@skylord123/node-red-pebble-timeline 1.0.0 → 1.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skylord123/node-red-pebble-timeline",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Node-RED nodes for interacting with the Pebble Timeline API",
   "keywords": [
     "node-red",

package/pebble-timeline-add.js

@@ -288,7 +288,7 @@ module.exports = function(RED) {
                         node.status({fill: "green", shape: "dot", text: "OK"});
 
                         // Store the pin in our local storage
-                        storePin(pin);
+                        storePin(pin, timelineToken);
 
                         // Prepare the output message
                         msg.payload = {
@@ -336,8 +336,15 @@ module.exports = function(RED) {
         });
 
         // Helper to store a pin in local storage
-        function storePin(pin) {
-            const timelineToken = tokenOverride || configNode.credentials.timelineToken;
+        function storePin(pin, timelineToken) {
+            // Ensure we have a valid token
+            if (!timelineToken) {
+                node.warn("Cannot store pin: No valid timeline token provided");
+                return;
+            }
+
+            // Convert token to string to ensure it can be used as an object key
+            timelineToken = String(timelineToken);
 
             // Initialize the token's pins array if it doesn't exist
             if (!pinsData[timelineToken]) {
@@ -368,21 +375,40 @@ module.exports = function(RED) {
         function cleanupOldPins() {
             const oneMonthAgo = new Date();
             oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1);
+            let changed = false;
 
             // Iterate through all tokens
             Object.keys(pinsData).forEach(token => {
+                // Make sure the token's data is an array
+                if (!Array.isArray(pinsData[token])) {
+                    pinsData[token] = [];
+                    return;
+                }
+
                 // Filter out pins older than 1 month
                 const initialCount = pinsData[token].length;
                 pinsData[token] = pinsData[token].filter(pin => {
-                    const storedDate = new Date(pin._stored);
-                    return storedDate >= oneMonthAgo;
+                    // Make sure pin has _stored property
+                    if (!pin || !pin._stored) return false;
+
+                    try {
+                        const storedDate = new Date(pin._stored);
+                        return storedDate >= oneMonthAgo;
+                    } catch (e) {
+                        // If date parsing fails, remove the pin
+                        return false;
+                    }
                 });
 
                 // Log if pins were removed
                 if (pinsData[token].length < initialCount) {
                     node.debug(`Removed ${initialCount - pinsData[token].length} old pins for token ${token.substring(0, 8)}...`);
+                    changed = true;
                 }
             });
+
+            // No need to save here as the calling function will save the file
+            return changed;
         }
 
         // Apply node configuration to the pin

package/pebble-timeline-delete.js

@@ -102,7 +102,7 @@ module.exports = function(RED) {
                     node.status({fill: "green", shape: "dot", text: "Pin deleted"});
 
                     // Remove the pin from our local storage
-                    removePin(pinId);
+                    removePin(pinId, timelineToken);
 
                     // Prepare the output message
                     msg.payload = {
@@ -133,8 +133,15 @@ module.exports = function(RED) {
         });
 
         // Helper to remove a pin from local storage
-        function removePin(pinId) {
-            const timelineToken = node.tokenOverride || configNode.credentials.timelineToken;
+        function removePin(pinId, timelineToken) {
+            // Ensure we have a valid token
+            if (!timelineToken) {
+                node.warn("Cannot remove pin: No valid timeline token provided");
+                return;
+            }
+
+            // Convert token to string to ensure it can be used as an object key
+            timelineToken = String(timelineToken);
 
             // Check if this token has any pins
             if (!pinsData[timelineToken]) {
@@ -145,8 +152,7 @@ module.exports = function(RED) {
             const initialCount = pinsData[timelineToken].length;
             pinsData[timelineToken] = pinsData[timelineToken].filter(p => p.id !== pinId);
 
-            // Clean up old pins (older than 1 month) from all tokens
-            cleanupOldPins();
+            // Note: Cleanup of old pins is handled in the add node
 
             // Only write if we actually removed something
             if (pinsData[timelineToken].length !== initialCount) {
@@ -158,27 +164,6 @@ module.exports = function(RED) {
             }
         }
 
-        // Helper to clean up pins older than 1 month
-        function cleanupOldPins() {
-            const oneMonthAgo = new Date();
-            oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1);
-
-            // Iterate through all tokens
-            Object.keys(pinsData).forEach(token => {
-                // Filter out pins older than 1 month
-                const initialCount = pinsData[token].length;
-                pinsData[token] = pinsData[token].filter(pin => {
-                    const storedDate = new Date(pin._stored);
-                    return storedDate >= oneMonthAgo;
-                });
-
-                // Log if pins were removed
-                if (pinsData[token].length < initialCount) {
-                    node.debug(`Removed ${initialCount - pinsData[token].length} old pins for token ${token.substring(0, 8)}...`);
-                }
-            });
-        }
-
         node.on('close', function() {
             // Clean up any resources
         });

package/pebble-timeline-list.js

@@ -105,11 +105,20 @@ module.exports = function(RED) {
                     }
 
                     // Get the timeline token to use
-                    const timelineToken = tokenOverride || configNode.credentials.timelineToken;
+                    let timelineToken = tokenOverride || configNode.credentials.timelineToken;
+
+                    // Ensure we have a valid token
+                    if (!timelineToken) {
+                        node.warn("No valid timeline token provided");
+                        timelineToken = "default"; // Use a default key to avoid errors
+                    }
+
+                    // Convert token to string to ensure it can be used as an object key
+                    timelineToken = String(timelineToken);
 
                     // Get pins for this token only
                     let pins = [];
-                    if (pinsData[timelineToken]) {
+                    if (pinsData[timelineToken] && Array.isArray(pinsData[timelineToken])) {
                         pins = pinsData[timelineToken];
                     }
 
@@ -134,8 +143,7 @@ module.exports = function(RED) {
                         return include;
                     });
 
-                    // Clean up old pins (older than 1 month) from all tokens
-                    cleanupOldPins(pinsData);
+                    // Note: Cleanup of old pins is handled in the add node
 
                     // Create output message
                     msg.payload = filteredPins;
@@ -152,38 +160,6 @@ module.exports = function(RED) {
                 });
         });
 
-        // Helper to clean up pins older than 1 month
-        function cleanupOldPins(pinsData) {
-            const oneMonthAgo = new Date();
-            oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1);
-            let changed = false;
-
-            // Iterate through all tokens
-            Object.keys(pinsData).forEach(token => {
-                // Filter out pins older than 1 month
-                const initialCount = pinsData[token].length;
-                pinsData[token] = pinsData[token].filter(pin => {
-                    const storedDate = new Date(pin._stored);
-                    return storedDate >= oneMonthAgo;
-                });
-
-                // Log if pins were removed
-                if (pinsData[token].length < initialCount) {
-                    node.debug(`Removed ${initialCount - pinsData[token].length} old pins for token ${token.substring(0, 8)}...`);
-                    changed = true;
-                }
-            });
-
-            // Save the updated pins data if any pins were removed
-            if (changed) {
-                try {
-                    fs.writeFileSync(pinsFile, JSON.stringify(pinsData, null, 2));
-                } catch (error) {
-                    node.warn(`Error saving pins to file: ${error.message}`);
-                }
-            }
-        }
-
         node.on('close', function() {
             // Clean up any resources
         });