@skyhook-io/radar-app 1.9.3 → 1.9.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyhook-io/radar-app",
-  "version": "1.9.3",
+  "version": "1.9.5",
   "description": "Radar's full web UI as a reusable React component. Used by Radar's own binary and by external consumers like Radar Cloud.",
   "repository": {
     "type": "git",

package/src/App.tsx

@@ -9,7 +9,7 @@ import { DebugOverlay } from './components/DebugOverlay'
 import { GlobalDiagnoseButton } from './components/diagnose/LocalDiagnoseAction'
 import { useDiagnoseLayout } from './components/diagnose/DiagnoseContext'
 import { DiagnoseSurface } from './components/diagnose/DiagnoseSurface'
-import { TopologyGraph, TopologySearch, TopologyBreadcrumb, TopologyFilterSidebar, TopologyControls, FreshnessControl, gitOpsRouteForKind, gitOpsRouteForResource, ScopePill, PaneLoader } from '@skyhook-io/k8s-ui'
+import { TopologyGraph, TopologySearch, TopologyBreadcrumb, TopologyFilterSidebar, TopologyControls, FreshnessControl, gitOpsRouteForKind, gitOpsRouteForResource, ScopePill, PaneLoader, assetUrl } from '@skyhook-io/k8s-ui'
 import { initNavigationMap } from '@skyhook-io/k8s-ui/utils/navigation'
 import { useAPIResources, findAPIResourceForRoute } from './api/apiResources'
 import { TimelineView } from './components/timeline/TimelineView'
@@ -33,6 +33,7 @@ import { DockProvider, BottomDock, useDock, useDockReservedHeight, useOpenLocalT
 import { DURATION_DOCK } from '@skyhook-io/k8s-ui/utils/animation'
 import { ContextSwitcher } from './components/ContextSwitcher'
 import { NamespaceSwitcher, type NamespaceSwitcherHandle } from './components/NamespaceSwitcher'
+import { CloudFunnelButton } from './components/CloudFunnelButton'
 import { useNavCustomization } from './context/NavCustomization'
 import type { FleetTakeoverTarget } from './context/NavCustomization'
 import { PrimaryNavRail } from './components/nav/PrimaryNavRail'
@@ -68,6 +69,8 @@ import { type OmnibarHandle } from './components/ui/Omnibar'
 import { RadarOmnibar } from './components/ui/RadarOmnibar'
 import type { ContextSwitcherHandle } from './components/ContextSwitcher'
 
+const radarLogoUrl = assetUrl('/images/radar/radar-icon.svg')
+
 // All possible node kinds (core + GitOps)
 const ALL_NODE_KINDS: NodeKind[] = [
   'Internet', 'Ingress', 'Gateway', 'HTTPRoute', 'GRPCRoute', 'TCPRoute', 'TLSRoute',
@@ -145,6 +148,8 @@ function getViewFromPath(pathname: string): ExtendedMainView {
 //     breakdown; a filter would only hide rows).
 //   - A GitOps detail tree spans namespaces — its controller lives in one
 //     namespace but manages workloads across many.
+//   - Upgrade impact evaluates the full readable cluster scope rather than a
+//     browsing filter.
 //   - A cluster-scoped resource kind (Nodes, PVs, ClusterRoles…) has no
 //     namespace at all.
 // The pick itself is preserved so it re-applies when the user returns to a
@@ -170,6 +175,12 @@ function namespaceFilterDisabled(
       tooltip: 'Capacity is reported across the cluster — the namespace filter doesn’t apply here.',
     }
   }
+  if (view === 'checks' && pathname.startsWith('/checks/upgrade')) {
+    return {
+      disabled: true,
+      tooltip: 'Upgrade impact scans every namespace you can access — the namespace filter doesn’t apply.',
+    }
+  }
   const segments = pathname.replace(/^\//, '').split('/')
   if (view === 'gitops' && segments[1] === 'detail') {
     return {
@@ -233,6 +244,8 @@ function radarPageTitle(pathname: string, search = '', apiResources?: APIResourc
     return slash >= 0 && slash < decoded.length - 1 ? decoded.slice(slash + 1) : decoded
   }
 
+  if (view === 'checks' && pathSegments[1] === 'upgrade') return 'Upgrade impact'
+
   // The landing view reads "Overview" rather than "Home" in the tab.
   if (view === 'capacity') {
     if (pathSegments[1] === 'pools') return decode(pathSegments[2] ?? '') || 'Capacity'
@@ -401,6 +414,7 @@ function AppInner({ manageDocumentTitle = false, documentTitleSuffix, onClusterL
 
   // Get mainView from URL path
   const mainView = getViewFromPath(location.pathname)
+  const upgradeReadinessRoute = location.pathname.startsWith('/checks/upgrade')
 
   // Initialize the kind→plural discovery map app-wide (not just on ResourcesView
   // mount) so the omnibar can open a CRD hit with an irregular plural from any
@@ -485,7 +499,7 @@ function AppInner({ manageDocumentTitle = false, documentTitleSuffix, onClusterL
   // The host's URL for the CURRENT view, if taken over. Drives the redirect
   // effect and the "Opening…" splash.
   const viewTakeoverHref =
-    mainView === 'issues' || mainView === 'gitops' || mainView === 'checks'
+    (mainView === 'issues' || mainView === 'gitops' || mainView === 'checks') && !upgradeReadinessRoute
       ? takeover[mainView]
       : undefined
   useEffect(() => {
@@ -698,6 +712,7 @@ function AppInner({ manageDocumentTitle = false, documentTitleSuffix, onClusterL
     newParams.delete('kind')
     newParams.delete('mode')
     newParams.delete('group')
+    newParams.delete('target')
     // Open as a normal drawer — never inherit a stale ?full=1/tab from an
     // expanded view we're navigating away from (only expand/drill set those).
     newParams.delete('full')
@@ -1866,6 +1881,11 @@ function AppInner({ manageDocumentTitle = false, documentTitleSuffix, onClusterL
           {/* AI investigations (self-hides when no agent CLI is present) */}
           <GlobalDiagnoseButton />
 
+          {/* Radar Cloud funnel — OSS-only chrome, same gate as the star.
+              Cloud embeds render chromeless anyway; the explicit gate is
+              belt-and-braces for future chrome-bearing embedders. */}
+          {!navCustomization.embedded && <CloudFunnelButton />}
+
           {/* Local terminal */}
           {capabilities.localTerminal && (
             <Tooltip content="Open local terminal">
@@ -2285,9 +2305,9 @@ function AppInner({ manageDocumentTitle = false, documentTitleSuffix, onClusterL
           />
         )}
 
-        {/* Best practices detail view (inline only when the host hasn't taken
-            Checks over — standalone OSS, or Cloud without a checks takeover). */}
-        {mainView === 'checks' && !isViewTakenOver('checks') && (
+        {/* Checks detail view. Cloud can take over fleet best practices while
+            the target-specific upgrade route continues to render locally. */}
+        {mainView === 'checks' && (!isViewTakenOver('checks') || upgradeReadinessRoute) && (
           <AuditView
             namespaces={namespaces}
             onNavigateToResource={navigateToResourceList}
@@ -2554,7 +2574,7 @@ function Logo() {
     <div className="flex items-center gap-2.5">
       <div className="relative w-7 h-7 rounded-lg overflow-hidden flex-shrink-0 bg-emerald-500/10 border border-emerald-500/20">
         <img
-          src="/images/radar/radar-icon.svg"
+          src={radarLogoUrl}
           alt=""
           aria-hidden
           className="w-full h-full p-0.5"

package/src/api/client.ts

@@ -391,6 +391,61 @@ export interface AuditResponse {
   groupedChecks?: Check[];
 }
 
+export type UpgradeReadinessVerdict = 'blocked' | 'warning' | 'review' | 'no_known_blockers' | 'unknown'
+export type UpgradeReadinessLevel = 'blocker' | 'warning' | 'review'
+export type UpgradeReadinessCheckStatus = 'passed' | 'blocked' | 'warning' | 'review' | 'unknown' | 'not_applicable'
+
+export interface UpgradeReadinessResourceRef {
+  group?: string
+  kind: string
+  namespace: string
+  name: string
+}
+
+export interface UpgradeReadinessFinding {
+  ruleID: string
+  title: string
+  level: UpgradeReadinessLevel
+  resource?: UpgradeReadinessResourceRef
+  managedBy?: UpgradeReadinessResourceRef
+  evidence: { source: string; path: string; detail?: string }
+  appliesFrom?: string
+  impact: string
+  remediation: string
+  references: { title: string; url: string }[]
+}
+
+export interface UpgradeReadinessCheck {
+  id: string
+  category: string
+  title: string
+  status: UpgradeReadinessCheckStatus
+  summary: string
+  evidenceNote?: string
+  caveat?: string
+  scope: string
+  inspected?: number
+  appliesFrom?: string
+  findings: UpgradeReadinessFinding[]
+  references?: { title: string; url: string }[]
+}
+
+export interface UpgradeReadinessResponse {
+  currentVersion: string
+  targetVersion: string
+  reviewedThrough: string
+  verdict: UpgradeReadinessVerdict
+  summary: { blocked: number; warnings: number; reviews: number; passed: number; unknown: number; notApplicable: number; findings: number }
+  checks: UpgradeReadinessCheck[]
+  coverage: {
+    source: 'live'
+    state: 'complete' | 'partial' | 'no_access'
+    unavailableKinds?: string[]
+    scopedNamespaces?: string[]
+    scopedKinds?: Record<string, string[]>
+  }
+}
+
 export interface DashboardCertificateHealth {
   total: number;
   healthy: number;
@@ -486,6 +541,18 @@ export function useAudit(namespaces: string[] = []) {
   });
 }
 
+export function useUpgradeReadiness(target?: string) {
+  const params = new URLSearchParams()
+  if (target) params.set('target', target)
+  const query = params.toString()
+  return useQuery<UpgradeReadinessResponse>({
+    queryKey: ['upgrade-readiness', target ?? 'next'],
+    queryFn: ({ signal }) => fetchJSON(`/upgrade-readiness${query ? `?${query}` : ''}`, signal),
+    staleTime: 30000,
+    placeholderData: (previous) => previous,
+  })
+}
+
 // Live cluster Issues — the grouped triage queue (radar's /api/issues =
 // internal/issues.Compose+Classify+Group). Single-cluster here; the Hub fleet
 // view fans the same shape across clusters. Do not carry old data across query
@@ -1478,6 +1545,190 @@ export function useCapabilities() {
   });
 }
 
+// ============================================================================
+// In-product Cloud Connect (driver lane)
+// ============================================================================
+
+export interface CloudInstallRecoveryGuidance {
+  summary: string
+  lines?: string[]
+  inspect?: string[]
+  clusterUrl?: string
+}
+
+export interface CloudInstallPlanSummary {
+  mode: 'fresh' | 'adopt'
+  contextName: string
+  namespace: string
+  release: string
+  defaultClusterName: string
+  targetChartVersion: string
+  targetAppVersion: string
+  currentChartVersion?: string
+  currentRevision?: number
+  currentImageTag?: string
+  preservedImageRepository?: string
+  uncertainty?: string
+  advisories?: string[]
+  sharedListener?: boolean
+}
+
+export interface CloudInstallConnected {
+  clusterId: string
+  clusterUrl: string
+  trackCommand: string
+  rollback?: CloudInstallRecoveryGuidance
+}
+
+export interface CloudInstallFailure {
+  kind: string
+  message: string
+  guidance?: CloudInstallRecoveryGuidance
+  retrySafe: boolean
+}
+
+export interface CloudInstallBlocked {
+  reason: 'gitops' | 'preflight' | 'unsupported'
+  message: string
+  blocking?: string[]
+}
+
+export type CloudInstallState =
+  | 'idle'
+  | 'preparing'
+  | 'ready'
+  | 'starting'
+  | 'awaiting_approval'
+  | 'provisioning'
+  | 'waiting_tunnel'
+  | 'connected'
+  | 'failed'
+  | 'blocked'
+
+export interface CloudInstallStatus {
+  flowId?: string
+  state: CloudInstallState
+  plan?: CloudInstallPlanSummary
+  clusterName?: string
+  connectUrl?: string
+  connected?: CloudInstallConnected
+  failure?: CloudInstallFailure
+  blocked?: CloudInstallBlocked
+}
+
+export const cloudInstallActive = (state: CloudInstallState | undefined): boolean =>
+  state === 'preparing' ||
+  state === 'ready' ||
+  state === 'starting' ||
+  state === 'awaiting_approval' ||
+  state === 'provisioning' ||
+  state === 'waiting_tunnel';
+
+// Poll while a flow is live so progress renders in near-real-time; the flow
+// itself is server-owned, so this hook merely observes (and re-attaches after
+// a page reload). gcTime 0: never cache connect-flow payloads.
+// What the Hub says about connecting to it. Fetched from the Hub itself, not
+// from Radar's API, so the dialog states current terms instead of whatever was
+// compiled into this binary months ago — a stale free-tier claim is a promise
+// Radar can't keep. Every field is optional and falls back per-field, so a Hub
+// that doesn't serve this (self-hosted, older, offline) renders exactly what
+// Radar renders today.
+export interface CloudConnectInfo {
+  assurances?: string[]
+  notice?: string
+}
+
+// Deliberately a bare cross-origin GET: no credentials, no identifiers, no
+// params. The Hub learns only what any HTTP request reveals.
+export function useCloudConnectInfo(apiUrl: string | undefined, enabled: boolean) {
+  return useQuery<CloudConnectInfo>({
+    queryKey: ["cloud-connect-info", apiUrl],
+    queryFn: async () => {
+      const res = await fetch(`${apiUrl}/api/connect/info`, {
+        credentials: "omit",
+        signal: AbortSignal.timeout(4000),
+      });
+      if (!res.ok) throw new Error(`connect info: ${res.status}`);
+      return res.json();
+    },
+    // No apiUrl means the server decided this deployment must not fetch.
+    enabled: enabled && !!apiUrl,
+    staleTime: 5 * 60 * 1000,
+    retry: false,
+  });
+}
+
+export function useCloudInstallStatus(enabled: boolean) {
+  const queryClient = useQueryClient()
+  const query = useQuery<CloudInstallStatus>({
+    queryKey: ['cloud-install-status'],
+    queryFn: () => fetchJSON('/cloud/install/status'),
+    enabled,
+    gcTime: 0,
+    staleTime: 0,
+    refetchInterval: (q) => (cloudInstallActive(q.state.data?.state) ? 1500 : false),
+  })
+  return {
+    ...query,
+    invalidate: () => queryClient.invalidateQueries({ queryKey: ['cloud-install-status'] }),
+  }
+}
+
+// In-cluster Radar describing its own installation, so the modal can route to
+// the right handoff instead of a generic signup link.
+export interface CloudConnectSelf {
+  ownership: 'helm' | 'gitops' | 'ambiguous' | 'unknown'
+  namespace?: string
+  release?: string
+  deploymentName?: string
+  chart?: string
+  controller?: string
+  wizardUrl?: string
+}
+
+export function useCloudConnectSelf(enabled: boolean) {
+  return useQuery<CloudConnectSelf>({
+    queryKey: ['cloud-connect-self'],
+    queryFn: () => fetchJSON('/cloud/connect/self'),
+    enabled,
+    staleTime: 60000,
+  })
+}
+
+export function prepareCloudInstall(): Promise<CloudInstallStatus> {
+  return fetchJSON('/cloud/install/prepare', { method: 'POST' })
+}
+
+export function startCloudInstall(body: {
+  flowId: string
+  clusterName: string
+  acceptAdoption?: boolean
+  acknowledgeIncompleteDiscovery?: boolean
+  acknowledgeSharedListener?: boolean
+}): Promise<CloudInstallStatus> {
+  return fetchJSON('/cloud/install/start', {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify(body),
+  })
+}
+
+export function cancelCloudInstall(flowId: string): Promise<CloudInstallStatus> {
+  return fetchJSON('/cloud/install/cancel', {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ flowId }),
+  })
+}
+
+export function dismissCloudInstall(flowId: string): Promise<CloudInstallStatus> {
+  return fetchJSON('/cloud/install/dismiss', {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ flowId }),
+  })
+}
+
 // Namespace-scoped capabilities. Users with namespace-scoped RoleBindings may
 // have these permissions in specific namespaces.
 export function useNamespaceCapabilities(

package/src/api/config.test.ts

@@ -40,6 +40,25 @@ describe('stripBasename', () => {
     expect(stripBasename('/c/abcdef/resources')).toBe('/c/abcdef/resources')
   })
 
+  // Standalone Radar sets a basename too once --base-path is configured, so the
+  // session-expiry return path round-trips through this in a new shape. Store
+  // strips once (client.ts) and restore strips again defensively (App.tsx) before
+  // navigate() re-applies the basename — the net effect must be the original
+  // route, never a doubled one.
+  it('round-trips a return path under a base path without doubling', () => {
+    setBasename('/radar')
+    const stored = stripBasename('/radar/resources/pods') + '?namespaces=prod'
+    expect(stored).toBe('/resources/pods?namespaces=prod')
+    // Restore side strips a second time; already-relative values are untouched.
+    expect(stripBasename(stored)).toBe('/resources/pods?namespaces=prod')
+  })
+
+  it('leaves a nested base path return path relative', () => {
+    setBasename('/tools/radar')
+    expect(stripBasename('/tools/radar/topology')).toBe('/topology')
+    expect(stripBasename(stripBasename('/tools/radar/topology'))).toBe('/topology')
+  })
+
   it('inverts routePath', () => {
     setBasename('/c/abc')
     expect(stripBasename(routePath('/auth/login'))).toBe('/auth/login')