@skyhook-io/radar-app 1.9.0 → 1.9.2

package/src/components/diagnose/LocalDiagnoseAction.tsx

@@ -1,5 +1,9 @@
 import { Loader2, Sparkles } from "lucide-react";
-import { useDiagnose, useDiagnoseLayout, runTargetKey } from "./DiagnoseContext";
+import {
+  useDiagnose,
+  useDiagnoseLayout,
+  runTargetKey,
+} from "./DiagnoseContext";
 import { Tooltip } from "../ui/Tooltip";
 import type { RenderDiagnoseAction } from "../../context/DiagnoseCustomization";
 
@@ -27,31 +31,41 @@ function DiagnoseResourceButton({
 }) {
   const d = useDiagnose();
   const { runningKeys } = useDiagnoseLayout();
-  if (!d.available) return null;
+  // Hidden only when the feature can't work here (auth/cloud/--no-mcp). When it's
+  // supported but no agent is installed we KEEP the button — clicking opens the
+  // setup notice so the feature is discoverable rather than silently absent.
+  if (d.setupState === "off") return null;
+  const ready = d.available;
   const problem = health === "problem";
-  const running = runningKeys.has(runTargetKey(kind, namespace, name));
-  const tooltip = running
-    ? `${d.agentLabel} is investigating this resource — click to watch it live.`
-    : d.hosted
-      ? problem
-        ? `Diagnose with ${d.agentLabel} — reads this resource's spec, events & logs to find the root cause.`
-        : `Ask ${d.agentLabel} about this resource — reads its spec, events & logs.`
-      : problem
-        ? `Diagnose with your own ${d.agentLabel} — runs locally, reads this resource's spec, events & logs to find the root cause.`
-        : `Ask your own ${d.agentLabel} about this resource — runs locally, reads its spec, events & logs.`;
+  const running = ready && runningKeys.has(runTargetKey(kind, namespace, name));
+  const tooltip = !ready
+    ? "Set up AI diagnosis to investigate this — runs your own agent locally."
+    : running
+      ? `${d.agentLabel} is investigating this resource — click to watch it live.`
+      : d.hosted
+        ? problem
+          ? `Diagnose with ${d.agentLabel} — reads this resource's spec, events & logs to find the root cause.`
+          : `Ask ${d.agentLabel} about this resource — reads its spec, events & logs.`
+        : problem
+          ? `Diagnose with your own ${d.agentLabel} — runs locally, reads this resource's spec, events & logs to find the root cause.`
+          : `Ask your own ${d.agentLabel} about this resource — runs locally, reads its spec, events & logs.`;
   // While an investigation is live, the button advertises it (and clicking focuses
   // the existing run rather than starting a new one — openInvestigation dedups).
   const showLabel = problem || running;
   return (
     <Tooltip content={tooltip} position="bottom">
       <button
-        onClick={() => d.openInvestigation({ kind, namespace, name })}
+        onClick={() =>
+          ready ? d.openInvestigation({ kind, namespace, name }) : d.openHome()
+        }
         aria-label={
-          running
-            ? "Investigation running — click to view"
-            : problem
-              ? "Diagnose with AI"
-              : "Ask AI about this resource"
+          !ready
+            ? "Set up AI diagnosis"
+            : running
+              ? "Investigation running — click to view"
+              : problem
+                ? "Diagnose with AI"
+                : "Ask AI about this resource"
         }
         className={
           showLabel
@@ -97,20 +111,26 @@ export function IssueDiagnoseButton({
   name: string;
 }) {
   const d = useDiagnose();
-  if (!d.available) return null;
+  if (d.setupState === "off") return null;
+  const ready = d.available;
   return (
     <Tooltip
       content={
-        d.hosted
-          ? `Sends this resource's context to ${d.agentLabel} to find the root cause`
-          : `Runs ${d.agentLabel} on your machine and sends it this resource's context to find the root cause`
+        d.setupState === "needs-restart"
+          ? "Restart Radar to enable AI diagnosis — a supported agent is installed"
+          : !ready
+            ? "Set up AI diagnosis — install a local agent to investigate"
+            : d.hosted
+              ? `Sends this resource's context to ${d.agentLabel} to find the root cause`
+              : `Runs ${d.agentLabel} on your machine and sends it this resource's context to find the root cause`
       }
       position="left"
     >
       <button
         onClick={(e) => {
           e.stopPropagation();
-          d.openInvestigation({ kind, namespace, name });
+          if (ready) d.openInvestigation({ kind, namespace, name });
+          else d.openHome();
         }}
         className="flex shrink-0 items-center gap-1 rounded-md border border-theme-border px-2 py-1 text-xs text-theme-text-secondary hover:bg-theme-hover hover:text-theme-text-primary"
       >
@@ -126,7 +146,8 @@ export function IssueDiagnoseButton({
 export function GlobalDiagnoseButton() {
   const d = useDiagnose();
   const { runningKeys } = useDiagnoseLayout();
-  if (!d.available) return null;
+  if (d.setupState === "off") return null;
+  const ready = d.available;
   const runningCount = runningKeys.size;
   const agentSuffix = d.hosted
     ? `powered by ${d.agentLabel}`
@@ -134,9 +155,11 @@ export function GlobalDiagnoseButton() {
   return (
     <Tooltip
       content={
-        runningCount > 0
-          ? `${runningCount} investigation${runningCount > 1 ? "s" : ""} running — ${agentSuffix}`
-          : `AI investigations — ${agentSuffix}`
+        !ready
+          ? "Set up AI investigations — runs your own agent locally"
+          : runningCount > 0
+            ? `${runningCount} investigation${runningCount > 1 ? "s" : ""} running — ${agentSuffix}`
+            : `AI investigations — ${agentSuffix}`
       }
       position="bottom"
     >

package/src/components/diagnose/agentCatalog.ts

@@ -0,0 +1,30 @@
+// Install metadata for the agent CLIs Radar can drive. Used by the setup notice
+// shown when AI diagnosis is eligible but no agent is installed. Names match the
+// backend's supported set (see internal/ai/detect.go knownAgents + isSupportedAgent).
+export interface AgentInstall {
+  name: string; // stable id, matches AgentInfo.name
+  label: string; // display name
+  install: string; // one-line install command
+  docs: string; // canonical setup/docs URL
+}
+
+export const SUPPORTED_AGENTS: AgentInstall[] = [
+  {
+    name: "claude",
+    label: "Claude Code",
+    install: "npm install -g @anthropic-ai/claude-code",
+    docs: "https://docs.claude.com/en/docs/claude-code/setup",
+  },
+  {
+    name: "codex",
+    label: "Codex",
+    install: "npm install -g @openai/codex",
+    docs: "https://github.com/openai/codex",
+  },
+  {
+    name: "cursor-agent",
+    label: "Cursor CLI",
+    install: "curl https://cursor.com/install -fsS | bash",
+    docs: "https://docs.cursor.com/en/cli/overview",
+  },
+];

package/src/components/diagnose/parts.test.tsx

@@ -0,0 +1,125 @@
+import { renderToStaticMarkup } from "react-dom/server";
+import { describe, expect, it, vi } from "vitest";
+import { AgentControls, ConsentCard } from "./parts";
+import type { AgentInfo, ExecutionProfile } from "../../api/diagnose";
+
+const noop = vi.fn();
+
+function renderAgent(
+  agent: string,
+  profiles: ExecutionProfile[],
+  profile: ExecutionProfile,
+) {
+  const agents: AgentInfo[] = [
+    {
+      name: agent,
+      label: agent,
+      path: agent,
+      version: "",
+      present: true,
+      supported: true,
+      profiles,
+    },
+  ];
+  return renderToStaticMarkup(
+    <AgentControls
+      agents={agents}
+      selectedAgent={agent}
+      onSelectAgent={noop}
+      profile={profile}
+      onSetProfile={noop}
+      model=""
+      onSetModel={noop}
+      effort=""
+      onSetEffort={noop}
+    />,
+  );
+}
+
+describe("AgentControls execution profile explanation", () => {
+  it("shows Cursor's fixed full-local warning even when the stored profile is stale", () => {
+    const html = renderAgent("cursor-agent", ["full-local"], "safeguarded");
+    expect(html).toContain("must use this agent");
+    expect(html).toContain("normal setup");
+    expect(html).toContain("always loads your global MCP servers");
+    expect(html).toContain("still enables the agent CLI");
+    expect(html).toContain("does not constrain external MCP servers");
+    expect(html).not.toContain("always runs this agent with safeguards");
+  });
+
+  it("discloses the Claude configuration that Radar cannot exclude", () => {
+    const html = renderAgent(
+      "claude",
+      ["safeguarded", "full-local"],
+      "safeguarded",
+    );
+    expect(html).toContain("built-in tools are disabled");
+    expect(html).toContain("settings, hooks, and CLAUDE.md instructions still apply");
+    expect(html).toContain("Your claude setup");
+    expect(html).not.toContain("other agent configuration is excluded");
+  });
+
+  it("explains that Claude full-local inherits the user's permissions", () => {
+    const html = renderAgent(
+      "claude",
+      ["safeguarded", "full-local"],
+      "full-local",
+    );
+    expect(html).toContain("permissions from your setup");
+    expect(html).toContain("Radar does not override them");
+    expect(html).not.toContain("Radar still enables the agent CLI");
+  });
+
+  it("does not describe an unknown safeguarded agent as Codex", () => {
+    const html = renderAgent("future-agent", ["safeguarded"], "safeguarded");
+    expect(html).toContain("documented restrictions");
+    expect(html).not.toContain("Codex");
+    expect(html).not.toContain("built-in tools are disabled");
+  });
+
+  it("labels the selectable full-local profile as the user's agent setup", () => {
+    const html = renderAgent(
+      "codex",
+      ["safeguarded", "full-local"],
+      "safeguarded",
+    );
+    expect(html).toContain("Your codex setup");
+    expect(html).not.toContain("Full local setup");
+  });
+});
+
+describe("ConsentCard execution profile treatment", () => {
+  it("uses warning chrome and explicit consequences for the user's agent setup", () => {
+    const html = renderToStaticMarkup(
+      <ConsentCard
+        agentName="Cursor Agent"
+        agent="cursor-agent"
+        profile="full-local"
+        onApprove={noop}
+        onCancel={noop}
+      />,
+    );
+    expect(html).toContain("Run using your Cursor Agent setup?");
+    expect(html).toContain("Continue with my agent setup");
+    expect(html).toContain("border-amber-500/40");
+    expect(html).toContain("text-amber-500");
+    expect(html).toContain("Radar cannot constrain");
+    expect(html).toContain("always loads your global MCP servers");
+    expect(html).not.toContain("text-accent");
+  });
+
+  it("does not claim Radar enables a sandbox for Claude's normal setup", () => {
+    const html = renderToStaticMarkup(
+      <ConsentCard
+        agentName="Claude Code"
+        agent="claude"
+        profile="full-local"
+        onApprove={noop}
+        onCancel={noop}
+      />,
+    );
+    expect(html).toContain("permissions from your setup");
+    expect(html).toContain("Radar does not override them");
+    expect(html).not.toContain("Radar still enables the agent CLI");
+  });
+});

package/src/components/diagnose/parts.tsx

@@ -27,13 +27,14 @@ import {
   type Diagnosis,
   type DiagnoseStep,
   type AgentInfo,
+  type ExecutionProfile,
   type RunSummary,
 } from "../../api/diagnose";
 import { StatusDot } from "@skyhook-io/k8s-ui";
 import { Markdown } from "../ui/Markdown";
 
-// Segmented two-or-more-way selector — shared shape for the agent picker and the
-// isolation toggle.
+// Segmented two-or-more-way selector — shared shape for the agent and execution
+// profile pickers.
 function Segmented<T extends string | boolean>({
   label,
   options,
@@ -228,15 +229,15 @@ function SelectMenu({
   );
 }
 
-// AgentControls is the full AI-diagnosis config block (agent, isolation, model,
+// AgentControls is the full AI-diagnosis config block (agent, execution profile, model,
 // effort) — pure + prop-driven. It lives in Settings, not the investigation panel,
 // since these are set-once preferences rather than per-run knobs.
 export function AgentControls({
   agents,
   selectedAgent,
   onSelectAgent,
-  isolated,
-  onSetIsolated,
+  profile,
+  onSetProfile,
   model,
   onSetModel,
   effort,
@@ -245,8 +246,8 @@ export function AgentControls({
   agents: AgentInfo[];
   selectedAgent: string;
   onSelectAgent: (name: string) => void;
-  isolated: boolean;
-  onSetIsolated: (v: boolean) => void;
+  profile: ExecutionProfile;
+  onSetProfile: (v: ExecutionProfile) => void;
   model: string;
   onSetModel: (v: string) => void;
   effort: string;
@@ -255,6 +256,17 @@ export function AgentControls({
   const isCodex = selectedAgent === "codex";
   const isClaude = selectedAgent === "claude";
   const isCursor = selectedAgent === "cursor-agent";
+  const selectedAgentInfo = agents.find((a) => a.name === selectedAgent);
+  const selectedAgentLabel =
+    selectedAgentInfo?.label || selectedAgent || "agent";
+  const profiles = selectedAgentInfo?.profiles ?? [];
+  const shownProfile = profiles.includes(profile)
+    ? profile
+    : (profiles[0] ?? profile);
+  const profileLabels: Record<ExecutionProfile, string> = {
+    safeguarded: "Radar safeguards",
+    "full-local": `Your ${selectedAgentLabel} setup`,
+  };
   return (
     <div className="space-y-3">
       {agents.length >= 2 && (
@@ -268,29 +280,66 @@ export function AgentControls({
           }))}
         />
       )}
-      {isCodex && (
+      {profiles.length > 0 && (
         <div>
-          <Segmented<boolean>
-            label="Environment"
-            value={isolated}
-            onChange={onSetIsolated}
-            options={[
-              { value: true, label: "Isolated (recommended)" },
-              { value: false, label: "My setup" },
-            ]}
-          />
-          {isolated ? (
-            <p className="mt-1.5 text-[11px] leading-snug text-theme-text-tertiary">
-              Runs Codex on its own — no access to your other MCP servers,
-              guidelines, or project files.
-            </p>
+          {profiles.length > 1 ? (
+            <>
+              <Segmented<ExecutionProfile>
+                label="How Radar runs it"
+                value={shownProfile}
+                onChange={onSetProfile}
+                options={profiles.map((value) => ({
+                  value,
+                  label: profileLabels[value],
+                }))}
+              />
+              {shownProfile === "safeguarded" ? (
+                <p className="mt-1.5 text-[11px] leading-snug text-theme-text-tertiary">
+                  {isClaude
+                    ? "Claude’s built-in tools are disabled, and MCP access is limited to Radar’s read-only investigation tools. Your Claude settings, hooks, and CLAUDE.md instructions still apply and are outside Radar’s control."
+                    : isCodex
+                      ? "Radar excludes your Codex configuration and other MCP servers. Codex’s sandboxed shell can still read files on this machine; it cannot write or reach the network."
+                      : "Radar uses this agent’s safeguarded execution profile. Review the agent’s documented restrictions before continuing."}
+                </p>
+              ) : (
+                <div className="mt-1.5 flex items-start gap-1.5 rounded border border-amber-500/40 bg-amber-500/10 p-2 text-[11px] leading-snug text-theme-text-secondary">
+                  <AlertTriangle className="mt-0.5 h-3 w-3 shrink-0 text-amber-500" />
+                  <span>
+                    Uses your agent&apos;s normal configuration and other
+                    configured tools and MCP servers. Radar cannot constrain that
+                    external tooling; it may access local files or the network
+                    and may be able to change your cluster.{" "}
+                    {isClaude
+                      ? "Claude uses the permissions from your setup; Radar does not override them."
+                      : "Radar still enables the agent CLI’s own sandbox, but that sandbox does not constrain external MCP servers."}{" "}
+                    Choose this only when you need that setup.
+                  </span>
+                </div>
+              )}
+            </>
+          ) : shownProfile === "safeguarded" ? (
+            <div className="flex items-start gap-1.5 rounded border border-theme-border bg-theme-base p-2 text-[11px] leading-snug text-theme-text-secondary">
+              <ShieldCheck className="mt-0.5 h-3 w-3 shrink-0 text-accent" />
+              <span>
+                Radar always runs this agent with safeguards.
+                {isClaude
+                  ? " Claude’s built-in tools are disabled, and MCP access is limited to Radar’s read-only investigation tools. Your Claude settings, hooks, and CLAUDE.md instructions still apply and are outside Radar’s control."
+                  : isCodex
+                    ? " Your Codex configuration and other MCP servers are excluded. Codex’s sandboxed shell can still read files on this machine; it cannot write or reach the network."
+                    : " Review the agent’s documented restrictions before continuing."}
+              </span>
+            </div>
           ) : (
-            <div className="mt-1.5 flex items-start gap-1.5 rounded border border-amber-500/40 bg-amber-500/10 p-2 text-[11px] leading-snug text-theme-text-secondary">
+            <div className="flex items-start gap-1.5 rounded border border-amber-500/40 bg-amber-500/10 p-2 text-[11px] leading-snug text-theme-text-secondary">
               <AlertTriangle className="mt-0.5 h-3 w-3 shrink-0 text-amber-500" />
               <span>
-                Runs Codex with your full setup — your own MCP servers (which may
-                be write- or network-capable) and guidelines, and it can read
-                local files. Only choose this if you rely on that config.
+                Radar must use this agent&apos;s normal setup. Radar cannot
+                constrain its external tools or MCP servers; they may access
+                local files or the network and may be able to change your
+                cluster. Radar still enables the agent CLI&apos;s own sandbox,
+                but that sandbox does not constrain external MCP servers.
+                {isCursor &&
+                  " Cursor always loads your global MCP servers, so Radar cannot exclude them."}
               </span>
             </div>
           )}
@@ -304,7 +353,7 @@ export function AgentControls({
           onChange={onSetModel}
           hint="Aliases always resolve to the latest of that tier."
         />
-      ) : (
+      ) : isCodex || isCursor ? (
         <TextField
           label="Model"
           value={model}
@@ -317,11 +366,19 @@ export function AgentControls({
           hint={
             isCursor
               ? "Leave empty for your Cursor default, or enter a model slug Cursor supports."
-              : !isolated
-                ? "“My setup” uses your own Codex config's model; set a slug here to override it."
+              : shownProfile === "full-local"
+                ? "Your Codex setup uses its configured model; set a slug here to override it."
                 : "Leave empty for Codex's default, or enter a model your Codex version supports."
           }
         />
+      ) : (
+        <TextField
+          label="Model"
+          value={model}
+          placeholder="Default"
+          onChange={onSetModel}
+          hint="Leave empty for the agent's default, or enter a model identifier it supports."
+        />
       )}
       {isCodex && (
         <SelectMenu
@@ -591,10 +648,12 @@ function ConsentCardShell({
   bullets,
   settingsLabel,
   approveLabel = "Approve & investigate",
+  warning = false,
   onOpenSettings,
   onApprove,
   onCancel,
 }: DiagnoseConsentCopy & {
+  warning?: boolean;
   onOpenSettings?: () => void;
   onApprove: () => void;
   onCancel: () => void;
@@ -606,9 +665,19 @@ function ConsentCardShell({
       ? "Change the agent and how it runs in Settings"
       : settingsLabel;
   return (
-    <div className="rounded-lg border border-theme-border bg-theme-elevated p-4">
+    <div
+      className={
+        warning
+          ? "rounded-lg border border-amber-500/40 bg-amber-500/10 p-4"
+          : "rounded-lg border border-theme-border bg-theme-elevated p-4"
+      }
+    >
       <div className="mb-2 flex items-center gap-2">
-        <ShieldCheck className="h-4 w-4 text-accent" />
+        {warning ? (
+          <AlertTriangle className="h-4 w-4 text-amber-500" />
+        ) : (
+          <ShieldCheck className="h-4 w-4 text-accent" />
+        )}
         <div className="text-sm font-medium text-theme-text-primary">
           {title}
         </div>
@@ -660,7 +729,7 @@ function ConsentCardShell({
 export function ConsentCard({
   agentName,
   agent,
-  isolated = true,
+  profile,
   copy,
   onOpenSettings,
   onApprove,
@@ -668,7 +737,7 @@ export function ConsentCard({
 }: {
   agentName: string;
   agent?: string;
-  isolated?: boolean;
+  profile: ExecutionProfile;
   copy?: DiagnoseConsentCopy;
   onOpenSettings?: () => void;
   onApprove: () => void;
@@ -679,17 +748,19 @@ export function ConsentCard({
   // Tier 1: a host (e.g. radar-hub-web) supplied its own copy — use it verbatim.
   if (copy) return <ConsentCardShell {...copy} {...chrome} />;
 
-  // Tier 2: OSS BYO-local default. Cursor can't be isolated (no flag suppresses
-  // its global MCP servers), so it gets its own honest framing rather than the
-  // isolated/my-setup pair.
-  const isCursor = agent === "cursor-agent";
   return (
     <ConsentCardShell
       {...chrome}
+      warning={profile === "full-local"}
+      approveLabel={
+        profile === "full-local"
+          ? "Continue with my agent setup"
+          : "Approve & investigate"
+      }
       title={
-        isolated && !isCursor
-          ? "Run a read-only AI investigation?"
-          : "Run an AI investigation?"
+        profile === "safeguarded"
+          ? "Run an AI investigation with Radar safeguards?"
+          : `Run using your ${agentName} setup?`
       }
       body={
         <>
@@ -698,48 +769,68 @@ export function ConsentCard({
             your own {agentName}
           </span>{" "}
           on your machine — no Radar cloud, no API key, no account. Radar sends
-          this resource&apos;s spec, recent events, and pod logs to it (and on to
-          its model provider under your account, not to Radar). Transcripts are
-          kept in your local Radar history on this machine until cleared.
-          {isolated && !isCursor && (
+          this resource&apos;s spec, recent events, and pod logs to it (and on
+          to its model provider under your account, not to Radar). Transcripts
+          are kept in your local Radar history on this machine until cleared.
+          {profile === "safeguarded" && (
             <>
               {" "}
-              Through Radar the agent can only{" "}
-              <span className="font-medium">read</span> — it cannot change your
-              cluster.
+              Radar&apos;s investigation tools can only{" "}
+              <span className="font-medium">read</span> your cluster.
             </>
           )}
         </>
       }
-      bullets={[
-        isCursor ? (
-          <>
-            Through Radar the agent only{" "}
-            <span className="font-medium">reads</span> your cluster. But Cursor
-            also loads your own global MCP servers and Radar can&apos;t exclude
-            them (unlike Claude or Codex), so if any of those can make changes,
-            Cursor could use them.
-          </>
-        ) : isolated ? (
-          <>
-            Isolated: only Radar&apos;s read-only investigation tools — your
-            other CLI config and MCP servers are excluded.
-            {agent === "codex" && (
+      bullets={
+        profile === "safeguarded"
+          ? [
+              agent === "claude" ? (
+                <>
+                  Radar safeguards disable Claude&apos;s built-in tools and limit
+                  MCP access to Radar&apos;s read-only investigation tools. Your
+                  Claude settings, hooks, and CLAUDE.md instructions still apply
+                  and are outside Radar&apos;s control.
+                </>
+              ) : agent === "codex" ? (
+                <>
+                  Radar safeguards exclude your Codex configuration and other MCP
+                  servers. Codex&apos;s sandboxed shell can still read files on
+                  this machine; it cannot write or reach the network.
+                </>
+              ) : (
+                <>
+                  Radar uses this agent&apos;s safeguarded execution profile.
+                  Review the agent&apos;s documented restrictions before
+                  continuing.
+                </>
+              ),
+            ]
+          : [
               <>
-                {" "}
-                Codex&apos;s sandboxed shell can still <em>read</em> files on
-                your machine (it cannot write or reach the network).
-              </>
-            )}
-          </>
-        ) : (
-          <>
-            &ldquo;My setup&rdquo;: the agent also runs with your own CLI config
-            + MCP servers and can read local files. Only Radar&apos;s own tools
-            are read-only.
-          </>
-        ),
-      ]}
+                Radar cannot constrain the agent&apos;s other configured tools or
+                MCP servers. They may access local files or the network and may
+                be able to change your cluster.
+              </>,
+              agent === "claude" ? (
+                <>
+                  Claude uses the permissions from your setup; Radar does not
+                  override them.
+                </>
+              ) : (
+                <>
+                  Radar still enables the agent CLI&apos;s own sandbox, but that
+                  sandbox does not constrain external MCP servers.
+                  {agent === "cursor-agent" && (
+                    <>
+                      {" "}
+                      Cursor always loads your global MCP servers; Radar cannot
+                      exclude them.
+                    </>
+                  )}
+                </>
+              ),
+            ]
+      }
     />
   );
 }