@skyhook-io/radar-app 1.8.10 → 1.8.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyhook-io/radar-app",
-  "version": "1.8.10",
+  "version": "1.8.12",
   "description": "Radar's full web UI as a reusable React component. Used by Radar's own binary and by external consumers like Radar Cloud.",
   "repository": {
     "type": "git",
@@ -33,7 +33,7 @@
     "@fontsource/dm-mono": "^5.2.7",
     "@monaco-editor/react": "^4.7.0",
     "diff": "^9.0.0",
-    "monaco-editor": "^0.55.1",
+    "monaco-editor": "0.55.1",
     "react-markdown": "^10.1.0",
     "react-virtuoso": "^4.18.11",
     "remark-gfm": "^4.0.1",
@@ -41,7 +41,7 @@
     "yaml": "^2.9.0"
   },
   "peerDependencies": {
-    "@skyhook-io/k8s-ui": ">=1.8.11",
+    "@skyhook-io/k8s-ui": ">=1.8.15",
     "@tanstack/react-query": ">=5",
     "@xyflow/react": ">=12.0.0",
     "clsx": ">=2",
@@ -83,7 +83,6 @@
     "vite": "^8.1.5"
   },
   "sideEffects": [
-    "*.css",
-    "./src/monaco-setup.ts"
+    "*.css"
   ]
 }

package/src/api/client.ts

@@ -1,5 +1,11 @@
 import { useEffect, useRef } from 'react'
-import type { AppHistory, AppRow, ArgoSyncOpts } from '@skyhook-io/k8s-ui'
+import type {
+  AppHistory,
+  AppRow,
+  ArgoSyncOpts,
+  YamlDocumentIdentity,
+  YamlSchemaLoadResult,
+} from '@skyhook-io/k8s-ui'
 import { useQuery, useMutation, useQueryClient, skipToken } from '@tanstack/react-query'
 import { showApiError, showApiSuccess } from '../components/ui/Toast'
 import { useCanHelmWrite } from '../contexts/CapabilitiesContext'
@@ -438,6 +444,8 @@ export interface IssuesResponse {
   total_matched?: number
   recent_changes?: IssueRecentChange[]
   recent_changes_reason?: string
+  recent_changes_guidance?: string
+  recent_changes_truncated?: boolean
   // Present only when RBAC visibility is incomplete (absent = full access).
   // state 'degraded' means core workload reads are denied, so an empty list may
   // mean "can't see" rather than "nothing broken" — the UI must say so.
@@ -2627,12 +2635,16 @@ export function useUpdateResource() {
       name,
       yaml,
       force = true,
+      reviewedResourceVersion,
+      reviewedContext,
     }: {
       kind: string
       namespace: string
       name: string
       yaml: string
       force?: boolean
+      reviewedResourceVersion?: string
+      reviewedContext?: string
     }) => {
       const url = new URL(
         `${getApiBase()}/resources/${kind}/${namespace}/${name}`,
@@ -2641,6 +2653,12 @@ export function useUpdateResource() {
       if (!force) {
         url.searchParams.set('force', 'false')
       }
+      if (reviewedResourceVersion) {
+        url.searchParams.set('resourceVersion', reviewedResourceVersion)
+      }
+      if (reviewedContext) {
+        url.searchParams.set('reviewedContext', reviewedContext)
+      }
       const response = await apiFetch(url.toString(), {
         method: 'PUT',
         headers: { 'Content-Type': 'text/plain' },
@@ -2979,6 +2997,144 @@ export interface ApplyResourceResult {
   created: boolean
 }
 
+interface ApplyResourceErrorResponse {
+  error?: string
+  results?: ApplyResourceResult[]
+  failedIndex?: number
+  total?: number
+}
+
+export class ApplyResourceError extends Error {
+  readonly appliedResults: ApplyResourceResult[]
+  readonly failedIndex?: number
+  readonly total?: number
+
+  constructor(payload: ApplyResourceErrorResponse, status: number) {
+    super(formatApplyResourceError(payload, status))
+    this.name = 'ApplyResourceError'
+    this.appliedResults = payload.results ?? []
+    this.failedIndex = payload.failedIndex
+    this.total = payload.total
+  }
+}
+
+export function formatApplyResourceError(
+  payload: ApplyResourceErrorResponse,
+  status: number,
+): string {
+  const message = payload.error || `HTTP ${status}`
+  const applied = payload.results ?? []
+  if (applied.length === 0 || payload.failedIndex === undefined) return message
+
+  const total = payload.total ?? applied.length + 1
+  const appliedLabel = applied.length === 1 ? 'resource was' : 'resources were'
+  const names = applied
+    .slice(0, 3)
+    .map(({ kind, namespace, name }) => `${kind} ${namespace ? `${namespace}/` : ''}${name}`)
+    .join(', ')
+  const more = applied.length > 3 ? ` and ${applied.length - 3} more` : ''
+  const cause = message.replace(/^document \d+:\s*/i, '')
+  return `${applied.length} of ${total} ${appliedLabel} applied before document ${payload.failedIndex + 1} failed. Applied: ${names}${more}. ${cause}`
+}
+
+interface YamlSchemaResponse {
+  documents: Array<{
+    index: number
+    status: 'available' | 'unavailable'
+    bundleKey?: string
+    schemaRef?: string
+    error?: string
+  }>
+  bundles: Record<string, { definitions: Record<string, unknown> }>
+}
+
+export async function fetchYamlSchemas(
+  documents: YamlDocumentIdentity[],
+): Promise<YamlSchemaLoadResult> {
+  const response = await apiFetch(`${getApiBase()}/resources/schemas`, {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({
+      documents: documents.map(({ index, apiVersion, kind }) => ({
+        index,
+        apiVersion,
+        kind,
+      })),
+    }),
+  })
+  if (!response.ok) {
+    const error = await response.json().catch(() => ({ error: 'Cluster schemas are unavailable' }))
+    throw new Error(error.error || `HTTP ${response.status}`)
+  }
+  const result = (await response.json()) as YamlSchemaResponse
+  const schemas: Array<Record<string, unknown> | null> = documents.map(() => null)
+  const unavailable: Array<{ index: number; reason: string }> = []
+  for (const document of result.documents) {
+    const position = documents.findIndex(({ index }) => index === document.index)
+    if (position < 0) continue
+    const bundle = document.bundleKey ? result.bundles[document.bundleKey] : undefined
+    if (document.status === 'available' && document.schemaRef && bundle) {
+      schemas[position] = {
+        $ref: document.schemaRef,
+        definitions: bundle.definitions,
+      }
+    } else {
+      unavailable.push({
+        index: document.index,
+        reason: document.error || 'Schema unavailable',
+      })
+    }
+  }
+  return { schemas, unavailable }
+}
+
+export interface YamlPreviewDocument {
+  index: number
+  status: 'accepted' | 'rejected' | 'unavailable'
+  apiVersion?: string
+  kind?: string
+  namespace?: string
+  name?: string
+  action?: 'create' | 'update' | 'unknown'
+  submittedYaml?: string
+  baselineYaml?: string
+  predictedYaml?: string
+  warnings?: string[]
+  error?: string
+  reviewedResourceVersion?: string
+  redacted?: boolean
+}
+
+export interface YamlPreviewResponse {
+  documents: YamlPreviewDocument[]
+  nonAtomic: boolean
+  context: string
+}
+
+export interface YamlPreviewRequest {
+  yaml: string
+  mode: 'apply' | 'create' | 'update'
+  force: boolean
+  target?: { kind: string; namespace: string; name: string }
+}
+
+export function usePreviewResources() {
+  return useMutation({
+    mutationFn: async (request: YamlPreviewRequest) => {
+      const response = await apiFetch(`${getApiBase()}/resources/preview`, {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify(request),
+      })
+      if (!response.ok) {
+        const error = await response.json().catch(() => ({ error: 'Preview failed' }))
+        throw new Error(error.error || `HTTP ${response.status}`)
+      }
+      return response.json() as Promise<YamlPreviewResponse>
+    },
+  })
+}
+
 export function useApplyResource() {
   const queryClient = useQueryClient()
 
@@ -2988,11 +3144,15 @@ export function useApplyResource() {
       mode = 'apply',
       dryRun = false,
       force = false,
+      reviewedResourceVersions,
+      reviewedContext,
     }: {
       yaml: string
       mode?: 'apply' | 'create'
       dryRun?: boolean
       force?: boolean
+      reviewedResourceVersions?: Record<number, string>
+      reviewedContext?: string
     }) => {
       const url = new URL(`${getApiBase()}/resources/apply`, window.location.origin)
       url.searchParams.set('mode', mode)
@@ -3002,20 +3162,28 @@ export function useApplyResource() {
       if (force) {
         url.searchParams.set('force', 'true')
       }
+      if (reviewedResourceVersions && Object.keys(reviewedResourceVersions).length > 0) {
+        url.searchParams.set('reviewedVersions', JSON.stringify(reviewedResourceVersions))
+      }
+      if (reviewedContext) {
+        url.searchParams.set('reviewedContext', reviewedContext)
+      }
       const response = await apiFetch(url.toString(), {
         method: 'POST',
         headers: { 'Content-Type': 'text/plain' },
         body: yaml,
       })
       if (!response.ok) {
-        const error = await response.json().catch(() => ({ error: 'Unknown error' }))
-        throw new Error(error.error || `HTTP ${response.status}`)
+        const error = (await response
+          .json()
+          .catch(() => ({ error: 'Unknown error' }))) as ApplyResourceErrorResponse
+        throw new ApplyResourceError(error, response.status)
       }
       return response.json() as Promise<ApplyResourceResult[]>
     },
     // No meta errorMessage/successMessage — the CreateResourceDialog
     // handles all feedback inline to avoid duplicate toasts.
-    onSuccess: () => {
+    onSettled: () => {
       queryClient.invalidateQueries({ queryKey: ['resources'] })
       queryClient.invalidateQueries({ queryKey: ['topology'] })
     },

package/src/api/client.yaml.test.ts

@@ -0,0 +1,45 @@
+import { describe, expect, it } from 'vitest'
+import { ApplyResourceError, formatApplyResourceError } from './client'
+
+describe('formatApplyResourceError', () => {
+  it('reports resources persisted before a multi-document failure', () => {
+    expect(
+      formatApplyResourceError(
+        {
+          error: 'document 3: admission denied the Service',
+          failedIndex: 2,
+          total: 4,
+          results: [
+            { kind: 'Namespace', namespace: '', name: 'checkout', created: true },
+            { kind: 'Deployment', namespace: 'checkout', name: 'api', created: true },
+          ],
+        },
+        422,
+      ),
+    ).toBe(
+      '2 of 4 resources were applied before document 3 failed. Applied: Namespace checkout, Deployment checkout/api. admission denied the Service',
+    )
+  })
+
+  it('preserves ordinary apply errors', () => {
+    expect(formatApplyResourceError({ error: 'field is invalid' }, 422)).toBe('field is invalid')
+  })
+
+  it('preserves structured partial-apply results for recovery', () => {
+    const result = { kind: 'Namespace', namespace: '', name: 'checkout', created: true }
+    const error = new ApplyResourceError(
+      {
+        error: 'document 2: admission denied',
+        failedIndex: 1,
+        total: 3,
+        results: [result],
+      },
+      422,
+    )
+
+    expect(error.message).toContain('1 of 3 resource was applied')
+    expect(error.appliedResults).toEqual([result])
+    expect(error.failedIndex).toBe(1)
+    expect(error.total).toBe(3)
+  })
+})

package/src/components/helm/InstallWizard.tsx

@@ -28,7 +28,6 @@ function deepMerge(base: Record<string, unknown>, overrides: Record<string, unkn
   }
   return result
 }
-
 interface InstallWizardProps {
   repo: string
   chartName: string
@@ -757,6 +756,7 @@ function ValuesStep({ valuesYaml, setValuesYaml, yamlError, setYamlError, chartD
               <YamlEditor
                 value={valuesYaml}
                 onChange={setValuesYaml}
+                showProblems={false}
                 height="300px"
                 onValidate={(isValid, errors) => {
                   setYamlError(isValid ? null : errors[0] || 'Invalid YAML')

package/src/components/helm/ValuesViewer.tsx

@@ -25,7 +25,6 @@ interface ValuesViewerProps {
   currentRevision?: number
   onApplySuccess?: () => void
 }
-
 export function ValuesViewer({
   values,
   isLoading,
@@ -297,6 +296,7 @@ export function ValuesViewer({
           <YamlEditor
             value={editedYaml}
             onChange={setEditedYaml}
+            showProblems={false}
             height="calc(100vh - 400px)"
             onValidate={(isValid, errors) => {
               setYamlError(isValid ? null : errors[0] || 'Invalid YAML')

package/src/components/shared/CreateResourceDialog.tsx

@@ -1,17 +1,24 @@
 import { type ComponentProps } from 'react'
 import { CreateResourceDialog as BaseCreateResourceDialog } from '@skyhook-io/k8s-ui'
-import { useApplyResource } from '../../api/client'
+import { fetchYamlSchemas, useApplyResource, usePreviewResources } from '../../api/client'
+import { useCapabilitiesContext } from '../../contexts/CapabilitiesContext'
 
 type BaseProps = ComponentProps<typeof BaseCreateResourceDialog>
 
-export function CreateResourceDialog(props: Omit<BaseProps, 'onApply' | 'isApplying'>) {
+export function CreateResourceDialog(props: Omit<BaseProps, 'onApply' | 'isApplying' | 'onPreview' | 'isPreviewing' | 'previewError' | 'schemaLoader'>) {
   const applyResource = useApplyResource()
+  const previewResources = usePreviewResources()
+  const { features } = useCapabilitiesContext()
 
   return (
     <BaseCreateResourceDialog
       {...props}
       onApply={(params) => applyResource.mutateAsync(params)}
       isApplying={applyResource.isPending}
+      onPreview={features?.yamlReview ? (params) => previewResources.mutateAsync(params) : undefined}
+      isPreviewing={previewResources.isPending}
+      previewError={previewResources.error?.message ?? null}
+      schemaLoader={features?.yamlSchemas ? fetchYamlSchemas : undefined}
     />
   )
 }

package/src/components/workload/WorkloadView.tsx

@@ -35,6 +35,7 @@ import {
   usePodLogs,
   useTopology,
   useUpdateResource,
+  usePreviewResources,
   useDeleteResource,
   useTriggerCronJob,
   useSuspendCronJob,
@@ -60,6 +61,7 @@ import {
   useWorkloadRuns,
   useApplications,
   fetchJSON,
+  fetchYamlSchemas,
 } from '../../api/client'
 import { PrometheusCharts, isPrometheusSupported } from '../resource/PrometheusCharts'
 import { PrometheusChartsGrid } from '../resource/PrometheusChartsGrid'
@@ -79,6 +81,7 @@ import {
   useCanNodeWrite,
   useNamespacedCapabilities,
   useIsLocalDeployment,
+  useCapabilitiesContext,
 } from '../../contexts/CapabilitiesContext'
 import { useOpenTerminal, useOpenLogs, useOpenWorkloadLogs, useOpenNodeTerminal } from '../dock'
 import { PortForwardButton, PortForwardInlineButton } from '../portforward/PortForwardButton'
@@ -651,6 +654,7 @@ export function WorkloadView({
 
   // RBAC
   const canUpdateSecrets = useCanUpdateSecrets()
+  const { features } = useCapabilitiesContext()
   const { canPortForward } = useNamespacedCapabilities(namespace)
   const isLocalDeployment = useIsLocalDeployment()
   const showServingPortForward = canPortForward || !isLocalDeployment
@@ -724,6 +728,7 @@ export function WorkloadView({
     [closeServingCurl, servingCurl],
   )
   const updateResource = useUpdateResource()
+  const previewResources = usePreviewResources()
   const baseActionsBarProps = useActionsBarProps(apiKind, namespace, name)
   const desktopDownload = useDesktopDownload()
 
@@ -761,11 +766,16 @@ export function WorkloadView({
   )
 
   const handleUpdateResource = useCallback(
-    async (params: { kind: string; namespace: string; name: string; yaml: string }) => {
+    async (params: Parameters<typeof updateResource.mutateAsync>[0]) => {
       await updateResource.mutateAsync(params)
     },
     [updateResource],
   )
+  const handlePreviewResource = useCallback(
+    async (params: Parameters<typeof previewResources.mutateAsync>[0]) =>
+      previewResources.mutateAsync(params),
+    [previewResources],
+  )
 
   const navigateRouter = useNavigate()
   const handleOpenGitOpsResource = useCallback(
@@ -901,6 +911,10 @@ export function WorkloadView({
         onUpdateResource={handleUpdateResource}
         isUpdatingResource={updateResource.isPending}
         updateResourceError={updateResource.error?.message ?? null}
+        onPreviewResource={features?.yamlReview ? handlePreviewResource : undefined}
+        isPreviewingResource={previewResources.isPending}
+        previewResourceError={previewResources.error?.message ?? null}
+        yamlSchemaLoader={features?.yamlSchemas ? fetchYamlSchemas : undefined}
         // Tab state (URL-synced)
         activeTab={migratedTab}
         onTabChange={handleTabChange}

package/src/main.tsx

@@ -1,15 +1,9 @@
 import React from 'react'
 import ReactDOM from 'react-dom/client'
-import { configureBundledMonaco } from './monaco-setup'
 import { RadarApp } from './RadarApp'
 import { openExternal } from './utils/navigation'
 import './index.css'
 
-// Keep this as an explicit call: side-effect-only imports of the Monaco setup can
-// be dropped by production tree-shaking, which makes offline desktop builds fall
-// back to Monaco's CDN loader.
-configureBundledMonaco()
-
 // Intercept external link clicks in the Wails desktop app.
 // <a target="_blank"> is swallowed by WKWebView/WebView2 — route through openExternal()
 // which calls the backend /api/desktop/open-url endpoint to open in the system browser.

package/src/monaco-deep.d.ts

@@ -1,8 +0,0 @@
-// monaco-editor's package `exports` map ("./*": "./*") doesn't surface type
-// declarations for deep ESM subpaths, so TS can't resolve these imports even
-// though the .js/.d.ts files exist on disk. Re-export the root types for the
-// editor API and declare the YAML grammar as a side-effect-only module.
-declare module 'monaco-editor/esm/vs/editor/editor.api' {
-  export * from 'monaco-editor'
-}
-declare module 'monaco-editor/esm/vs/basic-languages/yaml/yaml.contribution'

package/src/monaco-setup.ts

@@ -1,33 +0,0 @@
-// Load the Monaco editor from the bundled npm package instead of the default
-// jsdelivr CDN. Without this, @monaco-editor/react fetches the editor at runtime
-// over the network, so the YAML editor never loads in airgapped / offline
-// deployments. Bundling makes the binary fully self-contained.
-//
-// Called from main.tsx (Radar's binary entry) only — library consumers
-// (e.g. Radar Hub) keep the default CDN loader unless they opt in.
-//
-// Import the editor API + YAML grammar directly rather than the `monaco-editor`
-// barrel: the barrel pulls in the JSON/CSS/HTML/TypeScript language services,
-// each of which bundles a heavy web worker (the TS one alone is ~7MB) that Radar
-// never uses — it only ever edits YAML.
-import * as monaco from 'monaco-editor/esm/vs/editor/editor.api'
-import 'monaco-editor/esm/vs/basic-languages/yaml/yaml.contribution'
-import { loader } from '@monaco-editor/react'
-import EditorWorker from 'monaco-editor/esm/vs/editor/editor.worker?worker'
-
-let configured = false
-
-export function configureBundledMonaco() {
-  if (configured) return
-  configured = true
-
-  // YAML has no dedicated Monaco language worker — the base editor worker covers
-  // everything we use, so route every label to it.
-  ;(globalThis as typeof globalThis & { MonacoEnvironment?: { getWorker(): Worker } }).MonacoEnvironment = {
-    getWorker() {
-      return new EditorWorker()
-    },
-  }
-
-  loader.config({ monaco })
-}