@skyhook-io/radar-app 1.16.1 → 1.16.3

package/src/components/diagnose/DiagnoseContext.tsx

@@ -28,9 +28,11 @@ import {
   createRun,
   recordConsent,
   DiagnoseError,
+  investigationRefusal,
 } from "../../api/diagnose";
 import { getApiBase } from "../../api/config";
 import {
+  type InvestigationRefusal,
   type RunSummary,
   type AgentInfo,
   type ExecutionProfile,
@@ -86,6 +88,9 @@ interface DiagnoseCtx {
   historyDegraded: boolean; // persistence broke — history won't survive a restart
   needsConsent: boolean; // a start is pending the one-time consent
   startError: string | null;
+  // The host's refusal behind startError, when it sent one, so the surface can
+  // offer the host's action beside the message.
+  startRefusal: InvestigationRefusal | null;
   // Kept apart from startError: the consent card renders this as "why your
   // approval was refused", and a run-start failure landing in the same slot
   // would be read as exactly that — the two paths don't share a lifecycle.
@@ -426,7 +431,10 @@ function RoutedDiagnoseProvider({
   const [runsLoadFailed, setRunsLoadFailed] = useState(false);
   const [historyDegraded, setHistoryDegraded] = useState(false);
   const [pendingTarget, setPendingTarget] = useState<Target | null>(null);
-  const [startError, setStartError] = useState<string | null>(null);
+  const [startFailure, setStartFailure] = useState<{
+    message: string;
+    refusal: InvestigationRefusal | null;
+  } | null>(null);
   const [consentError, setConsentError] = useState<string | null>(null);
   const [width, setWidth] = useState<number>(() => {
     try {
@@ -694,24 +702,28 @@ function RoutedDiagnoseProvider({
       })
       .catch((e) => {
         if (seq !== startSeqRef.current) return;
-        setStartError(
-          e instanceof DiagnoseError
-            ? e.message
-            : "Couldn't start the investigation.",
-        );
+        setStartFailure({
+          message:
+            e instanceof DiagnoseError
+              ? e.message
+              : "Couldn't start the investigation.",
+          refusal: investigationRefusal(e),
+        });
       });
   };
 
   const openInvestigation = useCallback(
     (t: Target) => {
-      setStartError(null);
+      setStartFailure(null);
       setConsentError(null);
       setOpen(true);
       if (!hosted && !consentSurface) {
         setPendingTarget(null);
-        setStartError(
-          "Radar can’t run this agent with a verified execution profile.",
-        );
+        setStartFailure({
+          message:
+            "Radar can’t run this agent with a verified execution profile.",
+          refusal: null,
+        });
         setView("investigation");
         return;
       }
@@ -728,7 +740,7 @@ function RoutedDiagnoseProvider({
   const openRun = useCallback(
     (id: string) => {
       unavailableRunIDsRef.current.delete(id);
-      setStartError(null);
+      setStartFailure(null);
       setActiveRunId(id);
       setView("investigation");
       setOpen(true);
@@ -748,7 +760,7 @@ function RoutedDiagnoseProvider({
   );
 
   // Browser navigation is the source of truth for presentation: a dedicated
-  // /investigations route is the full workspace, while ?ai-run keeps the
+  // /investigations route is the full investigations page, while ?ai-run keeps the
   // contextual drawer on its underlying page. Fetch exact ids rather than
   // assuming the bounded recent list contains them.
   useEffect(() => {
@@ -756,7 +768,7 @@ function RoutedDiagnoseProvider({
       return;
     const workspace = isInvestigationWorkspacePath(location.pathname);
     // Eligibility is unresolved until the agent probe returns. Once it has
-    // definitively resolved to off, workspace routes cannot render anything
+    // definitively resolved to off, investigations-page routes cannot render anything
     // useful; return to the app instead of leaving an eternal loading panel.
     if (agentEligibilityResolved && !eligible) {
       setActiveRunId(null);
@@ -823,7 +835,7 @@ function RoutedDiagnoseProvider({
 
     urlRunIdRef.current = id;
     unavailableRunIDsRef.current.delete(id);
-    setStartError(null);
+    setStartFailure(null);
     setActiveRunId(id);
     setView("investigation");
     setOpen(true);
@@ -856,14 +868,14 @@ function RoutedDiagnoseProvider({
     unavailableRunIDsRef.current.clear();
     setActiveRunId(null);
     setView("home");
-    setStartError(null);
+    setStartFailure(null);
     setOpen(true);
     writeFocusedRunID(null, false);
   }, [writeFocusedRunID]);
   const openWorkspace = useCallback(
     (preferredRunID?: string | null) => {
       setOpen(true);
-      setStartError(null);
+      setStartFailure(null);
       if (!forceRouterURLState && !diagnoseURLStateEnabled(browserURLState)) {
         if (preferredRunID) {
           setActiveRunId(preferredRunID);
@@ -876,8 +888,8 @@ function RoutedDiagnoseProvider({
         return;
       }
       const current = locationRef.current;
-      // The global entry remains visible in the workspace. Treat clicking it
-      // there as an idempotent reveal rather than pushing another workspace
+      // The global entry remains visible on the investigations page. Treat clicking it
+      // there as an idempotent reveal rather than pushing another page
       // entry and replacing the page that Close should return to.
       if (isInvestigationWorkspacePath(current.pathname)) {
         setMaximized(true);
@@ -927,14 +939,14 @@ function RoutedDiagnoseProvider({
     unavailableRunIDsRef.current.clear();
     setActiveRunId(null);
     setView("home");
-    setStartError(null);
+    setStartFailure(null);
     writeFocusedRunID(null, false);
   }, [writeFocusedRunID]);
   const dismissForNavigation = useCallback(() => {
     unavailableRunIDsRef.current.clear();
     setOpen(false);
     setView("home");
-    setStartError(null);
+    setStartFailure(null);
   }, []);
   const close = useCallback(() => {
     unavailableRunIDsRef.current.clear();
@@ -999,7 +1011,7 @@ function RoutedDiagnoseProvider({
     setOpen(true);
     if (!activeRunIdRef.current) setView("home");
   }, []);
-  const dismissError = useCallback(() => setStartError(null), []);
+  const dismissError = useCallback(() => setStartFailure(null), []);
 
   // Reserve a right gutter on the CONTENT area (not the navbar/rail — those stay
   // global and static) so docked content reflows beside the panel. Wide viewports
@@ -1029,7 +1041,8 @@ function RoutedDiagnoseProvider({
     // pendingTarget is set ONLY when the current agent's consent is missing, and
     // cleared on approve/cancel — so its presence is exactly "consent needed now".
     needsConsent: !!pendingTarget,
-    startError,
+    startError: startFailure?.message ?? null,
+    startRefusal: startFailure?.refusal ?? null,
     consentError,
     openInvestigation,
     openRun,

package/src/components/diagnose/DiagnoseSurface.tsx

@@ -1,6 +1,6 @@
 // The right-docked shell of the AI surface. Two layouts:
 //  - docked: a single-pane right column (app reflows left via the provider's push)
-//  - expanded: a master-detail workspace that fills ONLY the content area (does
+//  - expanded: the investigations page, a master-detail layout that fills ONLY the content area (does
 //    not cover the left nav rail or top bar) — recent list on the left, the
 //    selected investigation/report on the right.
 import {
@@ -38,6 +38,7 @@ import {
   type DiagnoseView,
 } from "./DiagnoseContext";
 import { useDiagnoseCustomization } from "../../context/DiagnoseCustomization";
+import { InvestigationRefusalAction } from "./InvestigationRefusalAction";
 import { useNavCustomization } from "../../context/NavCustomization";
 import { InvestigationView } from "./InvestigationView";
 import type { InvestigationTimelineScope } from "./InvestigationEvidencePane";
@@ -419,7 +420,7 @@ export function DiagnoseSurface({
     panelWidthKey: widthKey,
   } = useDiagnoseLayout();
   // Home has no detail pane competing for width, so its history is always part
-  // of the workspace. Only a focused run collapses history into a drawer when
+  // of the page. Only a focused run collapses history into a drawer when
   // the two-pane layout would become cramped.
   const persistentHistory = investigationHistoryIsPersistent({
     maximized,
@@ -604,12 +605,15 @@ export function DiagnoseSurface({
   ) : d.startError ? (
     <div className="flex flex-1 flex-col items-center justify-center gap-3 px-6 text-center">
       <p className="text-sm text-theme-text-secondary">{d.startError}</p>
-      <button
-        onClick={d.dismissError}
-        className="rounded-lg border border-theme-border px-3 py-1.5 text-sm text-theme-text-secondary hover:bg-theme-hover"
-      >
-        Dismiss
-      </button>
+      <div className="flex flex-wrap items-center justify-center gap-2">
+        <InvestigationRefusalAction refusal={d.startRefusal} />
+        <button
+          onClick={d.dismissError}
+          className="rounded-lg border border-theme-border px-3 py-1.5 text-sm text-theme-text-secondary hover:bg-theme-hover"
+        >
+          Dismiss
+        </button>
+      </div>
     </div>
   ) : setupPending ? (
     <div className="flex-1 overflow-y-auto">

package/src/components/diagnose/Home.tsx

@@ -1,5 +1,5 @@
 // Server-side runs keep background and running investigations visible in both
-// the docked Home view and the maximized workspace's master pane.
+// the docked Home view and the investigations page's list pane.
 import {
   ArrowRight,
   CircleAlert,

package/src/components/diagnose/InvestigationEvidencePane.tsx

@@ -204,7 +204,7 @@ export function InvestigationEvidencePane({
     : undefined;
 
   // A source link is a navigation request, not a disclosure preference. Open
-  // whichever collection owns the source first, then tell the workspace that
+  // whichever collection owns the source first, then tell the investigation view that
   // its double-rAF focus/scroll can safely run outside an inert subtree.
   useLayoutEffect(() => {
     if (

package/src/components/diagnose/InvestigationRefusalAction.test.tsx

@@ -0,0 +1,156 @@
+import { describe, expect, it } from "vitest";
+import { renderToString } from "react-dom/server";
+import { DiagnoseError, investigationRefusal } from "../../api/diagnose";
+import { DiagnoseCustomizationProvider } from "../../context/DiagnoseCustomization";
+import {
+  InvestigationFailureNotice,
+  InvestigationStartErrorAlert,
+  InvestigationStatusCheckNotice,
+} from "./InvestigationView";
+
+const quota = new DiagnoseError(
+  402,
+  "Your organization has used this month's investigations.",
+  {
+    code: "ai_quota_exhausted",
+    reason: "allowance_used_free",
+    action: "upgrade",
+  },
+);
+
+describe("investigationRefusal", () => {
+  it("carries a host refusal's code, reason and action with its sentence", () => {
+    expect(investigationRefusal(quota)).toEqual({
+      status: 402,
+      message: "Your organization has used this month's investigations.",
+      code: "ai_quota_exhausted",
+      reason: "allowance_used_free",
+      action: "upgrade",
+    });
+  });
+
+  it("is null for Radar's own errors and for anything that isn't a DiagnoseError", () => {
+    expect(
+      investigationRefusal(
+        new DiagnoseError(409, "Too many investigations running."),
+      ),
+    ).toBeNull();
+    expect(investigationRefusal(new Error("network down"))).toBeNull();
+    expect(investigationRefusal(undefined)).toBeNull();
+  });
+});
+
+describe("InvestigationStartErrorAlert", () => {
+  const alert = (refusal = investigationRefusal(quota)) => (
+    <InvestigationStartErrorAlert
+      error={quota.message}
+      refusal={refusal}
+      onDismiss={() => {}}
+    />
+  );
+
+  it("shows the host's action beside the refusal", () => {
+    const html = renderToString(
+      <DiagnoseCustomizationProvider
+        value={undefined}
+        renderRefusalAction={(r) => (
+          <a href="/plans">{`Upgrade (${r.reason})`}</a>
+        )}
+      >
+        {alert()}
+      </DiagnoseCustomizationProvider>,
+    );
+    expect(html).toContain("this month&#x27;s investigations");
+    expect(html).toContain("Upgrade (allowance_used_free)");
+  });
+
+  it("shows only the sentence when the host offers no action", () => {
+    const html = renderToString(alert());
+    expect(html).toContain("this month&#x27;s investigations");
+    expect(html).not.toContain("Upgrade");
+  });
+
+  it("asks the host for nothing when the error carries no refusal", () => {
+    let asked = false;
+    renderToString(
+      <DiagnoseCustomizationProvider
+        value={undefined}
+        renderRefusalAction={() => {
+          asked = true;
+          return null;
+        }}
+      >
+        {alert(null)}
+      </DiagnoseCustomizationProvider>,
+    );
+    expect(asked).toBe(false);
+  });
+});
+
+const withHost = (node: React.ReactNode) =>
+  renderToString(
+    <DiagnoseCustomizationProvider
+      value={undefined}
+      renderRefusalAction={(r) => (
+        <a href="/plans">{`Upgrade (${r.reason})`}</a>
+      )}
+    >
+      {node}
+    </DiagnoseCustomizationProvider>,
+  );
+
+describe("InvestigationStatusCheckNotice (Findings)", () => {
+  it("says a refused status check couldn't run, with the host's action", () => {
+    const html = withHost(
+      <InvestigationStatusCheckNotice
+        message={quota.message}
+        uncertainOnly={false}
+        refusal={investigationRefusal(quota)}
+        onCheck={() => {}}
+        disabled={false}
+      />,
+    );
+    expect(html).toContain("Couldn&#x27;t check status:");
+    expect(html).not.toContain("Verification did not complete");
+    expect(html).toContain("Upgrade (allowance_used_free)");
+  });
+
+  it("keeps the verification wording, and no action, for a check that ran and failed", () => {
+    const html = withHost(
+      <InvestigationStatusCheckNotice
+        message="The agent stopped before checking."
+        uncertainOnly={false}
+        refusal={null}
+        onCheck={() => {}}
+        disabled={false}
+      />,
+    );
+    expect(html).toContain("Verification did not complete:");
+    expect(html).not.toContain("Upgrade");
+  });
+});
+
+describe("InvestigationFailureNotice (Activity)", () => {
+  it("keeps a status warning first and shows a newer refused follow-up, with its action, beside it", () => {
+    const html = withHost(
+      <InvestigationFailureNotice
+        message="Radar couldn't confirm whether the apply request completed."
+        refusal={null}
+        statusCheck={{
+          label: "Check current status",
+          onCheck: () => {},
+          disabled: false,
+        }}
+        followUp={{
+          message: quota.message,
+          refusal: investigationRefusal(quota),
+        }}
+      />,
+    );
+    expect(
+      html.indexOf("couldn&#x27;t confirm whether the apply"),
+    ).toBeLessThan(html.indexOf("this month&#x27;s investigations"));
+    expect(html).toContain("Check current status");
+    expect(html).toContain("Upgrade (allowance_used_free)");
+  });
+});

package/src/components/diagnose/InvestigationRefusalAction.tsx

@@ -0,0 +1,14 @@
+import type { InvestigationRefusal } from "../../api/diagnose";
+import { useDiagnoseCustomization } from "../../context/DiagnoseCustomization";
+
+/** The host's action for a refused start or follow-up, or nothing when the
+ * refusal carries no code, reason or action, or the host offers none. */
+export function InvestigationRefusalAction({
+  refusal,
+}: {
+  refusal: InvestigationRefusal | null;
+}) {
+  const { renderRefusalAction } = useDiagnoseCustomization();
+  if (!refusal || !renderRefusalAction) return null;
+  return <>{renderRefusalAction(refusal)}</>;
+}