@skyhook-io/radar-app 1.14.5 → 1.15.0

package/src/RadarApp.tsx

@@ -84,12 +84,7 @@ export interface RadarAppProps {
    * prefer to share its client rather than nest two providers.
    */
   queryClient?: QueryClient;
-  /**
-   * Slot-based customization of Radar's top nav. Use to inject host-app
-   * brand, replace the kubeconfig context picker with a product-level
-   * cluster switcher, and append items to the right action bar.
-   * See ./context/NavCustomization for the slot shape.
-   */
+  /** Embedded layout and host navigation hooks for Radar Hub. */
   navSlots?: NavCustomization;
   /**
    * Whether Radar may set the browser tab title (`document.title`) per view.
@@ -128,14 +123,14 @@ export interface RadarAppProps {
   /**
    * Initial route for `router: 'memory'` (ignored for 'browser'). Lets a host
    * deep-link a specific view (e.g. '/topology') without owning the URL bar —
-   * used with `navSlots.chrome: 'none'` to render a single per-cluster view
+   * used with `navSlots.embedded: true` to render a single per-cluster view
    * chromeless under the host's own chrome (Radar Hub's per-cluster destinations).
    */
   initialPath?: string;
   /**
    * Reports cluster-data warmup after the main connection is usable. Embedders
    * with their own chrome (Radar Hub) can render this in their topbar while
-   * Radar runs with `navSlots.chrome: 'none'`.
+   * Radar runs with `navSlots.embedded: true`.
    */
   onClusterLoadStateChange?: (state: ClusterLoadState) => void;
   /**

package/src/api/client.admission.test.ts

@@ -0,0 +1,34 @@
+import { describe, expect, it, vi } from 'vitest'
+import { useQuery } from '@tanstack/react-query'
+import { ApiError, useKueueAdmission as admissionQuery } from './client'
+
+vi.mock('@tanstack/react-query', async (original) => ({ ...await original<typeof import('@tanstack/react-query')>(), useQuery: vi.fn(() => ({})) }))
+
+describe('Kueue admission polling', () => {
+  function options(settings?: Parameters<typeof admissionQuery>[3]) {
+    admissionQuery('ml', 'training', 'current', settings)
+    return vi.mocked(useQuery).mock.calls.at(-1)![0]
+  }
+  function interval(settings: Parameters<typeof admissionQuery>[3], state: any = {}) {
+    const poll = options(settings).refetchInterval as (query: any) => number | false
+    return poll({ state })
+  }
+  it('separates Job and JobSet identities and recreated roots', () => {
+    expect(options({ isJob: true }).queryKey).toEqual(['kueue-admission', 'batch', 'jobs', 'ml', 'training', 'current'])
+    expect(options({ isRayJob: true }).queryKey).toEqual(['kueue-admission', 'ray.io', 'rayjobs', 'ml', 'training', 'current'])
+    expect(options().queryKey).toEqual(['kueue-admission', 'jobset.x-k8s.io', 'jobsets', 'ml', 'training', 'current'])
+  })
+  it('polls quiet and terminal Jobs slowly, active admission quickly', () => {
+    expect(interval({ isJob: true })).toBe(30000)
+    expect(interval({ isJob: true, hinted: true })).toBe(5000)
+    expect(interval({ isJob: true }, { data: { workloads: [{}] } })).toBe(5000)
+    expect(interval({ isJob: true, hinted: true, terminal: true })).toBe(30000)
+    expect(interval(undefined)).toBe(5000)
+  })
+  it('stops on confirmed absence or denied requests, not transient outages or old absence', () => {
+    expect(interval({ isJob: true }, { data: { uid: 'current', installed: false } })).toBe(false)
+    expect(interval({ isJob: true, hinted: true }, { data: { uid: 'old', installed: false } })).toBe(5000)
+    expect(interval({ isJob: true }, { error: new ApiError('denied', 403) })).toBe(false)
+    expect(interval({ isJob: true, hinted: true }, { error: new ApiError('warming', 503) })).toBe(5000)
+  })
+})

package/src/api/client.jobset.test.ts

@@ -0,0 +1,18 @@
+import { describe, expect, it, vi } from 'vitest'
+import { useQuery } from '@tanstack/react-query'
+import { useWorkloadRuns, type WorkloadRunsResponse } from './client'
+
+vi.mock('@tanstack/react-query', async (original) => ({ ...await original<typeof import('@tanstack/react-query')>(), useQuery: vi.fn(() => ({})) }))
+
+describe('JobSet member polling', () => {
+  it('refreshes an active selected member even when the displayed window is idle', () => {
+    useWorkloadRuns('jobsets', 'training', 'distributed', true, { refetchActive: true, role: 'prepare', selected: 'jobs/training/worker' })
+    const options = vi.mocked(useQuery).mock.calls.at(-1)![0]
+    const interval = options.refetchInterval as (query: { state: { data: WorkloadRunsResponse } }) => number
+    const run = { group: 'batch', kind: 'jobs', namespace: 'training', name: 'prepare', phase: 'Succeeded', active: false }
+    const response: WorkloadRunsResponse = { collection: 'members', runs: [run], selected: { ...run, name: 'worker', phase: 'Running', active: true }, total: 2, filteredTotal: 1, truncated: false }
+    expect(interval({ state: { data: response } })).toBe(5000)
+    expect(interval({ state: { data: { ...response, selected: run } } })).toBe(30000)
+    expect(interval({ state: { data: { ...response, runs: [{ ...run, active: true }], selected: undefined } } })).toBe(5000)
+  })
+})

package/src/api/client.resource-identity.test.ts

@@ -0,0 +1,44 @@
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { useQuery } from '@tanstack/react-query'
+import { useResourceAudit, useResourceEvents } from './client'
+
+vi.mock('@tanstack/react-query', async (original) => ({
+  ...await original<typeof import('@tanstack/react-query')>(),
+  useQuery: vi.fn(() => ({})),
+}))
+
+afterEach(() => { vi.clearAllMocks(); vi.unstubAllGlobals() })
+
+describe('resource history identity', () => {
+  it('separates same-name core and Volcano history in requests and cache keys', async () => {
+    const urls: URL[] = []
+    vi.stubGlobal('fetch', vi.fn(async (input: string) => {
+      urls.push(new URL(input, 'http://localhost'))
+      return new Response('[]', {status: 200})
+    }))
+    useResourceEvents('jobs', 'ml', 'shared', 'batch')
+    useResourceEvents('jobs', 'ml', 'shared', 'batch.volcano.sh')
+    const queries = vi.mocked(useQuery).mock.calls.map(call => call[0])
+    expect(queries[0].queryKey).not.toEqual(queries[2].queryKey)
+    expect(queries[1].queryKey).not.toEqual(queries[3].queryKey)
+    for (const query of queries) await (query.queryFn as () => Promise<unknown>)()
+    expect(urls.map(url => url.searchParams.get('group'))).toEqual(['batch', 'batch', 'batch.volcano.sh', 'batch.volcano.sh'])
+    expect(urls.every(url => url.searchParams.get('kind') === 'Job')).toBe(true)
+  })
+
+  it('does not query an unresolved custom identity', () => {
+    useResourceEvents('Widget', 'ml', 'shared')
+    expect(vi.mocked(useQuery).mock.calls.every(call => call[0].enabled === false)).toBe(true)
+  })
+
+  it('preserves a core group and an exact audit group', async () => {
+    const fetchMock = vi.fn<typeof fetch>(async () => new Response('[]', {status: 200}))
+    vi.stubGlobal('fetch', fetchMock)
+    useResourceEvents('pods', 'ml', 'shared', '')
+    await (vi.mocked(useQuery).mock.calls[0][0].queryFn as () => Promise<unknown>)()
+    expect(new URL(String(fetchMock.mock.calls[0][0]), 'http://localhost').searchParams.get('group')).toBe('')
+    useResourceAudit('IngressRoute', 'ml', 'shared', 'traefik.io')
+    await (vi.mocked(useQuery).mock.calls.at(-1)![0].queryFn as () => Promise<unknown>)()
+    expect(fetchMock).toHaveBeenLastCalledWith('/api/audit/resource/IngressRoute/ml/shared?group=traefik.io', expect.anything())
+  })
+})

package/src/api/client.rightsizing.test.ts

@@ -1,21 +1,25 @@
 import { describe, expect, it } from 'vitest'
-import { skipToken } from '@tanstack/react-query'
 import { getRightsizingScanCacheConfig } from './client'
 
 describe('rightsizing scan cache config', () => {
-  it('is manual-only and retained briefly', () => {
+  it('retains result lookups briefly', () => {
     const config = getRightsizingScanCacheConfig(['staging', 'default'], 'cluster-a')
 
-    expect(config.queryFn).toBe(skipToken)
     expect(config.gcTime).toBe(5 * 60 * 1000)
   })
 
+  it('isolates identities', () => {
+    expect(getRightsizingScanCacheConfig([], 'a', 'alice').queryKey).not.toEqual(getRightsizingScanCacheConfig([], 'a', 'bob').queryKey)
+  })
+
   it('normalizes namespace order and isolates cluster and namespace scopes', () => {
     const config = getRightsizingScanCacheConfig(['staging', 'default'], 'cluster-a')
 
     expect(config.namespaceKey).toBe('default,staging')
     expect(config.queryKey).toEqual([
       'prometheus-rightsizing-scan',
+      '/api',
+      '',
       'cluster-a',
       'default,staging',
     ])