@skyhook-io/radar-app 1.13.5 → 1.14.1

package/src/components/diagnose/InvestigationEvidencePane.story.test.tsx

@@ -0,0 +1,771 @@
+import { describe, expect, it } from "vitest";
+import { renderToStaticMarkup } from "react-dom/server";
+
+import {
+  InvestigationEvidencePane,
+  namedInventoryRows,
+} from "./InvestigationEvidencePane";
+import { resolveInvestigationCase } from "./investigationCase";
+import {
+  projectInvestigationEvidence,
+  type InvestigationEvidenceTimelineItem,
+} from "./investigationEvidence";
+import type { DiagnosisEvidenceItem } from "../../api/diagnose";
+
+const target = {
+  kind: "Deployment",
+  group: "apps",
+  namespace: "shop",
+  name: "api",
+};
+
+function evidenceRef(scope: string, nonce: string): string {
+  return `ev_${scope.repeat(26)}_${nonce.repeat(26)}`;
+}
+
+function tool(
+  id: string,
+  name: string,
+  result: unknown,
+  patch: Partial<
+    Extract<InvestigationEvidenceTimelineItem, { kind: "tool" }>
+  > = {},
+): Extract<InvestigationEvidenceTimelineItem, { kind: "tool" }> {
+  return {
+    kind: "tool",
+    id,
+    tool: name,
+    status: "done",
+    summary: JSON.stringify({ namespace: "shop", name: "api" }),
+    result: JSON.stringify(result),
+    isError: false,
+    radarEvidence: true,
+    ...patch,
+  };
+}
+
+const crashIssue = {
+  id: "issue-api-crash",
+  severity: "critical",
+  source: "problem",
+  category: "crashloop",
+  category_group: "runtime",
+  grouping_scope: "workload",
+  kind: "Deployment",
+  group: "apps",
+  namespace: "shop",
+  name: "api",
+  reason: "CrashLoopBackOff",
+  message: "The API container keeps restarting.",
+};
+
+describe("InvestigationEvidencePane under a story", () => {
+  const ref = evidenceRef("a", "b");
+  const projection = projectInvestigationEvidence(
+    [
+      {
+        timeline: [
+          tool(
+            "issues",
+            "issues",
+            { issues: [crashIssue], total: 1, total_matched: 1 },
+            {
+              evidenceRef: ref,
+            },
+          ),
+        ],
+      },
+    ],
+    target,
+  );
+  const evidence: DiagnosisEvidenceItem[] = [
+    { status: "linked", ref, role: "cause", claim: "" },
+    { status: "unlinked" },
+  ];
+  const investigationCase = resolveInvestigationCase(
+    projection,
+    { evidence },
+    0,
+  );
+  const render = (report: string) =>
+    renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={projection}
+        investigationCase={investigationCase}
+        story={{ report, evidence }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+        afterEvidence={<div data-next-steps>steps</div>}
+      />,
+    );
+
+  it("places the cited card in the story, marks it in the inventory, and puts next steps before it", () => {
+    const html = render(
+      "The container keeps dying.\n\n[[radar:evidence=0]]\n\nThat is the whole story.",
+    );
+    expect(html).toContain("data-story");
+    expect(html).toContain('id="story-');
+    expect(html).toContain("Captured results");
+    expect(html).toContain("1 shown above");
+    expect(html).toContain("In the analysis");
+    expect(html).not.toContain(">Evidence<");
+    // Next steps sit between the story and the inventory.
+    const story = html.indexOf("data-story");
+    const steps = html.indexOf("data-next-steps");
+    const inventory = html.indexOf("Captured results");
+    expect(story).toBeGreaterThan(-1);
+    expect(steps).toBeGreaterThan(story);
+    expect(inventory).toBeGreaterThan(steps);
+    // The inventory is collapsed once the story placed something.
+    expect(html).toMatch(/aria-controls="investigation-captured-results"[^>]*/);
+    expect(html).toMatch(
+      /aria-expanded="false"[^>]*aria-controls="investigation-captured-results"/,
+    );
+  });
+
+  it("shows lost support at the sentence and opens the inventory when nothing was placed", () => {
+    const html = render(
+      "Nothing placed, but see [[radar:evidence=1]] and [[radar:evidence=7]].",
+    );
+    expect(html).toContain('data-story-lost-support="unlinked"');
+    expect(html).toContain('data-story-lost-support="invalid"');
+  });
+
+  it("links a bound call that produced no card to its raw result in Activity", () => {
+    const searchRef = evidenceRef("e", "f");
+    const withSearch = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "issues",
+              "issues",
+              { issues: [crashIssue], total: 1, total_matched: 1 },
+              {
+                evidenceRef: ref,
+              },
+            ),
+            tool(
+              "search",
+              "search",
+              { results: [], total: 0 },
+              {
+                evidenceRef: searchRef,
+                summary: JSON.stringify({ query: "metrics-server" }),
+              },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const items: DiagnosisEvidenceItem[] = [
+      {
+        status: "linked",
+        ref: searchRef,
+        role: "rules_out",
+        claim: "Nothing named metrics-server exists.",
+      },
+    ];
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={withSearch}
+        investigationCase={resolveInvestigationCase(
+          withSearch,
+          { evidence: items },
+          0,
+        )}
+        story={{
+          report: "No metrics-server anywhere.\n\n[[radar:evidence=0]]",
+          evidence: items,
+        }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    expect(html).toContain('data-story-lost-support="nocard"');
+    expect(html).toContain("Result in Activity");
+    expect(html).toContain("None shown above");
+    expect(html).toMatch(
+      /aria-expanded="true"[^>]*aria-controls="investigation-captured-results"/,
+    );
+  });
+
+  it("places a subject-less citation of a fan-out call on that call's primary card", () => {
+    const bundleRef = evidenceRef("c", "d");
+    const bundle = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "diag",
+              "diagnose",
+              {
+                resource: {
+                  apiVersion: "apps/v1",
+                  kind: "Deployment",
+                  metadata: { name: "api", namespace: "shop" },
+                  status: { replicas: 1, readyReplicas: 0 },
+                },
+                issues: [crashIssue],
+                events: [],
+              },
+              { evidenceRef: bundleRef },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const items: DiagnosisEvidenceItem[] = [
+      { status: "linked", ref: bundleRef, role: "context", claim: "" },
+    ];
+    const bundleCase = resolveInvestigationCase(bundle, { evidence: items }, 0);
+    // The resolver itself leaves the item at its source: several cards match.
+    expect(bundleCase.items[0]?.placement).toBe("source");
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={bundle}
+        investigationCase={bundleCase}
+        story={{
+          report: "Radar's bundle says so.\n\n[[radar:evidence=0]]",
+          evidence: items,
+        }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    expect(html).toContain('data-story-placement="0"');
+    expect(html).not.toContain("data-story-lost-support");
+    expect(html).toContain("1 shown above");
+  });
+
+  it("renders a cited earlier read as that read, labelled, when a newer one exists", () => {
+    const early = evidenceRef("a", "b");
+    const later = evidenceRef("c", "d");
+    const twoReads = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "issues-early",
+              "issues",
+              { issues: [crashIssue], total: 1, total_matched: 1 },
+              {
+                evidenceRef: early,
+              },
+            ),
+          ],
+        },
+        {
+          timeline: [
+            tool(
+              "issues-later",
+              "issues",
+              {
+                issues: [
+                  {
+                    ...crashIssue,
+                    message:
+                      "The API container keeps restarting, 40 times now.",
+                  },
+                ],
+                total: 1,
+                total_matched: 1,
+              },
+              { evidenceRef: later },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const items: DiagnosisEvidenceItem[] = [
+      { status: "linked", ref: early, role: "cause", claim: "" },
+    ];
+    // A revised assessment in turn 1 citing the read from turn 0.
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={twoReads}
+        investigationCase={resolveInvestigationCase(
+          twoReads,
+          { evidence: items },
+          1,
+        )}
+        story={{
+          report: "It was crashing then.\n\n[[radar:evidence=0]]",
+          evidence: items,
+        }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    expect(html).toContain('data-story-placement="0"');
+    expect(html).toContain("Captured in turn 1");
+    expect(html).toContain("a newer read");
+  });
+
+  it("binds a subject-less earlier citation to that call's own read, never a later one", () => {
+    const early = evidenceRef("a", "b");
+    const later = evidenceRef("c", "d");
+    const bundleResult = (ready: number) => ({
+      resource: {
+        apiVersion: "apps/v1",
+        kind: "Deployment",
+        metadata: { name: "api", namespace: "shop" },
+        status: { replicas: 1, readyReplicas: ready },
+      },
+      issues: [crashIssue],
+      events: [],
+    });
+    const twoBundles = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool("diag-early", "diagnose", bundleResult(0), {
+              evidenceRef: early,
+            }),
+          ],
+        },
+        {
+          timeline: [
+            tool("diag-later", "diagnose", bundleResult(1), {
+              evidenceRef: later,
+            }),
+          ],
+        },
+      ],
+      target,
+    );
+    const items: DiagnosisEvidenceItem[] = [
+      { status: "linked", ref: early, role: "cause", claim: "" },
+    ];
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={twoBundles}
+        investigationCase={resolveInvestigationCase(
+          twoBundles,
+          { evidence: items },
+          1,
+        )}
+        story={{
+          report: "Then it was down.\n\n[[radar:evidence=0]]",
+          evidence: items,
+        }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    const placed = html.slice(html.indexOf('data-story-placement="0"'));
+    expect(placed).toContain('data-evidence-source="turn-0-step-diag-early"');
+    expect(placed).toContain("Captured in turn 1");
+  });
+
+  it("keeps the previous layout without a story", () => {
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={projection}
+        investigationCase={investigationCase}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+        afterEvidence={<div data-next-steps>steps</div>}
+      />,
+    );
+    expect(html).toContain(">Evidence<");
+    expect(html).not.toContain("Captured results");
+    expect(html.indexOf("data-next-steps")).toBeGreaterThan(
+      html.indexOf("More evidence about this resource"),
+    );
+  });
+});
+
+describe("story log card", () => {
+  const ref = evidenceRef("c", "d");
+  const projection = projectInvestigationEvidence(
+    [
+      {
+        timeline: [
+          tool(
+            "wl",
+            "get_workload_logs",
+            {
+              workload: "deployments/shop/api",
+              pods: 1,
+              logs: [
+                {
+                  pod: "api-68c7b766dc-fmphn",
+                  container: "api",
+                  logs: {
+                    lines: [
+                      "2026-09-07T08:00:19Z boot",
+                      "2026-09-07T08:00:20Z connecting",
+                      "2026-09-07T08:00:21Z MongoServerError: Authentication failed.",
+                    ],
+                    totalLines: 50,
+                    matchedLines: 0,
+                    fallback: true,
+                  },
+                },
+              ],
+            },
+            {
+              evidenceRef: ref,
+              summary: JSON.stringify({
+                namespace: "shop",
+                name: "api",
+                kind: "deployment",
+              }),
+            },
+          ),
+        ],
+      },
+    ],
+    target,
+  );
+  const evidence: DiagnosisEvidenceItem[] = [
+    {
+      status: "linked",
+      ref,
+      role: "cause",
+      claim: "The log names the failure.",
+    },
+  ];
+  const investigationCase = resolveInvestigationCase(
+    projection,
+    { evidence },
+    0,
+  );
+  const html = renderToStaticMarkup(
+    <InvestigationEvidencePane
+      projection={projection}
+      investigationCase={investigationCase}
+      story={{
+        report: "The API cannot log in.\n\n[[radar:evidence=0]]\n",
+        evidence,
+      }}
+      collecting={false}
+      animateGroupIds={new Set()}
+      onViewSource={() => {}}
+      onViewActivity={() => {}}
+    />,
+  );
+  const story = html.slice(
+    html.indexOf('aria-label="Analysis"'),
+    html.indexOf("investigation-captured-results"),
+  );
+
+  it("shows the cited lines inline and keeps retrieval bookkeeping out of the story", () => {
+    expect(story).toContain("MongoServerError: Authentication failed.");
+    expect(story).toContain("Earlier lines");
+    expect(story).not.toContain("matched the filter");
+    expect(story).not.toContain("filter matched nothing");
+    expect(html).toContain("0 of 50 read lines matched the filter");
+  });
+});
+
+describe("story card gap clause", () => {
+  it("puts the clause on a compact card's row and under a full card without a label", () => {
+    const ref = evidenceRef("q", "r");
+    const projection = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "issues",
+              "issues",
+              { issues: [crashIssue], total: 1, total_matched: 1 },
+              {
+                evidenceRef: ref,
+              },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const evidence: DiagnosisEvidenceItem[] = [
+      {
+        status: "linked",
+        ref,
+        role: "cause",
+        claim: "",
+        gap: "this pod only, not the other replicas",
+      },
+    ];
+    const render = (report: string) =>
+      renderToStaticMarkup(
+        <InvestigationEvidencePane
+          projection={projection}
+          investigationCase={resolveInvestigationCase(
+            projection,
+            { evidence },
+            0,
+          )}
+          story={{ report, evidence }}
+          collecting={false}
+          animateGroupIds={new Set()}
+          onViewSource={() => {}}
+          onViewActivity={() => {}}
+        />,
+      );
+    const compact = render("It crashes.\n\n[[radar:evidence=0|compact]]");
+    expect(compact).toContain("data-agent-gap-hint");
+    expect(compact).toContain("this pod only, not the other replicas");
+    expect(compact).not.toContain("not shown");
+    const full = render("It crashes.\n\n[[radar:evidence=0]]");
+    // The record under Captured results keeps its labelled form.
+    const story = full.slice(0, full.indexOf("Captured results"));
+    expect(story).toMatch(
+      /data-agent-gap[^>]*>this pod only, not the other replicas</,
+    );
+    expect(story).not.toContain("Not shown:");
+  });
+});
+
+describe("story card defaults", () => {
+  it("shows the row a citation names on a listing card, inline", () => {
+    const listRef = evidenceRef("k", "l");
+    const projection = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "cms",
+              "list_resources",
+              [
+                { kind: "ConfigMap", name: "kube-root-ca.crt" },
+                { kind: "ConfigMap", name: "nginx-config" },
+              ],
+              {
+                evidenceRef: listRef,
+                summary: JSON.stringify({
+                  kind: "configmaps",
+                  namespace: "shop",
+                }),
+              },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const evidence: DiagnosisEvidenceItem[] = [
+      {
+        status: "linked",
+        ref: listRef,
+        role: "context",
+        claim: "",
+        subject: {
+          kind: "ConfigMap",
+          namespace: "shop",
+          name: "nginx-config",
+          observation: "resource",
+        },
+      },
+    ];
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={projection}
+        investigationCase={resolveInvestigationCase(
+          projection,
+          { evidence },
+          0,
+        )}
+        story={{
+          report: "The config exists.\n\n[[radar:evidence=0]]",
+          evidence,
+        }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    const start = html.indexOf("data-story-inventory-rows");
+    expect(start).toBeGreaterThan(-1);
+    // The inline block ends where the folded body (every row) begins.
+    const block = html.slice(start, html.indexOf('-body"', start));
+    expect(block).toContain("nginx-config");
+    expect(block).not.toContain("kube-root-ca.crt");
+  });
+
+  it("says when a cited entry is absent from the listing, or which entries a name could mean", () => {
+    expect(
+      namedInventoryRows(
+        [
+          { kind: "ConfigMap", namespace: "a", name: "config" },
+          { kind: "ConfigMap", namespace: "b", name: "config" },
+        ],
+        [
+          { subject: { kind: "ConfigMap", name: "config" } },
+          { subject: { kind: "ConfigMap", namespace: "b", name: "config" } },
+          { subject: { kind: "ConfigMap", name: "missing" } },
+          { subject: { kind: "ConfigMap", name: "missing" } },
+        ],
+      ),
+    ).toEqual([
+      { key: "/config", label: "config", matches: 2, row: undefined },
+      {
+        key: "b/config",
+        label: "b/config",
+        matches: 1,
+        row: { kind: "ConfigMap", namespace: "b", name: "config" },
+      },
+      { key: "/missing", label: "missing", matches: 0, row: undefined },
+    ]);
+    // Rows of a namespace-scoped listing omit their namespace: the scope is
+    // theirs, and only that namespace satisfies a namespaced citation.
+    const scoped = [{ kind: "ConfigMap", name: "config" }];
+    expect(
+      namedInventoryRows(
+        scoped,
+        [{ subject: { kind: "ConfigMap", namespace: "shop", name: "config" } }],
+        "shop",
+      )[0].matches,
+    ).toBe(1);
+    expect(
+      namedInventoryRows(
+        scoped,
+        [
+          {
+            subject: { kind: "ConfigMap", namespace: "other", name: "config" },
+          },
+        ],
+        "shop",
+      )[0].matches,
+    ).toBe(0);
+    expect(
+      namedInventoryRows(
+        [{ kind: "Namespace", name: "prod" }],
+        [{ subject: { kind: "Namespace", namespace: "other", name: "prod" } }],
+      )[0].matches,
+    ).toBe(0);
+    // A mixed listing holding a Service and a Deployment of one name shows
+    // the row of the kind the citation states.
+    expect(
+      namedInventoryRows(
+        [
+          { kind: "Service", namespace: "shop", name: "api" },
+          { kind: "Deployment", namespace: "shop", name: "api" },
+        ],
+        [{ subject: { kind: "Deployment", namespace: "shop", name: "api" } }],
+      )[0].row?.kind,
+    ).toBe("Deployment");
+    expect(
+      namedInventoryRows(
+        [{ kind: "APIService", name: "v1.apps" }],
+        [{ subject: { kind: "APIService", namespace: "", name: "v1.apps" } }],
+      )[0],
+    ).toEqual({
+      key: "/v1.apps",
+      label: "v1.apps",
+      matches: 1,
+      row: { kind: "APIService", name: "v1.apps" },
+    });
+  });
+
+  it("shows the chart inline on a metrics card placed as the symptom", () => {
+    const promRef = evidenceRef("m", "n");
+    const projection = projectInvestigationEvidence(
+      [
+        {
+          timeline: [
+            tool(
+              "diag",
+              "diagnose",
+              {
+                resource: {
+                  apiVersion: "apps/v1",
+                  kind: "Deployment",
+                  metadata: { namespace: "shop", name: "api" },
+                  spec: { replicas: 1 },
+                  status: { replicas: 1, readyReplicas: 1 },
+                },
+                pods: 1,
+                podNames: ["api-1"],
+                events: [],
+              },
+              { evidenceRef: evidenceRef("o", "p") },
+            ),
+            tool(
+              "prom",
+              "query_prometheus",
+              {
+                query:
+                  'sum(container_memory_working_set_bytes{namespace="shop",pod=~"^(api-1)$"})',
+                type: "range",
+                start: "2026-09-06T07:17:23Z",
+                end: "2026-09-06T09:17:23Z",
+                step: "25s",
+                resultType: "matrix",
+                seriesCount: 1,
+                series: [
+                  {
+                    labels: { pod: "api-1" },
+                    dataPoints: [
+                      { timestamp: 1_788_679_043, value: 169_377_792 },
+                      { timestamp: 1_788_679_068, value: 171_401_216 },
+                    ],
+                  },
+                ],
+                selectors: [
+                  {
+                    metric: "container_memory_working_set_bytes",
+                    matchers: [
+                      { label: "namespace", op: "=", value: "shop" },
+                      { label: "pod", op: "=~", value: "^(api-1)$" },
+                    ],
+                  },
+                ],
+              },
+              { evidenceRef: promRef, summary: "{}" },
+            ),
+          ],
+        },
+      ],
+      target,
+    );
+    const evidence: DiagnosisEvidenceItem[] = [
+      {
+        status: "linked",
+        ref: promRef,
+        role: "symptom",
+        claim: "",
+        subject: {
+          kind: "Deployment",
+          namespace: "shop",
+          name: "api",
+          observation: "metrics",
+        },
+      },
+    ];
+    const html = renderToStaticMarkup(
+      <InvestigationEvidencePane
+        projection={projection}
+        investigationCase={resolveInvestigationCase(
+          projection,
+          { evidence },
+          0,
+        )}
+        story={{ report: "Memory climbs.\n\n[[radar:evidence=0]]", evidence }}
+        collecting={false}
+        animateGroupIds={new Set()}
+        onViewSource={() => {}}
+        onViewActivity={() => {}}
+      />,
+    );
+    expect(html).toContain("data-story-metrics");
+  });
+});