@skyhook-io/radar-app 1.13.0 → 1.13.1

package/src/components/diagnose/DiagnoseSurface.test.tsx

@@ -1,5 +1,9 @@
 import { describe, expect, it } from "vitest";
-import { canStartNewInvestigation } from "./DiagnoseSurface";
+import { canCopyRunLink, canStartNewInvestigation } from "./DiagnoseSurface";
+import {
+  canContinueInvestigation,
+  canStopInvestigation,
+} from "./InvestigationView";
 import type { RunSummary } from "../../api/diagnose";
 
 // The "new investigation" button dispatches an agent and spends the user's own
@@ -34,9 +38,25 @@ describe("canStartNewInvestigation", () => {
 
   it("stays hidden while a turn is in flight", () => {
     // A start would be handed back the live run, so the button does nothing.
-    expect(canStartNewInvestigation("investigation", run("running"), false)).toBe(
-      false,
-    );
+    expect(
+      canStartNewInvestigation("investigation", run("running"), false),
+    ).toBe(false);
+  });
+
+  it("stays hidden while a stopped turn is draining", () => {
+    expect(
+      canStartNewInvestigation("investigation", run("stopping"), false),
+    ).toBe(false);
+  });
+
+  it("offers a separate human investigation while an automatic run is in flight", () => {
+    expect(
+      canStartNewInvestigation(
+        "investigation",
+        { ...run("running"), trigger: "background" },
+        false,
+      ),
+    ).toBe(true);
   });
 
   it("stays hidden on a stale run", () => {
@@ -63,8 +83,101 @@ describe("canStartNewInvestigation", () => {
     expect(canStartNewInvestigation("investigation", run("error"), false)).toBe(
       true,
     );
-    expect(canStartNewInvestigation("investigation", run("stopped"), false)).toBe(
+    expect(
+      canStartNewInvestigation("investigation", run("stopped"), false),
+    ).toBe(true);
+  });
+});
+
+describe("canStopInvestigation", () => {
+  it("lets the terminal transcript outrank a lagging running summary", () => {
+    expect(canStopInvestigation(run("running"), false, false, "done")).toBe(
+      false,
+    );
+    expect(canStopInvestigation(run("running"), false, false, "error")).toBe(
+      false,
+    );
+  });
+
+  it("keeps Stop available for an active human turn", () => {
+    expect(canStopInvestigation(run("running"), true, false, "running")).toBe(
       true,
     );
   });
+
+  it("does not offer another Stop while the server drains the turn", () => {
+    expect(canStopInvestigation(run("stopping"), true, false, "running")).toBe(
+      false,
+    );
+  });
+
+  it("never lets a missing or automatic run expose Stop", () => {
+    expect(canStopInvestigation(run("running"), true, true, "running")).toBe(
+      false,
+    );
+    expect(
+      canStopInvestigation(
+        { ...run("running"), trigger: "background" },
+        true,
+        false,
+        "running",
+      ),
+    ).toBe(false);
+  });
+});
+
+describe("canContinueInvestigation", () => {
+  it("lets a terminal transcript outrank only a lagging running human summary", () => {
+    expect(
+      canContinueInvestigation(
+        { ...run("running"), canContinue: false },
+        "done",
+      ),
+    ).toBe(true);
+  });
+
+  it("keeps genuinely read-only and sessionless investigations read-only", () => {
+    expect(
+      canContinueInvestigation(
+        {
+          ...run("running"),
+          trigger: "background",
+          canContinue: false,
+        },
+        "done",
+      ),
+    ).toBe(false);
+    expect(
+      canContinueInvestigation({ ...run("done"), canContinue: false }, "done"),
+    ).toBe(false);
+  });
+
+  it("does not offer a follow-up after the retained run disappears", () => {
+    expect(
+      canContinueInvestigation(
+        { ...run("running"), canContinue: false },
+        "error",
+        true,
+      ),
+    ).toBe(false);
+  });
+});
+
+describe("canCopyRunLink", () => {
+  it("does not expose collaboration UI for an OSS run", () => {
+    expect(canCopyRunLink(run("done"))).toBe(false);
+  });
+
+  it("exposes the copy action only for a canonical hosted URL", () => {
+    expect(
+      canCopyRunLink({
+        ...run("done"),
+        radarUrl: "/c/cluster-1?org=org-1&ai-run=r1",
+      }),
+    ).toBe(true);
+  });
+
+  it("treats an empty hosted URL as unavailable", () => {
+    expect(canCopyRunLink({ ...run("done"), radarUrl: "" })).toBe(false);
+  });
 });

package/src/components/diagnose/DiagnoseSurface.tsx

@@ -16,8 +16,13 @@ import {
   Copy,
   Check,
   Plus,
+  Link,
+  Lock,
+  Users,
 } from "lucide-react";
 import { Tooltip } from "../ui/Tooltip";
+import { ConfirmDialog } from "../ui/ConfirmDialog";
+import { Badge } from "@skyhook-io/k8s-ui/components/ui/Badge";
 import {
   useDiagnose,
   useDiagnoseLayout,
@@ -31,7 +36,11 @@ import { RecentList } from "./Home";
 import { AgentSetupNotice } from "./AgentSetupNotice";
 import { ConsentCard } from "./parts";
 import { buildLaunchCommand, launchAgentLabel, openInTerminal } from "./launch";
-import { type RunSummary, type ExecutionProfile } from "../../api/diagnose";
+import {
+  updateRunVisibility,
+  type RunSummary,
+  type ExecutionProfile,
+} from "../../api/diagnose";
 import { routePath } from "../../api/config";
 import { useCapabilitiesContext } from "../../contexts/CapabilitiesContext";
 
@@ -71,7 +80,10 @@ function InvestigationMenu({ run }: { run: RunSummary }) {
   const [copied, setCopied] = useState(false);
   const { localTerminal } = useCapabilitiesContext();
   const label = launchAgentLabel(run);
-  const command = buildLaunchCommand(run, `${window.location.origin}${routePath('/mcp')}`);
+  const command = buildLaunchCommand(
+    run,
+    `${window.location.origin}${routePath("/mcp")}`,
+  );
   // No resumable session yet (or stale run) → nothing to hand off.
   if (!command) return null;
 
@@ -143,6 +155,135 @@ function InvestigationMenu({ run }: { run: RunSummary }) {
   );
 }
 
+export function canCopyRunLink(
+  run: RunSummary | null | undefined,
+): run is RunSummary & { radarUrl: string } {
+  return typeof run?.radarUrl === "string" && run.radarUrl.length > 0;
+}
+
+function CopyRunLink({ radarUrl, visibility }: { radarUrl: string; visibility: RunSummary["visibility"] }) {
+  const label = visibility === "private"
+    ? "Copy private link (only you can open it)"
+    : "Copy investigation link";
+  const [copyState, setCopyState] = useState<"idle" | "copied" | "error">(
+    "idle",
+  );
+  const copy = async () => {
+    try {
+      if (!navigator.clipboard) throw new Error("clipboard unavailable");
+      await navigator.clipboard.writeText(
+        new URL(radarUrl, window.location.origin).href,
+      );
+      setCopyState("copied");
+    } catch {
+      setCopyState("error");
+    }
+    setTimeout(() => setCopyState("idle"), 1500);
+  };
+  return (
+    <Tooltip
+      content={
+        copyState === "copied"
+          ? "Link copied"
+          : copyState === "error"
+            ? "Couldn’t copy link"
+            : label
+      }
+      position="bottom"
+    >
+      <button
+        onClick={copy}
+        className="rounded-md p-1 text-theme-text-tertiary hover:bg-theme-hover hover:text-theme-text-primary"
+        aria-label={label}
+      >
+        {copyState === "copied" ? (
+          <Check className="h-4 w-4 text-emerald-500" />
+        ) : (
+          <Link className="h-4 w-4" />
+        )}
+      </button>
+    </Tooltip>
+  );
+}
+
+function VisibilityControl({
+  run,
+  onChanged,
+}: {
+  run: RunSummary;
+  onChanged: (run: RunSummary) => void;
+}) {
+  const [busy, setBusy] = useState(false);
+  const [error, setError] = useState(false);
+  const [confirmShare, setConfirmShare] = useState(false);
+  if (!run.canManageVisibility) {
+    return run.visibility === "organization" ? (
+      <Tooltip content="Shared with your organization" position="bottom">
+        <Badge severity="neutral" size="sm" className="shrink-0">
+          <Users className="h-3 w-3" />
+          Organization
+        </Badge>
+      </Tooltip>
+    ) : null;
+  }
+  const shared = run.visibility === "organization";
+  const update = () => {
+    if (busy) return;
+    setBusy(true);
+    setError(false);
+    updateRunVisibility(run.id, shared ? "private" : "organization")
+      .then((updated) => {
+        onChanged(updated);
+        setConfirmShare(false);
+      })
+      .catch(() => setError(true))
+      .finally(() => setBusy(false));
+  };
+  const label = shared ? "Organization" : "Private";
+  return (
+    <>
+      <Tooltip
+        content={
+          error
+            ? "Couldn't change sharing"
+            : shared
+              ? "Shared with your organization — make private"
+              : "Private — click to let organization members access this investigation"
+        }
+        position="bottom"
+      >
+        <button
+          onClick={() => (shared ? update() : setConfirmShare(true))}
+          disabled={busy}
+          className="flex items-center gap-1 rounded-md border border-theme-border/70 px-1.5 py-1 text-[11px] font-medium text-theme-text-secondary hover:bg-theme-hover hover:text-theme-text-primary disabled:opacity-50"
+          aria-label={
+            shared
+              ? "Shared with your organization — make private"
+              : "Private — click to let organization members access this investigation"
+          }
+        >
+          {shared ? (
+            <Users className="h-3.5 w-3.5" />
+          ) : (
+            <Lock className="h-3.5 w-3.5" />
+          )}
+          {label}
+        </button>
+      </Tooltip>
+      <ConfirmDialog
+        open={confirmShare}
+        onClose={() => !busy && setConfirmShare(false)}
+        onConfirm={update}
+        title="Share this investigation?"
+        message="Everyone in your organization can read this entire investigation—including your questions and the logs and manifests Radar read—and can continue or stop it."
+        confirmLabel="Share with organization"
+        variant="warning"
+        isLoading={busy}
+      />
+    </>
+  );
+}
+
 // The panel is an ABSOLUTE slot inside the app's body frame (the column under the
 // header, right of the nav rail) — App renders it there and passes topInset (the
 // header height; 0 in chromeless embeds). It shares that frame with the resource/
@@ -154,8 +295,9 @@ function InvestigationMenu({ run }: { run: RunSummary }) {
 //                 the last focused run. Without this the button dispatches an
 //                 agent — real tokens — from a screen showing an unrelated list.
 //   run           nothing to take a resource from.
-//   running       a start is handed back the live run, so the click does nothing
-//                 and the button reads as broken.
+//   running/stopping a human start is handed back the live run, so the click does
+//                 nothing. An automatic run is a different, immutable session,
+//                 so it deliberately keeps the fresh human escape hatch.
 //   stale         the body already offers "Re-run on current cluster" WITH the
 //                 warning that the context changed; a bare + carries none of it,
 //                 and the resource may not exist in the context it'd run against.
@@ -168,7 +310,8 @@ export function canStartNewInvestigation(
   return (
     view === "investigation" &&
     !!run &&
-    run.status !== "running" &&
+    ((run.status !== "running" && run.status !== "stopping") ||
+      run.trigger === "background") &&
     run.status !== "stale" &&
     !needsConsent
   );
@@ -220,23 +363,28 @@ export function DiagnoseSurface({ topInset = 0 }: { topInset?: number }) {
     d.setupState === "needs-install" || d.setupState === "needs-restart";
 
   const activeRun = d.runs.find((r) => r.id === d.activeRunId) ?? null;
+  // Docked Home is a list, not the previously focused run. Scope every header
+  // label/action to what is visibly on screen so Copy/Share cannot act on a run
+  // the user has navigated away from. Expanded mode remains master-detail and
+  // therefore keeps the selected run active beside its history list.
+  const headerRun = !maximized && d.view === "home" ? null : activeRun;
   // A focused run shows the agent it actually ran with; Home reflects the current pick.
-  const activeAgentLabel = activeRun?.agent
-    ? agentLabelFor(activeRun.agent)
+  const activeAgentLabel = headerRun?.agent
+    ? agentLabelFor(headerRun.agent)
     : d.agentLabel;
   // Header subtitle: the config a focused run actually used (it records agent /
   // profile / model / effort), or the current defaults on Home. Codex shows mode
   // + reasoning effort; model is shown only when overridden. Clicking opens Settings.
   const configLine = buildConfigLine(
-    activeRun ?? {
+    headerRun ?? {
       agent: d.selectedAgent,
       profile: d.hosted ? undefined : d.profile,
       model: d.model,
       effort: d.effort,
     },
   );
-  const detailTitle = activeRun
-    ? `${activeRun.kind} ${activeRun.namespace ? `${activeRun.namespace}/` : ""}${activeRun.name}`
+  const detailTitle = headerRun
+    ? `${headerRun.kind} ${headerRun.namespace ? `${headerRun.namespace}/` : ""}${headerRun.name}`
     : "AI investigations";
 
   // Absolute within the body frame: maximized fills it; docked is a right slot.
@@ -280,12 +428,13 @@ export function DiagnoseSurface({ topInset = 0 }: { topInset?: number }) {
     </div>
   ) : d.activeRunId && d.runsLoaded ? (
     // A focused id that isn't in the loaded list — a deep link (?ai-run=…) to a
-    // cleared/evicted/unknown run. Say so; the generic "select an
+    // private/revoked/cleared/unknown run. The generic "select an
     // investigation" placeholder would read as a broken link.
     <div className="flex flex-1 flex-col items-center justify-center gap-3 px-6 text-center">
       <p className="text-sm text-theme-text-secondary">
-        This investigation is no longer available — history keeps the most
-        recent investigations, and this one has been cleared.
+        This investigation is unavailable. It may be private, your access may
+        have changed, or its history may have been cleared. Check your account
+        and organization, or ask the creator for access.
       </p>
       <button
         onClick={d.goHome}
@@ -375,27 +524,36 @@ export function DiagnoseSurface({ topInset = 0 }: { topInset?: number }) {
           </div>
         </div>
         <div className="flex shrink-0 items-center gap-0.5">
-          {activeRun &&
-            canStartNewInvestigation(d.view, activeRun, d.needsConsent) && (
-            <Tooltip content="New investigation on this resource" position="bottom">
-              <button
-                onClick={() =>
-                  d.openInvestigation({
-                    kind: activeRun.kind,
-                    namespace: activeRun.namespace,
-                    name: activeRun.name,
-                    issueId: activeRun.issueId,
-                    fresh: true,
-                  })
-                }
-                className="rounded-md p-1 text-theme-text-tertiary hover:bg-theme-hover hover:text-theme-text-primary"
-                aria-label="New investigation on this resource"
+          {headerRun &&
+            canStartNewInvestigation(d.view, headerRun, d.needsConsent) && (
+              <Tooltip
+                content="New investigation on this resource"
+                position="bottom"
               >
-                <Plus className="h-4 w-4" />
-              </button>
-            </Tooltip>
+                <button
+                  onClick={() =>
+                    d.openInvestigation({
+                      kind: headerRun.kind,
+                      namespace: headerRun.namespace,
+                      name: headerRun.name,
+                      issueId: headerRun.issueId,
+                      fresh: true,
+                    })
+                  }
+                  className="rounded-md p-1 text-theme-text-tertiary hover:bg-theme-hover hover:text-theme-text-primary"
+                  aria-label="New investigation on this resource"
+                >
+                  <Plus className="h-4 w-4" />
+                </button>
+              </Tooltip>
+            )}
+          {headerRun && (
+            <VisibilityControl run={headerRun} onChanged={d.updateRunSummary} />
+          )}
+          {canCopyRunLink(headerRun) && (
+            <CopyRunLink radarUrl={headerRun.radarUrl} visibility={headerRun.visibility} />
           )}
-          {activeRun && <InvestigationMenu run={activeRun} />}
+          {headerRun && <InvestigationMenu run={headerRun} />}
           <Tooltip content={maximized ? "Restore" : "Expand"} position="bottom">
             <button
               onClick={() => setMaximized((v) => !v)}

package/src/components/diagnose/Home.tsx

@@ -3,6 +3,7 @@
 // docked Home view and the master pane of the maximized workspace.
 import { Loader2, Sparkles } from "lucide-react";
 import { StatusDot, type StatusTone } from "@skyhook-io/k8s-ui";
+import { Badge } from "@skyhook-io/k8s-ui/components/ui/Badge";
 import { type RunSummary } from "../../api/diagnose";
 
 // Compact "3m ago" / "2h ago" / date label.
@@ -31,7 +32,7 @@ function runTone(status: RunSummary["status"]): StatusTone {
 }
 
 function statusDot(status: RunSummary["status"]) {
-  if (status === "running")
+  if (status === "running" || status === "stopping")
     return <Loader2 className="h-3 w-3 shrink-0 animate-spin text-accent" />;
   return <StatusDot tone={runTone(status)} className="shrink-0" />;
 }
@@ -47,6 +48,8 @@ function statusWord(
       return { text: "Failed", cls: "text-red-400" };
     case "stopped":
       return { text: "Stopped", cls: "text-theme-text-tertiary" };
+    case "stopping":
+      return { text: "Stopping", cls: "text-theme-text-tertiary" };
     case "stale":
       // Plain words, not the internal status name: "stale" means the run was
       // about a cluster that's no longer connected.
@@ -83,80 +86,106 @@ export function RecentList({
   if (runs.length === 0) {
     return (
       <div>
-      {degradedNote}
-      <div className="flex flex-col items-center px-4 py-12 text-center">
-        <Sparkles className="mb-3 h-7 w-7 text-accent" />
-        <div className="text-sm font-medium text-theme-text-primary">
-          No investigations yet
+        {degradedNote}
+        <div className="flex flex-col items-center px-4 py-12 text-center">
+          <Sparkles className="mb-3 h-7 w-7 text-accent" />
+          <div className="text-sm font-medium text-theme-text-primary">
+            No investigations yet
+          </div>
+          <p className="mt-1 max-w-xs text-sm text-theme-text-tertiary">
+            Open a resource and use its{" "}
+            <Sparkles className="inline h-3.5 w-3.5 align-text-bottom text-accent" />{" "}
+            action to investigate it with {agentLabel} —{" "}
+            <span className="font-medium text-theme-text-secondary">
+              Diagnose
+            </span>{" "}
+            a problem, or just ask about it. Investigations run in the
+            background and are kept in your history here.
+          </p>
         </div>
-        <p className="mt-1 max-w-xs text-sm text-theme-text-tertiary">
-          Open a resource and use its{" "}
-          <Sparkles className="inline h-3.5 w-3.5 align-text-bottom text-accent" />{" "}
-          action to investigate it with {agentLabel} —{" "}
-          <span className="font-medium text-theme-text-secondary">Diagnose</span>{" "}
-          a problem, or just ask about it. Investigations run in the background
-          and are kept in your history here.
-        </p>
-      </div>
       </div>
     );
   }
 
+  const organizationRuns = runs.filter(
+    (r) => r.trigger === "background" || r.ownedByMe === false,
+  );
+  const yourRuns = runs.filter((r) => !organizationRuns.includes(r));
+  const groups = organizationRuns.length
+    ? [
+        { label: "Your investigations", runs: yourRuns },
+        { label: "Organization", runs: organizationRuns },
+      ].filter((group) => group.runs.length > 0)
+    : [{ label: "Investigations", runs }];
+
   return (
     <div className="space-y-2">
       {degradedNote}
-      <div className="text-[11px] font-medium uppercase tracking-wide text-theme-text-tertiary">
-        Investigations
-      </div>
-      {runs.map((r) => (
-        <button
-          key={r.id}
-          onClick={() => onSelect(r.id)}
-          className={`flex w-full flex-col gap-0.5 rounded-md border px-2.5 py-2 text-left ${
-            r.id === selectedId
-              ? "border-accent/50 bg-accent/10"
-              : "border-theme-border/60 bg-theme-base/40 hover:bg-theme-hover"
-          }`}
-        >
-          <div className="flex items-center gap-2">
-            {statusDot(r.status)}
-            <span className="min-w-0 flex-1 truncate text-sm text-theme-text-primary">
-              {r.kind} {r.namespace ? `${r.namespace}/` : ""}
-              {r.name}
-            </span>
-            <span className="shrink-0 text-[11px] text-theme-text-tertiary">
-              {r.status === "running" ? (
-                "running…"
-              ) : (
-                <>
-                  {(() => {
-                    const w = statusWord(r.status);
-                    return w ? (
-                      <span className={`font-medium ${w.cls}`}>
-                        {w.text} ·{" "}
-                      </span>
-                    ) : null;
-                  })()}
-                  {relativeTime(new Date(r.updatedAt).getTime(), now)}
-                </>
-              )}
-            </span>
+      {groups.map((group) => (
+        <div key={group.label} className="space-y-2">
+          <div className="pt-1 text-[11px] font-medium uppercase tracking-wide text-theme-text-tertiary">
+            {group.label}
           </div>
-          {(r.status === "stale" && r.context) || r.preview ? (
-            <div className="truncate pl-3.5 text-xs text-theme-text-tertiary">
-              {/* A foreign-cluster run names its cluster — in mixed multi-
-                  context history, identical-looking rows otherwise give no way
-                  to tell WHICH cluster an investigation was about. */}
-              {r.status === "stale" && r.context ? (
-                <span className="text-amber-600/80 dark:text-amber-500/80">
-                  {r.context}
+          {group.runs.map((r) => (
+            <button
+              key={r.id}
+              onClick={() => onSelect(r.id)}
+              className={`flex w-full flex-col gap-0.5 rounded-md border px-2.5 py-2 text-left ${
+                r.id === selectedId
+                  ? "border-accent/50 bg-accent/10"
+                  : "border-theme-border/60 bg-theme-base/40 hover:bg-theme-hover"
+              }`}
+            >
+              <div className="flex items-center gap-2">
+                {statusDot(r.status)}
+                <span className="min-w-0 flex-1 truncate text-sm text-theme-text-primary">
+                  {r.kind} {r.namespace ? `${r.namespace}/` : ""}
+                  {r.name}
                 </span>
+                {(r.trigger || r.visibility) && (
+                  <Badge severity="neutral" size="sm" className="shrink-0">
+                    {r.trigger === "background"
+                      ? "Automatic"
+                      : r.visibility === "organization"
+                        ? "Shared"
+                        : "Private"}
+                  </Badge>
+                )}
+                <span className="shrink-0 text-[11px] text-theme-text-tertiary">
+                  {r.status === "running" || r.status === "stopping" ? (
+                    r.status === "stopping" ? "stopping…" : "running…"
+                  ) : (
+                    <>
+                      {(() => {
+                        const w = statusWord(r.status);
+                        return w ? (
+                          <span className={`font-medium ${w.cls}`}>
+                            {w.text} ·{" "}
+                          </span>
+                        ) : null;
+                      })()}
+                      {relativeTime(new Date(r.updatedAt).getTime(), now)}
+                    </>
+                  )}
+                </span>
+              </div>
+              {(r.status === "stale" && r.context) || r.preview ? (
+                <div className="truncate pl-3.5 text-xs text-theme-text-tertiary">
+                  {/* A foreign-cluster run names its cluster — in mixed multi-
+                      context history, identical-looking rows otherwise give no way
+                      to tell WHICH cluster an investigation was about. */}
+                  {r.status === "stale" && r.context ? (
+                    <span className="text-amber-600/80 dark:text-amber-500/80">
+                      {r.context}
+                    </span>
+                  ) : null}
+                  {r.status === "stale" && r.context && r.preview ? " · " : ""}
+                  {r.preview}
+                </div>
               ) : null}
-              {r.status === "stale" && r.context && r.preview ? " · " : ""}
-              {r.preview}
-            </div>
-          ) : null}
-        </button>
+            </button>
+          ))}
+        </div>
       ))}
     </div>
   );