@skyhook-io/radar-app 1.12.3 → 1.13.0

package/src/components/settings/settings-state.test.ts

@@ -0,0 +1,42 @@
+import { describe, expect, it } from "vitest";
+import {
+  costSourceApplyLabel,
+  shouldOfferCostReview,
+  shouldShowSettingsFooter,
+} from "./settings-state";
+
+describe("Cost settings state", () => {
+  it("keeps source drafts inline while the Cost section is open", () => {
+    expect(shouldOfferCostReview(true, "cost")).toBe(false);
+    expect(
+      shouldShowSettingsFooter({
+        canEditConfig: true,
+        confirmingClose: false,
+        configDirty: false,
+        costIntegrationDirty: true,
+        section: "cost",
+        hasSaveMessage: false,
+      }),
+    ).toBe(false);
+  });
+
+  it("offers review from other sections and retains the close guard", () => {
+    expect(shouldOfferCostReview(true, "overview")).toBe(true);
+    expect(
+      shouldShowSettingsFooter({
+        canEditConfig: true,
+        confirmingClose: true,
+        configDirty: false,
+        costIntegrationDirty: true,
+        section: "cost",
+        hasSaveMessage: false,
+      }),
+    ).toBe(true);
+  });
+
+  it("only claims to test sources that the backend probes", () => {
+    expect(costSourceApplyLabel("auto")).toBe("Test & apply source");
+    expect(costSourceApplyLabel("kubecost")).toBe("Test & apply source");
+    expect(costSourceApplyLabel("prometheus")).toBe("Apply source");
+  });
+});

package/src/components/settings/settings-state.ts

@@ -0,0 +1,39 @@
+export type SettingsSectionId =
+  | 'overview'
+  | 'perms'
+  | 'connection'
+  | 'prometheus'
+  | 'cost'
+  | 'argocd'
+  | 'ai'
+  | 'advanced'
+
+export function shouldOfferCostReview(
+  costIntegrationDirty: boolean,
+  section: SettingsSectionId,
+): boolean {
+  return costIntegrationDirty && section !== 'cost'
+}
+
+export function shouldShowSettingsFooter(input: {
+  canEditConfig: boolean
+  confirmingClose: boolean
+  configDirty: boolean
+  costIntegrationDirty: boolean
+  section: SettingsSectionId
+  hasSaveMessage: boolean
+}): boolean {
+  return (
+    input.canEditConfig &&
+    (input.confirmingClose ||
+      input.configDirty ||
+      shouldOfferCostReview(input.costIntegrationDirty, input.section) ||
+      input.hasSaveMessage)
+  )
+}
+
+export function costSourceApplyLabel(
+  source: 'auto' | 'prometheus' | 'kubecost',
+): string {
+  return source === 'prometheus' ? 'Apply source' : 'Test & apply source'
+}

package/src/index.css

@@ -269,8 +269,18 @@ body {
 .animate-transcript-enter {
   animation: transcript-enter 180ms ease-out both;
 }
+
+@keyframes status-enter {
+  from { opacity: 0; }
+  to { opacity: 1; }
+}
+.animate-status-enter {
+  animation: status-enter 140ms ease-out both;
+}
+
 @media (prefers-reduced-motion: reduce) {
-  .animate-transcript-enter {
+  .animate-transcript-enter,
+  .animate-status-enter {
     animation: none;
   }
 }