@skyhook-io/radar-app 1.12.2 → 1.13.0

package/src/components/resources/PodFilesystemModal.tsx

@@ -1,4 +1,4 @@
-import { useState, useRef, useEffect, useMemo, useCallback } from 'react'
+import { createElement, useState, useRef, useEffect, useMemo, useCallback } from 'react'
 import { createPortal } from 'react-dom'
 import { X, File, Link2, ChevronRight, AlertTriangle, Loader2, Search, Download, FolderOpen } from 'lucide-react'
 import { PaneLoader, Input } from '@skyhook-io/k8s-ui'
@@ -7,6 +7,9 @@ import type { FileNode } from '../../types'
 import { formatBytes } from '../../utils/format'
 import { downloadBlob, filterTree } from './file-browser-utils'
 import { apiUrl, getAuthHeaders, getCredentialsMode } from '../../api/config'
+import { isDesktopApp } from '../../utils/desktop-download'
+import { openFile, openFolder } from '../../utils/desktop-open-folder'
+import { useToast } from '../ui/Toast'
 import { Tooltip } from '../ui/Tooltip'
 
 interface PodFilesystem {
@@ -35,6 +38,36 @@ async function fetchPodFiles(
   return response.json()
 }
 
+/**
+ * Desktop only: has the backend write the pod file straight to disk. The browser
+ * route would hand the whole file to the webview only to have it hand every byte
+ * back to be saved, which is what puts a large file out of reach there.
+ * Returns the path it was saved to.
+ */
+async function savePodFileToDisk(
+  namespace: string,
+  podName: string,
+  container: string,
+  filePath: string,
+): Promise<string> {
+  const params = new URLSearchParams()
+  params.set('container', container)
+  params.set('path', filePath)
+
+  const response = await fetch(apiUrl(`/pods/${namespace}/${podName}/files/save?${params.toString()}`), {
+    method: 'POST',
+    credentials: getCredentialsMode(),
+    headers: getAuthHeaders(),
+  })
+  if (response.status === 204) throw new Error('cancelled')
+  if (!response.ok) {
+    const error = await response.json().catch(() => ({ error: 'Save failed' }))
+    throw new Error(error.error || `HTTP ${response.status}`)
+  }
+  const body = await response.json()
+  return body.path
+}
+
 interface PodFilesystemModalProps {
   open: boolean
   onClose: () => void
@@ -309,6 +342,7 @@ interface PodFileTreeNodeProps {
 
 function PodFileTreeNode({ node, namespace, podName, container, onNavigate }: PodFileTreeNodeProps) {
   const [downloading, setDownloading] = useState(false)
+  const { showSuccess, showError } = useToast()
   const isDir = node.type === 'dir'
   const isSymlink = node.type === 'symlink'
   const isDownloadable = !isDir // files and symlinks can be downloaded
@@ -319,6 +353,21 @@ function PodFileTreeNode({ node, namespace, podName, container, onNavigate }: Po
 
     setDownloading(true)
     try {
+      if (await isDesktopApp()) {
+        const savedPath = await savePodFileToDisk(namespace, podName, container, node.path)
+        showSuccess(
+          'File saved',
+          savedPath,
+          {
+            label: 'Show in Finder',
+            icon: createElement(FolderOpen, { className: 'w-3.5 h-3.5' }),
+            onClick: () => openFolder(savedPath),
+          },
+          () => openFile(savedPath),
+        )
+        return
+      }
+
       const params = new URLSearchParams()
       params.set('container', container)
       params.set('path', node.path)
@@ -335,7 +384,10 @@ function PodFileTreeNode({ node, namespace, podName, container, onNavigate }: Po
       const blob = await response.blob()
       await downloadBlob(blob, node.name)
     } catch (err) {
-      console.error('Download failed:', err)
+      const message = err instanceof Error ? err.message : String(err)
+      if (message !== 'cancelled') {
+        showError(`Could not download ${node.name}`, message)
+      }
     } finally {
       setDownloading(false)
     }

package/src/components/resources/ResourcesView.tsx

@@ -16,10 +16,12 @@ import {
   ResourcesView as BaseResourcesView,
   CORE_RESOURCES,
   intersectWorkloadWrites,
+  hasCuratedColumns,
+  sanitizePrinterTable,
 } from '@skyhook-io/k8s-ui'
-import type { Capabilities, ResourceQueryResult, WorkloadWritePermissions } from '@skyhook-io/k8s-ui'
+import type { Capabilities, PrinterTable, ResourceQueryResult, WorkloadWritePermissions } from '@skyhook-io/k8s-ui'
 import type { SelectedResource } from '../../types'
-import { kindToPlural, type NavigateToResource } from '../../utils/navigation'
+import { apiVersionToGroup, kindToPluralWithGroup, type NavigateToResource } from '../../utils/navigation'
 import { CreateResourceDialog } from '../shared/CreateResourceDialog'
 import { getSkeletonYaml } from '../../utils/skeleton-yaml'
 
@@ -229,12 +231,19 @@ export function ResourcesView({ namespaces, selectedResource, onResourceClick, o
   // Fetch full data only for the selected kind
   const selectedKindQuery = useQuery({
     queryKey: ['resources', selectedKind?.name, isSelectedCrd ? selectedKind?.group : '', namespaces],
-    queryFn: async () => {
-      if (!selectedKind) return []
+    queryFn: async (): Promise<{ items: any[]; printerTable: PrinterTable | null }> => {
+      if (!selectedKind) return { items: [], printerTable: null }
       const params = new URLSearchParams()
       if (namespaces.length > 0) params.set('namespaces', namespacesParam)
       if (isSelectedCrd && selectedKind.group) params.set('group', selectedKind.group)
       if (selectedKindSummaryServed) params.set('include', 'summary')
+      // Only CRDs can declare printer columns, and a curated kind discards the
+      // result — so table mode is requested from exactly the kinds that can use
+      // it. Resolving a table costs the server a CRD read per request; doing
+      // that for a kind whose columns are hand-curated is pure waste.
+      const wantsTable = isSelectedCrd && !!selectedKind.group &&
+        !hasCuratedColumns(selectedKind.name, selectedKind.group)
+      if (wantsTable) params.set('table', '1')
       const startedAt = performance.now()
       debugNamespaceLog('resources:selected-kind-fetch-start', {
         kind: selectedKind.name,
@@ -258,7 +267,19 @@ export function ResourcesView({ namespaces, selectedResource, onResourceClick, o
         const errorData = await res.json().catch(() => ({ error: `HTTP ${res.status}` }))
         throw new ApiError(errorData.error || `Failed to fetch ${selectedKind.name}`, res.status, errorData)
       }
-      return res.json()
+      const body = await res.json()
+      // Both branches are current shapes, not a guess at a legacy one: a Radar
+      // backend that predates `table` ignores the parameter and answers with
+      // the bare array. @skyhook-io/radar-app is versioned independently of the
+      // backend it points at, so a consumer can pair a new frontend with an
+      // older Radar — and reading that array as a missing envelope would render
+      // every CRD list empty. Items and columns still come from one response,
+      // so a row can never render against another fetch's cells.
+      if (!wantsTable || Array.isArray(body)) return { items: body as any[], printerTable: null }
+      return {
+        items: Array.isArray(body?.items) ? body.items as any[] : [],
+        printerTable: sanitizePrinterTable(body),
+      }
     },
     enabled: !!selectedKind && !selectedKindQueryBlocked,
     staleTime: 30000,
@@ -275,13 +296,13 @@ export function ResourcesView({ namespaces, selectedResource, onResourceClick, o
     return {
       resourceName: selectedKind.name,
       group: selectedKind.group,
-      data: selectedKindQueryBlocked ? [] : selectedKindQuery.data as any[] | undefined,
+      data: selectedKindQueryBlocked ? [] : selectedKindQuery.data?.items,
       isLoading: waitingForGuardCount || selectedKindQuery.isLoading,
       error: selectedKindQueryBlocked ? undefined : selectedKindQuery.error,
       refetch: selectedKindQuery.refetch,
       dataUpdatedAt: selectedKindQuery.dataUpdatedAt,
     }
-  }, [selectedKind, selectedKindQueryBlocked, waitingForGuardCount, selectedKindQuery.data, selectedKindQuery.isLoading, selectedKindQuery.error, selectedKindQuery.refetch, selectedKindQuery.dataUpdatedAt])
+  }, [selectedKind, selectedKindQueryBlocked, waitingForGuardCount, selectedKindQuery.data?.items, selectedKindQuery.isLoading, selectedKindQuery.error, selectedKindQuery.refetch, selectedKindQuery.dataUpdatedAt])
 
   // Metrics
   const { data: topPodMetrics } = useTopPodMetrics({ enabled: topPodMetricsEnabled, namespaces })
@@ -352,6 +373,7 @@ export function ResourcesView({ namespaces, selectedResource, onResourceClick, o
       resourceReasons={countsData?.reasons}
       resourceUnavailable={countsData?.unavailable}
       selectedKindQuery={selectedKindQueryResult}
+      printerTable={selectedKindQueryBlocked ? null : selectedKindQuery.data?.printerTable ?? null}
       connectionState={connection.state}
       largeListGuard={largeListGuard}
       onSelectedKindChange={setSelectedKind}
@@ -394,7 +416,8 @@ export function ResourcesView({ namespaces, selectedResource, onResourceClick, o
       initialYaml={createDialogYaml}
       title={createDialogTitle}
       onCreated={(result) => {
-        onResourceClick?.({ kind: kindToPlural(result.kind), namespace: result.namespace, name: result.name, group: '' })
+        const group = apiVersionToGroup(result.apiVersion)
+        onResourceClick?.({ kind: kindToPluralWithGroup(result.kind, group), namespace: result.namespace, name: result.name, group })
       }}
     />
     </>

package/src/components/resources/renderers/WorkloadRenderer.tsx

@@ -4,8 +4,8 @@ import { useScaleWorkload, fetchJSON } from '../../../api/client'
 import { useRBACSubject } from '../../../api/rbac'
 import { usePolicyResource } from '../../../api/policy'
 import { useQueries, useQueryClient } from '@tanstack/react-query'
-import { kindToPlural } from '@skyhook-io/k8s-ui/utils/navigation'
-import type { Relationships, ResourceRef, ResourceWithRelationships } from '../../../types'
+import { kindToPlural, kindToPluralWithGroup } from '@skyhook-io/k8s-ui/utils/navigation'
+import type { Relationships, ResourceRef, ResourceWithRelationships, WorkloadPodInfo } from '../../../types'
 import type { ScalerDiagnosis } from '@skyhook-io/k8s-ui/components/resources/renderers/WorkloadRenderer'
 
 // Map plural lowercase kind to singular PascalCase for ownerReferences matching
@@ -26,9 +26,10 @@ interface WorkloadRendererProps {
   onNavigate?: (ref: ResourceRef) => void
   relationships?: Relationships
   scaleBlockedBy?: ResourceRef[]
+  workloadPods?: WorkloadPodInfo[]
 }
 
-export function WorkloadRenderer({ kind, data, onNavigate, scaleBlockedBy }: WorkloadRendererProps) {
+export function WorkloadRenderer({ kind, data, onNavigate, scaleBlockedBy, workloadPods }: WorkloadRendererProps) {
   const navigate = useNavigate()
   const queryClient = useQueryClient()
   const scaleMutation = useScaleWorkload()
@@ -54,13 +55,19 @@ export function WorkloadRenderer({ kind, data, onNavigate, scaleBlockedBy }: Wor
   })
   const hpaQueries = useQueries({
     queries: hpaRefs.map(ref => ({
-      queryKey: ['resource', kindToPlural(ref.kind), ref.namespace, ref.name, ref.group],
+      queryKey: [
+        'resource',
+        kindToPluralWithGroup(ref.kind, ref.group ?? ''),
+        ref.namespace,
+        ref.name,
+        ref.group,
+      ],
       queryFn: () => {
         const ns = ref.namespace || '_'
         const params = new URLSearchParams()
         if (ref.group) params.set('group', ref.group)
         const query = params.toString()
-        return fetchJSON<ResourceWithRelationships<any>>(`/resources/${kindToPlural(ref.kind)}/${ns}/${ref.name}${query ? `?${query}` : ''}`)
+        return fetchJSON<ResourceWithRelationships<any>>(`/resources/${kindToPluralWithGroup(ref.kind, ref.group ?? '')}/${ns}/${ref.name}${query ? `?${query}` : ''}`)
       },
       enabled: Boolean(ref.kind && ref.name),
       staleTime: 10000,
@@ -90,6 +97,7 @@ export function WorkloadRenderer({ kind, data, onNavigate, scaleBlockedBy }: Wor
       policyLoading={policyLoading}
       policyError={policyError as Error | null}
       scaleBlockedBy={scaleBlockedBy}
+      workloadPods={workloadPods}
       scalerDiagnostics={scalerDiagnostics}
       onScale={async (replicas) => {
         await scaleMutation.mutateAsync({

package/src/components/rightsizing/RightsizingScanView.tsx

@@ -33,11 +33,17 @@ import {
   type ResourceSignal,
   type RightsizingActionTone,
 } from './presentation'
+import { useNavCustomization } from '../../context/NavCustomization'
 
 export const RIGHTSIZING_SCAN_DESCRIPTION =
   'Find CPU and memory requests to increase, reduce, or review. Radar never changes them.'
 export const RIGHTSIZING_SCAN_METHODOLOGY =
   'Based on 7 days of history: CPU P95 and memory maximum, plus 15% headroom. Memory reductions require verifiable restart history.'
+export const RIGHTSIZING_METRICS_REQUIRED_TITLE = 'Metrics history is required'
+export const RIGHTSIZING_METRICS_REQUIRED_BODY =
+  'Rightsizing needs 7 days of Kubernetes workload history from a PromQL-compatible metrics backend (Prometheus, VictoriaMetrics, Thanos, or Mimir).\nCost Overview remains available without it.'
+export const RIGHTSIZING_EMBEDDED_METRICS_REQUIRED_BODY =
+  `${RIGHTSIZING_METRICS_REQUIRED_BODY}\nConfigure metrics for this cluster in the host application or Radar deployment.`
 
 export type RightsizingScanSurfaceState =
   | 'discovering'
@@ -97,6 +103,7 @@ const ACTION_META: Record<
 
 export function RightsizingScanView({ namespaces }: RightsizingScanViewProps) {
   useAutoPromConnect()
+  const settingsAvailable = !useNavCustomization().embedded
   const navigate = useNavigate()
   const [params, setParams] = useSearchParams()
   const { data: clusterInfo } = useClusterInfo()
@@ -242,16 +249,33 @@ export function RightsizingScanView({ namespaces }: RightsizingScanViewProps) {
           />
         ) : surfaceState === 'prometheus_required' ? (
           <CenteredState
-            title="Prometheus is required"
-            body="Rightsizing uses Prometheus history. Cost Overview can still use OpenCost independently."
+            title={RIGHTSIZING_METRICS_REQUIRED_TITLE}
+            body={settingsAvailable
+              ? RIGHTSIZING_METRICS_REQUIRED_BODY
+              : RIGHTSIZING_EMBEDDED_METRICS_REQUIRED_BODY}
             action={
-              <button
-                type="button"
-                onClick={() => retryPrometheus()}
-                className="btn-brand px-3 py-1.5 text-xs font-medium"
-              >
-                Check again
-              </button>
+              <div className="flex flex-wrap items-center justify-center gap-3">
+                {settingsAvailable && (
+                  <button
+                    type="button"
+                    onClick={() =>
+                      window.dispatchEvent(
+                        new CustomEvent('radar:open-settings', { detail: { section: 'prometheus' } }),
+                      )
+                    }
+                    className="btn-brand px-4 py-2 text-sm font-medium"
+                  >
+                    Configure metrics
+                  </button>
+                )}
+                <button
+                  type="button"
+                  onClick={() => retryPrometheus()}
+                  className="rounded-lg border border-theme-border px-4 py-2 text-sm font-medium text-theme-text-secondary transition-colors hover:bg-theme-hover hover:text-theme-text-primary"
+                >
+                  Check again
+                </button>
+              </div>
             }
           />
         ) : surfaceState === 'first_run' ? (
@@ -860,15 +884,15 @@ function CenteredState({
   action?: React.ReactNode
 }) {
   return (
-    <div className="flex min-h-48 items-center justify-center rounded-xl border border-theme-border bg-theme-surface">
-      <div className="flex max-w-lg flex-col items-center px-6 text-center">
+    <div className="flex min-h-56 items-center justify-center rounded-xl border border-theme-border bg-theme-surface px-6 py-8">
+      <div className="flex w-full max-w-xl flex-col items-center text-center">
         {loading ? (
           <Loader2 className="h-8 w-8 animate-spin text-theme-text-tertiary" />
         ) : (
           <Gauge className="h-8 w-8 text-theme-text-tertiary" />
         )}
         <h2 className="mt-3 text-base font-semibold text-theme-text-primary">{title}</h2>
-        <p className="mt-1 text-sm text-theme-text-secondary">{body}</p>
+        <p className="mt-1 whitespace-pre-line text-sm text-theme-text-secondary">{body}</p>
         {action && <div className="mt-4">{action}</div>}
       </div>
     </div>

package/src/components/rightsizing/copy.test.ts

@@ -1,6 +1,9 @@
 import { describe, expect, it } from 'vitest'
 import {
   getRightsizingScanSurfaceState,
+  RIGHTSIZING_EMBEDDED_METRICS_REQUIRED_BODY,
+  RIGHTSIZING_METRICS_REQUIRED_BODY,
+  RIGHTSIZING_METRICS_REQUIRED_TITLE,
   RIGHTSIZING_SCAN_DESCRIPTION,
   RIGHTSIZING_SCAN_METHODOLOGY,
 } from './RightsizingScanView'
@@ -17,6 +20,22 @@ describe('rightsizing scan copy', () => {
     expect(copy.toLowerCase()).not.toContain('savings')
   })
 
+  it('describes the metrics contract without assuming one provider or cost source', () => {
+    const copy = `${RIGHTSIZING_METRICS_REQUIRED_TITLE} ${RIGHTSIZING_METRICS_REQUIRED_BODY}`
+    expect(copy).toContain('Metrics history')
+    expect(copy).toContain('PromQL-compatible metrics backend')
+    expect(copy).toContain('7 days')
+    expect(copy).toContain('Prometheus, VictoriaMetrics, Thanos, or Mimir')
+    expect(RIGHTSIZING_METRICS_REQUIRED_BODY).toContain('\nCost Overview')
+    expect(copy).not.toContain('OpenCost')
+    expect(copy).not.toContain('Kubecost')
+  })
+
+  it('routes embedded configuration through the host instead of standalone Settings', () => {
+    expect(RIGHTSIZING_EMBEDDED_METRICS_REQUIRED_BODY).toContain('host application')
+    expect(RIGHTSIZING_EMBEDDED_METRICS_REQUIRED_BODY).not.toContain('Settings')
+  })
+
   it('retains a prior snapshot after a failed rerun but treats a first-run failure as fatal', () => {
     expect(
       getRightsizingScanSurfaceState({