@skyhook-io/k8s-ui 1.8.14 → 1.9.0

package/src/components/topology/K8sResourceNode.tsx

@@ -10,13 +10,14 @@ import {
 import { clsx } from 'clsx'
 import type { NodeKind, HealthStatus, PodSummary } from '../../types'
 import { displayKind } from '../../types'
-import { healthToSeverity, SEVERITY_DOT, SEVERITY_TEXT } from '../../utils/badge-colors'
+import { healthToSeverity, SEVERITY_DOT } from '../../utils/badge-colors'
 import { workloadHue } from '../../utils/workload-colors'
 import { ownershipOf } from '../../utils/topology-neighborhood'
 import { midTruncate } from '../../utils/format'
 import { getTopologyIcon } from '../../utils/resource-icons'
 import { Tooltip } from '../ui/Tooltip'
 import { AuditBadgeTooltip, type AuditBadgeMessage } from '../audit/AuditBadgeTooltip'
+import { SEVERITY_TEXT_CLASS } from '../checks/severity'
 import argoCdLogo from '../../assets/gitops/argocd.png'
 import fluxLogo from '../../assets/gitops/flux.svg'
 
@@ -464,12 +465,13 @@ export const K8sResourceNode = memo(function K8sResourceNode({
   // node's data by auditKey). The host only counts "badge-worthy" findings —
   // reference-integrity / lifecycle, "this resource is actually broken" — not the
   // posture/best-practice nags that fire near-universally, so the indicator stays
-  // a signal. Colored by worst severity (danger red, else warning amber).
-  const auditDanger =
+  // a signal. The counters retain the raw transport names, but presentation
+  // follows the canonical Checks severity ladder (High, then Medium).
+  const auditHigh =
     typeof nodeData.auditDanger === "number" ? nodeData.auditDanger : 0;
-  const auditWarning =
+  const auditMedium =
     typeof nodeData.auditWarning === "number" ? nodeData.auditWarning : 0;
-  const auditTotal = auditDanger + auditWarning;
+  const auditTotal = auditHigh + auditMedium;
   const auditMessages = Array.isArray(nodeData.auditMessages)
     ? (nodeData.auditMessages as AuditBadgeMessage[])
     : [];
@@ -652,7 +654,7 @@ export const K8sResourceNode = memo(function K8sResourceNode({
                         clickHint={false}
                       />
                     ) : (
-                      `${auditTotal} audit ${auditTotal === 1 ? "finding" : "findings"}${auditDanger > 0 ? ` · ${auditDanger} danger` : ""}`
+                      `${auditTotal} audit ${auditTotal === 1 ? "finding" : "findings"}${auditHigh > 0 ? ` · ${auditHigh} high` : ""}${auditMedium > 0 ? ` · ${auditMedium} medium` : ""}`
                     )
                   }
                   position="right"
@@ -660,9 +662,9 @@ export const K8sResourceNode = memo(function K8sResourceNode({
                   <TriangleAlert
                     className={clsx(
                       "w-3 h-3 cursor-help",
-                      auditDanger > 0
-                        ? SEVERITY_TEXT.error
-                        : SEVERITY_TEXT.warning,
+                      auditHigh > 0
+                        ? SEVERITY_TEXT_CLASS.high
+                        : SEVERITY_TEXT_CLASS.medium,
                     )}
                   />
                 </Tooltip>

package/src/components/ui/FilterPill.tsx

@@ -22,7 +22,7 @@ import { Tooltip } from './Tooltip'
 // screen readers announce pressed/unpressed correctly. Optional tooltip
 // describes the toggle action ("Click to stop filtering by danger").
 
-export type FilterPillTone = 'neutral' | 'danger' | 'warn' | 'ok' | 'brand'
+export type FilterPillTone = 'neutral' | 'danger' | 'warn' | 'high' | 'medium' | 'ok' | 'brand'
 
 interface Props {
   label: ReactNode
@@ -49,6 +49,8 @@ const TONE_ACTIVE: Record<FilterPillTone, string> = {
   neutral: 'bg-theme-text-primary/10 border-theme-text-primary/25 text-theme-text-primary',
   danger:  'bg-red-500/15 border-red-500/40 text-red-700 dark:text-red-300',
   warn:    'bg-amber-500/15 border-amber-500/40 text-amber-800 dark:text-amber-300',
+  high:    'bg-orange-500/15 border-orange-500/40 text-orange-800 dark:text-orange-300',
+  medium:  'bg-yellow-500/15 border-yellow-500/40 text-yellow-800 dark:text-yellow-300',
   ok:      'bg-emerald-500/15 border-emerald-500/40 text-emerald-700 dark:text-emerald-300',
   brand:   'bg-[var(--color-brand-50)] border-[var(--color-radar-accent)] text-theme-text-primary dark:bg-[var(--color-brand-950)]',
 }

package/src/components/ui/YamlEditor.test.ts

@@ -0,0 +1,148 @@
+import { describe, expect, it } from 'vitest'
+import {
+  isBlockingYamlDiagnostic,
+  parseFallbackYamlDiagnostics,
+  parseYamlDocumentIdentities,
+  shouldAutoTriggerYamlSuggestions,
+} from './YamlEditor'
+
+describe('parseYamlDocumentIdentities', () => {
+  it('preserves ordered identities and document start lines', () => {
+    const documents = parseYamlDocumentIdentities(`apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: api
+---
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+  name: api
+`)
+    expect(documents).toEqual([
+      {
+        index: 0,
+        schemaIndex: 0,
+        apiVersion: 'apps/v1',
+        kind: 'Deployment',
+        startLine: 1,
+      },
+      {
+        index: 1,
+        schemaIndex: 1,
+        apiVersion: 'monitoring.coreos.com/v1',
+        kind: 'ServiceMonitor',
+        startLine: 5,
+      },
+    ])
+  })
+
+  it('keeps incomplete documents addressable without inventing an identity', () => {
+    expect(parseYamlDocumentIdentities('apiVersion: v1\nkind:')).toEqual([
+      { index: 0, schemaIndex: 0, apiVersion: 'v1', kind: '', startLine: 1 },
+    ])
+  })
+
+  it('compacts empty document segments to match preview and apply indices', () => {
+    expect(
+      parseYamlDocumentIdentities(`apiVersion: apps/v1
+kind: Deployment
+---
+
+---
+apiVersion: v1
+kind: ConfigMap
+`),
+    ).toEqual([
+      {
+        index: 0,
+        schemaIndex: 0,
+        apiVersion: 'apps/v1',
+        kind: 'Deployment',
+        startLine: 1,
+      },
+      {
+        index: 1,
+        schemaIndex: 2,
+        apiVersion: 'v1',
+        kind: 'ConfigMap',
+        startLine: 5,
+      },
+    ])
+  })
+})
+
+describe('isBlockingYamlDiagnostic', () => {
+  it('blocks syntax failures when no schema source is present', () => {
+    expect(isBlockingYamlDiagnostic('error')).toBe(true)
+    expect(isBlockingYamlDiagnostic('warning', '0', 'Incorrect type. Expected integer.')).toBe(true)
+  })
+
+  it('keeps cluster schema diagnostics advisory', () => {
+    expect(
+      isBlockingYamlDiagnostic(
+        'warning',
+        '513',
+        'Property contianers is not allowed.',
+        'yaml-schema: Kubernetes cluster schema',
+      ),
+    ).toBe(false)
+  })
+
+  it('keeps deprecations visible but advisory', () => {
+    expect(isBlockingYamlDiagnostic('warning', '2', 'Use spec.newField instead.')).toBe(false)
+    expect(
+      isBlockingYamlDiagnostic(
+        'warning',
+        undefined,
+        '[radar-advisory:deprecated] Use spec.newField instead.',
+      ),
+    ).toBe(false)
+  })
+})
+
+describe('parseFallbackYamlDiagnostics', () => {
+  it('accepts valid multi-document YAML', () => {
+    expect(
+      parseFallbackYamlDiagnostics(`apiVersion: v1
+kind: ConfigMap
+---
+apiVersion: apps/v1
+kind: Deployment
+`),
+    ).toEqual([])
+  })
+
+  it('reports a blocking syntax error against the correct document', () => {
+    const diagnostics = parseFallbackYamlDiagnostics(`apiVersion: v1
+kind: ConfigMap
+---
+apiVersion: v1
+kind: [`)
+
+    expect(diagnostics).toHaveLength(1)
+    expect(diagnostics[0]).toMatchObject({
+      severity: 'error',
+      line: 5,
+      column: 8,
+      documentIndex: 1,
+      blocking: true,
+    })
+  })
+})
+
+describe('shouldAutoTriggerYamlSuggestions', () => {
+  it('triggers after Enter creates an indented blank line', () => {
+    expect(shouldAutoTriggerYamlSuggestions(['\n      '], '      ', 7)).toBe(true)
+    expect(shouldAutoTriggerYamlSuggestions(['\r\n  '], '  ', 3)).toBe(true)
+  })
+
+  it('does not trigger for typing, pasted content, or a non-blank line', () => {
+    expect(shouldAutoTriggerYamlSuggestions([' '], '      ', 7)).toBe(false)
+    expect(shouldAutoTriggerYamlSuggestions(['\n      image:'], '      image:', 13)).toBe(false)
+    expect(shouldAutoTriggerYamlSuggestions(['\n      '], '      ports:', 13)).toBe(false)
+  })
+
+  it('waits until the cursor is at the end of the new indentation', () => {
+    expect(shouldAutoTriggerYamlSuggestions(['\n      '], '      ', 4)).toBe(false)
+  })
+})