@skyhook-io/k8s-ui 1.17.0 → 1.18.0

package/src/utils/url-path.ts

@@ -0,0 +1,21 @@
+export function stripTrailingSlashes(value: string): string {
+  let end = value.length
+  while (end > 0 && value[end - 1] === '/') end--
+  return value.slice(0, end)
+}
+
+export function normalizeURLForComparison(value: string): string | null {
+  if (!value) return ''
+  if (value.includes('\\')) return null
+  try {
+    const url = new URL(value)
+    const authorityStart = value.indexOf('://')
+    if (authorityStart < 0 || !url.hostname || url.username || url.password || value.includes('?') || value.includes('#')) return null
+    const pathStart = value.indexOf('/', authorityStart + 3)
+    const path = pathStart < 0 ? '' : value.slice(pathStart)
+    const port = url.port || (url.protocol === 'https:' ? '443' : url.protocol === 'http:' ? '80' : '')
+    return `${url.protocol}//${url.hostname.toLowerCase()}:${port}${stripTrailingSlashes(path)}`
+  } catch {
+    return null
+  }
+}

package/src/utils/validators.test.ts

@@ -82,25 +82,16 @@ describe('validateRFC1123Subdomain', () => {
     if (!r.valid) expect(r.error).toMatch(/253/)
   })
 
-  it('rejects single labels longer than 63 chars even when total is under 253', () => {
-    // K8s' IsDNS1123Subdomain enforces ≤ 63 chars per dot-
-    // separated label on top of the 253-char total. Without the
-    // per-label check, a single 200-char label slipped through
-    // client-side and was rejected only server-side.
-    const huge = 'a'.repeat(200)
-    const r = validateRFC1123Subdomain(huge)
-    expect(r.valid).toBe(false)
-    if (!r.valid) expect(r.error).toMatch(/63/)
+  it('accepts long undotted names under the Kubernetes total limit', () => {
+    expect(validateRFC1123Subdomain('a'.repeat(200)).valid).toBe(true)
   })
 
   it('accepts a 63-char label at the boundary', () => {
     expect(validateRFC1123Subdomain('a'.repeat(63)).valid).toBe(true)
   })
 
-  it('rejects only the offending label when other labels are fine', () => {
-    const r = validateRFC1123Subdomain(`ok.${'a'.repeat(64)}.also-ok`)
-    expect(r.valid).toBe(false)
-    if (!r.valid) expect(r.error).toMatch(/63/)
+  it('accepts long dot-separated parts under the Kubernetes total limit', () => {
+    expect(validateRFC1123Subdomain(`ok.${'a'.repeat(64)}.also-ok`).valid).toBe(true)
   })
 })
 

package/src/utils/validators.ts

@@ -17,7 +17,7 @@ export type ValidationResult =
   | { valid: false; error: string }
 
 const RFC1123_LABEL_MAX = 63
-// Kubernetes namespace / pod / service names are RFC 1123 labels:
+// Kubernetes namespace names are RFC 1123 labels:
 // lowercase alphanumeric or '-', start and end alphanumeric, ≤63 chars.
 // Source: k8s.io/apimachinery/pkg/util/validation.IsDNS1123Label.
 const RFC1123_LABEL_RE = /^[a-z0-9]([-a-z0-9]*[a-z0-9])?$/
@@ -34,9 +34,7 @@ const HELM_RELEASE_NAME_MAX = 53
 // https://helm.sh/docs/chart_best_practices/conventions/#chart-names
 
 /**
- * Validates a Kubernetes RFC 1123 label. Used for namespace names,
- * pod / service / configmap / secret names — anything Kubernetes
- * accepts as a single-segment identifier.
+ * Matches Kubernetes IsDNS1123Label, including namespace names.
  */
 export function validateRFC1123Label(input: string): ValidationResult {
   if (input.length === 0) {
@@ -64,9 +62,9 @@ export function validateRFC1123Label(input: string): ValidationResult {
 }
 
 /**
- * Validates a Kubernetes RFC 1123 subdomain (labels joined by dots).
- * Used for Helm chart names, image registries — anything that allows
- * dotted segments. NOT for pod/namespace names; use the label form.
+ * Matches Kubernetes IsDNS1123Subdomain: the whole name is capped at 253
+ * characters, without a separate 63-character cap on dot-separated parts.
+ * Namespace names use validateRFC1123Label instead.
  */
 export function validateRFC1123Subdomain(input: string): ValidationResult {
   if (input.length === 0) {
@@ -90,18 +88,6 @@ export function validateRFC1123Subdomain(input: string): ValidationResult {
       error: 'must contain only lowercase letters, numbers, hyphens, and dots, and each segment must start/end with a letter or number',
     }
   }
-  // Per-label cap: K8s' IsDNS1123Subdomain enforces ≤ 63 chars
-  // PER dot-separated label on top of the 253-char total. The
-  // regex above doesn't catch that; without this check a single
-  // 200-char label passes here and only fails server-side.
-  for (const label of input.split('.')) {
-    if (label.length > RFC1123_LABEL_MAX) {
-      return {
-        valid: false,
-        error: `each dot-separated label must be at most ${RFC1123_LABEL_MAX} characters (got ${label.length} for "${label}")`,
-      }
-    }
-  }
   return { valid: true }
 }
 

package/src/utils/view-transition.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi } from 'vitest'
-import { isInvalidStateError, startViewTransitionSafe } from './view-transition'
+import { isInvalidStateError, isWebKitGTK, startViewTransitionSafe } from './view-transition'
 
 // SKY-833 bug 49: rapid tab / route switches surfaced
 // "InvalidStateError: Transition was aborted because of invalid state"
@@ -79,3 +79,37 @@ describe('startViewTransitionSafe', () => {
     expect(isInvalidStateError(new TypeError('y'))).toBe(false)
   })
 })
+
+const WEBKITGTK_UA =
+  'Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0 Safari/605.1.15'
+
+describe('isWebKitGTK', () => {
+  it('matches WebKitGTK user agents', () => {
+    expect(isWebKitGTK(WEBKITGTK_UA)).toBe(true)
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko)')).toBe(true)
+  })
+
+  it('does not match other engines on Linux, or Safari', () => {
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64; rv:140.0) Gecko/20100101 Firefox/140.0')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (Linux; Android 15) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Mobile Safari/537.36')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0 Safari/605.1.15')).toBe(false)
+  })
+})
+
+describe('startViewTransitionSafe under WebKitGTK', () => {
+  it('applies the update directly instead of starting a transition', () => {
+    const originalDoc = (globalThis as { document?: unknown }).document
+    const startSpy = vi.fn()
+    ;(globalThis as { document: object }).document = { startViewTransition: startSpy }
+    const uaSpy = vi.spyOn(navigator, 'userAgent', 'get').mockReturnValue(WEBKITGTK_UA)
+
+    const update = vi.fn()
+    startViewTransitionSafe(update)
+    expect(update).toHaveBeenCalledTimes(1)
+    expect(startSpy).not.toHaveBeenCalled()
+
+    uaSpy.mockRestore()
+    ;(globalThis as { document?: unknown }).document = originalDoc
+  })
+})

package/src/utils/view-transition.ts

@@ -14,6 +14,13 @@
  *
  * Other rejection types (programming errors, unsupported configs)
  * are re-thrown so we don't accidentally hide real bugs.
+ *
+ * Under WebKitGTK (the Linux desktop app's webview) the update is applied
+ * without a transition: when WebKitGTK has no renderer buffer transport —
+ * WEBKIT_DISABLE_DMABUF_RENDERER or WEBKIT_DISABLE_COMPOSITING_MODE set, a
+ * distro patch, or an EGL stack without GBM/surfaceless platforms — starting
+ * a view transition segfaults the UI process. The page cannot tell which
+ * case it is in, so it skips the cross-fade on every WebKitGTK host.
  */
 export function startViewTransitionSafe(update: () => void): void {
   // Some lib.dom.d.ts versions don't yet expose `startViewTransition`
@@ -27,7 +34,7 @@ export function startViewTransitionSafe(update: () => void): void {
     }
   }
 
-  if (typeof doc.startViewTransition !== 'function') {
+  if (typeof doc.startViewTransition !== 'function' || isWebKitGTK(navigator.userAgent)) {
     update()
     return
   }
@@ -60,3 +67,11 @@ export function isInvalidStateError(err: unknown): boolean {
     (err as { name: unknown }).name === 'InvalidStateError'
   )
 }
+
+/**
+ * WebKitGTK identifies as AppleWebKit on Linux. Chromium-based browsers on
+ * Linux and Android carry AppleWebKit too, so they are excluded by name.
+ */
+export function isWebKitGTK(userAgent: string): boolean {
+  return /\bLinux\b/.test(userAgent) && /AppleWebKit/.test(userAgent) && !/Chrome|Chromium|Android/.test(userAgent)
+}