@skyhook-io/k8s-ui 1.17.0 → 1.17.1

package/src/utils/navigation.test.ts

@@ -193,6 +193,63 @@ describe('pluralToKind', () => {
 })
 
 describe('initNavigationMap', () => {
+  const coreNode = { group: '', version: 'v1', kind: 'Node', name: 'nodes', namespaced: false, isCrd: false, verbs: ['get'] }
+  const customNode = { group: 'collision.example.io', version: 'v1', kind: 'Node', name: 'workerhosts', namespaced: false, isCrd: true, verbs: ['get'] }
+
+  test.each([
+    ['core listed first', [coreNode, customNode]],
+    ['custom listed first', [customNode, coreNode]],
+  ])('keeps the core plural for a Kind a CRD reuses under another plural (%s)', (_, resources) => {
+    initNavigationMap(resources)
+    expect(kindToPlural('Node')).toBe('nodes')
+    expect(kindToPluralWithGroup('Node', '')).toBe('nodes')
+    expect(refToSelectedResource({ kind: 'Node', group: '', name: 'worker' }).kind).toBe('nodes')
+    expect(kindToPluralWithGroup('Node', 'collision.example.io')).toBe('workerhosts')
+  })
+
+  test('keeps the core plural when partial discovery omits the core group', () => {
+    initNavigationMap([customNode])
+    expect(refToSelectedResource({ kind: 'Node', group: '', name: 'worker' }).kind).toBe('nodes')
+    expect(kindToPluralWithGroup('Node', 'collision.example.io')).toBe('workerhosts')
+  })
+
+  test.each([
+    ['partial discovery', [{ ...customNode, name: 'node' }]],
+    ['full discovery', [coreNode, { ...customNode, name: 'node' }]],
+  ])('keeps the core plural when a CRD registers the core Kind word as its plural (%s)', (_, resources) => {
+    initNavigationMap(resources)
+    expect(refToSelectedResource({ kind: 'Node', group: '', name: 'worker' }).kind).toBe('nodes')
+    expect(kindToPlural('node')).toBe('node')
+    expect(kindToPluralWithGroup('Node', 'collision.example.io')).toBe('node')
+  })
+
+  test('resolves a group-qualified Kind spelled like a core plural to its own resource', () => {
+    initNavigationMap([
+      { group: '', version: 'v1', kind: 'Endpoints', name: 'endpoints', namespaced: true, isCrd: false, verbs: ['get'] },
+      { group: 'custom.example.io', version: 'v1', kind: 'Endpoints', name: 'virtualendpoints', namespaced: true, isCrd: true, verbs: ['get'] },
+    ])
+    expect(kindToPluralWithGroup('Endpoints', 'custom.example.io')).toBe('virtualendpoints')
+    expect(kindToPluralWithGroup('Endpoints', '')).toBe('endpoints')
+  })
+
+  test('keeps a lowercase group plural rather than reading it as another Kind', () => {
+    initNavigationMap([
+      { group: 'shapes.example.io', version: 'v1', kind: 'Widget', name: 'widgets', namespaced: true, isCrd: true, verbs: ['get'] },
+      { group: 'shapes.example.io', version: 'v1', kind: 'Widgets', name: 'widgetsets', namespaced: true, isCrd: true, verbs: ['get'] },
+    ])
+    expect(kindToPluralWithGroup('widgets', 'shapes.example.io')).toBe('widgets')
+    expect(kindToPluralWithGroup('Widgets', 'shapes.example.io')).toBe('widgetsets')
+    expect(kindToPluralWithGroup('Widget', 'shapes.example.io')).toBe('widgets')
+  })
+
+  test('keeps last-wins for Kinds that only CRDs declare', () => {
+    initNavigationMap([
+      { group: 'a.example.io', version: 'v1', kind: 'Widget', name: 'widgets', namespaced: true, isCrd: true, verbs: [] },
+      { group: 'b.example.io', version: 'v1', kind: 'Widget', name: 'gadgets', namespaced: true, isCrd: true, verbs: [] },
+    ])
+    expect(kindToPlural('Widget')).toBe('gadgets')
+  })
+
   test('discovered API resources override heuristic pluralization', () => {
     // Before init, an unknown CRD would hit the heuristic fallback
     // After init, it uses the discovered plural name

package/src/utils/navigation.ts

@@ -1,6 +1,6 @@
 import type { SelectedResource, ResourceRef, APIResource } from '../types/core'
 import { englishPlural, englishSingular, isEnglishPlural } from './pluralize'
-import { CORE_RESOURCES } from './api-resources'
+import { CORE_RESOURCES, isBuiltinCoreKind } from './api-resources'
 
 /**
  * Canonical callback type for navigating to a resource.
@@ -67,6 +67,18 @@ let discoveredPluralToKind: Record<string, string> | null = null
 let discoveredKindToPlural: Record<string, string> | null = null
 let discoveredGroupKindToPlural: Record<string, string> | null = null
 let discoveredGroupPluralToKind: Record<string, string> | null = null
+let discoveredGroupKindNamespaced: Record<string, boolean> | null = null
+let discoveredCRDNames: Record<string, string> | null = null
+const crdDefinitionListeners = new Set<() => void>()
+
+export function subscribeCRDDefinitions(listener: () => void): () => void {
+  crdDefinitionListeners.add(listener)
+  return () => { crdDefinitionListeners.delete(listener) }
+}
+
+export function getCRDDefinitionsSnapshot(): Readonly<Record<string, string>> | null {
+  return discoveredCRDNames
+}
 
 /**
  * Initialize navigation maps from discovered API resources.
@@ -75,17 +87,35 @@ let discoveredGroupPluralToKind: Record<string, string> | null = null
  */
 export function initNavigationMap(resources: APIResource[]) {
   const p2k: Record<string, string> = { ...BUILTIN_PLURAL_TO_KIND }
-  const k2p: Record<string, string> = {}
+  // Seeded from the built-in table so core protection survives partial
+  // discovery (the server forwards whatever groups it could list).
+  const k2p: Record<string, string> = Object.fromEntries(
+    CORE_RESOURCES.filter(r => r.group === '').map(r => [r.kind.toLowerCase(), r.name]),
+  )
   const gk2p: Record<string, string> = {}
   const gp2k: Record<string, string> = { ...BUILTIN_GROUP_PLURAL_TO_KIND }
+  const scopes: Record<string, boolean> = {}
+  const crdNames: Record<string, string> = {}
+  const coreKinds = new Set(Object.keys(k2p))
   for (const r of resources) {
     const plural = r.name.toLowerCase()
+    const kindLower = r.kind.toLowerCase()
+    if (r.definitionName) crdNames[`${r.group}/${r.kind}`] = r.definitionName
     // First-wins on plurals: BUILTIN_PLURAL_TO_KIND seeds canonical core mappings
     // (e.g. "pods" → "Pod") so a colliding API resource (metrics.k8s.io exposes
     // "pods" with kind "PodMetrics") cannot hijack the core mapping.
     if (!(plural in p2k)) p2k[plural] = r.kind
-    k2p[r.kind.toLowerCase()] = plural
-    gk2p[`${r.group}/${r.kind.toLowerCase()}`] = plural
+    // Kind-only lookups (core links carry an empty group) likewise keep the core
+    // plural: a CRD that reuses a core Kind under another plural must not win
+    // just because discovery happened to list it later.
+    if (r.group === '') {
+      k2p[kindLower] = plural
+      coreKinds.add(kindLower)
+    } else if (!coreKinds.has(kindLower)) {
+      k2p[kindLower] = plural
+    }
+    gk2p[`${r.group}/${kindLower}`] = plural
+    scopes[`${r.group}/${kindLower}`] = r.namespaced
     const groupPlural = `${r.group}/${plural}`
     if (!(groupPlural in gp2k)) gp2k[groupPlural] = r.kind
   }
@@ -93,14 +123,20 @@ export function initNavigationMap(resources: APIResource[]) {
   discoveredKindToPlural = k2p
   discoveredGroupKindToPlural = gk2p
   discoveredGroupPluralToKind = gp2k
+  discoveredGroupKindNamespaced = scopes
+  discoveredCRDNames = crdNames
+  crdDefinitionListeners.forEach(listener => listener())
 }
 
-/** Reset navigation maps to builtin-only state. For testing. */
+/** Reset navigation maps to builtin-only state on cluster changes. */
 export function resetNavigationMap() {
   discoveredPluralToKind = null
   discoveredKindToPlural = null
   discoveredGroupKindToPlural = null
   discoveredGroupPluralToKind = null
+  discoveredGroupKindNamespaced = null
+  discoveredCRDNames = null
+  crdDefinitionListeners.forEach(listener => listener())
 }
 
 function getPluralToKind(): Record<string, string> {
@@ -117,6 +153,11 @@ export function kindToPlural(kind: string): string {
   const kindLower = kind.toLowerCase()
   const pluralToKindMap = getPluralToKind()
 
+  // An exact core Kind (PascalCase, unlike plural slugs) keeps its core plural
+  // even when a CRD registered that word as its own plural.
+  const core = kind !== kindLower ? CORE_RESOURCES.find(r => r.group === '' && r.kind === kind) : undefined
+  if (core) return core.name
+
   // Already a known plural — return as-is to prevent double-pluralization
   if (kindLower in pluralToKindMap) return kindLower
 
@@ -156,10 +197,15 @@ export function kindToPlural(kind: string): string {
 export function kindToPluralWithGroup(kind: string, group: string): string {
   if (!group) return kindToPlural(kind)
   const kindLower = kind.toLowerCase()
-  const pluralToKindMap = getPluralToKind()
-  if (kindLower in pluralToKindMap) return kindLower
+  // The group's own plural, then its exact Kind, before the group-blind plural
+  // shortcut: a custom Kind spelled like a core plural (Endpoints) has its own
+  // resource, while a lowercase plural must not be read as another Kind.
+  if (kind === kindLower && discoveredGroupPluralToKind?.[`${group}/${kindLower}`]) return kindLower
   const groupKind = `${group}/${kindLower}`
-  return discoveredGroupKindToPlural?.[groupKind] ?? BUILTIN_GROUP_KIND_TO_PLURAL[groupKind] ?? kindToPlural(kind)
+  const exact = discoveredGroupKindToPlural?.[groupKind] ?? BUILTIN_GROUP_KIND_TO_PLURAL[groupKind]
+  if (exact) return exact
+  if (kindLower in getPluralToKind()) return kindLower
+  return kindToPlural(kind)
 }
 
 /**
@@ -196,6 +242,13 @@ export function knownKindForPluralWithGroup(plural: string, group: string): stri
     ?? BUILTIN_GROUP_PLURAL_TO_KIND[groupPlural]
 }
 
+/** Return a CRD definition only when exact group/kind discovery identifies a CRD. */
+export function customResourceDefinitionRef(apiVersion: string | undefined, kind: string | undefined): ResourceRef | null {
+  if (!apiVersion || !kind) return null
+  const name = discoveredCRDNames?.[`${apiVersionToGroup(apiVersion)}/${kind}`]
+  return name ? { kind: 'CustomResourceDefinition', group: 'apiextensions.k8s.io', namespace: '', name } : null
+}
+
 /**
  * Convert a ResourceRef (from backend relationships) to a SelectedResource (for navigation).
  * Handles kind singular→plural conversion.
@@ -225,6 +278,31 @@ export function apiVersionToGroup(apiVersion?: string | null): string {
   return i === -1 ? '' : apiVersion.slice(0, i)
 }
 
+/** A Kubernetes ObjectReference retains its own API identity and namespace.
+ * Cluster scope comes from exact group/kind discovery (or known built-ins).
+ * Core controllers omit apiVersion for core objects (the EndpointSlice
+ * controller writes Pod targets as kind/namespace/name/uid), so an omitted
+ * apiVersion means the core group only for a built-in core Kind. Any other
+ * missing identity or scope stays non-navigable rather than guessing an API
+ * or borrowing the referring object's namespace. UID is not a drawer locator.
+ */
+export function objectReferenceToResourceRef(ref: {
+  apiVersion?: string
+  kind?: string
+  namespace?: string
+  name?: string
+} | null | undefined): ResourceRef | null {
+  if (!ref?.kind || !ref.name) return null
+  const kindLower = ref.kind.toLowerCase()
+  if (!ref.apiVersion && !isBuiltinCoreKind(ref.kind)) return null
+  const group = apiVersionToGroup(ref.apiVersion)
+  const key = `${group}/${kindLower}`
+  const namespaced = discoveredGroupKindNamespaced?.[key]
+    ?? CORE_RESOURCES.find(r => r.group === group && r.kind.toLowerCase() === kindLower)?.namespaced
+  if (namespaced !== false && !ref.namespace) return null
+  return { kind: ref.kind, group, namespace: namespaced === false ? '' : ref.namespace!, name: ref.name }
+}
+
 // -----------------------------------------------------------------------------
 // Timeline lane identity. A lane's id includes the API group so two CRDs that
 // share a kind name across vendors (CAPI `Cluster` in cluster.x-k8s.io vs CNPG

package/src/utils/object-reference-navigation.test.ts

@@ -0,0 +1,43 @@
+import { afterEach, describe, expect, it } from 'vitest'
+import { initNavigationMap, objectReferenceToResourceRef, resetNavigationMap } from './navigation'
+
+afterEach(resetNavigationMap)
+
+describe('objectReferenceToResourceRef', () => {
+  it('keeps the reference namespace and drops it for cluster-scoped core kinds', () => {
+    expect(objectReferenceToResourceRef({ apiVersion: 'v1', kind: 'Pod', namespace: 'other', name: 'backend' }))
+      .toEqual({ kind: 'Pod', group: '', namespace: 'other', name: 'backend' })
+    expect(objectReferenceToResourceRef({ apiVersion: 'v1', kind: 'Node', namespace: 'irrelevant', name: 'worker' }))
+      .toEqual({ kind: 'Node', group: '', namespace: '', name: 'worker' })
+  })
+
+  it('resolves a core Kind without apiVersion, the shape the EndpointSlice controller writes', () => {
+    expect(objectReferenceToResourceRef({ kind: 'Pod', namespace: 'team', name: 'backend' }))
+      .toEqual({ kind: 'Pod', group: '', namespace: 'team', name: 'backend' })
+    expect(objectReferenceToResourceRef({ kind: 'Endpoints', namespace: 'team', name: 'backend' }))
+      .toEqual({ kind: 'Endpoints', group: '', namespace: 'team', name: 'backend' })
+    expect(objectReferenceToResourceRef({ kind: 'Deployment', namespace: 'team', name: 'backend' })).toBeNull()
+    expect(objectReferenceToResourceRef({ kind: 'Services', namespace: 'team', name: 'backend' })).toBeNull()
+    expect(objectReferenceToResourceRef({ kind: 'Nodes', namespace: 'team', name: 'worker' })).toBeNull()
+  })
+
+  it('uses exact discovered scope for colliding API kinds', () => {
+    initNavigationMap([
+      { group: 'cluster.example.io', version: 'v1', kind: 'Node', name: 'nodes', namespaced: false, isCrd: true, verbs: ['get'] },
+      { group: 'team.example.io', version: 'v1', kind: 'Node', name: 'nodes', namespaced: true, isCrd: true, verbs: ['get'] },
+    ])
+    expect(objectReferenceToResourceRef({ apiVersion: 'cluster.example.io/v1', kind: 'Node', name: 'worker' }))
+      .toEqual({ kind: 'Node', group: 'cluster.example.io', namespace: '', name: 'worker' })
+    expect(objectReferenceToResourceRef({ apiVersion: 'team.example.io/v1', kind: 'Node', namespace: 'team', name: 'worker' }))
+      .toEqual({ kind: 'Node', group: 'team.example.io', namespace: 'team', name: 'worker' })
+    expect(objectReferenceToResourceRef({ apiVersion: 'team.example.io/v1', kind: 'Node', name: 'worker' })).toBeNull()
+  })
+
+  it('does not invent a custom API group, a namespace, or an unknown cluster scope', () => {
+    expect(objectReferenceToResourceRef({ kind: 'Widget', namespace: 'team', name: 'backend' })).toBeNull()
+    expect(objectReferenceToResourceRef({ apiVersion: 'v1', kind: 'Pod', name: 'backend' })).toBeNull()
+    expect(objectReferenceToResourceRef({ apiVersion: 'unknown.example.io/v1', kind: 'Node', name: 'worker' })).toBeNull()
+    expect(objectReferenceToResourceRef({ apiVersion: 'unknown.example.io/v1', kind: 'Widget', namespace: 'team', name: 'backend' }))
+      .toEqual({ kind: 'Widget', group: 'unknown.example.io', namespace: 'team', name: 'backend' })
+  })
+})

package/src/utils/resource-hierarchy.test.ts

@@ -1560,3 +1560,40 @@ describe('uses edges in the timeline hierarchy', () => {
     expect(deployment.children?.map(child => child.kind)).toEqual(['HorizontalPodAutoscaler'])
   })
 })
+
+describe('buildResourceHierarchy Flux sources', () => {
+  it('keeps a shared Flux source as its own lane instead of nesting it under one consumer', () => {
+    const event = (kind: string, name: string, apiVersion: string): TimelineEvent => ({
+      id: `${kind}/flux-system/${name}`,
+      timestamp: '2024-01-01T00:00:00.000Z',
+      source: 'informer',
+      kind,
+      apiVersion,
+      namespace: 'flux-system',
+      name,
+      eventType: 'update',
+    } as TimelineEvent)
+    const events = [
+      event('GitRepository', 'podinfo', 'source.toolkit.fluxcd.io/v1'),
+      event('Kustomization', 'base', 'kustomize.toolkit.fluxcd.io/v1'),
+      event('Kustomization', 'overlay', 'kustomize.toolkit.fluxcd.io/v1'),
+    ]
+    const topology = {
+      nodes: [
+        { id: 'gitrepository/flux-system/podinfo', kind: 'GitRepository', name: 'podinfo', status: 'healthy', data: { namespace: 'flux-system', apiVersion: 'source.toolkit.fluxcd.io/v1' } },
+        { id: 'kustomization/flux-system/base', kind: 'Kustomization', name: 'base', status: 'healthy', data: { namespace: 'flux-system', apiVersion: 'kustomize.toolkit.fluxcd.io/v1' } },
+        { id: 'kustomization/flux-system/overlay', kind: 'Kustomization', name: 'overlay', status: 'healthy', data: { namespace: 'flux-system', apiVersion: 'kustomize.toolkit.fluxcd.io/v1' } },
+      ],
+      edges: [
+        { id: 'e1', source: 'gitrepository/flux-system/podinfo', target: 'kustomization/flux-system/base', type: 'configures' },
+        { id: 'e2', source: 'gitrepository/flux-system/podinfo', target: 'kustomization/flux-system/overlay', type: 'configures' },
+      ],
+    } as unknown as Topology
+    const lanes = buildResourceHierarchy({ events, topology, grouping: 'owner' })
+    expect(lanes.map((lane) => `${lane.kind}/${lane.name}`).sort()).toEqual([
+      'GitRepository/podinfo',
+      'Kustomization/base',
+      'Kustomization/overlay',
+    ])
+  })
+})

package/src/utils/resource-hierarchy.ts

@@ -466,7 +466,7 @@ function sortEventsForRendering(events: TimelineEvent[]): TimelineEvent[] {
 // then workloads, then their generated children (ReplicaSet/Pod), config last.
 // Applied at EVERY depth so a Job's Pods sort the same way a root's children do.
 const CHILD_SORT_KIND_PRIORITY: Record<string, number> = {
-  Service: 1, Gateway: 1, HTTPRoute: 2, GRPCRoute: 2, TCPRoute: 2, TLSRoute: 2,
+  Service: 1, Gateway: 1, HTTPRoute: 2, GRPCRoute: 2, TCPRoute: 2, TLSRoute: 2, UDPRoute: 2,
   Deployment: 2, Rollout: 2, StatefulSet: 2, DaemonSet: 2,
   Job: 3, CronJob: 3,
   ReplicaSet: 3, Pod: 4, ConfigMap: 5, Secret: 5,
@@ -761,11 +761,11 @@ export function buildResourceHierarchy(options: HierarchyOptions): ResourceLane[
         const targetKind = parseLaneId(targetId)!.kind
 
         // Gateway→Route: Gateway is parent of Route
-        if (sourceKind === 'Gateway' && (targetKind === 'HTTPRoute' || targetKind === 'GRPCRoute' || targetKind === 'TCPRoute' || targetKind === 'TLSRoute')) {
+        if (sourceKind === 'Gateway' && (targetKind === 'HTTPRoute' || targetKind === 'GRPCRoute' || targetKind === 'TCPRoute' || targetKind === 'TLSRoute' || targetKind === 'UDPRoute')) {
           link(targetId, sourceId, targetExists)
         }
         // Route→Service: reverse (Service is representative, like Ingress)
-        else if ((sourceKind === 'HTTPRoute' || sourceKind === 'GRPCRoute' || sourceKind === 'TCPRoute' || sourceKind === 'TLSRoute') && targetKind === 'Service') {
+        else if ((sourceKind === 'HTTPRoute' || sourceKind === 'GRPCRoute' || sourceKind === 'TCPRoute' || sourceKind === 'TLSRoute' || sourceKind === 'UDPRoute') && targetKind === 'Service') {
           link(sourceId, targetId, sourceExists)
         }
         // Ingress→Service: reverse relationship (Service is representative)
@@ -778,8 +778,10 @@ export function buildResourceHierarchy(options: HierarchyOptions): ResourceLane[
         }
       }
 
-      // configures/protects: ConfigMap→Deployment, PDB→Deployment (target is parent)
-      if (edge.type === 'configures' || edge.type === 'protects') {
+      // configures/protects: ConfigMap→Deployment, PDB→Deployment (target is parent).
+      // A Flux source feeds many reconcilers and its timeline is its own, so it
+      // never nests under one of them.
+      if ((edge.type === 'configures' && !isFluxSource(topologyNodeById.get(edge.source))) || edge.type === 'protects') {
         link(sourceId, targetId, sourceExists)
       }
       // uses: only an autoscaler or a mounted claim belongs under the workload it
@@ -813,7 +815,7 @@ export function buildResourceHierarchy(options: HierarchyOptions): ResourceLane[
     const appLabelEligibleKinds = new Set([
       'Service', 'Deployment', 'Rollout', 'StatefulSet', 'DaemonSet',
       'Job', 'CronJob', 'Ingress', 'Gateway', 'HTTPRoute', 'GRPCRoute',
-      'TCPRoute', 'TLSRoute', 'ConfigMap', 'Secret',
+      'TCPRoute', 'TLSRoute', 'UDPRoute', 'ConfigMap', 'Secret',
       'Application', 'Kustomization', 'HelmRelease', 'GitRepository',
       'Workflow', 'CronWorkflow',
       'KnativeService', 'KnativeConfiguration', 'KnativeRevision', 'KnativeRoute',
@@ -844,7 +846,7 @@ export function buildResourceHierarchy(options: HierarchyOptions): ResourceLane[
 
       const kindPriority: Record<string, number> = {
         Service: 1, Ingress: 2, Gateway: 2,
-        HTTPRoute: 2, GRPCRoute: 2, TCPRoute: 2, TLSRoute: 2,
+        HTTPRoute: 2, GRPCRoute: 2, TCPRoute: 2, TLSRoute: 2, UDPRoute: 2,
         Deployment: 3, Rollout: 3, StatefulSet: 3, DaemonSet: 3,
         Job: 4, CronJob: 4, Workflow: 4, CronWorkflow: 4,
         ConfigMap: 5, Secret: 5,
@@ -1487,6 +1489,12 @@ const ATTACHED_USES_SOURCES = new Set([
   '/PersistentVolumeClaim',
 ])
 
+function isFluxSource(node: Topology['nodes'][number] | undefined): boolean {
+  if (!node) return false
+  const apiVersion = typeof node.data?.apiVersion === 'string' ? node.data.apiVersion : ''
+  return apiVersionToGroup(apiVersion) === 'source.toolkit.fluxcd.io'
+}
+
 function attachesToTarget(node: Topology['nodes'][number] | undefined): boolean {
   if (!node) return false
   const kind = topologyNodeResourceKind(node)

package/src/utils/resource-icons.ts

@@ -111,6 +111,7 @@ const KIND_ICON_MAP: Record<string, LucideIcon> = {
   httproute: Globe,
   grpcroute: Globe,
   tcproute: Globe,
+  udproute: Globe,
   tlsroute: Globe,
 
   // Config
@@ -219,6 +220,7 @@ const KIND_ICON_MAP: Record<string, LucideIcon> = {
   // pseudo-kinds (cnpgcluster/…) belong here only once pkg/topology's
   // KindForGVK emits them — it has no CNPG case today.
   pooler: Waypoints,
+  databaserole: UserCog,
 
   // Cluster API
   capicluster: Server,

package/src/utils/skeleton-yaml.test.ts

@@ -0,0 +1,21 @@
+import { describe, expect, it } from 'vitest'
+import { getSkeletonYaml } from './skeleton-yaml'
+
+describe('getSkeletonYaml', () => {
+  it('starts a CloudNativePG Cluster from a spec the operator accepts', () => {
+    const yaml = getSkeletonYaml('Cluster', 'postgresql.cnpg.io')
+    expect(yaml).toContain('apiVersion: postgresql.cnpg.io/v1')
+    expect(yaml).toContain('instances: 3')
+    expect(yaml).toContain('size: 1Gi')
+  })
+
+  it('leaves a Cluster API Cluster on the generic template', () => {
+    const yaml = getSkeletonYaml('Cluster', 'cluster.x-k8s.io')
+    expect(yaml).toContain('apiVersion: cluster.x-k8s.io/v1')
+    expect(yaml).not.toContain('instances')
+  })
+
+  it('keeps core kinds on their own skeleton', () => {
+    expect(getSkeletonYaml('Pod')).toContain('containers:')
+  })
+})

package/src/utils/skeleton-yaml.ts

@@ -198,8 +198,24 @@ spec:
           image: nginx:latest`,
 }
 
+// Keyed by group as well as kind: CloudNativePG and Cluster API both name a
+// kind Cluster.
+const groupSkeletons: Record<string, string> = {
+  'postgresql.cnpg.io/Cluster': `apiVersion: postgresql.cnpg.io/v1
+kind: Cluster
+metadata:
+  name: my-cluster
+  namespace: default
+spec:
+  instances: 3
+  storage:
+    size: 1Gi`,
+}
+
 // Returns skeleton YAML for a known kind, or a generic template for unknown kinds.
 export function getSkeletonYaml(kind: string, group?: string): string {
+  const grouped = group ? groupSkeletons[`${group}/${kind}`] : undefined
+  if (grouped) return grouped
   const skeleton = skeletons[kind]
   if (skeleton) return skeleton
 

package/src/utils/url-path.test.ts

@@ -0,0 +1,35 @@
+import { describe, expect, it } from 'vitest'
+import { normalizeURLForComparison, stripTrailingSlashes } from './url-path'
+
+describe('stripTrailingSlashes', () => {
+  it.each([
+    ['', ''],
+    ['/', ''],
+    ['////', ''],
+    ['/api///', '/api'],
+    ['https://store.example//bucket///', 'https://store.example//bucket'],
+    ['https://store.example//bucket?prefix=/', 'https://store.example//bucket?prefix='],
+    ['/api//nested', '/api//nested'],
+  ])('preserves the existing path normalization for %s', (value, expected) => {
+    expect(stripTrailingSlashes(value)).toBe(expected)
+  })
+
+  it('handles long slash runs without scanning each possible start', () => {
+    const slashes = '/'.repeat(100_000)
+    expect(stripTrailingSlashes(`prefix${slashes}`)).toBe('prefix')
+    expect(stripTrailingSlashes(`prefix${slashes}suffix`)).toBe(`prefix${slashes}suffix`)
+  })
+})
+
+it('compares equivalent origins while retaining declared path semantics', () => {
+  expect(normalizeURLForComparison('https://STORE.example:443/prefix/')).toBe(normalizeURLForComparison('https://store.example/prefix'))
+  expect(normalizeURLForComparison('http://STORE.example:080/')).toBe(normalizeURLForComparison('http://store.example'))
+  expect(normalizeURLForComparison('s3://BUCKET/path/')).toBe(normalizeURLForComparison('s3://bucket/path'))
+  expect(normalizeURLForComparison('https://store.example/Prefix')).not.toBe(normalizeURLForComparison('https://store.example/prefix'))
+  expect(normalizeURLForComparison('https://store.example/a/../b')).not.toBe(normalizeURLForComparison('https://store.example/b'))
+  expect(normalizeURLForComparison('https://store.example:8443/path')).not.toBe(normalizeURLForComparison('https://store.example/path'))
+  expect(normalizeURLForComparison('')).toBe('')
+  expect(normalizeURLForComparison('invalid')).toBeNull()
+  expect(normalizeURLForComparison('https://host\\prefix')).toBeNull()
+  expect(normalizeURLForComparison('https://user:password@store.example')).toBeNull()
+})

package/src/utils/url-path.ts

@@ -0,0 +1,21 @@
+export function stripTrailingSlashes(value: string): string {
+  let end = value.length
+  while (end > 0 && value[end - 1] === '/') end--
+  return value.slice(0, end)
+}
+
+export function normalizeURLForComparison(value: string): string | null {
+  if (!value) return ''
+  if (value.includes('\\')) return null
+  try {
+    const url = new URL(value)
+    const authorityStart = value.indexOf('://')
+    if (authorityStart < 0 || !url.hostname || url.username || url.password || value.includes('?') || value.includes('#')) return null
+    const pathStart = value.indexOf('/', authorityStart + 3)
+    const path = pathStart < 0 ? '' : value.slice(pathStart)
+    const port = url.port || (url.protocol === 'https:' ? '443' : url.protocol === 'http:' ? '80' : '')
+    return `${url.protocol}//${url.hostname.toLowerCase()}:${port}${stripTrailingSlashes(path)}`
+  } catch {
+    return null
+  }
+}

package/src/utils/validators.test.ts

@@ -82,25 +82,16 @@ describe('validateRFC1123Subdomain', () => {
     if (!r.valid) expect(r.error).toMatch(/253/)
   })
 
-  it('rejects single labels longer than 63 chars even when total is under 253', () => {
-    // K8s' IsDNS1123Subdomain enforces ≤ 63 chars per dot-
-    // separated label on top of the 253-char total. Without the
-    // per-label check, a single 200-char label slipped through
-    // client-side and was rejected only server-side.
-    const huge = 'a'.repeat(200)
-    const r = validateRFC1123Subdomain(huge)
-    expect(r.valid).toBe(false)
-    if (!r.valid) expect(r.error).toMatch(/63/)
+  it('accepts long undotted names under the Kubernetes total limit', () => {
+    expect(validateRFC1123Subdomain('a'.repeat(200)).valid).toBe(true)
   })
 
   it('accepts a 63-char label at the boundary', () => {
     expect(validateRFC1123Subdomain('a'.repeat(63)).valid).toBe(true)
   })
 
-  it('rejects only the offending label when other labels are fine', () => {
-    const r = validateRFC1123Subdomain(`ok.${'a'.repeat(64)}.also-ok`)
-    expect(r.valid).toBe(false)
-    if (!r.valid) expect(r.error).toMatch(/63/)
+  it('accepts long dot-separated parts under the Kubernetes total limit', () => {
+    expect(validateRFC1123Subdomain(`ok.${'a'.repeat(64)}.also-ok`).valid).toBe(true)
   })
 })
 

package/src/utils/validators.ts

@@ -17,7 +17,7 @@ export type ValidationResult =
   | { valid: false; error: string }
 
 const RFC1123_LABEL_MAX = 63
-// Kubernetes namespace / pod / service names are RFC 1123 labels:
+// Kubernetes namespace names are RFC 1123 labels:
 // lowercase alphanumeric or '-', start and end alphanumeric, ≤63 chars.
 // Source: k8s.io/apimachinery/pkg/util/validation.IsDNS1123Label.
 const RFC1123_LABEL_RE = /^[a-z0-9]([-a-z0-9]*[a-z0-9])?$/
@@ -34,9 +34,7 @@ const HELM_RELEASE_NAME_MAX = 53
 // https://helm.sh/docs/chart_best_practices/conventions/#chart-names
 
 /**
- * Validates a Kubernetes RFC 1123 label. Used for namespace names,
- * pod / service / configmap / secret names — anything Kubernetes
- * accepts as a single-segment identifier.
+ * Matches Kubernetes IsDNS1123Label, including namespace names.
  */
 export function validateRFC1123Label(input: string): ValidationResult {
   if (input.length === 0) {
@@ -64,9 +62,9 @@ export function validateRFC1123Label(input: string): ValidationResult {
 }
 
 /**
- * Validates a Kubernetes RFC 1123 subdomain (labels joined by dots).
- * Used for Helm chart names, image registries — anything that allows
- * dotted segments. NOT for pod/namespace names; use the label form.
+ * Matches Kubernetes IsDNS1123Subdomain: the whole name is capped at 253
+ * characters, without a separate 63-character cap on dot-separated parts.
+ * Namespace names use validateRFC1123Label instead.
  */
 export function validateRFC1123Subdomain(input: string): ValidationResult {
   if (input.length === 0) {
@@ -90,18 +88,6 @@ export function validateRFC1123Subdomain(input: string): ValidationResult {
       error: 'must contain only lowercase letters, numbers, hyphens, and dots, and each segment must start/end with a letter or number',
     }
   }
-  // Per-label cap: K8s' IsDNS1123Subdomain enforces ≤ 63 chars
-  // PER dot-separated label on top of the 253-char total. The
-  // regex above doesn't catch that; without this check a single
-  // 200-char label passes here and only fails server-side.
-  for (const label of input.split('.')) {
-    if (label.length > RFC1123_LABEL_MAX) {
-      return {
-        valid: false,
-        error: `each dot-separated label must be at most ${RFC1123_LABEL_MAX} characters (got ${label.length} for "${label}")`,
-      }
-    }
-  }
   return { valid: true }
 }
 

package/src/utils/view-transition.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi } from 'vitest'
-import { isInvalidStateError, startViewTransitionSafe } from './view-transition'
+import { isInvalidStateError, isWebKitGTK, startViewTransitionSafe } from './view-transition'
 
 // SKY-833 bug 49: rapid tab / route switches surfaced
 // "InvalidStateError: Transition was aborted because of invalid state"
@@ -79,3 +79,37 @@ describe('startViewTransitionSafe', () => {
     expect(isInvalidStateError(new TypeError('y'))).toBe(false)
   })
 })
+
+const WEBKITGTK_UA =
+  'Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0 Safari/605.1.15'
+
+describe('isWebKitGTK', () => {
+  it('matches WebKitGTK user agents', () => {
+    expect(isWebKitGTK(WEBKITGTK_UA)).toBe(true)
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko)')).toBe(true)
+  })
+
+  it('does not match other engines on Linux, or Safari', () => {
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (X11; Linux x86_64; rv:140.0) Gecko/20100101 Firefox/140.0')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (Linux; Android 15) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Mobile Safari/537.36')).toBe(false)
+    expect(isWebKitGTK('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0 Safari/605.1.15')).toBe(false)
+  })
+})
+
+describe('startViewTransitionSafe under WebKitGTK', () => {
+  it('applies the update directly instead of starting a transition', () => {
+    const originalDoc = (globalThis as { document?: unknown }).document
+    const startSpy = vi.fn()
+    ;(globalThis as { document: object }).document = { startViewTransition: startSpy }
+    const uaSpy = vi.spyOn(navigator, 'userAgent', 'get').mockReturnValue(WEBKITGTK_UA)
+
+    const update = vi.fn()
+    startViewTransitionSafe(update)
+    expect(update).toHaveBeenCalledTimes(1)
+    expect(startSpy).not.toHaveBeenCalled()
+
+    uaSpy.mockRestore()
+    ;(globalThis as { document?: unknown }).document = originalDoc
+  })
+})