@skyhook-io/k8s-ui 1.16.3 → 1.17.1

package/src/components/resources/resource-utils-cnpg.test.ts

@@ -14,6 +14,7 @@ import {
   getCNPGWALArchivingFailure,
   getCNPGLastBackupFailure,
   classifyCNPGClusterPhase,
+  cnpgBlockedPhaseExplanation,
   classifyCNPGBackupPhase,
   CNPG_CLUSTER_PHASES_HEALTHY,
   CNPG_CLUSTER_PHASES_TRANSIENT,
@@ -115,6 +116,26 @@ describe('getCNPGClusterCertificateExpirations', () => {
 
 const cluster = (status: any = {}, spec: any = {}) => ({ spec, status })
 
+describe('cnpgBlockedPhaseExplanation', () => {
+  it('says the operator retries a plugin phase, and quotes its reason', () => {
+    const e = cnpgBlockedPhaseExplanation(
+      'Cluster cannot proceed to reconciliation due to an unknown plugin being required',
+      "Unknown plugin: 'barman-cloud.cloudnative-pg.io'. Check the operator and plugin logs for errors",
+    )
+    expect(e.title).toBe('Reconciliation is blocked by a plugin')
+    expect(e.body).toMatch(/retries every few seconds/)
+    expect(e.body).not.toMatch(/manual intervention|does not resolve/)
+    expect(e.body).toMatch(/The operator reports: Unknown plugin/)
+    expect(e.body.endsWith('for errors.')).toBe(true)
+    expect(e.message.startsWith('Cluster cannot proceed')).toBe(true)
+  })
+  it('keeps manual intervention for the one phase upstream says needs it', () => {
+    expect(cnpgBlockedPhaseExplanation('Cluster is unrecoverable and needs manual intervention').title).toBe('Cluster is unrecoverable')
+    const objects = cnpgBlockedPhaseExplanation('Unable to create required cluster objects', '  ')
+    expect(objects.body).toBe('The operator keeps retrying, but this does not clear until its cause is fixed.')
+  })
+})
+
 describe('classifyCNPGClusterPhase', () => {
   it('buckets every phase constant shipped by CNPG 1.27', () => {
     for (const p of CNPG_CLUSTER_PHASES_HEALTHY) expect(classifyCNPGClusterPhase(p)).toBe('healthy')
@@ -365,13 +386,17 @@ describe('getCNPGClusterInstancesReportedState', () => {
 // ============================================================================
 
 describe('getCNPGPoolerStatus', () => {
+  it('uses the requested count during scale-down without claiming readiness', () => {
+    expect(getCNPGPoolerStatus({ spec: { instances: 2 }, status: { instances: 3 } })).toMatchObject({ text: '2 instances requested', level: 'neutral' })
+    expect(getCNPGPoolerStatus({ spec: { instances: 1 }, status: { instances: 1 } })).toMatchObject({ text: '1 instance requested', level: 'neutral' })
+  })
   it('does not claim readiness from status.instances, which counts scheduled pods', () => {
     // Verified live: a Pooler whose 2 PgBouncer pods are both Pending (0/1
     // ready) still reports status.instances=2. Calling that "Ready" renders a
     // broken Pooler green.
     const s = getCNPGPoolerStatus({ spec: { instances: 2 }, status: { instances: 2 } })
-    expect(s.level).toBe('healthy')
-    expect(s.text).toBe('Scheduled')
+    expect(s.level).toBe('neutral')
+    expect(s.text).toBe('2 instances requested')
     expect(s.text).not.toBe('Ready')
   })
 
@@ -595,7 +620,7 @@ describe('status column filter reads the badge, not the raw phase', () => {
     )).toBe('Suspended')
     expect(getCellFilterValue(
       { apiVersion: 'postgresql.cnpg.io/v1', spec: { instances: 2 }, status: { instances: 2 } }, 'status', 'poolers',
-    )).toBe('Scheduled')
+    )).toBe('2 instances requested')
   })
 
   it('leaves a foreign CRD sharing the plural on the generic path', () => {
@@ -670,7 +695,7 @@ describe('an absent count is unknown, never zero', () => {
     expect(getCNPGPoolerStatus({ spec: { instances: 2 }, status: { instances: 0 } }))
       .toMatchObject({ text: 'Not Scheduled', level: 'unhealthy' })
     expect(getCNPGPoolerStatus({ spec: { instances: 2 }, status: { instances: 2 } }))
-      .toMatchObject({ text: 'Scheduled', level: 'healthy' })
+      .toMatchObject({ text: '2 instances requested', level: 'neutral' })
   })
 })
 
@@ -696,9 +721,9 @@ describe('paused Pooler', () => {
 
   it('only an explicit true pauses', () => {
     expect(getCNPGPoolerStatus({ spec: { instances: 2, pgbouncer: {} }, status: { instances: 2 } }))
-      .toMatchObject({ text: 'Scheduled', level: 'healthy' })
+      .toMatchObject({ text: '2 instances requested', level: 'neutral' })
     expect(getCNPGPoolerStatus({ spec: { instances: 2, pgbouncer: { paused: false } }, status: { instances: 2 } }))
-      .toMatchObject({ text: 'Scheduled', level: 'healthy' })
+      .toMatchObject({ text: '2 instances requested', level: 'neutral' })
     expect(isCNPGPoolerPaused({ spec: { pgbouncer: { paused: true } } })).toBe(true)
     expect(isCNPGPoolerPaused({ spec: {} })).toBe(false)
   })
@@ -752,9 +777,9 @@ describe('CNPG scheduled backup lateness', () => {
     expect(badge.text).toBe('Overdue')
   })
 
-  it('stays healthy inside the operator reconcile window', () => {
+  it('stays neutral inside the operator reconcile window', () => {
     const badge = getCNPGScheduledBackupStatus(sb(false, at(-1 * MIN), at(-24 * 60 * MIN)))
-    expect(badge.level).toBe('healthy')
+    expect(badge.level).toBe('neutral')
   })
 
   it('keeps suspended as a deliberate state, not a missed backup', () => {
@@ -768,7 +793,7 @@ describe('CNPG scheduled backup lateness', () => {
     // The two read from one test. Before this they disagreed: the badge said
     // Active while this field said overdue on the same row.
     const justPastDue = sb(false, at(-1 * MIN), at(-24 * 60 * MIN))
-    expect(getCNPGScheduledBackupStatus(justPastDue).level).toBe('healthy')
+    expect(getCNPGScheduledBackupStatus(justPastDue).level).toBe('neutral')
     expect(getCNPGScheduledBackupNextSchedule(justPastDue)).toBe('due now')
 
     const longPastDue = sb(false, at(-200 * 24 * 60 * MIN), at(-200 * 24 * 60 * MIN))
@@ -783,7 +808,7 @@ describe('CNPG scheduled backup lateness', () => {
 
   it('says nothing when the operator published no next-run time', () => {
     expect(getCNPGScheduledBackupNextSchedule(sb(false))).toBe('-')
-    expect(getCNPGScheduledBackupStatus(sb(false, undefined, at(-24 * 60 * MIN))).level).toBe('healthy')
+    expect(getCNPGScheduledBackupStatus(sb(false, undefined, at(-24 * 60 * MIN))).level).toBe('neutral')
   })
 })
 

package/src/components/resources/resource-utils-cnpg.ts

@@ -2,6 +2,9 @@
 
 import type { StatusBadge } from './resource-utils'
 import { healthColors, formatAge, formatDuration } from './resource-utils'
+import { cnpgBackupDeclaration, cnpgBarmanPlugin } from '../../utils/cnpg-backup'
+export { CNPG_BARMAN_PLUGIN_NAME } from '../../utils/cnpg-backup'
+
 import { parseGoTimeString } from '../../utils/parse-go-time'
 
 // ============================================================================
@@ -10,6 +13,11 @@ import { parseGoTimeString } from '../../utils/parse-go-time'
 
 export const CNPG_GROUP = 'postgresql.cnpg.io'
 
+export function getCNPGPostgresMajor(cluster: any): number | undefined {
+  const major = cluster?.status?.pgDataImageInfo?.majorVersion ?? cluster?.spec?.imageCatalogRef?.major
+  return typeof major === 'number' && Number.isInteger(major) && major > 0 ? major : undefined
+}
+
 /**
  * Exact API-group match for a resource's `apiVersion` ("group/version").
  *
@@ -56,7 +64,11 @@ export const CNPG_CLUSTER_PHASES_TRANSIENT = [
 /** Losing the primary — degraded now, self-resolving only if a replica can take over. */
 export const CNPG_CLUSTER_PHASES_FAILING = ['Failing over'] as const
 
-/** Reconciliation has stopped. These need a human; none of them self-heal. */
+/**
+ * Reconciliation is blocked. The operator keeps retrying every one of these;
+ * only the plugin phases can clear without anyone changing something (a plugin
+ * Pod that comes back). See cnpgBlockedPhaseExplanation.
+ */
 export const CNPG_CLUSTER_PHASES_TERMINAL = [
   'Cluster is unrecoverable and needs manual intervention',
   // Not in 1.27 or 1.28; added upstream after 1.28 (PhaseDefinitionInvalid).
@@ -135,6 +147,34 @@ export function getCNPGClusterDisplayState(phase: string): string {
 
 export type CNPGPhaseBucket = 'healthy' | 'transient' | 'failing' | 'terminal' | 'attention' | 'unknown'
 
+const CNPG_PLUGIN_BLOCKED_PHASES = new Set<string>([
+  'Cluster cannot proceed to reconciliation due to an unknown plugin being required',
+  'Cluster cannot proceed to reconciliation due to an error while interacting with plugins',
+])
+
+/**
+ * What a blocked phase means for whoever is on call, with the operator's own
+ * `status.phaseReason` when it set one. The operator requeues the plugin
+ * phases every 10–15 s, so they clear once the plugin loads and answers;
+ * the others keep failing until their cause is fixed; "unrecoverable" is the
+ * one upstream itself says needs manual intervention.
+ */
+export function cnpgBlockedPhaseExplanation(phase: string, phaseReason?: string): { title: string; message: string; body: string } {
+  const said = typeof phaseReason === 'string' ? phaseReason.trim() : ''
+  const reason = said ? ` The operator reports: ${/[.!?]$/.test(said) ? said : `${said}.`}` : ''
+  const out = (title: string, body: string) => ({ title, body: `${body}${reason}`, message: `${phase}. ${body}${reason}` })
+  if (phase === 'Cluster is unrecoverable and needs manual intervention') {
+    return out('Cluster is unrecoverable', 'The operator cannot bring it back by itself.')
+  }
+  if (CNPG_PLUGIN_BLOCKED_PHASES.has(phase)) {
+    return out(
+      'Reconciliation is blocked by a plugin',
+      'The operator retries every few seconds and continues once the plugin is loaded and answering, so a plugin Pod that is restarting clears on its own; check the operator and plugin logs if it does not.',
+    )
+  }
+  return out('Reconciliation is blocked', 'The operator keeps retrying, but this does not clear until its cause is fixed.')
+}
+
 export function classifyCNPGClusterPhase(phase: string): CNPGPhaseBucket {
   if (!phase) return 'unknown'
   if ((CNPG_CLUSTER_PHASES_HEALTHY as readonly string[]).includes(phase)) return 'healthy'
@@ -414,7 +454,6 @@ export function getCNPGClusterUpdateStrategy(resource: any): string {
   return resource.spec?.primaryUpdateStrategy || 'unsupervised'
 }
 
-export const CNPG_BARMAN_PLUGIN_NAME = 'barman-cloud.cloudnative-pg.io'
 
 /** The API group ObjectStore is served under. `objectstores` is a generic
  *  plural several operators ship, so every link to one has to be qualified —
@@ -438,20 +477,10 @@ export interface CNPGBarmanPlugin {
  * status.lastSuccessfulBackup / firstRecoverabilityPoint entirely.
  */
 export function getCNPGClusterBarmanPlugin(resource: any): CNPGBarmanPlugin | null {
-  const plugins = resource.spec?.plugins
-  if (!Array.isArray(plugins)) return null
-  const plugin = plugins.find(
-    (p: any) => p?.name === CNPG_BARMAN_PLUGIN_NAME && p?.enabled !== false
-  )
+  const plugin = cnpgBarmanPlugin(cnpgBackupDeclaration(resource))
   if (!plugin) return null
-  return {
-    name: plugin.name,
-    barmanObjectName: plugin.parameters?.barmanObjectName,
-    // ObjectStore keys the recovery window by the plugin's serverName when set,
-    // otherwise by the cluster name.
-    serverName: plugin.parameters?.serverName || resource.metadata?.name,
-    isWALArchiver: plugin.isWALArchiver === true,
-  }
+  const { name, barmanObjectName, serverName, isWALArchiver } = plugin
+  return { name, barmanObjectName, serverName, isWALArchiver }
 }
 
 export function getCNPGClusterBackupConfig(resource: any): {
@@ -518,7 +547,7 @@ export function getCNPGDeclarativeMessage(resource: any): string | undefined {
 export function getCNPGReclaimPolicy(resource: any): { value: string; destructive: boolean } {
   const spec = resource?.spec ?? {}
   const raw =
-    spec.databaseReclaimPolicy ?? spec.publicationReclaimPolicy ?? spec.subscriptionReclaimPolicy ?? 'retain'
+    spec.databaseReclaimPolicy ?? spec.publicationReclaimPolicy ?? spec.subscriptionReclaimPolicy ?? spec.databaseRoleReclaimPolicy ?? 'retain'
   return { value: raw, destructive: String(raw).toLowerCase() === 'delete' }
 }
 
@@ -865,10 +894,6 @@ export function getCNPGBackupStartedAt(resource: any): string {
   return resource.status?.startedAt ? formatAge(resource.status.startedAt) : '-'
 }
 
-export function getCNPGBackupStoppedAt(resource: any): string {
-  return resource.status?.stoppedAt ? formatAge(resource.status.stoppedAt) : '-'
-}
-
 export function getCNPGBackupName(resource: any): string {
   return resource.status?.backupName || '-'
 }
@@ -937,15 +962,15 @@ export function getCNPGScheduledBackupStatus(resource: any): StatusBadge {
 
   // If we have a last schedule time, it's active
   if (resource.status?.lastScheduleTime) {
-    return { text: 'Active', color: healthColors.healthy, level: 'healthy' }
+    return { text: 'Enabled', color: healthColors.neutral, level: 'neutral' }
   }
 
   // Check if immediate flag is set and no schedule has run yet
   if (resource.spec?.immediate) {
-    return { text: 'Immediate', color: healthColors.healthy, level: 'healthy' }
+    return { text: 'Immediate run requested', color: healthColors.neutral, level: 'neutral' }
   }
 
-  return { text: 'Scheduled', color: healthColors.healthy, level: 'healthy' }
+  return { text: 'Enabled · not run yet', color: healthColors.neutral, level: 'neutral' }
 }
 
 export function getCNPGScheduledBackupCluster(resource: any): string {
@@ -1034,8 +1059,10 @@ export function getCNPGPoolerStatus(resource: any): StatusBadge {
     return { text: 'Paused', color: healthColors.degraded, level: 'degraded' }
   }
 
+  // status.instances counts scheduled Pods only; readiness lives on the
+  // Pooler's Deployment, so this badge must not read as healthy.
   if (desired > 0 && scheduled >= desired) {
-    return { text: 'Scheduled', color: healthColors.healthy, level: 'healthy' }
+    return { text: `${desired} instance${desired === 1 ? '' : 's'} requested`, color: healthColors.neutral, level: 'neutral' }
   }
 
   return { text: 'Unknown', color: healthColors.unknown, level: 'unknown' }

package/src/components/resources/resource-utils-contour.test.ts

@@ -0,0 +1,44 @@
+import { describe, expect, it } from 'vitest'
+import { readFileSync } from 'node:fs'
+import { getContourSecretReference, getHTTPProxyTLSSecret } from './resource-utils-contour'
+
+const proxy = (secretName?: string) => ({
+  metadata: { namespace: 'shop' },
+  spec: { virtualhost: { fqdn: 'shop.example.com', tls: secretName === undefined ? {} : { secretName } } },
+})
+
+describe('getHTTPProxyTLSSecret', () => {
+  it('resolves a bare name in the proxy namespace', () => {
+    expect(getHTTPProxyTLSSecret(proxy('cert'))).toEqual({ namespace: 'shop', name: 'cert' })
+  })
+  it('resolves a delegated namespace/name', () => {
+    expect(getHTTPProxyTLSSecret(proxy('certs/wildcard'))).toEqual({ namespace: 'certs', name: 'wildcard' })
+  })
+  it('defaults an empty namespace to the proxy namespace', () => {
+    expect(getHTTPProxyTLSSecret(proxy('/cert'))).toEqual({ namespace: 'shop', name: 'cert' })
+  })
+  it('rejects names that cannot identify a Kubernetes Secret', () => {
+    expect(getHTTPProxyTLSSecret(proxy('certs/a/b'))).toBeNull()
+  })
+  it('returns null without a secret', () => {
+    expect(getHTTPProxyTLSSecret(proxy())).toBeNull()
+  })
+})
+
+interface ReferenceCase {
+  case: string
+  raw: string
+  defaultNamespace: string
+  valid: boolean
+  namespace?: string
+  name?: string
+}
+const referenceCases: ReferenceCase[] = JSON.parse(readFileSync(new URL('../../../../../pkg/configrefs/testdata/contour_secret_refs.json', import.meta.url), 'utf8'))
+
+describe('shared Go/TS Contour reference contract', () => {
+  it.each(referenceCases)('$case', (tc) => {
+    const expected = tc.valid ? { namespace: tc.namespace, name: tc.name } : undefined
+    expect(getContourSecretReference(tc.raw, tc.defaultNamespace)).toEqual(expected)
+    expect(getHTTPProxyTLSSecret({ ...proxy(tc.raw), metadata: { namespace: tc.defaultNamespace } })).toEqual(expected ?? null)
+  })
+})

package/src/components/resources/resource-utils-contour.ts

@@ -1,3 +1,5 @@
+import { validateRFC1123Label, validateRFC1123Subdomain } from '../../utils/validators'
+
 // Contour HTTPProxy CRD utility functions for resource list cells and detail renderers
 
 export function getHTTPProxyFQDN(resource: any): string {
@@ -32,3 +34,17 @@ export function getHTTPProxyIncludeCount(resource: any): number {
 export function hasHTTPProxyTLS(resource: any): boolean {
   return !!resource.spec?.virtualhost?.tls
 }
+
+export function getHTTPProxyTLSSecret(resource: any): { namespace: string; name: string } | null {
+  const raw: string | undefined = resource.spec?.virtualhost?.tls?.secretName
+  return raw ? getContourSecretReference(raw, resource.metadata?.namespace ?? '') ?? null : null
+}
+
+/** Contour's delegated TLS secret form is namespace/name. */
+export function getContourSecretReference(raw: string, defaultNamespace: string): { name: string; namespace: string } | undefined {
+  const parts = raw.split('/')
+  const namespace = parts.length === 1 ? defaultNamespace : parts[0] || defaultNamespace
+  const name = parts.length === 1 ? parts[0] : parts[1]
+  if (parts.length > 2 || !validateRFC1123Label(namespace).valid || !validateRFC1123Subdomain(name).valid) return undefined
+  return { name, namespace }
+}

package/src/components/resources/resource-utils-istio.ts

@@ -8,13 +8,17 @@ import { pluralize } from '../../utils/pluralize'
 // SHARED HELPERS
 // ============================================================================
 
-function parseIstioHost(host: string): { name: string; namespace: string } {
-  // Istio hosts can be: "reviews", "reviews.default", "reviews.default.svc.cluster.local"
+// FQDNs require the registry domain supplied by the producer. Undotted
+// names use Istio's documented namespace-relative expansion.
+export function resolveIstioServiceHost(host: string, defaultNamespace: string, serviceDomain = ''): { name: string; namespace: string } | undefined {
+  const label = /^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/
   const parts = host.split('.')
-  return {
-    name: parts[0] || host,
-    namespace: parts.length >= 2 ? parts[1] : '',
+  if (parts.length === 1 && host.length <= 63 && label.test(host)) return { name: host, namespace: defaultNamespace }
+  if (serviceDomain && host.endsWith(`.svc.${serviceDomain}`)) {
+    const service = host.slice(0, -(`.svc.${serviceDomain}`.length)).split('.')
+    if (service.length === 2 && service.every(part => part.length <= 63 && label.test(part))) return { name: service[0], namespace: service[1] }
   }
+  return undefined
 }
 
 // ============================================================================
@@ -103,16 +107,16 @@ export function getVirtualServiceTlsRoutes(resource: any): any[] {
   return resource.spec?.tls || []
 }
 
-export function getVirtualServiceDestinations(resource: any): Array<{ host: string; namespace: string; port?: number; subset?: string; weight?: number }> {
+export function getVirtualServiceDestinations(resource: any, serviceDomain = ''): Array<{ host: string; namespace: string; port?: number; subset?: string; weight?: number }> {
   const destinations: Array<{ host: string; namespace: string; port?: number; subset?: string; weight?: number }> = []
   const httpRoutes = resource.spec?.http || []
   for (const route of httpRoutes) {
     for (const dest of (route.route || [])) {
       if (dest.destination?.host) {
-        const parsed = parseIstioHost(dest.destination.host)
+        const parsed = resolveIstioServiceHost(dest.destination.host, resource.metadata?.namespace || '', serviceDomain)
         destinations.push({
           host: dest.destination.host,
-          namespace: parsed.namespace || resource.metadata?.namespace || '',
+          namespace: parsed?.namespace || '',
           port: dest.destination.port?.number,
           subset: dest.destination.subset,
           weight: dest.weight,

package/src/components/resources/resource-utils-keda.ts

@@ -1,7 +1,7 @@
 // KEDA CRD utility functions
 
 import type { StatusBadge } from './resource-utils'
-import { healthColors, formatAge } from './resource-utils'
+import { healthColors } from './resource-utils'
 
 // ============================================================================
 // SHARED HELPERS
@@ -108,12 +108,6 @@ export function getScaledObjectHpaName(resource: any): string {
   return resource.status?.hpaName || '-'
 }
 
-export function getScaledObjectLastActiveTime(resource: any): string {
-  const lastActive = resource.status?.lastActiveTime
-  if (!lastActive) return '-'
-  return formatAge(lastActive)
-}
-
 export function getScaledObjectPollingInterval(resource: any): number {
   return resource.spec?.pollingInterval ?? 30
 }

package/src/components/resources/resource-utils-knative.ts

@@ -1,3 +1,21 @@
+import { apiVersionToGroup, kindToPluralWithGroup } from '../../utils/navigation'
+import type { ResourceRef } from '../../types/core'
+
+/** KReference records apiVersion or an explicit nonempty group. */
+export function getKnativeReference(reference: any, defaultNamespace: string): ResourceRef | undefined {
+  const version = reference?.apiVersion
+  let group = reference?.group
+  if (typeof version === 'string' && version) {
+    const parts = version.split('/')
+    if (parts.length > 2 || parts.some(part => !part)) return undefined
+    const observed = apiVersionToGroup(version)
+    if (group && group !== observed) return undefined
+    group = observed
+  } else if (typeof group !== 'string' || !group) return undefined
+  if (typeof reference?.kind !== 'string' || !reference.kind || typeof reference?.name !== 'string' || !reference.name) return undefined
+  return { group, kind: kindToPluralWithGroup(reference.kind, group), name: reference.name, namespace: reference.namespace || defaultNamespace }
+}
+
 // KNative CRD utility functions
 
 import type { StatusBadge } from './resource-utils'

package/src/components/resources/resource-utils-kyverno.ts

@@ -1,7 +1,7 @@
 // Kyverno / Policy Report CRD utility functions
 
 import type { StatusBadge } from './resource-utils'
-import { healthColors, formatAge } from './resource-utils'
+import { healthColors } from './resource-utils'
 
 // ============================================================================
 // SHARED HELPERS
@@ -286,12 +286,6 @@ export function getKyvernoPolicyAutogenRules(resource: any): string[] {
   return autogen.map((r: any) => r.name).filter(Boolean)
 }
 
-export function getKyvernoPolicyLastScheduleTime(resource: any): string {
-  const lastSchedule = resource.status?.lastScheduleTime
-  if (!lastSchedule) return '-'
-  return formatAge(lastSchedule)
-}
-
 // ============================================================================
 // KYVERNO CLUSTERPOLICY UTILITIES (kyverno.io/v1)
 // ============================================================================

package/src/components/resources/resource-utils-velero.ts

@@ -504,12 +504,6 @@ export function getBSLLastValidation(resource: any): string {
   return formatAge(lastValidation)
 }
 
-export function getBSLLastSynced(resource: any): string {
-  const lastSynced = resource.status?.lastSyncedTime
-  if (!lastSynced) return '-'
-  return formatAge(lastSynced)
-}
-
 // Why the location is unavailable, in the validation controller's own words.
 // A BackupStorageLocation carries no conditions, so status.message is the only
 // place the reason exists — without it the phase is the whole story a reader
@@ -571,12 +565,6 @@ export function getBackupRepositoryMaintenanceFrequency(resource: any): string {
   return resource.spec?.maintenanceFrequency || '-'
 }
 
-export function getBackupRepositoryLastMaintenance(resource: any): string {
-  const at = resource.status?.lastMaintenanceTime
-  if (!at) return '-'
-  return formatAge(at)
-}
-
 // Why the repository is not ready, in the controller's own words. Velero writes
 // it on the object and nowhere else, so without it the phase is the whole story
 // a reader gets.