@skyhook-io/k8s-ui 1.13.3 → 1.14.0

package/src/components/shared/ResourceRendererDispatch.tsx

@@ -1,7 +1,10 @@
 import { clsx } from 'clsx'
-import { SEVERITY_BADGE } from '../../utils/badge-colors'
+import { SEVERITY_BADGE, HEALTH_BADGE_COLORS } from '../../utils/badge-colors'
+import { isArgoRolloutResource } from '../../utils/workload-rollout'
+import { getGenericResourceStatus } from '../resources/generic-status'
 import {
   getPodStatus,
+  getWorkloadDisplayStatus,
   getWorkloadStatus,
   getJobStatus,
   getCronJobStatus,
@@ -9,7 +12,6 @@ import {
   getServiceStatus,
   getNodeStatus,
   getPVCStatus,
-  getRolloutStatus,
   getAnalysisRunStatus,
   getWorkflowStatus,
   getCronWorkflowStatus,
@@ -65,6 +67,17 @@ import {
 } from '../resources/resource-utils-kyverno-exceptions'
 import { getResourceClaimStatus, getResourceClaimTemplateStatus, getDeviceClassStatus, getResourceSliceStatus } from '../resources/resource-utils-dra'
 import { getNvidiaClusterPolicyStatus, getNvidiaDriverStatus } from '../resources/resource-utils-nvidia'
+import { getClusterQueueStatus, getLocalQueueStatus, getKueueWorkloadStatus, getResourceFlavorStatus, getAdmissionCheckStatus, getProvisioningRequestStatus } from '../resources/resource-utils-kueue'
+import { getRayClusterStatus, getRayJobStatus, getRayServiceStatus, getRayCronJobStatus } from '../resources/resource-utils-ray'
+import { getLeaderWorkerSetStatus, getJobSetStatus } from '../resources/resource-utils-jobset-lws'
+import { getInferenceServiceStatus, getServingRuntimeStatus, getInferenceGraphStatus, getTrainedModelStatus, getLLMInferenceServiceStatus } from '../resources/resource-utils-kserve'
+import { getInferencePoolStatus, getInferenceObjectiveStatus } from '../resources/resource-utils-inference-gateway'
+import { getVolcanoJobStatus, getVolcanoQueueStatus, getVolcanoPodGroupStatus, getJobFlowStatus, getJobTemplateStatus } from '../resources/resource-utils-volcano'
+import { getKaiQueueStatus, getKaiPodGroupStatus } from '../resources/resource-utils-kai'
+import { getKaitoWorkspaceStatus, getRAGEngineStatus } from '../resources/resource-utils-kaito'
+import { getNIMServiceStatus, getNIMCacheStatus, getNIMPipelineStatus } from '../resources/resource-utils-nim'
+import { getAMDDeviceConfigStatus } from '../resources/resource-utils-amd-gpu'
+import { getPyTorchJobStatus, getTFJobStatus, getMPIJobStatus, getTrainJobStatus } from '../resources/resource-utils-kubeflow-training'
 import { getBackupStatus, getRestoreStatus, getScheduleStatus, getBSLStatus, getBackupRepositoryStatus, isVeleroResource } from '../resources/resource-utils-velero'
 import {
   getVirtualServiceStatus,
@@ -272,7 +285,7 @@ import {
   isComposite,
   isClaim,
 } from '../resources/resource-utils-crossplane'
-import type { SelectedResource, Relationships, ResourceRef, SecretCertificateInfo, ResolvedEnvFrom, TimelineEvent, HPADiagnosis } from '../../types'
+import type { SelectedResource, Relationships, ResourceRef, SecretCertificateInfo, ResolvedEnvFrom, TimelineEvent, HPADiagnosis, WorkloadPodInfo } from '../../types'
 import type { CopyHandler } from '../ui/drawer-components'
 import { AlertBanner } from '../ui/drawer-components'
 import { replicaScalers } from '../../utils/replica-scalers'
@@ -310,6 +323,7 @@ export interface RendererOverrides {
     relationships?: Relationships
     scaleBlockedBy?: ResourceRef[]
     scalerDiagnostics?: ScalerDiagnosis[]
+    workloadPods?: WorkloadPodInfo[]
   }>
   // Optional override for Crossplane Composite / Claim — host wraps the
   // package renderer to fan out per-composed-ref status fetches via React Query.
@@ -500,6 +514,7 @@ interface ResourceRendererDispatchProps {
   certificateInfo?: SecretCertificateInfo
   hpaDiagnosis?: HPADiagnosis
   scalerDiagnostics?: ScalerDiagnosis[]
+  workloadPods?: WorkloadPodInfo[]
   onCopy: (text: string, key: string) => void
   copied: string | null
   onNavigate?: (ref: ResourceRef) => void
@@ -545,6 +560,7 @@ export function ResourceRendererDispatch({
   certificateInfo,
   hpaDiagnosis,
   scalerDiagnostics,
+  workloadPods,
   onCopy,
   copied,
   onNavigate,
@@ -646,7 +662,7 @@ export function ResourceRendererDispatch({
     kind === 'clusters' || kind === 'backups' || kind === 'scheduledbackups' || kind === 'poolers'
     || kind === 'objectstores' || kind === 'databases' || kind === 'publications'
     || kind === 'subscriptions' || kind === 'imagecatalogs' || kind === 'clusterimagecatalogs'
-    || kind === 'policies'
+    || kind === 'policies' || kind === 'rollouts'
   const isCNPGApiVersion = isApiGroup(data?.apiVersion, CNPG_GROUP)
   const groupGatedMatched =
     (kind === 'clusters' && (isCNPGApiVersion || isApiGroup(data?.apiVersion, 'cluster.x-k8s.io')))
@@ -658,6 +674,7 @@ export function ResourceRendererDispatch({
     || (kind === 'subscriptions'
       && (isCNPGApiVersion || isApiGroup(data?.apiVersion, 'messaging.knative.dev')))
     || (kind === 'policies' && isApiGroup(data?.apiVersion, 'kyverno.io'))
+    || (kind === 'rollouts' && isArgoRolloutResource(data))
   const groupGatedFallthrough = isGroupGatedKind && !groupGatedMatched
 
   const calicoApiVersionMatched = isCalicoApiVersion(data?.apiVersion)
@@ -672,6 +689,10 @@ export function ResourceRendererDispatch({
     isCalicoPolicyKind(kind) || kind === 'hostendpoints' || kind === 'ippools' || kind === 'tiers'
   ) && !isCoreNetworkPolicy && !((isCalicoPolicy || isCalicoHostEndpoint || isCalicoIPPool || isCalicoTier))
 
+  const nonCoreJobFallthrough = kind === 'jobs'
+    && !!data?.apiVersion
+    && !data.apiVersion.startsWith('batch/')
+
   const isKnownKind = KNOWN_KINDS.has(kind) || isCrossplaneMR || isCrossplaneClaim || isCrossplaneXR
 
   const PodComp = rendererOverrides?.PodRenderer ?? PodRenderer
@@ -727,6 +748,7 @@ export function ResourceRendererDispatch({
             relationships={relationships}
             scaleBlockedBy={scaleBlockedBy}
             scalerDiagnostics={scalerDiagnostics}
+            workloadPods={workloadPods}
           />
         )}
         {kind === 'replicasets' && <ReplicaSetRenderer data={data} />}
@@ -735,13 +757,13 @@ export function ResourceRendererDispatch({
         {kind === 'ingresses' && !data?.apiVersion?.includes('networking.internal.knative.dev') && <IngressRenderer data={data} onNavigate={onNavigate} />}
         {kind === 'configmaps' && <ConfigMapRenderer data={data} />}
         {kind === 'secrets' && <SecretRenderer data={data} certificateInfo={certificateInfo} resourceData={data} onSaveSecretValue={onSaveSecretValue} isSaving={isSavingSecret} />}
-        {kind === 'jobs' && <JobRenderer data={data} />}
+        {kind === 'jobs' && !nonCoreJobFallthrough && <JobRenderer data={data} />}
         {kind === 'cronjobs' && <CronJobRenderer data={data} onNavigate={onNavigate} />}
         {kind === 'cronworkflows' && <CronWorkflowRenderer data={data} onNavigate={onNavigate} />}
         {(kind === 'hpas' || kind === 'horizontalpodautoscalers') && <HPAComp data={data} onNavigate={onNavigate} hpaDiagnosis={hpaDiagnosis} />}
         {kind === 'nodes' && <NodeComp data={data} relationships={relationships} />}
         {kind === 'persistentvolumeclaims' && <PVCComp data={data} onNavigate={onNavigate} />}
-        {kind === 'rollouts' && <RolloutComp data={data} onNavigate={onNavigate} />}
+        {kind === 'rollouts' && isArgoRolloutResource(data) && <RolloutComp data={data} onNavigate={onNavigate} />}
         {kind === 'analysisruns' && <AnalysisRunRenderer data={data} onNavigate={onNavigate} />}
         {kind === 'certificates' && !data?.apiVersion?.includes('networking.internal.knative.dev') && <CertificateRenderer data={data} />}
         {kind === 'workflows' && <WorkflowRenderer data={data} onNavigate={onNavigate} />}
@@ -934,7 +956,7 @@ export function ResourceRendererDispatch({
             for known-plural collisions where no apiVersion-gated renderer
             matched (e.g. a Knative Configuration sharing the `configurations`
             plural with Crossplane Configuration). */}
-        {(!isKnownKind || crossplaneCollisionFallthrough || kyvernoCollisionFallthrough || veleroCollisionFallthrough || groupGatedFallthrough || calicoCollisionFallthrough) && <GenericRenderer data={data} />}
+        {(!isKnownKind || crossplaneCollisionFallthrough || kyvernoCollisionFallthrough || veleroCollisionFallthrough || groupGatedFallthrough || calicoCollisionFallthrough || nonCoreJobFallthrough) && <GenericRenderer data={data} />}
 
         {/* Common sections - can be disabled when parent handles them separately */}
         {showCommonSections && (
@@ -988,7 +1010,10 @@ export function getResourceStatus(kind: string, data: any): { text: string; colo
   const k = kind.toLowerCase()
 
   if (k === 'pods') return getPodStatus(data)
-  if (['deployments', 'statefulsets', 'replicasets', 'daemonsets'].includes(k)) return getWorkloadStatus(data, k)
+  if (['deployments', 'statefulsets', 'daemonsets', 'rollouts'].includes(k)) {
+    return getWorkloadDisplayStatus(data, k).status
+  }
+  if (k === 'replicasets') return getWorkloadStatus(data, k)
   if (k === 'services') {
     if (data.apiVersion?.includes('serving.knative.dev')) {
       const status = getKnativeConditionStatus(data)
@@ -1006,12 +1031,59 @@ export function getResourceStatus(kind: string, data: any): { text: string; colo
       SEVERITY_BADGE.error
     return { text, color }
   }
-  if (k === 'jobs') return getJobStatus(data)
+  if (k === 'jobs') {
+    if (data?.apiVersion?.startsWith('batch.volcano.sh/')) return getVolcanoJobStatus(data)
+    if (!data?.apiVersion || data.apiVersion.startsWith('batch/')) return getJobStatus(data)
+  }
+  if (k === 'queues') {
+    if (data?.apiVersion?.startsWith('scheduling.run.ai/')) return getKaiQueueStatus(data)
+    if (data?.apiVersion?.startsWith('scheduling.volcano.sh/')) return getVolcanoQueueStatus(data)
+  }
+  if (k === 'podgroups') {
+    if (data?.apiVersion?.startsWith('scheduling.run.ai/')) return getKaiPodGroupStatus(data)
+    if (data?.apiVersion?.startsWith('scheduling.volcano.sh/')) return getVolcanoPodGroupStatus(data)
+  }
+  if (k === 'workspaces' && data?.apiVersion?.startsWith('kaito.sh/')) return getKaitoWorkspaceStatus(data)
+  if (k === 'workloads' && data?.apiVersion?.startsWith('kueue.x-k8s.io/')) return getKueueWorkloadStatus(data)
+  if (k === 'clusterqueues' && data?.apiVersion?.startsWith('kueue.x-k8s.io/')) return getClusterQueueStatus(data)
+  if (k === 'localqueues' && data?.apiVersion?.startsWith('kueue.x-k8s.io/')) return getLocalQueueStatus(data)
+  if (k === 'resourceflavors' && data?.apiVersion?.startsWith('kueue.x-k8s.io/')) return getResourceFlavorStatus(data)
+  if (k === 'admissionchecks' && data?.apiVersion?.startsWith('kueue.x-k8s.io/')) return getAdmissionCheckStatus(data)
+  if (k === 'provisioningrequests' && data?.apiVersion?.startsWith('autoscaling.x-k8s.io/')) return getProvisioningRequestStatus(data)
+  if (k === 'rayclusters' && data?.apiVersion?.startsWith('ray.io/')) return getRayClusterStatus(data)
+  if (k === 'rayjobs' && data?.apiVersion?.startsWith('ray.io/')) return getRayJobStatus(data)
+  if (k === 'rayservices' && data?.apiVersion?.startsWith('ray.io/')) return getRayServiceStatus(data)
+  if (k === 'raycronjobs' && data?.apiVersion?.startsWith('ray.io/')) return getRayCronJobStatus(data)
+  if (k === 'leaderworkersets' && data?.apiVersion?.startsWith('leaderworkerset.x-k8s.io/')) return getLeaderWorkerSetStatus(data)
+  if (k === 'jobsets' && data?.apiVersion?.startsWith('jobset.x-k8s.io/')) return getJobSetStatus(data)
+  if (k === 'inferenceservices' && data?.apiVersion?.startsWith('serving.kserve.io/')) return getInferenceServiceStatus(data)
+  if ((k === 'servingruntimes' || k === 'clusterservingruntimes') && data?.apiVersion?.startsWith('serving.kserve.io/')) return getServingRuntimeStatus(data)
+  if (k === 'inferencegraphs' && data?.apiVersion?.startsWith('serving.kserve.io/')) return getInferenceGraphStatus(data)
+  if (k === 'trainedmodels' && data?.apiVersion?.startsWith('serving.kserve.io/')) return getTrainedModelStatus(data)
+  if (k === 'llminferenceservices' && data?.apiVersion?.startsWith('serving.kserve.io/')) return getLLMInferenceServiceStatus(data)
+  if (k === 'inferencepools' && (
+    data?.apiVersion?.startsWith('inference.networking.k8s.io/')
+    || data?.apiVersion?.startsWith('inference.networking.x-k8s.io/')
+  )) return getInferencePoolStatus(data)
+  if (k === 'inferenceobjectives' && (
+    data?.apiVersion?.startsWith('inference.networking.x-k8s.io/')
+    || data?.apiVersion?.startsWith('llm-d.ai/')
+  )) return getInferenceObjectiveStatus(data)
+  if (k === 'jobflows' && data?.apiVersion?.startsWith('flow.volcano.sh/')) return getJobFlowStatus(data)
+  if (k === 'jobtemplates' && data?.apiVersion?.startsWith('flow.volcano.sh/')) return getJobTemplateStatus(data)
+  if (k === 'ragengines' && data?.apiVersion?.startsWith('kaito.sh/')) return getRAGEngineStatus(data)
+  if (k === 'nimservices' && data?.apiVersion?.startsWith('apps.nvidia.com/')) return getNIMServiceStatus(data)
+  if (k === 'nimcaches' && data?.apiVersion?.startsWith('apps.nvidia.com/')) return getNIMCacheStatus(data)
+  if (k === 'nimpipelines' && data?.apiVersion?.startsWith('apps.nvidia.com/')) return getNIMPipelineStatus(data)
+  if (k === 'deviceconfigs' && data?.apiVersion?.startsWith('amd.com/')) return getAMDDeviceConfigStatus(data)
+  if (k === 'pytorchjobs' && data?.apiVersion?.startsWith('kubeflow.org/')) return getPyTorchJobStatus(data)
+  if (k === 'tfjobs' && data?.apiVersion?.startsWith('kubeflow.org/')) return getTFJobStatus(data)
+  if (k === 'mpijobs' && data?.apiVersion?.startsWith('kubeflow.org/')) return getMPIJobStatus(data)
+  if (k === 'trainjobs' && data?.apiVersion?.startsWith('trainer.kubeflow.org/')) return getTrainJobStatus(data)
   if (k === 'cronjobs') return getCronJobStatus(data)
   if (k === 'hpas' || k === 'horizontalpodautoscalers') return getHPAStatus(data)
   if (k === 'nodes') return getNodeStatus(data)
   if (k === 'persistentvolumeclaims') return getPVCStatus(data)
-  if (k === 'rollouts') return getRolloutStatus(data)
   if (k === 'analysisruns') return getAnalysisRunStatus(data)
   if (k === 'workflows') return getWorkflowStatus(data)
   if (k === 'cronworkflows') return getCronWorkflowStatus(data)
@@ -1193,36 +1265,8 @@ export function getResourceStatus(kind: string, data: any): { text: string; colo
     return { text: status.text, color: status.color }
   }
 
-  // Generic status extraction
-  const status = data.status
-  if (status) {
-    if (status.phase) {
-      const phase = String(status.phase)
-      const healthyPhases = ['Running', 'Active', 'Succeeded', 'Ready', 'Healthy', 'Available', 'Bound']
-      const warningPhases = ['Pending', 'Progressing', 'Unknown', 'Terminating']
-      const isHealthy = healthyPhases.includes(phase)
-      const isWarning = warningPhases.includes(phase)
-      return {
-        text: phase,
-        color: isHealthy ? SEVERITY_BADGE.success :
-               isWarning ? SEVERITY_BADGE.warning :
-               SEVERITY_BADGE.error
-      }
-    }
-
-    if (status.conditions && Array.isArray(status.conditions)) {
-      const readyCondition = status.conditions.find((c: any) =>
-        c.type === 'Ready' || c.type === 'Available' || c.type === 'Progressing'
-      )
-      if (readyCondition) {
-        const isReady = readyCondition.status === 'True'
-        return {
-          text: isReady ? 'Ready' : 'Not Ready',
-          color: isReady ? SEVERITY_BADGE.success : SEVERITY_BADGE.warning
-        }
-      }
-    }
-  }
+  const derived = getGenericResourceStatus(data)
+  if (derived) return { text: derived.text, color: HEALTH_BADGE_COLORS[derived.tone] }
 
   return null
 }

package/src/components/shared/SetImageDialog.test.ts

@@ -0,0 +1,129 @@
+import { describe, expect, it } from 'vitest'
+
+import type { WorkloadContainerImage } from '../../types/core'
+import {
+  canSubmitImageUpdates,
+  changedImageUpdates,
+  describeImageUpdateBehavior,
+  reconcileRefreshedImageDrafts,
+} from './SetImageDialog'
+
+const containers: WorkloadContainerImage[] = [
+  { type: 'container', name: 'app', image: 'repo/app:v1' },
+  { type: 'container', name: 'sidecar', image: 'repo/sidecar:v1' },
+  { type: 'initContainer', name: 'migrate', image: 'repo/migrate:v1' },
+]
+
+describe('changedImageUpdates', () => {
+  it('submits only changed rows with their reviewed previous images', () => {
+    expect(
+      changedImageUpdates(containers, {
+        ['container\u0000app']: 'repo/app:v2',
+        ['container\u0000sidecar']: 'repo/sidecar:v1',
+        ['initContainer\u0000migrate']: ' repo/migrate:v2 ',
+      }),
+    ).toEqual([
+      {
+        type: 'container',
+        name: 'app',
+        previousImage: 'repo/app:v1',
+        image: 'repo/app:v2',
+      },
+      {
+        type: 'initContainer',
+        name: 'migrate',
+        previousImage: 'repo/migrate:v1',
+        image: 'repo/migrate:v2',
+      },
+    ])
+  })
+
+  it('does not turn an empty draft into a mutation', () => {
+    expect(
+      changedImageUpdates(containers.slice(0, 1), {
+        ['container\u0000app']: '   ',
+      }),
+    ).toEqual([])
+  })
+})
+
+describe('describeImageUpdateBehavior', () => {
+  it('does not promise an immediate rollout for paused, OnDelete, or partitioned controllers', () => {
+    expect(describeImageUpdateBehavior({ type: 'paused' })).toContain(
+      'no rollout starts',
+    )
+    expect(describeImageUpdateBehavior({ type: 'onDelete' })).toContain(
+      'until they are deleted',
+    )
+    expect(
+      describeImageUpdateBehavior({ type: 'partitioned', partition: 3 }),
+    ).toContain('ordinal 3 or higher')
+  })
+
+  it('describes Argo promotion behavior from the Rollout strategy', () => {
+    expect(
+      describeImageUpdateBehavior({ type: 'canary', gated: true }),
+    ).toContain('configured steps')
+    expect(
+      describeImageUpdateBehavior({ type: 'canary', gated: false }),
+    ).toContain('100% without a pause')
+    expect(
+      describeImageUpdateBehavior({ type: 'blueGreen', autoPromote: true }),
+    ).toContain('automatically')
+    expect(
+      describeImageUpdateBehavior({ type: 'blueGreen', autoPromote: false }),
+    ).toContain('Promotion remains a separate action')
+  })
+})
+
+describe('reconcileRefreshedImageDrafts', () => {
+  it('preserves proposed images while adopting untouched concurrent changes', () => {
+    expect(
+      reconcileRefreshedImageDrafts(
+        containers,
+        [
+          { type: 'container', name: 'app', image: 'repo/app:other' },
+          { type: 'container', name: 'sidecar', image: 'repo/sidecar:other' },
+          { type: 'initContainer', name: 'migrate', image: 'repo/migrate:v1' },
+        ],
+        {
+          ['container\u0000app']: 'repo/app:proposed',
+          ['container\u0000sidecar']: 'repo/sidecar:v1',
+          ['initContainer\u0000migrate']: 'repo/migrate:v1',
+        },
+      ),
+    ).toEqual({
+      drafts: {
+        ['container\u0000app']: 'repo/app:proposed',
+        ['container\u0000sidecar']: 'repo/sidecar:other',
+        ['initContainer\u0000migrate']: 'repo/migrate:v1',
+      },
+      changedCurrentKeys: ['container\u0000app', 'container\u0000sidecar'],
+    })
+  })
+})
+
+describe('canSubmitImageUpdates', () => {
+  const ready = {
+    updateCount: 1,
+    hasEmptyImage: false,
+    managed: false,
+    ownershipResolved: true,
+    acknowledged: false,
+    busy: false,
+  }
+
+  it('requires break-glass acknowledgement for managed resources', () => {
+    expect(canSubmitImageUpdates({ ...ready, managed: true })).toBe(false)
+    expect(
+      canSubmitImageUpdates({ ...ready, managed: true, acknowledged: true }),
+    ).toBe(true)
+  })
+
+  it('blocks empty images and concurrent submissions', () => {
+    expect(canSubmitImageUpdates({ ...ready, hasEmptyImage: true })).toBe(false)
+    expect(canSubmitImageUpdates({ ...ready, busy: true })).toBe(false)
+    expect(canSubmitImageUpdates({ ...ready, loadFailed: true })).toBe(false)
+    expect(canSubmitImageUpdates({ ...ready, ownershipResolved: false })).toBe(false)
+  })
+})