@skydiveai/pi-extensions 0.1.252-beta.1 → 0.1.252-beta.11

package/dist/index.d.mts

@@ -1,9 +1,27 @@
+/// <reference types="node" />
 import { A2AOptions, Middleware, ProtocolsOptions } from "@skydiveai/pi-server";
 import { ExtensionFactory } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
 import { Client } from "@modelcontextprotocol/sdk/client/index.js";
+import * as _$qs from "qs";
+import * as _$express from "express";
 import { Logger } from "pino";
 
+//#region ../../node_modules/@types/express-serve-static-core/index.d.ts
+declare global {
+  namespace Express {
+    // These open interfaces may be extended in an application-specific manner via declaration merging.
+    // See for example method-override.d.ts (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/method-override/index.d.ts)
+    interface Request {}
+    interface Response {}
+    interface Locals {}
+    interface Application {}
+  }
+}
+interface ParamsDictionary {
+  [key: string]: string;
+}
+//#endregion
 //#region src/harness.d.ts
 type CreateHarnessOptions = ProtocolsOptions & {
   cwd: string;
@@ -26,7 +44,7 @@ declare function createHarness(options: CreateHarnessOptions): {
   };
   protocols: {
     handlers: {
-      /** Express-style; mount at /a2a. */a2a: RequestHandler; /** GET /.well-known/agent-card.json. */
+      /** Express-style; mount at /a2a. */a2a: _$express.RequestHandler<ParamsDictionary, any, any, _$qs.ParsedQs, Record<string, any>>; /** GET /.well-known/agent-card.json. */
       agentCard: Middleware; /** Mirrors each vendor's API shape. */
       openai: {
         v1: {

package/dist/index.mjs

@@ -161,7 +161,7 @@ async function readPackageVersion(pkg) {
 	let dir;
 	try {
 		dir = dirname(require.resolve(pkg));
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 	let current = dir;
@@ -169,7 +169,7 @@ async function readPackageVersion(pkg) {
 		try {
 			const manifest = JSON.parse(await readFile(resolve(current, "package.json"), "utf8"));
 			if (manifest.name === pkg && typeof manifest.version === "string") return manifest.version;
-		} catch {}
+		} catch (_error) {}
 		const parent = dirname(current);
 		if (parent === current) return null;
 		current = parent;
@@ -210,7 +210,7 @@ function createPlatformEnvMiddleware() {
 	return async (req, _res, next) => {
 		try {
 			await loadPlatformConfig(new Request(requestUrl(req), { headers: requestHeaders(req) }));
-		} catch {}
+		} catch (_error) {}
 		next();
 	};
 }
@@ -662,7 +662,7 @@ async function listToolFiles(dir) {
 				file,
 				mtimeMs: s.mtimeMs
 			});
-		} catch {}
+		} catch (_error) {}
 	}
 	return out;
 }
@@ -946,7 +946,7 @@ function probeAlive(pid) {
 	try {
 		process.kill(pid, 0);
 		return true;
-	} catch {
+	} catch (_error) {
 		return false;
 	}
 }
@@ -1041,7 +1041,7 @@ async function connectClient(id, config, opts = {}) {
 	}
 	try {
 		await client.close();
-	} catch {}
+	} catch (_error) {}
 	return {
 		status: "failed",
 		error: formatError(result),
@@ -1163,7 +1163,7 @@ function estimateToolTokens(tool) {
 	let chars = tool.name.length + (tool.description?.length ?? 0);
 	if (tool.inputSchema !== void 0 && tool.inputSchema !== null) try {
 		chars += JSON.stringify(tool.inputSchema).length;
-	} catch {
+	} catch (_error) {
 		chars += 256;
 	}
 	return Math.ceil(chars / 4);
@@ -2163,7 +2163,7 @@ function extractMessageId(channelContextJson) {
 	try {
 		const parsed = channelContextRefSchema.safeParse(JSON.parse(channelContextJson));
 		return parsed.success ? parsed.data.messageId : null;
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 }
@@ -2410,7 +2410,7 @@ async function postSubagentSpawn({ messageId, tasks }) {
 		try {
 			const errBody = await res.json();
 			if (errBody && typeof errBody.error === "string") detail = `: ${errBody.error}`;
-		} catch {}
+		} catch (_error) {}
 		throw new Error(`subagent-spawn POST failed (${res.status})${detail}`);
 	}
 	const body = await res.json();
@@ -2434,7 +2434,7 @@ async function postSubagentRearm({ messageId, taskId, timeoutMinutes }) {
 		try {
 			const body = await res.json();
 			if (typeof body.error === "string") detail = `: ${body.error}`;
-		} catch {}
+		} catch (_error) {}
 		throw new Error(`subagent re-arm POST failed (${res.status})${detail}`);
 	}
 	const body = await res.json();
@@ -3028,6 +3028,13 @@ const bashDefaultTimeoutExtension = (pi) => {
 * idle sandbox's resource usage is not the agent's problem and there is no
 * open turn to deliver into anyway.
 *
+* Delivery is further gated to turns that are ACTIVELY in tool-call work
+* (see WarningDeliveryGate): a warning that lands once the model has moved
+* on to its final reply triggers a continuation turn after the answer was
+* already produced, which breaks external-channel delivery (Slack steer-
+* after-reply). So the warning only interrupts between/around tool calls
+* and never chases a turn that is already wrapping up.
+*
 * Best-effort throughout: any read failure (cgroup absent, controller not
 * delegated, non-cgroup-v2 host, df missing) reads as "no signal" for that
 * stat and the extension warns on what it can see — it must never break a
@@ -3151,20 +3158,77 @@ function resourcePressureWarningText(trigger, { mem, cpuPct, diskPct }) {
 	const closer = trigger === "memory" ? "If the workload genuinely needs more memory or CPU, request a bigger sandbox with `platform compute request`." : "A bigger compute tier will not add disk. Free space on the current computer instead, and do not request a compute upgrade for disk pressure.";
 	return `<system_notification>${lead} Current usage: ${stats.join(", ")}. Act now: ${remedy} ${closer} Do not mention this constraint as you work unless the user asks. This warning does not change whether the user is owed a reply. Do not call \`platform channel suppress-reply\` because of this warning. Complete any reply already owed after checkpointing. This is an automated resource warning, not a message from the user; continue the task, adjusted.</system_notification>`;
 }
+/**
+* Whether a pressure warning may be delivered into the open turn right now.
+*
+* Only interrupts turns that are actively in tool-call work. The failure it
+* guards against: the poll lands after the model has stopped calling tools
+* and is streaming (or has finished) its final reply. `sendMessage` with
+* `triggerTurn: true` then starts a continuation turn BEHIND an answer the
+* user is already owed, which wedges external-channel delivery (Slack).
+*
+* Deliverable means ALL of:
+* - agent active (between agent_start and agent_end),
+* - the turn has issued at least one tool call,
+* - no assistant message is currently streaming (while one streams we cannot
+*   know whether it will end the loop, so we hold and re-poll),
+* - the loop is not closed: no assistant message without tool calls has
+*   completed this turn (that message IS the final reply; anything after it
+*   is post-answer and must not be steered).
+*
+* Pure and exported so the gating is regression-testable without fake timers.
+*/
+var WarningDeliveryGate = class {
+	agentActive = false;
+	sawToolCall = false;
+	toolsInFlight = 0;
+	messageStreaming = false;
+	loopClosed = false;
+	agentStart() {
+		this.agentActive = true;
+		this.sawToolCall = false;
+		this.toolsInFlight = 0;
+		this.messageStreaming = false;
+		this.loopClosed = false;
+	}
+	agentEnd() {
+		this.agentActive = false;
+		this.messageStreaming = false;
+	}
+	toolExecutionStart() {
+		this.sawToolCall = true;
+		this.toolsInFlight += 1;
+	}
+	toolExecutionEnd() {
+		this.toolsInFlight = Math.max(0, this.toolsInFlight - 1);
+	}
+	messageStart(message) {
+		if (message.role !== "assistant") return;
+		this.messageStreaming = true;
+	}
+	messageEnd(message) {
+		if (message.role !== "assistant") return;
+		this.messageStreaming = false;
+		if (!(Array.isArray(message.content) && message.content.some((part) => part.type === "toolCall"))) this.loopClosed = true;
+	}
+	canDeliver() {
+		return this.agentActive && this.sawToolCall && !this.loopClosed && !this.messageStreaming;
+	}
+};
 const resourcePressureWarningExtension = (pi) => {
-	let agentActive = false;
+	const gate = new WarningDeliveryGate();
 	let warnedMemThisTurn = false;
 	let warnedDiskThisTurn = false;
 	let timer = null;
 	const sampleCpu = createCpuSampler();
 	async function checkOnce() {
-		if (!agentActive || warnedMemThisTurn && warnedDiskThisTurn) return;
+		if (!gate.canDeliver() || warnedMemThisTurn && warnedDiskThisTurn) return;
 		const [mem, cpuPct, diskPct] = await Promise.all([
 			readMemUsePct(),
 			sampleCpu(),
 			readDiskUsePct()
 		]);
-		if (!agentActive) return;
+		if (!gate.canDeliver()) return;
 		let trigger = null;
 		if (!warnedMemThisTurn && mem !== null && mem.pct >= 80) {
 			trigger = "memory";
@@ -3193,8 +3257,20 @@ const resourcePressureWarningExtension = (pi) => {
 			deliverAs: "followUp"
 		});
 	}
+	pi.on("tool_execution_start", () => {
+		gate.toolExecutionStart();
+	});
+	pi.on("tool_execution_end", () => {
+		gate.toolExecutionEnd();
+	});
+	pi.on("message_start", (event) => {
+		gate.messageStart(event.message);
+	});
+	pi.on("message_end", (event) => {
+		gate.messageEnd(event.message);
+	});
 	pi.on("agent_start", async () => {
-		agentActive = true;
+		gate.agentStart();
 		warnedMemThisTurn = false;
 		warnedDiskThisTurn = false;
 		if (!timer) {
@@ -3207,7 +3283,7 @@ const resourcePressureWarningExtension = (pi) => {
 		}
 	});
 	pi.on("agent_end", async () => {
-		agentActive = false;
+		gate.agentEnd();
 		if (timer) {
 			clearInterval(timer);
 			timer = null;
@@ -3708,7 +3784,7 @@ async function readMemoryIndexFile({ cwd }) {
 	try {
 		const trimmed = (await readFile(path, "utf-8")).trim();
 		return trimmed.length > 0 ? trimmed : null;
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 }
@@ -3748,7 +3824,7 @@ async function maxMtimeAcrossDir(dir) {
 	let dirStat;
 	try {
 		dirStat = await stat(dir);
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 	if (!dirStat.isDirectory()) return null;
@@ -3763,7 +3839,7 @@ async function walkMdFiles(dir, out) {
 	let entries;
 	try {
 		entries = await readdir(dir, { withFileTypes: true });
-	} catch {
+	} catch (_error) {
 		return;
 	}
 	await Promise.all(entries.map(async (entry) => {
@@ -3776,7 +3852,7 @@ async function listMdFilesShallow(dir) {
 	let entries;
 	try {
 		entries = await readdir(dir, { withFileTypes: true });
-	} catch {
+	} catch (_error) {
 		return [];
 	}
 	return entries.filter((e) => e.isFile() && e.name.endsWith(".md")).map((e) => join(dir, e.name));
@@ -3785,7 +3861,7 @@ async function listSubdirs(dir) {
 	let entries;
 	try {
 		entries = await readdir(dir, { withFileTypes: true });
-	} catch {
+	} catch (_error) {
 		return [];
 	}
 	return entries.filter((e) => e.isDirectory()).map((e) => join(dir, e.name));
@@ -3811,14 +3887,14 @@ async function readFrontmatterOnly(filePath) {
 	let fh;
 	try {
 		fh = await open(filePath, "r");
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 	try {
 		const buf = Buffer.alloc(FRONTMATTER_READ_BYTES);
 		const { bytesRead } = await fh.read(buf, 0, FRONTMATTER_READ_BYTES, 0);
 		return parseFrontmatter(buf.toString("utf-8", 0, bytesRead));
-	} catch {
+	} catch (_error) {
 		return null;
 	} finally {
 		await fh.close().catch(() => {});
@@ -3830,7 +3906,7 @@ function parseFrontmatter(text) {
 	let parsed;
 	try {
 		parsed = parse(match[1]);
-	} catch {
+	} catch (_error) {
 		return null;
 	}
 	const result = FrontmatterSchema.safeParse(parsed);
@@ -4826,7 +4902,7 @@ async function readLogChunk(id, maxBytes, anchor) {
 			text: buffer.toString("utf8", start),
 			size
 		};
-	} catch {
+	} catch (_error) {
 		return {
 			text: "",
 			size: 0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skydiveai/pi-extensions",
-  "version": "0.1.252-beta.1",
+  "version": "0.1.252-beta.11",
   "homepage": "https://skydive.com",
   "license": "MIT",
   "author": "Create, Inc.",