@skitterbyte/skitterspec-linear 10.8.0 → 12.0.0

package/src/gating.js

@@ -0,0 +1,155 @@
+'use strict'
+
+/**
+ * Release gating — the loader, the header reader, and the check.
+ *
+ * The feature records ONE decision per spec: does this ship behind a feature
+ * flag, or land live? Skitterspec never learns how a project does flags; it asks
+ * the question, cites the project's own documentation, and reads back what was
+ * written. Strictly opt-in: with `specs/.core/gating.config.json` absent, every
+ * function here reports "not configured" and nothing else changes.
+ *
+ * Mirrors `src/env/config.js` (frozen defaults, merge known keys only, never
+ * throws on absence) so the two opt-in configs behave alike.
+ */
+
+const fs = require('node:fs')
+const path = require('node:path')
+
+const CONFIG_FILE = path.join('specs', '.core', 'gating.config.json')
+
+// Only these two buckets are ever read.
+//
+// A SPEC WRITTEN BEFORE GATING WAS ADOPTED HAS NO HEADER AND IS NOT BROKEN. That
+// is the blind spot this check would otherwise walk into: "no Gating: line" is
+// evidence of an unanswered question only for a spec that could have been asked,
+// and every finished or abandoned spec predates the question by definition. They
+// are excluded STRUCTURALLY rather than by a filter someone must remember — a
+// completed spec is not in range, so no future edit can make it fire. Pre-existing
+// specs still in flight ARE reported, deliberately: they are live work, the
+// question genuinely still applies, and the report never blocks anything.
+const ACTIVE_BUCKETS = ['backlog', 'in-progress']
+
+const DEFAULT_CONFIG = Object.freeze({
+  guidance: '',
+  default: 'none: <reason>',
+})
+
+/**
+ * Load `specs/.core/gating.config.json`. Returns `{ config, present }`;
+ * `present:false` means the project has not adopted gating, which is read as
+ * "this project does not use feature flags" — never as an error.
+ */
+function loadGatingConfig(dir = process.cwd()) {
+  const base = { ...DEFAULT_CONFIG }
+  let raw
+  try {
+    raw = fs.readFileSync(path.join(dir, CONFIG_FILE), 'utf-8')
+  } catch (error) {
+    if (error.code === 'ENOENT') return { config: base, present: false }
+    throw error
+  }
+  let parsed
+  try {
+    parsed = JSON.parse(raw)
+  } catch (error) {
+    throw new Error(`Invalid ${CONFIG_FILE}: ${error.message}`)
+  }
+  if (parsed && typeof parsed === 'object') {
+    if (typeof parsed.guidance === 'string') base.guidance = parsed.guidance.trim()
+    if (typeof parsed.default === 'string' && parsed.default.trim()) {
+      base.default = parsed.default.trim()
+    }
+  }
+  return { config: base, present: true }
+}
+
+/**
+ * Read a spec's `> **Gating:** …` blockquote field from `00-overview.md`.
+ *
+ * Returns `{ raw, kind }` with four kinds, because there are four states and
+ * collapsing them is what made the omission invisible in the first place:
+ *
+ *   flag     a flag name — ships behind it
+ *   none     `none: <reason>` — deliberately not flagged, and why
+ *   invalid  present but says nothing: empty, or a bare `none` with no reason
+ *   missing  no field at all
+ *
+ * `invalid` and `missing` are kept apart on purpose. A bare `none` is someone
+ * answering without deciding; a missing line is nobody having been asked. They
+ * want different words.
+ */
+function readGatingField(specPath) {
+  const overview = path.join(specPath, '00-overview.md')
+  let raw
+  try {
+    raw = fs.readFileSync(overview, 'utf-8')
+  } catch {
+    return { raw: null, kind: 'missing' }
+  }
+  const m = /^>\s*\*\*Gating:\*\*\s*(.*)$/m.exec(raw)
+  if (!m) return { raw: null, kind: 'missing' }
+  const value = m[1].trim().replace(/^["'`]|["'`]$/g, '')
+  if (!value) return { raw: value, kind: 'invalid' }
+  const bare = /^none\b/i.test(value)
+  if (bare) {
+    // `none` alone, or `none:` with nothing after it, is a shrug rather than a
+    // decision — the reason half is the whole point of recording it.
+    const reason = value.replace(/^none\b:?/i, '').trim()
+    return { raw: value, kind: reason ? 'none' : 'invalid' }
+  }
+  return { raw: value, kind: 'flag' }
+}
+
+// Active specs on disk, as `{ folder, bucket, path }`. A bucket that does not
+// exist is simply empty — git does not store empty directories, so a missing
+// `specs/backlog/` is the ordinary state of a project with nothing queued.
+function activeSpecs(dir) {
+  const out = []
+  for (const bucket of ACTIVE_BUCKETS) {
+    const root = path.join(dir, 'specs', bucket)
+    let entries
+    try {
+      entries = fs.readdirSync(root, { withFileTypes: true })
+    } catch {
+      continue
+    }
+    for (const e of entries) {
+      if (e.isDirectory()) out.push({ folder: e.name, bucket, path: path.join(root, e.name) })
+    }
+  }
+  return out
+}
+
+/**
+ * Check specs for a recorded gating decision.
+ *
+ * Advisory by construction: it returns findings and says nothing about what the
+ * caller should do. Nothing here exits, throws on a finding, or blocks.
+ *
+ * @returns {{configured: boolean, findings: Array<{folder, bucket, kind, raw}>,
+ *            checked: number, guidance: string}}
+ */
+function checkGating(dir, specs) {
+  const { config, present } = loadGatingConfig(dir)
+  if (!present) return { configured: false, findings: [], checked: 0, guidance: '' }
+  const targets = specs && specs.length ? specs : activeSpecs(dir)
+  const findings = []
+  for (const spec of targets) {
+    const { kind, raw } = readGatingField(spec.path)
+    if (kind === 'missing' || kind === 'invalid') {
+      findings.push({ folder: spec.folder, bucket: spec.bucket, kind, raw })
+    }
+  }
+  return { configured: true, findings, checked: targets.length, guidance: config.guidance }
+}
+
+module.exports = {
+  CONFIG_FILE,
+  DEFAULT_CONFIG,
+  ACTIVE_BUCKETS,
+  loadGatingConfig,
+  readGatingField,
+  activeSpecs,
+  checkGating,
+}

package/src/init.js

@@ -423,19 +423,43 @@ function installCore(dir, opts) {
 }
 
 // Activate opt-in per-spec isolation: write specs/.core/env.config.json from the
-// example asset so /spec-go provisions a worktree for every in-progress spec.
+// example asset so /spec-start provisions a worktree for every in-progress spec.
 // Only called when the operator opts in, and never on `update` (adopting isolation
 // is a deliberate choice, not something a re-sync flips on). Idempotent: writeFile
 // never clobbers an existing env.config.json without --force.
-function installIsolation(dir, { enabled }, opts) {
+function installIsolation(dir, { enabled, workspaceMode }, opts) {
+  if (!enabled) return
+  const target = path.join(dir, 'specs', '.core', 'env.config.json')
+  copyAsset(dir, path.join('core', 'env.config.json.example'), target, opts)
+
+  // Only 'checkout' is written; 'worktree' is already what the template says and
+  // what the loader defaults to, so the common path leaves the file untouched.
+  // Guarded by existsSync because copyAsset legitimately declines to overwrite a
+  // config the operator already customized — rewriting it here would undo that.
+  if (workspaceMode === 'checkout' && fs.existsSync(target)) {
+    const parsed = JSON.parse(fs.readFileSync(target, 'utf8'))
+    parsed.mode = 'checkout'
+    fs.writeFileSync(target, `${JSON.stringify(parsed, null, 2)}\n`)
+  }
+  trustWorktreeRoot(dir)
+}
+
+// Activate opt-in release gating: write specs/.core/gating.config.json from the
+// example asset, so /spec and friends start asking whether a change ships behind
+// a feature flag and recording the answer.
+//
+// Only called when the operator opts in, and NEVER on `update` — for the same
+// reason as isolation: adopting a policy is a deliberate choice, not something a
+// re-sync flips on. Idempotent; copyAsset never clobbers an existing config
+// without --force, so an operator's edited `guidance` survives a re-init.
+function installGating(dir, { enabled }, opts) {
   if (!enabled) return
   copyAsset(
     dir,
-    path.join('core', 'env.config.json.example'),
-    path.join(dir, 'specs', '.core', 'env.config.json'),
+    path.join('core', 'gating.config.json.example'),
+    path.join(dir, 'specs', '.core', 'gating.config.json'),
     opts,
   )
-  trustWorktreeRoot(dir)
 }
 
 // Seed the absolute worktree root into .claude/settings.local.json (gitignored)
@@ -673,9 +697,16 @@ function printReport(dir, mode, { diff = false } = {}) {
   const isolationOn = fs.existsSync(path.join(dir, 'specs', '.core', 'env.config.json'))
   const isolationNote = isolationOn
     ? 'Per-spec isolation is ON: every in-progress spec gets its own git worktree' +
-      ' at /spec-go (Docker is a per-spec escalation — set > **Stack:** in the spec).\n'
+      ' at /spec-start (Docker is a per-spec escalation — set > **Stack:** in the spec).\n'
     : 'Per-spec isolation is opt-in: re-run with --isolation (or copy' +
       ' specs/.core/env.config.json.example → env.config.json) to enable it.\n'
+  const gatingOn = fs.existsSync(path.join(dir, 'specs', '.core', 'gating.config.json'))
+  const gatingNote = gatingOn
+    ? 'Release gating is ON: /spec asks whether a change ships behind a feature' +
+      ' flag and records the answer on the spec (skitterspec gating check reports' +
+      ' any that have none).\n'
+    : 'Release gating is opt-in: re-run with --gating (or copy' +
+      ' specs/.core/gating.config.json.example → gating.config.json) to enable it.\n'
   // A provider superset ships its own `spec-<provider>-setup` skill; the base
   // ships none. Discovering it from what was actually installed keeps this file
   // tracker-free — it never has to know which tracker (if any) is in the box.
@@ -696,16 +727,20 @@ function printReport(dir, mode, { diff = false } = {}) {
         ' (it discovers your workspace and writes the config), or see' +
         ' specs/.core/SETUP.md.\n'
   process.stdout.write(
-    '\nDone. Skills resolve as /spec, /spec-go, /spec-complete, /spec-cancel,' +
+    '\nDone. Skills resolve as /spec, /spec-start, /spec-next, /spec-complete,' +
       ' /spec-bug, /spec-review, /spec-init, /spec-connect.\n' +
       'Next: tailor .claude/rules/spec-planning.md + the CLAUDE.md section to this' +
       " project's stack, then run /spec.\n" +
       isolationNote +
+      gatingNote +
       trackerNote,
   )
 }
 
-async function init({ dir, force, claudeMd, mode, isolation }) {
+// `mode` here is the INSTALL mode ('init' | 'update'), long-standing and
+// unrelated to the config's own `mode` key — which arrives as `workspaceMode`
+// precisely so the two cannot be confused at a call site.
+async function init({ dir, force, claudeMd, mode, isolation, workspaceMode, gating }) {
   if (!fs.existsSync(dir)) throw new Error(`target dir does not exist: ${dir}`)
   resetReport()
 
@@ -716,7 +751,8 @@ async function init({ dir, force, claudeMd, mode, isolation }) {
   removeRetiredFiles(dir)
   installCore(dir, { force })
   // Adopting isolation writes the live env.config.json — init only, never update.
-  if (mode !== 'update') installIsolation(dir, { enabled: isolation }, { force })
+  if (mode !== 'update') installIsolation(dir, { enabled: isolation, workspaceMode }, { force })
+  if (mode !== 'update') installGating(dir, { enabled: gating }, { force })
   if (claudeMd) installClaudeMd(dir, { mode })
 
   // Record what we wrote (and migrate a pre-manifest repo) so a later resync can

package/src/prompts.js

@@ -7,10 +7,11 @@
  * test suite never imports the interactive UI.
  *
  * `isolationSeed` pre-fills the per-spec isolation question. Returns
- * `{ isolation }`.
+ * `{ isolation, mode }` — `mode` is only asked when isolation is enabled, and
+ * is `'worktree'` otherwise (the value the config defaults to anyway).
  */
 
-async function promptSetup({ isolationSeed = false } = {}) {
+async function promptSetup({ isolationSeed = false, gatingSeed = false } = {}) {
   const prompts = require('prompts')
 
   let cancelled = false
@@ -23,15 +24,51 @@ async function promptSetup({ isolationSeed = false } = {}) {
     {
       type: 'confirm',
       name: 'isolation',
-      message: 'Enable per-spec isolation — a git worktree per spec?',
+      message: 'Enable per-spec isolation — build each spec on its own branch?',
       initial: isolationSeed,
     },
+    {
+      // Only reachable when isolation was accepted: `prev` is the previous
+      // answer, and returning null skips the question entirely.
+      type: (prev) => (prev ? 'select' : null),
+      name: 'mode',
+      message: 'Where should a spec be built?',
+      hint: '- this is the trade, not a preference',
+      initial: 0,
+      choices: [
+        {
+          title: 'Its own worktree (default)',
+          value: 'worktree',
+          description: 'several specs at once, main left free — one terminal session per spec',
+        },
+        {
+          title: 'The checkout you are in',
+          value: 'checkout',
+          description: 'one spec at a time, no second session — your terminal follows the work',
+        },
+      ],
+    },
+    {
+      // Orthogonal to isolation, so it is asked unconditionally rather than
+      // nested under it — a project can adopt either, both, or neither.
+      type: 'confirm',
+      name: 'gating',
+      message: 'Record a release-gating decision on each spec — flag, or land live?',
+      initial: gatingSeed,
+    },
   ]
 
   const ans = await prompts(questions, { onCancel })
   if (cancelled) throw new Error('Setup cancelled')
 
-  return { isolation: Boolean(ans.isolation) }
+  // Anything other than an explicit 'checkout' resolves to the default, so a
+  // skipped or cancelled-into-default answer can never select the mode that
+  // puts a spec's work in the primary checkout.
+  return {
+    isolation: Boolean(ans.isolation),
+    mode: ans.mode === 'checkout' ? 'checkout' : 'worktree',
+    gating: Boolean(ans.gating),
+  }
 }
 
 /**

package/src/vendor/linear/cli-sync.js

@@ -242,6 +242,7 @@ function specSyncPush(dir, config, specArg, flags, out, err) {
     if (p.subIssues.update.length) lines.push(`  sub-issues update: ${p.subIssues.update.map((s) => s.id).join(', ')}`)
     lines.push('  (run with --json for the full plan the skill applies)')
   }
+  lines.push(...unstampedLines(p))
   out.write(lines.join('\n') + '\n')
   return 0
 }
@@ -249,10 +250,28 @@ function specSyncPush(dir, config, specArg, flags, out, err) {
 // `mapping.phases: 'deferred'` is holding phases back. Said plainly wherever a
 // plan or a status report is printed, because the alternative reading of a spec
 // with no sub-issues is that its phase files failed to parse.
+// Phases whose stamp is missing while the snapshot still remembers an id nobody
+// claims. Reported OUTSIDE the empty-plan branch on purpose: a plan carrying
+// nothing but these is "empty" for applying, and saying `up to date` about it
+// would hide the one thing the operator has to act on.
+function unstampedLines(plan) {
+  const u = (plan && plan.unstamped) || []
+  if (!u.length) return []
+  const lines = [
+    `  unstamped: ${u.length} phase(s) have no linear_issue_id, and ${
+      u[0].candidates.length
+    } sub-issue(s) from the last push are unclaimed —`,
+    '    not creating, since a lost stamp and a new phase look identical from here.',
+  ]
+  for (const item of u) lines.push(`    ${item.ref} — could be: ${item.candidates.join(', ')}`)
+  lines.push('    re-stamp the phase file (linear_issue_id) and push again.')
+  return lines
+}
+
 function deferredLines(n) {
   return [
     `  ${n} phase(s) deferred — mapping.phases is "deferred" and this spec has not started`,
-    '     they are created on the push that follows /spec-go',
+    '     they are created on the push that follows /spec-start',
   ]
 }
 
@@ -483,6 +502,7 @@ function specSyncStatus(dir, config, specArg, flags, out) {
     const u = plan.subIssues.update.length
     lines.push(`  push: pending — ${n} to create, ${u} to update${plan.issue ? ', issue changed' : ''}`)
   }
+  lines.push(...unstampedLines(plan))
 
   if (flags.remote && fs.existsSync(flags.remote)) {
     const remote = JSON.parse(fs.readFileSync(flags.remote, 'utf-8'))
@@ -1327,7 +1347,7 @@ async function specSyncStage(dir, config, stageKey, rangeArg, flags, out) {
  * beats no ref for looking correct). An explicit override cannot be blinded, and
  * needs no answer for mixed staging.
  *
- * The branch→spec direction is the INVERSE of what `/spec-go` provisions with,
+ * The branch→spec direction is the INVERSE of what `/spec-start` provisions with,
  * so it is computed by running `branchFor` over each spec and matching, rather
  * than by re-deriving the pattern here. A second implementation of the naming
  * rule would drift from the one that created the branch.

package/src/vendor/linear/config.js

@@ -2,7 +2,7 @@
 
 /**
  * Config loader for the one-way Linear sync feature (`/spec-status`, `/spec-push`
- * and the Linear-aware paths of `/spec` and `/spec-go`).
+ * and the Linear-aware paths of `/spec` and `/spec-next`).
  *
  * Reads `specs/.core/linear.config.json` from the project root and normalises it
  * over frozen defaults. The feature is strictly opt-in: when the file is absent

package/src/vendor/sync-core/src/compare.js

@@ -94,7 +94,9 @@ function snapshotOf(projection) {
 /**
  * Diff the local projection against the last-pushed snapshot.
  * @returns {{ issue?: object, subIssues: {create,update} }}
- *   create items carry a `ref` (local handle) and no id; update items carry both
+ *   `unstamped` (when present) lists phases whose stamp is missing while the
+ *   snapshot still remembers an unminted-for id — ambiguous, so neither created
+ *   nor updated. create items carry a `ref` (local handle) and no id; update items carry both
  *   — the `ref` because the read-back check matches sub-issues to phases BY ref,
  *   and an update with only an id makes every one of them look unmatched.
  *   `plan.issue` (when present) is the spec issue's description + state; the push
@@ -105,16 +107,37 @@ function planChanges(projection, snapshot) {
   const snap = snapshot || {}
   const snapS = snap.subIssues || {}
 
+  // Ids the last push minted that no phase claims any more. A phase file's stamp
+  // is the only link back to its sub-issue, and it lives in frontmatter — so a
+  // whole-file rewrite, a hand edit or a bad merge drops it while the sub-issue
+  // carries on existing. This snapshot is the only memory that it was ever
+  // minted, and nothing else in the push path re-reads the tracker.
+  const claimed = new Set()
+  for (const s of p.subIssues || []) if (s.id != null) claimed.add(String(s.id))
+  const unclaimed = Object.keys(snapS).filter((id) => !claimed.has(id))
+
   const subIssues = { create: [], update: [] }
+  const unstamped = []
   for (const s of p.subIssues || []) {
     if (s.id == null) {
-      subIssues.create.push({ ref: s.ref, name: s.name, goal: s.goal, state: s.state })
+      // THREE STATES, NOT TWO. "No stamp" means "new phase" only when every id
+      // the snapshot remembers is still claimed. With an unclaimed id sitting
+      // beside an unstamped phase the two readings — a new phase, and a phase
+      // whose stamp was lost — are indistinguishable from here, so this routes to
+      // the harmless branch and mints nothing. Being wrong this way costs a
+      // re-stamp; the other way cost a duplicate sub-issue and a manual cancel.
+      if (unclaimed.length) {
+        unstamped.push({ ref: s.ref, name: s.name, candidates: unclaimed.slice() })
+      } else {
+        subIssues.create.push({ ref: s.ref, name: s.name, goal: s.goal, state: s.state })
+      }
     } else if (snapS[String(s.id)] !== subIssueHash(s)) {
       subIssues.update.push({ ref: s.ref, id: s.id, name: s.name, goal: s.goal, state: s.state })
     }
   }
 
   const plan = { subIssues }
+  if (unstamped.length) plan.unstamped = unstamped
   const issue = issueChanges(p, snap)
   if (issue) plan.issue = issue
   return plan