@skillsmith/mcp-server 0.1.0

package/dist/tests/e2e/recommend.e2e.test.js

@@ -0,0 +1,347 @@
+/**
+ * E2E Test: MCP skill_recommend tool
+ *
+ * Tests the recommend tool against real skill databases
+ * in a clean Codespace environment.
+ *
+ * FOCUS: Detect hardcoded values that caused SMI-902/904 issues
+ *
+ * User Journey: Get skill recommendations based on context
+ */
+import { describe, it, expect, beforeAll, afterAll } from 'vitest';
+import { existsSync, rmSync, mkdirSync, writeFileSync } from 'fs';
+import { join } from 'path';
+import { tmpdir, homedir } from 'os';
+import { createDatabase, initializeSchema, SkillRepository, } from '@skillsmith/core';
+import { createToolContext } from '../../src/context.js';
+import { executeRecommend } from '../../src/tools/recommend.js';
+import { scanForHardcoded } from './utils/hardcoded-detector.js';
+import { recordTiming, measureAsync } from './utils/baseline-collector.js';
+// Test configuration
+const TEST_DIR = join(tmpdir(), 'skillsmith-e2e-recommend');
+const TEST_DB_PATH = join(TEST_DIR, 'recommend-test.db');
+const TEST_SKILLS_DIR = join(TEST_DIR, '.claude', 'skills');
+// Diverse seed data for testing recommendations
+const SEED_SKILLS = [
+    {
+        id: 'anthropic/commit',
+        name: 'commit',
+        description: 'Generate semantic commit messages following conventional commits',
+        author: 'anthropic',
+        repoUrl: 'https://github.com/anthropics/claude-code/tree/main/skills/commit',
+        qualityScore: 0.95,
+        trustTier: 'verified',
+        tags: ['development', 'git', 'commit', 'conventional-commits'],
+    },
+    {
+        id: 'community/jest-helper',
+        name: 'jest-helper',
+        description: 'Generate Jest test cases for React components',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/jest-helper',
+        qualityScore: 0.87,
+        trustTier: 'community',
+        tags: ['testing', 'jest', 'react', 'unit-tests'],
+    },
+    {
+        id: 'community/vitest-helper',
+        name: 'vitest-helper',
+        description: 'Generate Vitest test cases with modern ESM support',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/vitest-helper',
+        qualityScore: 0.85,
+        trustTier: 'community',
+        tags: ['testing', 'vitest', 'esm', 'typescript'],
+    },
+    {
+        id: 'community/docker-compose',
+        name: 'docker-compose',
+        description: 'Generate and manage Docker Compose configurations',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/docker-compose',
+        qualityScore: 0.84,
+        trustTier: 'community',
+        tags: ['devops', 'docker', 'containers'],
+    },
+    {
+        id: 'community/eslint-config',
+        name: 'eslint-config',
+        description: 'Generate and configure ESLint rules for JavaScript projects',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/eslint-config',
+        qualityScore: 0.82,
+        trustTier: 'community',
+        tags: ['linting', 'eslint', 'code-quality'],
+    },
+    {
+        id: 'experimental/ai-debug',
+        name: 'ai-debug',
+        description: 'AI-powered debugging assistant',
+        author: 'experimental',
+        repoUrl: 'https://github.com/skillsmith-community/ai-debug',
+        qualityScore: 0.65,
+        trustTier: 'experimental',
+        tags: ['debugging', 'ai', 'experimental'],
+    },
+];
+/**
+ * Create mock installed skill for auto-detection tests
+ */
+function createMockInstalledSkill(skillName) {
+    const skillDir = join(TEST_SKILLS_DIR, skillName);
+    mkdirSync(skillDir, { recursive: true });
+    writeFileSync(join(skillDir, 'SKILL.md'), `---
+name: ${skillName}
+version: 1.0.0
+description: Mock skill for testing
+---
+# ${skillName}
+Mock skill content.
+`);
+}
+/**
+ * Scan response for hardcoded values
+ */
+function scanResponseForHardcoded(response, command) {
+    const responseStr = JSON.stringify(response, null, 2);
+    return scanForHardcoded(responseStr, command, 'database', 'recommend response');
+}
+describe('E2E: skill_recommend tool', () => {
+    let db;
+    let context;
+    beforeAll(() => {
+        // Create test environment
+        if (existsSync(TEST_DIR)) {
+            rmSync(TEST_DIR, { recursive: true, force: true });
+        }
+        mkdirSync(TEST_DIR, { recursive: true });
+        mkdirSync(TEST_SKILLS_DIR, { recursive: true });
+        // Initialize database with seed data
+        db = createDatabase(TEST_DB_PATH);
+        initializeSchema(db);
+        const skillRepo = new SkillRepository(db);
+        for (const skill of SEED_SKILLS) {
+            skillRepo.create(skill);
+        }
+        // Create context pointing to test database
+        context = createToolContext({ dbPath: TEST_DB_PATH });
+    });
+    afterAll(() => {
+        db?.close();
+        if (existsSync(TEST_DIR)) {
+            rmSync(TEST_DIR, { recursive: true, force: true });
+        }
+    });
+    describe('Basic Recommendations', () => {
+        it('should return recommendations without installed skills', async () => {
+            const input = {
+                installed_skills: [],
+                limit: 5,
+            };
+            const { result } = await measureAsync('recommend:empty', 'skill_recommend (no installed)', () => executeRecommend(input, context));
+            expect(result.recommendations.length).toBeGreaterThan(0);
+            expect(result.timing.totalMs).toBeGreaterThanOrEqual(0);
+            // Check for hardcoded values in response
+            const issues = scanResponseForHardcoded(result, 'skill_recommend');
+            expect(issues.filter((i) => i.severity === 'error')).toHaveLength(0);
+        });
+        it('should return recommendations with installed skills', async () => {
+            const input = {
+                installed_skills: ['anthropic/commit'],
+                limit: 5,
+            };
+            const result = await executeRecommend(input, context);
+            recordTiming('recommend:with_installed', 'skill_recommend (installed)', result.timing.totalMs);
+            // May have 0 recommendations if seed data overlaps with installed skill
+            expect(result.recommendations.length).toBeGreaterThanOrEqual(0);
+            expect(result.context.installed_count).toBe(1);
+            // If there are recommendations, should not include already installed skill
+            const recommendedIds = result.recommendations.map((r) => r.skill_id);
+            expect(recommendedIds).not.toContain('anthropic/commit');
+            // Check for hardcoded values
+            const issues = scanResponseForHardcoded(result, 'skill_recommend');
+            expect(issues.filter((i) => i.severity === 'error')).toHaveLength(0);
+        });
+        it('should use project context for recommendations', async () => {
+            const input = {
+                installed_skills: [],
+                project_context: 'React TypeScript frontend with Jest testing',
+                limit: 5,
+            };
+            const result = await executeRecommend(input, context);
+            recordTiming('recommend:context', 'skill_recommend (context)', result.timing.totalMs);
+            expect(result.context.has_project_context).toBe(true);
+            // Check for hardcoded values
+            const issues = scanResponseForHardcoded(result, 'skill_recommend');
+            expect(issues.filter((i) => i.severity === 'error')).toHaveLength(0);
+        });
+    });
+    describe('Auto-Detection of Installed Skills', () => {
+        it('should auto-detect installed skills from ~/.claude/skills/', async () => {
+            // Create mock installed skill
+            createMockInstalledSkill('test-installed-skill');
+            // Override HOME for this test
+            const originalHome = process.env.HOME;
+            process.env.HOME = TEST_DIR;
+            try {
+                const input = {
+                    installed_skills: [], // Empty to trigger auto-detection
+                    limit: 5,
+                };
+                const result = await executeRecommend(input, context);
+                // Should have auto-detected
+                expect(result.context.auto_detected).toBe(true);
+                // Check for hardcoded values
+                const issues = scanResponseForHardcoded(result, 'skill_recommend (auto-detect)');
+                expect(issues.filter((i) => i.severity === 'error')).toHaveLength(0);
+            }
+            finally {
+                process.env.HOME = originalHome;
+            }
+        });
+    });
+    describe('Overlap Detection', () => {
+        it('should filter overlapping skills when enabled', async () => {
+            const input = {
+                installed_skills: ['community/jest-helper'],
+                detect_overlap: true,
+                limit: 10,
+            };
+            const result = await executeRecommend(input, context);
+            recordTiming('recommend:overlap', 'skill_recommend (overlap)', result.timing.totalMs);
+            // vitest-helper might be filtered as similar to jest-helper
+            // Just verify overlap_filtered is tracked
+            expect(typeof result.overlap_filtered).toBe('number');
+            // Check for hardcoded values
+            const issues = scanResponseForHardcoded(result, 'skill_recommend');
+            expect(issues.filter((i) => i.severity === 'error')).toHaveLength(0);
+        });
+        it('should not filter when detect_overlap is false', async () => {
+            const input = {
+                installed_skills: ['community/jest-helper'],
+                detect_overlap: false,
+                limit: 10,
+            };
+            const result = await executeRecommend(input, context);
+            // Should have more candidates when overlap not filtered
+            expect(result.candidates_considered).toBeGreaterThan(0);
+        });
+    });
+    describe('Response Data Quality', () => {
+        it('should return valid recommendation structure', async () => {
+            const input = {
+                installed_skills: [],
+                limit: 3,
+            };
+            const result = await executeRecommend(input, context);
+            for (const rec of result.recommendations) {
+                // Validate structure
+                expect(rec.skill_id).toBeDefined();
+                expect(rec.name).toBeDefined();
+                expect(rec.reason).toBeDefined();
+                expect(rec.similarity_score).toBeGreaterThanOrEqual(0);
+                expect(rec.similarity_score).toBeLessThanOrEqual(1);
+                expect(['verified', 'community', 'standard', 'unverified']).toContain(rec.trust_tier);
+                expect(rec.quality_score).toBeGreaterThanOrEqual(0);
+                expect(rec.quality_score).toBeLessThanOrEqual(100);
+            }
+        });
+        it('should not contain hardcoded skill IDs in recommendations', async () => {
+            const input = {
+                installed_skills: [],
+                limit: 10,
+            };
+            const result = await executeRecommend(input, context);
+            // All skill IDs should come from database, not hardcoded
+            const dbSkillIds = SEED_SKILLS.map((s) => s.id);
+            for (const rec of result.recommendations) {
+                expect(dbSkillIds).toContain(rec.skill_id);
+            }
+        });
+    });
+    describe('Hardcoded Value Detection (SMI-902/904 Regression)', () => {
+        it('should not expose user paths in response', async () => {
+            const input = {
+                installed_skills: ['anthropic/commit'],
+                project_context: 'Testing for hardcoded paths',
+                limit: 5,
+            };
+            const result = await executeRecommend(input, context);
+            const responseStr = JSON.stringify(result);
+            // Should not contain user-specific paths
+            expect(responseStr).not.toMatch(/\/Users\/[a-zA-Z0-9_-]+\//);
+            expect(responseStr).not.toMatch(/\/home\/[a-zA-Z0-9_-]+\//);
+            expect(responseStr).not.toContain(homedir());
+        });
+        it('should not expose localhost URLs in response', async () => {
+            const input = {
+                installed_skills: [],
+                limit: 5,
+            };
+            const result = await executeRecommend(input, context);
+            const responseStr = JSON.stringify(result);
+            // Should not contain localhost
+            expect(responseStr).not.toMatch(/localhost:\d+/);
+            expect(responseStr).not.toMatch(/127\.0\.0\.1:\d+/);
+        });
+        it('should not expose API keys in response', async () => {
+            const input = {
+                installed_skills: [],
+                project_context: 'Should not leak credentials',
+                limit: 5,
+            };
+            const result = await executeRecommend(input, context);
+            const responseStr = JSON.stringify(result);
+            // Should not contain API keys
+            expect(responseStr).not.toMatch(/ghp_[a-zA-Z0-9]{36}/);
+            expect(responseStr).not.toMatch(/sk-[a-zA-Z0-9]{32,}/);
+            expect(responseStr).not.toMatch(/lin_api_[a-zA-Z0-9]+/);
+        });
+        it('should have dynamic recommendations not hardcoded static list', async () => {
+            // Run twice with different contexts
+            const result1 = await executeRecommend({ installed_skills: [], project_context: 'Docker DevOps', limit: 5 }, context);
+            const result2 = await executeRecommend({ installed_skills: [], project_context: 'React testing', limit: 5 }, context);
+            // Results should potentially differ based on context
+            // (This test helps detect if recommendations are completely static)
+            const ids1 = result1.recommendations.map((r) => r.skill_id).sort();
+            const ids2 = result2.recommendations.map((r) => r.skill_id).sort();
+            // If results are EXACTLY the same regardless of context, may indicate hardcoding
+            // Note: This is a soft check - might be same due to small dataset
+            if (ids1.join(',') === ids2.join(',')) {
+                console.warn('Warning: Recommendations identical for different contexts - may indicate hardcoding');
+            }
+        });
+    });
+    describe('Performance Baselines', () => {
+        it('should complete recommendation in reasonable time', async () => {
+            const { durationMs } = await measureAsync('recommend:baseline', 'skill_recommend baseline', () => executeRecommend({
+                installed_skills: ['anthropic/commit'],
+                project_context: 'Full-stack TypeScript project',
+                limit: 10,
+            }, context));
+            // Baseline: should complete within 2 seconds for seed data
+            expect(durationMs).toBeLessThan(2000);
+            console.log(`Recommend baseline: ${durationMs}ms`);
+        });
+        it('should handle multiple rapid requests', async () => {
+            const requests = Array(5)
+                .fill(null)
+                .map((_, i) => executeRecommend({ installed_skills: [], project_context: `Context ${i}`, limit: 3 }, context));
+            const results = await Promise.all(requests);
+            expect(results).toHaveLength(5);
+            for (const result of results) {
+                expect(result.recommendations.length).toBeGreaterThanOrEqual(0);
+            }
+        });
+    });
+    describe('Error Handling', () => {
+        it('should handle invalid limit gracefully', async () => {
+            // Zod should enforce limits
+            await expect(executeRecommend({ installed_skills: [], limit: 100 }, context)).rejects.toThrow();
+        });
+        it('should handle invalid min_similarity gracefully', async () => {
+            await expect(executeRecommend({ installed_skills: [], min_similarity: 2.0 }, context)).rejects.toThrow();
+        });
+    });
+});
+//# sourceMappingURL=recommend.e2e.test.js.map

package/dist/tests/e2e/recommend.e2e.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"recommend.e2e.test.js","sourceRoot":"","sources":["../../../tests/e2e/recommend.e2e.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,QAAQ,EAAE,MAAM,QAAQ,CAAA;AAClE,OAAO,EAAE,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,aAAa,EAAE,MAAM,IAAI,CAAA;AACjE,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAA;AAC3B,OAAO,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,CAAA;AACpC,OAAO,EACL,cAAc,EACd,gBAAgB,EAChB,eAAe,GAEhB,MAAM,kBAAkB,CAAA;AACzB,OAAO,EAAE,iBAAiB,EAAoB,MAAM,sBAAsB,CAAA;AAC1E,OAAO,EAAE,gBAAgB,EAAuB,MAAM,8BAA8B,CAAA;AACpF,OAAO,EAAE,gBAAgB,EAAuB,MAAM,+BAA+B,CAAA;AACrF,OAAO,EAAE,YAAY,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAA;AAE1E,qBAAqB;AACrB,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,EAAE,EAAE,0BAA0B,CAAC,CAAA;AAC3D,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,EAAE,mBAAmB,CAAC,CAAA;AACxD,MAAM,eAAe,GAAG,IAAI,CAAC,QAAQ,EAAE,SAAS,EAAE,QAAQ,CAAC,CAAA;AAE3D,gDAAgD;AAChD,MAAM,WAAW,GAAG;IAClB;QACE,EAAE,EAAE,kBAAkB;QACtB,IAAI,EAAE,QAAQ;QACd,WAAW,EAAE,kEAAkE;QAC/E,MAAM,EAAE,WAAW;QACnB,OAAO,EAAE,mEAAmE;QAC5E,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,UAAmB;QAC9B,IAAI,EAAE,CAAC,aAAa,EAAE,KAAK,EAAE,QAAQ,EAAE,sBAAsB,CAAC;KAC/D;IACD;QACE,EAAE,EAAE,uBAAuB;QAC3B,IAAI,EAAE,aAAa;QACnB,WAAW,EAAE,+CAA+C;QAC5D,MAAM,EAAE,WAAW;QACnB,OAAO,EAAE,qDAAqD;QAC9D,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,WAAoB;QAC/B,IAAI,EAAE,CAAC,SAAS,EAAE,MAAM,EAAE,OAAO,EAAE,YAAY,CAAC;KACjD;IACD;QACE,EAAE,EAAE,yBAAyB;QAC7B,IAAI,EAAE,eAAe;QACrB,WAAW,EAAE,oDAAoD;QACjE,MAAM,EAAE,WAAW;QACnB,OAAO,EAAE,uDAAuD;QAChE,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,WAAoB;QAC/B,IAAI,EAAE,CAAC,SAAS,EAAE,QAAQ,EAAE,KAAK,EAAE,YAAY,CAAC;KACjD;IACD;QACE,EAAE,EAAE,0BAA0B;QAC9B,IAAI,EAAE,gBAAgB;QACtB,WAAW,EAAE,mDAAmD;QAChE,MAAM,EAAE,WAAW;QACnB,OAAO,EAAE,wDAAwD;QACjE,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,WAAoB;QAC/B,IAAI,EAAE,CAAC,QAAQ,EAAE,QAAQ,EAAE,YAAY,CAAC;KACzC;IACD;QACE,EAAE,EAAE,yBAAyB;QAC7B,IAAI,EAAE,eAAe;QACrB,WAAW,EAAE,6DAA6D;QAC1E,MAAM,EAAE,WAAW;QACnB,OAAO,EAAE,uDAAuD;QAChE,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,WAAoB;QAC/B,IAAI,EAAE,CAAC,SAAS,EAAE,QAAQ,EAAE,cAAc,CAAC;KAC5C;IACD;QACE,EAAE,EAAE,uBAAuB;QAC3B,IAAI,EAAE,UAAU;QAChB,WAAW,EAAE,gCAAgC;QAC7C,MAAM,EAAE,cAAc;QACtB,OAAO,EAAE,kDAAkD;QAC3D,YAAY,EAAE,IAAI;QAClB,SAAS,EAAE,cAAuB;QAClC,IAAI,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,cAAc,CAAC;KAC1C;CACF,CAAA;AAED;;GAEG;AACH,SAAS,wBAAwB,CAAC,SAAiB;IACjD,MAAM,QAAQ,GAAG,IAAI,CAAC,eAAe,EAAE,SAAS,CAAC,CAAA;IACjD,SAAS,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;IACxC,aAAa,CACX,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,EAC1B;QACI,SAAS;;;;IAIb,SAAS;;CAEZ,CACE,CAAA;AACH,CAAC;AAED;;GAEG;AACH,SAAS,wBAAwB,CAAC,QAAiB,EAAE,OAAe;IAClE,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAA;IACrD,OAAO,gBAAgB,CAAC,WAAW,EAAE,OAAO,EAAE,UAAU,EAAE,oBAAoB,CAAC,CAAA;AACjF,CAAC;AAED,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IACzC,IAAI,EAAgB,CAAA;IACpB,IAAI,OAAoB,CAAA;IAExB,SAAS,CAAC,GAAG,EAAE;QACb,0BAA0B;QAC1B,IAAI,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YACzB,MAAM,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;QACpD,CAAC;QACD,SAAS,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;QACxC,SAAS,CAAC,eAAe,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;QAE/C,qCAAqC;QACrC,EAAE,GAAG,cAAc,CAAC,YAAY,CAAC,CAAA;QACjC,gBAAgB,CAAC,EAAE,CAAC,CAAA;QAEpB,MAAM,SAAS,GAAG,IAAI,eAAe,CAAC,EAAE,CAAC,CAAA;QACzC,KAAK,MAAM,KAAK,IAAI,WAAW,EAAE,CAAC;YAChC,SAAS,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QACzB,CAAC;QAED,2CAA2C;QAC3C,OAAO,GAAG,iBAAiB,CAAC,EAAE,MAAM,EAAE,YAAY,EAAE,CAAC,CAAA;IACvD,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,GAAG,EAAE;QACZ,EAAE,EAAE,KAAK,EAAE,CAAA;QACX,IAAI,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YACzB,MAAM,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;QACpD,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;QACrC,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;YACtE,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,EAAE,MAAM,EAAE,GAAG,MAAM,YAAY,CACnC,iBAAiB,EACjB,gCAAgC,EAChC,GAAG,EAAE,CAAC,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CACvC,CAAA;YAED,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;YACxD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;YAEvD,yCAAyC;YACzC,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAA;YAClE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACtE,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,qDAAqD,EAAE,KAAK,IAAI,EAAE;YACnE,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,CAAC,kBAAkB,CAAC;gBACtC,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,YAAY,CAAC,0BAA0B,EAAE,6BAA6B,EAAE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAA;YAE9F,wEAAwE;YACxE,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;YAC/D,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;YAE9C,2EAA2E;YAC3E,MAAM,cAAc,GAAG,MAAM,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAA;YACpE,MAAM,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAA;YAExD,6BAA6B;YAC7B,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAA;YAClE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACtE,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;YAC9D,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,eAAe,EAAE,6CAA6C;gBAC9D,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,YAAY,CAAC,mBAAmB,EAAE,2BAA2B,EAAE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAA;YAErF,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YAErD,6BAA6B;YAC7B,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAA;YAClE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACtE,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAClD,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;YAC1E,8BAA8B;YAC9B,wBAAwB,CAAC,sBAAsB,CAAC,CAAA;YAEhD,8BAA8B;YAC9B,MAAM,YAAY,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAA;YACrC,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,QAAQ,CAAA;YAE3B,IAAI,CAAC;gBACH,MAAM,KAAK,GAAmB;oBAC5B,gBAAgB,EAAE,EAAE,EAAE,kCAAkC;oBACxD,KAAK,EAAE,CAAC;iBACT,CAAA;gBAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;gBAErD,4BAA4B;gBAC5B,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;gBAE/C,6BAA6B;gBAC7B,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,EAAE,+BAA+B,CAAC,CAAA;gBAChF,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;YACtE,CAAC;oBAAS,CAAC;gBACT,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,YAAY,CAAA;YACjC,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;YAC7D,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,CAAC,uBAAuB,CAAC;gBAC3C,cAAc,EAAE,IAAI;gBACpB,KAAK,EAAE,EAAE;aACV,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,YAAY,CAAC,mBAAmB,EAAE,2BAA2B,EAAE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAA;YAErF,4DAA4D;YAC5D,0CAA0C;YAC1C,MAAM,CAAC,OAAO,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;YAErD,6BAA6B;YAC7B,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAA;YAClE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACtE,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;YAC9D,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,CAAC,uBAAuB,CAAC;gBAC3C,cAAc,EAAE,KAAK;gBACrB,KAAK,EAAE,EAAE;aACV,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,wDAAwD;YACxD,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;QACzD,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;QACrC,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;YAC5D,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,eAAe,EAAE,CAAC;gBACzC,qBAAqB;gBACrB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,WAAW,EAAE,CAAA;gBAClC,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,WAAW,EAAE,CAAA;gBAC9B,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,CAAA;gBAChC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;gBACtD,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAA;gBACnD,MAAM,CAAC,CAAC,UAAU,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAC,CAAC,SAAS,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;gBACrF,MAAM,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;gBACnD,MAAM,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAA;YACpD,CAAC;QACH,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;YACzE,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,KAAK,EAAE,EAAE;aACV,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YAErD,yDAAyD;YACzD,MAAM,UAAU,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAA;YAC/C,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,eAAe,EAAE,CAAC;gBACzC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAA;YAC5C,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAClE,EAAE,CAAC,0CAA0C,EAAE,KAAK,IAAI,EAAE;YACxD,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,CAAC,kBAAkB,CAAC;gBACtC,eAAe,EAAE,6BAA6B;gBAC9C,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YACrD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;YAE1C,yCAAyC;YACzC,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,2BAA2B,CAAC,CAAA;YAC5D,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAA;YAC3D,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,OAAO,EAAE,CAAC,CAAA;QAC9C,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;YAC5D,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YACrD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;YAE1C,+BAA+B;YAC/B,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,eAAe,CAAC,CAAA;YAChD,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAA;QACrD,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,wCAAwC,EAAE,KAAK,IAAI,EAAE;YACtD,MAAM,KAAK,GAAmB;gBAC5B,gBAAgB,EAAE,EAAE;gBACpB,eAAe,EAAE,6BAA6B;gBAC9C,KAAK,EAAE,CAAC;aACT,CAAA;YAED,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAA;YACrD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;YAE1C,8BAA8B;YAC9B,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAA;YACtD,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAA;YACtD,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAA;QACzD,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,+DAA+D,EAAE,KAAK,IAAI,EAAE;YAC7E,oCAAoC;YACpC,MAAM,OAAO,GAAG,MAAM,gBAAgB,CACpC,EAAE,gBAAgB,EAAE,EAAE,EAAE,eAAe,EAAE,eAAe,EAAE,KAAK,EAAE,CAAC,EAAE,EACpE,OAAO,CACR,CAAA;YAED,MAAM,OAAO,GAAG,MAAM,gBAAgB,CACpC,EAAE,gBAAgB,EAAE,EAAE,EAAE,eAAe,EAAE,eAAe,EAAE,KAAK,EAAE,CAAC,EAAE,EACpE,OAAO,CACR,CAAA;YAED,qDAAqD;YACrD,oEAAoE;YACpE,MAAM,IAAI,GAAG,OAAO,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,EAAE,CAAA;YAClE,MAAM,IAAI,GAAG,OAAO,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,EAAE,CAAA;YAElE,iFAAiF;YACjF,kEAAkE;YAClE,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;gBACtC,OAAO,CAAC,IAAI,CACV,qFAAqF,CACtF,CAAA;YACH,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;QACrC,EAAE,CAAC,mDAAmD,EAAE,KAAK,IAAI,EAAE;YACjE,MAAM,EAAE,UAAU,EAAE,GAAG,MAAM,YAAY,CACvC,oBAAoB,EACpB,0BAA0B,EAC1B,GAAG,EAAE,CACH,gBAAgB,CACd;gBACE,gBAAgB,EAAE,CAAC,kBAAkB,CAAC;gBACtC,eAAe,EAAE,+BAA+B;gBAChD,KAAK,EAAE,EAAE;aACV,EACD,OAAO,CACR,CACJ,CAAA;YAED,2DAA2D;YAC3D,MAAM,CAAC,UAAU,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAA;YACrC,OAAO,CAAC,GAAG,CAAC,uBAAuB,UAAU,IAAI,CAAC,CAAA;QACpD,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;YACrD,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC;iBACtB,IAAI,CAAC,IAAI,CAAC;iBACV,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CACZ,gBAAgB,CACd,EAAE,gBAAgB,EAAE,EAAE,EAAE,eAAe,EAAE,WAAW,CAAC,EAAE,EAAE,KAAK,EAAE,CAAC,EAAE,EACnE,OAAO,CACR,CACF,CAAA;YAEH,MAAM,OAAO,GAAG,MAAM,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAA;YAE3C,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;YAC/B,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;gBAC7B,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;YACjE,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,gBAAgB,EAAE,GAAG,EAAE;QAC9B,EAAE,CAAC,wCAAwC,EAAE,KAAK,IAAI,EAAE;YACtD,4BAA4B;YAC5B,MAAM,MAAM,CACV,gBAAgB,CAAC,EAAE,gBAAgB,EAAE,EAAE,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,OAAO,CAAC,CAChE,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;QACrB,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;YAC/D,MAAM,MAAM,CACV,gBAAgB,CAAC,EAAE,gBAAgB,EAAE,EAAE,EAAE,cAAc,EAAE,GAAG,EAAE,EAAE,OAAO,CAAC,CACzE,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;QACrB,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/e2e/skill-flow.e2e.test.d.ts

@@ -0,0 +1,10 @@
+/**
+ * E2E Test: Search → Get → Install Flow
+ *
+ * Tests the complete user journey from discovering a skill to installing it.
+ * Uses seed data to ensure consistent, reproducible tests.
+ *
+ * @see SMI-796: E2E test: Search → Get → Install flow
+ */
+export {};
+//# sourceMappingURL=skill-flow.e2e.test.d.ts.map

package/dist/tests/e2e/skill-flow.e2e.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-flow.e2e.test.d.ts","sourceRoot":"","sources":["../../../tests/e2e/skill-flow.e2e.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG"}

package/dist/tests/e2e/skill-flow.e2e.test.js

@@ -0,0 +1,280 @@
+/**
+ * E2E Test: Search → Get → Install Flow
+ *
+ * Tests the complete user journey from discovering a skill to installing it.
+ * Uses seed data to ensure consistent, reproducible tests.
+ *
+ * @see SMI-796: E2E test: Search → Get → Install flow
+ */
+import { describe, it, expect, beforeAll, afterAll } from 'vitest';
+import { existsSync, rmSync, mkdirSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { createDatabase, initializeSchema, SkillRepository, } from '@skillsmith/core';
+import { createToolContext } from '../../src/context.js';
+import { executeSearch } from '../../src/tools/search.js';
+import { executeGetSkill } from '../../src/tools/get-skill.js';
+const SEED_SKILLS = [
+    {
+        id: 'anthropic/commit',
+        name: 'commit',
+        description: 'Generate semantic commit messages following conventional commits',
+        author: 'anthropic',
+        repoUrl: 'https://github.com/anthropics/claude-code/tree/main/skills/commit',
+        qualityScore: 0.95,
+        trustTier: 'verified',
+        tags: ['development', 'git', 'commit', 'conventional-commits'],
+    },
+    {
+        id: 'community/jest-helper',
+        name: 'jest-helper',
+        description: 'Generate Jest test cases for React components',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/jest-helper',
+        qualityScore: 0.87,
+        trustTier: 'community',
+        tags: ['testing', 'jest', 'react', 'unit-tests'],
+    },
+    {
+        id: 'community/vitest-helper',
+        name: 'vitest-helper',
+        description: 'Generate Vitest test cases with modern ESM support',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/vitest-helper',
+        qualityScore: 0.85,
+        trustTier: 'community',
+        tags: ['testing', 'vitest', 'esm', 'typescript'],
+    },
+    {
+        id: 'community/docker-compose',
+        name: 'docker-compose',
+        description: 'Generate and manage Docker Compose configurations',
+        author: 'community',
+        repoUrl: 'https://github.com/skillsmith-community/docker-compose',
+        qualityScore: 0.84,
+        trustTier: 'community',
+        tags: ['devops', 'docker', 'containers'],
+    },
+];
+describe('E2E: Skill Discovery Flow', () => {
+    let db;
+    let context;
+    let testDbPath;
+    beforeAll(() => {
+        // Create isolated test database
+        const testDir = join(tmpdir(), 'skillsmith-e2e-test');
+        if (!existsSync(testDir)) {
+            mkdirSync(testDir, { recursive: true });
+        }
+        testDbPath = join(testDir, `e2e-test-${Date.now()}.db`);
+        // Initialize database with seed data
+        db = createDatabase(testDbPath);
+        initializeSchema(db);
+        const skillRepository = new SkillRepository(db);
+        for (const skill of SEED_SKILLS) {
+            skillRepository.create(skill);
+        }
+        // Create context
+        context = createToolContext({ dbPath: testDbPath });
+    });
+    afterAll(() => {
+        db?.close();
+        if (testDbPath && existsSync(testDbPath)) {
+            rmSync(testDbPath, { force: true });
+        }
+    });
+    describe('Step 1: Search for skills', () => {
+        it('should find commit skill when searching for "commit"', async () => {
+            const input = { query: 'commit' };
+            const result = await executeSearch(input, context);
+            expect(result.results.length).toBeGreaterThan(0);
+            expect(result.results.some((s) => s.id === 'anthropic/commit')).toBe(true);
+        });
+        it('should find testing skills when searching for "test"', async () => {
+            const input = { query: 'test' };
+            const result = await executeSearch(input, context);
+            expect(result.results.length).toBeGreaterThanOrEqual(2);
+            expect(result.results.some((s) => s.id === 'community/jest-helper')).toBe(true);
+            expect(result.results.some((s) => s.id === 'community/vitest-helper')).toBe(true);
+        });
+        it('should filter by category', async () => {
+            // Note: Category filtering may not reduce results if skills already match the category
+            const input = { query: 'docker' };
+            const result = await executeSearch(input, context);
+            expect(result.results.length).toBeGreaterThan(0);
+            expect(result.results.some((s) => s.id === 'community/docker-compose')).toBe(true);
+            // Verify docker-compose has expected category from extractCategoryFromTags
+            const dockerSkill = result.results.find((s) => s.id === 'community/docker-compose');
+            expect(dockerSkill?.category).toBe('devops');
+        });
+        it('should filter by trust tier', async () => {
+            const input = { query: 'commit', trust_tier: 'verified' };
+            const result = await executeSearch(input, context);
+            expect(result.results.every((s) => s.trustTier === 'verified')).toBe(true);
+        });
+        it('should filter by minimum score', async () => {
+            const input = { query: 'test', min_score: 85 };
+            const result = await executeSearch(input, context);
+            expect(result.results.every((s) => s.score >= 85)).toBe(true);
+        });
+    });
+    describe('Step 2: Get skill details', () => {
+        it('should retrieve full details for a skill', async () => {
+            const input = { id: 'anthropic/commit' };
+            const result = await executeGetSkill(input, context);
+            expect(result.skill.id).toBe('anthropic/commit');
+            expect(result.skill.name).toBe('commit');
+            expect(result.skill.author).toBe('anthropic');
+            expect(result.skill.trustTier).toBe('verified');
+            expect(result.skill.score).toBe(95);
+            expect(result.installCommand).toContain('claude skill add anthropic/commit');
+        });
+        it('should include timing information', async () => {
+            const input = { id: 'community/jest-helper' };
+            const result = await executeGetSkill(input, context);
+            expect(result.timing).toBeDefined();
+            expect(result.timing.totalMs).toBeGreaterThanOrEqual(0);
+        });
+        it('should throw for non-existent skill', async () => {
+            const input = { id: 'nonexistent/skill' };
+            await expect(executeGetSkill(input, context)).rejects.toThrow();
+        });
+    });
+    describe('Step 3: Search → Get flow integration', () => {
+        it('should allow getting details of any search result', async () => {
+            // Step 1: Search
+            const searchInput = { query: 'jest' };
+            const searchResult = await executeSearch(searchInput, context);
+            expect(searchResult.results.length).toBeGreaterThan(0);
+            // Step 2: Get details of first result
+            const firstResult = searchResult.results[0];
+            const getInput = { id: firstResult.id };
+            const skillDetails = await executeGetSkill(getInput, context);
+            // Verify consistency
+            expect(skillDetails.skill.id).toBe(firstResult.id);
+            expect(skillDetails.skill.name).toBe(firstResult.name);
+            expect(skillDetails.skill.trustTier).toBe(firstResult.trustTier);
+        });
+        it('should provide install command for all skills', async () => {
+            // Search for all testing skills
+            const searchInput = { query: 'test' };
+            const searchResult = await executeSearch(searchInput, context);
+            // Get details and verify install commands
+            for (const result of searchResult.results) {
+                const details = await executeGetSkill({ id: result.id }, context);
+                expect(details.installCommand).toMatch(/^claude skill add [a-z0-9-]+\/[a-z0-9-]+$/i);
+            }
+        });
+    });
+    describe('Quality and Performance', () => {
+        it('should complete search in under 100ms', async () => {
+            const input = { query: 'commit' };
+            const result = await executeSearch(input, context);
+            expect(result.timing.totalMs).toBeLessThan(100);
+        });
+        it('should complete get-skill in under 50ms', async () => {
+            const input = { id: 'anthropic/commit' };
+            const result = await executeGetSkill(input, context);
+            expect(result.timing.totalMs).toBeLessThan(50);
+        });
+        it('should handle rapid successive searches', async () => {
+            const queries = ['commit', 'test', 'docker', 'jest', 'vitest'];
+            const results = await Promise.all(queries.map((query) => executeSearch({ query }, context)));
+            expect(results.every((r) => r.results.length >= 0)).toBe(true);
+        });
+    });
+    describe('Error Handling', () => {
+        it('should reject empty search queries', async () => {
+            const input = { query: '' };
+            await expect(executeSearch(input, context)).rejects.toThrow();
+        });
+        it('should reject single-character search queries', async () => {
+            const input = { query: 'a' };
+            await expect(executeSearch(input, context)).rejects.toThrow();
+        });
+        it('should reject invalid skill ID formats', async () => {
+            const input = { id: 'invalid-format' };
+            await expect(executeGetSkill(input, context)).rejects.toThrow();
+        });
+        it('should reject out-of-range min_score', async () => {
+            const input = { query: 'test', min_score: 150 };
+            await expect(executeSearch(input, context)).rejects.toThrow();
+        });
+    });
+});
+describe('E2E: Data Quality Validation', () => {
+    let db;
+    let context;
+    let testDbPath;
+    beforeAll(() => {
+        const testDir = join(tmpdir(), 'skillsmith-e2e-quality');
+        if (!existsSync(testDir)) {
+            mkdirSync(testDir, { recursive: true });
+        }
+        testDbPath = join(testDir, `quality-test-${Date.now()}.db`);
+        db = createDatabase(testDbPath);
+        initializeSchema(db);
+        const skillRepository = new SkillRepository(db);
+        for (const skill of SEED_SKILLS) {
+            skillRepository.create(skill);
+        }
+        context = createToolContext({ dbPath: testDbPath });
+    });
+    afterAll(() => {
+        db?.close();
+        if (testDbPath && existsSync(testDbPath)) {
+            rmSync(testDbPath, { force: true });
+        }
+    });
+    describe('SMI-795: Import Quality Validation', () => {
+        it('should have valid trust tiers for all skills', async () => {
+            // Since empty/short queries throw, get skills directly
+            for (const skill of SEED_SKILLS) {
+                const details = await executeGetSkill({ id: skill.id }, context);
+                expect(['verified', 'community', 'standard', 'unverified', 'experimental']).toContain(details.skill.trustTier);
+            }
+        });
+        it('should have quality scores between 0 and 100', async () => {
+            for (const skill of SEED_SKILLS) {
+                const details = await executeGetSkill({ id: skill.id }, context);
+                const score = details.skill.score ?? 0;
+                expect(score).toBeGreaterThanOrEqual(0);
+                expect(score).toBeLessThanOrEqual(100);
+            }
+        });
+        it('should have non-empty descriptions', async () => {
+            for (const skill of SEED_SKILLS) {
+                const details = await executeGetSkill({ id: skill.id }, context);
+                const description = details.skill.description ?? '';
+                expect(description.length).toBeGreaterThan(0);
+            }
+        });
+        it('should have valid category mappings', async () => {
+            for (const skill of SEED_SKILLS) {
+                const details = await executeGetSkill({ id: skill.id }, context);
+                const category = details.skill.category ?? 'other';
+                expect([
+                    'development',
+                    'testing',
+                    'documentation',
+                    'devops',
+                    'database',
+                    'security',
+                    'productivity',
+                    'integration',
+                    'ai-ml',
+                    'other',
+                ]).toContain(category);
+            }
+        });
+        it('should have valid author names', async () => {
+            for (const skill of SEED_SKILLS) {
+                const details = await executeGetSkill({ id: skill.id }, context);
+                const author = details.skill.author ?? '';
+                expect(author).not.toBe('unknown');
+                expect(author.length).toBeGreaterThan(0);
+            }
+        });
+    });
+});
+//# sourceMappingURL=skill-flow.e2e.test.js.map