@skillsmith/core 0.4.9 → 0.4.10

package/dist/tests/utils/safe-fs.test.js

@@ -0,0 +1,116 @@
+/**
+ * SMI-2274: Safe filesystem operations tests
+ *
+ * Tests for symlink-safe file write operations.
+ * Covers:
+ * - Normal file writes
+ * - Symlink detection and rejection
+ * - Non-existent file creation
+ * - Explicit file permissions
+ */
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { safeWriteFile, SymlinkError, HardlinkError } from '../../src/utils/safe-fs.js';
+import * as fs from 'fs/promises';
+import * as path from 'path';
+import * as os from 'os';
+describe('SMI-2274: safeWriteFile', () => {
+    let tempDir;
+    beforeEach(async () => {
+        tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'safe-fs-test-'));
+    });
+    afterEach(async () => {
+        await fs.rm(tempDir, { recursive: true, force: true });
+    });
+    it('should write to a new file that does not exist', async () => {
+        const filePath = path.join(tempDir, 'new-file.md');
+        await safeWriteFile(filePath, '# Test Skill');
+        const content = await fs.readFile(filePath, 'utf-8');
+        expect(content).toBe('# Test Skill');
+    });
+    it('should overwrite an existing regular file', async () => {
+        const filePath = path.join(tempDir, 'existing.md');
+        await fs.writeFile(filePath, 'old content');
+        await safeWriteFile(filePath, 'new content');
+        const content = await fs.readFile(filePath, 'utf-8');
+        expect(content).toBe('new content');
+    });
+    it('should reject writing to a symlink', async () => {
+        const targetPath = path.join(tempDir, 'target.md');
+        const symlinkPath = path.join(tempDir, 'symlink.md');
+        await fs.writeFile(targetPath, 'target content');
+        await fs.symlink(targetPath, symlinkPath);
+        await expect(safeWriteFile(symlinkPath, 'malicious')).rejects.toThrow(SymlinkError);
+        await expect(safeWriteFile(symlinkPath, 'malicious')).rejects.toThrow('Refusing to write to symlink');
+        // Verify target was not modified
+        const content = await fs.readFile(targetPath, 'utf-8');
+        expect(content).toBe('target content');
+    });
+    it('should reject writing to a dangling symlink', async () => {
+        const symlinkPath = path.join(tempDir, 'dangling.md');
+        await fs.symlink('/nonexistent/path', symlinkPath);
+        await expect(safeWriteFile(symlinkPath, 'content')).rejects.toThrow(SymlinkError);
+    });
+    it('should set default file permissions to 0o644', async () => {
+        const filePath = path.join(tempDir, 'permissions.md');
+        await safeWriteFile(filePath, 'content');
+        const stats = await fs.stat(filePath);
+        // Check the file permission bits (mask out file type bits)
+        const mode = stats.mode & 0o777;
+        expect(mode).toBe(0o644);
+    });
+    it('should respect custom mode option', async () => {
+        const filePath = path.join(tempDir, 'custom-mode.md');
+        await safeWriteFile(filePath, 'content', { mode: 0o600 });
+        const stats = await fs.stat(filePath);
+        const mode = stats.mode & 0o777;
+        expect(mode).toBe(0o600);
+    });
+    it('should handle Buffer content', async () => {
+        const filePath = path.join(tempDir, 'buffer.bin');
+        const buffer = Buffer.from([0x48, 0x65, 0x6c, 0x6c, 0x6f]);
+        await safeWriteFile(filePath, buffer);
+        const content = await fs.readFile(filePath);
+        expect(content.toString()).toBe('Hello');
+    });
+    it('should propagate non-ENOENT errors', async () => {
+        // Try to write to a path where the parent directory doesn't exist
+        const filePath = path.join(tempDir, 'nonexistent', 'deep', 'file.md');
+        await expect(safeWriteFile(filePath, 'content')).rejects.toThrow();
+    });
+    it('should apply default permissions when encoding string is passed', async () => {
+        const filePath = path.join(tempDir, 'encoding-test.md');
+        await safeWriteFile(filePath, 'content', 'utf-8');
+        const stats = await fs.stat(filePath);
+        const mode = stats.mode & 0o777;
+        expect(mode).toBe(0o644);
+    });
+    it('should reject writing to a hardlinked file', async () => {
+        const originalPath = path.join(tempDir, 'original.md');
+        const hardlinkPath = path.join(tempDir, 'hardlink.md');
+        await fs.writeFile(originalPath, 'original content');
+        await fs.link(originalPath, hardlinkPath);
+        await expect(safeWriteFile(hardlinkPath, 'malicious')).rejects.toThrow(HardlinkError);
+        // Verify original was not modified
+        const content = await fs.readFile(originalPath, 'utf-8');
+        expect(content).toBe('original content');
+    });
+});
+describe('SMI-2274: SymlinkError', () => {
+    it('should have correct name, message, and filePath', () => {
+        const error = new SymlinkError('/path/to/file');
+        expect(error.name).toBe('SymlinkError');
+        expect(error.message).toBe('Refusing to write to symlink: /path/to/file');
+        expect(error.filePath).toBe('/path/to/file');
+        expect(error).toBeInstanceOf(Error);
+    });
+});
+describe('SMI-2290: HardlinkError', () => {
+    it('should have correct name, message, and filePath', () => {
+        const error = new HardlinkError('/path/to/file');
+        expect(error.name).toBe('HardlinkError');
+        expect(error.message).toBe('Refusing to write to hardlinked file: /path/to/file');
+        expect(error.filePath).toBe('/path/to/file');
+        expect(error).toBeInstanceOf(Error);
+    });
+});
+//# sourceMappingURL=safe-fs.test.js.map

package/dist/tests/utils/safe-fs.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"safe-fs.test.js","sourceRoot":"","sources":["../../../tests/utils/safe-fs.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAA;AACpE,OAAO,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAA;AACvF,OAAO,KAAK,EAAE,MAAM,aAAa,CAAA;AACjC,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,KAAK,EAAE,MAAM,IAAI,CAAA;AAExB,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACvC,IAAI,OAAe,CAAA;IAEnB,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,OAAO,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,eAAe,CAAC,CAAC,CAAA;IACrE,CAAC,CAAC,CAAA;IAEF,SAAS,CAAC,KAAK,IAAI,EAAE;QACnB,MAAM,EAAE,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC9D,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QAElD,MAAM,aAAa,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAA;QAE7C,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QACpD,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,2CAA2C,EAAE,KAAK,IAAI,EAAE;QACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QAClD,MAAM,EAAE,CAAC,SAAS,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAA;QAE3C,MAAM,aAAa,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAA;QAE5C,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QACpD,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;IACrC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oCAAoC,EAAE,KAAK,IAAI,EAAE;QAClD,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,WAAW,CAAC,CAAA;QAClD,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,YAAY,CAAC,CAAA;QACpD,MAAM,EAAE,CAAC,SAAS,CAAC,UAAU,EAAE,gBAAgB,CAAC,CAAA;QAChD,MAAM,EAAE,CAAC,OAAO,CAAC,UAAU,EAAE,WAAW,CAAC,CAAA;QAEzC,MAAM,MAAM,CAAC,aAAa,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,YAAY,CAAC,CAAA;QACnF,MAAM,MAAM,CAAC,aAAa,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CACnE,8BAA8B,CAC/B,CAAA;QAED,iCAAiC;QACjC,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,UAAU,EAAE,OAAO,CAAC,CAAA;QACtD,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,KAAK,IAAI,EAAE;QAC3D,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QACrD,MAAM,EAAE,CAAC,OAAO,CAAC,mBAAmB,EAAE,WAAW,CAAC,CAAA;QAElD,MAAM,MAAM,CAAC,aAAa,CAAC,WAAW,EAAE,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,YAAY,CAAC,CAAA;IACnF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,gBAAgB,CAAC,CAAA;QAErD,MAAM,aAAa,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAA;QAExC,MAAM,KAAK,GAAG,MAAM,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACrC,2DAA2D;QAC3D,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,GAAG,KAAK,CAAA;QAC/B,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IAC1B,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mCAAmC,EAAE,KAAK,IAAI,EAAE;QACjD,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,gBAAgB,CAAC,CAAA;QAErD,MAAM,aAAa,CAAC,QAAQ,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAA;QAEzD,MAAM,KAAK,GAAG,MAAM,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACrC,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,GAAG,KAAK,CAAA;QAC/B,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IAC1B,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8BAA8B,EAAE,KAAK,IAAI,EAAE;QAC5C,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,YAAY,CAAC,CAAA;QACjD,MAAM,MAAM,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC,CAAA;QAE1D,MAAM,aAAa,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAA;QAErC,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAA;QAC3C,MAAM,CAAC,OAAO,CAAC,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oCAAoC,EAAE,KAAK,IAAI,EAAE;QAClD,kEAAkE;QAClE,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,EAAE,MAAM,EAAE,SAAS,CAAC,CAAA;QAErE,MAAM,MAAM,CAAC,aAAa,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;IACpE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;QAC/E,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,kBAAkB,CAAC,CAAA;QACvD,MAAM,aAAa,CAAC,QAAQ,EAAE,SAAS,EAAE,OAAO,CAAC,CAAA;QACjD,MAAM,KAAK,GAAG,MAAM,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACrC,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,GAAG,KAAK,CAAA;QAC/B,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IAC1B,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QACtD,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QACtD,MAAM,EAAE,CAAC,SAAS,CAAC,YAAY,EAAE,kBAAkB,CAAC,CAAA;QACpD,MAAM,EAAE,CAAC,IAAI,CAAC,YAAY,EAAE,YAAY,CAAC,CAAA;QAEzC,MAAM,MAAM,CAAC,aAAa,CAAC,YAAY,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,aAAa,CAAC,CAAA;QAErF,mCAAmC;QACnC,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;QACxD,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,MAAM,KAAK,GAAG,IAAI,YAAY,CAAC,eAAe,CAAC,CAAA;QAE/C,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;QACvC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,6CAA6C,CAAC,CAAA;QACzE,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;QAC5C,MAAM,CAAC,KAAK,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,CAAA;IACrC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACvC,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,MAAM,KAAK,GAAG,IAAI,aAAa,CAAC,eAAe,CAAC,CAAA;QAEhD,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;QACxC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,qDAAqD,CAAC,CAAA;QACjF,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;QAC5C,MAAM,CAAC,KAAK,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,CAAA;IACrC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skillsmith/core",
-  "version": "0.4.9",
+  "version": "0.4.10",
   "description": "Core types and utilities for Skillsmith",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -8,27 +8,33 @@
   "exports": {
     ".": {
       "types": "./dist/src/index.d.ts",
-      "import": "./dist/src/index.js"
+      "import": "./dist/src/index.js",
+      "default": "./dist/src/index.js"
     },
     "./errors": {
       "types": "./dist/src/errors.d.ts",
-      "import": "./dist/src/errors.js"
+      "import": "./dist/src/errors.js",
+      "default": "./dist/src/errors.js"
     },
     "./embeddings": {
       "types": "./dist/src/embeddings/index.d.ts",
-      "import": "./dist/src/embeddings/index.js"
+      "import": "./dist/src/embeddings/index.js",
+      "default": "./dist/src/embeddings/index.js"
     },
     "./testing": {
       "types": "./dist/src/testing/index.d.ts",
-      "import": "./dist/src/testing/index.js"
+      "import": "./dist/src/testing/index.js",
+      "default": "./dist/src/testing/index.js"
     },
     "./learning": {
       "types": "./dist/src/learning/index.d.ts",
-      "import": "./dist/src/learning/index.js"
+      "import": "./dist/src/learning/index.js",
+      "default": "./dist/src/learning/index.js"
     },
     "./billing": {
       "types": "./dist/src/billing/index.d.ts",
-      "import": "./dist/src/billing/index.js"
+      "import": "./dist/src/billing/index.js",
+      "default": "./dist/src/billing/index.js"
     }
   },
   "scripts": {
@@ -81,12 +87,10 @@
     "url": "https://github.com/smith-horn/skillsmith/issues"
   },
   "keywords": [
-    "claude",
     "ai",
     "skills",
     "mcp",
-    "llm",
-    "anthropic"
+    "llm"
   ],
   "engines": {
     "node": ">=22.0.0"

package/dist/tests/db/driver-parity.integration.test.d.ts

@@ -1,16 +0,0 @@
-/**
- * SMI-2180: Database Driver Parity Integration Tests
- *
- * Ensures end-to-end parity between better-sqlite3 and sql.js drivers
- * by running identical operations on SkillRepository with both drivers.
- *
- * Tests cover:
- * - CRUD operations
- * - Transactions and rollback behavior
- * - Prepared statement reuse
- * - Search operations
- * - Batch insertions
- * - Edge cases and error handling
- */
-export {};
-//# sourceMappingURL=driver-parity.integration.test.d.ts.map

package/dist/tests/db/driver-parity.integration.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"driver-parity.integration.test.d.ts","sourceRoot":"","sources":["../../../tests/db/driver-parity.integration.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}