@skillsmith/core 0.4.16 → 0.5.0

package/dist/tests/db/migration.test.js

@@ -0,0 +1,265 @@
+/**
+ * SMI-3416: Database Migration Utility Tests
+ *
+ * Tests for migration.ts:
+ * - checkSchemaCompatibility: version detection and compatibility
+ * - ensureSchemaCompatibility: auto-upgrade/warning/error
+ * - mergeSkillDatabases: three-way skill merge with strategies
+ * - getSyncStatus / updateSyncStatus / recordSyncRun / getSyncHistory
+ */
+import { describe, it, expect, afterEach } from 'vitest';
+import { createDatabase, closeDatabase, getSchemaVersion, SCHEMA_VERSION, } from '../../src/db/schema.js';
+import { checkSchemaCompatibility, ensureSchemaCompatibility, mergeSkillDatabases, getSyncStatus, recordSyncRun, getSyncHistory, } from '../../src/db/migration.js';
+// ============================================================================
+// Test helpers
+// ============================================================================
+const testDatabases = [];
+function createTestDb() {
+    const db = createDatabase(':memory:');
+    // Add columns that migrations v2+ would add (createDatabase stamps SCHEMA_VERSION
+    // but uses base DDL which doesn't include ALTER TABLE columns)
+    try {
+        db.exec('ALTER TABLE skills ADD COLUMN source TEXT');
+    }
+    catch {
+        // Column may already exist
+    }
+    try {
+        db.exec('ALTER TABLE skills ADD COLUMN stars INTEGER');
+    }
+    catch {
+        // Column may already exist
+    }
+    // Ensure sync tables exist (migration v3)
+    db.exec(`
+    CREATE TABLE IF NOT EXISTS sync_config (
+      id TEXT PRIMARY KEY DEFAULT 'default',
+      last_sync_at TEXT,
+      next_sync_at TEXT,
+      last_sync_count INTEGER DEFAULT 0,
+      last_sync_error TEXT,
+      updated_at TEXT DEFAULT (datetime('now'))
+    );
+    INSERT OR IGNORE INTO sync_config (id) VALUES ('default');
+    CREATE TABLE IF NOT EXISTS sync_history (
+      id TEXT PRIMARY KEY,
+      started_at TEXT NOT NULL,
+      completed_at TEXT,
+      status TEXT NOT NULL CHECK (status IN ('running', 'success', 'failed', 'partial')),
+      skills_added INTEGER DEFAULT 0,
+      skills_updated INTEGER DEFAULT 0,
+      skills_unchanged INTEGER DEFAULT 0,
+      error_message TEXT,
+      duration_ms INTEGER
+    );
+  `);
+    testDatabases.push(db);
+    return db;
+}
+function insertSkill(db, id, overrides) {
+    db.prepare(`INSERT INTO skills (id, name, description, author, repo_url, quality_score,
+                        trust_tier, tags, created_at, updated_at, source, stars)
+     VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`).run(id, overrides?.name ?? `skill-${id}`, 'Test skill', 'test-author', `https://github.com/test/${id}`, 0.8, overrides?.trust_tier ?? 'community', overrides?.tags ?? '["test"]', '2026-01-01T00:00:00Z', overrides?.updated_at ?? '2026-01-01T00:00:00Z', 'github', 10);
+}
+afterEach(() => {
+    for (const db of testDatabases) {
+        try {
+            closeDatabase(db);
+        }
+        catch {
+            // ignore
+        }
+    }
+    testDatabases.length = 0;
+});
+// ============================================================================
+// checkSchemaCompatibility
+// ============================================================================
+describe('checkSchemaCompatibility', () => {
+    it('should return compatible + none when schema is current', () => {
+        const db = createTestDb();
+        const result = checkSchemaCompatibility(db);
+        expect(result.isCompatible).toBe(true);
+        expect(result.action).toBe('none');
+        expect(result.currentVersion).toBe(SCHEMA_VERSION);
+    });
+    it('should return compatible + upgrade when schema is older', () => {
+        const db = createTestDb();
+        // Manually downgrade schema version
+        db.prepare('UPDATE schema_version SET version = ?').run(SCHEMA_VERSION - 1);
+        const result = checkSchemaCompatibility(db);
+        expect(result.isCompatible).toBe(true);
+        expect(result.action).toBe('upgrade');
+        expect(result.currentVersion).toBe(SCHEMA_VERSION - 1);
+        expect(result.expectedVersion).toBe(SCHEMA_VERSION);
+    });
+    it('should return downgrade_warning when schema is newer (no breaking changes)', () => {
+        const db = createTestDb();
+        // Manually bump schema version beyond current
+        db.prepare('UPDATE schema_version SET version = ?').run(SCHEMA_VERSION + 1);
+        const result = checkSchemaCompatibility(db);
+        expect(result.currentVersion).toBe(SCHEMA_VERSION + 1);
+        // Could be downgrade_warning or incompatible depending on migration content
+        expect(['downgrade_warning', 'incompatible']).toContain(result.action);
+    });
+});
+// ============================================================================
+// ensureSchemaCompatibility
+// ============================================================================
+describe('ensureSchemaCompatibility', () => {
+    it('should do nothing when schema is current', () => {
+        const db = createTestDb();
+        expect(() => ensureSchemaCompatibility(db)).not.toThrow();
+        expect(getSchemaVersion(db)).toBe(SCHEMA_VERSION);
+    });
+    it('should throw for incompatible schema', () => {
+        const db = createTestDb();
+        // Set to a very high version that likely has breaking migrations
+        db.prepare('UPDATE schema_version SET version = ?').run(9999);
+        // This may or may not throw depending on migration content
+        // At minimum, it should not crash
+        try {
+            ensureSchemaCompatibility(db);
+        }
+        catch (e) {
+            expect(e.message).toContain('incompatible');
+        }
+    });
+});
+// ============================================================================
+// mergeSkillDatabases
+// ============================================================================
+describe('mergeSkillDatabases', () => {
+    it('should add new skills from source', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(source, 'skill-1');
+        insertSkill(source, 'skill-2');
+        const result = mergeSkillDatabases(target, source);
+        expect(result.skillsAdded).toBe(2);
+        expect(result.skillsUpdated).toBe(0);
+        expect(result.conflicts).toHaveLength(0);
+    });
+    it('should handle keep_newer strategy (source newer)', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(target, 'skill-1', { updated_at: '2026-01-01T00:00:00Z' });
+        insertSkill(source, 'skill-1', { updated_at: '2026-03-01T00:00:00Z' });
+        const result = mergeSkillDatabases(target, source, { strategy: 'keep_newer' });
+        expect(result.skillsUpdated).toBe(1);
+        expect(result.conflicts).toHaveLength(1);
+        expect(result.conflicts[0].resolution).toBe('updated');
+    });
+    it('should handle keep_newer strategy (target newer)', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(target, 'skill-1', { updated_at: '2026-03-01T00:00:00Z' });
+        insertSkill(source, 'skill-1', { updated_at: '2026-01-01T00:00:00Z' });
+        const result = mergeSkillDatabases(target, source, { strategy: 'keep_newer' });
+        expect(result.skillsSkipped).toBe(1);
+        expect(result.conflicts[0].resolution).toBe('kept_target');
+    });
+    it('should handle keep_target strategy', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(target, 'skill-1');
+        insertSkill(source, 'skill-1', { name: 'updated-name' });
+        const result = mergeSkillDatabases(target, source, { strategy: 'keep_target' });
+        expect(result.skillsSkipped).toBe(1);
+    });
+    it('should handle keep_source strategy', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(target, 'skill-1');
+        insertSkill(source, 'skill-1', { name: 'source-name' });
+        const result = mergeSkillDatabases(target, source, { strategy: 'keep_source' });
+        expect(result.skillsUpdated).toBe(1);
+    });
+    it('should handle merge_fields strategy', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(target, 'skill-1', { name: 'target-name', trust_tier: 'unknown' });
+        insertSkill(source, 'skill-1', { name: '', trust_tier: 'verified' });
+        const result = mergeSkillDatabases(target, source, { strategy: 'merge_fields' });
+        expect(result.skillsUpdated).toBe(1);
+    });
+    it('should support dry run', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        insertSkill(source, 'skill-new');
+        const result = mergeSkillDatabases(target, source, { strategy: 'keep_newer', dryRun: true });
+        expect(result.skillsAdded).toBe(1);
+        // Verify nothing was actually inserted
+        const count = target.prepare('SELECT COUNT(*) as c FROM skills').get();
+        expect(count.c).toBe(0);
+    });
+    it('should report duration', () => {
+        const target = createTestDb();
+        const source = createTestDb();
+        const result = mergeSkillDatabases(target, source);
+        expect(result.duration).toBeGreaterThanOrEqual(0);
+    });
+});
+// ============================================================================
+// Sync utilities
+// ============================================================================
+describe('getSyncStatus', () => {
+    it('should return skill count and null sync times when no config', () => {
+        const db = createTestDb();
+        insertSkill(db, 'skill-1');
+        const status = getSyncStatus(db);
+        expect(status.skillsInLocal).toBe(1);
+        expect(status.pendingUploads).toBe(0);
+        expect(status.pendingDownloads).toBe(0);
+    });
+});
+describe('recordSyncRun', () => {
+    it('should insert a sync history record', () => {
+        const db = createTestDb();
+        const id = recordSyncRun(db, 'success', {
+            skillsAdded: 3,
+            skillsUpdated: 1,
+            skillsSkipped: 0,
+            conflicts: [],
+            duration: 200,
+        });
+        expect(id).toMatch(/^sync_/);
+        const history = getSyncHistory(db, 1);
+        expect(history).toHaveLength(1);
+        expect(history[0].status).toBe('success');
+        expect(history[0].skills_added).toBe(3);
+    });
+    it('should record running state with null completed_at', () => {
+        const db = createTestDb();
+        recordSyncRun(db, 'running');
+        const history = getSyncHistory(db, 1);
+        expect(history[0].status).toBe('running');
+        expect(history[0].completed_at).toBeNull();
+    });
+    it('should record error message for failed runs', () => {
+        const db = createTestDb();
+        recordSyncRun(db, 'failed', undefined, 'Connection refused');
+        const history = getSyncHistory(db, 1);
+        expect(history[0].status).toBe('failed');
+        expect(history[0].error_message).toBe('Connection refused');
+    });
+});
+describe('getSyncHistory', () => {
+    it('should return entries ordered by most recent first', () => {
+        const db = createTestDb();
+        recordSyncRun(db, 'success');
+        // Small delay to ensure different timestamps
+        recordSyncRun(db, 'failed', undefined, 'error');
+        const history = getSyncHistory(db, 10);
+        expect(history.length).toBe(2);
+    });
+    it('should respect limit parameter', () => {
+        const db = createTestDb();
+        recordSyncRun(db, 'success');
+        recordSyncRun(db, 'success');
+        recordSyncRun(db, 'success');
+        const history = getSyncHistory(db, 2);
+        expect(history).toHaveLength(2);
+    });
+});
+//# sourceMappingURL=migration.test.js.map

package/dist/tests/db/migration.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"migration.test.js","sourceRoot":"","sources":["../../../tests/db/migration.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAA;AACxD,OAAO,EACL,cAAc,EACd,aAAa,EACb,gBAAgB,EAChB,cAAc,GACf,MAAM,wBAAwB,CAAA;AAE/B,OAAO,EACL,wBAAwB,EACxB,yBAAyB,EACzB,mBAAmB,EACnB,aAAa,EACb,aAAa,EACb,cAAc,GACf,MAAM,2BAA2B,CAAA;AAElC,+EAA+E;AAC/E,eAAe;AACf,+EAA+E;AAE/E,MAAM,aAAa,GAAe,EAAE,CAAA;AAEpC,SAAS,YAAY;IACnB,MAAM,EAAE,GAAG,cAAc,CAAC,UAAU,CAAC,CAAA;IACrC,kFAAkF;IAClF,+DAA+D;IAC/D,IAAI,CAAC;QACH,EAAE,CAAC,IAAI,CAAC,2CAA2C,CAAC,CAAA;IACtD,CAAC;IAAC,MAAM,CAAC;QACP,2BAA2B;IAC7B,CAAC;IACD,IAAI,CAAC;QACH,EAAE,CAAC,IAAI,CAAC,6CAA6C,CAAC,CAAA;IACxD,CAAC;IAAC,MAAM,CAAC;QACP,2BAA2B;IAC7B,CAAC;IACD,0CAA0C;IAC1C,EAAE,CAAC,IAAI,CAAC;;;;;;;;;;;;;;;;;;;;;GAqBP,CAAC,CAAA;IACF,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IACtB,OAAO,EAAE,CAAA;AACX,CAAC;AAED,SAAS,WAAW,CAClB,EAAY,EACZ,EAAU,EACV,SAKE;IAEF,EAAE,CAAC,OAAO,CACR;;iDAE6C,CAC9C,CAAC,GAAG,CACH,EAAE,EACF,SAAS,EAAE,IAAI,IAAI,SAAS,EAAE,EAAE,EAChC,YAAY,EACZ,aAAa,EACb,2BAA2B,EAAE,EAAE,EAC/B,GAAG,EACH,SAAS,EAAE,UAAU,IAAI,WAAW,EACpC,SAAS,EAAE,IAAI,IAAI,UAAU,EAC7B,sBAAsB,EACtB,SAAS,EAAE,UAAU,IAAI,sBAAsB,EAC/C,QAAQ,EACR,EAAE,CACH,CAAA;AACH,CAAC;AAED,SAAS,CAAC,GAAG,EAAE;IACb,KAAK,MAAM,EAAE,IAAI,aAAa,EAAE,CAAC;QAC/B,IAAI,CAAC;YACH,aAAa,CAAC,EAAE,CAAC,CAAA;QACnB,CAAC;QAAC,MAAM,CAAC;YACP,SAAS;QACX,CAAC;IACH,CAAC;IACD,aAAa,CAAC,MAAM,GAAG,CAAC,CAAA;AAC1B,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,2BAA2B;AAC3B,+EAA+E;AAE/E,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IACxC,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QAChE,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,MAAM,MAAM,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,oCAAoC;QACpC,EAAE,CAAC,OAAO,CAAC,uCAAuC,CAAC,CAAC,GAAG,CAAC,cAAc,GAAG,CAAC,CAAC,CAAA;QAE3E,MAAM,MAAM,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACrC,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,cAAc,GAAG,CAAC,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACrD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4EAA4E,EAAE,GAAG,EAAE;QACpF,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,8CAA8C;QAC9C,EAAE,CAAC,OAAO,CAAC,uCAAuC,CAAC,CAAC,GAAG,CAAC,cAAc,GAAG,CAAC,CAAC,CAAA;QAE3E,MAAM,MAAM,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,cAAc,GAAG,CAAC,CAAC,CAAA;QACtD,4EAA4E;QAC5E,MAAM,CAAC,CAAC,mBAAmB,EAAE,cAAc,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC,CAAA;IACxE,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,4BAA4B;AAC5B,+EAA+E;AAE/E,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IACzC,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QAClD,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,MAAM,CAAC,GAAG,EAAE,CAAC,yBAAyB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;QACzD,MAAM,CAAC,gBAAgB,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACnD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;QAC9C,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,iEAAiE;QACjE,EAAE,CAAC,OAAO,CAAC,uCAAuC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;QAE7D,2DAA2D;QAC3D,kCAAkC;QAClC,IAAI,CAAC;YACH,yBAAyB,CAAC,EAAE,CAAC,CAAA;QAC/B,CAAC;QAAC,OAAO,CAAC,EAAE,CAAC;YACX,MAAM,CAAE,CAAW,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,cAAc,CAAC,CAAA;QACxD,CAAC;IACH,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,sBAAsB;AACtB,+EAA+E;AAE/E,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;IACnC,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC3C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;QAC9B,WAAW,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;QAE9B,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACpC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,kDAAkD,EAAE,GAAG,EAAE;QAC1D,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,UAAU,EAAE,sBAAsB,EAAE,CAAC,CAAA;QACtE,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,UAAU,EAAE,sBAAsB,EAAE,CAAC,CAAA;QAEtE,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,YAAY,EAAE,CAAC,CAAA;QAC9E,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACpC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,kDAAkD,EAAE,GAAG,EAAE;QAC1D,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,UAAU,EAAE,sBAAsB,EAAE,CAAC,CAAA;QACtE,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,UAAU,EAAE,sBAAsB,EAAE,CAAC,CAAA;QAEtE,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,YAAY,EAAE,CAAC,CAAA;QAC9E,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACpC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;IAC5D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;QAC9B,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,CAAC,CAAA;QAExD,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,aAAa,EAAE,CAAC,CAAA;QAC/E,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;QAC9B,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,CAAA;QAEvD,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,aAAa,EAAE,CAAC,CAAA;QAC/E,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,UAAU,EAAE,SAAS,EAAE,CAAC,CAAA;QAC9E,WAAW,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,UAAU,EAAE,UAAU,EAAE,CAAC,CAAA;QAEpE,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,CAAC,CAAA;QAChF,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wBAAwB,EAAE,GAAG,EAAE;QAChC,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,WAAW,CAAC,MAAM,EAAE,WAAW,CAAC,CAAA;QAEhC,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,YAAY,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAA;QAC5F,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAElC,uCAAuC;QACvC,MAAM,KAAK,GAAG,MAAM,CAAC,OAAO,CAAC,kCAAkC,CAAC,CAAC,GAAG,EAAmB,CAAA;QACvF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACzB,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wBAAwB,EAAE,GAAG,EAAE;QAChC,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAC7B,MAAM,MAAM,GAAG,YAAY,EAAE,CAAA;QAE7B,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;IACnD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,iBAAiB;AACjB,+EAA+E;AAE/E,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,WAAW,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAE1B,MAAM,MAAM,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QAChC,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACpC,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACrC,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACzC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,MAAM,EAAE,GAAG,aAAa,CAAC,EAAE,EAAE,SAAS,EAAE;YACtC,WAAW,EAAE,CAAC;YACd,aAAa,EAAE,CAAC;YAChB,aAAa,EAAE,CAAC;YAChB,SAAS,EAAE,EAAE;YACb,QAAQ,EAAE,GAAG;SACd,CAAC,CAAA;QAEF,MAAM,CAAC,EAAE,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAA;QAC5B,MAAM,OAAO,GAAG,cAAc,CAAC,EAAE,EAAE,CAAC,CAAC,CAAA;QACrC,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAC/B,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACzC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACzC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,aAAa,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAE5B,MAAM,OAAO,GAAG,cAAc,CAAC,EAAE,EAAE,CAAC,CAAC,CAAA;QACrC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACzC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,QAAQ,EAAE,CAAA;IAC5C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACrD,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,aAAa,CAAC,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE,oBAAoB,CAAC,CAAA;QAE5D,MAAM,OAAO,GAAG,cAAc,CAAC,EAAE,EAAE,CAAC,CAAC,CAAA;QACrC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACxC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAA;IAC7D,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,gBAAgB,EAAE,GAAG,EAAE;IAC9B,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,aAAa,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAC5B,6CAA6C;QAC7C,aAAa,CAAC,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE,OAAO,CAAC,CAAA;QAE/C,MAAM,OAAO,GAAG,cAAc,CAAC,EAAE,EAAE,EAAE,CAAC,CAAA;QACtC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAChC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gCAAgC,EAAE,GAAG,EAAE;QACxC,MAAM,EAAE,GAAG,YAAY,EAAE,CAAA;QACzB,aAAa,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAC5B,aAAa,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAC5B,aAAa,CAAC,EAAE,EAAE,SAAS,CAAC,CAAA;QAE5B,MAAM,OAAO,GAAG,cAAc,CAAC,EAAE,EAAE,CAAC,CAAC,CAAA;QACrC,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;IACjC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/db/schema-migrations.test.js

@@ -65,14 +65,16 @@ describe('runMigrationsSafe', () => {
     });
     it.skipIf(skipIfNoSqlite)('runs pending migrations and records version increments', async () => {
         const db = await freshDb();
-        // Pin version to 1 (initial migration) to force re-running pending ones
-        // We need to delete all recorded versions above 1 to simulate pending state.
+        // Delete all version records to simulate a completely unversioned database.
+        // initializeSchema() stamped SCHEMA_VERSION but never recorded individual
+        // migration versions. Clearing the table forces all migrations to re-run.
         // Since the schema already has all columns, duplicate column errors are swallowed.
-        db.exec('DELETE FROM schema_version WHERE version > 1');
+        db.exec('DELETE FROM schema_version');
         const migrationsRun = runMigrationsSafe(db);
-        // Should have run migrations 2 through SCHEMA_VERSION
-        const expectedRun = SCHEMA_VERSION - 1;
-        expect(migrationsRun).toBe(expectedRun);
+        // All MIGRATIONS entries should have been applied (versions 1 through SCHEMA_VERSION).
+        // SMI-3910: migration-runner now uses db.exec() directly instead of splitting
+        // by semicolon, so migration 1 (SCHEMA_SQL with trigger bodies) succeeds.
+        expect(migrationsRun).toBe(MIGRATIONS.length);
         // Version should now be up to date
         const finalVersion = getSchemaVersion(db);
         expect(finalVersion).toBe(SCHEMA_VERSION);

package/dist/tests/db/schema-migrations.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"schema-migrations.test.js","sourceRoot":"","sources":["../../../tests/db/schema-migrations.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAA;AACxD,OAAO,EACL,mBAAmB,EACnB,iBAAiB,EACjB,aAAa,EACb,gBAAgB,EAChB,cAAc,EACd,UAAU,GACX,MAAM,wBAAwB,CAAA;AAE/B,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AAEtF,oEAAoE;AACpE,mEAAmE;AACnE,MAAM,cAAc,GAAG,CAAC,wBAAwB,EAAE,CAAA;AAElD,MAAM,aAAa,GAAe,EAAE,CAAA;AAEpC,SAAS,CAAC,GAAG,EAAE;IACb,KAAK,MAAM,EAAE,IAAI,aAAa,EAAE,CAAC;QAC/B,IAAI,EAAE,CAAC,IAAI,EAAE,CAAC;YACZ,aAAa,CAAC,EAAE,CAAC,CAAA;QACnB,CAAC;IACH,CAAC;IACD,aAAa,CAAC,MAAM,GAAG,CAAC,CAAA;AAC1B,CAAC,CAAC,CAAA;AAEF,mCAAmC;AACnC,KAAK,UAAU,OAAO;IACpB,MAAM,EAAE,GAAG,MAAM,mBAAmB,CAAC,UAAU,CAAC,CAAA;IAChD,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IACtB,OAAO,EAAE,CAAA;AACX,CAAC;AAED,+EAA+E;AAC/E,oBAAoB;AACpB,+EAA+E;AAE/E,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,qEAAqE,EACrE,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,+EAA+E;QAC/E,8EAA8E;QAC9E,8CAA8C;QAC9C,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,4DAA4D,EAC5D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,6DAA6D;QAC7D,EAAE,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAA;QACrC,EAAE,CAAC,OAAO,CAAC,iDAAiD,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAA;QAEpE,kFAAkF;QAClF,iFAAiF;QACjF,4DAA4D;QAC5D,gFAAgF;QAChF,sFAAsF;QACtF,6EAA6E;QAC7E,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,4DAA4D,EAC5D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,wEAAwE;QACxE,4EAA4E;QAC5E,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,8DAA8D;QAC9D,MAAM,KAAK,GAAG,iBAAiB,CAAC,EAAE,CAAC,CAAA;QAEnC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA,CAAC,iCAAiC;IACzD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QAC7F,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,wEAAwE;QACxE,6EAA6E;QAC7E,mFAAmF;QACnF,EAAE,CAAC,IAAI,CAAC,8CAA8C,CAAC,CAAA;QAEvD,MAAM,aAAa,GAAG,iBAAiB,CAAC,EAAE,CAAC,CAAA;QAE3C,sDAAsD;QACtD,MAAM,WAAW,GAAG,cAAc,GAAG,CAAC,CAAA;QACtC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;QAEvC,mCAAmC;QACnC,MAAM,YAAY,GAAG,gBAAgB,CAAC,EAAE,CAAC,CAAA;QACzC,MAAM,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,gBAAgB;AAChB,+EAA+E;AAE/E,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,EAAE,GAAG,MAAM,mBAAmB,CAAC,UAAU,CAAC,CAAA;QAChD,sDAAsD;QAEtD,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1B,MAAM,CAAC,GAAG,EAAE,CAAC,aAAa,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;QAC7C,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IAC7B,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,8CAA8C;AAC9C,+EAA+E;AAE/E,QAAQ,CAAC,6CAA6C,EAAE,GAAG,EAAE;IAC3D,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,0DAA0D,EAC1D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,MAAM,OAAO,GAAG,gBAAgB,CAAC,EAAE,CAAC,CAAA;QACpC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACtC,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,0DAA0D,EAC1D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,MAAM,MAAM,GAAG,EAAE;aACd,OAAO,CACN;;uBAEa,CACd;aACA,GAAG,EAAwB,CAAA;QAE9B,MAAM,UAAU,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;QAC5C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAA;QAC9C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAA;QACtC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAA;QACvC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;QAC1C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAA;QACrC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;IAC5C,CAAC,CACF,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,sCAAsC;AACtC,+EAA+E;AAE/E,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,IAAI,IAAI,GAAG,CAAC,CAAA;QACZ,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YAC3B,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YACvC,IAAI,GAAG,CAAC,CAAC,OAAO,CAAA;QAClB,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,aAAa,GAAG,UAAU,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;QACvD,MAAM,CAAC,aAAa,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}
+{"version":3,"file":"schema-migrations.test.js","sourceRoot":"","sources":["../../../tests/db/schema-migrations.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAA;AACxD,OAAO,EACL,mBAAmB,EACnB,iBAAiB,EACjB,aAAa,EACb,gBAAgB,EAChB,cAAc,EACd,UAAU,GACX,MAAM,wBAAwB,CAAA;AAE/B,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AAEtF,oEAAoE;AACpE,mEAAmE;AACnE,MAAM,cAAc,GAAG,CAAC,wBAAwB,EAAE,CAAA;AAElD,MAAM,aAAa,GAAe,EAAE,CAAA;AAEpC,SAAS,CAAC,GAAG,EAAE;IACb,KAAK,MAAM,EAAE,IAAI,aAAa,EAAE,CAAC;QAC/B,IAAI,EAAE,CAAC,IAAI,EAAE,CAAC;YACZ,aAAa,CAAC,EAAE,CAAC,CAAA;QACnB,CAAC;IACH,CAAC;IACD,aAAa,CAAC,MAAM,GAAG,CAAC,CAAA;AAC1B,CAAC,CAAC,CAAA;AAEF,mCAAmC;AACnC,KAAK,UAAU,OAAO;IACpB,MAAM,EAAE,GAAG,MAAM,mBAAmB,CAAC,UAAU,CAAC,CAAA;IAChD,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IACtB,OAAO,EAAE,CAAA;AACX,CAAC;AAED,+EAA+E;AAC/E,oBAAoB;AACpB,+EAA+E;AAE/E,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,qEAAqE,EACrE,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,+EAA+E;QAC/E,8EAA8E;QAC9E,8CAA8C;QAC9C,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,4DAA4D,EAC5D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,6DAA6D;QAC7D,EAAE,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAA;QACrC,EAAE,CAAC,OAAO,CAAC,iDAAiD,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAA;QAEpE,kFAAkF;QAClF,iFAAiF;QACjF,4DAA4D;QAC5D,gFAAgF;QAChF,sFAAsF;QACtF,6EAA6E;QAC7E,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,4DAA4D,EAC5D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,wEAAwE;QACxE,4EAA4E;QAC5E,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;IACnD,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,8DAA8D;QAC9D,MAAM,KAAK,GAAG,iBAAiB,CAAC,EAAE,CAAC,CAAA;QAEnC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA,CAAC,iCAAiC;IACzD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QAC7F,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,4EAA4E;QAC5E,0EAA0E;QAC1E,0EAA0E;QAC1E,mFAAmF;QACnF,EAAE,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAA;QAErC,MAAM,aAAa,GAAG,iBAAiB,CAAC,EAAE,CAAC,CAAA;QAE3C,uFAAuF;QACvF,8EAA8E;QAC9E,0EAA0E;QAC1E,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,CAAA;QAE7C,mCAAmC;QACnC,MAAM,YAAY,GAAG,gBAAgB,CAAC,EAAE,CAAC,CAAA;QACzC,MAAM,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,gBAAgB;AAChB,+EAA+E;AAE/E,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,EAAE,GAAG,MAAM,mBAAmB,CAAC,UAAU,CAAC,CAAA;QAChD,sDAAsD;QAEtD,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1B,MAAM,CAAC,GAAG,EAAE,CAAC,aAAa,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAA;QAC7C,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IAC7B,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,8CAA8C;AAC9C,+EAA+E;AAE/E,QAAQ,CAAC,6CAA6C,EAAE,GAAG,EAAE;IAC3D,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,0DAA0D,EAC1D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,MAAM,OAAO,GAAG,gBAAgB,CAAC,EAAE,CAAC,CAAA;QACpC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACtC,CAAC,CACF,CAAA;IAED,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CACvB,0DAA0D,EAC1D,KAAK,IAAI,EAAE;QACT,MAAM,EAAE,GAAG,MAAM,OAAO,EAAE,CAAA;QAE1B,MAAM,MAAM,GAAG,EAAE;aACd,OAAO,CACN;;uBAEa,CACd;aACA,GAAG,EAAwB,CAAA;QAE9B,MAAM,UAAU,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;QAC5C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAA;QAC9C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAA;QACtC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAA;QACvC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;QAC1C,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAA;QACrC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;IAC5C,CAAC,CACF,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,sCAAsC;AACtC,+EAA+E;AAE/E,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,IAAI,IAAI,GAAG,CAAC,CAAA;QACZ,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YAC3B,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YACvC,IAAI,GAAG,CAAC,CAAC,OAAO,CAAA;QAClB,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,aAAa,GAAG,UAAU,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;QACvD,MAAM,CAAC,aAAa,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/integration/events-batch-contract.test.d.ts

@@ -0,0 +1,12 @@
+/**
+ * SMI-4119 / C3: Contract test pinning the `/events` response shapes.
+ *
+ * **Backward compat guardrail**: the single-event POST body MUST continue to
+ * return `{ ok: true }` byte-identical — no `accepted`/`rejected`/`errors`
+ * leakage from the batch path. Any drift here breaks old `@skillsmith/core`
+ * clients in the wild.
+ *
+ * We pin the schemas exposed by `@skillsmith/core` to guard both shapes.
+ */
+export {};
+//# sourceMappingURL=events-batch-contract.test.d.ts.map

package/dist/tests/integration/events-batch-contract.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"events-batch-contract.test.d.ts","sourceRoot":"","sources":["../../../tests/integration/events-batch-contract.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG"}

package/dist/tests/integration/events-batch-contract.test.js

@@ -0,0 +1,69 @@
+/**
+ * SMI-4119 / C3: Contract test pinning the `/events` response shapes.
+ *
+ * **Backward compat guardrail**: the single-event POST body MUST continue to
+ * return `{ ok: true }` byte-identical — no `accepted`/`rejected`/`errors`
+ * leakage from the batch path. Any drift here breaks old `@skillsmith/core`
+ * clients in the wild.
+ *
+ * We pin the schemas exposed by `@skillsmith/core` to guard both shapes.
+ */
+import { describe, it, expect } from 'vitest';
+import { TelemetryResponseSchema, TelemetryBatchResponseSchema, TelemetryEventBatchSchema, } from '../../src/api/schemas.js';
+describe('SMI-4119 / C3: events endpoint response contracts', () => {
+    it('single-event response is exactly `{ ok: true }` (no batch fields leak)', () => {
+        const raw = { data: { ok: true } };
+        const parsed = TelemetryResponseSchema.safeParse(raw);
+        expect(parsed.success).toBe(true);
+        // Byte-identical: JSON serialized form must have no unexpected keys.
+        const body = { ok: true };
+        expect(JSON.stringify(body)).toBe('{"ok":true}');
+        // Keys are exactly ['ok'] — pin so future refactors don't silently widen.
+        expect(Object.keys(body)).toEqual(['ok']);
+    });
+    it('batch response carries `{ok, accepted, rejected}` and optional `errors`', () => {
+        const ok = TelemetryBatchResponseSchema.safeParse({
+            ok: true,
+            accepted: 3,
+            rejected: 0,
+        });
+        expect(ok.success).toBe(true);
+        const withErrors = TelemetryBatchResponseSchema.safeParse({
+            ok: true,
+            accepted: 2,
+            rejected: 1,
+            errors: [{ index: 1, reason: 'invalid_anonymous_id' }],
+        });
+        expect(withErrors.success).toBe(true);
+    });
+    it('batch request schema enforces 1..=20 events', () => {
+        const tooFew = TelemetryEventBatchSchema.safeParse({ events: [] });
+        expect(tooFew.success).toBe(false);
+        const tooMany = TelemetryEventBatchSchema.safeParse({
+            events: Array.from({ length: 21 }, () => ({
+                event: 'skill_view',
+                anonymous_id: 'a'.repeat(16),
+            })),
+        });
+        expect(tooMany.success).toBe(false);
+        const justRight = TelemetryEventBatchSchema.safeParse({
+            events: Array.from({ length: 20 }, () => ({
+                event: 'skill_view',
+                anonymous_id: 'a'.repeat(16),
+            })),
+        });
+        expect(justRight.success).toBe(true);
+    });
+    it('rate-limited batch response shape is pinned (SMI-4119 / C1)', () => {
+        // Shape produced by events/index.ts when checkRateLimit rejects a batch:
+        const body = {
+            ok: false,
+            accepted: 0,
+            rejected: 5,
+            errors: [{ index: -1, reason: 'rate_limited' }],
+        };
+        const parsed = TelemetryBatchResponseSchema.safeParse(body);
+        expect(parsed.success).toBe(true);
+    });
+});
+//# sourceMappingURL=events-batch-contract.test.js.map

package/dist/tests/integration/events-batch-contract.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"events-batch-contract.test.js","sourceRoot":"","sources":["../../../tests/integration/events-batch-contract.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAA;AAC7C,OAAO,EACL,uBAAuB,EACvB,4BAA4B,EAC5B,yBAAyB,GAC1B,MAAM,0BAA0B,CAAA;AAEjC,QAAQ,CAAC,mDAAmD,EAAE,GAAG,EAAE;IACjE,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;QAChF,MAAM,GAAG,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,CAAA;QAClC,MAAM,MAAM,GAAG,uBAAuB,CAAC,SAAS,CAAC,GAAG,CAAC,CAAA;QACrD,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAEjC,qEAAqE;QACrE,MAAM,IAAI,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,CAAA;QACzB,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;QAChD,0EAA0E;QAC1E,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QACjF,MAAM,EAAE,GAAG,4BAA4B,CAAC,SAAS,CAAC;YAChD,EAAE,EAAE,IAAI;YACR,QAAQ,EAAE,CAAC;YACX,QAAQ,EAAE,CAAC;SACZ,CAAC,CAAA;QACF,MAAM,CAAC,EAAE,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAE7B,MAAM,UAAU,GAAG,4BAA4B,CAAC,SAAS,CAAC;YACxD,EAAE,EAAE,IAAI;YACR,QAAQ,EAAE,CAAC;YACX,QAAQ,EAAE,CAAC;YACX,MAAM,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC,EAAE,MAAM,EAAE,sBAAsB,EAAE,CAAC;SACvD,CAAC,CAAA;QACF,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACvC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACrD,MAAM,MAAM,GAAG,yBAAyB,CAAC,SAAS,CAAC,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,CAAA;QAClE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAElC,MAAM,OAAO,GAAG,yBAAyB,CAAC,SAAS,CAAC;YAClD,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,GAAG,EAAE,CAAC,CAAC;gBACxC,KAAK,EAAE,YAAqB;gBAC5B,YAAY,EAAE,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;aAC7B,CAAC,CAAC;SACJ,CAAC,CAAA;QACF,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAEnC,MAAM,SAAS,GAAG,yBAAyB,CAAC,SAAS,CAAC;YACpD,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,GAAG,EAAE,CAAC,CAAC;gBACxC,KAAK,EAAE,YAAqB;gBAC5B,YAAY,EAAE,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;aAC7B,CAAC,CAAC;SACJ,CAAC,CAAA;QACF,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,yEAAyE;QACzE,MAAM,IAAI,GAAG;YACX,EAAE,EAAE,KAAK;YACT,QAAQ,EAAE,CAAC;YACX,QAAQ,EAAE,CAAC;YACX,MAAM,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,cAAc,EAAE,CAAC;SAChD,CAAA;QACD,MAAM,MAAM,GAAG,4BAA4B,CAAC,SAAS,CAAC,IAAI,CAAC,CAAA;QAC3D,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACnC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/scoring/quality-score.test.d.ts

@@ -0,0 +1,7 @@
+/**
+ * Quality Score Tests - SMI-3864
+ *
+ * Tests the canonical computeQualityScore function.
+ */
+export {};
+//# sourceMappingURL=quality-score.test.d.ts.map

package/dist/tests/scoring/quality-score.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality-score.test.d.ts","sourceRoot":"","sources":["../../../tests/scoring/quality-score.test.ts"],"names":[],"mappings":"AAAA;;;;GAIG"}

package/dist/tests/scoring/quality-score.test.js

@@ -0,0 +1,78 @@
+/**
+ * Quality Score Tests - SMI-3864
+ *
+ * Tests the canonical computeQualityScore function.
+ */
+import { describe, it, expect } from 'vitest';
+import { computeQualityScore } from '../../src/scoring/quality-score.js';
+function makeInput(overrides = {}) {
+    return {
+        riskScore: 0,
+        securityFindingsCount: 0,
+        securityPassed: true,
+        description: 'A well-documented skill for testing purposes with plenty of detail',
+        tagCount: 4,
+        hasRepoUrl: true,
+        hasAuthor: true,
+        trustTier: 'verified',
+        hasExamples: true,
+        ...overrides,
+    };
+}
+describe('computeQualityScore (SMI-3864)', () => {
+    it('should return a number between 0 and 1', () => {
+        const score = computeQualityScore(makeInput());
+        expect(score).toBeGreaterThanOrEqual(0);
+        expect(score).toBeLessThanOrEqual(1);
+    });
+    it('should return high score for perfect inputs', () => {
+        const score = computeQualityScore(makeInput({ description: 'A'.repeat(300), tagCount: 5 }));
+        expect(score).toBeGreaterThan(0.85);
+    });
+    it('should return low score for worst-case inputs', () => {
+        const score = computeQualityScore({
+            riskScore: 100,
+            securityFindingsCount: 20,
+            securityPassed: false,
+            description: null,
+            tagCount: 0,
+            hasRepoUrl: false,
+            hasAuthor: false,
+            trustTier: 'unknown',
+            hasExamples: false,
+        });
+        expect(score).toBeLessThan(0.15);
+    });
+    it('should give partial credit when security scan is null', () => {
+        const withScan = computeQualityScore(makeInput({ securityPassed: true }));
+        const withoutScan = computeQualityScore(makeInput({ securityPassed: null, riskScore: null }));
+        expect(withoutScan).toBeLessThan(withScan);
+        expect(withoutScan).toBeGreaterThan(0);
+    });
+    it('should increase score with more tags', () => {
+        const noTags = computeQualityScore(makeInput({ tagCount: 0 }));
+        const someTags = computeQualityScore(makeInput({ tagCount: 4 }));
+        expect(someTags).toBeGreaterThan(noTags);
+    });
+    it('should increase score with examples', () => {
+        const noExamples = computeQualityScore(makeInput({ hasExamples: false }));
+        const withExamples = computeQualityScore(makeInput({ hasExamples: true }));
+        expect(withExamples).toBeGreaterThan(noExamples);
+    });
+    it('should score verified higher than experimental', () => {
+        const verified = computeQualityScore(makeInput({ trustTier: 'verified' }));
+        const experimental = computeQualityScore(makeInput({ trustTier: 'experimental' }));
+        expect(verified).toBeGreaterThan(experimental);
+    });
+    it('should handle null description', () => {
+        const score = computeQualityScore(makeInput({ description: null }));
+        expect(score).toBeGreaterThanOrEqual(0);
+        expect(score).toBeLessThanOrEqual(1);
+    });
+    it('should penalize high risk scores', () => {
+        const lowRisk = computeQualityScore(makeInput({ riskScore: 5 }));
+        const highRisk = computeQualityScore(makeInput({ riskScore: 80 }));
+        expect(lowRisk).toBeGreaterThan(highRisk);
+    });
+});
+//# sourceMappingURL=quality-score.test.js.map

package/dist/tests/scoring/quality-score.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality-score.test.js","sourceRoot":"","sources":["../../../tests/scoring/quality-score.test.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAA;AAC7C,OAAO,EAAE,mBAAmB,EAA0B,MAAM,oCAAoC,CAAA;AAEhG,SAAS,SAAS,CAAC,YAAwC,EAAE;IAC3D,OAAO;QACL,SAAS,EAAE,CAAC;QACZ,qBAAqB,EAAE,CAAC;QACxB,cAAc,EAAE,IAAI;QACpB,WAAW,EAAE,oEAAoE;QACjF,QAAQ,EAAE,CAAC;QACX,UAAU,EAAE,IAAI;QAChB,SAAS,EAAE,IAAI;QACf,SAAS,EAAE,UAAU;QACrB,WAAW,EAAE,IAAI;QACjB,GAAG,SAAS;KACb,CAAA;AACH,CAAC;AAED,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC9C,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,KAAK,GAAG,mBAAmB,CAAC,SAAS,EAAE,CAAC,CAAA;QAC9C,MAAM,CAAC,KAAK,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;QACvC,MAAM,CAAC,KAAK,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACrD,MAAM,KAAK,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,WAAW,EAAE,GAAG,CAAC,MAAM,CAAC,GAAG,CAAC,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;QAC3F,MAAM,CAAC,KAAK,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IACrC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,KAAK,GAAG,mBAAmB,CAAC;YAChC,SAAS,EAAE,GAAG;YACd,qBAAqB,EAAE,EAAE;YACzB,cAAc,EAAE,KAAK;YACrB,WAAW,EAAE,IAAI;YACjB,QAAQ,EAAE,CAAC;YACX,UAAU,EAAE,KAAK;YACjB,SAAS,EAAE,KAAK;YAChB,SAAS,EAAE,SAAS;YACpB,WAAW,EAAE,KAAK;SACnB,CAAC,CAAA;QACF,MAAM,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,QAAQ,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,cAAc,EAAE,IAAI,EAAE,CAAC,CAAC,CAAA;QACzE,MAAM,WAAW,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,cAAc,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC,CAAA;QAC7F,MAAM,CAAC,WAAW,CAAC,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAA;QAC1C,MAAM,CAAC,WAAW,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;QAC9C,MAAM,MAAM,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;QAC9D,MAAM,QAAQ,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;QAChE,MAAM,CAAC,QAAQ,CAAC,CAAC,eAAe,CAAC,MAAM,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,UAAU,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC,CAAC,CAAA;QACzE,MAAM,YAAY,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,CAAC,CAAA;QAC1E,MAAM,CAAC,YAAY,CAAC,CAAC,eAAe,CAAC,UAAU,CAAC,CAAA;IAClD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,QAAQ,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,SAAS,EAAE,UAAU,EAAE,CAAC,CAAC,CAAA;QAC1E,MAAM,YAAY,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,SAAS,EAAE,cAAc,EAAE,CAAC,CAAC,CAAA;QAClF,MAAM,CAAC,QAAQ,CAAC,CAAC,eAAe,CAAC,YAAY,CAAC,CAAA;IAChD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gCAAgC,EAAE,GAAG,EAAE;QACxC,MAAM,KAAK,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,CAAC,CAAA;QACnE,MAAM,CAAC,KAAK,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAA;QACvC,MAAM,CAAC,KAAK,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAA;IACtC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAC1C,MAAM,OAAO,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;QAChE,MAAM,QAAQ,GAAG,mBAAmB,CAAC,SAAS,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,CAAC,CAAC,CAAA;QAClE,MAAM,CAAC,OAAO,CAAC,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/security/ContinuousSecurity.false-positives.test.d.ts

@@ -0,0 +1,6 @@
+/**
+ * SMI-688: Continuous Security Testing - False Positive Prevention
+ * Split from ContinuousSecurity.test.ts (SMI-3879)
+ */
+export {};
+//# sourceMappingURL=ContinuousSecurity.false-positives.test.d.ts.map

package/dist/tests/security/ContinuousSecurity.false-positives.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ContinuousSecurity.false-positives.test.d.ts","sourceRoot":"","sources":["../../../tests/security/ContinuousSecurity.false-positives.test.ts"],"names":[],"mappings":"AAAA;;;GAGG"}

package/dist/tests/security/ContinuousSecurity.false-positives.test.js

@@ -0,0 +1,89 @@
+/**
+ * SMI-688: Continuous Security Testing - False Positive Prevention
+ * Split from ContinuousSecurity.test.ts (SMI-3879)
+ */
+import { describe, it, expect, beforeEach } from 'vitest';
+import { SecurityScanner } from '../../src/security/index.js';
+import * as fs from 'fs';
+import * as path from 'path';
+import { fileURLToPath } from 'url';
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+const fixturesPath = path.join(__dirname, '../fixtures/security');
+const safePrompts = JSON.parse(fs.readFileSync(path.join(fixturesPath, 'safe-prompts.json'), 'utf-8'));
+const edgeCases = JSON.parse(fs.readFileSync(path.join(fixturesPath, 'edge-cases.json'), 'utf-8'));
+const toTestCases = (arr) => arr.map((item) => [item]);
+describe('ContinuousSecurity - False Positive Prevention', () => {
+    let scanner;
+    beforeEach(() => {
+        scanner = new SecurityScanner();
+    });
+    describe('Safe Skill Descriptions', () => {
+        it.each(toTestCases(safePrompts.categories.normalSkillDescriptions))('should not flag normal description: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            expect(report.passed).toBe(true);
+            expect(report.findings.filter((f) => f.severity === 'critical')).toHaveLength(0);
+        });
+    });
+    describe('Technical Content', () => {
+        it.each(toTestCases(safePrompts.categories.technicalContent))('should not flag technical content: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            const criticalFindings = report.findings.filter((f) => f.severity === 'critical');
+            expect(criticalFindings).toHaveLength(0);
+        });
+    });
+    describe('Similar Words (Not Jailbreak)', () => {
+        it.each(toTestCases(safePrompts.categories.mentionsSimilarWords))('should not flag similar but safe words: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            const jailbreakFindings = report.findings.filter((f) => f.type === 'jailbreak');
+            expect(jailbreakFindings).toHaveLength(0);
+        });
+    });
+    describe('Safe URLs', () => {
+        it.each(toTestCases(safePrompts.categories.containsUrls))('should allow safe URLs: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            const urlFindings = report.findings.filter((f) => f.type === 'url');
+            expect(urlFindings).toHaveLength(0);
+        });
+    });
+    describe('Code Examples', () => {
+        it.each(toTestCases(safePrompts.categories.codeExamples))('should handle code examples safely: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            expect(report.passed).toBe(true);
+        });
+    });
+    describe('Markdown Content', () => {
+        it.each(toTestCases(safePrompts.categories.markdownContent))('should handle markdown content safely', (content) => {
+            const report = scanner.scan('test-skill', content);
+            expect(report.passed).toBe(true);
+        });
+    });
+    describe('Long Form Content', () => {
+        it.each(toTestCases(safePrompts.categories.longFormContent))('should handle long form content safely', (content) => {
+            const report = scanner.scan('test-skill', content);
+            expect(report.passed).toBe(true);
+        });
+    });
+    describe('Educational Content', () => {
+        it.each(toTestCases(safePrompts.categories.educationalContent))('should allow educational content: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            expect(report.passed).toBe(true);
+        });
+    });
+    describe('Path False Positives', () => {
+        it.each(toTestCases(edgeCases.categories.pathEdgeCases.falsePositives))('should not flag safe content with similar words: %s', (content) => {
+            const report = scanner.scan('test-skill', content);
+            // Some may still flag depending on patterns, but should not be critical
+            const criticalFindings = report.findings.filter((f) => f.severity === 'critical');
+            expect(criticalFindings).toHaveLength(0);
+        });
+    });
+    describe('Whitespace Edge Cases', () => {
+        it.each(toTestCases(edgeCases.categories.whitespaceEdgeCases))('should handle whitespace variations: %s', (content) => {
+            const report = scanner.scan('test', content);
+            const jailbreakFindings = report.findings.filter((f) => f.type === 'jailbreak');
+            // Multi-word patterns should still be detected with varied whitespace
+            expect(jailbreakFindings.length).toBeGreaterThan(0);
+        });
+    });
+});
+//# sourceMappingURL=ContinuousSecurity.false-positives.test.js.map

package/dist/tests/security/ContinuousSecurity.false-positives.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ContinuousSecurity.false-positives.test.js","sourceRoot":"","sources":["../../../tests/security/ContinuousSecurity.false-positives.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAA;AACzD,OAAO,EAAE,eAAe,EAAE,MAAM,6BAA6B,CAAA;AAC7D,OAAO,KAAK,EAAE,MAAM,IAAI,CAAA;AACxB,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,KAAK,CAAA;AAEnC,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAA;AAC9D,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,sBAAsB,CAAC,CAAA;AAEjE,MAAM,WAAW,GAAG,IAAI,CAAC,KAAK,CAC5B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,mBAAmB,CAAC,EAAE,OAAO,CAAC,CACvE,CAAA;AACD,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,iBAAiB,CAAC,EAAE,OAAO,CAAC,CAAC,CAAA;AAElG,MAAM,WAAW,GAAG,CAAC,GAAa,EAAc,EAAE,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;AAE5E,QAAQ,CAAC,gDAAgD,EAAE,GAAG,EAAE;IAC9D,IAAI,OAAwB,CAAA;IAE5B,UAAU,CAAC,GAAG,EAAE;QACd,OAAO,GAAG,IAAI,eAAe,EAAE,CAAA;IACjC,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;QACvC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,uBAAuB,CAAC,CAAC,CAClE,wCAAwC,EACxC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAClF,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,gBAAgB,CAAC,CAAC,CAC3D,uCAAuC,EACvC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,gBAAgB,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAA;YACjF,MAAM,CAAC,gBAAgB,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAC1C,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;QAC7C,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,oBAAoB,CAAC,CAAC,CAC/D,4CAA4C,EAC5C,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,iBAAiB,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,WAAW,CAAC,CAAA;YAC/E,MAAM,CAAC,iBAAiB,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAC3C,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,WAAW,EAAE,GAAG,EAAE;QACzB,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CACvD,4BAA4B,EAC5B,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,WAAW,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,KAAK,CAAC,CAAA;YACnE,MAAM,CAAC,WAAW,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QACrC,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;QAC7B,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CACvD,wCAAwC,EACxC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAClC,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;QAChC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,CAC1D,uCAAuC,EACvC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAClC,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,CAC1D,wCAAwC,EACxC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAClC,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;QACnC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,UAAU,CAAC,kBAAkB,CAAC,CAAC,CAC7D,sCAAsC,EACtC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAClC,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,sBAAsB,EAAE,GAAG,EAAE;QACpC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,SAAS,CAAC,UAAU,CAAC,aAAa,CAAC,cAA0B,CAAC,CAAC,CACjF,qDAAqD,EACrD,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,YAAY,EAAE,OAAO,CAAC,CAAA;YAElD,wEAAwE;YACxE,MAAM,gBAAgB,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAA;YACjF,MAAM,CAAC,gBAAgB,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAC1C,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;QACrC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,SAAS,CAAC,UAAU,CAAC,mBAA+B,CAAC,CAAC,CACxE,yCAAyC,EACzC,CAAC,OAAO,EAAE,EAAE;YACV,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;YAC5C,MAAM,iBAAiB,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,WAAW,CAAC,CAAA;YAE/E,sEAAsE;YACtE,MAAM,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;QACrD,CAAC,CACF,CAAA;IACH,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}