@skillsmith/core 0.4.13 → 0.4.15

package/dist/tests/unit/quarantine-query-builder.test.js

@@ -0,0 +1,157 @@
+/**
+ * SMI-2755 Wave 2: Quarantine query builder pure-function tests
+ *
+ * Tests for buildFilteredQuery and rowToEntry from
+ * packages/core/src/repositories/quarantine/query-builder.ts.
+ *
+ * No mocking needed — both are pure functions.
+ */
+import { describe, it, expect } from 'vitest';
+import { buildFilteredQuery, rowToEntry } from '../../src/repositories/quarantine/query-builder.js';
+// ============================================================================
+// buildFilteredQuery — filter branch coverage
+// ============================================================================
+describe('buildFilteredQuery', () => {
+    it('returns base WHERE 1=1 query when no filters are provided', () => {
+        const result = buildFilteredQuery({});
+        expect(result.query).toContain('WHERE 1=1');
+        expect(result.countQuery).toContain('WHERE 1=1');
+        // No additional WHERE clauses beyond the base
+        expect(result.query).not.toContain('AND skill_id');
+        expect(result.query).not.toContain('AND source');
+        expect(result.query).not.toContain('AND severity');
+        expect(result.params).toHaveLength(2); // limit + offset are appended
+    });
+    it('appends reviewedBy filter correctly', () => {
+        const result = buildFilteredQuery({ reviewedBy: 'alice' });
+        expect(result.query).toContain('AND reviewed_by = ?');
+        expect(result.countQuery).toContain('AND reviewed_by = ?');
+        expect(result.params).toContain('alice');
+        expect(result.countParams).toContain('alice');
+    });
+    it('appends since date filter correctly', () => {
+        const since = new Date('2025-01-01T00:00:00Z');
+        const result = buildFilteredQuery({ since });
+        expect(result.query).toContain('AND quarantine_date >= ?');
+        expect(result.countQuery).toContain('AND quarantine_date >= ?');
+        expect(result.params).toContain(since.toISOString());
+        expect(result.countParams).toContain(since.toISOString());
+    });
+    it('appends until date filter correctly', () => {
+        const until = new Date('2025-12-31T23:59:59Z');
+        const result = buildFilteredQuery({ until });
+        expect(result.query).toContain('AND quarantine_date <= ?');
+        expect(result.countQuery).toContain('AND quarantine_date <= ?');
+        expect(result.params).toContain(until.toISOString());
+        expect(result.countParams).toContain(until.toISOString());
+    });
+    it('applies combined since + until range', () => {
+        const since = new Date('2025-01-01T00:00:00Z');
+        const until = new Date('2025-06-30T23:59:59Z');
+        const result = buildFilteredQuery({ since, until });
+        expect(result.query).toContain('AND quarantine_date >= ?');
+        expect(result.query).toContain('AND quarantine_date <= ?');
+        expect(result.params).toContain(since.toISOString());
+        expect(result.params).toContain(until.toISOString());
+    });
+    it('applies all filters simultaneously and builds correct param array', () => {
+        const since = new Date('2025-01-01T00:00:00Z');
+        const until = new Date('2025-12-31T00:00:00Z');
+        const result = buildFilteredQuery({
+            skillId: 'skill-abc',
+            source: 'github',
+            severity: 'MALICIOUS',
+            reviewStatus: 'pending',
+            reviewedBy: 'bob',
+            since,
+            until,
+            limit: 50,
+            offset: 10,
+        });
+        expect(result.query).toContain('AND skill_id = ?');
+        expect(result.query).toContain('AND source = ?');
+        expect(result.query).toContain('AND severity = ?');
+        expect(result.query).toContain('AND review_status = ?');
+        expect(result.query).toContain('AND reviewed_by = ?');
+        expect(result.query).toContain('AND quarantine_date >= ?');
+        expect(result.query).toContain('AND quarantine_date <= ?');
+        expect(result.query).toContain('LIMIT ? OFFSET ?');
+        // Verify param ordering: skill_id, source, severity, review_status, reviewed_by, since, until, limit, offset
+        expect(result.params).toEqual([
+            'skill-abc',
+            'github',
+            'MALICIOUS',
+            'pending',
+            'bob',
+            since.toISOString(),
+            until.toISOString(),
+            50,
+            10,
+        ]);
+    });
+    it('uses default limit=20 and offset=0 when not specified', () => {
+        const result = buildFilteredQuery({});
+        // Last two params should be limit and offset defaults
+        const lastTwo = result.params.slice(-2);
+        expect(lastTwo).toEqual([20, 0]);
+    });
+});
+// ============================================================================
+// rowToEntry — column mapping
+// ============================================================================
+describe('rowToEntry', () => {
+    it('maps all database row columns to the correct output properties', () => {
+        const row = {
+            id: 'entry-001',
+            skill_id: 'community/bad-skill',
+            source: 'github',
+            quarantine_reason: 'Detected malicious pattern',
+            severity: 'MALICIOUS',
+            detected_patterns: '["eval(", "require(fs)"]',
+            quarantine_date: '2025-06-15T10:00:00.000Z',
+            reviewed_by: 'security-team',
+            review_status: 'approved',
+            review_notes: 'Confirmed malicious',
+            review_date: '2025-06-16T09:00:00.000Z',
+            created_at: '2025-06-15T10:00:00.000Z',
+            updated_at: '2025-06-16T09:00:00.000Z',
+        };
+        const entry = rowToEntry(row);
+        expect(entry.id).toBe('entry-001');
+        expect(entry.skillId).toBe('community/bad-skill');
+        expect(entry.source).toBe('github');
+        expect(entry.quarantineReason).toBe('Detected malicious pattern');
+        expect(entry.severity).toBe('MALICIOUS');
+        expect(entry.detectedPatterns).toEqual(['eval(', 'require(fs)']);
+        expect(entry.quarantineDate).toBe('2025-06-15T10:00:00.000Z');
+        expect(entry.reviewedBy).toBe('security-team');
+        expect(entry.reviewStatus).toBe('approved');
+        expect(entry.reviewNotes).toBe('Confirmed malicious');
+        expect(entry.reviewDate).toBe('2025-06-16T09:00:00.000Z');
+        expect(entry.createdAt).toBe('2025-06-15T10:00:00.000Z');
+        expect(entry.updatedAt).toBe('2025-06-16T09:00:00.000Z');
+    });
+    it('handles null optional fields correctly', () => {
+        const row = {
+            id: 'entry-002',
+            skill_id: 'community/suspicious-skill',
+            source: 'registry',
+            quarantine_reason: 'High risk score',
+            severity: 'SUSPICIOUS',
+            detected_patterns: '[]',
+            quarantine_date: '2025-07-01T00:00:00.000Z',
+            reviewed_by: null,
+            review_status: 'pending',
+            review_notes: null,
+            review_date: null,
+            created_at: '2025-07-01T00:00:00.000Z',
+            updated_at: '2025-07-01T00:00:00.000Z',
+        };
+        const entry = rowToEntry(row);
+        expect(entry.reviewedBy).toBeNull();
+        expect(entry.reviewNotes).toBeNull();
+        expect(entry.reviewDate).toBeNull();
+        expect(entry.detectedPatterns).toEqual([]);
+    });
+});
+//# sourceMappingURL=quarantine-query-builder.test.js.map

package/dist/tests/unit/quarantine-query-builder.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quarantine-query-builder.test.js","sourceRoot":"","sources":["../../../tests/unit/quarantine-query-builder.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAA;AAC7C,OAAO,EAAE,kBAAkB,EAAE,UAAU,EAAE,MAAM,oDAAoD,CAAA;AAGnG,+EAA+E;AAC/E,8CAA8C;AAC9C,+EAA+E;AAE/E,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,CAAC,CAAA;QAErC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAA;QAChD,8CAA8C;QAC9C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;QAChD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA,CAAC,8BAA8B;IACtE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,UAAU,EAAE,OAAO,EAAE,CAAC,CAAA;QAE1D,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,qBAAqB,CAAC,CAAA;QACrD,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,qBAAqB,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAA;IAC/C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,KAAK,EAAE,CAAC,CAAA;QAE5C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC/D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;IAC3D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,KAAK,EAAE,CAAC,CAAA;QAE5C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC/D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;IAC3D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;QAC9C,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,KAAK,EAAE,KAAK,EAAE,CAAC,CAAA;QAEnD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QAC3E,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC9C,MAAM,MAAM,GAAG,kBAAkB,CAAC;YAChC,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,QAAQ;YAChB,QAAQ,EAAE,WAAW;YACrB,YAAY,EAAE,SAAS;YACvB,UAAU,EAAE,KAAK;YACjB,KAAK;YACL,KAAK;YACL,KAAK,EAAE,EAAE;YACT,MAAM,EAAE,EAAE;SACX,CAAC,CAAA;QAEF,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAA;QAChD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,uBAAuB,CAAC,CAAA;QACvD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,qBAAqB,CAAC,CAAA;QACrD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAA;QAC1D,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAA;QAElD,6GAA6G;QAC7G,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YAC5B,WAAW;YACX,QAAQ;YACR,WAAW;YACX,SAAS;YACT,KAAK;YACL,KAAK,CAAC,WAAW,EAAE;YACnB,KAAK,CAAC,WAAW,EAAE;YACnB,EAAE;YACF,EAAE;SACH,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,MAAM,GAAG,kBAAkB,CAAC,EAAE,CAAC,CAAA;QAErC,sDAAsD;QACtD,MAAM,OAAO,GAAG,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAA;QACvC,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAA;IAClC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,+EAA+E;AAC/E,8BAA8B;AAC9B,+EAA+E;AAE/E,QAAQ,CAAC,YAAY,EAAE,GAAG,EAAE;IAC1B,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,MAAM,GAAG,GAAkB;YACzB,EAAE,EAAE,WAAW;YACf,QAAQ,EAAE,qBAAqB;YAC/B,MAAM,EAAE,QAAQ;YAChB,iBAAiB,EAAE,4BAA4B;YAC/C,QAAQ,EAAE,WAAW;YACrB,iBAAiB,EAAE,0BAA0B;YAC7C,eAAe,EAAE,0BAA0B;YAC3C,WAAW,EAAE,eAAe;YAC5B,aAAa,EAAE,UAAU;YACzB,YAAY,EAAE,qBAAqB;YACnC,WAAW,EAAE,0BAA0B;YACvC,UAAU,EAAE,0BAA0B;YACtC,UAAU,EAAE,0BAA0B;SACvC,CAAA;QAED,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,CAAC,CAAA;QAE7B,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;QAClC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAA;QACjD,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACnC,MAAM,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAA;QACjE,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;QACxC,MAAM,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,aAAa,CAAC,CAAC,CAAA;QAChE,MAAM,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;QAC7D,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;QAC9C,MAAM,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QAC3C,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAA;QACrD,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;QACzD,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;QACxD,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,GAAG,GAAkB;YACzB,EAAE,EAAE,WAAW;YACf,QAAQ,EAAE,4BAA4B;YACtC,MAAM,EAAE,UAAU;YAClB,iBAAiB,EAAE,iBAAiB;YACpC,QAAQ,EAAE,YAAY;YACtB,iBAAiB,EAAE,IAAI;YACvB,eAAe,EAAE,0BAA0B;YAC3C,WAAW,EAAE,IAAI;YACjB,aAAa,EAAE,SAAS;YACxB,YAAY,EAAE,IAAI;YAClB,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,0BAA0B;YACtC,UAAU,EAAE,0BAA0B;SACvC,CAAA;QAED,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,CAAC,CAAA;QAE7B,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE,CAAA;QACnC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,QAAQ,EAAE,CAAA;QACpC,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE,CAAA;QACnC,MAAM,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IAC5C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skillsmith/core",
-  "version": "0.4.13",
+  "version": "0.4.15",
   "description": "Core types and utilities for Skillsmith",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -60,7 +60,6 @@
     "@opentelemetry/sdk-trace-base": "2.5.0",
     "@opentelemetry/semantic-conventions": "1.39.0",
     "@huggingface/transformers": "3.8.1",
-    "better-sqlite3": "12.6.2",
     "fts5-sql-bundle": "1.0.2",
     "lru-cache": "10.4.3",
     "posthog-node": "5.21.0",
@@ -70,7 +69,6 @@
   },
   "devDependencies": {
     "@types/better-sqlite3": "7.6.13",
-    "@types/sql.js": "1.4.9",
     "vitest": "4.0.16"
   },
   "files": [