@skillsmith/core 0.12.1 → 0.12.3

package/dist/src/install/agent-pack-installer.cursor-mcp.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.cursor-mcp.js","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.cursor-mcp.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA2CG;AAEH,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,SAAS,CAAA;AAEjE,OAAO,EAAE,iBAAiB,EAAE,MAAM,4BAA4B,CAAA;AAC9D,OAAO,EAAE,iBAAiB,EAAE,MAAM,8BAA8B,CAAA;AAChE,OAAO,EAAE,WAAW,EAAE,MAAM,oCAAoC,CAAA;AAChE,OAAO,EAAE,aAAa,EAAE,YAAY,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAA;AACzF,OAAO,EACL,oBAAoB,EACpB,oBAAoB,EACpB,uBAAuB,EACvB,wBAAwB,GACzB,MAAM,iCAAiC,CAAA;AACxC,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAA;AAK5D,6JAA6J;AAC7J,SAAS,cAAc,CAAC,MAA6B;IACnD,OAAO,MAAM,KAAK,SAAS,IAAI,MAAM,KAAK,SAAS,IAAI,MAAM,KAAK,WAAW,CAAA;AAC/E,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,sBAAsB,CAAC,GAAsB,EAAE,MAA4B;IACzF,MAAM,MAAM,GAAG,iBAAiB,CAAC,MAAM,CAAA;IACvC,MAAM,IAAI,GAAG,iBAAiB,CAAC,MAAM,CAAC,IAAI,EAAE,GAAG,CAAC,OAAO,CAAC,CAAA;IACxD,MAAM,UAAU,GAAG,wBAAwB,EAAE,CAAA;IAE7C,MAAM,MAAM,GAAG,iBAAiB,CAAC;QAC/B,IAAI;QACJ,OAAO,EAAE,MAAM,CAAC,OAAO;QACvB,QAAQ,EAAE,oBAAoB;QAC9B,UAAU;QACV,SAAS,EAAE,GAAG,CAAC,SAAS;QACxB,KAAK,EAAE,GAAG,CAAC,KAAK;QAChB,oBAAoB,EAAE,GAAG,CAAC,aAAa;KACxC,CAAC,CAAA;IAEF,MAAM,CAAC,SAAS,GAAG,MAAM,CAAA;IACzB,IAAI,MAAM,CAAC,MAAM,KAAK,UAAU,EAAE,CAAC;QACjC,MAAM,CAAC,KAAK,CAAC,IAAI,CACf,iBAAiB,IAAI,mBAAmB,oBAAoB,mGAAmG,IAAI,YAAY,CAChL,CAAA;IACH,CAAC;IACD,IAAI,MAAM,CAAC,MAAM,KAAK,OAAO,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,8BAA8B,IAAI,KAAK,MAAM,CAAC,YAAY,EAAE,CAAC,CAAA;IACjF,CAAC;IAED,2EAA2E;IAC3E,yEAAyE;IACzE,2EAA2E;IAC3E,0EAA0E;IAC1E,6CAA6C;IAC7C,MAAM,OAAO,GAAG,cAAc,CAAC,MAAM,CAAC,MAAM,CAAC;QAC3C,CAAC,CAAC,sBAAsB,CAAC,IAAI,EAAE,MAAM,CAAC,OAAO,EAAE,GAAG,CAAC;QACnD,CAAC,CAAC,IAAI,CAAA;IACR,IAAI,OAAO,EAAE,MAAM,KAAK,SAAS,EAAE,CAAC;QAClC,MAAM,CAAC,KAAK,CAAC,IAAI,CACf,yBAAyB,oBAAoB,kBAAkB,IAAI,qBAAqB,oBAAoB,oEAAoE,CACjL,CAAA;IACH,CAAC;IACD,IAAI,OAAO,EAAE,MAAM,KAAK,OAAO,EAAE,CAAC;QAChC,MAAM,CAAC,KAAK,CAAC,IAAI,CACf,yBAAyB,oBAAoB,kBAAkB,IAAI,6BAA6B,OAAO,CAAC,YAAY,cAAc,oBAAoB,iGAAiG,CACxP,CAAA;IACH,CAAC;IAED,IAAI,cAAc,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,OAAO,EAAE,MAAM,KAAK,SAAS,EAAE,CAAC;QACnE,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC;YACf,IAAI;YACJ,IAAI,EAAE,YAAY;YAClB,OAAO,EAAE,QAAQ;YACjB,UAAU,EAAE,MAAM,CAAC,UAAU,IAAI,OAAO,EAAE,UAAU,IAAI,IAAI;YAC5D,UAAU,EAAE,KAAK;SAClB,CAAC,CAAA;IACJ,CAAC;AACH,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,SAAS,4BAA4B,CAAC,KAAc;IAClD,OAAO,aAAa,CAAC,KAAK,EAAE,uBAAuB,EAAE,CAAC,CAAA;AACxD,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,SAAS,sBAAsB,CAC7B,IAAY,EACZ,OAA0B,EAC1B,GAAsB;IAEtB,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAA;IAElC,IAAI,GAA4B,CAAA;IAChC,IAAI,CAAC;QACH,MAAM,MAAM,GAAY,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAA;QAC/D,IAAI,CAAC,MAAM,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC;YAAE,OAAO,IAAI,CAAA;QAC/E,GAAG,GAAG,MAAiC,CAAA;IACzC,CAAC;IAAC,MAAM,CAAC;QACP,oEAAoE;QACpE,oEAAoE;QACpE,wEAAwE;QACxE,OAAO,IAAI,CAAA;IACb,CAAC;IAED,MAAM,YAAY,GAAG,OAAO,CAAC,CAAC,CAAC,CAAA;IAC/B,IAAI,YAAY,KAAK,SAAS;QAAE,OAAO,IAAI,CAAA;IAC3C,MAAM,SAAS,GAAG,GAAG,CAAC,YAAY,CAAC,CAAA;IACnC,IAAI,CAAC,SAAS,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC;QAAE,OAAO,IAAI,CAAA;IACxF,MAAM,YAAY,GAAG,SAAoC,CAAA;IAEzD,MAAM,WAAW,GAAG,YAAY,CAAC,oBAAoB,CAAC,CAAA;IACtD,IAAI,WAAW,KAAK,SAAS;QAAE,OAAO,IAAI,CAAA;IAC1C,kEAAkE;IAClE,IAAI,CAAC,4BAA4B,CAAC,WAAW,CAAC;QAAE,OAAO,IAAI,CAAA;IAE3D,uEAAuE;IACvE,sEAAsE;IACtE,IAAI,CAAC;QACH,OAAO,YAAY,CAAC,oBAAoB,CAAC,CAAA;QACzC,MAAM,UAAU,GAAG,YAAY,CAAC,IAAI,EAAE,GAAG,CAAC,aAAa,CAAC;YACtD,CAAC,CAAC,WAAW,CAAC,IAAI,EAAE,GAAG,CAAC,SAAS,CAAC;YAClC,CAAC,CAAC,IAAI,CAAA;QACR,YAAY,CAAC,IAAI,EAAE,GAAG,CAAC,aAAa,CAAC,CAAA;QACrC,aAAa,CAAC,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,IAAI,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAA;QACzE,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,CAAA;IAChD,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,OAAO;YACL,MAAM,EAAE,OAAO;YACf,IAAI;YACJ,UAAU,EAAE,IAAI;YAChB,YAAY,EAAE,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC;SACrE,CAAA;IACH,CAAC;AACH,CAAC"}

package/dist/src/install/agent-pack-installer.cursor-mcp.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=agent-pack-installer.cursor-mcp.test.d.ts.map

package/dist/src/install/agent-pack-installer.cursor-mcp.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.cursor-mcp.test.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.cursor-mcp.test.ts"],"names":[],"mappings":""}

package/dist/src/install/agent-pack-installer.cursor-mcp.test.js

@@ -0,0 +1,285 @@
+/**
+ * Cursor `mcp.json` entry-shape + key-alignment regression coverage
+ * (SMI-6279 Wave 9, GH#2368 V3).
+ *
+ * Split from agent-pack-installer.test.ts, mirroring the existing
+ * agent-pack-installer.cursor-hooks.test.ts split (same temp-HOME +
+ * manifest-env fixture shape). Covers the two independent things
+ * `agent-pack-installer.cursor-mcp.ts` fixes:
+ *   1. Entry SHAPE: a resolved `skillsmith-mcp` binary path (or the
+ *      documented paste-here placeholder when resolution fails) instead of
+ *      the `npx`/`args` form two live UAT passes proved ENOENTs inside
+ *      Cursor's bundled Node, plus `SKILLSMITH_CLIENT=cursor`.
+ *   2. Entry KEY: `@skillsmith/mcp-server` (matching the website/CLI docs
+ *      snippet) instead of `skillsmith`, with a legacy-key cleanup step for
+ *      a pre-fix install that still has the old key.
+ *
+ * `node:child_process`'s `execFileSync` is mocked so `resolveSkillsmithMcpBinPath`
+ * never depends on whether `skillsmith-mcp` happens to be on the test
+ * runner's real PATH.
+ *
+ * @module @skillsmith/core/install/agent-pack-installer.cursor-mcp.test
+ */
+import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+const { execFileSyncMock } = vi.hoisted(() => ({ execFileSyncMock: vi.fn() }));
+vi.mock('node:child_process', async (importOriginal) => {
+    const actual = await importOriginal();
+    return { ...actual, execFileSync: execFileSyncMock };
+});
+// Defaults to the real writeFileSync so every test in this file gets real
+// disk writes unmodified; only the one PR-07-regression test below swaps in
+// a conditional throw, keyed by path so it can't accidentally intercept the
+// unrelated skill-pack-file writes installAgentPack also performs in the
+// same run (confirmed necessary: a naive call-order-based override fired on
+// one of those instead, on the first pass at writing this test).
+const { writeFileSyncMock, realWriteFileSyncRef } = vi.hoisted(() => ({
+    writeFileSyncMock: vi.fn(),
+    realWriteFileSyncRef: { current: null },
+}));
+vi.mock('node:fs', async (importOriginal) => {
+    const actual = await importOriginal();
+    realWriteFileSyncRef.current = actual.writeFileSync;
+    writeFileSyncMock.mockImplementation(actual.writeFileSync);
+    return { ...actual, writeFileSync: writeFileSyncMock };
+});
+import { installAgentPack } from './agent-pack-installer.js';
+import { AGENT_INSTALL_DIR_ENV_VAR } from './agent-manifest.js';
+let homeDir;
+let manifestDir;
+let prevInstallDirEnv;
+const RESOLVED_BIN_PATH = '/usr/local/bin/skillsmith-mcp';
+function mcpJsonPath(home) {
+    return join(home, '.cursor', 'mcp.json');
+}
+function readCursorMcpJson(home) {
+    return JSON.parse(readFileSync(mcpJsonPath(home), 'utf-8'));
+}
+function seedCursorPresent() {
+    mkdirSync(join(homeDir, '.cursor', 'skills'), { recursive: true });
+}
+beforeEach(() => {
+    homeDir = mkdtempSync(join(tmpdir(), 'skillsmith-agent-install-home-'));
+    manifestDir = mkdtempSync(join(tmpdir(), 'skillsmith-agent-install-manifest-'));
+    prevInstallDirEnv = process.env[AGENT_INSTALL_DIR_ENV_VAR];
+    process.env[AGENT_INSTALL_DIR_ENV_VAR] = manifestDir;
+    execFileSyncMock.mockReset();
+    // Reset to the real passthrough (see the vi.mock('node:fs', ...) setup
+    // above) in case a prior test overrode it to simulate a write failure.
+    writeFileSyncMock.mockClear();
+});
+afterEach(() => {
+    rmSync(homeDir, { recursive: true, force: true });
+    rmSync(manifestDir, { recursive: true, force: true });
+    if (prevInstallDirEnv !== undefined)
+        process.env[AGENT_INSTALL_DIR_ENV_VAR] = prevInstallDirEnv;
+    else
+        delete process.env[AGENT_INSTALL_DIR_ENV_VAR];
+    vi.restoreAllMocks();
+});
+describe('installAgentPack — cursor mcp.json entry shape (SMI-6279 Wave 9)', () => {
+    it('writes the entry under the @skillsmith/mcp-server key with a resolved binary path + SKILLSMITH_CLIENT=cursor', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        const result = installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        const entry = doc.mcpServers['@skillsmith/mcp-server'];
+        expect(entry?.command).toBe(RESOLVED_BIN_PATH);
+        expect(entry?.env?.SKILLSMITH_CLIENT).toBe('cursor');
+        expect(entry?.env?.SKILLSMITH_TOOL_PROFILE).toBe('agent');
+        // No `args` — unlike the broken npx form, Cursor's entry invokes the
+        // resolved binary directly.
+        expect(entry?.args).toBeUndefined();
+        // No stray legacy key on a first-ever install.
+        expect(doc.mcpServers.skillsmith).toBeUndefined();
+        const report = result.harnessReports.find((r) => r.harness === 'cursor');
+        expect(report?.mcpConfig?.status).toBe('created');
+    });
+    it('falls back to the documented paste-here placeholder when the binary cannot be resolved', () => {
+        execFileSyncMock.mockImplementation(() => {
+            throw new Error('not found');
+        });
+        seedCursorPresent();
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        const entry = doc.mcpServers['@skillsmith/mcp-server'];
+        expect(entry?.command).toContain('which skillsmith-mcp');
+        expect(entry?.command).toContain('where skillsmith-mcp');
+    });
+    it('falls back to the placeholder (never hangs) when the which/where lookup times out — code-review finding, GPT-5.6-Sol / SMI-6279', () => {
+        // execFileSync throws a synchronous ETIMEDOUT-shaped error when its own
+        // `timeout` option elapses — the existing blanket catch already handles
+        // this the same as "not found", so simulating that error is sufficient
+        // to prove the timeout-case fallback without an actual hung process.
+        const timeoutError = Object.assign(new Error('spawnSync which ETIMEDOUT'), {
+            code: 'ETIMEDOUT',
+            killed: true,
+            signal: 'SIGTERM',
+        });
+        execFileSyncMock.mockImplementation(() => {
+            throw timeoutError;
+        });
+        seedCursorPresent();
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        const entry = doc.mcpServers['@skillsmith/mcp-server'];
+        expect(entry?.command).toContain('which skillsmith-mcp');
+        // And the bound is actually wired to the real execFileSync call, not
+        // just documented — a `timeout` option keeps a hung/substituted
+        // which/where from blocking `agent install` indefinitely.
+        expect(execFileSyncMock).toHaveBeenCalledWith(expect.any(String), ['skillsmith-mcp'], expect.objectContaining({ timeout: expect.any(Number) }));
+        const [, , options] = execFileSyncMock.mock.calls[0];
+        expect(options.timeout).toBeGreaterThan(0);
+        // A few seconds is plenty for a local PATH lookup — not a network call.
+        expect(options.timeout).toBeLessThanOrEqual(5000);
+    });
+    it('does not regress claude-code’s own entry — still the npx form under the "skillsmith" key', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        installAgentPack({ homeDir });
+        const claudeDoc = JSON.parse(readFileSync(join(homeDir, '.claude', 'settings.json'), 'utf-8'));
+        expect(claudeDoc.mcpServers.skillsmith?.command).toBe('npx');
+        expect(claudeDoc.mcpServers.skillsmith?.env?.SKILLSMITH_TOOL_PROFILE).toBe('agent');
+        expect(claudeDoc.mcpServers.skillsmith?.env?.SKILLSMITH_CLIENT).toBeUndefined();
+    });
+});
+describe('installAgentPack — cursor mcp.json idempotency (SMI-6279 Wave 9)', () => {
+    it('re-install does not create a duplicate second server entry', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        installAgentPack({ homeDir });
+        const second = installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        expect(Object.keys(doc.mcpServers)).toEqual(['@skillsmith/mcp-server']);
+        const report = second.harnessReports.find((r) => r.harness === 'cursor');
+        expect(report?.mcpConfig?.status).toBe('unchanged');
+    });
+});
+describe('installAgentPack — cursor mcp.json stale legacy-key cleanup (SMI-6279 Wave 9)', () => {
+    it('removes a stale "skillsmith"-keyed entry from a pre-fix install, leaving exactly one entry', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({
+            mcpServers: {
+                skillsmith: {
+                    command: 'npx',
+                    args: ['-y', '@skillsmith/mcp-server'],
+                    env: { SKILLSMITH_TOOL_PROFILE: 'agent' },
+                },
+            },
+        }, null, 2));
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        expect(doc.mcpServers.skillsmith).toBeUndefined();
+        expect(doc.mcpServers['@skillsmith/mcp-server']?.command).toBe(RESOLVED_BIN_PATH);
+        expect(Object.keys(doc.mcpServers)).toEqual(['@skillsmith/mcp-server']);
+    });
+    it('preserves a foreign entry under the legacy "skillsmith" key — never deletes a user-owned unrelated entry', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        const foreignEntry = { command: 'some-other-tool', args: ['--flag'] };
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({ mcpServers: { skillsmith: foreignEntry } }, null, 2));
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        expect(doc.mcpServers.skillsmith).toEqual(foreignEntry);
+        expect(doc.mcpServers['@skillsmith/mcp-server']?.command).toBe(RESOLVED_BIN_PATH);
+    });
+    it('preserves a near-miss entry that references the package name in an extra description field (code-review finding, GPT-5.6-Sol / SMI-6279)', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        // Structurally close to our own legacy shape (same command/args/env
+        // value) but NOT byte-identical — one extra key. The old loose
+        // `looksLikeOurMcpEntry` heuristic (substring-matches args, checks only
+        // key presence) would have matched this and deleted it; the tightened
+        // exact-shape check must not.
+        const nearMissEntry = {
+            command: 'npx',
+            args: ['-y', '@skillsmith/mcp-server'],
+            env: { SKILLSMITH_TOOL_PROFILE: 'agent' },
+            description: 'Custom wrapper — see @skillsmith/mcp-server docs for context',
+        };
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({ mcpServers: { skillsmith: nearMissEntry } }, null, 2));
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        expect(doc.mcpServers.skillsmith).toEqual(nearMissEntry);
+        expect(doc.mcpServers['@skillsmith/mcp-server']?.command).toBe(RESOLVED_BIN_PATH);
+    });
+    it('preserves a near-miss "skillsmith"-keyed entry whose SKILLSMITH_TOOL_PROFILE value differs from what we would have written (code-review finding, GPT-5.6-Sol / SMI-6279)', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        // Same command/args/key SET as our legacy shape, but a different env
+        // VALUE — the old loose heuristic only checked key presence, not value,
+        // and would have matched+deleted this too.
+        const nearMissEntry = {
+            command: 'npx',
+            args: ['-y', '@skillsmith/mcp-server'],
+            env: { SKILLSMITH_TOOL_PROFILE: 'debug' },
+        };
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({ mcpServers: { skillsmith: nearMissEntry } }, null, 2));
+        installAgentPack({ homeDir });
+        const doc = readCursorMcpJson(homeDir);
+        expect(doc.mcpServers.skillsmith).toEqual(nearMissEntry);
+        expect(doc.mcpServers['@skillsmith/mcp-server']?.command).toBe(RESOLVED_BIN_PATH);
+    });
+    it('is idempotent: a second install run on an already-migrated file makes no further legacy-key change', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({
+            mcpServers: {
+                skillsmith: {
+                    command: 'npx',
+                    args: ['-y', '@skillsmith/mcp-server'],
+                    env: { SKILLSMITH_TOOL_PROFILE: 'agent' },
+                },
+            },
+        }, null, 2));
+        installAgentPack({ homeDir }); // first run: writes the new key, cleans the legacy one
+        const afterFirst = readFileSync(mcpJsonPath(homeDir), 'utf-8');
+        const second = installAgentPack({ homeDir }); // second run: nothing left to clean
+        const afterSecond = readFileSync(mcpJsonPath(homeDir), 'utf-8');
+        expect(afterSecond).toBe(afterFirst);
+        const report = second.harnessReports.find((r) => r.harness === 'cursor');
+        expect(report?.mcpConfig?.status).toBe('unchanged');
+    });
+    it('reports a cleanup write failure via report.notes instead of swallowing it as "nothing to clean up" (PR-07 finding, GPT-5.6-Sol / SMI-6279)', () => {
+        execFileSyncMock.mockReturnValue(`${RESOLVED_BIN_PATH}\n`);
+        seedCursorPresent();
+        // Seed BOTH the already-correct new entry and the stale legacy entry, so
+        // the main merge sees 'unchanged' (no write attempted there) and only
+        // the cleanup step's own write is exercised below.
+        writeFileSync(mcpJsonPath(homeDir), JSON.stringify({
+            mcpServers: {
+                skillsmith: {
+                    command: 'npx',
+                    args: ['-y', '@skillsmith/mcp-server'],
+                    env: { SKILLSMITH_TOOL_PROFILE: 'agent' },
+                },
+                '@skillsmith/mcp-server': {
+                    command: RESOLVED_BIN_PATH,
+                    env: { SKILLSMITH_TOOL_PROFILE: 'agent', SKILLSMITH_CLIENT: 'cursor' },
+                },
+            },
+        }, null, 2));
+        // Target only the cleanup's write to THIS file — installAgentPack also
+        // writes several unrelated skill-pack files earlier in the same run, and
+        // must keep writing those for real.
+        const targetPath = mcpJsonPath(homeDir);
+        writeFileSyncMock.mockImplementation((...args) => {
+            if (args[0] === targetPath) {
+                throw new Error('EACCES: permission denied (simulated)');
+            }
+            return realWriteFileSyncRef.current(...args);
+        });
+        const result = installAgentPack({ homeDir });
+        // The legacy key must still be on disk — the failed write must not have
+        // corrupted or partially applied the delete.
+        const doc = readCursorMcpJson(homeDir);
+        expect(doc.mcpServers.skillsmith).toBeDefined();
+        const report = result.harnessReports.find((r) => r.harness === 'cursor');
+        expect(report?.notes.some((n) => n.includes('could not remove it'))).toBe(true);
+        expect(report?.notes.some((n) => n.includes('EACCES'))).toBe(true);
+    });
+});
+//# sourceMappingURL=agent-pack-installer.cursor-mcp.test.js.map

package/dist/src/install/agent-pack-installer.cursor-mcp.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.cursor-mcp.test.js","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.cursor-mcp.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,OAAO,EAAE,SAAS,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,EAAE,aAAa,EAAE,MAAM,SAAS,CAAA;AACrF,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAA;AAChC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAChC,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAExE,MAAM,EAAE,gBAAgB,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,gBAAgB,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,CAAA;AAC9E,EAAE,CAAC,IAAI,CAAC,oBAAoB,EAAE,KAAK,EAAE,cAAc,EAAE,EAAE;IACrD,MAAM,MAAM,GAAG,MAAM,cAAc,EAAuC,CAAA;IAC1E,OAAO,EAAE,GAAG,MAAM,EAAE,YAAY,EAAE,gBAAgB,EAAE,CAAA;AACtD,CAAC,CAAC,CAAA;AAEF,0EAA0E;AAC1E,4EAA4E;AAC5E,4EAA4E;AAC5E,yEAAyE;AACzE,4EAA4E;AAC5E,iEAAiE;AACjE,MAAM,EAAE,iBAAiB,EAAE,oBAAoB,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IACpE,iBAAiB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC1B,oBAAoB,EAAE,EAAE,OAAO,EAAE,IAA6C,EAAE;CACjF,CAAC,CAAC,CAAA;AACH,EAAE,CAAC,IAAI,CAAC,SAAS,EAAE,KAAK,EAAE,cAAc,EAAE,EAAE;IAC1C,MAAM,MAAM,GAAG,MAAM,cAAc,EAA4B,CAAA;IAC/D,oBAAoB,CAAC,OAAO,GAAG,MAAM,CAAC,aAAwD,CAAA;IAC9F,iBAAiB,CAAC,kBAAkB,CAAC,MAAM,CAAC,aAAa,CAAC,CAAA;IAC1D,OAAO,EAAE,GAAG,MAAM,EAAE,aAAa,EAAE,iBAAiB,EAAE,CAAA;AACxD,CAAC,CAAC,CAAA;AAEF,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAA;AAC5D,OAAO,EAAE,yBAAyB,EAAE,MAAM,qBAAqB,CAAA;AAE/D,IAAI,OAAe,CAAA;AACnB,IAAI,WAAmB,CAAA;AACvB,IAAI,iBAAqC,CAAA;AAEzC,MAAM,iBAAiB,GAAG,+BAA+B,CAAA;AAEzD,SAAS,WAAW,CAAC,IAAY;IAC/B,OAAO,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,UAAU,CAAC,CAAA;AAC1C,CAAC;AASD,SAAS,iBAAiB,CAAC,IAAY;IACrC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,OAAO,CAAC,CAAiB,CAAA;AAC7E,CAAC;AAED,SAAS,iBAAiB;IACxB,SAAS,CAAC,IAAI,CAAC,OAAO,EAAE,SAAS,EAAE,QAAQ,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;AACpE,CAAC;AAED,UAAU,CAAC,GAAG,EAAE;IACd,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,gCAAgC,CAAC,CAAC,CAAA;IACvE,WAAW,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,oCAAoC,CAAC,CAAC,CAAA;IAC/E,iBAAiB,GAAG,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,CAAA;IAC1D,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,GAAG,WAAW,CAAA;IACpD,gBAAgB,CAAC,SAAS,EAAE,CAAA;IAC5B,uEAAuE;IACvE,uEAAuE;IACvE,iBAAiB,CAAC,SAAS,EAAE,CAAA;AAC/B,CAAC,CAAC,CAAA;AAEF,SAAS,CAAC,GAAG,EAAE;IACb,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;IACjD,MAAM,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;IACrD,IAAI,iBAAiB,KAAK,SAAS;QAAE,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,GAAG,iBAAiB,CAAA;;QAC1F,OAAO,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,CAAA;IAClD,EAAE,CAAC,eAAe,EAAE,CAAA;AACtB,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAChF,EAAE,CAAC,8GAA8G,EAAE,GAAG,EAAE;QACtH,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QAEnB,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE5C,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,CAAA;QACtD,MAAM,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAA;QAC9C,MAAM,CAAC,KAAK,EAAE,GAAG,EAAE,iBAAiB,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACpD,MAAM,CAAC,KAAK,EAAE,GAAG,EAAE,uBAAuB,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACzD,qEAAqE;QACrE,4BAA4B;QAC5B,MAAM,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC,aAAa,EAAE,CAAA;QACnC,+CAA+C;QAC/C,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAA;QAEjD,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAA;QACxE,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IACnD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wFAAwF,EAAE,GAAG,EAAE;QAChG,gBAAgB,CAAC,kBAAkB,CAAC,GAAG,EAAE;YACvC,MAAM,IAAI,KAAK,CAAC,WAAW,CAAC,CAAA;QAC9B,CAAC,CAAC,CAAA;QACF,iBAAiB,EAAE,CAAA;QAEnB,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,CAAA;QACtD,MAAM,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC,SAAS,CAAC,sBAAsB,CAAC,CAAA;QACxD,MAAM,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC,SAAS,CAAC,sBAAsB,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iIAAiI,EAAE,GAAG,EAAE;QACzI,wEAAwE;QACxE,wEAAwE;QACxE,uEAAuE;QACvE,qEAAqE;QACrE,MAAM,YAAY,GAAG,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,2BAA2B,CAAC,EAAE;YACzE,IAAI,EAAE,WAAW;YACjB,MAAM,EAAE,IAAI;YACZ,MAAM,EAAE,SAAS;SAClB,CAAC,CAAA;QACF,gBAAgB,CAAC,kBAAkB,CAAC,GAAG,EAAE;YACvC,MAAM,YAAY,CAAA;QACpB,CAAC,CAAC,CAAA;QACF,iBAAiB,EAAE,CAAA;QAEnB,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,CAAA;QACtD,MAAM,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC,SAAS,CAAC,sBAAsB,CAAC,CAAA;QAExD,qEAAqE;QACrE,gEAAgE;QAChE,0DAA0D;QAC1D,MAAM,CAAC,gBAAgB,CAAC,CAAC,oBAAoB,CAC3C,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,EAClB,CAAC,gBAAgB,CAAC,EAClB,MAAM,CAAC,gBAAgB,CAAC,EAAE,OAAO,EAAE,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,CACzD,CAAA;QACD,MAAM,CAAC,EAAE,AAAD,EAAG,OAAO,CAAC,GAAG,gBAAgB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA4C,CAAA;QAC/F,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;QAC1C,wEAAwE;QACxE,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAA;IACnD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0FAA0F,EAAE,GAAG,EAAE;QAClG,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QAEnB,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAC1B,YAAY,CAAC,IAAI,CAAC,OAAO,EAAE,SAAS,EAAE,eAAe,CAAC,EAAE,OAAO,CAAC,CACjD,CAAA;QACjB,MAAM,CAAC,SAAS,CAAC,UAAU,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC5D,MAAM,CAAC,SAAS,CAAC,UAAU,CAAC,UAAU,EAAE,GAAG,EAAE,uBAAuB,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACnF,MAAM,CAAC,SAAS,CAAC,UAAU,CAAC,UAAU,EAAE,GAAG,EAAE,iBAAiB,CAAC,CAAC,aAAa,EAAE,CAAA;IACjF,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAChF,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QAEnB,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAC7B,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE5C,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,wBAAwB,CAAC,CAAC,CAAA;QAEvE,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAA;QACxE,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;IACrD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,+EAA+E,EAAE,GAAG,EAAE;IAC7F,EAAE,CAAC,4FAA4F,EAAE,GAAG,EAAE;QACpG,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CACZ;YACE,UAAU,EAAE;gBACV,UAAU,EAAE;oBACV,OAAO,EAAE,KAAK;oBACd,IAAI,EAAE,CAAC,IAAI,EAAE,wBAAwB,CAAC;oBACtC,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE;iBAC1C;aACF;SACF,EACD,IAAI,EACJ,CAAC,CACF,CACF,CAAA;QAED,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAA;QACjD,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAA;QACjF,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,wBAAwB,CAAC,CAAC,CAAA;IACzE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0GAA0G,EAAE,GAAG,EAAE;QAClH,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,MAAM,YAAY,GAAG,EAAE,OAAO,EAAE,iBAAiB,EAAE,IAAI,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAA;QACrE,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CAAC,EAAE,UAAU,EAAE,EAAE,UAAU,EAAE,YAAY,EAAE,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,CACtE,CAAA;QAED,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,YAAY,CAAC,CAAA;QACvD,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAA;IACnF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0IAA0I,EAAE,GAAG,EAAE;QAClJ,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,oEAAoE;QACpE,+DAA+D;QAC/D,wEAAwE;QACxE,sEAAsE;QACtE,8BAA8B;QAC9B,MAAM,aAAa,GAAG;YACpB,OAAO,EAAE,KAAK;YACd,IAAI,EAAE,CAAC,IAAI,EAAE,wBAAwB,CAAC;YACtC,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE;YACzC,WAAW,EAAE,8DAA8D;SAC5E,CAAA;QACD,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CAAC,EAAE,UAAU,EAAE,EAAE,UAAU,EAAE,aAAa,EAAE,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,CACvE,CAAA;QAED,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,aAAa,CAAC,CAAA;QACxD,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAA;IACnF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0KAA0K,EAAE,GAAG,EAAE;QAClL,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,qEAAqE;QACrE,wEAAwE;QACxE,2CAA2C;QAC3C,MAAM,aAAa,GAAG;YACpB,OAAO,EAAE,KAAK;YACd,IAAI,EAAE,CAAC,IAAI,EAAE,wBAAwB,CAAC;YACtC,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE;SAC1C,CAAA;QACD,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CAAC,EAAE,UAAU,EAAE,EAAE,UAAU,EAAE,aAAa,EAAE,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,CACvE,CAAA;QAED,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE7B,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,aAAa,CAAC,CAAA;QACxD,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,wBAAwB,CAAC,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAA;IACnF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oGAAoG,EAAE,GAAG,EAAE;QAC5G,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CACZ;YACE,UAAU,EAAE;gBACV,UAAU,EAAE;oBACV,OAAO,EAAE,KAAK;oBACd,IAAI,EAAE,CAAC,IAAI,EAAE,wBAAwB,CAAC;oBACtC,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE;iBAC1C;aACF;SACF,EACD,IAAI,EACJ,CAAC,CACF,CACF,CAAA;QAED,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA,CAAC,uDAAuD;QACrF,MAAM,UAAU,GAAG,YAAY,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,CAAA;QAC9D,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA,CAAC,oCAAoC;QACjF,MAAM,WAAW,GAAG,YAAY,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,CAAA;QAE/D,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QACpC,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAA;QACxE,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;IACrD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4IAA4I,EAAE,GAAG,EAAE;QACpJ,gBAAgB,CAAC,eAAe,CAAC,GAAG,iBAAiB,IAAI,CAAC,CAAA;QAC1D,iBAAiB,EAAE,CAAA;QACnB,yEAAyE;QACzE,sEAAsE;QACtE,mDAAmD;QACnD,aAAa,CACX,WAAW,CAAC,OAAO,CAAC,EACpB,IAAI,CAAC,SAAS,CACZ;YACE,UAAU,EAAE;gBACV,UAAU,EAAE;oBACV,OAAO,EAAE,KAAK;oBACd,IAAI,EAAE,CAAC,IAAI,EAAE,wBAAwB,CAAC;oBACtC,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE;iBAC1C;gBACD,wBAAwB,EAAE;oBACxB,OAAO,EAAE,iBAAiB;oBAC1B,GAAG,EAAE,EAAE,uBAAuB,EAAE,OAAO,EAAE,iBAAiB,EAAE,QAAQ,EAAE;iBACvE;aACF;SACF,EACD,IAAI,EACJ,CAAC,CACF,CACF,CAAA;QAED,uEAAuE;QACvE,yEAAyE;QACzE,oCAAoC;QACpC,MAAM,UAAU,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;QACvC,iBAAiB,CAAC,kBAAkB,CAAC,CAAC,GAAG,IAAe,EAAE,EAAE;YAC1D,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,UAAU,EAAE,CAAC;gBAC3B,MAAM,IAAI,KAAK,CAAC,uCAAuC,CAAC,CAAA;YAC1D,CAAC;YAED,OAAO,oBAAoB,CAAC,OAAQ,CAAC,GAAG,IAAI,CAAC,CAAA;QAC/C,CAAC,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAE5C,wEAAwE;QACxE,6CAA6C;QAC7C,MAAM,GAAG,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,WAAW,EAAE,CAAA;QAE/C,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAA;QACxE,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC/E,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACpE,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/src/install/agent-pack-installer.d.ts

@@ -24,6 +24,14 @@
  *   - The `skillsmith` MCP server registration (`SKILLSMITH_TOOL_PROFILE=agent`)
  *     for every detected MCP-capable harness (all 7), backup-first,
  *     idempotent, preserve-and-prompt on a foreign entry.
+ *   - AntiGravity (SMI-6275 Wave 5): a workspace-scoped 8th target, handled
+ *     OUTSIDE the 7-harness loop above — see the `antigravity` block near
+ *     the end of `installAgentPack`. Whenever its workspace scope resolves
+ *     (an existing `.agents/` marker auto-detects, or `--scope workspace`
+ *     creates one), writes the skill pack AND `.agents/mcp_config.json`
+ *     (`installAntigravityMcpConfig`, `agent-pack-installer.antigravity-mcp.ts`)
+ *     — MCP config only, no hooks/shim this wave (stated decision, see
+ *     `HOOK_HARNESSES`'s doc comment in `services/agent-pack/types.ts`).
  *
  * Every write funnels through `writeOwnedArtifactFile` (owned files) or the
  * `agent-config-merge.*` helpers (shared config files), both of which record

package/dist/src/install/agent-pack-installer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"agent-pack-installer.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAWH,OAAO,EAGL,iBAAiB,EAGlB,MAAM,qBAAqB,CAAA;AAU5B,OAAO,EAEL,KAAK,mBAAmB,EACxB,KAAK,kBAAkB,EAExB,MAAM,iCAAiC,CAAA;AA4FxC;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,GAAE,mBAAwB,GAAG,kBAAkB,CAqInF;AAGD,OAAO,EAAE,iBAAiB,EAAE,CAAA"}
+{"version":3,"file":"agent-pack-installer.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA0CG;AAYH,OAAO,EAGL,iBAAiB,EAGlB,MAAM,qBAAqB,CAAA;AAY5B,OAAO,EAEL,KAAK,mBAAmB,EACxB,KAAK,kBAAkB,EAExB,MAAM,iCAAiC,CAAA;AA4FxC;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,GAAE,mBAAwB,GAAG,kBAAkB,CA0NnF;AAGD,OAAO,EAAE,iBAAiB,EAAE,CAAA"}

package/dist/src/install/agent-pack-installer.entry.d.ts

@@ -10,11 +10,97 @@
  */
 /**
  * The `skillsmith` MCP server registration value for `mcpServers`-convention
- * harnesses (claude-code, cursor, copilot, windsurf; hermes uses the same
- * field names under YAML). OpenCode does NOT use this shape — see
- * {@link buildOpenCodeMcpEntryValue}.
+ * harnesses (claude-code, copilot, windsurf; hermes uses the same field
+ * names under YAML). OpenCode does NOT use this shape — see
+ * {@link buildOpenCodeMcpEntryValue}. Cursor ALSO does not use this shape —
+ * see {@link buildCursorMcpEntryValue} (SMI-6279 Wave 9): two independent
+ * live UAT passes proved the `npx`/`args` form here ENOENTs inside Cursor's
+ * bundled Node (GH#2368 C-01), which is why the website/CLI-template docs
+ * snippet was corrected to a resolved-binary-path form back in SMI-5893
+ * Wave 11 — this function stayed on the broken form for every OTHER
+ * harness it's still correct for, so it is deliberately left unchanged here.
  */
 export declare function buildAgentMcpEntryValue(): Record<string, unknown>;
+/**
+ * JSON key Cursor's MCP entry is installed under (SMI-6279 Wave 9).
+ *
+ * Every OTHER `mcpServers`-convention harness still uses the literal
+ * `'skillsmith'` key (hardcoded as `mergeJsonMcpEntry`'s default `entryKey`
+ * — deliberately NOT changed here, out of scope for this fix). Cursor is
+ * the one client with a human-facing docs snippet
+ * (`packages/website/src/lib/mcp-client-snippets.ts` /
+ * `packages/cli/src/templates/mcp-server.template.snippets.ts`) that tells a
+ * user to hand-paste an entry under the PACKAGE-scoped key
+ * `@skillsmith/mcp-server` instead — a mismatch that let a user who both
+ * pasted the docs snippet AND ran `sklx agent install` end up with two
+ * different server entries coexisting in the same `mcp.json`, neither ever
+ * recognized as "the other's" by the installer's own conflict-detection
+ * (which matches purely on key). Aligning the installer's key to the docs
+ * snippet's key here means a docs-paste and an `agent install` reconcile as
+ * ONE entry: either recognized as ours and updated in place, or correctly
+ * detected as foreign (conflict) and left alone — never silently
+ * duplicated. See `agent-pack-installer.cursor-mcp.ts` for the write path
+ * (including the legacy-key cleanup for a pre-fix install that still has
+ * the old `'skillsmith'`-keyed entry) and `version-check.ts`'s
+ * `checkCursorMcpArtifact` for the read-side (`skillsmith diagnose`) use.
+ */
+export declare const CURSOR_MCP_ENTRY_KEY = "@skillsmith/mcp-server";
+/**
+ * The JSON key every pre-SMI-6279 `sklx agent install` run wrote Cursor's
+ * MCP entry under — kept as a named constant (not a bare literal) so the
+ * legacy-key cleanup step and the `diagnose` staleness check can both point
+ * at the exact same "this is the OLD key" definition instead of drifting.
+ */
+export declare const LEGACY_MCP_ENTRY_KEY = "skillsmith";
+/**
+ * Placeholder command text shown when {@link resolveSkillsmithMcpBinPath}
+ * can't resolve a real path — byte-identical to the human-facing
+ * instruction already shipped in the website/CLI-template Cursor snippets
+ * (SMI-5893 Wave 11), so a user who runs `agent install` before the resolve
+ * step succeeds sees the exact same next action the docs already describe.
+ */
+export declare const CURSOR_MCP_COMMAND_PLACEHOLDER = "<paste output of: which skillsmith-mcp (macOS/Linux) or where skillsmith-mcp (Windows)>";
+/**
+ * Resolve the on-disk path of the globally-installed `skillsmith-mcp`
+ * binary by shelling out to the exact command the docs already tell a
+ * human to run by hand — `which` on macOS/Linux, `where` on Windows
+ * (SMI-6279 Wave 9).
+ *
+ * There is no reliable programmatic equivalent that doesn't shell out:
+ * `@skillsmith/mcp-server` is a SEPARATE npm package from `@skillsmith/cli`
+ * (the package this code runs inside of) and is commonly NOT installed yet
+ * when `agent install` runs — it is a peer install the docs tell the user
+ * to do themselves (`npm install -g @skillsmith/mcp-server`). Node module
+ * resolution (`require.resolve`) only finds an already-installed package's
+ * importable entry point, not a DIFFERENT package's globally-linked `bin`
+ * symlink, and `process.execPath` is the Node binary running THIS process,
+ * not `skillsmith-mcp`'s location — neither is a substitute. `which`/`where`
+ * against the global npm bin directory (already on PATH for any shell the
+ * user installed from) is the SAME resolution the docs snippet instructs a
+ * human to do; this automates exactly that step rather than inventing a new
+ * one.
+ *
+ * Never throws and never hangs — returns `undefined` when the binary isn't
+ * found (an `agent install` run commonly happens BEFORE
+ * `@skillsmith/mcp-server` is installed; that is an expected outcome here,
+ * not an exceptional one) or when the lookup exceeds
+ * {@link BIN_RESOLVE_TIMEOUT_MS}.
+ */
+export declare function resolveSkillsmithMcpBinPath(): string | undefined;
+/**
+ * Cursor's own MCP server registration value (SMI-6279 Wave 9) — structurally
+ * different from {@link buildAgentMcpEntryValue} in two ways confirmed
+ * broken by the GH#2368 V3 repro:
+ *   1. `command` is a resolved binary path (or the documented paste-here
+ *      placeholder when resolution fails), never `npx` — two independent
+ *      live UAT passes proved `npx` ENOENTs inside Cursor's bundled Node.
+ *   2. `env.SKILLSMITH_CLIENT` is always set to `'cursor'` — without it,
+ *      Cursor installs silently land in the default `~/.claude/skills`
+ *      instead of `~/.cursor/skills` (SMI-5894 Wave 1 Step 7).
+ * `SKILLSMITH_TOOL_PROFILE` is unchanged from the generic builder — this is
+ * still the curated agent-pack registration, not a general-purpose one.
+ */
+export declare function buildCursorMcpEntryValue(): Record<string, unknown>;
 /**
  * OpenCode's `mcp`-key entry value (Step-6 verified against
  * opencode.ai/docs/mcp-servers/): entries are typed `local|remote`,
@@ -23,6 +109,37 @@ export declare function buildAgentMcpEntryValue(): Record<string, unknown>;
  * would produce an entry OpenCode's config schema rejects.
  */
 export declare function buildOpenCodeMcpEntryValue(): Record<string, unknown>;
+/**
+ * AntiGravity's own MCP server registration value (SMI-6275 Wave 5).
+ *
+ * Unlike Cursor, there is no verified evidence of an `npx`-inside-bundled-Node
+ * failure for AntiGravity (Wave 7 of the SMI-6266 plan makes the same call
+ * for the website/CLI docs snippet) — so this stays on the plain `npx` form,
+ * composed directly over {@link buildAgentMcpEntryValue} rather than
+ * reimplementing it. The one addition is `env.SKILLSMITH_CLIENT = 'antigravity'`,
+ * for the same reason Cursor's builder sets it (SMI-5894 Wave 1 Step 7):
+ * without it, an MCP server spawned from THIS entry would default to
+ * `~/.claude/skills` (`resolveClientPath()`'s fallback) instead of
+ * AntiGravity's own directories.
+ */
+export declare function buildAntigravityMcpEntryValue(): Record<string, unknown>;
+/**
+ * JSON key AntiGravity's `.agents/mcp_config.json` entry is installed under
+ * (SMI-6275 Wave 5) — deliberately the SAME value as {@link CURSOR_MCP_ENTRY_KEY},
+ * not the legacy `'skillsmith'` key every other non-Cursor harness's
+ * installer entry still uses. AntiGravity's OWN human-facing docs snippets
+ * (`packages/website/src/lib/mcp-client-snippets.ts`'s `STANDARD_JSON_BODY`
+ * and the CLI template's antigravity entry, both verified live 2026-08-30)
+ * already use the package-scoped key `@skillsmith/mcp-server` — aligning the
+ * installer's key here avoids the exact key-mismatch class of bug SMI-6279
+ * fixed for Cursor (a user who both pastes the docs snippet AND runs
+ * `agent install` ending up with two divergent, mutually-unrecognized
+ * entries). Unlike Cursor, AntiGravity has no PRE-EXISTING `agent install`
+ * writer to migrate away from — this is its first-ever implementation — so
+ * there is no legacy-keyed entry to clean up here (contrast
+ * `agent-pack-installer.cursor-mcp.ts`'s `stripStaleLegacyMcpKey`).
+ */
+export declare const ANTIGRAVITY_MCP_ENTRY_KEY = "@skillsmith/mcp-server";
 /** Codex `[mcp_servers.skillsmith]` TOML block (text between our markers). */
 export declare function buildCodexMcpTomlBlock(): string;
 /** Regex matching a bare (non-marker-delimited) `[mcp_servers.skillsmith]` table header. */

package/dist/src/install/agent-pack-installer.entry.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"agent-pack-installer.entry.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.entry.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAOH;;;;;GAKG;AACH,wBAAgB,uBAAuB,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAQjE;AAED;;;;;;GAMG;AACH,wBAAgB,0BAA0B,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CASpE;AAED,8EAA8E;AAC9E,wBAAgB,sBAAsB,IAAI,MAAM,CAS/C;AAED,4FAA4F;AAC5F,eAAO,MAAM,wBAAwB,QAAoD,CAAA;AAEzF,6FAA6F;AAC7F,eAAO,MAAM,2BAA2B,QAAqD,CAAA;AAE7F;;;;;;;;;GASG;AACH,wBAAgB,+BAA+B,CAAC,sBAAsB,EAAE,MAAM,GAAG,MAAM,CAQtF;AAED;;;;;;;;;;GAUG;AACH,eAAO,MAAM,iCAAiC,QAA8B,CAAA"}
+{"version":3,"file":"agent-pack-installer.entry.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.entry.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AASH;;;;;;;;;;;GAWG;AACH,wBAAgB,uBAAuB,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAQjE;AAED;;;;;;;;;;;;;;;;;;;;;;GAsBG;AACH,eAAO,MAAM,oBAAoB,2BAA2B,CAAA;AAE5D;;;;;GAKG;AACH,eAAO,MAAM,oBAAoB,eAAe,CAAA;AAEhD;;;;;;GAMG;AACH,eAAO,MAAM,8BAA8B,4FACgD,CAAA;AAc3F;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AACH,wBAAgB,2BAA2B,IAAI,MAAM,GAAG,SAAS,CAehE;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,wBAAwB,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CASlE;AAED;;;;;;GAMG;AACH,wBAAgB,0BAA0B,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CASpE;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,6BAA6B,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CASvE;AAED;;;;;;;;;;;;;;;GAeG;AACH,eAAO,MAAM,yBAAyB,2BAAuB,CAAA;AAE7D,8EAA8E;AAC9E,wBAAgB,sBAAsB,IAAI,MAAM,CAS/C;AAED,4FAA4F;AAC5F,eAAO,MAAM,wBAAwB,QAAoD,CAAA;AAEzF,6FAA6F;AAC7F,eAAO,MAAM,2BAA2B,QAAqD,CAAA;AAE7F;;;;;;;;;GASG;AACH,wBAAgB,+BAA+B,CAAC,sBAAsB,EAAE,MAAM,GAAG,MAAM,CAQtF;AAED;;;;;;;;;;GAUG;AACH,eAAO,MAAM,iCAAiC,QAA8B,CAAA"}