@skillsmith/core 0.11.4 → 0.11.5

package/dist/tests/unit/services/skill-installation.io.symlink.test.js

@@ -0,0 +1,72 @@
+/**
+ * @fileoverview writeInstallFiles nested sub-skill path + symlink-safety tests
+ * @see SMI-5905 final code review (Sol, GPT-5.6-Sol via NEEDLE) findings #2/#4
+ *
+ * Split out of skill-installation.io.test.ts (515/500 lines once these tests landed).
+ */
+import { describe, it, expect } from 'vitest';
+import * as fs from 'fs/promises';
+import * as os from 'os';
+import * as path from 'path';
+import { writeInstallFiles } from '../../../src/services/skill-installation.io.js';
+/**
+ * SMI-5905 Sol final-code-review findings #2/#4: nested sub-skill filenames (e.g.
+ * "scripts/run.sh", used by private-registry content installs) previously had no parent
+ * directory created (ENOENT on any clean install) and, once fixed, must not silently write
+ * through a pre-existing symlink at an intermediate path component.
+ */
+describe('writeInstallFiles nested sub-skill paths (SMI-5905 final review #2/#4)', () => {
+    it('creates the parent directory for a nested sub-skill filename', async () => {
+        const root = await fs.mkdtemp(path.join(os.tmpdir(), 'wif-nested-'));
+        try {
+            const skillsDir = path.join(root, 'skills');
+            await fs.mkdir(skillsDir, { recursive: true });
+            const installPath = path.join(skillsDir, 'my-skill');
+            const result = await writeInstallFiles(installPath, skillsDir, 'my-skill', '# hello', [{ filename: 'scripts/run.sh', content: 'echo hi' }], undefined);
+            expect(await fs.readFile(path.join(installPath, 'scripts', 'run.sh'), 'utf8')).toBe('echo hi');
+            expect(result.writtenFiles).toContain(path.join(installPath, 'scripts', 'run.sh'));
+        }
+        finally {
+            await fs.rm(root, { recursive: true, force: true }).catch(() => { });
+        }
+    });
+    it('creates parents for two nested files sharing the same new subdirectory (concurrent-write race)', async () => {
+        const root = await fs.mkdtemp(path.join(os.tmpdir(), 'wif-nested-race-'));
+        try {
+            const skillsDir = path.join(root, 'skills');
+            await fs.mkdir(skillsDir, { recursive: true });
+            const installPath = path.join(skillsDir, 'my-skill');
+            await writeInstallFiles(installPath, skillsDir, 'my-skill', '# hello', [
+                { filename: 'scripts/a.sh', content: 'a' },
+                { filename: 'scripts/b.sh', content: 'b' },
+            ], undefined);
+            expect(await fs.readFile(path.join(installPath, 'scripts', 'a.sh'), 'utf8')).toBe('a');
+            expect(await fs.readFile(path.join(installPath, 'scripts', 'b.sh'), 'utf8')).toBe('b');
+        }
+        finally {
+            await fs.rm(root, { recursive: true, force: true }).catch(() => { });
+        }
+    });
+    it('refuses to write through a pre-existing symlinked intermediate directory', async () => {
+        const root = await fs.mkdtemp(path.join(os.tmpdir(), 'wif-symlink-'));
+        try {
+            const skillsDir = path.join(root, 'skills');
+            await fs.mkdir(skillsDir, { recursive: true });
+            const installPath = path.join(skillsDir, 'my-skill');
+            await fs.mkdir(installPath, { recursive: true });
+            // A directory OUTSIDE skillsDir the attack would try to write into.
+            const outsideTarget = path.join(root, 'outside-target');
+            await fs.mkdir(outsideTarget, { recursive: true });
+            // Plant "scripts" as a symlink pointing outside skillsDir, as if left behind by a
+            // prior force-reinstall or planted directly by an attacker with local write access.
+            await fs.symlink(outsideTarget, path.join(installPath, 'scripts'));
+            await expect(writeInstallFiles(installPath, skillsDir, 'my-skill', '# hello', [{ filename: 'scripts/run.sh', content: 'malicious' }], undefined)).rejects.toThrow(/symlink/);
+            // Nothing was written to the symlink target.
+            await expect(fs.access(path.join(outsideTarget, 'run.sh'))).rejects.toThrow();
+        }
+        finally {
+            await fs.rm(root, { recursive: true, force: true }).catch(() => { });
+        }
+    });
+});
+//# sourceMappingURL=skill-installation.io.symlink.test.js.map

package/dist/tests/unit/services/skill-installation.io.symlink.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.io.symlink.test.js","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.io.symlink.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAA;AAC7C,OAAO,KAAK,EAAE,MAAM,aAAa,CAAA;AACjC,OAAO,KAAK,EAAE,MAAM,IAAI,CAAA;AACxB,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,EAAE,iBAAiB,EAAE,MAAM,gDAAgD,CAAA;AAElF;;;;;GAKG;AACH,QAAQ,CAAC,wEAAwE,EAAE,GAAG,EAAE;IACtF,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,IAAI,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,aAAa,CAAC,CAAC,CAAA;QACpE,IAAI,CAAC;YACH,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAA;YAC3C,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;YAC9C,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,UAAU,CAAC,CAAA;YAEpD,MAAM,MAAM,GAAG,MAAM,iBAAiB,CACpC,WAAW,EACX,SAAS,EACT,UAAU,EACV,SAAS,EACT,CAAC,EAAE,QAAQ,EAAE,gBAAgB,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,EACpD,SAAS,CACV,CAAA;YAED,MAAM,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,SAAS,EAAE,QAAQ,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;YAC9F,MAAM,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,SAAS,EAAE,QAAQ,CAAC,CAAC,CAAA;QACpF,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,EAAE,CAAC,IAAI,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;QACrE,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gGAAgG,EAAE,KAAK,IAAI,EAAE;QAC9G,MAAM,IAAI,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,kBAAkB,CAAC,CAAC,CAAA;QACzE,IAAI,CAAC;YACH,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAA;YAC3C,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;YAC9C,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,UAAU,CAAC,CAAA;YAEpD,MAAM,iBAAiB,CACrB,WAAW,EACX,SAAS,EACT,UAAU,EACV,SAAS,EACT;gBACE,EAAE,QAAQ,EAAE,cAAc,EAAE,OAAO,EAAE,GAAG,EAAE;gBAC1C,EAAE,QAAQ,EAAE,cAAc,EAAE,OAAO,EAAE,GAAG,EAAE;aAC3C,EACD,SAAS,CACV,CAAA;YAED,MAAM,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,SAAS,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;YACtF,MAAM,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,SAAS,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;QACxF,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,EAAE,CAAC,IAAI,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;QACrE,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,IAAI,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,cAAc,CAAC,CAAC,CAAA;QACrE,IAAI,CAAC;YACH,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAA;YAC3C,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;YAC9C,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,UAAU,CAAC,CAAA;YACpD,MAAM,EAAE,CAAC,KAAK,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;YAEhD,oEAAoE;YACpE,MAAM,aAAa,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAA;YACvD,MAAM,EAAE,CAAC,KAAK,CAAC,aAAa,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;YAElD,kFAAkF;YAClF,oFAAoF;YACpF,MAAM,EAAE,CAAC,OAAO,CAAC,aAAa,EAAE,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,SAAS,CAAC,CAAC,CAAA;YAElE,MAAM,MAAM,CACV,iBAAiB,CACf,WAAW,EACX,SAAS,EACT,UAAU,EACV,SAAS,EACT,CAAC,EAAE,QAAQ,EAAE,gBAAgB,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,EACtD,SAAS,CACV,CACF,CAAC,OAAO,CAAC,OAAO,CAAC,SAAS,CAAC,CAAA;YAE5B,6CAA6C;YAC7C,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;QAC/E,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,EAAE,CAAC,IAAI,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;QACrE,CAAC;IACH,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/unit/services/skill-installation.service.error-codes.test.d.ts

@@ -0,0 +1,15 @@
+/**
+ * SMI-4795: errorCode taxonomy on install failures
+ *
+ * Each failing return path inside install() must populate `errorCode` with
+ * a code from InstallErrorCode. Telemetry (emitInstallEvent) reads this
+ * field; without it the install funnel cannot classify failures.
+ *
+ * Split out of skill-installation.service.test.ts (CLAUDE.md's 500-line
+ * file cap) after SMI-5894 Wave 1 added its own multi-client suite there —
+ * this block predates that change and is unrelated to it, but moving it
+ * out (rather than the newly-added block alone) was the smallest change
+ * that got the original file back under the cap.
+ */
+export {};
+//# sourceMappingURL=skill-installation.service.error-codes.test.d.ts.map

package/dist/tests/unit/services/skill-installation.service.error-codes.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.service.error-codes.test.d.ts","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.service.error-codes.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG"}

package/dist/tests/unit/services/skill-installation.service.error-codes.test.js

@@ -0,0 +1,190 @@
+/**
+ * SMI-4795: errorCode taxonomy on install failures
+ *
+ * Each failing return path inside install() must populate `errorCode` with
+ * a code from InstallErrorCode. Telemetry (emitInstallEvent) reads this
+ * field; without it the install funnel cannot classify failures.
+ *
+ * Split out of skill-installation.service.test.ts (CLAUDE.md's 500-line
+ * file cap) after SMI-5894 Wave 1 added its own multi-client suite there —
+ * this block predates that change and is unrelated to it, but moving it
+ * out (rather than the newly-added block alone) was the smallest change
+ * that got the original file back under the cap.
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import * as fs from 'fs/promises';
+import * as path from 'path';
+import * as os from 'os';
+import { SkillInstallationService } from '../../../src/services/skill-installation.service.js';
+import { SkillRepository } from '../../../src/repositories/SkillRepository.js';
+import { SkillDependencyRepository } from '../../../src/repositories/SkillDependencyRepository.js';
+import { createTestDatabase } from '../../helpers/database.js';
+const VALID_SKILL_MD = `---
+name: test-skill
+description: A test skill for unit testing
+---
+
+# Test Skill
+
+This is a valid skill file with enough content to pass the 100-character minimum
+validation threshold that the service checks during installation.
+
+## Usage
+
+Use this skill by saying "Use the test-skill skill to..."
+`;
+const SHORT_SKILL_MD = '# Short\nToo short.';
+let tmpDir;
+let skillsDir;
+let manifestPath;
+async function createTmpDirs() {
+    tmpDir = path.join(os.tmpdir(), 'skillsmith-test-' + Date.now() + '-' + Math.random().toString(36).slice(2));
+    skillsDir = path.join(tmpDir, 'skills');
+    manifestPath = path.join(tmpDir, 'manifest.json');
+    await fs.mkdir(skillsDir, { recursive: true });
+}
+async function cleanupTmpDirs() {
+    await fs.rm(tmpDir, { recursive: true, force: true }).catch(() => { });
+}
+function createMockRegistryLookup(skills) {
+    return {
+        async lookup(skillId) {
+            const entry = skills[skillId];
+            if (!entry)
+                return null;
+            return {
+                repoUrl: entry.repoUrl,
+                name: entry.name,
+                trustTier: entry.trustTier ?? 'community',
+                quarantined: entry.quarantined,
+                contentHash: entry.contentHash,
+            };
+        },
+    };
+}
+function createService(db, overrides = {}) {
+    const skillRepo = new SkillRepository(db);
+    const skillDependencyRepo = new SkillDependencyRepository(db);
+    return new SkillInstallationService({
+        db,
+        skillRepo,
+        skillDependencyRepo,
+        skillsDir,
+        manifestPath,
+        ...overrides,
+    });
+}
+describe('SMI-4795: install failures populate errorCode', () => {
+    let db;
+    beforeEach(async () => {
+        db = await createTestDatabase();
+        await createTmpDirs();
+        vi.stubGlobal('fetch', vi.fn());
+    });
+    afterEach(async () => {
+        db.close();
+        await cleanupTmpDirs();
+        vi.restoreAllMocks();
+    });
+    it('REGISTRY_LOOKUP_UNAVAILABLE when registry id supplied without lookup adapter', async () => {
+        const service = createService(db); // no registryLookup
+        const result = await service.install('author/some-skill');
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('REGISTRY_LOOKUP_UNAVAILABLE');
+    });
+    it('REGISTRY_SKILL_NOT_FOUND when registry returns null', async () => {
+        const service = createService(db, {
+            registryLookup: createMockRegistryLookup({}), // empty registry
+        });
+        const result = await service.install('author/missing-skill');
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('REGISTRY_SKILL_NOT_FOUND');
+    });
+    it('QUARANTINED when registry flags the skill', async () => {
+        const service = createService(db, {
+            registryLookup: createMockRegistryLookup({
+                'author/quarantined-skill': {
+                    repoUrl: 'https://github.com/author/quarantined-skill',
+                    name: 'quarantined-skill',
+                    quarantined: true,
+                    trustTier: 'community',
+                },
+            }),
+        });
+        const result = await service.install('author/quarantined-skill');
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('QUARANTINED');
+        expect(result.trustTier).toBe('community');
+    });
+    it('FETCH_FAILED when SKILL.md is unreachable', async () => {
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockResolvedValue(new Response('Not found', { status: 404 }));
+        const service = createService(db);
+        const result = await service.install('https://github.com/owner/missing-repo');
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('FETCH_FAILED');
+    });
+    it('VALIDATION_FAILED when SKILL.md is malformed/short', async () => {
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(SHORT_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+        const service = createService(db);
+        const result = await service.install('https://github.com/owner/short-repo');
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('VALIDATION_FAILED');
+    });
+    it('ALREADY_INSTALLED on repeat install without force', async () => {
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(VALID_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+        const service = createService(db);
+        const first = await service.install('https://github.com/owner/dup-repo');
+        expect(first.success).toBe(true);
+        const second = await service.install('https://github.com/owner/dup-repo');
+        expect(second.success).toBe(false);
+        expect(second.errorCode).toBe('ALREADY_INSTALLED');
+    });
+    it('SKIP_SCAN_FORBIDDEN when skipScan requested on unknown tier', async () => {
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(VALID_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+        // Direct GitHub URL → trust tier defaults to 'unknown', skipScan disallowed
+        const service = createService(db);
+        const result = await service.install('https://github.com/owner/skip-repo', {
+            skipScan: true,
+        });
+        expect(result.success).toBe(false);
+        expect(result.errorCode).toBe('SKIP_SCAN_FORBIDDEN');
+        expect(result.trustTier).toBe('unknown');
+    });
+    it('successful install does NOT carry errorCode', async () => {
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(VALID_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+        const service = createService(db);
+        const result = await service.install('https://github.com/owner/ok-repo');
+        expect(result.success).toBe(true);
+        expect(result.errorCode).toBeUndefined();
+    });
+});
+//# sourceMappingURL=skill-installation.service.error-codes.test.js.map

package/dist/tests/unit/services/skill-installation.service.error-codes.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.service.error-codes.test.js","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.service.error-codes.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AACxE,OAAO,KAAK,EAAE,MAAM,aAAa,CAAA;AACjC,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,KAAK,EAAE,MAAM,IAAI,CAAA;AACxB,OAAO,EAAE,wBAAwB,EAAE,MAAM,qDAAqD,CAAA;AAC9F,OAAO,EAAE,eAAe,EAAE,MAAM,8CAA8C,CAAA;AAC9E,OAAO,EAAE,yBAAyB,EAAE,MAAM,wDAAwD,CAAA;AAClG,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAA;AAK9D,MAAM,cAAc,GAAG;;;;;;;;;;;;;CAatB,CAAA;AAED,MAAM,cAAc,GAAG,qBAAqB,CAAA;AAE5C,IAAI,MAAc,CAAA;AAClB,IAAI,SAAiB,CAAA;AACrB,IAAI,YAAoB,CAAA;AAExB,KAAK,UAAU,aAAa;IAC1B,MAAM,GAAG,IAAI,CAAC,IAAI,CAChB,EAAE,CAAC,MAAM,EAAE,EACX,kBAAkB,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,GAAG,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAC5E,CAAA;IACD,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAA;IACvC,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,eAAe,CAAC,CAAA;IACjD,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;AAChD,CAAC;AAED,KAAK,UAAU,cAAc;IAC3B,MAAM,EAAE,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;AACvE,CAAC;AAED,SAAS,wBAAwB,CAC/B,MASC;IAED,OAAO;QACL,KAAK,CAAC,MAAM,CAAC,OAAe;YAC1B,MAAM,KAAK,GAAG,MAAM,CAAC,OAAO,CAAC,CAAA;YAC7B,IAAI,CAAC,KAAK;gBAAE,OAAO,IAAI,CAAA;YACvB,OAAO;gBACL,OAAO,EAAE,KAAK,CAAC,OAAO;gBACtB,IAAI,EAAE,KAAK,CAAC,IAAI;gBAChB,SAAS,EAAE,KAAK,CAAC,SAAS,IAAK,WAAqB;gBACpD,WAAW,EAAE,KAAK,CAAC,WAAW;gBAC9B,WAAW,EAAE,KAAK,CAAC,WAAW;aAC/B,CAAA;QACH,CAAC;KACF,CAAA;AACH,CAAC;AAED,SAAS,aAAa,CACpB,EAAY,EACZ,YAAgF,EAAE;IAElF,MAAM,SAAS,GAAG,IAAI,eAAe,CAAC,EAAE,CAAC,CAAA;IACzC,MAAM,mBAAmB,GAAG,IAAI,yBAAyB,CAAC,EAAE,CAAC,CAAA;IAE7D,OAAO,IAAI,wBAAwB,CAAC;QAClC,EAAE;QACF,SAAS;QACT,mBAAmB;QACnB,SAAS;QACT,YAAY;QACZ,GAAG,SAAS;KACb,CAAC,CAAA;AACJ,CAAC;AAED,QAAQ,CAAC,+CAA+C,EAAE,GAAG,EAAE;IAC7D,IAAI,EAAY,CAAA;IAEhB,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,EAAE,GAAG,MAAM,kBAAkB,EAAE,CAAA;QAC/B,MAAM,aAAa,EAAE,CAAA;QACrB,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAA;IACjC,CAAC,CAAC,CAAA;IAEF,SAAS,CAAC,KAAK,IAAI,EAAE;QACnB,EAAE,CAAC,KAAK,EAAE,CAAA;QACV,MAAM,cAAc,EAAE,CAAA;QACtB,EAAE,CAAC,eAAe,EAAE,CAAA;IACtB,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8EAA8E,EAAE,KAAK,IAAI,EAAE;QAC5F,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA,CAAC,oBAAoB;QACtD,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAA;QAEzD,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAA;IAC9D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qDAAqD,EAAE,KAAK,IAAI,EAAE;QACnE,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,EAAE;YAChC,cAAc,EAAE,wBAAwB,CAAC,EAAE,CAAC,EAAE,iBAAiB;SAChE,CAAC,CAAA;QACF,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAA;QAE5D,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;IAC3D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,2CAA2C,EAAE,KAAK,IAAI,EAAE;QACzD,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,EAAE;YAChC,cAAc,EAAE,wBAAwB,CAAC;gBACvC,0BAA0B,EAAE;oBAC1B,OAAO,EAAE,6CAA6C;oBACtD,IAAI,EAAE,mBAAmB;oBACzB,WAAW,EAAE,IAAI;oBACjB,SAAS,EAAE,WAAW;iBACvB;aACF,CAAC;SACH,CAAC,CAAA;QACF,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAA;QAEhE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;QAC5C,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;IAC5C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,2CAA2C,EAAE,KAAK,IAAI,EAAE;QACzD,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,iBAAiB,CAAC,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC,CAAA;QAEvE,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QACjC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,uCAAuC,CAAC,CAAA;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IAC/C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YACzC,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;QAEF,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QACjC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,qCAAqC,CAAC,CAAA;QAE3E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,KAAK,IAAI,EAAE;QACjE,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YACzC,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;QAEF,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QACjC,MAAM,KAAK,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,mCAAmC,CAAC,CAAA;QACxE,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAEhC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,mCAAmC,CAAC,CAAA;QACzE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;QAC3E,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YACzC,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;QAEF,4EAA4E;QAC5E,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QACjC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,oCAAoC,EAAE;YACzE,QAAQ,EAAE,IAAI;SACf,CAAC,CAAA;QAEF,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,KAAK,IAAI,EAAE;QAC3D,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YACzC,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;QAEF,MAAM,OAAO,GAAG,aAAa,CAAC,EAAE,CAAC,CAAA;QACjC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,kCAAkC,CAAC,CAAA;QAExE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACjC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,aAAa,EAAE,CAAA;IAC1C,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/unit/services/skill-installation.service.multi-client.test.d.ts

@@ -0,0 +1,17 @@
+/**
+ * SMI-5894 Wave 1 Step 3: multi-client manifest re-keying
+ *
+ * getInstalledSkills() dedupes same-named skills across clients with
+ * Claude Code precedence; before this fix, SkillInstallationService wrote
+ * every manifest entry under a bare skill-name key regardless of client,
+ * so installing the same skill name under two clients silently collided
+ * (the second install's manifest write overwrote the first). This suite
+ * is the required cross-cutting regression scenario from the plan's
+ * Verification section (both Wave 1 and Wave 2 require coverage).
+ *
+ * Split out of skill-installation.service.test.ts (CLAUDE.md's 500-line
+ * file cap) rather than left inline -- this scenario is also cohesive
+ * enough to stand alone.
+ */
+export {};
+//# sourceMappingURL=skill-installation.service.multi-client.test.d.ts.map

package/dist/tests/unit/services/skill-installation.service.multi-client.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.service.multi-client.test.d.ts","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.service.multi-client.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG"}

package/dist/tests/unit/services/skill-installation.service.multi-client.test.js

@@ -0,0 +1,126 @@
+/**
+ * SMI-5894 Wave 1 Step 3: multi-client manifest re-keying
+ *
+ * getInstalledSkills() dedupes same-named skills across clients with
+ * Claude Code precedence; before this fix, SkillInstallationService wrote
+ * every manifest entry under a bare skill-name key regardless of client,
+ * so installing the same skill name under two clients silently collided
+ * (the second install's manifest write overwrote the first). This suite
+ * is the required cross-cutting regression scenario from the plan's
+ * Verification section (both Wave 1 and Wave 2 require coverage).
+ *
+ * Split out of skill-installation.service.test.ts (CLAUDE.md's 500-line
+ * file cap) rather than left inline -- this scenario is also cohesive
+ * enough to stand alone.
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import * as fs from 'fs/promises';
+import * as path from 'path';
+import * as os from 'os';
+import { SkillInstallationService } from '../../../src/services/skill-installation.service.js';
+import { SkillRepository } from '../../../src/repositories/SkillRepository.js';
+import { SkillDependencyRepository } from '../../../src/repositories/SkillDependencyRepository.js';
+import { createTestDatabase } from '../../helpers/database.js';
+const VALID_SKILL_MD = `---
+name: test-skill
+description: A test skill for unit testing
+---
+
+# Test Skill
+
+This is a valid skill file with enough content to pass the 100-character minimum
+validation threshold that the service checks during installation.
+
+## Usage
+
+Use this skill by saying "Use the test-skill skill to..."
+`;
+let tmpDir;
+let skillsDir;
+let manifestPath;
+async function createTmpDirs() {
+    tmpDir = path.join(os.tmpdir(), 'skillsmith-test-' + Date.now() + '-' + Math.random().toString(36).slice(2));
+    skillsDir = path.join(tmpDir, 'skills');
+    manifestPath = path.join(tmpDir, 'manifest.json');
+    await fs.mkdir(skillsDir, { recursive: true });
+}
+async function cleanupTmpDirs() {
+    await fs.rm(tmpDir, { recursive: true, force: true }).catch(() => { });
+}
+function createService(db, overrides = {}) {
+    const skillRepo = new SkillRepository(db);
+    const skillDependencyRepo = new SkillDependencyRepository(db);
+    return new SkillInstallationService({
+        db,
+        skillRepo,
+        skillDependencyRepo,
+        skillsDir,
+        manifestPath,
+        ...overrides,
+    });
+}
+describe('SMI-5894 Wave 1 Step 3: multi-client manifest re-keying', () => {
+    let db;
+    let cursorSkillsDir;
+    beforeEach(async () => {
+        db = await createTestDatabase();
+        await createTmpDirs();
+        vi.stubGlobal('fetch', vi.fn());
+        const mockFetch = vi.mocked(fetch);
+        mockFetch.mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(VALID_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+        cursorSkillsDir = path.join(tmpDir, 'cursor-skills');
+        await fs.mkdir(cursorSkillsDir, { recursive: true });
+    });
+    afterEach(async () => {
+        db.close();
+        await cleanupTmpDirs();
+        vi.restoreAllMocks();
+    });
+    it('installs the same skill name independently under two clients without collision', async () => {
+        const claudeService = createService(db, { client: 'claude-code' });
+        const cursorService = createService(db, { client: 'cursor', skillsDir: cursorSkillsDir });
+        const claudeResult = await claudeService.install('https://github.com/owner/test-repo', {
+            skipOptimize: true,
+        });
+        const cursorResult = await cursorService.install('https://github.com/owner/test-repo', {
+            skipOptimize: true,
+        });
+        expect(claudeResult.success).toBe(true);
+        expect(cursorResult.success).toBe(true);
+        const manifest = JSON.parse(await fs.readFile(manifestPath, 'utf-8'));
+        // Canonical client keeps the legacy bare-name key (backward compat).
+        expect(manifest.installedSkills['test-repo']).toBeDefined();
+        expect(manifest.installedSkills['test-repo'].installPath).toBe(path.join(skillsDir, 'test-repo'));
+        expect(manifest.installedSkills['test-repo'].client).toBe('claude-code');
+        // Non-canonical client gets a distinct composite key — does NOT
+        // overwrite the claude-code entry above.
+        expect(manifest.installedSkills['test-repo::cursor']).toBeDefined();
+        expect(manifest.installedSkills['test-repo::cursor'].installPath).toBe(path.join(cursorSkillsDir, 'test-repo'));
+        expect(manifest.installedSkills['test-repo::cursor'].client).toBe('cursor');
+        // Both physical directories exist independently.
+        await expect(fs.access(path.join(skillsDir, 'test-repo'))).resolves.toBeUndefined();
+        await expect(fs.access(path.join(cursorSkillsDir, 'test-repo'))).resolves.toBeUndefined();
+    });
+    it('uninstalling the Cursor copy leaves the Claude Code copy untouched (and vice versa)', async () => {
+        const claudeService = createService(db, { client: 'claude-code' });
+        const cursorService = createService(db, { client: 'cursor', skillsDir: cursorSkillsDir });
+        await claudeService.install('https://github.com/owner/test-repo', { skipOptimize: true });
+        await cursorService.install('https://github.com/owner/test-repo', { skipOptimize: true });
+        const uninstallResult = await cursorService.uninstall('test-repo');
+        expect(uninstallResult.success).toBe(true);
+        // Cursor copy removed from disk and the manifest...
+        await expect(fs.access(path.join(cursorSkillsDir, 'test-repo'))).rejects.toThrow();
+        const manifestAfterCursorRemove = JSON.parse(await fs.readFile(manifestPath, 'utf-8'));
+        expect(manifestAfterCursorRemove.installedSkills['test-repo::cursor']).toBeUndefined();
+        // ...but the Claude Code copy is untouched on disk and in the manifest.
+        await expect(fs.access(path.join(skillsDir, 'test-repo'))).resolves.toBeUndefined();
+        expect(manifestAfterCursorRemove.installedSkills['test-repo']).toBeDefined();
+    });
+});
+//# sourceMappingURL=skill-installation.service.multi-client.test.js.map

package/dist/tests/unit/services/skill-installation.service.multi-client.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.service.multi-client.test.js","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.service.multi-client.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AACxE,OAAO,KAAK,EAAE,MAAM,aAAa,CAAA;AACjC,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,KAAK,EAAE,MAAM,IAAI,CAAA;AACxB,OAAO,EAAE,wBAAwB,EAAE,MAAM,qDAAqD,CAAA;AAC9F,OAAO,EAAE,eAAe,EAAE,MAAM,8CAA8C,CAAA;AAC9E,OAAO,EAAE,yBAAyB,EAAE,MAAM,wDAAwD,CAAA;AAClG,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAA;AAG9D,MAAM,cAAc,GAAG;;;;;;;;;;;;;CAatB,CAAA;AAED,IAAI,MAAc,CAAA;AAClB,IAAI,SAAiB,CAAA;AACrB,IAAI,YAAoB,CAAA;AAExB,KAAK,UAAU,aAAa;IAC1B,MAAM,GAAG,IAAI,CAAC,IAAI,CAChB,EAAE,CAAC,MAAM,EAAE,EACX,kBAAkB,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,GAAG,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAC5E,CAAA;IACD,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAA;IACvC,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,eAAe,CAAC,CAAA;IACjD,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;AAChD,CAAC;AAED,KAAK,UAAU,cAAc;IAC3B,MAAM,EAAE,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;AACvE,CAAC;AAED,SAAS,aAAa,CACpB,EAAY,EACZ,YAAgF,EAAE;IAElF,MAAM,SAAS,GAAG,IAAI,eAAe,CAAC,EAAE,CAAC,CAAA;IACzC,MAAM,mBAAmB,GAAG,IAAI,yBAAyB,CAAC,EAAE,CAAC,CAAA;IAE7D,OAAO,IAAI,wBAAwB,CAAC;QAClC,EAAE;QACF,SAAS;QACT,mBAAmB;QACnB,SAAS;QACT,YAAY;QACZ,GAAG,SAAS;KACb,CAAC,CAAA;AACJ,CAAC;AAED,QAAQ,CAAC,yDAAyD,EAAE,GAAG,EAAE;IACvE,IAAI,EAAY,CAAA;IAChB,IAAI,eAAuB,CAAA;IAE3B,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,EAAE,GAAG,MAAM,kBAAkB,EAAE,CAAA;QAC/B,MAAM,aAAa,EAAE,CAAA;QAErB,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAA;QAC/B,MAAM,SAAS,GAAG,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAClC,SAAS,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YACzC,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;QAEF,eAAe,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,eAAe,CAAC,CAAA;QACpD,MAAM,EAAE,CAAC,KAAK,CAAC,eAAe,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,SAAS,CAAC,KAAK,IAAI,EAAE;QACnB,EAAE,CAAC,KAAK,EAAE,CAAA;QACV,MAAM,cAAc,EAAE,CAAA;QACtB,EAAE,CAAC,eAAe,EAAE,CAAA;IACtB,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,aAAa,GAAG,aAAa,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,aAAa,EAAE,CAAC,CAAA;QAClE,MAAM,aAAa,GAAG,aAAa,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC,CAAA;QAEzF,MAAM,YAAY,GAAG,MAAM,aAAa,CAAC,OAAO,CAAC,oCAAoC,EAAE;YACrF,YAAY,EAAE,IAAI;SACnB,CAAC,CAAA;QACF,MAAM,YAAY,GAAG,MAAM,aAAa,CAAC,OAAO,CAAC,oCAAoC,EAAE;YACrF,YAAY,EAAE,IAAI;SACnB,CAAC,CAAA;QAEF,MAAM,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACvC,MAAM,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC,CAAA;QACrE,qEAAqE;QACrE,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,WAAW,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;QAC3D,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,WAAW,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAC5D,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAClC,CAAA;QACD,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,WAAW,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;QACxE,gEAAgE;QAChE,yCAAyC;QACzC,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,mBAAmB,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;QACnE,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,mBAAmB,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CACpE,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,WAAW,CAAC,CACxC,CAAA;QACD,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,mBAAmB,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QAE3E,iDAAiD;QACjD,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;QACnF,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,WAAW,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;IAC3F,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qFAAqF,EAAE,KAAK,IAAI,EAAE;QACnG,MAAM,aAAa,GAAG,aAAa,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,aAAa,EAAE,CAAC,CAAA;QAClE,MAAM,aAAa,GAAG,aAAa,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC,CAAA;QAEzF,MAAM,aAAa,CAAC,OAAO,CAAC,oCAAoC,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAA;QACzF,MAAM,aAAa,CAAC,OAAO,CAAC,oCAAoC,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAA;QAEzF,MAAM,eAAe,GAAG,MAAM,aAAa,CAAC,SAAS,CAAC,WAAW,CAAC,CAAA;QAClE,MAAM,CAAC,eAAe,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAE1C,oDAAoD;QACpD,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,WAAW,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;QAClF,MAAM,yBAAyB,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC,CAAA;QACtF,MAAM,CAAC,yBAAyB,CAAC,eAAe,CAAC,mBAAmB,CAAC,CAAC,CAAC,aAAa,EAAE,CAAA;QAEtF,wEAAwE;QACxE,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;QACnF,MAAM,CAAC,yBAAyB,CAAC,eAAe,CAAC,WAAW,CAAC,CAAC,CAAC,WAAW,EAAE,CAAA;IAC9E,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/tests/unit/services/skill-installation.service.test.js

@@ -312,6 +312,9 @@ describe('SMI-3483: SkillInstallationService', () => {
             expect(manifest.installedSkills['test-repo'].source).toBe('github:owner/test-repo');
         });
     });
+    // SMI-5894 Wave 1 Step 3's multi-client manifest re-keying suite now
+    // lives in skill-installation.service.multi-client.test.ts (split out
+    // to stay under CLAUDE.md's 500-line file cap).
     // ==========================================================================
     // Uninstall
     // ==========================================================================
@@ -338,117 +341,9 @@ describe('SMI-3483: SkillInstallationService', () => {
             expect(forceResult.warning).toContain('not in the manifest');
         });
     });
-    // ==========================================================================
-    // SMI-4795: errorCode taxonomy on install failures
-    //
-    // Each failing return path inside install() must populate `errorCode` with
-    // a code from InstallErrorCode. Telemetry (emitInstallEvent) reads this
-    // field; without it the install funnel cannot classify failures.
-    // ==========================================================================
-    describe('SMI-4795: install failures populate errorCode', () => {
-        beforeEach(() => {
-            vi.stubGlobal('fetch', vi.fn());
-        });
-        it('REGISTRY_LOOKUP_UNAVAILABLE when registry id supplied without lookup adapter', async () => {
-            const service = createService(db); // no registryLookup
-            const result = await service.install('author/some-skill');
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('REGISTRY_LOOKUP_UNAVAILABLE');
-        });
-        it('REGISTRY_SKILL_NOT_FOUND when registry returns null', async () => {
-            const service = createService(db, {
-                registryLookup: createMockRegistryLookup({}), // empty registry
-            });
-            const result = await service.install('author/missing-skill');
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('REGISTRY_SKILL_NOT_FOUND');
-        });
-        it('QUARANTINED when registry flags the skill', async () => {
-            const service = createService(db, {
-                registryLookup: createMockRegistryLookup({
-                    'author/quarantined-skill': {
-                        repoUrl: 'https://github.com/author/quarantined-skill',
-                        name: 'quarantined-skill',
-                        quarantined: true,
-                        trustTier: 'community',
-                    },
-                }),
-            });
-            const result = await service.install('author/quarantined-skill');
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('QUARANTINED');
-            expect(result.trustTier).toBe('community');
-        });
-        it('FETCH_FAILED when SKILL.md is unreachable', async () => {
-            const mockFetch = vi.mocked(fetch);
-            mockFetch.mockResolvedValue(new Response('Not found', { status: 404 }));
-            const service = createService(db);
-            const result = await service.install('https://github.com/owner/missing-repo');
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('FETCH_FAILED');
-        });
-        it('VALIDATION_FAILED when SKILL.md is malformed/short', async () => {
-            const mockFetch = vi.mocked(fetch);
-            mockFetch.mockImplementation(async (url) => {
-                const urlStr = typeof url === 'string' ? url : url.toString();
-                if (urlStr.includes('SKILL.md')) {
-                    return new Response(SHORT_SKILL_MD, { status: 200 });
-                }
-                return new Response('Not found', { status: 404 });
-            });
-            const service = createService(db);
-            const result = await service.install('https://github.com/owner/short-repo');
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('VALIDATION_FAILED');
-        });
-        it('ALREADY_INSTALLED on repeat install without force', async () => {
-            const mockFetch = vi.mocked(fetch);
-            mockFetch.mockImplementation(async (url) => {
-                const urlStr = typeof url === 'string' ? url : url.toString();
-                if (urlStr.includes('SKILL.md')) {
-                    return new Response(VALID_SKILL_MD, { status: 200 });
-                }
-                return new Response('Not found', { status: 404 });
-            });
-            const service = createService(db);
-            const first = await service.install('https://github.com/owner/dup-repo');
-            expect(first.success).toBe(true);
-            const second = await service.install('https://github.com/owner/dup-repo');
-            expect(second.success).toBe(false);
-            expect(second.errorCode).toBe('ALREADY_INSTALLED');
-        });
-        it('SKIP_SCAN_FORBIDDEN when skipScan requested on unknown tier', async () => {
-            const mockFetch = vi.mocked(fetch);
-            mockFetch.mockImplementation(async (url) => {
-                const urlStr = typeof url === 'string' ? url : url.toString();
-                if (urlStr.includes('SKILL.md')) {
-                    return new Response(VALID_SKILL_MD, { status: 200 });
-                }
-                return new Response('Not found', { status: 404 });
-            });
-            // Direct GitHub URL → trust tier defaults to 'unknown', skipScan disallowed
-            const service = createService(db);
-            const result = await service.install('https://github.com/owner/skip-repo', {
-                skipScan: true,
-            });
-            expect(result.success).toBe(false);
-            expect(result.errorCode).toBe('SKIP_SCAN_FORBIDDEN');
-            expect(result.trustTier).toBe('unknown');
-        });
-        it('successful install does NOT carry errorCode', async () => {
-            const mockFetch = vi.mocked(fetch);
-            mockFetch.mockImplementation(async (url) => {
-                const urlStr = typeof url === 'string' ? url : url.toString();
-                if (urlStr.includes('SKILL.md')) {
-                    return new Response(VALID_SKILL_MD, { status: 200 });
-                }
-                return new Response('Not found', { status: 404 });
-            });
-            const service = createService(db);
-            const result = await service.install('https://github.com/owner/ok-repo');
-            expect(result.success).toBe(true);
-            expect(result.errorCode).toBeUndefined();
-        });
-    });
+    // SMI-4795's errorCode-taxonomy suite now lives in
+    // skill-installation.service.error-codes.test.ts (split out to stay
+    // under CLAUDE.md's 500-line file cap once SMI-5894 Wave 1 added its
+    // own multi-client suite here).
 });
 //# sourceMappingURL=skill-installation.service.test.js.map