@skillcdn/console 0.4.3 → 0.4.4

package/src/client.ts

@@ -498,6 +498,8 @@ export interface PluginClient {
   fileUrl(fileId: string): string;
   /** The bytes of a record's file, with the name and the type the console says. */
   readFile(fileId: string, signal?: AbortSignal): Promise<FileRead>;
+  /** A person's picture, for a frame, which names the person and never an address (ADR-0063). */
+  personPicture(personId: string, signal?: AbortSignal): Promise<FileRead>;
   /** Where the frame of a page or a widget is (ADR-0054), on a project when its key is given. */
   frameUrl(options: {
     readonly page?: string | undefined;
@@ -543,6 +545,8 @@ export interface PluginClient {
   disable(): Promise<RestPluginDetail>;
   /** Changes the settings' values, without secrets; `null` clears one. */
   updateSettings(patch: RestPluginSettingsPatch): Promise<RestPluginDetail>;
+  /** Says what an enabled plugin holds: those it requires, named again, and the optional ones to turn on. */
+  updateConsent(consent: readonly string[]): Promise<RestPluginDetail>;
   /** Seals a secret for the plugin; it is answered by nothing from then on. */
   setSecret(name: string, value: string): Promise<void>;
   removeSecret(name: string): Promise<void>;
@@ -1143,6 +1147,8 @@ export function createClient(options: ClientOptions = {}): ConsoleClient {
         ),
       fileUrl: (fileId) => `${base}${at("files", fileId)}`,
       readFile: (fileId, signal) => read(`${base}${at("files", fileId)}`, fileId, signal),
+      personPicture: (personId, signal) =>
+        read(`${base}${at("people", personId, "picture")}`, personId, signal),
       frameUrl: (options) =>
         withQuery(at("frame"), {
           page: options.page,
@@ -1213,6 +1219,8 @@ export function createClient(options: ClientOptions = {}): ConsoleClient {
       disable: () => request("POST", `${base}${at("disable")}`, undefined, restPluginDetailSchema),
       updateSettings: (patch) =>
         request("PATCH", `${base}${at("settings")}`, patch, restPluginDetailSchema),
+      updateConsent: (consent) =>
+        request("PATCH", `${base}${at("consent")}`, { consent }, restPluginDetailSchema),
       setSecret: (name, value) =>
         request("PUT", `${base}${at("secrets", name)}`, { value }, undefined),
       removeSecret: (name) =>

package/src/compat.ts

@@ -113,7 +113,7 @@ export interface ClientPolicy {
  * last changed what the command reads or sends (ADR-0038), whose changelog entry begins with
  * `Breaking:`; `pnpm check` holds it to a version the package has, or is about to have.
  */
-export const CLIENT_POLICY: ClientPolicy = { atLeast: "0.4.2" };
+export const CLIENT_POLICY: ClientPolicy = { atLeast: "0.4.4" };
 
 /**
  * The oldest console this command works with (ADR-0038): raised by the release that last

package/src/components/board.tsx

@@ -71,13 +71,13 @@ export interface BoardProps {
 export const FOLDED_STATES: readonly TaskState[] = ["done", "dropped"];
 
 /** How far a mouse travels on a card before the press is a drag and not a click. */
-const DRAG_SLACK = 4;
+export const DRAG_SLACK = 4;
 /**
  * How long a finger rests on a card before the card comes loose, and how far it may wander
  * meanwhile; a finger that moves sooner is scrolling the page, not moving the card.
  */
-const HOLD_MS = 300;
-const HOLD_SLACK = 8;
+export const HOLD_MS = 300;
+export const HOLD_SLACK = 8;
 /** How near the pointer comes to the board's edge before the board scrolls to show more columns. */
 const EDGE = 48;
 /** How fast the board scrolls, in pixels a second, with the pointer at the edge itself; slower further in. */

package/src/components/decision-form.tsx

@@ -1,6 +1,7 @@
 import { type ClipboardEvent, type FormEvent, useMemo, useState } from "react";
 import {
   MAX_BODY_LENGTH,
+  MAX_DECIDERS,
   MAX_FILES_PER_DECISION,
   MAX_OPTION_LABEL_LENGTH,
   MAX_OPTIONS,
@@ -39,6 +40,23 @@ export interface DecisionFormProps {
   readonly onCancel?: (() => void) | undefined;
 }
 
+/**
+ * What the form sends of whom the decision is for: nothing for the raiser alone, `deciderId` for
+ * one other person, `deciderIds` for several (ADR-0057), the first among them repeated as
+ * `deciderId` for a console of before.
+ */
+export function decidersInput(
+  deciders: readonly RestPerson[],
+  me: RestPerson | undefined,
+): Pick<RestDecisionInput, "deciderId" | "deciderIds"> {
+  const ids = deciders.map((person) => person.id);
+  if (ids.length === 0 || (ids.length === 1 && ids[0] === me?.id)) {
+    return {};
+  }
+  const first = ids[0] ?? "";
+  return ids.length === 1 ? { deciderId: first } : { deciderId: first, deciderIds: ids };
+}
+
 /** The people of the project found by the words typed, a page at a time, as a picker searches. */
 export function peopleSearch(people: readonly RestPerson[]): PickerSearch<RestPerson> {
   return async (query, page) => {
@@ -63,9 +81,20 @@ export function DecisionForm(props: DecisionFormProps) {
   const [body, setBody] = useState("");
   const [about, setAbout] = useState<RestTask | undefined>(undefined);
   const [options, setOptions] = useState<readonly string[]>(["", ""]);
-  const [decider, setDecider] = useState<RestPerson | undefined>(props.me);
+  // Whom it is for (ADR-0042, ADR-0057): the raiser, until others are named in their place.
+  const [deciders, setDeciders] = useState<readonly RestPerson[]>(
+    props.me === undefined ? [] : [props.me],
+  );
   const [files, setFiles] = useState<readonly File[]>([]);
-  const findDeciders = useMemo(() => peopleSearch(props.deciders ?? []), [props.deciders]);
+  const findDeciders = useMemo(
+    () =>
+      peopleSearch(
+        (props.deciders ?? []).filter(
+          (person) => !deciders.some((chosen) => chosen.id === person.id),
+        ),
+      ),
+    [props.deciders, deciders],
+  );
 
   const labels = options.map((option) => option.trim()).filter((option) => option.length > 0);
   const ready = question.trim().length > 0 && labels.length >= MIN_OPTIONS;
@@ -115,7 +144,7 @@ export function DecisionForm(props: DecisionFormProps) {
         body,
         options: labels.map((label) => ({ label })),
         taskId: props.taskId ?? about?.id ?? null,
-        ...(decider === undefined || decider.id === props.me?.id ? {} : { deciderId: decider.id }),
+        ...decidersInput(deciders, props.me),
       },
       files,
     );
@@ -195,24 +224,51 @@ export function DecisionForm(props: DecisionFormProps) {
         </div>
       )}
       {props.deciders !== undefined && (
-        <div className="sc-field">
-          <span className="sc-field-label">{form.decider}</span>
-          <Picker
-            value={decider}
-            search={findDeciders}
-            keyOf={(person) => person.id}
-            render={(person) => (
-              <>
-                <PersonChip person={person} size="sm" />
+        <fieldset className="sc-field sc-workers-field">
+          <legend className="sc-field-label">{form.decider}</legend>
+          <div className="sc-chips">
+            {deciders.map((person) => (
+              <span key={person.id} className="sc-chip">
+                <PersonChip person={person} />
                 {person.id === props.me?.id && <span className="sc-muted"> {form.me}</span>}
-              </>
+                <button
+                  type="button"
+                  className="sc-chip-remove"
+                  aria-label={`${words.common.remove}: ${personName(person)}`}
+                  disabled={props.busy}
+                  onClick={() =>
+                    setDeciders((current) => current.filter((chosen) => chosen.id !== person.id))
+                  }
+                >
+                  <span aria-hidden="true">&times;</span>
+                </button>
+              </span>
+            ))}
+            {deciders.length === 0 && <span className="sc-muted">{form.deciderPlaceholder}</span>}
+            {deciders.length < MAX_DECIDERS && (
+              <Picker
+                value={undefined}
+                search={findDeciders}
+                keyOf={(person) => person.id}
+                render={(person) => (
+                  <>
+                    <PersonChip person={person} size="sm" />
+                    {person.id === props.me?.id && <span className="sc-muted"> {form.me}</span>}
+                  </>
+                )}
+                label={form.addDecider}
+                placeholder={form.addDecider}
+                disabled={props.busy}
+                onChange={(person) => {
+                  if (person !== undefined) {
+                    setDeciders((current) => [...current, person]);
+                  }
+                }}
+              />
             )}
-            label={form.decider}
-            placeholder={form.deciderPlaceholder}
-            disabled={props.busy}
-            onChange={(person) => setDecider(person ?? props.me)}
-          />
-        </div>
+          </div>
+          {deciders.length > 1 && <p className="sc-field-hint">{form.decidersHint}</p>}
+        </fieldset>
       )}
       <fieldset className="sc-field sc-options">
         <legend className="sc-field-label">{form.options}</legend>

package/src/components/decision-list.tsx

@@ -8,6 +8,7 @@ import {
   type RestDecision,
   type RestDecisionFile,
   type RestDecisionPatch,
+  type RestPerson,
   type RestTask,
 } from "../api.js";
 import { useWords } from "../i18n/index.js";
@@ -43,13 +44,34 @@ export interface DecisionCardProps {
   readonly busy?: boolean | undefined;
 }
 
+/** The word beside who answered: through their agent, when the answer came that way (ADR-0056). */
+function answeredWord(words: ReturnType<typeof useWords>, agent: string | null | undefined) {
+  return agent === null || agent === undefined
+    ? words.decisions.answeredBy
+    : words.decisions.answeredThrough(agentLabel(agent));
+}
+
+/** Everyone a decision is addressed to (ADR-0057): `deciders` where the console answers it, else the one decider. */
+export function decidersOf(decision: RestDecision): readonly RestPerson[] {
+  return decision.deciders !== undefined && decision.deciders.length > 0
+    ? decision.deciders
+    : [decision.decider];
+}
+
+/** The names of everyone a decision is addressed to, one after another. */
+export function deciderNames(decision: RestDecision): string {
+  return decidersOf(decision).map(personName).join(", ");
+}
+
 /**
  * Who asked, and when: the person, through their agent when a run asked; and whom the decision
- * is for, where that is someone else (ADR-0042).
+ * is for, where that is not the asker alone (ADR-0042, ADR-0057).
  */
 function Asked(props: { readonly decision: RestDecision; readonly day?: boolean }) {
   const words = useWords();
   const { decision } = props;
+  const deciders = decidersOf(decision);
+  const addressed = deciders.some((person) => person.id !== decision.raisedBy.id);
   return (
     <>
       <PersonChip person={decision.raisedBy} />{" "}
@@ -57,18 +79,17 @@ function Asked(props: { readonly decision: RestDecision; readonly day?: boolean
         ? words.decisions.asked
         : words.decisions.askedThrough(agentLabel(decision.run.agent))}{" "}
       <Time iso={decision.createdAt} precision={props.day === true ? "day" : "minute"} />
-      {decision.decider.id !== decision.raisedBy.id && (
+      {addressed && (
         <span className="sc-decision-for">
           <span className="sc-visually-hidden">
-            {words.decisions.peopleLabel(
-              personName(decision.raisedBy),
-              personName(decision.decider),
-            )}
+            {words.decisions.peopleLabel(personName(decision.raisedBy), deciderNames(decision))}
           </span>
           <span className="sc-decision-arrow" aria-hidden="true">
             →
           </span>{" "}
-          <PersonChip person={decision.decider} />
+          {deciders.map((person) => (
+            <PersonChip key={person.id} person={person} />
+          ))}
         </span>
       )}
     </>
@@ -233,7 +254,20 @@ function Outcome(props: {
           {decision.outcome === null ? (
             <p className="sc-muted">{words.decisions.nothingWritten}</p>
           ) : (
-            <Markdown source={decision.outcome} docHref={props.docHref} />
+            <>
+              <Markdown source={decision.outcome} docHref={props.docHref} />
+              {decision.outcomeBy != null && decision.outcomeAt != null && (
+                <p className="sc-decision-meta">
+                  <PersonChip person={decision.outcomeBy} />{" "}
+                  {decision.outcomeAgent == null
+                    ? words.decisions.wroteWhatFollowed
+                    : words.decisions.wroteWhatFollowedThrough(
+                        agentLabel(decision.outcomeAgent),
+                      )}{" "}
+                  <Time iso={decision.outcomeAt} />
+                </p>
+              )}
+            </>
           )}
           {props.onUpdate !== undefined && (
             <Button
@@ -368,14 +402,12 @@ export function DecisionCard(props: DecisionCardProps) {
             </div>
           )}
           <p className="sc-decision-meta">
-            <PersonChip person={decision.answer.by} /> {words.decisions.answeredBy}{" "}
+            <PersonChip person={decision.answer.by} /> {answeredWord(words, decision.answer.agent)}{" "}
             <Time iso={decision.answer.at} />
           </p>
         </div>
       ) : props.onAnswer === undefined ? (
-        <p className="sc-decision-waiting">
-          {words.decisions.waitingFor(personName(decision.decider))}
-        </p>
+        <p className="sc-decision-waiting">{words.decisions.waitingFor(deciderNames(decision))}</p>
       ) : (
         <AnswerForm decision={decision} onAnswer={props.onAnswer} busy={props.busy} />
       )}
@@ -474,7 +506,7 @@ function RecordRow(props: {
             </div>
           )}
           <p className="sc-decision-record-meta">
-            <PersonChip person={answer.by} /> {words.decisions.answeredBy}{" "}
+            <PersonChip person={answer.by} /> {answeredWord(words, answer.agent)}{" "}
             <Time iso={answer.at} precision="day" />
           </p>
         </div>

package/src/components/event-feed.tsx

@@ -63,6 +63,10 @@ function sentenceOf(event: RestEvent, words: Messages): string {
       return feed.event.personDeactivated(login);
     case "person.reactivated":
       return feed.event.personReactivated(login);
+    case "person.manager_changed":
+      return data.manager === null || data.manager === undefined
+        ? feed.event.managerCleared(login)
+        : feed.event.managerChanged(login, data.manager);
     case "workspace.updated":
       return feed.event.workspaceUpdated(fields);
     case "project.created":
@@ -136,7 +140,9 @@ function sentenceOf(event: RestEvent, words: Messages): string {
     case "plugin.disabled":
       return feed.event.pluginDisabled(plugin);
     case "plugin.configured":
-      return feed.event.pluginConfigured(fields, plugin);
+      return data.capabilities === undefined
+        ? feed.event.pluginConfigured(fields, plugin)
+        : feed.event.pluginConsented(plugin);
     case "plugin.granted":
       return feed.event.pluginGranted(data.role ?? feed.role.other, grantee, plugin);
     case "plugin.revoked":

package/src/components/goals.tsx

@@ -1,5 +1,6 @@
 import { type FormEvent, type ReactNode, useState } from "react";
 import {
+  agentLabel,
   GOAL_STATES,
   type GoalState,
   MAX_BODY_LENGTH,
@@ -355,7 +356,9 @@ export function GoalView(props: GoalViewProps) {
           <div>
             <dt>{roadmap.setBy}</dt>
             <dd>
-              <PersonChip person={goal.createdBy} /> <Time iso={goal.createdAt} />
+              <PersonChip person={goal.createdBy} />{" "}
+              {goal.agent != null && <>{roadmap.setThrough(agentLabel(goal.agent))} </>}
+              <Time iso={goal.createdAt} />
             </dd>
           </div>
           {props.editHref !== undefined && (