@skillcap/gdh 0.26.5 → 0.26.6

package/INSTALL-BUNDLE.json

@@ -1,5 +1,5 @@
 {
   "product": "GDH",
-  "version": "0.26.5",
+  "version": "0.26.6",
   "installMode": "packaged_install"
 }

package/RELEASE-SPAN-UPDATE-CONTRACTS.json

@@ -3236,6 +3236,63 @@
           }
         ]
       }
+    },
+    {
+      "version": "0.26.6",
+      "releaseTag": "v0.26.6",
+      "migrationStatus": "required",
+      "summary": "v0.26.6 re-bakes managed authoring hooks so GDScript post-edit checks can prove the edited content. GDH_UPDATE_HOOK_VERSION moves 14 -> 15. Existing targets should self-update and migrate so hooks run a bounded foreground diagnostics refresh for inconclusive .gd edits before dispatching.",
+      "releaseHighlights": {
+        "summary": "v0.26.6 fixes the managed authoring hook proof loop for GDScript edits. When a `.gd` edit is not already proven by the cached broker snapshot, the hook now runs a bounded foreground diagnostics refresh, rereads the broker, and blocks or allows from diagnostics for the edited content instead of returning repeated `file_not_in_snapshot` or `content_hash_mismatch` hints.",
+        "operatorChanges": [
+          "**Post-edit GDScript diagnostics are proved before dispatch.** Inconclusive `.gd` hook checks now run `npx -y @skillcap/gdh@<pin> authoring diagnostics refresh --changed ...` inside the hook budget, then reread the broker before deciding.",
+          "**Fresh broker reads stay fast.** If the existing broker snapshot already covers the current file content, the hook still avoids npx and returns immediately.",
+          "**Fallback guidance is honest.** The hook no longer says \"next edit will be fresh.\" If foreground refresh cannot prove the edit, the message says bounded refresh failed to produce fresh evidence and gives the exact pinned `npx -y @skillcap/gdh@<pin>` command rather than assuming a global `gdh` binary exists."
+        ]
+      },
+      "updateContract": {
+        "summary": "Managed targets must re-bake generated authoring hooks so target-side post-edit GDScript validation uses the v0.26.6 foreground-refresh proof loop.",
+        "steps": [
+          {
+            "id": "install_v0_26_6",
+            "kind": "mechanical",
+            "summary": "Install the v0.26.6 GDH package.",
+            "detail": "Run gdh self-update so the target uses the v0.26.6 package and can re-render managed authoring hooks with update hook version 15.",
+            "commands": [
+              "gdh self-update --apply"
+            ],
+            "validationCommands": [
+              "gdh status",
+              "gdh adapters status"
+            ]
+          },
+          {
+            "id": "rebake_authoring_hook",
+            "kind": "mechanical",
+            "summary": "Re-bake managed authoring hook surfaces.",
+            "detail": "If lifecycle status reports pending managed-surface work, run gdh migrate --apply. The migration re-renders the authoring hook so inconclusive .gd post-edit checks run bounded foreground diagnostics refresh before falling back to context.",
+            "commands": [
+              "gdh migrate --apply"
+            ],
+            "validationCommands": [
+              "gdh adapters status",
+              "gdh status"
+            ]
+          },
+          {
+            "id": "confirm_gd_post_edit_proof",
+            "kind": "agent_reasoning",
+            "summary": "Confirm GDScript post-edit checks prove current content.",
+            "detail": "When dogfooding or validating a target, create or edit a temporary .gd file with an obvious type error and confirm the managed hook or gdh authoring diagnostics refresh reports diagnostics for the current file content. Then clear the error and confirm the same path returns clean.",
+            "commands": [
+              "gdh authoring diagnostics refresh --target <target> --changed <file.gd>"
+            ],
+            "validationCommands": [
+              "gdh authoring check --mode final --target <target>"
+            ]
+          }
+        ]
+      }
     }
   ]
 }

package/node_modules/@gdh/adapters/dist/templates/authoring-hook.js.tpl

@@ -20,6 +20,7 @@ const { spawnSync } = require('child_process');
 
 const AUTHORING_EXTENSIONS = new Set(['.gd', '.tscn', '.tres']);
 const CHECK_TIMEOUT_MS = readBoundedPositiveIntEnv('GDH_AUTHORING_HOOK_CHECK_TIMEOUT_MS', 2500, 10000);
+const FOREGROUND_REFRESH_TIMEOUT_MS = readBoundedPositiveIntEnv('GDH_AUTHORING_HOOK_REFRESH_TIMEOUT_MS', 8000, 30000);
 // Phase 82 / LSP-03: session-end ("Stop") freshness barrier. Default 60 s gives
 // real Godot LSP startup + final-mode authoring check headroom; hard cap 300 s
 // keeps the env var from becoming a denial-of-service surface.
@@ -52,25 +53,11 @@ function handlePostEdit(input, targetRoot) {
   const changed = collectChangedFiles(input, targetRoot);
   const authoring = changed.filter(isAuthoringValidationPath);
   if (authoring.length === 0) return allow();
-  // Phase 82 / LSP-02: fire-and-forget scoped diagnostics refresh BEFORE the
-  // bounded read. The verb calls `refreshAuthoringDiagnostics` which boots
-  // Godot LSP if needed, opens scoped files via LSP, drains diagnostics, and
-  // writes `diagnostics-broker/snapshot.json` + `primed` marker. Hook still
-  // returns within CHECK_TIMEOUT_MS regardless of refresh outcome (Pitfall 1:
-  // detached + stdio:'ignore' + .unref() means the parent never blocks on
-  // the child).
-  spawnDetachedRefresh(targetRoot, authoring);
-  // Quick task 260504-ix2: embedded broker-snapshot reader. Replaces the
-  // per-edit synchronous `npx -y @skillcap/gdh@PINNED authoring check ...`
-  // shellout (which was eating the full `CHECK_TIMEOUT_MS` budget on the npx
-  // bootstrap path even before any GDH code ran). The reader synthesises the
-  // same `[fresh]` / `[stale]` / `[pending]` bracketed-token vocabulary the
-  // existing dispatch already consumes, so the regex ladder below is unchanged.
   let output;
   try {
-    output = runEmbeddedDiagnosticsRead(targetRoot, authoring);
+    output = runPostEditDiagnostics(targetRoot, authoring);
   } catch (_err) {
-    return context('GDH post-edit hook embedded read threw; continuing without blocking. Run `gdh authoring check --mode final` before claiming code-validity.');
+    return context(`GDH post-edit hook embedded read threw; continuing without blocking. Run \`${gdhCommandPrefix()} authoring check --mode final --target ${JSON.stringify(targetRoot)}\` before claiming code-validity.`);
   }
   // Phase 81 / LSP-06 / D-01: dispatch on bracketed-token vocabulary.
   // Pitfall 5: anchor regex to line-start with /m flag so per-diagnostic
@@ -132,23 +119,11 @@ function handlePostToolBatch(input, targetRoot) {
   const authoring = unique(files).filter(isAuthoringValidationPath);
   if (authoring.length === 0) return allow();  // Pitfall 2: no authoring files — no work
 
-  // SC2: spawnDetachedRefresh reuses the lsp.lock-serialized helper. If a
-  // per-edit refresh is already in flight when this fires, the broker side
-  // serializes via the lock primitive — no double-spawn of Godot.
-  spawnDetachedRefresh(targetRoot, authoring);
-
-  // Quick task 260504-ix2: embedded broker-snapshot reader replaces the
-  // synchronous `npx ... authoring check` shellout. The reader is invoked
-  // ONCE with the full deduplicated authoring set — the LSP-09 coalescing
-  // invariant is preserved: the loop in `runEmbeddedDiagnosticsRead` walks
-  // every file but returns on the first non-fresh status (first-failure-wins
-  // is the documented contract; a [stale] in any one file routes the batch
-  // through the drift dispatch branch).
   let output;
   try {
-    output = runEmbeddedDiagnosticsRead(targetRoot, authoring);
+    output = runPostEditDiagnostics(targetRoot, authoring);
   } catch (_err) {
-    return context('GDH PostToolBatch hook embedded read threw; continuing without blocking. Run `gdh authoring check --mode final` before claiming code-validity.');
+    return context(`GDH PostToolBatch hook embedded read threw; continuing without blocking. Run \`${gdhCommandPrefix()} authoring check --mode final --target ${JSON.stringify(targetRoot)}\` before claiming code-validity.`);
   }
 
   // Bracketed-token dispatch — IDENTICAL to handlePostEdit. Pitfall 5 from Phase 81
@@ -181,6 +156,65 @@ function handlePostToolBatch(input, targetRoot) {
 // refresh --changed`. Detached spawn still uses `child_process.spawn` directly
 // (always did).
 
+// v0.26.6: trust-first post-edit loop.
+//
+// The old v0.26.4/v0.26.5 hook spawned a detached refresh and immediately read
+// the previous broker snapshot. That is a broken proof loop for real edits:
+// each edit changes the content hash, so the synchronous read is guaranteed to
+// see either `file_not_in_snapshot` or `content_hash_mismatch` until a refresh
+// for the new content has completed. The advertised "next edit will be fresh"
+// was therefore false for any edit that changed the file again.
+//
+// New contract:
+//   1. Read current broker snapshot.
+//   2. If conclusive ([fresh]/[failed]/[partial]), dispatch immediately.
+//   3. For .gd files only, run a bounded foreground diagnostics refresh, then
+//      read broker again. This is the only way a post-edit hook can prove the
+//      edited GDScript content it was asked to validate.
+//   4. If foreground refresh cannot prove within budget, spawn detached refresh
+//      as a fallback and emit non-blocking context.
+function runPostEditDiagnostics(targetRoot, authoringFiles) {
+  let output = runEmbeddedDiagnosticsRead(targetRoot, authoringFiles);
+  if (isConclusiveDiagnosticsOutput(output)) return output;
+
+  if (hasGdFiles(authoringFiles)) {
+    const refreshed = runForegroundDiagnosticsRefresh(targetRoot, authoringFiles);
+    if (refreshed) {
+      output = runEmbeddedDiagnosticsRead(targetRoot, authoringFiles);
+      if (isConclusiveDiagnosticsOutput(output)) return output;
+    }
+  }
+
+  spawnDetachedRefresh(targetRoot, authoringFiles);
+  return output;
+}
+
+function isConclusiveDiagnosticsOutput(output) {
+  return /^\[fresh\]/m.test(output) || /^\[failed\]/m.test(output) || /^\[partial\]/m.test(output);
+}
+
+function hasGdFiles(files) {
+  return Array.isArray(files) && files.some(f => path.extname(f).toLowerCase() === '.gd');
+}
+
+function runForegroundDiagnosticsRefresh(targetRoot, files) {
+  const gdFiles = Array.isArray(files) ? unique(files).filter(f => path.extname(f).toLowerCase() === '.gd') : [];
+  if (gdFiles.length === 0) return false;
+  try {
+    const args = ['-y', `@skillcap/gdh@${PINNED_VERSION}`, 'authoring', 'diagnostics', 'refresh', '--target', targetRoot];
+    for (const f of gdFiles) args.push('--changed', f);
+    const result = spawnSync('npx', args, {
+      cwd: targetRoot,
+      encoding: 'utf8',
+      timeout: FOREGROUND_REFRESH_TIMEOUT_MS,
+      windowsHide: true,
+    });
+    return !!result && !result.error && result.status === 0 && !result.signal;
+  } catch (_error) {
+    return false;
+  }
+}
+
 // Quick task 260504-o6w. Fire-and-forget scoped diagnostics refresh from the
 // post-edit hook. The CLI verb calls `refreshAuthoringDiagnostics` which boots
 // Godot LSP if needed, opens scoped files via LSP, drains diagnostics, and
@@ -686,19 +720,19 @@ function reasonHint(output, targetRoot, files) {
   const scopedHint = fileTypeScopedHint(targetArg, files);
   // First-match-wins ordering: more specific reasons before generic.
   if (reasons.includes('lsp_instance_identity_mismatch')) {
-    return `Cross-worktree LSP from another checkout. Run \`gdh lsp prune --target ${targetArg}\` then retry the edit.`;
+    return `Cross-worktree LSP from another checkout. Run \`${gdhCommandPrefix()} lsp prune --target ${targetArg}\` then retry the edit.`;
   }
   if (reasons.includes('lsp_state_lock_timeout')) {
     return `Authoring state lock busy; ${describeLspLock(targetRoot)} Retry the scoped command after the current authoring operation finishes. ${scopedHint}`;
   }
   if (reasons.includes('lsp_instance_not_running')) {
-    return `LSP launching in background; next edit will report fresh diagnostics. ${scopedHint}`;
+    return `LSP not ready inside hook budget; foreground refresh attempted for .gd files and background refresh is running if needed. ${scopedHint}`;
   }
   if (reasons.includes('broker_not_yet_primed') || reasons.includes('file_not_in_snapshot')) {
-    return `Broker priming in background; next edit will be fresh. ${scopedHint}`;
+    return `Broker did not contain this edit after bounded refresh; background refresh is running if needed. ${scopedHint}`;
   }
   if (reasons.includes('content_hash_mismatch') || reasons.includes('freshness_expired')) {
-    return `Broker snapshot stale; background refresh running. ${scopedHint}`;
+    return `Broker snapshot stale after bounded refresh; background refresh is running if needed. ${scopedHint}`;
   }
   return `Run scoped authoring validation before claiming code-validity. ${scopedHint}`;
 }
@@ -710,20 +744,24 @@ function fileTypeScopedHint(targetArg, files) {
   const resourceFiles = inputFiles.filter(f => path.extname(f).toLowerCase() === '.tres');
   const parts = [];
   if (gdFiles.length > 0) {
-    parts.push(`For .gd: \`gdh authoring diagnostics refresh --target ${targetArg}${changedArgs(gdFiles)}\``);
+    parts.push(`For .gd: \`${gdhCommandPrefix()} authoring diagnostics refresh --target ${targetArg}${changedArgs(gdFiles)}\``);
   }
   if (sceneFiles.length > 0) {
-    parts.push(`For .tscn: \`gdh authoring check --mode post-edit --target ${targetArg}${changedArgs(sceneFiles)}\``);
+    parts.push(`For .tscn: \`${gdhCommandPrefix()} authoring check --mode post-edit --target ${targetArg}${changedArgs(sceneFiles)}\``);
   }
   if (resourceFiles.length > 0) {
     parts.push('.tres automatic scoped validation is ignored in this GDH version; do not wait on LSP/resource diagnostics for those files.');
   }
   if (parts.length === 0) {
-    return `Run \`gdh authoring check --mode final --target ${targetArg}\` before claiming code-validity.`;
+    return `Run \`${gdhCommandPrefix()} authoring check --mode final --target ${targetArg}\` before claiming code-validity.`;
   }
   return parts.join(' ');
 }
 
+function gdhCommandPrefix() {
+  return `npx -y @skillcap/gdh@${PINNED_VERSION}`;
+}
+
 function changedArgs(files) {
   return files.map(f => ` --changed ${JSON.stringify(f)}`).join('');
 }

package/node_modules/@gdh/adapters/package.json

@@ -11,13 +11,13 @@
     }
   },
   "dependencies": {
-    "@gdh/authoring": "0.26.5",
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5",
-    "@gdh/observability": "0.26.5",
-    "@gdh/runtime": "0.26.5",
-    "@gdh/scan": "0.26.5",
-    "@gdh/verify": "0.26.5"
+    "@gdh/authoring": "0.26.6",
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6",
+    "@gdh/observability": "0.26.6",
+    "@gdh/runtime": "0.26.6",
+    "@gdh/scan": "0.26.6",
+    "@gdh/verify": "0.26.6"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/authoring/package.json

@@ -14,7 +14,7 @@
     "test": "vitest run"
   },
   "dependencies": {
-    "@gdh/core": "0.26.5"
+    "@gdh/core": "0.26.6"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/cli/package.json

@@ -15,16 +15,16 @@
   },
   "dependencies": {
     "@clack/prompts": "^1.2.0",
-    "@gdh/adapters": "0.26.5",
-    "@gdh/authoring": "0.26.5",
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5",
-    "@gdh/mcp": "0.26.5",
-    "@gdh/observability": "0.26.5",
-    "@gdh/runtime": "0.26.5",
-    "@gdh/scan": "0.26.5",
-    "@gdh/verify": "0.26.5",
+    "@gdh/adapters": "0.26.6",
+    "@gdh/authoring": "0.26.6",
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6",
+    "@gdh/mcp": "0.26.6",
+    "@gdh/observability": "0.26.6",
+    "@gdh/runtime": "0.26.6",
+    "@gdh/scan": "0.26.6",
+    "@gdh/verify": "0.26.6",
     "picocolors": "^1.1.1"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/core/dist/index.d.ts

@@ -55,7 +55,7 @@ export declare const GDH_AUTHORING_DOGFOOD_VERSION = 1;
 export declare const GDH_AUTHORING_SLICE_REPORT_VERSION = 1;
 export declare const GDH_MCP_MANIFEST_VERSION = 1;
 export declare const GDH_CURSOR_RULE_VERSION = 4;
-export declare const GDH_UPDATE_HOOK_VERSION = 14;
+export declare const GDH_UPDATE_HOOK_VERSION = 15;
 export declare const GDH_RUNTIME_RECIPE_RUN_VERSION = 1;
 export declare const GDH_RUNTIME_RUN_BUNDLE_VERSION = 1;
 export declare const GDH_RUNTIME_CORPUS_ARTIFACT_VERSION = 1;

package/node_modules/@gdh/core/dist/index.js

@@ -47,7 +47,7 @@ export const GDH_AUTHORING_DOGFOOD_VERSION = 1;
 export const GDH_AUTHORING_SLICE_REPORT_VERSION = 1;
 export const GDH_MCP_MANIFEST_VERSION = 1;
 export const GDH_CURSOR_RULE_VERSION = 4;
-export const GDH_UPDATE_HOOK_VERSION = 14;
+export const GDH_UPDATE_HOOK_VERSION = 15;
 export const GDH_RUNTIME_RECIPE_RUN_VERSION = 1;
 export const GDH_RUNTIME_RUN_BUNDLE_VERSION = 1;
 export const GDH_RUNTIME_CORPUS_ARTIFACT_VERSION = 1;

package/node_modules/@gdh/core/package.json

@@ -10,5 +10,5 @@
       "import": "./dist/index.js"
     }
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/docs/package.json

@@ -11,8 +11,8 @@
     }
   },
   "dependencies": {
-    "@gdh/core": "0.26.5",
+    "@gdh/core": "0.26.6",
     "yaml": "^2.8.3"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/mcp/package.json

@@ -11,14 +11,14 @@
     }
   },
   "dependencies": {
-    "@gdh/adapters": "0.26.5",
-    "@gdh/authoring": "0.26.5",
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5",
-    "@gdh/observability": "0.26.5",
-    "@gdh/scan": "0.26.5",
-    "@gdh/verify": "0.26.5",
+    "@gdh/adapters": "0.26.6",
+    "@gdh/authoring": "0.26.6",
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6",
+    "@gdh/observability": "0.26.6",
+    "@gdh/scan": "0.26.6",
+    "@gdh/verify": "0.26.6",
     "@modelcontextprotocol/sdk": "1.29.0"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/observability/package.json

@@ -11,7 +11,7 @@
     }
   },
   "dependencies": {
-    "@gdh/core": "0.26.5"
+    "@gdh/core": "0.26.6"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/runtime/package.json

@@ -11,9 +11,9 @@
     }
   },
   "dependencies": {
-    "@gdh/core": "0.26.5",
+    "@gdh/core": "0.26.6",
     "ws": "^8.18.3",
     "yaml": "^2.8.3"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/scan/package.json

@@ -11,8 +11,8 @@
     }
   },
   "dependencies": {
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5"
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/node_modules/@gdh/verify/package.json

@@ -11,13 +11,13 @@
     }
   },
   "dependencies": {
-    "@gdh/authoring": "0.26.5",
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5",
-    "@gdh/observability": "0.26.5",
-    "@gdh/runtime": "0.26.5",
-    "@gdh/scan": "0.26.5",
+    "@gdh/authoring": "0.26.6",
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6",
+    "@gdh/observability": "0.26.6",
+    "@gdh/runtime": "0.26.6",
+    "@gdh/scan": "0.26.6",
     "yaml": "^2.8.3"
   },
-  "version": "0.26.5"
+  "version": "0.26.6"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skillcap/gdh",
-  "version": "0.26.5",
+  "version": "0.26.6",
   "description": "Godot-specific authoring and validation harness for agentic development.",
   "license": "MIT",
   "type": "module",
@@ -31,17 +31,17 @@
     "releaseStage": "broader_internal_release"
   },
   "dependencies": {
-    "@gdh/cli": "0.26.5",
+    "@gdh/cli": "0.26.6",
     "@clack/prompts": "^1.2.0",
-    "@gdh/adapters": "0.26.5",
-    "@gdh/authoring": "0.26.5",
-    "@gdh/core": "0.26.5",
-    "@gdh/docs": "0.26.5",
-    "@gdh/mcp": "0.26.5",
-    "@gdh/observability": "0.26.5",
-    "@gdh/runtime": "0.26.5",
-    "@gdh/scan": "0.26.5",
-    "@gdh/verify": "0.26.5",
+    "@gdh/adapters": "0.26.6",
+    "@gdh/authoring": "0.26.6",
+    "@gdh/core": "0.26.6",
+    "@gdh/docs": "0.26.6",
+    "@gdh/mcp": "0.26.6",
+    "@gdh/observability": "0.26.6",
+    "@gdh/runtime": "0.26.6",
+    "@gdh/scan": "0.26.6",
+    "@gdh/verify": "0.26.6",
     "picocolors": "^1.1.1"
   },
   "bundledDependencies": [