@skbkontur/react-ui 4.4.0 → 4.5.2

package/lib/rootNode/getRootNode/getRootNode.js

@@ -1,10 +1,11 @@
 /* eslint-disable react/no-find-dom-node */
 import { findDOMNode } from 'react-dom';
+import warning from 'warning';
 import { isElement, isNode } from "../../SSRSafe";
 import { canUseDOM } from "../../client";
 import { isInstanceWithRootNode } from "../rootNodeDecorator";
 /**
- * Extracts component's root `Element` out of it's instance
+ * Extracts component's root Element (HTMLElement/SVGElement) out of it's instance
  * following the "StrictMode support convention" (@see README.md#strictmode, #2518).
  *
  * Replaces findDOMNode but falls back to it if "convention" is not respected.
@@ -14,14 +15,21 @@ import { isInstanceWithRootNode } from "../rootNodeDecorator";
  */
 
 export var getRootNode = function getRootNode(instance) {
+  /**
+   * Options of what instance can be:
+   *  1. null or undefined
+   *  2. DOM Element
+   *  3. class Component instance (object)
+   *  4. literally anything, returned from useImperativeHandle
+   */
   if (!canUseDOM || !instance) {
     // instance can be `null` if component was unmounted
-    // also checking undefined for convinient usage
+    // also checking undefined for convenient usage
     return null;
   }
 
   if (isElement(instance)) {
-    // instance can be a `Element` already if comming
+    // instance can be an Element already if its coming
     // from Refs of intrinsic elements (<div />, <button />, etc.)
     return instance;
   }
@@ -31,7 +39,7 @@ export var getRootNode = function getRootNode(instance) {
   if (isInstanceWithRootNode(instance)) {
     // it happened to be that native Node interface also has
     // the "getRootNode" method, but we can ignore it here
-    // because we'd already checked the instance on being an `Element`
+    // because we'd already checked the instance on being an Element
     // which is a subclass of Node, so, just fixing types here
     if (!isNode(instance)) {
       rootNode = instance.getRootNode();
@@ -39,15 +47,25 @@ export var getRootNode = function getRootNode(instance) {
   }
 
   if (rootNode !== undefined) {
-    // at this point, it is rather `Element` (what we are looking for)
-    // or null (which is also OK, e.g. Popup/Tooltip/Hint before opening), so, just return it
+    // the getter exists and has returned something, it should be what we are looking for
+    // probably its an Element or null (which is also OK, e.g. Popup/Tooltip/Hint before opening)
     return rootNode;
-  } // node is undefined, which means that the instance's root node getter doesn't exists or returns the undefined
-  // anyway, it tell us that the convention is not respected (by the component itself or its children),
-  // so, we have to fall back to the deprecated findDOMNode, which always works but breaks StrictMode
+  }
 
+  try {
+    // rootNode is undefined, which means that the getter doesn't exists or returns the undefined
+    // anyway, it tell us that the convention is not respected,
+    // so, we have to fall back to the deprecated findDOMNode, which breaks StrictMode
+    // instance can still be a class component or an imperative handle (i.e., anything, except null/undefined/Element)
+    rootNode = findDOMNode(instance);
+  } catch (e) {
+    // but findDOMNode doesn`t accept everything that instance can be at this point,
+    // so we have to handle exceptions
+    // see https://github.com/facebook/react/blob/cae63505/packages/react-dom/src/__tests__/findDOMNode-test.js#L66-L86
+    warning(false, '[getRootNode]: can`t fallback to findDOMNode.' + '\n' + 'See https://github.com/skbkontur/retail-ui/blob/master/packages/react-ui/README.md#strictmode' + '\n\n' + e.message);
+    return null;
+  } // the findDOMNode can also return Text, but we are only interested in Elements, so just filter it
 
-  rootNode = findDOMNode(instance); // the findDOMNode can also return Text, but we are only intrested in HTMLElements, so just filter it
 
   return isElement(rootNode) ? rootNode : null;
 };

package/lib/rootNode/getRootNode/getRootNode.js.map

@@ -1 +1 @@
-{"version":3,"sources":["getRootNode.ts"],"names":["findDOMNode","isElement","isNode","canUseDOM","isInstanceWithRootNode","getRootNode","instance","rootNode","undefined"],"mappings":"AAAA;AACA,SAASA,WAAT,QAA4B,WAA5B;;;;AAIA,SAASC,SAAT,EAAoBC,MAApB,QAAkC,YAAlC;AACA,SAASC,SAAT,QAA0B,WAA1B;;AAEA,SAASC,sBAAT,QAAuC,qBAAvC;;AAEA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;;AAEA,OAAO,IAAMC,WAAW,GAAG,SAAdA,WAAc,CAACC,QAAD,EAAgE;AACzF,MAAI,CAACH,SAAD,IAAc,CAACG,QAAnB,EAA6B;AAC3B;AACA;AACA,WAAO,IAAP;AACD;;AAED,MAAIL,SAAS,CAACK,QAAD,CAAb,EAAyB;AACvB;AACA;AACA,WAAOA,QAAP;AACD;;AAED,MAAIC,QAAJ;;AAEA,MAAIH,sBAAsB,CAACE,QAAD,CAA1B,EAAsC;AACpC;AACA;AACA;AACA;AACA,QAAI,CAACJ,MAAM,CAACI,QAAD,CAAX,EAAuB;AACrBC,MAAAA,QAAQ,GAAGD,QAAQ,CAACD,WAAT,EAAX;AACD;AACF;;AAED,MAAIE,QAAQ,KAAKC,SAAjB,EAA4B;AAC1B;AACA;AACA,WAAOD,QAAP;AACD;;AAED;AACA;AACA;AACAA,EAAAA,QAAQ,GAAGP,WAAW,CAACM,QAAD,CAAtB;;AAEA;AACA,SAAOL,SAAS,CAACM,QAAD,CAAT,GAAsBA,QAAtB,GAAiC,IAAxC;AACD,CAtCM","sourcesContent":["/* eslint-disable react/no-find-dom-node */\nimport { findDOMNode } from 'react-dom';\nimport React from 'react';\n\nimport { Nullable } from '../../typings/utility-types';\nimport { isElement, isNode } from '../SSRSafe';\nimport { canUseDOM } from '../client';\n\nimport { isInstanceWithRootNode } from './rootNodeDecorator';\n\n/**\n * Extracts component's root `Element` out of it's instance\n * following the \"StrictMode support convention\" (@see README.md#strictmode, #2518).\n *\n * Replaces findDOMNode but falls back to it if \"convention\" is not respected.\n *\n * @param instance Component's instance provided by React.Ref or `this` inside class-components.\n * @returns Component's root `Element` or null\n */\n\nexport const getRootNode = (instance: Nullable<React.ReactInstance>): Nullable<Element> => {\n  if (!canUseDOM || !instance) {\n    // instance can be `null` if component was unmounted\n    // also checking undefined for convinient usage\n    return null;\n  }\n\n  if (isElement(instance)) {\n    // instance can be a `Element` already if comming\n    // from Refs of intrinsic elements (<div />, <button />, etc.)\n    return instance;\n  }\n\n  let rootNode;\n\n  if (isInstanceWithRootNode(instance)) {\n    // it happened to be that native Node interface also has\n    // the \"getRootNode\" method, but we can ignore it here\n    // because we'd already checked the instance on being an `Element`\n    // which is a subclass of Node, so, just fixing types here\n    if (!isNode(instance)) {\n      rootNode = instance.getRootNode();\n    }\n  }\n\n  if (rootNode !== undefined) {\n    // at this point, it is rather `Element` (what we are looking for)\n    // or null (which is also OK, e.g. Popup/Tooltip/Hint before opening), so, just return it\n    return rootNode;\n  }\n\n  // node is undefined, which means that the instance's root node getter doesn't exists or returns the undefined\n  // anyway, it tell us that the convention is not respected (by the component itself or its children),\n  // so, we have to fall back to the deprecated findDOMNode, which always works but breaks StrictMode\n  rootNode = findDOMNode(instance);\n\n  // the findDOMNode can also return Text, but we are only intrested in HTMLElements, so just filter it\n  return isElement(rootNode) ? rootNode : null;\n};\n"]}
+{"version":3,"sources":["getRootNode.ts"],"names":["findDOMNode","warning","isElement","isNode","canUseDOM","isInstanceWithRootNode","getRootNode","instance","rootNode","undefined","e","message"],"mappings":"AAAA;AACA,SAASA,WAAT,QAA4B,WAA5B;;AAEA,OAAOC,OAAP,MAAoB,SAApB;;;AAGA,SAASC,SAAT,EAAoBC,MAApB,QAAkC,YAAlC;AACA,SAASC,SAAT,QAA0B,WAA1B;;AAEA,SAASC,sBAAT,QAAuC,qBAAvC;;AAEA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;;AAEA,OAAO,IAAMC,WAAW,GAAG,SAAdA,WAAc,CAACC,QAAD,EAAgE;AACzF;AACF;AACA;AACA;AACA;AACA;AACA;;AAEE,MAAI,CAACH,SAAD,IAAc,CAACG,QAAnB,EAA6B;AAC3B;AACA;AACA,WAAO,IAAP;AACD;;AAED,MAAIL,SAAS,CAACK,QAAD,CAAb,EAAyB;AACvB;AACA;AACA,WAAOA,QAAP;AACD;;AAED,MAAIC,QAAJ;;AAEA,MAAIH,sBAAsB,CAACE,QAAD,CAA1B,EAAsC;AACpC;AACA;AACA;AACA;AACA,QAAI,CAACJ,MAAM,CAACI,QAAD,CAAX,EAAuB;AACrBC,MAAAA,QAAQ,GAAGD,QAAQ,CAACD,WAAT,EAAX;AACD;AACF;;AAED,MAAIE,QAAQ,KAAKC,SAAjB,EAA4B;AAC1B;AACA;AACA,WAAOD,QAAP;AACD;;AAED,MAAI;AACF;AACA;AACA;AACA;AACAA,IAAAA,QAAQ,GAAGR,WAAW,CAACO,QAAD,CAAtB;AACD,GAND,CAME,OAAOG,CAAP,EAAU;AACV;AACA;AACA;AACAT,IAAAA,OAAO;AACL,SADK;AAEL;AACE,QADF;AAEE,mGAFF;AAGE,UAHF;AAIES,IAAAA,CAAC,CAACC,OANC,CAAP;;AAQA,WAAO,IAAP;AACD;;AAED;AACA,SAAOT,SAAS,CAACM,QAAD,CAAT,GAAsBA,QAAtB,GAAiC,IAAxC;AACD,CA9DM","sourcesContent":["/* eslint-disable react/no-find-dom-node */\nimport { findDOMNode } from 'react-dom';\nimport React from 'react';\nimport warning from 'warning';\n\nimport { Nullable } from '../../typings/utility-types';\nimport { isElement, isNode } from '../SSRSafe';\nimport { canUseDOM } from '../client';\n\nimport { isInstanceWithRootNode } from './rootNodeDecorator';\n\n/**\n * Extracts component's root Element (HTMLElement/SVGElement) out of it's instance\n * following the \"StrictMode support convention\" (@see README.md#strictmode, #2518).\n *\n * Replaces findDOMNode but falls back to it if \"convention\" is not respected.\n *\n * @param instance Component's instance provided by React.Ref or `this` inside class-components.\n * @returns Component's root `Element` or null\n */\n\nexport const getRootNode = (instance: Nullable<React.ReactInstance>): Nullable<Element> => {\n  /**\n   * Options of what instance can be:\n   *  1. null or undefined\n   *  2. DOM Element\n   *  3. class Component instance (object)\n   *  4. literally anything, returned from useImperativeHandle\n   */\n\n  if (!canUseDOM || !instance) {\n    // instance can be `null` if component was unmounted\n    // also checking undefined for convenient usage\n    return null;\n  }\n\n  if (isElement(instance)) {\n    // instance can be an Element already if its coming\n    // from Refs of intrinsic elements (<div />, <button />, etc.)\n    return instance;\n  }\n\n  let rootNode;\n\n  if (isInstanceWithRootNode(instance)) {\n    // it happened to be that native Node interface also has\n    // the \"getRootNode\" method, but we can ignore it here\n    // because we'd already checked the instance on being an Element\n    // which is a subclass of Node, so, just fixing types here\n    if (!isNode(instance)) {\n      rootNode = instance.getRootNode();\n    }\n  }\n\n  if (rootNode !== undefined) {\n    // the getter exists and has returned something, it should be what we are looking for\n    // probably its an Element or null (which is also OK, e.g. Popup/Tooltip/Hint before opening)\n    return rootNode;\n  }\n\n  try {\n    // rootNode is undefined, which means that the getter doesn't exists or returns the undefined\n    // anyway, it tell us that the convention is not respected,\n    // so, we have to fall back to the deprecated findDOMNode, which breaks StrictMode\n    // instance can still be a class component or an imperative handle (i.e., anything, except null/undefined/Element)\n    rootNode = findDOMNode(instance);\n  } catch (e) {\n    // but findDOMNode doesn`t accept everything that instance can be at this point,\n    // so we have to handle exceptions\n    // see https://github.com/facebook/react/blob/cae63505/packages/react-dom/src/__tests__/findDOMNode-test.js#L66-L86\n    warning(\n      false,\n      '[getRootNode]: can`t fallback to findDOMNode.' +\n        '\\n' +\n        'See https://github.com/skbkontur/retail-ui/blob/master/packages/react-ui/README.md#strictmode' +\n        '\\n\\n' +\n        e.message,\n    );\n    return null;\n  }\n\n  // the findDOMNode can also return Text, but we are only interested in Elements, so just filter it\n  return isElement(rootNode) ? rootNode : null;\n};\n"]}

package/lib/rootNode/getRootNode.d.ts

@@ -1,7 +1,7 @@
 import React from 'react';
 import { Nullable } from '../../typings/utility-types';
 /**
- * Extracts component's root `Element` out of it's instance
+ * Extracts component's root Element (HTMLElement/SVGElement) out of it's instance
  * following the "StrictMode support convention" (@see README.md#strictmode, #2518).
  *
  * Replaces findDOMNode but falls back to it if "convention" is not respected.

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@skbkontur/react-ui",
-  "version": "4.4.0",
+  "version": "4.5.2",
   "description": "UI Components",
   "main": "cjs/index.js",
   "module": "index.js",
   "sideEffects": false,
-  "homepage": "https://tech.skbkontur.ru/react-ui/4.4.0/",
+  "homepage": "https://tech.skbkontur.ru/react-ui/4.5.2/",
   "repository": {
     "type": "git",
     "url": "git@github.com:skbkontur/retail-ui.git"
@@ -151,24 +151,7 @@
     "react": ">=16.9",
     "react-dom": ">=16.9"
   },
-  "jest": {
-    "testResultsProcessor": "jest-teamcity-reporter",
-    "moduleNameMapper": {
-      "\\.(css|less)$": "identity-obj-proxy"
-    },
-    "transform": {
-      "\\.[jt]sx?$": "babel-jest"
-    },
-    "testRegex": "__tests__(\\\\|/).*(\\.|-)test\\.(j|t)sx?$",
-    "testEnvironment": "jsdom",
-    "setupFilesAfterEnv": [
-      "<rootDir>/test-setup.js"
-    ],
-    "transformIgnorePatterns": [
-      "<rootDir>/node_modules/"
-    ]
-  },
   "publishConfig": {
-    "tag": "old-version"
+    "tag": "latest"
   }
 }