@sjawhar/pi-legion 10.4.0 → 10.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/legion.js +79 -31
- package/dist/skills/legion-architect/SKILL.md +2 -1
- package/dist/skills/legion-controller/SKILL.md +11 -9
- package/dist/skills/legion-controller/references/slack-mentions.md +94 -0
- package/dist/skills/legion-worker/references/merge-gate.md +30 -17
- package/package.json +2 -2
package/dist/legion.js
CHANGED
|
@@ -14090,7 +14090,17 @@ function dispatchSettings(env, config2) {
|
|
|
14090
14090
|
}
|
|
14091
14091
|
const url2 = (explicitUrl ?? (source.kind === "file" ? source.server : own.serverUrl ?? DEFAULT_SERVER_URL)).replace(/\/+$/, "");
|
|
14092
14092
|
const token = source.kind === "variable" ? source.token : fileBearer(source, url2, "DISPATCH", env);
|
|
14093
|
-
|
|
14093
|
+
const publicUrl = nonEmpty(env.DISPATCH_PUBLIC_URL);
|
|
14094
|
+
const publicParsed = publicUrl === undefined ? undefined : httpUrl2(publicUrl);
|
|
14095
|
+
if (publicUrl !== undefined && (publicParsed === undefined || publicParsed.port === "0")) {
|
|
14096
|
+
return offWithError("DISPATCH_PUBLIC_URL must be an http or https URL");
|
|
14097
|
+
}
|
|
14098
|
+
return {
|
|
14099
|
+
enabled: true,
|
|
14100
|
+
url: url2,
|
|
14101
|
+
token,
|
|
14102
|
+
...publicUrl === undefined ? {} : { publicUrl: publicUrl.replace(/\/+$/, "") }
|
|
14103
|
+
};
|
|
14094
14104
|
} catch (error48) {
|
|
14095
14105
|
return offWithError(messageFor(error48));
|
|
14096
14106
|
}
|
|
@@ -14902,6 +14912,11 @@ function controllerToken(project) {
|
|
|
14902
14912
|
assertLegionProjectToken(project);
|
|
14903
14913
|
return `legion-${project}-controller`;
|
|
14904
14914
|
}
|
|
14915
|
+
// ../contracts/src/slack.ts
|
|
14916
|
+
var SLACK_CHANNEL_ID_PATTERN = /^[CG][A-Z0-9]+$/;
|
|
14917
|
+
function slackMentionTopic(channel) {
|
|
14918
|
+
return `notifications.slack.*.${channel}.mention`;
|
|
14919
|
+
}
|
|
14905
14920
|
// ../envoy-client/src/ask-answer.ts
|
|
14906
14921
|
var HEAD_LENGTH = 120;
|
|
14907
14922
|
function textHead(text) {
|
|
@@ -15540,7 +15555,7 @@ function sessionDispatchSettings(file2, env, options) {
|
|
|
15540
15555
|
|
|
15541
15556
|
// ../pi-shared/src/interface.ts
|
|
15542
15557
|
import { logger } from "@oh-my-pi/pi-utils";
|
|
15543
|
-
var ENVOY_PLUGIN_INTERFACE_VERSION =
|
|
15558
|
+
var ENVOY_PLUGIN_INTERFACE_VERSION = 3;
|
|
15544
15559
|
var ENVOY_PLUGIN_INTERFACE_KEY = Symbol.for("legion.pi-shared.envoy-plugin-interface");
|
|
15545
15560
|
var LEGION_PLUGIN_LOADED_KEY = Symbol.for("legion.pi-legion.loaded");
|
|
15546
15561
|
var LEGACY_LEGION_LOADED_KEY = Symbol.for("legion.pi-envoy.legion-loaded");
|
|
@@ -15553,7 +15568,12 @@ function envoyPluginInterface() {
|
|
|
15553
15568
|
const created = {
|
|
15554
15569
|
version: ENVOY_PLUGIN_INTERFACE_VERSION,
|
|
15555
15570
|
publishers: [],
|
|
15556
|
-
roleClaim: {
|
|
15571
|
+
roleClaim: {
|
|
15572
|
+
instances: [],
|
|
15573
|
+
managedSessions: new Set,
|
|
15574
|
+
regained: undefined,
|
|
15575
|
+
slackRoleOwned: false
|
|
15576
|
+
},
|
|
15557
15577
|
injectedUserTurns: new Map,
|
|
15558
15578
|
bootstrappedSession: { file: undefined }
|
|
15559
15579
|
};
|
|
@@ -15627,6 +15647,29 @@ function messageTag(message) {
|
|
|
15627
15647
|
return typeof message.tag === "string" ? message.tag : undefined;
|
|
15628
15648
|
}
|
|
15629
15649
|
|
|
15650
|
+
// ../pi-shared/src/role-claim-bridge.ts
|
|
15651
|
+
function legionRoleClaimBridge() {
|
|
15652
|
+
return envoyPluginInterface().roleClaim;
|
|
15653
|
+
}
|
|
15654
|
+
async function claimEnvoyRole(sessionID, role, context) {
|
|
15655
|
+
const bridge = legionRoleClaimBridge();
|
|
15656
|
+
bridge.managedSessions.add(sessionID);
|
|
15657
|
+
const instance = bridge.instances.findLast((candidate) => candidate.sessionID() === sessionID) ?? bridge.instances.at(-1);
|
|
15658
|
+
if (instance === undefined)
|
|
15659
|
+
throw new Error("Envoy has no bound instance for a role claim");
|
|
15660
|
+
await instance.claim(sessionID, role, context);
|
|
15661
|
+
}
|
|
15662
|
+
async function subscribeLegionNotice(sessionID, topic, context, whileHolding) {
|
|
15663
|
+
const bridge = legionRoleClaimBridge();
|
|
15664
|
+
const instance = bridge.instances.findLast((candidate) => candidate.sessionID() === sessionID) ?? bridge.instances.at(-1);
|
|
15665
|
+
if (instance === undefined)
|
|
15666
|
+
throw new Error("Envoy has no bound instance for a notice subscription");
|
|
15667
|
+
await instance.subscribe(sessionID, topic, context, whileHolding);
|
|
15668
|
+
}
|
|
15669
|
+
function onEnvoyRoleRegained(listener) {
|
|
15670
|
+
legionRoleClaimBridge().regained = listener;
|
|
15671
|
+
}
|
|
15672
|
+
|
|
15630
15673
|
// ../pi-shared/src/subagent-session.ts
|
|
15631
15674
|
import fs from "fs";
|
|
15632
15675
|
import path2 from "path";
|
|
@@ -15701,7 +15744,8 @@ var ENVOY_TOOL_NAMES = [
|
|
|
15701
15744
|
"envoy_role_set",
|
|
15702
15745
|
"envoy_role_get",
|
|
15703
15746
|
"envoy_whoami",
|
|
15704
|
-
"envoy_sessions"
|
|
15747
|
+
"envoy_sessions",
|
|
15748
|
+
"slack_post"
|
|
15705
15749
|
];
|
|
15706
15750
|
var LIVE_CAPABILITIES = [
|
|
15707
15751
|
"subagents",
|
|
@@ -15907,7 +15951,7 @@ var checkDispatchEnvoyTools = async (host2, input, signal) => {
|
|
|
15907
15951
|
});
|
|
15908
15952
|
if (result.code !== 0)
|
|
15909
15953
|
return failed(`dispatch read failed: ${commandFailure(result)}`);
|
|
15910
|
-
return ok(
|
|
15954
|
+
return ok(`${ENVOY_TOOL_NAMES.length} Envoy tools registered; dispatch read ${input.issue} answered from ${whichOnPath("dispatch")}`);
|
|
15911
15955
|
};
|
|
15912
15956
|
var checkGitHub = async (host2, input, signal) => {
|
|
15913
15957
|
const result = await host2.run("gh", ["api", "graphql", "-f", "query={viewer{login}}", "--jq", ".data.viewer.login"], { cwd: input.cwd, signal });
|
|
@@ -16122,33 +16166,10 @@ function ompCapabilityHost() {
|
|
|
16122
16166
|
run: runCommand2
|
|
16123
16167
|
};
|
|
16124
16168
|
}
|
|
16125
|
-
|
|
16126
|
-
// ../pi-shared/src/role-claim-bridge.ts
|
|
16127
|
-
function legionRoleClaimBridge() {
|
|
16128
|
-
return envoyPluginInterface().roleClaim;
|
|
16129
|
-
}
|
|
16130
|
-
async function claimEnvoyRole(sessionID, role, context) {
|
|
16131
|
-
const bridge = legionRoleClaimBridge();
|
|
16132
|
-
bridge.managedSessions.add(sessionID);
|
|
16133
|
-
const instance = bridge.instances.findLast((candidate) => candidate.sessionID() === sessionID) ?? bridge.instances.at(-1);
|
|
16134
|
-
if (instance === undefined)
|
|
16135
|
-
throw new Error("Envoy has no bound instance for a role claim");
|
|
16136
|
-
await instance.claim(sessionID, role, context);
|
|
16137
|
-
}
|
|
16138
|
-
async function subscribeLegionNotice(sessionID, topic, context, whileHolding) {
|
|
16139
|
-
const bridge = legionRoleClaimBridge();
|
|
16140
|
-
const instance = bridge.instances.findLast((candidate) => candidate.sessionID() === sessionID) ?? bridge.instances.at(-1);
|
|
16141
|
-
if (instance === undefined)
|
|
16142
|
-
throw new Error("Envoy has no bound instance for a notice subscription");
|
|
16143
|
-
await instance.subscribe(sessionID, topic, context, whileHolding);
|
|
16144
|
-
}
|
|
16145
|
-
function onEnvoyRoleRegained(listener) {
|
|
16146
|
-
legionRoleClaimBridge().regained = listener;
|
|
16147
|
-
}
|
|
16148
16169
|
// package.json
|
|
16149
16170
|
var package_default = {
|
|
16150
16171
|
name: "@sjawhar/pi-legion",
|
|
16151
|
-
version: "10.
|
|
16172
|
+
version: "10.5.0",
|
|
16152
16173
|
license: "Apache-2.0",
|
|
16153
16174
|
type: "module",
|
|
16154
16175
|
omp: {
|
|
@@ -16160,7 +16181,7 @@ var package_default = {
|
|
|
16160
16181
|
]
|
|
16161
16182
|
},
|
|
16162
16183
|
legion: {
|
|
16163
|
-
daemonApiVersion:
|
|
16184
|
+
daemonApiVersion: 29
|
|
16164
16185
|
},
|
|
16165
16186
|
repository: {
|
|
16166
16187
|
type: "git",
|
|
@@ -16841,6 +16862,26 @@ function createClaimSession(deps) {
|
|
|
16841
16862
|
};
|
|
16842
16863
|
}
|
|
16843
16864
|
|
|
16865
|
+
// src/slack-channels.ts
|
|
16866
|
+
function daemonLaunchedController(env) {
|
|
16867
|
+
return env.LEGION_CONTROLLER === "1" && env.LEGION_TREE === undefined && (env.LEGION_BOOT_TOKEN_FILE !== undefined || env.LEGION_BOOT_TOKEN !== undefined);
|
|
16868
|
+
}
|
|
16869
|
+
function daemonControllerSlackChannels(env) {
|
|
16870
|
+
const { LEGION_SLACK_CHANNELS: named } = env;
|
|
16871
|
+
if (named === undefined) {
|
|
16872
|
+
throw new Error("LEGION_SLACK_CHANNELS is required for the controller the daemon launches: the project's slack_channels, comma-separated, empty for none");
|
|
16873
|
+
}
|
|
16874
|
+
if (named.trim() === "")
|
|
16875
|
+
return [];
|
|
16876
|
+
return named.split(",").map((entry) => {
|
|
16877
|
+
const channel = entry.trim();
|
|
16878
|
+
if (!SLACK_CHANNEL_ID_PATTERN.test(channel)) {
|
|
16879
|
+
throw new Error(`LEGION_SLACK_CHANNELS entry ${JSON.stringify(channel)} is not a Slack channel id (C or G, then capital letters and digits)`);
|
|
16880
|
+
}
|
|
16881
|
+
return channel;
|
|
16882
|
+
});
|
|
16883
|
+
}
|
|
16884
|
+
|
|
16844
16885
|
// src/controller-session.ts
|
|
16845
16886
|
function createControllerSession(deps) {
|
|
16846
16887
|
const { daemon, persistedTranscript, pi } = deps;
|
|
@@ -16850,7 +16891,7 @@ function createControllerSession(deps) {
|
|
|
16850
16891
|
let startMessageSent = false;
|
|
16851
16892
|
let controllerTranscript;
|
|
16852
16893
|
const claim = async (context) => {
|
|
16853
|
-
const supervised =
|
|
16894
|
+
const supervised = daemonLaunchedController(process.env);
|
|
16854
16895
|
if (!supervised)
|
|
16855
16896
|
return claimWith(context, false);
|
|
16856
16897
|
try {
|
|
@@ -16870,6 +16911,7 @@ function createControllerSession(deps) {
|
|
|
16870
16911
|
if (launched)
|
|
16871
16912
|
recordBootstrappedSession(sessionFile);
|
|
16872
16913
|
const project = requiredEnvironment(process.env, "LEGION_PROJECT");
|
|
16914
|
+
const slackChannels = supervised ? daemonControllerSlackChannels(process.env) : [];
|
|
16873
16915
|
const client = daemon();
|
|
16874
16916
|
const { daemon: served } = await client.state();
|
|
16875
16917
|
const servedRole = controllerToken(legionProjectToken(served.project, "the daemon's project"));
|
|
@@ -16898,6 +16940,9 @@ function createControllerSession(deps) {
|
|
|
16898
16940
|
startMessageSent = true;
|
|
16899
16941
|
}
|
|
16900
16942
|
await subscribeLegionNotice(sessionID, legionControllerNoticeSubject(project), envoyContext, registration.claimToken);
|
|
16943
|
+
for (const channel of slackChannels) {
|
|
16944
|
+
await subscribeLegionNotice(sessionID, slackMentionTopic(channel), envoyContext, registration.claimToken);
|
|
16945
|
+
}
|
|
16901
16946
|
if (supervised) {
|
|
16902
16947
|
await client.ready({
|
|
16903
16948
|
claimToken: registration.claimToken,
|
|
@@ -17464,6 +17509,9 @@ function legionExtension(pi) {
|
|
|
17464
17509
|
from: import.meta.url,
|
|
17465
17510
|
envoyInterface: ENVOY_PLUGIN_INTERFACE_VERSION
|
|
17466
17511
|
};
|
|
17512
|
+
if (daemonLaunchedController(process.env)) {
|
|
17513
|
+
legionRoleClaimBridge().slackRoleOwned = true;
|
|
17514
|
+
}
|
|
17467
17515
|
const checkSubagentSession = subagentSessionCheck();
|
|
17468
17516
|
let phaseStall = "closed";
|
|
17469
17517
|
const phaseWorkerSession = (context) => {
|
|
@@ -403,11 +403,12 @@ active phase worker.
|
|
|
403
403
|
| `design-approved` | Its `version` is the approved one. A human approved the root spec document at its current version; the gate is open. Proceed to section 2 — except on a root whose catch-up said `handed_over`: its workers already run their phases, so start nothing; the approval releases any READY the gate refused. One whose `version` is the version a human's own answer to a decision block wrote, after an earlier approval (Dispatch carried that approval to it, section 1), opens nothing new: carry on, and release no wave because of it. |
|
|
404
404
|
| `design-changes-requested` | Its `version` and `reason`. A human asked for changes to the root spec at `version`, for `reason`. Revise the spec as the reason asks and request approval again as section 1 says; stay parked; the gate is closed. |
|
|
405
405
|
| `phase-finished` | The daemon has already moved the issue to its next phase by its fixed table and started that phase's role; you start nothing. Read the committed handoff for the finishing phase; if it shows unresolved gaps, tell the role now working the issue (`envoy_publish` to its role topic). A `planner` notice that names a departure from the spec's design defers to section 1's full condition: when the approved Summary, Acceptance, scope and settled decisions still hold, the plan is the record; otherwise change the root spec and request approval again as section 1 says. A `reviewer` notice whose GitHub review is `CHANGES_REQUESTED` needs nothing from you: the daemon has returned the issue to `implementing` (Dispatch `in_progress`) and started the **implementer**, whose correction goes through the tester and the reviewer again, never straight to retro. A `reviewer` notice with an `APPROVED` review means the daemon has started retro (step 5). An `implementer` notice for `production_check` is its production report: read the record on the pull request and the issue, then run step 7. A `tester` notice with `verdict: "fail"` — its handoff carries `implementerProof.verdict: "rejected"`, or a failure naming the production-like proof — has gone back to the **implementer** by the daemon's table; never supply the proof from another role. A worker that reports no surface reaches the changed path sends that report instead of completing its phase, so the daemon starts nothing more on that issue and the worker stays idle in its session, not suspended: file a child issue in this tree to build the surface (infrastructure, tooling, or a skill), and when that child's `child-closed` arrives, tell the waiting worker to continue with `envoy_publish` to its role topic. That report is never a reason to advance the phase. |
|
|
406
|
-
| `pr-blocked` | Its `reason` names the pull request and the `max_fix_attempts` it reached, or reads `Issue reached review_round_cap=<N>.` (the end of this row). The count is of heads pushed onto a red verdict that changed something outside `.legion/` — handoff-only pushes (`.legion/` paths only) never count, a push by the review App (a planner's, tester's, reviewer's or architect's) never counts, and the head after a red the tester's red tests earned (a review-App push that changed a path outside `.legion/`, however many handoff-only pushes follow it) does not count either — so after the tester's handoff-only push onto the implementer's red, the implementer's next push does count; a push the daemon cannot classify (a listener without `changed_paths`, a list the listener stopped at 100 paths or 32,768 runes of text, a push listing no commits) does. Published once per exhausted count, not on every later red verdict for that count. Read the failed CI evidence and recovery attempts. The notice moves nothing, and no later CI red within the attempt that ran the count out (the counted head, and every head pushed on top of it until a push lands on a head CI judged green, the tester's red tests and handoff onto the held red included) sends the work back from `testing`, `reviewing`, `retro` or `merging` either: the issue stays in its phase until you move it, or a worker's own decision does (a tester's `fail`, a reviewer's request for changes). A head pushed onto green CI leaves that attempt, so its red still comes as a `checks-red`. In `implementing`, give the implementer the failing checks (`envoy_publish` to its role topic). In any later phase a worker holds, tell that worker (`envoy_publish` to its role topic) to move the issue back to `implementing` with `request_backward_move`, naming the failing checks, and the daemon starts the implementer; or file a corrective child. In `awaiting_merge`, where no worker holds a phase and a backward move is refused, open a `dispatch ask` naming the failing checks for the human who merges, as section 6 does for a conflict there. Do not treat the blocked PR as final. A `review_round_cap` reason is the implementer's round count instead: every move back to an earlier phase counts one, and the notice comes again with each round past the cap. It moves nothing either, since the round that reached the cap has already started its worker. Tell the rounds apart by what announced each: a tester's fail by its `phase-finished` with `verdict: "fail"`; a request for changes by the reviewer's `phase-finished` over a `CHANGES_REQUESTED` review; the daemon's own move by a `checks-red` notice, whose reason names
|
|
406
|
+
| `pr-blocked` | Its `reason` names the pull request and the `max_fix_attempts` it reached, or reads `Issue reached review_round_cap=<N>.` (the end of this row). The count is of heads pushed onto a red verdict that changed something outside `.legion/` — handoff-only pushes (`.legion/` paths only) never count, a push by the review App (a planner's, tester's, reviewer's or architect's) never counts, and the head after a red the tester's red tests earned (a review-App push that changed a path outside `.legion/`, however many handoff-only pushes follow it) does not count either — so after the tester's handoff-only push onto the implementer's red, the implementer's next push does count; a push the daemon cannot classify (a listener without `changed_paths`, a list the listener stopped at 100 paths or 32,768 runes of text, a push listing no commits) does. Published once per exhausted count, not on every later red verdict for that count. Read the failed CI evidence and recovery attempts. The notice moves nothing, and no later CI red within the attempt that ran the count out (the counted head, and every head pushed on top of it until a push lands on a head CI judged green, the tester's red tests and handoff onto the held red included) sends the work back from `testing`, `reviewing`, `retro` or `merging` either: the issue stays in its phase until you move it, or a worker's own decision does (a tester's `fail`, a reviewer's request for changes). A head pushed onto green CI leaves that attempt, so its red still comes as a `checks-red`. In `implementing`, give the implementer the failing checks (`envoy_publish` to its role topic). In any later phase a worker holds, tell that worker (`envoy_publish` to its role topic) to move the issue back to `implementing` with `request_backward_move`, naming the failing checks, and the daemon starts the implementer; or file a corrective child. In `awaiting_merge`, where no worker holds a phase and a backward move is refused, open a `dispatch ask` naming the failing checks for the human who merges, as section 6 does for a conflict there. Do not treat the blocked PR as final. A `review_round_cap` reason is the implementer's round count instead: every move back to an earlier phase counts one, and the notice comes again with each round past the cap. It moves nothing either, since the round that reached the cap has already started its worker. Tell the rounds apart by what announced each: a tester's fail by its `phase-finished` with `verdict: "fail"`; a request for changes by the reviewer's `phase-finished` over a `CHANGES_REQUESTED` review; the daemon's own move by a `checks-red` notice, whose reason names a conflict (`the head conflicts with <base>`), the required checks that failed (`CI is red at <head>`), or the merge queue's failed merge and its failing run (`the merge queue took pull request #<n> out at READY's head …`); a worker's `request_backward_move` by a `phase-finished` from the role that asked, whose reason reaches only the task of the worker the move started, so ask that worker. Judge the cap by the rounds that are not conflicts. Conflict returns need nothing from you beyond the next round. Tester fails, requests for changes and CI-red returns (a `checks-red` notice is raised for CI only when a required check fails on code the branch pushed, or when the merge queue fails the merge) are the work going in circles: narrow it, re-plan it with the responsible worker, or ask a human with `dispatch ask`. Judge a worker's backward move by the reason that worker gives. A move you ordered for a conflict found before `awaiting_merge` (section 6) is a conflict return. The merger's move back to `reviewing` because its task names no approved head is not the work going in circles either. A move that sends back code found wrong counts with the tester fails. |
|
|
407
407
|
| `pr-merged` | Its `reason` names the pull request. The PR merged, under the repository's rules, before the issue reached `awaiting_merge`. The workflow runs on and asks no one to merge it: the daemon starts the **implementer** on the production check once the issue gets there, and you start nothing. Its `phase-finished` for `production_check` is what brings you to step 7: verify the record on the pull request and this issue first, then sign off naming it with `sign_off`. A merge is not the close. |
|
|
408
408
|
| `pr-closed-unmerged` | Decide from current scope whether the work is reopened, started over (`park_child` then `rerun_child`, for a child), or ended with a reason. Delegate the repository action to the responsible phase worker and keep ownership. |
|
|
409
409
|
| `merge-refused` | Its `reason` names the pull request, READY's head, what the daemon asked GitHub to do (merge, enqueue, or enable auto-merge for it), and GitHub's refusal, which a retry would meet again (squash merges disabled, a permission the implement App lacks). The daemon has stopped submitting that merge; the issue stays in `awaiting_merge`. The cause is a repository setting or an App permission, a person's to change: ask one with `dispatch ask`, naming the refusal and the pull request at READY's head, which that person merges under the repository's rules once it is fixed. The merge moves the issue on to its production check. Never bypass a rule. |
|
|
410
410
|
| `merge-stalled` | Its `reason` names the pull request, the state and head GitHub shows (closed, or another head), since when GitHub has shown it, and READY's head, which the record still awaits. GitHub's last change to the pull request is more than 10 minutes old and the record never heard of it, so its webhook never reached the daemon: the daemon has stopped submitting that merge, and the issue stays in `awaiting_merge`. Read the pull request on GitHub. Open at READY's head, GitHub has caught up: a person merges it under the repository's rules, and the merge moves the issue on to its production check. Closed, or at another head the daemon never recorded: ask a person with `dispatch ask`, naming the pull request, what GitHub shows, and READY's head. Never bypass a rule. |
|
|
411
|
+
| `merge-removed` | Its `reason` names who took the pull request out of the merge queue or turned its auto-merge off at READY's head after the daemon submitted it, or says GitHub turned it off on its own (over a repository setting such as a merge method the repository blocks) and names the App that submitted the merge, which GitHub names as the actor of its own disables; then what was removed, GitHub's reason (`manual`, `merge_conflict`, `manually_disabled`, `merge_commit_blocked`, …), when, and READY's head. It was not a failed merge, which comes as a `checks-red` instead. The daemon submits that merge no further, so the removal stands, and the issue stays in `awaiting_merge`. Read the pull request on GitHub. A `merge_conflict` conflicts with the base or with a pull request queued ahead of it: once the conflict is on the base, the daemon's own conflict check sends the issue back to `implementing` by itself. Otherwise ask a person with `dispatch ask` (the one who removed it, when the reason names a person rather than GitHub on its own), naming the pull request at READY's head and the reason; that person merges or queues it again under the repository's rules, and the merge moves the issue on to its production check. Never bypass a rule. |
|
|
411
412
|
| A reply on an ask you follow | Interpret the reply in the issue's design context. Answer in its thread (`dispatch comment --reply-to <comment id>`; under an open ask whose next move is yours, such as the approval request you must revise or hand back, `--reply-to-ask <ask id> --turn agent`, since a default-turn reply hands that request back to the human and a corrected `--summary` is then refused), then adjust the plan or relay it via `envoy_publish` to the responsible worker's role token; scope and product decisions remain with you. |
|
|
412
413
|
| `worker-died` | Its `role` and `phase`. That role's claim failed: its launches or prompts ran out. For a phase worker the daemon holds the issue (phase `held`) and starts nothing more on it. Reassess the work, then decide with `retry_or_escalate`: `retry` when the failure looks agent-specific or transient, `escalate` to hand the held issue to the controller when it looks environmental. |
|
|
413
414
|
| `held` | Its `role` and `phase` (the phase the issue left), or `phase` with `reason: "escalated"`. Without `reason`, that phase's worker ran out of launches or prompts: the issue is held (phase `held`), the `worker-died` that comes with it is yours to answer with `retry_or_escalate` as that row says, and the controller hears of the hold too. With `reason: "escalated"`, it records your own `escalate`: the controller has the issue now, and you start nothing for it. |
|
|
@@ -404,7 +404,8 @@ priority first, then board rank ([Keeping the slots full](#keeping-the-slots-ful
|
|
|
404
404
|
| `todo on <KEY>` from the Go daemon (payload `{kind: "todo"}`) | an issue not handed to Legion that changed while in `todo` and a slot stood free, sent half a minute later | Verify a free slot, then walk the whole `todo` list ([Keeping the slots full](#keeping-the-slots-full-go-daemon)) |
|
|
405
405
|
| `tick on <PROJECT>` from the Go daemon (payload `{kind: "tick", openCapabilities?: [<name>, …]}`) | the project key; the daemon's periodic wake, whatever the slots; `openCapabilities` names the deployment capabilities with no decision, each with its detail and `capabilities.decided.<name>` line under `capabilities` in `read_state`, and the live capabilities a running session's check failed, each with the detail naming the session (pod or pane), role, issue and fact, and no `configLine` | Recheck the trees waiting on a claim, then walk if a slot is free — a gap never stops the walk; post the day's report if this is the day's first turn, naming each open capability in it (the operator closes or decides a deployment row; the operator or the issue's architect fixes a live row's session; you take no other action) |
|
|
406
406
|
| Architect escalation (controller-actionable only: re-file a child as a root issue, capacity, cross-tree conflicts) | request + context | Judge and act; the owning architect writes an issue-design decision as a decision block and opens `dispatch ask` only for a human to-do |
|
|
407
|
-
| Mention |
|
|
407
|
+
| Mention | GitHub PR @mention text | Answer, or route to the owning issue's architect role |
|
|
408
|
+
| Slack mention (`from: slack`) | the mention's `channel_id`, `user_id`, `text`, `ts`, `thread_ts` | Nothing when your `Slack channels:` line does not name its `channel_id`; otherwise answer in its thread with `slack_post`: a state question from `read_state`, a work request filed as a Dispatch issue, an architect's question routed to that architect ([Slack mentions](skill://legion-controller/references/slack-mentions.md)) |
|
|
408
409
|
| `held on <KEY>` from the Go daemon (payload `{kind: "held", phase, role?, reason?}`) | the held issue, the phase it left, and the role whose claim failed, or `reason: "escalated"` | Verify the hold in `read_state` (the issue's phase is `held`). Without `reason`, a phase worker's launches or prompts ran out and the tree's architect decides retry or escalate: no action. With `reason: "escalated"` (on the record, `issues.<KEY>.holdReason` is `escalated`), the architect sent it to you: handle it as an architect escalation below. Parking the tree is `set_status` of the root to `backlog`; setting the root back to `todo` later re-admits it as a new generation, which starts again from its architect |
|
|
409
410
|
| `worker-died on <KEY>` from the Go daemon with `role: "architect"` | the tree root whose architect's claim failed, and the phase the root was in | The tree's architect ran out of launches or prompts and the daemon relaunches nothing; every other notice of the tree goes to that architect, so nobody inside the tree can act. Verify in `read_state` (`issues.<KEY>.architect.state` is `failed`); if the root's phase is `done`, the tree is already parked: no action. Otherwise re-admit the tree (`set_status` of the root to `backlog`, then to `todo`: a new generation, whose architect starts again with fresh budgets) or leave it parked and say why on the issue |
|
|
410
411
|
| Direct user message | — | Always first |
|
|
@@ -482,12 +483,13 @@ judgments.
|
|
|
482
483
|
|
|
483
484
|
## Mentions
|
|
484
485
|
|
|
485
|
-
Read the mention and its artifact
|
|
486
|
-
|
|
487
|
-
|
|
488
|
-
|
|
489
|
-
|
|
490
|
-
gate
|
|
491
|
-
|
|
492
|
-
|
|
486
|
+
Read the mention and its artifact; a Slack mention follows [Slack
|
|
487
|
+
mentions](skill://legion-controller/references/slack-mentions.md). Answer it when it asks the
|
|
488
|
+
controller for triage or human-facing information. A human asking how to let a root proceed past
|
|
489
|
+
its design gate approves the root issue's spec document in Dispatch — the `Approve` control in the
|
|
490
|
+
document's header, or the approval question the architect's request opened in the Inbox. The
|
|
491
|
+
controller never opens a gate and there is no operator command for it; a project that does not
|
|
492
|
+
want the gate at all runs `gates.design: off` in its `legion.yaml`. Otherwise resolve the
|
|
493
|
+
authoritative owning architect role and route the verified context with `envoy_publish`. Do not
|
|
494
|
+
route raw event traffic or invent a role token from a partial issue reference.
|
|
493
495
|
|
|
@@ -0,0 +1,94 @@
|
|
|
1
|
+
# Slack mentions
|
|
2
|
+
|
|
3
|
+
A person who mentions the Legion Slack app in one of the project's Slack channels is talking to
|
|
4
|
+
you, and you answer in that thread. The `Slack channels:` line of your system prompt names each
|
|
5
|
+
channel `legion.yaml` gives the project (`projects.<KEY>.slack_channels`). Only the controller the
|
|
6
|
+
daemon launches has one: the Slack bot token is the Legion daemon service's, which the secrets
|
|
7
|
+
broker grants to that service's own pods alone. With no such line the project has no channel, and
|
|
8
|
+
nothing here applies.
|
|
9
|
+
|
|
10
|
+
## Your session subscribes for you
|
|
11
|
+
|
|
12
|
+
Your session hears each listed channel's mentions by itself, on
|
|
13
|
+
`notifications.slack.*.<channel>.mention`, for as long as it holds the controller role: a resumed or
|
|
14
|
+
relaunched session hears the channels its launch names and no others, and drops every Slack topic an
|
|
15
|
+
earlier session subscribed to by hand. Never `envoy_subscribe` a Slack topic yourself.
|
|
16
|
+
|
|
17
|
+
A delivery from Slack whose `channel_id` the line does not name is not yours: do nothing with it.
|
|
18
|
+
|
|
19
|
+
A mention published while no controller ran never arrives: Envoy hands a session no copy of an
|
|
20
|
+
event from before it subscribed. Nothing tells you about one, so there is nothing to catch up. When
|
|
21
|
+
the project's `slack_channels` change, the daemon relaunches you into this session with the new
|
|
22
|
+
line.
|
|
23
|
+
|
|
24
|
+
## What a mention carries
|
|
25
|
+
|
|
26
|
+
The delivery's `message` holds Slack's fields: `channel_id`, `user_id` (a Slack user id such as
|
|
27
|
+
`U0123ABCD`), `text` (the mention itself appears in it as `<@U…>`, the app's own id), `ts` (the
|
|
28
|
+
mention's own timestamp), `thread_ts` (the thread's root, only when the mention was posted inside a
|
|
29
|
+
thread), and `bot_id` and `bot_name` when a bot posted it.
|
|
30
|
+
|
|
31
|
+
## Answer in the thread
|
|
32
|
+
|
|
33
|
+
Every answer is one `slack_post` call:
|
|
34
|
+
|
|
35
|
+
- `channel` is the mention's `channel_id`.
|
|
36
|
+
- `thread_ts` is the mention's `thread_ts`, or its `ts` when it has none. Either keeps the reply in
|
|
37
|
+
the thread the mention opened or joined, never at the channel's top level.
|
|
38
|
+
- `text` is what you say, at most 4,000 characters, written as `skill://dispatch`'s "Writing for
|
|
39
|
+
the human" says. Address the author as `<@user_id>` (by `bot_name` when a bot posted the mention
|
|
40
|
+
with no `user_id`) and give every issue as its key, its title and its Dispatch link exactly as
|
|
41
|
+
`dispatch` printed it (the `Link:` line of `dispatch read`, the link on a `Created` line or a
|
|
42
|
+
search hit): it points at Dispatch's dashboard, and `slack_post` refuses a reply linking an
|
|
43
|
+
address inside the cluster. Never build a link yourself. Say only what Dispatch shows: an issue's
|
|
44
|
+
assignee is the one `dispatch` names, never one you assume.
|
|
45
|
+
|
|
46
|
+
`slack_post` is sent once and never retried. When it answers that Slack did not answer, the reply
|
|
47
|
+
may already be in the thread: do not post it again. When it answers with Slack's refusal, the
|
|
48
|
+
reply is not posted: `not_in_channel` means the app has not been added to that channel, which only
|
|
49
|
+
a person in the workspace can fix, so say so in your next report rather than retrying. When it
|
|
50
|
+
answers that the secrets broker has not granted `LEGION_SLACK_BOT_TOKEN` (its request waits for
|
|
51
|
+
approval, or was denied), nothing was posted and no reply can be until the operator stores the
|
|
52
|
+
token with owner `legion-daemon` and tier `agent`: name the error in your next report.
|
|
53
|
+
|
|
54
|
+
## Decide what the person wants
|
|
55
|
+
|
|
56
|
+
Read the mention's `text`. When it names an issue key, read the issue with `dispatch read` before
|
|
57
|
+
answering. Then take the first of these that fits.
|
|
58
|
+
|
|
59
|
+
- **A question about state.** "What is Legion working on?", "Where is ACME-12?", "Why is it held?"
|
|
60
|
+
Answer from `read_state` and Dispatch as they stand now, never from memory: each issue's
|
|
61
|
+
`issues.<KEY>.phase`, its pull request, `admission.active` and `admission.waiting`. Say what you
|
|
62
|
+
read, not what you infer.
|
|
63
|
+
- **A request for work.** Someone wants a change made, a bug fixed, something investigated. Search
|
|
64
|
+
first (`skill://dispatch-first`): when an open issue already tracks it, reply with that issue and
|
|
65
|
+
file nothing. Otherwise file one issue in the project:
|
|
66
|
+
|
|
67
|
+
```text
|
|
68
|
+
dispatch issue --project <PROJECT> --title '<the request, as a title>' --spec-file - <<'EOF'
|
|
69
|
+
## Summary
|
|
70
|
+
|
|
71
|
+
<what the person asked for, in your words, and why if they said>
|
|
72
|
+
|
|
73
|
+
Asked in Slack by <@user_id> in channel <channel_id>, message <ts>.
|
|
74
|
+
EOF
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
Add `--label legion` only when the person asks Legion to do the work ("Legion, fix…", "can
|
|
78
|
+
Legion take…"); a request for someone to look at something, or one that does not say who, gets
|
|
79
|
+
no label and waits for a person to hand it over. Never label a request outside the scope the
|
|
80
|
+
deployment instructions state. Reply with the new issue's key, its title, the link and assignee
|
|
81
|
+
the `Created` line names (Dispatch assigns the issue to your token's owner when you name nobody),
|
|
82
|
+
and whether Legion will take it.
|
|
83
|
+
- **Something an issue's architect owns.** A question about a tree's design, a change of direction,
|
|
84
|
+
a decision only the tree's architect can make about an issue Legion runs. Find the tree: follow
|
|
85
|
+
`Links:` up through each `child_of` parent with `dispatch read` until you reach the issue
|
|
86
|
+
`read_state` records with an `architect`. When `issues.<ROOT>.architect.locator.claim` is there,
|
|
87
|
+
`envoy_publish` the person's words to `notifications.role.` followed by it, with the channel id
|
|
88
|
+
and `thread_ts` you reply on, and reply in the thread that you passed it to the architect that
|
|
89
|
+
owns `<ROOT>`, which answers on the issue. When the architect is not running (no locator), say
|
|
90
|
+
that in the thread instead and what `read_state` shows for the tree. Never invent a role token.
|
|
91
|
+
- **Anything else** (a greeting, a question about Legion itself): answer it briefly in the thread.
|
|
92
|
+
|
|
93
|
+
A request to approve a design is answered as the skill's "Mentions" section says: a person
|
|
94
|
+
approves the spec in Dispatch, and you never open a gate.
|
|
@@ -137,23 +137,36 @@ reviewing until you finish.
|
|
|
137
137
|
- **The daemon submits the merge the moment READY is accepted, unless the answer says a person
|
|
138
138
|
merges it.** It queues a `ready_merge` outbox row for the head READY named, and the row, as the
|
|
139
139
|
implement App, reads GitHub and then the record: while the issue still awaits that READY head, a
|
|
140
|
-
base with a merge queue gets the pull request enqueued
|
|
141
|
-
|
|
142
|
-
allows auto-merge is armed. Every request carries
|
|
143
|
-
GitHub refuses it once the head has moved.
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
156
|
-
|
|
140
|
+
base with a merge queue gets the pull request enqueued once GitHub reports it mergeable now
|
|
141
|
+
(`CLEAN`, `UNSTABLE` or `HAS_HOOKS`); otherwise a pull request GitHub reports mergeable now is
|
|
142
|
+
squash-merged, and one in a repository that allows auto-merge is armed. Every request carries
|
|
143
|
+
READY's head as GitHub's expected head, so GitHub refuses it once the head has moved. On a
|
|
144
|
+
merge-queue base the row never arms auto-merge: while a required check still runs, or anything
|
|
145
|
+
else keeps GitHub from reporting the pull request mergeable, it waits, reading GitHub again on
|
|
146
|
+
the outbox's backoff, and enters the queue once GitHub does. In a repository that allows neither a
|
|
147
|
+
merge queue nor auto-merge, the row waits the same way until GitHub reports the pull request
|
|
148
|
+
mergeable — a required check finishing, a required review a person gives — and then merges it. An
|
|
149
|
+
arm or a queue entry is not the end: the row keeps reading GitHub until GitHub reports the pull
|
|
150
|
+
request merged at READY's head. Once it has seen the arm or entry, it never submits that head
|
|
151
|
+
again after someone else removes it: the merge queue taking the pull request out because the merge
|
|
152
|
+
failed (GitHub's reason `failed_checks`, or an unexplained reason with a check that failed, timed
|
|
153
|
+
out, failed to start, needed action or went stale on the commit the queue built for its
|
|
154
|
+
`merge_group` CI) sends the issue back to `implementing`, the implementer's task naming each
|
|
155
|
+
failing check and its run, as a red head does; any other removal (a person dequeues it,
|
|
156
|
+
cancelling its runs, or turns auto-merge off, GitHub turns it off, the queue finds a conflict)
|
|
157
|
+
ends the row and is told to the architect once
|
|
158
|
+
(`merge-removed`). Two removals are submitted again: the implement App's own disarm sent before
|
|
159
|
+
READY that GitHub applied late (auto-merge `manually_disabled`, or a `manual` dequeue, by that
|
|
160
|
+
App), and auto-merge a close turned off, which the reopen at READY's head undid. GitHub's
|
|
161
|
+
rules decide each answer: the daemon bypasses
|
|
162
|
+
none, and a person may merge it first. A refusal a retry would meet again (squash merges disabled,
|
|
163
|
+
a permission the App lacks) ends the row and is told to the architect once (`merge-refused`), with
|
|
164
|
+
GitHub's message. While the record still awaits READY's head, GitHub showing the pull request
|
|
165
|
+
closed or at another head is a webhook not yet applied, so the row waits for the two to agree.
|
|
166
|
+
Only once GitHub's last change to the pull request is more than 10 minutes old, however long the
|
|
167
|
+
row waited before, does the row end and tell the architect once (`merge-stalled`). A reopen at
|
|
168
|
+
READY's head reuses the row, starts it over as though nothing had been armed, and takes it from a
|
|
169
|
+
run that read the record before the reopen. Any other failure retries.
|
|
157
170
|
No role runs `gh pr merge`. When the answer's `note` begins `MANUAL_MERGE_REQUIRED:` (the pull
|
|
158
171
|
request touches a path the project's `merge.by_hand` names), READY stands but the daemon submits
|
|
159
172
|
nothing: the merger tells the architect the note and the head, and a person merges under the
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@sjawhar/pi-legion",
|
|
3
|
-
"version": "10.
|
|
3
|
+
"version": "10.5.0",
|
|
4
4
|
"license": "Apache-2.0",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"omp": {
|
|
@@ -12,7 +12,7 @@
|
|
|
12
12
|
]
|
|
13
13
|
},
|
|
14
14
|
"legion": {
|
|
15
|
-
"daemonApiVersion":
|
|
15
|
+
"daemonApiVersion": 29
|
|
16
16
|
},
|
|
17
17
|
"repository": {
|
|
18
18
|
"type": "git",
|