@sjawhar/pi-legion-envoy 5.16.7 → 5.16.8

package/dist/envoy.js

@@ -30600,6 +30600,7 @@ function controllerToken(project) {
 
 // ../contracts/src/legion-daemon-api.ts
 var nonEmptyString = exports_external.string().min(1);
+var appLogin = exports_external.string().regex(/^[^[\]]+\[bot\]$/);
 var legionRole = exports_external.enum(LEGION_ROLES);
 var requiredUnknown = exports_external.unknown().refine((value) => value !== undefined, {
   message: "Required"
@@ -30853,7 +30854,11 @@ var LegionDaemonApi = {
   },
   GitHubToken: {
     request: exports_external.strictObject({ grantId: nonEmptyString }),
-    response: exports_external.object({ token: nonEmptyString, appLogin: exports_external.string().endsWith("[bot]") })
+    response: exports_external.object({
+      token: nonEmptyString,
+      appLogin: exports_external.string().endsWith("[bot]"),
+      legionAppLogins: exports_external.object({ implement: appLogin, review: appLogin }).optional()
+    })
   },
   GitCredential: {
     request: exports_external.strictObject({ grantId: nonEmptyString })

package/dist/legion.js

@@ -30769,6 +30769,7 @@ function controllerToken(project) {
 
 // ../contracts/src/legion-daemon-api.ts
 var nonEmptyString = exports_external.string().min(1);
+var appLogin = exports_external.string().regex(/^[^[\]]+\[bot\]$/);
 var legionRole = exports_external.enum(LEGION_ROLES);
 var requiredUnknown = exports_external.unknown().refine((value) => value !== undefined, {
   message: "Required"
@@ -31022,7 +31023,11 @@ var LegionDaemonApi = {
   },
   GitHubToken: {
     request: exports_external.strictObject({ grantId: nonEmptyString }),
-    response: exports_external.object({ token: nonEmptyString, appLogin: exports_external.string().endsWith("[bot]") })
+    response: exports_external.object({
+      token: nonEmptyString,
+      appLogin: exports_external.string().endsWith("[bot]"),
+      legionAppLogins: exports_external.object({ implement: appLogin, review: appLogin }).optional()
+    })
   },
   GitCredential: {
     request: exports_external.strictObject({ grantId: nonEmptyString })
@@ -33415,7 +33420,7 @@ import { logger } from "@oh-my-pi/pi-utils";
 // package.json
 var package_default = {
   name: "@sjawhar/pi-legion-envoy",
-  version: "5.16.7",
+  version: "5.16.8",
   type: "module",
   omp: {
     extensions: [
@@ -33428,7 +33433,7 @@ var package_default = {
   },
   legion: {
     daemonApiVersion: 9,
-    goDaemonApiVersion: 10
+    goDaemonApiVersion: 11
   },
   repository: {
     type: "git",
@@ -33990,9 +33995,11 @@ var LegionGoGrantResponse = exports_external.strictObject({
   grantId: nonEmptyString2,
   expiresAt: timestamp
 });
+var appLogin2 = exports_external.string().regex(/^[^[\]]+\[bot\]$/);
 var LegionGoGitHubTokenResponse = exports_external.strictObject({
   token: nonEmptyString2,
-  appLogin: exports_external.string().endsWith("[bot]")
+  appLogin: exports_external.string().endsWith("[bot]"),
+  legionAppLogins: exports_external.strictObject({ implement: appLogin2, review: appLogin2 }).optional()
 });
 var LegionGoGitCredentialResponse = exports_external.strictObject({
   username: exports_external.literal("x-access-token"),

package/dist/skills/legion-worker/SKILL.md

@@ -285,9 +285,11 @@ later phase keeps it current rather than replacing it:
 - Thread <id>: fixed in <commit-sha> — <one line>.
 - Thread <id>: not a defect — <reason>.
 `legion threads resolve --pr <n> --repo <owner>/<repo>` at <head-sha>:
-resolved <thread URL>
+resolved <thread URL> — its opener's acceptance
+resolved <thread URL> — the Legion reviewer's acceptance of a bot's thread
 left open <thread URL> — newest reply by <login> is not an acceptance
 left open <thread URL> — newest reply by <login> is an unsubmitted draft in a pending review
+left open <thread URL> — newest reply by <login> is not its opener's or the Legion reviewer's acceptance
 
 **Thermo:** `ce-simplify-code` once at <head-sha>: <0 applied | applied → new head <sha>>; thermonuclear pair at the final head <sha>:
 <verdict>. (omitted entirely on a docs-only PR — there is no code for either pass, so neither runs)
@@ -329,7 +331,8 @@ this proof.
 
 - **Threads are dispositioned individually, never resolved in bulk.** Every open review
   thread gets its own line naming the fixing commit or the reason it isn't a defect. The
-  reviewer answers each thread it opened with exactly one of `Accepted: fixed in <commit> — <one line>`,
+  reviewer answers each thread it opened, and each thread a bot opened that is none of Legion's
+  role Apps, with exactly one of `Accepted: fixed in <commit> — <one line>`,
   `Accepted: not a defect — <reason>`, or `Still open: <what remains>`; nothing else is an
   acceptance, and nobody replies after an `Accepted:` (any later reply that is not itself an
   `Accepted:` — the opener's own follow-up included — leaves the thread open, because resolution
@@ -341,9 +344,16 @@ this proof.
   In a Legion pane, the **implementer** runs the command before every push that answers a review
   (the corrective push and the final `.legion/` deletion push) and pastes its output into the
   `Threads` section. The command resolves each unresolved thread whose newest submitted comment is
-  the opener's own `Accepted:` reply, one `resolveReviewThread` per thread, prints `resolved <url>`
-  or `left open <url> — newest reply by <login> is not an acceptance`, and exits 1 naming the
-  thread's URL and GitHub's message when GitHub refuses one.
+  the opener's own `Accepted:` reply. On a thread a bot account opened that is none of Legion's
+  role Apps (the daemon names them, keyed by App role), the Legion reviewer's `Accepted:` also
+  closes it. GitHub cannot tell a CI bot, which never accepts, from a person whose `gh` is routed
+  to an App, so the reviewer adjudicates such a finding, and it may accept one an App-routed person
+  raised. The subject of a finding never closes it: the implementer's `Fixed in <commit>: …` or
+  `Declined: …` answers a thread and closes none. A thread either Legion App opened, a reviewer's
+  finding included, still needs its opener's `Accepted:`. It makes one `resolveReviewThread` per
+  thread, prints `resolved <url> — <whose acceptance>` (its opener's, or the Legion reviewer's on a
+  bot's thread, so the ledger shows which) or `left open <url> — newest reply by <login> is …`
+  naming why, and exits 1 naming the thread's URL and GitHub's message when GitHub refuses one.
 
   Without a grant, page through `reviewThreads`, skip `isResolved: true`, and compare the opener
   with the newest comment. Query shape, inside `repository { pullRequest { … } }`:
@@ -353,15 +363,18 @@ this proof.
     pageInfo { hasNextPage endCursor }
     nodes {
       id isResolved
-      opener: comments(first: 1) { nodes { author { login } } }
-      newest: comments(last: 1) { nodes { author { login } body state } }
+      opener: comments(first: 1) { nodes { author { __typename login } } }
+      newest: comments(last: 1) { nodes { author { __typename login } body state } }
     }
   }
   ```
 
-  Resolve only when the newest comment is submitted, its `author { login }` equals the opener's,
-  and its `body`, after removing leading spaces, tabs, CR, and LF, begins `Accepted:`. For each
-  such thread:
+  Resolve only when the newest comment is submitted, its `author` is the opener's account (the same
+  `__typename` and `login`: a login alone is a string anyone may register), and its `body`, after
+  removing leading spaces, tabs, CR, and LF, begins `Accepted:`. Without a
+  grant nothing names Legion's own App logins, so this route closes a bot's thread only on its
+  opener's `Accepted:`: leave one the Legion reviewer accepted for the implementer's or merger's
+  run in a pane, or report it. For each thread to resolve:
 
   ```graphql
   mutation($threadId: ID!) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sjawhar/pi-legion-envoy",
-  "version": "5.16.7",
+  "version": "5.16.8",
   "type": "module",
   "omp": {
     "extensions": [
@@ -13,7 +13,7 @@
   },
   "legion": {
     "daemonApiVersion": 9,
-    "goDaemonApiVersion": 10
+    "goDaemonApiVersion": 11
   },
   "repository": {
     "type": "git",