@sjawhar/pi-legion-envoy 1.55.1 → 1.56.0

package/dist/envoy.js

@@ -32567,6 +32567,36 @@ function notSubscribed(owner) {
 function followsAsk(owner) {
   return `You follow this ask: its answer and replies reach you directly. For every event on ${owner.label}: envoy_subscribe ${owner.topic}`;
 }
+var triageAdviceShown = new Set;
+function renderAdvice(tool, key, advice, opts) {
+  if (advice === undefined)
+    return [];
+  const hasIssueAdvice = advice.issue_status !== undefined;
+  const openAsks = advice.your_open_asks;
+  const writesSinceHuman = advice.session_writes_since_human;
+  const lines = [];
+  if (advice.decision_blocks === 0 && opts.isPrimarySpec === true && (tool === "dispatch_issue" || tool === "dispatch_artifact")) {
+    lines.push('No decision blocks in this spec \u2014 nothing here reaches a human\'s inbox. Want human feedback? See the `dispatch` skill, "Decision blocks".');
+  }
+  if (hasIssueAdvice && writesSinceHuman !== undefined && writesSinceHuman >= 3 && (tool === "dispatch_message" || tool === "dispatch_ask" || tool === "dispatch_comment" && opts.isAskReply !== true)) {
+    const middle = writesSinceHuman >= 6 ? "Stop posting here until a human replies." : "Progress ledger or scratchpad? If so, stop.";
+    lines.push(`You've sent ${writesSinceHuman} messages on ${key} with no human response. ${middle} See the \`dispatch\` skill, "Structure over stream".`);
+  }
+  if (advice.issue_status === "triage" && tool !== "dispatch_issue" && !(tool === "dispatch_issue_update" && opts.setsStatus === true) && !triageAdviceShown.has(key)) {
+    triageAdviceShown.add(key);
+    lines.push(`${key} is still in triage \u2014 nobody can see its development status. See the \`dispatch\` skill, "Issue status is yours to move".`);
+  }
+  if (hasIssueAdvice && openAsks !== undefined && openAsks.length > 0 && (tool === "dispatch_message" || tool === "dispatch_doc_edit" || tool === "dispatch_issue_update" || tool === "dispatch_comment" && opts.replyToOwnAsk !== true)) {
+    const askCount = Math.min(openAsks.length, 2);
+    for (let index = 0;index < askCount; index += 1) {
+      const ask = openAsks[index];
+      if (ask === undefined)
+        break;
+      lines.push(`You still have an open ask on ${key}: "${ask.question.slice(0, 80)}" (${ask.id}). Still needed? See the \`dispatch\` skill, "Close what you opened".`);
+    }
+  }
+  return lines;
+}
 function documentResultDetails(artifact) {
   return {
     project: artifact.project,
@@ -33455,9 +33485,19 @@ async function executeDispatchTool(input) {
           ...Array.isArray(labels) ? { labels } : {},
           actor
         });
+        const adviceLines = renderAdvice(input.tool, created.key, created.advice, {
+          isPrimarySpec: spec !== undefined
+        });
         return {
-          text: `Created ${created.key}: ${created.title} ${notSubscribed(issueTopic(created.key))}`,
-          details: { issue: created.key }
+          text: [
+            `Created ${created.key}: ${created.title} ${notSubscribed(issueTopic(created.key))}`,
+            ...adviceLines
+          ].join(`
+`),
+          details: {
+            issue: created.key,
+            ...created.advice === undefined ? {} : { advice: created.advice }
+          }
         };
       } catch (error) {
         if (!(error instanceof DispatchServiceError) || error.code !== "POSSIBLE_DUPLICATE") {
@@ -33514,12 +33554,20 @@ async function executeDispatchTool(input) {
           ...parent === undefined ? [] : [after.parent === null ? "parent cleared" : `parent -> ${after.parent}`],
           ...components === undefined ? [] : [componentsChange(components, after.components)]
         ];
+        const adviceLines = renderAdvice(input.tool, after.key, after.advice, {
+          setsStatus: status !== undefined
+        });
         return {
-          text: `${after.key}: ${changes.join("; ")} ${notSubscribed(issueTopic(after.key))}`,
+          text: [
+            `${after.key}: ${changes.join("; ")} ${notSubscribed(issueTopic(after.key))}`,
+            ...adviceLines
+          ].join(`
+`),
           details: {
             issue: after.key,
             status: after.status,
-            external_links: after.external_links.map((link) => link.url)
+            external_links: after.external_links.map((link) => link.url),
+            ...after.advice === undefined ? {} : { advice: after.advice }
           }
         };
       } catch (error) {
@@ -33650,10 +33698,18 @@ async function executeDispatchTool(input) {
       };
       const ask = resolved?.owner.kind === "project" ? await client.artifactAsk(resolved.artifact.id, askInput) : await client.ask(issue(), askInput);
       const askOwner = ask.issue_key !== null ? issueTopic(ask.issue_key) : resolved === undefined ? issueTopic(issue()) : documentTopic(resolved.artifact);
+      const adviceLines = renderAdvice(input.tool, askOwner.label, ask.advice, {});
       return {
-        text: `Asked ${ask.id} on ${askOwner.label} (urgency ${ask.urgency}): ${ask.question}
+        text: [
+          `Asked ${ask.id} on ${askOwner.label} (urgency ${ask.urgency}): ${ask.question}
 ${followsAsk(askOwner)}`,
-        details: await followedAskDetails(client, ask, resolved?.artifact)
+          ...adviceLines
+        ].join(`
+`),
+        details: {
+          ...await followedAskDetails(client, ask, resolved?.artifact),
+          ...ask.advice === undefined ? {} : { advice: ask.advice }
+        }
       };
     }
     case "dispatch_edit_ask": {
@@ -33698,21 +33754,34 @@ ${followsAsk(askOwner)}`,
       const comment = resolved?.owner.kind === "project" ? await client.artifactComment(resolved.artifact.id, commentInput) : await client.comment(issue(), commentInput);
       const commentOwner = resolved === undefined ? issueTopic(issue()) : resolvedTopic(resolved);
       const commentDetails = resolved === undefined ? { issue: comment.issue_key, comment: comment.id } : writeResultDetails(resolved, { comment: comment.id });
+      const adviceLines = renderAdvice(input.tool, commentOwner.label, comment.advice, {
+        isAskReply: replyToAsk !== undefined,
+        replyToOwnAsk: replyToAsk !== undefined && (comment.advice?.your_open_asks?.some((ask) => ask.id === replyToAsk) ?? false)
+      });
       if (replyToAsk !== undefined) {
         const askState = comment.turn === null ? "" : `; ask now waiting on ${comment.turn}`;
         return {
-          text: `Replied on ask ${replyToAsk} (comment ${comment.id}${askState}). ${followsAsk(commentOwner)}`,
+          text: [
+            `Replied on ask ${replyToAsk} (comment ${comment.id}${askState}). ${followsAsk(commentOwner)}`,
+            ...adviceLines
+          ].join(`
+`),
           details: {
             ...commentDetails,
             ask: replyToAsk,
             follows: { ask: replyToAsk },
-            ...comment.turn === null ? {} : { ask_waiting_on: comment.turn }
+            ...comment.turn === null ? {} : { ask_waiting_on: comment.turn },
+            ...comment.advice === undefined ? {} : { advice: comment.advice }
           }
         };
       }
       return {
-        text: `Posted comment ${comment.id} ${notSubscribed(commentOwner)}`,
-        details: commentDetails
+        text: [`Posted comment ${comment.id} ${notSubscribed(commentOwner)}`, ...adviceLines].join(`
+`),
+        details: {
+          ...commentDetails,
+          ...comment.advice === undefined ? {} : { advice: comment.advice }
+        }
       };
     }
     case "dispatch_suggest": {
@@ -33742,9 +33811,18 @@ ${followsAsk(askOwner)}`,
         actor
       });
       const messageRef = dispatchChildRef(dispatchIssueRef(issueKey), "message", message.id);
+      const adviceLines = renderAdvice(input.tool, issueKey, message.advice, {});
       return {
-        text: `Posted message ${message.id} (${messageRef}) ${notSubscribed(issueTopic(issueKey))}`,
-        details: { issue: issueKey, message: message.id }
+        text: [
+          `Posted message ${message.id} (${messageRef}) ${notSubscribed(issueTopic(issueKey))}`,
+          ...adviceLines
+        ].join(`
+`),
+        details: {
+          issue: issueKey,
+          message: message.id,
+          ...message.advice === undefined ? {} : { advice: message.advice }
+        }
       };
     }
     case "dispatch_doc_edit": {
@@ -33762,11 +33840,14 @@ ${followsAsk(askOwner)}`,
       const retyped = ops.filter((operation) => operation.op === "retype").length;
       const versionText = edited.version === null ? "no new version" : `version ${edited.version.number}`;
       const applied = retyped === 0 ? `Applied ${edited.applied} ops (${versionText})` : `Applied ${edited.applied} ops; retyped ${retyped} block${retyped === 1 ? "" : "s"} (${versionText})`;
+      const adviceLines = renderAdvice(input.tool, resolvedTopic(resolved).label, edited.advice, {});
       return {
-        text: `${applied} ${notSubscribed(resolvedTopic(resolved))}`,
+        text: [`${applied} ${notSubscribed(resolvedTopic(resolved))}`, ...adviceLines].join(`
+`),
         details: writeResultDetails(resolved, {
           applied: edited.applied,
-          ...edited.version === null ? {} : { version: edited.version.number }
+          ...edited.version === null ? {} : { version: edited.version.number },
+          ...edited.advice === undefined ? {} : { advice: edited.advice }
         })
       };
     }
@@ -33838,15 +33919,24 @@ ${trailer.join(`
       const result = artifactOwner.kind === "project" ? await client.projectArtifact(artifactOwner.project, artifactInput) : await client.artifact(issue(), artifactInput);
       const artifactRef = dispatchDocumentRef(artifactOwner.kind === "project" ? artifactOwner.project : issue(), result.artifact.slug);
       const uploadOwner = artifactOwner.kind === "project" ? documentTopic(result.artifact) : issueTopic(issue());
+      const adviceLines = renderAdvice(input.tool, uploadOwner.label, result.advice, {
+        isPrimarySpec: result.artifact.primary || result.artifact.name === "spec.md"
+      });
       return {
-        text: `Uploaded ${result.artifact.name} as version ${result.version.number} (artifact slug ${result.artifact.slug}; ${artifactRef}) ${notSubscribed(uploadOwner)}`,
+        text: [
+          `Uploaded ${result.artifact.name} as version ${result.version.number} (artifact slug ${result.artifact.slug}; ${artifactRef}) ${notSubscribed(uploadOwner)}`,
+          ...adviceLines
+        ].join(`
+`),
         details: artifactOwner.kind === "project" ? {
           ...documentResultDetails(result.artifact),
-          version: result.version.number
+          version: result.version.number,
+          ...result.advice === undefined ? {} : { advice: result.advice }
         } : {
           issue: issue(),
           artifact: result.artifact.id,
-          version: result.version.number
+          version: result.version.number,
+          ...result.advice === undefined ? {} : { advice: result.advice }
         }
       };
     }

package/dist/legion.js

@@ -16145,7 +16145,7 @@ import { logger } from "@oh-my-pi/pi-utils";
 // package.json
 var package_default = {
   name: "@sjawhar/pi-legion-envoy",
-  version: "1.55.1",
+  version: "1.56.0",
   type: "module",
   omp: {
     extensions: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sjawhar/pi-legion-envoy",
-  "version": "1.55.1",
+  "version": "1.56.0",
   "type": "module",
   "omp": {
     "extensions": [