@sixb/sqlite 0.1.17 → 0.1.19

package/dist/index.js

@@ -25,12 +25,8 @@ import {
   serializeActionRunFailure
 } from "@sixb/core/internal/action-run-storage";
 import { assertActionRunExecution } from "@sixb/core/internal/action-run-storage-provider";
-import {
-  actionRunPhaseRecordsEqual,
-  canRequeueActionRunAfterEnqueueFailure,
-  finishActionRunPhase
-} from "@sixb/core/internal/storage";
-import { ActionRunError, isTerminalActionRun } from "@sixb/core/storage";
+import { normalizeRecordActionRunInput, resolveActionRunEffects } from "@sixb/core/internal/storage";
+import { ActionRunError } from "@sixb/core/storage";
 
 // src/migrations.ts
 import { Database } from "bun:sqlite";
@@ -4994,6 +4990,158 @@ CREATE INDEX idx_ontology_sources_drained
   WHERE status = 'superseded' AND root_count = 0;
 `;
 
+// src/migrations/060-terminal-action-runs.sql
+var _060_terminal_action_runs_default = `-- Actions run in the request that asks for them and record their run once, when it ends. No run
+-- is queued, running, or cancelled any more, and every run has started and finished. SQLite cannot
+-- alter a CHECK constraint, so the table is rebuilt.
+CREATE TABLE action_runs_v2 (
+  project_id TEXT NOT NULL,
+  id TEXT NOT NULL,
+  execution_id TEXT NOT NULL,
+  action_id TEXT NOT NULL,
+  subject_kind TEXT NOT NULL CHECK (subject_kind IN ('none', 'object')),
+  object_type_id TEXT,
+  primary_id TEXT,
+  status TEXT NOT NULL CHECK (status IN ('succeeded', 'failed')),
+  phase TEXT NOT NULL CHECK (phase IN ('validation', 'writeback', 'edits', 'commit', 'effects')),
+  started_at TEXT NOT NULL,
+  finished_at TEXT NOT NULL,
+  params TEXT NOT NULL,
+  idempotency_key TEXT NOT NULL,
+  writeback_status TEXT CHECK (writeback_status IS NULL OR writeback_status IN ('succeeded', 'failed')),
+  writeback_completed_at TEXT,
+  writeback_result TEXT,
+  writeback_error TEXT CHECK (writeback_error IS NULL OR json_valid(writeback_error)),
+  effects_status TEXT CHECK (effects_status IS NULL OR effects_status IN ('succeeded', 'failed')),
+  effects_completed_at TEXT,
+  effects_error TEXT CHECK (effects_error IS NULL OR json_valid(effects_error)),
+  error TEXT CHECK (error IS NULL OR json_valid(error)),
+  CHECK (
+    (subject_kind = 'none' AND object_type_id IS NULL AND primary_id IS NULL)
+    OR (subject_kind = 'object' AND object_type_id IS NOT NULL AND primary_id IS NOT NULL)
+  ),
+  CHECK ((status = 'failed') = (error IS NOT NULL)),
+  PRIMARY KEY (project_id, id),
+  UNIQUE (project_id, execution_id)
+);
+
+INSERT INTO action_runs_v2 (
+  project_id, id, execution_id, action_id, subject_kind, object_type_id, primary_id, status,
+  phase, started_at, finished_at, params, idempotency_key, writeback_status,
+  writeback_completed_at, writeback_result, writeback_error, effects_status,
+  effects_completed_at, effects_error, error
+)
+SELECT
+  project_id, id, execution_id, action_id, subject_kind, object_type_id, primary_id,
+  migrated_status, migrated_phase,
+  -- A run starts when it was queued at the latest.
+  COALESCE(started_at, queued_at),
+  migrated_finished_at,
+  params, idempotency_key, writeback_status,
+  CASE
+    WHEN writeback_status IS NULL THEN NULL
+    ELSE COALESCE(writeback_completed_at, migrated_finished_at)
+  END,
+  writeback_result, writeback_error,
+  CASE WHEN effects_abandoned THEN 'failed' ELSE effects_status END,
+  CASE
+    WHEN effects_abandoned THEN migrated_at
+    WHEN effects_status IS NULL THEN NULL
+    ELSE COALESCE(effects_completed_at, migrated_finished_at)
+  END,
+  CASE
+    WHEN effects_abandoned THEN json_object(
+      'code', 'internal.unexpected',
+      'message', 'Abandoned: Actions now run synchronously; these effects never finished.',
+      'retryable', json('false'),
+      'at', migrated_at,
+      'details', json_object('actionId', action_id, 'runId', id, 'phase', 'effects')
+    )
+    ELSE effects_error
+  END,
+  -- A failure names the phase its run ended in.
+  CASE
+    WHEN migrated_error IS NULL THEN NULL
+    WHEN json_extract(migrated_error, '$.details.phase') IS migrated_phase THEN migrated_error
+    ELSE json_set(migrated_error, '$.details.phase', migrated_phase)
+  END
+FROM (
+  SELECT
+    *,
+    CASE
+      WHEN status = 'succeeded' OR edits_committed THEN 'succeeded'
+      ELSE 'failed'
+    END AS migrated_status,
+    CASE
+      WHEN edits_committed THEN CASE WHEN phase = 'effects' THEN 'effects' ELSE 'commit' END
+      -- The phases \`request\`, \`enqueue\`, and \`cancelled\` are gone: a run that stopped in one of
+      -- them never got past validation.
+      WHEN phase IN ('validation', 'writeback', 'edits', 'commit', 'effects') THEN phase
+      ELSE 'validation'
+    END AS migrated_phase,
+    CASE
+      WHEN edits_committed THEN committed_at
+      WHEN status IN ('queued', 'running') THEN migrated_at
+      ELSE COALESCE(finished_at, migrated_at)
+    END AS migrated_finished_at,
+    edits_committed AND phase = 'effects' AND effects_status IS NULL AS effects_abandoned,
+    CASE
+      WHEN edits_committed THEN NULL
+      WHEN status IN ('queued', 'running') THEN json_object(
+        'code', 'internal.unexpected',
+        'message', 'Abandoned: Actions now run synchronously; this run never finished.',
+        'retryable', json('false'),
+        'at', migrated_at,
+        'details', json_object('actionId', action_id, 'runId', id)
+      )
+      -- Every failed run carries a failure. One recorded before failures were kept explains
+      -- itself.
+      WHEN status IN ('failed', 'cancelled') AND error IS NULL THEN json_object(
+        'code', 'internal.unexpected',
+        'message', 'This run failed before Sixb recorded why.',
+        'retryable', json('false'),
+        'at', COALESCE(finished_at, migrated_at),
+        'details', json_object('actionId', action_id, 'runId', id)
+      )
+      -- An enqueue failure, which no run can meet any more, reads as the unexpected error it
+      -- now is.
+      WHEN json_extract(error, '$.code') = 'queue.enqueue_failed'
+        THEN json_set(error, '$.code', 'internal.unexpected', '$.retryable', json('false'))
+      ELSE error
+    END AS migrated_error
+  FROM (
+    SELECT
+      run.*,
+      committed.committed_at,
+      strftime('%Y-%m-%dT%H:%M:%fZ', 'now') AS migrated_at,
+      -- A run left running after its edits committed, as a crash between the commit and the end
+      -- of the run left it, succeeded: its edits and their outbox facts are in the commit. A run
+      -- that stopped during its effects keeps that phase, and records effects that never ended.
+      -- Any other run left queued or running never finished, and nothing will resume it. A
+      -- cancelled run failed, and keeps the failure it recorded.
+      run.status IN ('queued', 'running') AND committed.committed_at IS NOT NULL
+        AS edits_committed
+    FROM action_runs AS run
+    LEFT JOIN ontology_commits AS committed
+      ON committed.origin_kind = 'action'
+      AND committed.project_id = run.project_id
+      AND committed.origin_run_id = run.id
+  )
+);
+
+DROP TABLE action_runs;
+ALTER TABLE action_runs_v2 RENAME TO action_runs;
+
+CREATE INDEX idx_action_runs_project_started
+  ON action_runs(project_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_action_started
+  ON action_runs(project_id, action_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_object_started
+  ON action_runs(project_id, object_type_id, primary_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_status_started
+  ON action_runs(project_id, status, started_at DESC);
+`;
+
 // src/migrations.ts
 var MIGRATIONS_TABLE_SQL = `
   CREATE TABLE IF NOT EXISTS sixb_migrations (
@@ -5100,7 +5248,8 @@ var sqliteStorageMigrations = defineMigrations({
     sqliteSql("056-audio-transcription", _056_audio_transcription_default),
     sqliteSql("057-reranking-model-kind", _057_reranking_model_kind_default),
     sqliteSql("058-file-download-grants", _058_file_download_grants_default),
-    sqliteSql("059-drained-source-versions", _059_drained_source_versions_default)
+    sqliteSql("059-drained-source-versions", _059_drained_source_versions_default),
+    sqliteSql("060-terminal-action-runs", _060_terminal_action_runs_default)
   ]
 });
 function sqliteStoragePath(basePath) {
@@ -5437,174 +5586,50 @@ class SqliteActionRunStorage {
       installFreshSqliteSchema(this.db);
     }
   }
-  async lockForMaterialization(input) {
-    const row = this.db.query(`SELECT action_id, status FROM action_runs WHERE project_id = ? AND id = ?`).get(input.projectId, input.runId);
-    if (!row) {
-      throw new ActionRunError(`[SixbSqlite] Action run '${input.runId}' not found for project '${input.projectId}'.`);
-    }
-    if (row.action_id !== input.actionId) {
-      throw new ActionRunError(`[SixbSqlite] Action run '${input.runId}' does not belong to action '${input.actionId}'.`);
-    }
-    if (row.status !== "running") {
-      throw new ActionRunError(`[SixbSqlite] Action run '${input.runId}' cannot materialize from status '${row.status}'.`);
-    }
-    const record = await this.getById({ projectId: input.projectId, id: input.runId });
-    if (!record) {
-      throw new ActionRunError(`[SixbSqlite] Action run '${input.runId}' disappeared while locking materialization.`);
-    }
-    return record;
-  }
-  async queue(input) {
-    const queuedAt = input.queuedAt ?? new Date;
+  async record(input) {
+    const record = normalizeRecordActionRunInput(input);
     await assertActionRunExecution({
       executions: this.executions,
-      projectId: input.projectId,
-      executionId: input.executionId,
-      runId: input.id,
-      actionId: input.actionId
+      projectId: record.projectId,
+      executionId: record.executionId,
+      runId: record.id,
+      actionId: record.actionId
     });
-    try {
-      this.db.query(`
-          INSERT INTO action_runs (
-            project_id,
-            id,
-            execution_id,
-            action_id,
-            subject_kind,
-            object_type_id,
-            primary_id,
-            status,
-            phase,
-            queued_at,
-            started_at,
-            finished_at,
-            params,
-            idempotency_key,
-            writeback_status,
-            writeback_completed_at,
-            writeback_result,
-            writeback_error,
-            effects_status,
-            effects_completed_at,
-            effects_error,
-            error
-          ) VALUES (
-            ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, NULL, NULL, ?, ?,
-            NULL, NULL, NULL, NULL,
-            NULL, NULL, NULL,
-            NULL
-          )
-        `).run(input.projectId, input.id, input.executionId, input.actionId, input.subject.kind, input.subject.kind === "object" ? input.subject.objectTypeId : null, input.subject.kind === "object" ? input.subject.primaryId : null, "queued", "request", queuedAt.toISOString(), JSON.stringify(input.params), input.idempotencyKey);
-    } catch (error) {
-      if (isUniqueConstraintError(error)) {
-        return this.requeueAfterEnqueueFailure(input, queuedAt);
-      }
-      throw error;
-    }
-    const record = await this.getById({ projectId: input.projectId, id: input.id });
-    if (!record) {
-      throw new ActionRunError(`[SixbSqlite] Failed to load action run '${input.id}' for project '${input.projectId}'.`);
+    const inserted = this.db.query(`
+        INSERT INTO action_runs (
+          project_id,
+          id,
+          execution_id,
+          action_id,
+          subject_kind,
+          object_type_id,
+          primary_id,
+          status,
+          phase,
+          started_at,
+          finished_at,
+          params,
+          idempotency_key,
+          writeback_status,
+          writeback_completed_at,
+          writeback_result,
+          writeback_error,
+          error
+        ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+        ON CONFLICT DO NOTHING
+      `).run(record.projectId, record.id, record.executionId, record.actionId, record.subject.kind, record.subject.kind === "object" ? record.subject.objectTypeId : null, record.subject.kind === "object" ? record.subject.primaryId : null, record.status, record.phase, record.startedAt.toISOString(), record.finishedAt.toISOString(), JSON.stringify(record.params), record.idempotencyKey, record.writeback?.status ?? null, record.writeback?.completedAt.toISOString() ?? null, record.writeback?.status === "succeeded" ? JSON.stringify(record.writeback.result) : null, record.writeback?.status === "failed" ? serializeActionRunFailure(record.writeback.error, "writeback") : null, record.status === "failed" ? serializeActionRunFailure(record.error) : null);
+    if (inserted.changes === 0) {
+      const conflict = this.selectRow(record.projectId, record.id);
+      throw new ActionRunError(conflict ? `[SixbSqlite] Action run '${record.id}' is already recorded for project '${record.projectId}'.` : `[SixbSqlite] Execution '${record.executionId}' already belongs to another Action run.`);
     }
-    return record;
-  }
-  async requeueAfterEnqueueFailure(input, queuedAt) {
-    return this.db.transaction(() => {
-      const existing = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      if (!existing || !canRequeueActionRunAfterEnqueueFailure(rowToActionRunRecord(existing), input)) {
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' already exists for project '${input.projectId}'.`);
-      }
-      this.db.query(`
-          UPDATE action_runs
-          SET
-            status = ?,
-            phase = ?,
-            queued_at = ?,
-            started_at = NULL,
-            finished_at = NULL,
-            writeback_status = NULL,
-            writeback_completed_at = NULL,
-            writeback_result = NULL,
-            writeback_error = NULL,
-            effects_status = NULL,
-            effects_completed_at = NULL,
-            effects_error = NULL,
-            error = NULL
-          WHERE project_id = ? AND id = ?
-        `).run("queued", "request", queuedAt.toISOString(), input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
-    })();
-  }
-  async start(input) {
-    return this.db.transaction(() => {
-      const existing = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      if (!existing) {
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' not found for project '${input.projectId}'.`);
-      }
-      if (existing.status !== "queued") {
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' cannot start from status '${existing.status}'.`);
-      }
-      this.db.query(`
-          UPDATE action_runs
-          SET
-            status = ?,
-            phase = ?,
-            started_at = ?,
-            error = NULL
-          WHERE project_id = ? AND id = ?
-        `).run("running", input.phase ?? "validation", (input.startedAt ?? new Date).toISOString(), input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
-    })();
-  }
-  async enterPhase(input) {
-    return this.db.transaction(() => {
-      this.requireRunningRun(input.projectId, input.id, "transition phase");
-      this.db.query(`
-          UPDATE action_runs
-          SET phase = ?
-          WHERE project_id = ? AND id = ?
-        `).run(input.phase, input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
-    })();
-  }
-  async recordWriteback(input) {
-    return this.db.transaction(() => {
-      const existing = this.requireRunningRun(input.projectId, input.id, "record writeback");
-      const nextWriteback = toWritebackRecord(input, new Date(input.completedAt ?? new Date));
-      const currentWriteback = toActionRunWritebackRecord(existing);
-      if (currentWriteback) {
-        if (actionRunPhaseRecordsEqual(currentWriteback, nextWriteback)) {
-          return rowToActionRunRecord(existing);
-        }
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' already has a different writeback record.`);
-      }
-      this.db.query(`
-          UPDATE action_runs
-          SET
-            phase = ?,
-            writeback_status = ?,
-            writeback_completed_at = ?,
-            writeback_result = ?,
-            writeback_error = ?
-          WHERE project_id = ? AND id = ?
-        `).run("writeback", input.status, nextWriteback.completedAt.toISOString(), input.status === "succeeded" ? serializeJsonValue(input.result) : null, input.status === "failed" ? serializeActionRunFailure(input.error, "writeback") : null, input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
-    })();
+    return rowToActionRunRecord(this.requireRow(record.projectId, record.id));
   }
   async recordEffects(input) {
     return this.db.transaction(() => {
-      const existing = this.requireRunningRun(input.projectId, input.id, "record effects");
-      const nextEffects = toEffectsRecord(input, new Date(input.completedAt ?? new Date));
-      const currentEffects = toActionRunEffectsRecord(existing);
-      if (currentEffects) {
-        if (actionRunPhaseRecordsEqual(currentEffects, nextEffects)) {
-          return rowToActionRunRecord(existing);
-        }
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' already has a different effects record.`);
-      }
+      const existing = this.selectRow(input.projectId, input.id);
+      const { run, effects } = resolveActionRunEffects(existing ? rowToActionRunRecord(existing) : null, input);
+      if (!effects)
+        return run;
       this.db.query(`
           UPDATE action_runs
           SET
@@ -5613,32 +5638,8 @@ class SqliteActionRunStorage {
             effects_completed_at = ?,
             effects_error = ?
           WHERE project_id = ? AND id = ?
-        `).run("effects", input.status, nextEffects.completedAt.toISOString(), input.status === "failed" ? serializeActionRunFailure(input.error, "effects") : null, input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
-    })();
-  }
-  async finish(input) {
-    return this.db.transaction(() => {
-      const existing = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      if (!existing) {
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' not found for project '${input.projectId}'.`);
-      }
-      if (isTerminalActionRun({ status: existing.status })) {
-        throw new ActionRunError(`[SixbSqlite] Action run '${input.id}' cannot finish from terminal status '${existing.status}'.`);
-      }
-      const phase = finishActionRunPhase(input, existing.phase);
-      this.db.query(`
-          UPDATE action_runs
-          SET
-            status = ?,
-            phase = ?,
-            finished_at = ?,
-            error = ?
-          WHERE project_id = ? AND id = ?
-        `).run(input.status, phase, (input.finishedAt ?? new Date).toISOString(), input.status === "succeeded" ? null : serializeActionRunFailure(input.error), input.projectId, input.id);
-      const updated = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(input.projectId, input.id);
-      return rowToActionRunRecord(updated);
+        `).run("effects", effects.status, effects.completedAt.toISOString(), effects.status === "failed" ? serializeActionRunFailure(effects.error, "effects") : null, input.projectId, input.id);
+      return rowToActionRunRecord(this.requireRow(input.projectId, input.id));
     })();
   }
   async getById(params) {
@@ -5699,11 +5700,11 @@ class SqliteActionRunStorage {
       args.push(...input.statuses);
     }
     if (input.startedAfter) {
-      whereClauses.push("COALESCE(started_at, queued_at) >= ?");
+      whereClauses.push("started_at >= ?");
       args.push(input.startedAfter.toISOString());
     }
     if (input.startedBefore) {
-      whereClauses.push("COALESCE(started_at, queued_at) <= ?");
+      whereClauses.push("started_at <= ?");
       args.push(input.startedBefore.toISOString());
     }
     const where = `WHERE ${whereClauses.join(" AND ")}`;
@@ -5714,7 +5715,7 @@ class SqliteActionRunStorage {
     let query = `
       SELECT * FROM action_runs
       ${where}
-      ORDER BY COALESCE(started_at, queued_at) ${order}, id ${order}
+      ORDER BY started_at ${order}, id ${order}
     `;
     const queryArgs = [...args];
     if (limit !== undefined) {
@@ -5735,31 +5736,22 @@ class SqliteActionRunStorage {
   close() {
     closeSqliteStoreConnection(this.connection);
   }
-  requireRunningRun(projectId, id, operation) {
-    const existing = this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(projectId, id);
-    if (!existing) {
-      throw new ActionRunError(`[SixbSqlite] Action run '${id}' not found for project '${projectId}'.`);
-    }
-    if (existing.status !== "running") {
-      throw new ActionRunError(`[SixbSqlite] Action run '${id}' cannot ${operation} from status '${existing.status}'.`);
+  selectRow(projectId, id) {
+    return this.db.query("SELECT * FROM action_runs WHERE project_id = ? AND id = ?").get(projectId, id);
+  }
+  requireRow(projectId, id) {
+    const row = this.selectRow(projectId, id);
+    if (!row) {
+      throw new ActionRunError(`[SixbSqlite] Action run '${id}' disappeared from project '${projectId}' while recording it.`);
     }
-    return existing;
+    return row;
   }
 }
-function serializeJsonValue(value) {
-  return JSON.stringify(value);
-}
-function toActionRunFailure(row) {
-  return row.error === null ? undefined : parseActionRunFailure(row.error);
-}
-function parsePhaseFailure(value, expectedPhase) {
-  return parseActionRunFailure(value, expectedPhase);
-}
 function toActionRunWritebackRecord(row) {
   if (!row.writeback_status) {
     return;
   }
-  const completedAt = row.writeback_completed_at ? new Date(row.writeback_completed_at) : new Date(row.queued_at);
+  const completedAt = new Date(row.writeback_completed_at ?? row.finished_at);
   if (row.writeback_status === "succeeded") {
     return {
       status: "succeeded",
@@ -5770,14 +5762,14 @@ function toActionRunWritebackRecord(row) {
   return {
     status: "failed",
     completedAt,
-    error: parsePhaseFailure(row.writeback_error, "writeback")
+    error: parseActionRunFailure(row.writeback_error, "writeback")
   };
 }
 function toActionRunEffectsRecord(row) {
   if (!row.effects_status) {
     return;
   }
-  const completedAt = row.effects_completed_at ? new Date(row.effects_completed_at) : new Date(row.queued_at);
+  const completedAt = new Date(row.effects_completed_at ?? row.finished_at);
   if (row.effects_status === "succeeded") {
     return {
       status: "succeeded",
@@ -5787,54 +5779,29 @@ function toActionRunEffectsRecord(row) {
   return {
     status: "failed",
     completedAt,
-    error: parsePhaseFailure(row.effects_error, "effects")
-  };
-}
-function toWritebackRecord(input, completedAt) {
-  if (input.status === "succeeded") {
-    return {
-      status: "succeeded",
-      completedAt,
-      result: input.result
-    };
-  }
-  return {
-    status: "failed",
-    completedAt,
-    error: input.error
-  };
-}
-function toEffectsRecord(input, completedAt) {
-  if (input.status === "succeeded") {
-    return {
-      status: "succeeded",
-      completedAt
-    };
-  }
-  return {
-    status: "failed",
-    completedAt,
-    error: input.error
+    error: parseActionRunFailure(row.effects_error, "effects")
   };
 }
 function rowToActionRunRecord(row) {
-  return {
+  const writeback = toActionRunWritebackRecord(row);
+  const effects = toActionRunEffectsRecord(row);
+  const fields = {
     id: row.id,
     projectId: row.project_id,
     executionId: row.execution_id,
     actionId: row.action_id,
     subject: rowToActionSubject(row),
-    status: row.status,
-    phase: row.phase ?? undefined,
-    queuedAt: new Date(row.queued_at),
-    startedAt: row.started_at ? new Date(row.started_at) : undefined,
-    finishedAt: row.finished_at ? new Date(row.finished_at) : undefined,
+    phase: row.phase,
+    startedAt: new Date(row.started_at),
+    finishedAt: new Date(row.finished_at),
     params: JSON.parse(row.params),
     idempotencyKey: row.idempotency_key,
-    writeback: toActionRunWritebackRecord(row),
-    effects: toActionRunEffectsRecord(row),
-    error: toActionRunFailure(row)
+    ...writeback === undefined ? {} : { writeback },
+    ...effects === undefined ? {} : { effects }
   };
+  if (row.status === "succeeded")
+    return { ...fields, status: "succeeded" };
+  return { ...fields, status: "failed", error: parseActionRunFailure(row.error) };
 }
 function rowToActionSubject(row) {
   if (row.subject_kind === "none") {
@@ -5849,9 +5816,6 @@ function rowToActionSubject(row) {
     primaryId: row.primary_id
   };
 }
-function isUniqueConstraintError(error) {
-  return error instanceof Error && error.message.includes("UNIQUE constraint failed");
-}
 
 // src/agents/checkpoints.ts
 import {
@@ -6105,7 +6069,7 @@ import {
 } from "@sixb/core/storage";
 
 // src/storage-errors.ts
-function isUniqueConstraintError2(error) {
+function isUniqueConstraintError(error) {
   return error instanceof Error && error.message.includes("UNIQUE constraint failed");
 }
 function isForeignKeyConstraintError(error) {
@@ -6151,7 +6115,7 @@ class SqliteAgentMessageStore {
             ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
           `).run(input.projectId, input.id, input.threadId, input.runId, input.role, input.authorPrincipal?.type ?? null, input.authorPrincipal?.id ?? null, seqRow.next, JSON.stringify(input.parts), input.metadata === undefined ? null : JSON.stringify(input.metadata), AGENT_MESSAGE_CONTENT_VERSION, createdAt.toISOString(), input.completedAt ? input.completedAt.toISOString() : null);
       } catch (error) {
-        if (isUniqueConstraintError2(error)) {
+        if (isUniqueConstraintError(error)) {
           throw new AgentStorageError2("duplicate_id", `[SixbSqlite] Agent message '${input.id}' already exists for project '${input.projectId}'.`);
         }
         throw error;
@@ -6340,7 +6304,7 @@ class SqliteAgentRunStore {
             ) VALUES (?, ?, ?, 'conversation', ?, ?, ?, 'queued', 0, ?)
           `).run(input.projectId, input.id, input.executionId, input.threadId, input.triggerMessageId, JSON.stringify(input.spec), createdAt.toISOString());
       } catch (error) {
-        if (isUniqueConstraintError2(error)) {
+        if (isUniqueConstraintError(error)) {
           throw new AgentStorageError3("duplicate_id", `[SixbSqlite] Agent run '${input.id}' already exists for project '${input.projectId}'.`);
         }
         throw error;
@@ -6395,7 +6359,7 @@ class SqliteAgentRunStore {
             ) VALUES (?, ?, ?, 'subagent', ?, ?, ?, 'queued', 0, ?)
           `).run(input.projectId, input.id, input.executionId, input.parentRunId, input.spawnKey, JSON.stringify(input.spec), (input.createdAt ?? new Date).toISOString());
       } catch (error) {
-        if (isUniqueConstraintError2(error)) {
+        if (isUniqueConstraintError(error)) {
           throw new AgentStorageError3("duplicate_id", `[SixbSqlite] Subagent run '${input.id}' conflicts with an existing durable spawn.`);
         }
         throw error;
@@ -6624,7 +6588,7 @@ class SqliteAgentThreadStore {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, NULL, NULL, 0, ?, ?)
         `).run(input.projectId, input.id, input.ownerPrincipal.type, input.ownerPrincipal.id, input.title ?? null, sandboxParams, input.status ?? "active", createdAt.toISOString(), updatedAt.toISOString());
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new AgentStorageError4("duplicate_id", `[SixbSqlite] Agent thread '${input.id}' already exists for project '${input.projectId}'.`);
       }
       throw error;
@@ -6827,7 +6791,7 @@ class SqliteAiUsageStorage {
       try {
         this.insertRecord(record);
       } catch (error) {
-        if (!isUniqueConstraintError2(error))
+        if (!isUniqueConstraintError(error))
           throw error;
         const concurrent = this.findByIdempotencyKey(record);
         if (concurrent)
@@ -7035,7 +6999,7 @@ class SqliteAiCostStorage {
       try {
         this.insertCost(record);
       } catch (error) {
-        if (!isUniqueConstraintError2(error))
+        if (!isUniqueConstraintError(error))
           throw error;
         if (!this.findCost(record.projectId, record.usageRecordId))
           throw error;
@@ -8613,7 +8577,7 @@ function revokeActiveMagicLinksForEmail(db, params) {
   }));
 }
 function mapUniqueConstraintError(error, code, message) {
-  if (isUniqueConstraintError2(error)) {
+  if (isUniqueConstraintError(error)) {
     throw new AuthStorageError(code, message);
   }
   throw error;
@@ -10233,7 +10197,7 @@ class SqliteConnectorConnectionPersistence {
         `).run(record.projectId, record.connectorId, record.id, record.slot, record.initiatedByExecutionId, record.stateHash, record.codeVerifier === undefined ? null : json(record.codeVerifier), record.redirectUri, record.connectionRunId ?? null, record.returnTo ?? null, record.callbackBindingHash ?? null, record.reauthorizationId ?? null, record.reauthorizationRevision ?? null, record.reauthorizationConnectionIds ? json(record.reauthorizationConnectionIds) : null, iso(record.createdAt), iso(record.expiresAt));
       return true;
     } catch (error) {
-      if (isUniqueConstraintError2(error))
+      if (isUniqueConstraintError(error))
         return false;
       throw error;
     }
@@ -10259,7 +10223,7 @@ class SqliteConnectorConnectionPersistence {
       this.insertRun(record);
       return true;
     } catch (error) {
-      if (isUniqueConstraintError2(error))
+      if (isUniqueConstraintError(error))
         return false;
       throw error;
     }
@@ -10293,7 +10257,7 @@ class SqliteConnectorConnectionPersistence {
       this.insertAuthorizationRow(record);
       return true;
     } catch (error) {
-      if (isUniqueConstraintError2(error))
+      if (isUniqueConstraintError(error))
         return false;
       throw error;
     }
@@ -10324,7 +10288,7 @@ class SqliteConnectorConnectionPersistence {
         `).run(record.projectId, record.connectorId, record.id, record.authorizationId, record.slot, json(record.account), record.account.id, record.status, optionalIso(record.disconnectedAt), iso(record.createdAt), iso(record.updatedAt));
       return true;
     } catch (error) {
-      if (isUniqueConstraintError2(error))
+      if (isUniqueConstraintError(error))
         return false;
       throw error;
     }
@@ -10837,7 +10801,7 @@ class SqliteFileUploadSessionPersistence {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`).run(session.id, session.projectId, session.principal.type, session.principal.id, session.strategy, session.status, session.fileName ?? null, session.mediaType ?? null, session.logicalPath ?? null, session.expectedSizeBytes ?? null, session.expectedDigest ?? null, ...mutableColumns(session));
       return true;
     } catch (error) {
-      if (isUniqueConstraintError2(error))
+      if (isUniqueConstraintError(error))
         return false;
       throw error;
     }
@@ -16392,7 +16356,7 @@ class SqlitePipelineRunStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, NULL)
         `).run(input.projectId, input.id, input.executionId, input.pipelineId, "queued", queuedAt.toISOString());
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         return this.requeueAfterEnqueueFailure(input, queuedAt);
       }
       throw error;
@@ -16489,7 +16453,7 @@ class SqlitePipelineRunStorage {
             ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
           `).run(input.projectId, input.id, input.pipelineRunId, input.pipelineId, input.stepId, input.datasetId, input.mode, "running", startedAt.toISOString(), serializeDatasetVersionRefs(input.inputs));
       } catch (error) {
-        if (isUniqueConstraintError2(error)) {
+        if (isUniqueConstraintError(error)) {
           throw new PipelineRunError(`[SixbSqlite] Pipeline step run '${input.id}' already exists for project '${input.projectId}'.`);
         }
         throw error;
@@ -16757,7 +16721,7 @@ class SqliteProjectionRunStorage {
       try {
         this.insertQueued(record);
       } catch (error) {
-        if (isUniqueConstraintError3(error))
+        if (isUniqueConstraintError2(error))
           throw duplicateProjectionRun(input);
         throw error;
       }
@@ -17146,7 +17110,7 @@ function databaseSafeInteger(value, fieldName) {
   }
   return value;
 }
-function isUniqueConstraintError3(error) {
+function isUniqueConstraintError2(error) {
   return error instanceof Error && error.message.includes("UNIQUE constraint failed");
 }
 function duplicateProjectionRun(input) {
@@ -17422,7 +17386,7 @@ class SqliteShareGrantStorage {
             ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
           `).run(record.projectId, record.id, record.definitionId, record.target.objectTypeId, record.target.primaryId, record.issuedBy.type, record.issuedBy.id, record.authoritySnapshot.version, JSON.stringify(record.authoritySnapshot), record.authorityDigest, record.tokenHash, record.destinationPath, record.createdAt.toISOString(), record.expiresAt.toISOString());
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new ShareGrantStorageError("duplicate", `[SixbSqlite] Share grant '${record.id}' conflicts with an existing record.`, { cause: error });
       }
       throw error;
@@ -17571,7 +17535,7 @@ class SqliteShareSessionStorage {
         throw invalidRecord2(`Share session '${record.id}' disappeared after create.`);
       return rowToRecord2(row);
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new ShareSessionStorageError("duplicate", `[SixbSqlite] Share session '${record.id}' conflicts with an existing record.`, { cause: error });
       }
       if (isForeignKeyConstraintError(error)) {
@@ -17688,7 +17652,7 @@ class SqliteSyncRunStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, NULL, ?, ?)
         `).run(input.projectId, input.id, input.executionId, input.syncId, input.datasetId, input.mode, "queued", queuedAt.toISOString(), input.expectedLatestVersionId ?? null, input.commitMessage ?? null);
     } catch (error) {
-      if (isUniqueConstraintError4(error)) {
+      if (isUniqueConstraintError3(error)) {
         return this.requeueAfterEnqueueFailure(input, queuedAt);
       }
       throw error;
@@ -17853,7 +17817,7 @@ function rowToSyncRunRecord(row) {
     checkpoint: parseCheckpoint(row.checkpoint)
   };
 }
-function isUniqueConstraintError4(error) {
+function isUniqueConstraintError3(error) {
   return error instanceof Error && error.message.includes("UNIQUE constraint failed");
 }
 
@@ -18019,7 +17983,7 @@ class SqliteWebhookRunStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
         `).run(input.projectId, input.id, input.executionId, input.connectorId, input.webhookId, "running", input.method, input.route, startedAt.toISOString(), input.requestBodyBytes, input.requestBodySha256, input.idempotencyKey ?? null);
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new WebhookRunError(`[SixbSqlite] Webhook run '${input.id}' or delivery key already exists for project '${input.projectId}'.`, "duplicate_run");
       }
       throw error;
@@ -18172,7 +18136,7 @@ class SqliteWorkflowInterventionStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
         `).run(input.projectId, input.id, input.workflowId, input.workflowRunId, input.nodeRunId, input.nodeIndex, input.nodeId, input.nodeKey, input.interventionId, serializeRecord(input.input), serializeRecord(input.defaultResponse), "pending", (input.requestedAt ?? new Date).toISOString(), input.expiresAt?.toISOString() ?? null);
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new WorkflowInterventionError(`[SixbSqlite] Workflow intervention '${input.id}' already exists for project '${input.projectId}'.`);
       }
       throw error;
@@ -18413,7 +18377,7 @@ class SqliteWorkflowRunStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
         `).run(input.projectId, input.id, input.executionId, input.workflowId, "queued", serializeRecord2(input.input), queuedAt.toISOString(), queuedAt.toISOString(), 0);
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new WorkflowRunError(`[SixbSqlite] Workflow run '${input.id}' or execution '${input.executionId}' is already linked for project '${input.projectId}'.`);
       }
       throw error;
@@ -18639,7 +18603,7 @@ class SqliteWorkflowAgentNodeRunStorage {
           ) VALUES (?, ?, ?, ?, ?, ?, ?, ?)
         `).run(input.projectId, input.nodeRunId, input.executionId, input.actorId, "queued", input.prompt, 0, (input.createdAt ?? new Date).toISOString());
     } catch (error) {
-      if (isUniqueConstraintError2(error)) {
+      if (isUniqueConstraintError(error)) {
         throw new WorkflowRunError(`[SixbSqlite] Agent execution already exists for workflow node run '${input.nodeRunId}'.`);
       }
       throw error;
@@ -18788,7 +18752,7 @@ class SqliteWorkflowNodeRunStorage {
             ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
           `).run(input.projectId, input.id, input.workflowRunId, input.workflowId, input.nodeIndex, input.nodeType, input.nodeId, input.nodeKey, "running", serializeRecord2(input.input), startedAt.toISOString());
       } catch (error) {
-        if (isUniqueConstraintError2(error)) {
+        if (isUniqueConstraintError(error)) {
           throw new WorkflowRunError(`[SixbSqlite] Workflow node run '${input.id}' already exists for project '${input.projectId}'.`);
         }
         throw error;
@@ -19206,4 +19170,4 @@ export {
   migrateSqliteStorage
 };
 
-//# debugId=0E043C316BC5C57264756E2164756E21
+//# debugId=682E7F57F0A7280864756E2164756E21