@sixb/pg 0.1.18 → 0.1.19

package/dist/migrations.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"migrations.d.ts","sourceRoot":"","sources":["../src/migrations.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,YAAY,CAAA;AACjD,OAAO,KAAK,EAGV,YAAY,EACZ,aAAa,EACb,oBAAoB,EACrB,MAAM,oBAAoB,CAAA;AAqH3B,OAAO,KAAK,EAAe,GAAG,EAAa,MAAM,aAAa,CAAA;AAG9D,MAAM,WAAW,wBAAwB;IACvC,IAAI,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAA;CACrC;AAED,eAAO,MAAM,2BAA2B,wBAAwB,CAAA;AAEhE,wBAAgB,KAAK,CAAC,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,aAAa,CAAC,wBAAwB,CAAC,CAE1F;AAED,wBAAgB,MAAM,CACpB,EAAE,EAAE,MAAM,EACV,EAAE,EAAE,CAAC,OAAO,EAAE,wBAAwB,KAAK,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,EAC/D,OAAO,GAAE,oBAAyB,GACjC,aAAa,CAAC,wBAAwB,CAAC,CAEzC;AAED,wBAAgB,8BAA8B,CAC5C,GAAG,EAAE,GAAG,EACR,UAAU,EAAE,MAAM,GACjB,SAAS,eAAe,EAAE,CAQ5B;AAED,wBAAgB,sBAAsB,CAAC,MAAM,EAAE;IAC7C,QAAQ,CAAC,GAAG,EAAE,GAAG,CAAA;IACjB,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAA;IAC3B,QAAQ,CAAC,UAAU,EAAE,YAAY,CAAC,wBAAwB,CAAC,CAAA;CAC5D,GAAG,eAAe,CAqBlB;AAED,wBAAsB,sBAAsB,CAAC,GAAG,EAAE,GAAG,EAAE,UAAU,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAMxF;AAED,wBAAsB,UAAU,CAAC,GAAG,EAAE,GAAG,EAAE,UAAU,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAE5E;AAED,wBAAgB,UAAU,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAKrD;AAuKD,eAAO,MAAM,yBAAyB,wCAgEpC,CAAA"}
+{"version":3,"file":"migrations.d.ts","sourceRoot":"","sources":["../src/migrations.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,YAAY,CAAA;AACjD,OAAO,KAAK,EAGV,YAAY,EACZ,aAAa,EACb,oBAAoB,EACrB,MAAM,oBAAoB,CAAA;AAqH3B,OAAO,KAAK,EAAe,GAAG,EAAa,MAAM,aAAa,CAAA;AAG9D,MAAM,WAAW,wBAAwB;IACvC,IAAI,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAA;CACrC;AAED,eAAO,MAAM,2BAA2B,wBAAwB,CAAA;AAEhE,wBAAgB,KAAK,CAAC,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,aAAa,CAAC,wBAAwB,CAAC,CAE1F;AAED,wBAAgB,MAAM,CACpB,EAAE,EAAE,MAAM,EACV,EAAE,EAAE,CAAC,OAAO,EAAE,wBAAwB,KAAK,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,EAC/D,OAAO,GAAE,oBAAyB,GACjC,aAAa,CAAC,wBAAwB,CAAC,CAEzC;AAED,wBAAgB,8BAA8B,CAC5C,GAAG,EAAE,GAAG,EACR,UAAU,EAAE,MAAM,GACjB,SAAS,eAAe,EAAE,CAQ5B;AAED,wBAAgB,sBAAsB,CAAC,MAAM,EAAE;IAC7C,QAAQ,CAAC,GAAG,EAAE,GAAG,CAAA;IACjB,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAA;IAC3B,QAAQ,CAAC,UAAU,EAAE,YAAY,CAAC,wBAAwB,CAAC,CAAA;CAC5D,GAAG,eAAe,CAqBlB;AAED,wBAAsB,sBAAsB,CAAC,GAAG,EAAE,GAAG,EAAE,UAAU,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAMxF;AAED,wBAAsB,UAAU,CAAC,GAAG,EAAE,GAAG,EAAE,UAAU,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAE5E;AAED,wBAAgB,UAAU,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAKrD;AAuKD,eAAO,MAAM,yBAAyB,wCAiEpC,CAAA"}

package/dist/pg-action-run-storage.d.ts

@@ -1,22 +1,15 @@
-import type { ActionRunRecord, ActionRunStorage, EnterActionRunPhaseInput, ExecutionStorage, FinishActionRunInput, ListActionRunsInput, ListActionRunsResult, LockActionMaterializationRunInput, QueueActionRunInput, RecordActionEffectsInput, RecordActionWritebackInput, StartActionRunInput } from "@sixb/core/storage";
+import type { ActionRunRecord, ActionRunStorage, ExecutionStorage, ListActionRunsInput, ListActionRunsResult, RecordActionEffectsInput, RecordActionRunInput } from "@sixb/core/storage";
 import { type PgStoreClient } from "./transactions";
 export declare class PgActionRunStorage implements ActionRunStorage {
     private readonly sql;
     private readonly executions;
     constructor(sql: PgStoreClient, executions: ExecutionStorage);
-    lockForMaterialization(input: LockActionMaterializationRunInput): Promise<ActionRunRecord>;
-    queue(input: QueueActionRunInput): Promise<ActionRunRecord>;
-    private requeueAfterEnqueueFailure;
-    start(input: StartActionRunInput): Promise<ActionRunRecord>;
-    enterPhase(input: EnterActionRunPhaseInput): Promise<ActionRunRecord>;
-    recordWriteback(input: RecordActionWritebackInput): Promise<ActionRunRecord>;
+    record(input: RecordActionRunInput): Promise<ActionRunRecord>;
     recordEffects(input: RecordActionEffectsInput): Promise<ActionRunRecord>;
-    finish(input: FinishActionRunInput): Promise<ActionRunRecord>;
     getById(params: {
         projectId: string;
         id: string;
     }): Promise<ActionRunRecord | null>;
     list(input: ListActionRunsInput): Promise<ListActionRunsResult>;
-    private requireRunningRun;
 }
 //# sourceMappingURL=pg-action-run-storage.d.ts.map

package/dist/pg-action-run-storage.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"pg-action-run-storage.d.ts","sourceRoot":"","sources":["../src/pg-action-run-storage.ts"],"names":[],"mappings":"AAWA,OAAO,KAAK,EAKV,eAAe,EACf,gBAAgB,EAEhB,wBAAwB,EACxB,gBAAgB,EAChB,oBAAoB,EACpB,mBAAmB,EACnB,oBAAoB,EACpB,iCAAiC,EACjC,mBAAmB,EACnB,wBAAwB,EACxB,0BAA0B,EAC1B,mBAAmB,EACpB,MAAM,oBAAoB,CAAA;AAI3B,OAAO,EAAE,KAAK,aAAa,EAAoB,MAAM,gBAAgB,CAAA;AAErE,qBAAa,kBAAmB,YAAW,gBAAgB;IAEvD,OAAO,CAAC,QAAQ,CAAC,GAAG;IACpB,OAAO,CAAC,QAAQ,CAAC,UAAU;gBADV,GAAG,EAAE,aAAa,EAClB,UAAU,EAAE,gBAAgB;IAGzC,sBAAsB,CAAC,KAAK,EAAE,iCAAiC,GAAG,OAAO,CAAC,eAAe,CAAC;IAyB1F,KAAK,CAAC,KAAK,EAAE,mBAAmB,GAAG,OAAO,CAAC,eAAe,CAAC;YAuEnD,0BAA0B;IAyClC,KAAK,CAAC,KAAK,EAAE,mBAAmB,GAAG,OAAO,CAAC,eAAe,CAAC;IA8B3D,UAAU,CAAC,KAAK,EAAE,wBAAwB,GAAG,OAAO,CAAC,eAAe,CAAC;IAerE,eAAe,CAAC,KAAK,EAAE,0BAA0B,GAAG,OAAO,CAAC,eAAe,CAAC;IAqC5E,aAAa,CAAC,KAAK,EAAE,wBAAwB,GAAG,OAAO,CAAC,eAAe,CAAC;IA+BxE,MAAM,CAAC,KAAK,EAAE,oBAAoB,GAAG,OAAO,CAAC,eAAe,CAAC;IAqC7D,OAAO,CAAC,MAAM,EAAE;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAA;KAAE,GAAG,OAAO,CAAC,eAAe,GAAG,IAAI,CAAC;IASnF,IAAI,CAAC,KAAK,EAAE,mBAAmB,GAAG,OAAO,CAAC,oBAAoB,CAAC;YAkHvD,iBAAiB;CAwBhC"}
+{"version":3,"file":"pg-action-run-storage.d.ts","sourceRoot":"","sources":["../src/pg-action-run-storage.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAIV,eAAe,EAEf,gBAAgB,EAEhB,gBAAgB,EAChB,mBAAmB,EACnB,oBAAoB,EACpB,wBAAwB,EACxB,oBAAoB,EACrB,MAAM,oBAAoB,CAAA;AAG3B,OAAO,EAAE,KAAK,aAAa,EAAoB,MAAM,gBAAgB,CAAA;AAErE,qBAAa,kBAAmB,YAAW,gBAAgB;IAEvD,OAAO,CAAC,QAAQ,CAAC,GAAG;IACpB,OAAO,CAAC,QAAQ,CAAC,UAAU;gBADV,GAAG,EAAE,aAAa,EAClB,UAAU,EAAE,gBAAgB;IAGzC,MAAM,CAAC,KAAK,EAAE,oBAAoB,GAAG,OAAO,CAAC,eAAe,CAAC;IAuE7D,aAAa,CAAC,KAAK,EAAE,wBAAwB,GAAG,OAAO,CAAC,eAAe,CAAC;IA2BxE,OAAO,CAAC,MAAM,EAAE;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAA;KAAE,GAAG,OAAO,CAAC,eAAe,GAAG,IAAI,CAAC;IASnF,IAAI,CAAC,KAAK,EAAE,mBAAmB,GAAG,OAAO,CAAC,oBAAoB,CAAC;CAiHtE"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sixb/pg",
-  "version": "0.1.18",
+  "version": "0.1.19",
   "description": "PostgreSQL storage provider for Sixb",
   "keywords": [
     "sixb",
@@ -40,10 +40,10 @@
     "postgres": "^3.4.5"
   },
   "peerDependencies": {
-    "@sixb/core": "0.1.18"
+    "@sixb/core": "0.1.19"
   },
   "devDependencies": {
-    "@sixb/core": "0.1.18",
+    "@sixb/core": "0.1.19",
     "@types/bun": "latest",
     "typescript": "^5.7.0"
   },

package/src/migrations/061-terminal-action-runs.sql

@@ -0,0 +1,150 @@
+-- Actions run in the request that asks for them and record their run once, when it ends. No run
+-- is queued, running, or cancelled any more, and every run has started and finished.
+
+-- A run left running after its edits committed, as a crash between the commit and the end of the
+-- run left it, succeeded: its edits and their outbox facts are in the commit. A run that stopped
+-- during its effects keeps that phase, and records effects that never ended.
+UPDATE action_runs AS run
+SET
+  status = 'succeeded',
+  error = NULL,
+  finished_at = committed.committed_at,
+  phase = CASE WHEN run.phase = 'effects' THEN 'effects' ELSE 'commit' END,
+  effects_status = CASE
+    WHEN run.phase = 'effects' AND run.effects_status IS NULL THEN 'failed'
+    ELSE run.effects_status
+  END,
+  effects_completed_at = CASE
+    WHEN run.phase = 'effects' AND run.effects_status IS NULL THEN now()
+    ELSE run.effects_completed_at
+  END,
+  effects_error = CASE
+    WHEN run.phase = 'effects' AND run.effects_status IS NULL THEN jsonb_build_object(
+      'code', 'internal.unexpected',
+      'message', 'Abandoned: Actions now run synchronously; these effects never finished.',
+      'retryable', false,
+      'at', to_char(now() AT TIME ZONE 'UTC', 'YYYY-MM-DD"T"HH24:MI:SS.MS"Z"'),
+      'details', jsonb_build_object('actionId', run.action_id, 'runId', run.id, 'phase', 'effects')
+    )
+    ELSE run.effects_error
+  END
+FROM ontology_commits AS committed
+WHERE run.status IN ('queued', 'running')
+  AND committed.origin_kind = 'action'
+  AND committed.project_id = run.project_id
+  AND committed.origin_run_id = run.id;
+
+-- Any other run left queued or running never finished, and nothing will resume it.
+UPDATE action_runs
+SET
+  status = 'failed',
+  finished_at = now(),
+  error = jsonb_build_object(
+    'code', 'internal.unexpected',
+    'message', 'Abandoned: Actions now run synchronously; this run never finished.',
+    'retryable', false,
+    'at', to_char(now() AT TIME ZONE 'UTC', 'YYYY-MM-DD"T"HH24:MI:SS.MS"Z"'),
+    'details', jsonb_build_object('actionId', action_id, 'runId', id)
+  )
+WHERE status IN ('queued', 'running');
+
+-- A cancelled run failed: it keeps the failure it recorded.
+UPDATE action_runs SET status = 'failed' WHERE status = 'cancelled';
+
+-- Every failed run carries a failure. One recorded before failures were kept explains itself.
+UPDATE action_runs
+SET error = jsonb_build_object(
+  'code', 'internal.unexpected',
+  'message', 'This run failed before Sixb recorded why.',
+  'retryable', false,
+  'at', to_char(COALESCE(finished_at, now()) AT TIME ZONE 'UTC', 'YYYY-MM-DD"T"HH24:MI:SS.MS"Z"'),
+  'details', jsonb_build_object('actionId', action_id, 'runId', id)
+)
+WHERE status = 'failed' AND error IS NULL;
+
+-- The phases `request`, `enqueue`, and `cancelled` are gone: a run that stopped in one of them
+-- never got past validation. A run starts when it was queued at the latest.
+UPDATE action_runs
+SET
+  phase = CASE
+    WHEN phase IN ('validation', 'writeback', 'edits', 'commit', 'effects') THEN phase
+    ELSE 'validation'
+  END,
+  started_at = COALESCE(started_at, queued_at),
+  finished_at = COALESCE(finished_at, now()),
+  writeback_completed_at = CASE
+    WHEN writeback_status IS NULL THEN NULL
+    ELSE COALESCE(writeback_completed_at, finished_at, now())
+  END,
+  effects_completed_at = CASE
+    WHEN effects_status IS NULL THEN NULL
+    ELSE COALESCE(effects_completed_at, finished_at, now())
+  END
+WHERE phase IS NULL
+  OR phase NOT IN ('validation', 'writeback', 'edits', 'commit', 'effects')
+  OR started_at IS NULL
+  OR finished_at IS NULL
+  OR (writeback_status IS NOT NULL AND writeback_completed_at IS NULL)
+  OR (effects_status IS NOT NULL AND effects_completed_at IS NULL);
+
+-- A failure names the phase its run ended in, and only Action codes: an enqueue failure, which no
+-- run can meet any more, reads as the unexpected error it now is.
+UPDATE action_runs
+SET error = jsonb_set(
+  CASE
+    WHEN error->>'code' = 'queue.enqueue_failed'
+      THEN error || '{"code": "internal.unexpected", "retryable": false}'::jsonb
+    ELSE error
+  END,
+  '{details,phase}',
+  to_jsonb(phase)
+)
+WHERE error IS NOT NULL
+  AND (
+    error->'details'->>'phase' IS DISTINCT FROM phase
+    OR error->>'code' = 'queue.enqueue_failed'
+  );
+
+-- The status and phase checks were unnamed. Drop exactly the two that admit the removed values.
+DO $$
+DECLARE lifecycle_constraint RECORD;
+BEGIN
+  FOR lifecycle_constraint IN
+    SELECT conname
+    FROM pg_constraint
+    WHERE conrelid = 'action_runs'::regclass
+      AND contype = 'c'
+      AND (
+        pg_get_constraintdef(oid) LIKE '%''queued''%'
+        OR pg_get_constraintdef(oid) LIKE '%''enqueue''%'
+      )
+  LOOP
+    EXECUTE format('ALTER TABLE action_runs DROP CONSTRAINT %I', lifecycle_constraint.conname);
+  END LOOP;
+END $$;
+
+-- The listing indexes ordered runs by `COALESCE(started_at, queued_at)`.
+DROP INDEX idx_action_runs_project_started;
+DROP INDEX idx_action_runs_project_action_started;
+DROP INDEX idx_action_runs_project_object_started;
+DROP INDEX idx_action_runs_project_status_started;
+
+ALTER TABLE action_runs
+  DROP COLUMN queued_at,
+  ALTER COLUMN phase SET NOT NULL,
+  ALTER COLUMN started_at SET NOT NULL,
+  ALTER COLUMN finished_at SET NOT NULL,
+  ADD CONSTRAINT action_runs_status_check CHECK (status IN ('succeeded', 'failed')),
+  ADD CONSTRAINT action_runs_phase_check CHECK (
+    phase IN ('validation', 'writeback', 'edits', 'commit', 'effects')
+  ),
+  ADD CONSTRAINT action_runs_failure_check CHECK ((status = 'failed') = (error IS NOT NULL));
+
+CREATE INDEX idx_action_runs_project_started
+  ON action_runs (project_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_action_started
+  ON action_runs (project_id, action_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_object_started
+  ON action_runs (project_id, object_type_id, primary_id, started_at DESC);
+CREATE INDEX idx_action_runs_project_status_started
+  ON action_runs (project_id, status, started_at DESC);

package/src/migrations.ts

@@ -431,6 +431,7 @@ export const postgresStorageMigrations = defineMigrations<PostgresMigrationConte
     pgSql("058-reranking-model-kind", rerankingModelKindSql),
     pgSql("059-file-download-grants", fileDownloadGrantsSql),
     pgSql("060-drained-source-versions", drainedSourceVersionsSql),
+    pgSql("061-terminal-action-runs", terminalActionRunsSql),
   ],
 })
 
@@ -459,3 +460,4 @@ import fileDownloadGrantsSql from "./migrations/059-file-download-grants.sql" wi
 import drainedSourceVersionsSql from "./migrations/060-drained-source-versions.sql" with {
   type: "text",
 }
+import terminalActionRunsSql from "./migrations/061-terminal-action-runs.sql" with { type: "text" }