@sixb/pg 0.1.1 → 0.1.2

package/src/pg-projection-run-storage.ts

@@ -1,14 +1,21 @@
 import { randomUUID } from "node:crypto"
+import type { JsonValue } from "@sixb/core"
+import { serializeSixbFailure } from "@sixb/core/internal/errors"
 import {
   advanceProjectionTelemetry,
   assertGenericProgressDoesNotAdvanceTelemetry,
   assertProjectionMissingTarget,
-  assertProjectionRunExecution,
+  assertProjectionRunAttempt,
+  assertProjectionRunDurableExecution,
   assertProjectionRunListWindow,
   assertProjectionRunNonEmpty,
+  assertProjectionRunQueueInput,
   assertProjectionRunRunning,
   assertProjectionRunStartInput,
+  canRequeueProjectionRunAfterEnqueueFailure,
   createProjectionRunClaim,
+  createProjectionRunRecord,
+  failProjectionRunEnqueue,
   immutableDatasetVersionConflict,
   mergeProjectionRunProgress,
   type PersistedProjectionRunRecord,
@@ -16,7 +23,6 @@ import {
   planProjectionRunReclaim,
   projectionRunNotFound,
   publicProjectionRunRecord,
-  requireProjectionRunExecutionToken,
   requireTelemetryProjectionRun,
   restoreProjectionRun,
   type StoredProjectionRunRecord,
@@ -24,6 +30,8 @@ import {
 } from "@sixb/core/internal/projection-run-storage-provider"
 import type {
   AdvanceProjectionTelemetryCheckpointInput,
+  ExecutionStorage,
+  FailProjectionRunEnqueueInput,
   FinishProjectionRunInput,
   ListLatestProjectionRunsInput,
   ListLatestProjectionRunsResult,
@@ -35,21 +43,34 @@ import type {
   ProjectionRunRecord,
   ProjectionRunStatus,
   ProjectionRunStorage,
+  QueueProjectionRunInput,
   RecordProjectionMissingTargetInput,
   StartOrReclaimProjectionRunInput,
   TelemetryProjectionRunRecord,
   UpdateProjectionRunInput,
 } from "@sixb/core/storage"
-import { ProjectionRunError } from "@sixb/core/storage"
+import { PROJECTION_RUN_FAILURE_CODES, ProjectionRunError } from "@sixb/core/storage"
 import { queryLatestRunsByOwnerId } from "./latest-run-query"
 import type { SQLClient, SqlParameter } from "./pg-client"
 import { lockAdvisoryKeys, type PgStoreClient, runPgTransaction } from "./transactions"
 
 export class PgProjectionRunStorage implements ProjectionRunStorage {
-  constructor(private readonly sql: PgStoreClient) {}
-
-  async startOrReclaim(input: StartOrReclaimProjectionRunInput): Promise<ProjectionRunClaim> {
-    assertProjectionRunStartInput(input)
+  constructor(
+    private readonly sql: PgStoreClient,
+    private readonly executions: ExecutionStorage
+  ) {}
+
+  async queue(input: QueueProjectionRunInput): Promise<ProjectionRunRecord> {
+    assertProjectionRunQueueInput(input)
+    await assertProjectionRunDurableExecution({
+      executions: this.executions,
+      projectId: input.projectId,
+      executionId: input.executionId,
+      runId: input.id,
+      projectionId: input.identity.projectionId,
+      datasetId: input.identity.datasetVersion.datasetId,
+      datasetVersionId: input.identity.datasetVersion.versionId,
+    })
 
     return runPgTransaction(this.sql, async (tx) => {
       await lockAdvisoryKeys(tx, [
@@ -60,98 +81,119 @@ export class PgProjectionRunStorage implements ProjectionRunStorage {
           input.identity.datasetVersion.versionId
         ),
       ])
-      const [metadataConflict] = await tx<{ readonly id: string }[]>`
-        SELECT id FROM projection_runs
-        WHERE project_id = ${input.projectId}
-          AND id <> ${input.id}
-          AND dataset_id = ${input.identity.datasetVersion.datasetId}
-          AND dataset_version_id = ${input.identity.datasetVersion.versionId}
-          AND dataset_version_created_at IS NOT NULL
-          AND dataset_version_created_at <> ${input.identity.datasetVersion.createdAt}
-        LIMIT 1
-      `
-      if (metadataConflict) {
-        throw immutableDatasetVersionConflict(input.identity)
-      }
-
+      await assertDatasetVersionIsImmutable(tx, input)
       const [existingRow] = await tx<DatabaseRow[]>`
         SELECT * FROM projection_runs
         WHERE project_id = ${input.projectId} AND id = ${input.id}
         FOR UPDATE
       `
-
-      const existing = existingRow ? restoreProjectionRunRow(existingRow) : undefined
-      const executionToken = createFreshExecutionToken(existing?.executionToken)
-
-      if (existingRow && existing) {
-        const { attempt } = planProjectionRunReclaim(existing, input)
-        const previousExecutionToken = requireProjectionRunExecutionToken(existing)
-
-        const [updated] = await tx<DatabaseRow[]>`
+      if (existingRow) {
+        if (
+          !canRequeueProjectionRunAfterEnqueueFailure(rowToProjectionRunRecord(existingRow), input)
+        ) {
+          throw duplicateProjectionRun(input)
+        }
+        const [requeued] = await tx<DatabaseRow[]>`
           UPDATE projection_runs
-          SET attempt = ${attempt}, execution_token = ${executionToken}
-          WHERE project_id = ${input.projectId}
-            AND id = ${input.id}
-            AND status = ${"running"}
-            AND execution_token = ${previousExecutionToken}
+          SET status = ${"queued"}, queued_at = ${input.queuedAt ?? new Date()},
+            started_at = ${null}, finished_at = ${null}, attempt = ${0}, execution_token = ${null},
+            next_batch_ordinal = ${input.fixedBatchSize === undefined ? null : 0},
+            next_row_offset = ${input.fixedBatchSize === undefined ? null : 0},
+            input_exhausted = ${input.fixedBatchSize === undefined ? null : false},
+            missing_target_object_type_id = ${null}, missing_target_object_id = ${null},
+            missing_target_batch_ordinal = ${null}, missing_target_first_seen_at = ${null},
+            source_rows_read = ${0}, source_rows_skipped = ${0}, error = ${null}
+          WHERE project_id = ${input.projectId} AND id = ${input.id}
+            AND status = ${"failed"} AND error->>'code' = ${"queue.enqueue_failed"}
           RETURNING *
         `
-        if (!updated) throw staleProjectionRunExecution(input.id)
-        return projectionRunClaim(updated)
+        if (!requeued) throw duplicateProjectionRun(input)
+        return rowToProjectionRunRecord(requeued)
       }
 
+      const record = createProjectionRunRecord(input)
+      const checkpoint = record.telemetryCheckpoint
       const [inserted] = await tx<DatabaseRow[]>`
         INSERT INTO projection_runs (
-          project_id,
-          id,
-          projection_id,
-          projection_kind,
-          dataset_id,
-          dataset_version_id,
-          object_type_id,
-          source_object_type_id,
-          target_object_type_id,
-          status,
-          started_at,
-          attempt,
-          execution_token,
-          materialization_protocol,
-          dataset_version_created_at,
-          ontology_revision,
-          projection_revision,
-          ownership_hash,
-          fixed_batch_size,
-          next_batch_ordinal,
-          next_row_offset,
-          input_exhausted
+          project_id, id, execution_id, projection_id, projection_kind,
+          materialization_protocol, dataset_id, dataset_version_id,
+          dataset_version_created_at, ontology_revision, projection_revision, ownership_hash,
+          object_type_id, source_object_type_id, target_object_type_id, status, queued_at,
+          started_at, finished_at, attempt, execution_token, fixed_batch_size,
+          next_batch_ordinal, next_row_offset, input_exhausted, source_rows_read,
+          source_rows_skipped
         ) VALUES (
-          ${input.projectId},
-          ${input.id},
-          ${input.identity.projectionId},
-          ${input.identity.projectionKind},
-          ${input.identity.datasetVersion.datasetId},
-          ${input.identity.datasetVersion.versionId},
-          ${"objectTypeId" in input.target ? input.target.objectTypeId : null},
-          ${"sourceObjectTypeId" in input.target ? input.target.sourceObjectTypeId : null},
-          ${"sourceObjectTypeId" in input.target ? input.target.targetObjectTypeId : null},
-          ${"running"},
-          ${input.startedAt ?? new Date()},
-          ${1},
-          ${executionToken},
-          ${input.identity.protocol},
-          ${input.identity.datasetVersion.createdAt},
-          ${input.identity.ontologyRevision},
-          ${input.identity.projectionRevision},
-          ${input.identity.ownershipHash},
-          ${input.fixedBatchSize ?? null},
-          ${input.fixedBatchSize === undefined ? null : 0},
-          ${input.fixedBatchSize === undefined ? null : 0},
-          ${input.fixedBatchSize === undefined ? null : false}
+          ${record.projectId}, ${record.id}, ${record.executionId},
+          ${record.identity.projectionId}, ${record.identity.projectionKind},
+          ${record.identity.protocol}, ${record.identity.datasetVersion.datasetId},
+          ${record.identity.datasetVersion.versionId}, ${record.identity.datasetVersion.createdAt},
+          ${record.identity.ontologyRevision}, ${record.identity.projectionRevision},
+          ${record.identity.ownershipHash},
+          ${"objectTypeId" in record.target ? record.target.objectTypeId : null},
+          ${"sourceObjectTypeId" in record.target ? record.target.sourceObjectTypeId : null},
+          ${"sourceObjectTypeId" in record.target ? record.target.targetObjectTypeId : null},
+          ${"queued"}, ${record.queuedAt}, ${null}, ${null}, ${0}, ${null},
+          ${checkpoint?.fixedBatchSize ?? null}, ${checkpoint?.nextBatchOrdinal ?? null},
+          ${checkpoint?.nextRowOffset ?? null}, ${checkpoint?.inputExhausted ?? null}, ${0}, ${0}
         )
         RETURNING *
       `
+      return rowToProjectionRunRecord(inserted)
+    })
+  }
+
+  async startOrReclaim(input: StartOrReclaimProjectionRunInput): Promise<ProjectionRunClaim> {
+    assertProjectionRunStartInput(input)
 
-      return projectionRunClaim(inserted)
+    return runPgTransaction(this.sql, async (tx) => {
+      await lockAdvisoryKeys(tx, [projectionRunLockKey(input.projectId, input.id)])
+      const [existingRow] = await tx<DatabaseRow[]>`
+        SELECT * FROM projection_runs
+        WHERE project_id = ${input.projectId} AND id = ${input.id}
+        FOR UPDATE
+      `
+      if (!existingRow) throw projectionRunNotFound(input.projectId, input.id)
+      const existing = restoreProjectionRunRow(existingRow)
+      const { attempt } = planProjectionRunReclaim(existing, input)
+      const executionToken = createFreshExecutionToken(existing.executionToken)
+      const [updated] = await tx<DatabaseRow[]>`
+        UPDATE projection_runs
+        SET status = ${"running"}, started_at = COALESCE(started_at, ${input.startedAt ?? new Date()}),
+          finished_at = ${null}, attempt = ${attempt}, execution_token = ${executionToken},
+          error = ${null}
+        WHERE project_id = ${input.projectId} AND id = ${input.id}
+          AND (
+            (status = ${"queued"} AND execution_token IS NULL)
+            OR (status = ${"running"} AND execution_token = ${existing.executionToken ?? null})
+          )
+        RETURNING *
+      `
+      if (!updated) throw staleProjectionRunExecution(input.id)
+      return projectionRunClaim(updated)
+    })
+  }
+
+  async failEnqueue(input: FailProjectionRunEnqueueInput): Promise<ProjectionRunRecord> {
+    return runPgTransaction(this.sql, async (tx) => {
+      const [existingRow] = await tx<DatabaseRow[]>`
+        SELECT * FROM projection_runs
+        WHERE project_id = ${input.projectId} AND id = ${input.id}
+        FOR UPDATE
+      `
+      if (!existingRow) throw projectionRunNotFound(input.projectId, input.id)
+      const failed = failProjectionRunEnqueue(restoreProjectionRunRow(existingRow), input)
+      if (!failed.error) {
+        throw new ProjectionRunError(`[SixbPg] Projection run '${input.id}' has no failure.`)
+      }
+      const [updated] = await tx<DatabaseRow[]>`
+        UPDATE projection_runs
+        SET status = ${"failed"}, finished_at = ${failed.finishedAt ?? new Date()},
+          error = ${serializeSixbFailure(failed.error, PROJECTION_RUN_FAILURE_CODES)}::text::jsonb
+        WHERE project_id = ${input.projectId} AND id = ${input.id} AND status = ${"queued"}
+        RETURNING *
+      `
+      if (!updated) throw duplicateProjectionRun(input)
+      return rowToProjectionRunRecord(updated)
     })
   }
 
@@ -200,7 +242,7 @@ export class PgProjectionRunStorage implements ProjectionRunStorage {
           source_rows_read = ${plan.progress.sourceRowsRead},
           source_rows_skipped = ${plan.progress.sourceRowsSkipped},
           input_exhausted = ${plan.inputExhausted ?? existingRow.input_exhausted},
-          error_message = ${plan.errorMessage ?? null}
+          error = ${plan.error === undefined ? null : serializeSixbFailure(plan.error, PROJECTION_RUN_FAILURE_CODES)}::text::jsonb
         WHERE project_id = ${input.projectId}
           AND id = ${input.id}
           AND status = ${"running"}
@@ -328,11 +370,11 @@ export class PgProjectionRunStorage implements ProjectionRunStorage {
       params.push(...input.statuses)
     }
     if (input.startedAfter) {
-      whereClauses.push(`started_at >= $${index++}`)
+      whereClauses.push(`COALESCE(started_at, queued_at) >= $${index++}`)
       params.push(input.startedAfter)
     }
     if (input.startedBefore) {
-      whereClauses.push(`started_at <= $${index++}`)
+      whereClauses.push(`COALESCE(started_at, queued_at) <= $${index++}`)
       params.push(input.startedBefore)
     }
 
@@ -351,7 +393,7 @@ export class PgProjectionRunStorage implements ProjectionRunStorage {
     let query = `
       SELECT * FROM projection_runs
       ${where}
-      ORDER BY started_at ${order}, id ${order}
+      ORDER BY COALESCE(started_at, queued_at) ${order}, id ${order}
     `
     if (input.limit !== undefined) {
       query += ` LIMIT $${index++} OFFSET $${index++}`
@@ -388,7 +430,7 @@ async function requireMaterializationExecution(
   input: LockProjectionRunForMaterializationInput
 ): Promise<DatabaseRow> {
   const row = await requireRunning(sql, input.projectId, input.id)
-  assertProjectionRunExecution(restoreProjectionRunRow(row), input)
+  assertProjectionRunAttempt(restoreProjectionRunRow(row), input)
   return row
 }
 
@@ -406,6 +448,22 @@ async function requireRunning(sql: SQLClient, projectId: string, id: string): Pr
   return row
 }
 
+async function assertDatasetVersionIsImmutable(
+  sql: SQLClient,
+  input: QueueProjectionRunInput
+): Promise<void> {
+  const [conflict] = await sql<{ readonly id: string }[]>`
+    SELECT id FROM projection_runs
+    WHERE project_id = ${input.projectId}
+      AND id <> ${input.id}
+      AND dataset_id = ${input.identity.datasetVersion.datasetId}
+      AND dataset_version_id = ${input.identity.datasetVersion.versionId}
+      AND dataset_version_created_at <> ${input.identity.datasetVersion.createdAt}
+    LIMIT 1
+  `
+  if (conflict) throw immutableDatasetVersionConflict(input.identity)
+}
+
 function createFreshExecutionToken(previous: string | undefined): string {
   let token = randomUUID()
   while (token === previous) token = randomUUID()
@@ -436,6 +494,7 @@ function restoreProjectionRunRow(row: DatabaseRow): StoredProjectionRunRecord {
   const persisted: PersistedProjectionRunRecord = {
     id: row.id,
     projectId: row.project_id,
+    executionId: row.execution_id,
     projectionId: row.projection_id,
     projectionKind: row.projection_kind,
     protocol: row.materialization_protocol ?? undefined,
@@ -449,7 +508,8 @@ function restoreProjectionRunRow(row: DatabaseRow): StoredProjectionRunRecord {
     sourceObjectTypeId: row.source_object_type_id ?? undefined,
     targetObjectTypeId: row.target_object_type_id ?? undefined,
     status: row.status,
-    startedAt: new Date(row.started_at),
+    queuedAt: new Date(row.queued_at),
+    startedAt: row.started_at ? new Date(row.started_at) : undefined,
     finishedAt: row.finished_at ? new Date(row.finished_at) : undefined,
     attempt: databaseSafeInteger(row.attempt, "attempt"),
     executionToken: row.execution_token ?? undefined,
@@ -470,7 +530,7 @@ function restoreProjectionRunRow(row: DatabaseRow): StoredProjectionRunRecord {
       sourceRowsRead: databaseSafeInteger(row.source_rows_read, "sourceRowsRead"),
       sourceRowsSkipped: databaseSafeInteger(row.source_rows_skipped, "sourceRowsSkipped"),
     },
-    errorMessage: row.error_message ?? undefined,
+    error: row.error ?? undefined,
   }
   return restoreProjectionRun(persisted)
 }
@@ -495,6 +555,7 @@ function databaseSafeInteger(value: number | string | null, fieldName: string):
 interface DatabaseRow {
   project_id: string
   id: string
+  execution_id: string
   projection_id: string
   projection_kind: ProjectionKind
   dataset_id: string
@@ -503,7 +564,8 @@ interface DatabaseRow {
   source_object_type_id: string | null
   target_object_type_id: string | null
   status: ProjectionRunStatus
-  started_at: Date | string
+  queued_at: Date | string
+  started_at: Date | string | null
   finished_at: Date | string | null
   attempt: number | string
   execution_token: string | null
@@ -522,5 +584,11 @@ interface DatabaseRow {
   missing_target_first_seen_at: Date | string | null
   source_rows_read: number | string
   source_rows_skipped: number | string
-  error_message: string | null
+  error: JsonValue | null
+}
+
+function duplicateProjectionRun(input: { readonly projectId: string; readonly id: string }) {
+  return new ProjectionRunError(
+    `[SixbPg] Projection run '${input.id}' already exists for project '${input.projectId}'.`
+  )
 }

package/src/pg-sync-run-storage.ts

@@ -1,16 +1,23 @@
 import type { JsonValue } from "@sixb/core"
+import { parseSixbFailure, serializeSixbFailure } from "@sixb/core/internal/errors"
+import { assertSyncRunExecution } from "@sixb/core/internal/sync-run-storage-provider"
 import type {
+  ExecutionStorage,
   FinishSyncRunInput,
   ListLatestSyncRunsInput,
   ListLatestSyncRunsResult,
   ListSyncRunsInput,
   ListSyncRunsResult,
+  QueueSyncRunInput,
   StartSyncRunInput,
-  SyncRunFailure,
   SyncRunRecord,
   SyncRunStorage,
 } from "@sixb/core/storage"
-import { SyncRunError } from "@sixb/core/storage"
+import {
+  canRequeueSyncRunAfterEnqueueFailure,
+  SYNC_RUN_FAILURE_CODES,
+  SyncRunError,
+} from "@sixb/core/storage"
 import { queryLatestRunsByOwnerId } from "./latest-run-query"
 import type { SqlParameter } from "./pg-client"
 import { appendRunListFilters, hasEmptyStatuses, queryRunList } from "./run-list-query"
@@ -18,29 +25,43 @@ import { isUniqueViolation } from "./storage-errors"
 import { type PgStoreClient, runPgTransaction } from "./transactions"
 
 export class PgSyncRunStorage implements SyncRunStorage {
-  constructor(private readonly sql: PgStoreClient) {}
+  constructor(
+    private readonly sql: PgStoreClient,
+    private readonly executions: ExecutionStorage
+  ) {}
 
-  async start(input: StartSyncRunInput): Promise<SyncRunRecord> {
+  async queue(input: QueueSyncRunInput): Promise<SyncRunRecord> {
+    await assertSyncRunExecution({
+      executions: this.executions,
+      projectId: input.projectId,
+      executionId: input.executionId,
+      runId: input.id,
+      syncId: input.syncId,
+    })
     try {
       const [row] = await this.sql<DatabaseRow[]>`
         INSERT INTO sync_runs (
           project_id,
           id,
+          execution_id,
           sync_id,
           dataset_id,
           mode,
           status,
+          queued_at,
           started_at,
           expected_latest_version_id,
           commit_message
         ) VALUES (
           ${input.projectId},
           ${input.id},
+          ${input.executionId},
           ${input.syncId},
           ${input.datasetId},
           ${input.mode},
-          ${"running"},
-          ${input.startedAt ?? new Date()},
+          ${"queued"},
+          ${input.queuedAt ?? new Date()},
+          ${null},
           ${input.expectedLatestVersionId ?? null},
           ${input.commitMessage ?? null}
         )
@@ -50,13 +71,57 @@ export class PgSyncRunStorage implements SyncRunStorage {
       return rowToSyncRunRecord(row)
     } catch (error) {
       if (isUniqueViolation(error)) {
+        return this.requeueAfterEnqueueFailure(input)
+      }
+
+      throw error
+    }
+  }
+
+  private async requeueAfterEnqueueFailure(input: QueueSyncRunInput): Promise<SyncRunRecord> {
+    return runPgTransaction(this.sql, async (tx) => {
+      const [existing] = await tx<DatabaseRow[]>`
+        SELECT *, checkpoint IS NOT NULL AS checkpoint_present FROM sync_runs
+        WHERE project_id = ${input.projectId} AND id = ${input.id}
+        FOR UPDATE
+      `
+      if (!existing || !canRequeueSyncRunAfterEnqueueFailure(rowToSyncRunRecord(existing), input)) {
         throw new SyncRunError(
           `[SixbPg] Sync run '${input.id}' already exists for project '${input.projectId}'.`
         )
       }
 
-      throw error
+      const [updated] = await tx<DatabaseRow[]>`
+        UPDATE sync_runs
+        SET status = ${"queued"}, queued_at = ${input.queuedAt ?? new Date()},
+            started_at = ${null}, finished_at = ${null}, rows_read = ${null},
+            output_version_id = ${null}, error = ${null}, checkpoint = ${null}
+        WHERE project_id = ${input.projectId} AND id = ${input.id}
+        RETURNING *, checkpoint IS NOT NULL AS checkpoint_present
+      `
+      return rowToSyncRunRecord(updated)
+    })
+  }
+
+  async start(input: StartSyncRunInput): Promise<SyncRunRecord> {
+    const [updated] = await this.sql<DatabaseRow[]>`
+      UPDATE sync_runs
+      SET status = ${"running"}, started_at = ${input.startedAt ?? new Date()},
+          error = ${null}
+      WHERE project_id = ${input.projectId} AND id = ${input.id} AND status = ${"queued"}
+      RETURNING *, checkpoint IS NOT NULL AS checkpoint_present
+    `
+    if (updated) return rowToSyncRunRecord(updated)
+
+    const existing = await this.getById({ projectId: input.projectId, id: input.id })
+    if (!existing) {
+      throw new SyncRunError(
+        `[SixbPg] Sync run '${input.id}' not found for project '${input.projectId}'.`
+      )
     }
+    throw new SyncRunError(
+      `[SixbPg] Sync run '${input.id}' cannot start from status '${existing.status}'.`
+    )
   }
 
   async finish(input: FinishSyncRunInput): Promise<SyncRunRecord> {
@@ -72,6 +137,17 @@ export class PgSyncRunStorage implements SyncRunStorage {
         )
       }
 
+      const enqueueFailure =
+        input.status === "failed" && input.error.code === "queue.enqueue_failed"
+      if (
+        (enqueueFailure && existing.status !== "queued") ||
+        (!enqueueFailure && existing.status !== "running")
+      ) {
+        throw new SyncRunError(
+          `[SixbPg] Sync run '${input.id}' cannot finish from status '${existing.status}'.`
+        )
+      }
+
       if (input.status === "succeeded") {
         if (input.output && input.output.datasetId !== existing.dataset_id) {
           throw new SyncRunError(
@@ -94,8 +170,7 @@ export class PgSyncRunStorage implements SyncRunStorage {
                 finished_at = ${input.finishedAt ?? new Date()},
                 rows_read = ${input.rowsRead},
                 output_version_id = ${input.output?.versionId ?? null},
-                error_name = ${null},
-                error_message = ${null},
+                error = ${null},
                 checkpoint = ${serializeCheckpoint(input.checkpoint)}::text::jsonb
               WHERE project_id = ${input.projectId} AND id = ${input.id}
               RETURNING *, checkpoint IS NOT NULL AS checkpoint_present
@@ -107,8 +182,7 @@ export class PgSyncRunStorage implements SyncRunStorage {
                 finished_at = ${input.finishedAt ?? new Date()},
                 rows_read = ${input.rowsRead ?? existing.rows_read ?? null},
                 output_version_id = ${null},
-                error_name = ${input.error?.name ?? null},
-                error_message = ${input.error?.message ?? null},
+                error = ${input.error === undefined ? null : serializeSixbFailure(input.error, SYNC_RUN_FAILURE_CODES)}::text::jsonb,
                 checkpoint = ${null}
               WHERE project_id = ${input.projectId} AND id = ${input.id}
               RETURNING *, checkpoint IS NOT NULL AS checkpoint_present
@@ -156,7 +230,13 @@ export class PgSyncRunStorage implements SyncRunStorage {
       params.push(input.datasetId)
     }
 
-    index = appendRunListFilters(whereClauses, params, index, input)
+    index = appendRunListFilters(
+      whereClauses,
+      params,
+      index,
+      input,
+      "COALESCE(started_at, queued_at)"
+    )
 
     const { rows, total, hasMore } = await queryRunList<DatabaseRow>({
       sql: this.sql,
@@ -198,26 +278,17 @@ function serializeCheckpoint(checkpoint: JsonValue | undefined): string | null {
   return checkpoint !== undefined ? JSON.stringify(checkpoint) : null
 }
 
-function toSyncRunFailure(row: DatabaseRow): SyncRunFailure | undefined {
-  if (!row.error_message) {
-    return undefined
-  }
-
-  return {
-    name: row.error_name ?? undefined,
-    message: row.error_message,
-  }
-}
-
 function rowToSyncRunRecord(row: DatabaseRow): SyncRunRecord {
   return {
     id: row.id,
     projectId: row.project_id,
+    executionId: row.execution_id,
     syncId: row.sync_id,
     datasetId: row.dataset_id,
     mode: row.mode,
     status: row.status,
-    startedAt: new Date(row.started_at),
+    queuedAt: new Date(row.queued_at),
+    startedAt: row.started_at ? new Date(row.started_at) : undefined,
     finishedAt: row.finished_at ? new Date(row.finished_at) : undefined,
     rowsRead: row.rows_read != null ? Number(row.rows_read) : undefined,
     output: row.output_version_id
@@ -228,7 +299,7 @@ function rowToSyncRunRecord(row: DatabaseRow): SyncRunRecord {
       : undefined,
     expectedLatestVersionId: row.expected_latest_version_id ?? undefined,
     commitMessage: row.commit_message ?? undefined,
-    error: toSyncRunFailure(row),
+    error: row.error === null ? undefined : parseSixbFailure(row.error, SYNC_RUN_FAILURE_CODES),
     checkpoint: hasCheckpoint(row) ? row.checkpoint : undefined,
   }
 }
@@ -246,18 +317,19 @@ function hasCheckpoint(row: DatabaseRow): boolean {
 interface DatabaseRow {
   project_id: string
   id: string
+  execution_id: string
   sync_id: string
   dataset_id: string
   mode: SyncRunRecord["mode"]
   status: SyncRunRecord["status"]
-  started_at: Date | string
+  queued_at: Date | string
+  started_at: Date | string | null
   finished_at: Date | string | null
   rows_read: number | string | null
   output_version_id: string | null
   expected_latest_version_id: string | null
   commit_message: string | null
-  error_name: string | null
-  error_message: string | null
+  error: JsonValue | null
   checkpoint: JsonValue | null
   checkpoint_present: boolean | number | string
 }