@sitecore-jss/sitecore-jss-nextjs 22.2.0-canary.61 → 22.2.0-canary.63

package/dist/cjs/middleware/index.js

@@ -1,8 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.MultisiteMiddleware = exports.PersonalizeMiddleware = exports.RedirectsMiddleware = exports.debug = void 0;
+exports.MultisiteMiddleware = exports.PersonalizeMiddleware = exports.RedirectsMiddleware = exports.MiddlewareBase = exports.debug = void 0;
 var sitecore_jss_1 = require("@sitecore-jss/sitecore-jss");
 Object.defineProperty(exports, "debug", { enumerable: true, get: function () { return sitecore_jss_1.debug; } });
+var middleware_1 = require("./middleware");
+Object.defineProperty(exports, "MiddlewareBase", { enumerable: true, get: function () { return middleware_1.MiddlewareBase; } });
 var redirects_middleware_1 = require("./redirects-middleware");
 Object.defineProperty(exports, "RedirectsMiddleware", { enumerable: true, get: function () { return redirects_middleware_1.RedirectsMiddleware; } });
 var personalize_middleware_1 = require("./personalize-middleware");

package/dist/cjs/middleware/redirects-middleware.js

@@ -15,6 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.RedirectsMiddleware = void 0;
 const sitecore_jss_1 = require("@sitecore-jss/sitecore-jss");
 const site_1 = require("@sitecore-jss/sitecore-jss/site");
+const utils_1 = require("@sitecore-jss/sitecore-jss/utils");
 const server_1 = require("next/server");
 const regex_parser_1 = __importDefault(require("regex-parser"));
 const middleware_1 = require("./middleware");
@@ -70,7 +71,7 @@ class RedirectsMiddleware extends middleware_1.MiddlewareBase {
                     url.href = existsRedirect.target;
                 }
                 else {
-                    const source = `${url.pathname.replace(/\/*$/gi, '')}${url.search}`;
+                    const source = `${url.pathname.replace(/\/*$/gi, '')}${existsRedirect.matchedQueryString}`;
                     const urlFirstPart = existsRedirect.target.split('/')[1];
                     if (this.locales.includes(urlFirstPart)) {
                         req.nextUrl.locale = urlFirstPart;
@@ -156,17 +157,52 @@ class RedirectsMiddleware extends middleware_1.MiddlewareBase {
             const modifyRedirects = structuredClone(redirects);
             return modifyRedirects.length
                 ? modifyRedirects.find((redirect) => {
+                    // Modify the redirect pattern to ignore the language prefix in the path
                     redirect.pattern = redirect.pattern.replace(RegExp(`^[^]?/${language}/`, 'gi'), '');
+                    // Prepare the redirect pattern as a regular expression, making it more flexible for matching URLs
                     redirect.pattern = `/^\/${redirect.pattern
-                        .replace(/^\/|\/$/g, '')
-                        .replace(/^\^\/|\/\$$/g, '')
-                        .replace(/^\^|\$$/g, '')
-                        .replace(/(?<!\\)\?/g, '\\?')
-                        .replace(/\$\/gi$/g, '')}[\/]?$/gi`;
+                        .replace(/^\/|\/$/g, '') // Removes leading and trailing slashes
+                        .replace(/^\^\/|\/\$$/g, '') // Removes unnecessary start (^) and end ($) anchors
+                        .replace(/^\^|\$$/g, '') // Further cleans up anchors
+                        .replace(/(?<!\\)\?/g, '\\?') // Escapes question marks in the pattern
+                        .replace(/\$\/gi$/g, '')}[\/]?$/i`; // Ensures the pattern allows an optional trailing slash
+                    /**
+                     * This line checks whether the current URL query string (and all its possible permutations)
+                     * matches the redirect pattern.
+                     *
+                     * Query parameters in URLs can come in different orders, but logically they represent the
+                     * same information (e.g., "key1=value1&key2=value2" is the same as "key2=value2&key1=value1").
+                     * To account for this, the method `isPermutedQueryMatch` generates all possible permutations
+                     * of the query parameters and checks if any of those permutations match the regex pattern for the redirect.
+                     *
+                     * NOTE: This fix is specifically implemented for Netlify, where query parameters are sometimes
+                     * automatically sorted, which can cause issues with matching redirects if the order of query
+                     * parameters is important. By checking every possible permutation, we ensure that redirects
+                     * work correctly on Netlify despite this behavior.
+                     *
+                     * It passes several pieces of information to the function:
+                     * 1. `pathname`: The normalized URL path without query parameters (e.g., '/about').
+                     * 2. `queryString`: The current query string from the URL, which will be permuted and matched (e.g., '?key1=value1&key2=value2').
+                     * 3. `pattern`: The regex pattern for the redirect that we are trying to match against the URL (e.g., '/about?key1=value1').
+                     * 4. `locale`: The locale part of the URL (if any), which helps support multilingual URLs.
+                     *
+                     * If one of the permutations of the query string matches the redirect pattern, the function
+                     * returns the matched query string, which is stored in `matchedQueryString`. If no match is found,
+                     * it returns `undefined`. The `matchedQueryString` is later used to indicate whether the query
+                     * string contributed to a successful redirect match.
+                     */
+                    const matchedQueryString = this.isPermutedQueryMatch({
+                        pathname: tragetURL,
+                        queryString: targetQS,
+                        pattern: redirect.pattern,
+                        locale: req.nextUrl.locale,
+                    });
+                    // Save the matched query string (if found) into the redirect object
+                    redirect.matchedQueryString = matchedQueryString || '';
+                    // Return the redirect if the URL path or any query string permutation matches the pattern
                     return (((0, regex_parser_1.default)(redirect.pattern).test(tragetURL) ||
-                        (0, regex_parser_1.default)(redirect.pattern).test(`${tragetURL.replace(/\/*$/gi, '')}${targetQS}`) ||
                         (0, regex_parser_1.default)(redirect.pattern).test(`/${req.nextUrl.locale}${tragetURL}`) ||
-                        (0, regex_parser_1.default)(redirect.pattern).test(`/${req.nextUrl.locale}${tragetURL}${targetQS}`)) &&
+                        matchedQueryString) &&
                         (redirect.locale
                             ? redirect.locale.toLowerCase() === req.nextUrl.locale.toLowerCase()
                             : true));
@@ -233,5 +269,24 @@ class RedirectsMiddleware extends middleware_1.MiddlewareBase {
         }
         return redirect;
     }
+    /**
+     * Checks if the current URL query matches the provided pattern, considering all permutations of query parameters.
+     * It constructs all possible query parameter permutations and tests them against the pattern.
+     * @param {Object} params - The parameters for the URL match.
+     * @param {string} params.pathname - The current URL pathname.
+     * @param {string} params.queryString - The current URL query string.
+     * @param {string} params.pattern - The regex pattern to test the constructed URLs against.
+     * @param {string} [params.locale] - The locale prefix to include in the URL if present.
+     * @returns {string | undefined} - return query string if any of the query permutations match the provided pattern, undefined otherwise.
+     */
+    isPermutedQueryMatch({ pathname, queryString, pattern, locale, }) {
+        const paramsArray = Array.from(new URLSearchParams(queryString).entries());
+        const listOfPermuted = (0, utils_1.getPermutations)(paramsArray).map((permutation) => '?' + permutation.map(([key, value]) => `${key}=${value}`).join('&'));
+        const normalizedPath = pathname.replace(/\/*$/gi, '');
+        return listOfPermuted.find((query) => [
+            (0, regex_parser_1.default)(pattern).test(`${normalizedPath}${query}`),
+            (0, regex_parser_1.default)(pattern).test(`/${locale}${normalizedPath}${query}`),
+        ].some(Boolean));
+    }
 }
 exports.RedirectsMiddleware = RedirectsMiddleware;

package/dist/esm/middleware/index.js

@@ -1,4 +1,5 @@
 export { debug } from '@sitecore-jss/sitecore-jss';
+export { MiddlewareBase } from './middleware';
 export { RedirectsMiddleware } from './redirects-middleware';
 export { PersonalizeMiddleware } from './personalize-middleware';
 export { MultisiteMiddleware } from './multisite-middleware';

package/dist/esm/middleware/redirects-middleware.js

@@ -9,6 +9,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 import { debug } from '@sitecore-jss/sitecore-jss';
 import { GraphQLRedirectsService, REDIRECT_TYPE_301, REDIRECT_TYPE_302, REDIRECT_TYPE_SERVER_TRANSFER, } from '@sitecore-jss/sitecore-jss/site';
+import { getPermutations } from '@sitecore-jss/sitecore-jss/utils';
 import { NextResponse } from 'next/server';
 import regexParser from 'regex-parser';
 import { MiddlewareBase } from './middleware';
@@ -64,7 +65,7 @@ export class RedirectsMiddleware extends MiddlewareBase {
                     url.href = existsRedirect.target;
                 }
                 else {
-                    const source = `${url.pathname.replace(/\/*$/gi, '')}${url.search}`;
+                    const source = `${url.pathname.replace(/\/*$/gi, '')}${existsRedirect.matchedQueryString}`;
                     const urlFirstPart = existsRedirect.target.split('/')[1];
                     if (this.locales.includes(urlFirstPart)) {
                         req.nextUrl.locale = urlFirstPart;
@@ -150,17 +151,52 @@ export class RedirectsMiddleware extends MiddlewareBase {
             const modifyRedirects = structuredClone(redirects);
             return modifyRedirects.length
                 ? modifyRedirects.find((redirect) => {
+                    // Modify the redirect pattern to ignore the language prefix in the path
                     redirect.pattern = redirect.pattern.replace(RegExp(`^[^]?/${language}/`, 'gi'), '');
+                    // Prepare the redirect pattern as a regular expression, making it more flexible for matching URLs
                     redirect.pattern = `/^\/${redirect.pattern
-                        .replace(/^\/|\/$/g, '')
-                        .replace(/^\^\/|\/\$$/g, '')
-                        .replace(/^\^|\$$/g, '')
-                        .replace(/(?<!\\)\?/g, '\\?')
-                        .replace(/\$\/gi$/g, '')}[\/]?$/gi`;
+                        .replace(/^\/|\/$/g, '') // Removes leading and trailing slashes
+                        .replace(/^\^\/|\/\$$/g, '') // Removes unnecessary start (^) and end ($) anchors
+                        .replace(/^\^|\$$/g, '') // Further cleans up anchors
+                        .replace(/(?<!\\)\?/g, '\\?') // Escapes question marks in the pattern
+                        .replace(/\$\/gi$/g, '')}[\/]?$/i`; // Ensures the pattern allows an optional trailing slash
+                    /**
+                     * This line checks whether the current URL query string (and all its possible permutations)
+                     * matches the redirect pattern.
+                     *
+                     * Query parameters in URLs can come in different orders, but logically they represent the
+                     * same information (e.g., "key1=value1&key2=value2" is the same as "key2=value2&key1=value1").
+                     * To account for this, the method `isPermutedQueryMatch` generates all possible permutations
+                     * of the query parameters and checks if any of those permutations match the regex pattern for the redirect.
+                     *
+                     * NOTE: This fix is specifically implemented for Netlify, where query parameters are sometimes
+                     * automatically sorted, which can cause issues with matching redirects if the order of query
+                     * parameters is important. By checking every possible permutation, we ensure that redirects
+                     * work correctly on Netlify despite this behavior.
+                     *
+                     * It passes several pieces of information to the function:
+                     * 1. `pathname`: The normalized URL path without query parameters (e.g., '/about').
+                     * 2. `queryString`: The current query string from the URL, which will be permuted and matched (e.g., '?key1=value1&key2=value2').
+                     * 3. `pattern`: The regex pattern for the redirect that we are trying to match against the URL (e.g., '/about?key1=value1').
+                     * 4. `locale`: The locale part of the URL (if any), which helps support multilingual URLs.
+                     *
+                     * If one of the permutations of the query string matches the redirect pattern, the function
+                     * returns the matched query string, which is stored in `matchedQueryString`. If no match is found,
+                     * it returns `undefined`. The `matchedQueryString` is later used to indicate whether the query
+                     * string contributed to a successful redirect match.
+                     */
+                    const matchedQueryString = this.isPermutedQueryMatch({
+                        pathname: tragetURL,
+                        queryString: targetQS,
+                        pattern: redirect.pattern,
+                        locale: req.nextUrl.locale,
+                    });
+                    // Save the matched query string (if found) into the redirect object
+                    redirect.matchedQueryString = matchedQueryString || '';
+                    // Return the redirect if the URL path or any query string permutation matches the pattern
                     return ((regexParser(redirect.pattern).test(tragetURL) ||
-                        regexParser(redirect.pattern).test(`${tragetURL.replace(/\/*$/gi, '')}${targetQS}`) ||
                         regexParser(redirect.pattern).test(`/${req.nextUrl.locale}${tragetURL}`) ||
-                        regexParser(redirect.pattern).test(`/${req.nextUrl.locale}${tragetURL}${targetQS}`)) &&
+                        matchedQueryString) &&
                         (redirect.locale
                             ? redirect.locale.toLowerCase() === req.nextUrl.locale.toLowerCase()
                             : true));
@@ -227,4 +263,23 @@ export class RedirectsMiddleware extends MiddlewareBase {
         }
         return redirect;
     }
+    /**
+     * Checks if the current URL query matches the provided pattern, considering all permutations of query parameters.
+     * It constructs all possible query parameter permutations and tests them against the pattern.
+     * @param {Object} params - The parameters for the URL match.
+     * @param {string} params.pathname - The current URL pathname.
+     * @param {string} params.queryString - The current URL query string.
+     * @param {string} params.pattern - The regex pattern to test the constructed URLs against.
+     * @param {string} [params.locale] - The locale prefix to include in the URL if present.
+     * @returns {string | undefined} - return query string if any of the query permutations match the provided pattern, undefined otherwise.
+     */
+    isPermutedQueryMatch({ pathname, queryString, pattern, locale, }) {
+        const paramsArray = Array.from(new URLSearchParams(queryString).entries());
+        const listOfPermuted = getPermutations(paramsArray).map((permutation) => '?' + permutation.map(([key, value]) => `${key}=${value}`).join('&'));
+        const normalizedPath = pathname.replace(/\/*$/gi, '');
+        return listOfPermuted.find((query) => [
+            regexParser(pattern).test(`${normalizedPath}${query}`),
+            regexParser(pattern).test(`/${locale}${normalizedPath}${query}`),
+        ].some(Boolean));
+    }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sitecore-jss/sitecore-jss-nextjs",
-  "version": "22.2.0-canary.61",
+  "version": "22.2.0-canary.63",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
   "sideEffects": false,
@@ -72,9 +72,9 @@
     "react-dom": "^18.2.0"
   },
   "dependencies": {
-    "@sitecore-jss/sitecore-jss": "^22.2.0-canary.61",
-    "@sitecore-jss/sitecore-jss-dev-tools": "^22.2.0-canary.61",
-    "@sitecore-jss/sitecore-jss-react": "^22.2.0-canary.61",
+    "@sitecore-jss/sitecore-jss": "^22.2.0-canary.63",
+    "@sitecore-jss/sitecore-jss-dev-tools": "^22.2.0-canary.63",
+    "@sitecore-jss/sitecore-jss-react": "^22.2.0-canary.63",
     "@vercel/kv": "^0.2.1",
     "prop-types": "^15.8.1",
     "regex-parser": "^2.2.11",
@@ -82,7 +82,7 @@
   },
   "description": "",
   "types": "types/index.d.ts",
-  "gitHead": "50eb0f665c2936d8c6262020bb57a8eea359f7b7",
+  "gitHead": "320dcbeb8398d1a7854fd93244f73fc6b9ee8f66",
   "files": [
     "dist",
     "types",

package/types/middleware/index.d.ts

@@ -1,4 +1,5 @@
 export { debug } from '@sitecore-jss/sitecore-jss';
+export { MiddlewareBase, MiddlewareBaseConfig } from './middleware';
 export { RedirectsMiddleware, RedirectsMiddlewareConfig } from './redirects-middleware';
 export { PersonalizeMiddleware, PersonalizeMiddlewareConfig } from './personalize-middleware';
 export { MultisiteMiddleware, MultisiteMiddlewareConfig } from './multisite-middleware';

package/types/middleware/redirects-middleware.d.ts

@@ -54,4 +54,15 @@ export declare class RedirectsMiddleware extends MiddlewareBase {
      * @returns {NextResponse<unknown>} The redirect response.
      */
     private createRedirectResponse;
+    /**
+     * Checks if the current URL query matches the provided pattern, considering all permutations of query parameters.
+     * It constructs all possible query parameter permutations and tests them against the pattern.
+     * @param {Object} params - The parameters for the URL match.
+     * @param {string} params.pathname - The current URL pathname.
+     * @param {string} params.queryString - The current URL query string.
+     * @param {string} params.pattern - The regex pattern to test the constructed URLs against.
+     * @param {string} [params.locale] - The locale prefix to include in the URL if present.
+     * @returns {string | undefined} - return query string if any of the query permutations match the provided pattern, undefined otherwise.
+     */
+    private isPermutedQueryMatch;
 }