@sitecore-feaas/clientside 0.6.3-alpha.15 → 0.6.3-alpha.17

package/src/dom/rendering.ts

@@ -96,9 +96,7 @@ export function setDOMAttribute(
   } else if (attribute == 'data-path-href') {
     target = element.querySelector('a') || element.closest('a')
   } else if (attribute == 'data-path-hidden') {
-    // console.log('hidden init value', value)
     value = !value ? true : null
-    // console.log('~~~ after:', value)
   } else if (attribute == 'data-path' || attribute == 'data-embed-html' || attribute == 'html') {
     prop = 'innerHTML'
   } else if (attribute == 'data-embed-src' && loadScript) {
@@ -134,15 +132,13 @@ export function setDOMAttribute(
     }
     return
   }
-  if (typeof value == 'boolean') {
+  if (typeof value == 'boolean' && prop !== 'hidden') {
     value = value ? '' : null
-    // console.log('turns it to empty?', value)
   }
 
   if (!target) return
 
   const usePlaceholder = prop == 'innerHTML' || prop == 'src'
-  // console.log('debug set dom', attribute, prop, value, usePlaceholder)
   if (usePlaceholder && (value == null || value === '')) {
     var placeholder = String(
       (element.getAttribute('data-path-placeholder') || target[prop as keyof HTMLElement]) ??
@@ -152,7 +148,6 @@ export function setDOMAttribute(
     if (prop == 'innerHTML') {
       target.innerHTML = placeholder
     } else if (placeholder) {
-      // console.log('set with empty value placeholder', attribute, prop, placeholder)
       target.setAttribute(prop, placeholder)
     } else {
       target.removeAttribute(prop)
@@ -181,12 +176,13 @@ export function setDOMAttribute(
     } else {
       if (target.getAttribute(prop) != value) {
         // console.log('set with value', attribute, prop, value)
-        if (prop === 'hidden') {
-          console.log('in here?...')
-          target[prop] = true
-        } else {
-          target.setAttribute(prop, value)
-        }
+        // if (prop === 'hidden') {
+        //   console.log('in here?...')
+        //   target[prop] = true
+        // } else {
+        //   target.setAttribute(prop, value)
+        // }
+        target.setAttribute(prop, value)
       }
     }
   } else {

package/types/dom/rendering.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"rendering.d.ts","sourceRoot":"","sources":["../../src/dom/rendering.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,WAAW,CAAA;AAElD,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,sBAAsB,CAAA;AAIvD,OAAO,EAAE,WAAW,EAAE,MAAM,gBAAgB,CAAA;AAG5C,MAAM,WAAW,mBAAmB;IAClC,eAAe,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,KAAK,MAAM,CAAA;IACtF,WAAW,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,UAAU,KAAK,GAAG,CAAA;IAC7D,YAAY,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,GAAG,CAAA;IAC1E,YAAY,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,GAAG,KAAK,OAAO,CAAA;IAC5D,QAAQ,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,UAAU,KAAK,IAAI,CAAA;CAC5D;AAED,MAAM,WAAW,gBAAgB;IAC/B,QAAQ,EAAE,MAAM,CAAA;CACjB;AAED,MAAM,MAAM,mBAAmB,CAAC,CAAC,GAAG,WAAW,IAAI,OAAO,CAAC,gBAAgB,CAAC,GAAG;IAC7E,IAAI,CAAC,EAAE,CAAC,CAAA;CACT,GAAG,CAAC,gBAAgB,GAAG,sBAAsB,CAAC,GAC7C,mBAAmB,CAAA;AAsDrB,wBAAgB,eAAe,CAC7B,OAAO,EAAE,WAAW,EACpB,SAAS,EAAE,MAAM,EACjB,KAAK,EAAE,GAAG,EACV,MAAM,CAAC,EAAE,mBAAmB,EAC5B,UAAU,UAAO,QA+GlB;AAID,wBAAgB,gBAAgB,CAC9B,KAAK,EAAE,WAAW,GAAG,gBAAgB,EACrC,UAAU,CAAC,EAAE,GAAG,EAChB,MAAM,CAAC,EAAE,mBAAmB,EAC5B,QAAQ,CAAC,EAAE,OAAO,EAClB,UAAU,UAAO,eAwDlB;AAMD,wBAAgB,gBAAgB,CAC9B,IAAI,EAAE,WAAW,EACjB,QAAQ,EAAE,MAAM,EAChB,IAAI,CAAC,EAAE,IAAI,EACX,MAAM,CAAC,EAAE,mBAAmB,EAC5B,UAAU,UAAO,eAelB;AAED,wBAAgB,iBAAiB,CAC/B,QAAQ,EAAE,MAAM,EAChB,IAAI,CAAC,EAAE,IAAI,EACX,MAAM,CAAC,EAAE,mBAAmB,EAC5B,OAAO,UAAQ,EACf,UAAU,UAAO,UAYlB"}
+{"version":3,"file":"rendering.d.ts","sourceRoot":"","sources":["../../src/dom/rendering.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,WAAW,CAAA;AAElD,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,sBAAsB,CAAA;AAIvD,OAAO,EAAE,WAAW,EAAE,MAAM,gBAAgB,CAAA;AAG5C,MAAM,WAAW,mBAAmB;IAClC,eAAe,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,KAAK,MAAM,CAAA;IACtF,WAAW,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,UAAU,KAAK,GAAG,CAAA;IAC7D,YAAY,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,GAAG,CAAA;IAC1E,YAAY,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,GAAG,KAAK,OAAO,CAAA;IAC5D,QAAQ,CAAC,EAAE,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,UAAU,KAAK,IAAI,CAAA;CAC5D;AAED,MAAM,WAAW,gBAAgB;IAC/B,QAAQ,EAAE,MAAM,CAAA;CACjB;AAED,MAAM,MAAM,mBAAmB,CAAC,CAAC,GAAG,WAAW,IAAI,OAAO,CAAC,gBAAgB,CAAC,GAAG;IAC7E,IAAI,CAAC,EAAE,CAAC,CAAA;CACT,GAAG,CAAC,gBAAgB,GAAG,sBAAsB,CAAC,GAC7C,mBAAmB,CAAA;AAsDrB,wBAAgB,eAAe,CAC7B,OAAO,EAAE,WAAW,EACpB,SAAS,EAAE,MAAM,EACjB,KAAK,EAAE,GAAG,EACV,MAAM,CAAC,EAAE,mBAAmB,EAC5B,UAAU,UAAO,QA2GlB;AAID,wBAAgB,gBAAgB,CAC9B,KAAK,EAAE,WAAW,GAAG,gBAAgB,EACrC,UAAU,CAAC,EAAE,GAAG,EAChB,MAAM,CAAC,EAAE,mBAAmB,EAC5B,QAAQ,CAAC,EAAE,OAAO,EAClB,UAAU,UAAO,eAwDlB;AAMD,wBAAgB,gBAAgB,CAC9B,IAAI,EAAE,WAAW,EACjB,QAAQ,EAAE,MAAM,EAChB,IAAI,CAAC,EAAE,IAAI,EACX,MAAM,CAAC,EAAE,mBAAmB,EAC5B,UAAU,UAAO,eAelB;AAED,wBAAgB,iBAAiB,CAC/B,QAAQ,EAAE,MAAM,EAChB,IAAI,CAAC,EAAE,IAAI,EACX,MAAM,CAAC,EAAE,mBAAmB,EAC5B,OAAO,UAAQ,EACf,UAAU,UAAO,UAYlB"}