@sis-cc/dotstatsuite-components 17.25.0 → 17.26.0

package/lib/rules2/src/parseAttributes.js

@@ -40,7 +40,7 @@ var parseAttributes = exports.parseAttributes = function parseAttributes(attribu
     }
     var seriesDimensions = R.pipe(R.pathOr([], ['relationship', 'dimensions']), R.filter(function (id) {
       var dimension = R.prop(id, indexedDimensions);
-      return !dimension.header;
+      return !dimension.header && R.length(dimension.values || []) > 1;
     }))(attr);
     if (R.length(seriesDimensions) > 0) {
       return (0, _extends3.default)({}, res, { series: true, relationship: seriesDimensions });

package/lib/rules2/src/table/getCells.js

@@ -61,7 +61,7 @@ var getCells = exports.getCells = function getCells(customAttributes, cellsAttri
     var attributesInCellsCombination = R.pipe(R.propOr([], 'cells'), R.pluck('concepts'), R.unnest)(combinations);
 
     var _customAttributes = R.over(R.lensProp('notes'), function (notes) {
-      return R.concat(notes || [], attributesInLayoutCombination);
+      return R.pipe(R.concat, R.uniq)(notes || [], attributesInLayoutCombination);
     })(customAttributes);
 
     return R.mapObjIndexed(function (obs) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sis-cc/dotstatsuite-components",
   "description": "Set components based on React.",
-  "version": "17.25.0",
+  "version": "17.26.0",
   "main": "lib/index.js",
   "author": "OECD",
   "license": "MIT",

package/src/rules2/src/parseAttributes.js

@@ -25,7 +25,7 @@ export const parseAttributes = (attributes, dimensions, customAttributes) => {
       R.pathOr([], ['relationship', 'dimensions']),
       R.filter(id => {
         const dimension = R.prop(id, indexedDimensions);
-        return !dimension.header;
+        return !dimension.header && R.length(dimension.values || []) > 1;
       }),
     )(attr);
     if (R.length(seriesDimensions) > 0) {

package/src/rules2/src/table/getCells.js

@@ -57,7 +57,7 @@ export const getCells = (customAttributes, cellsAttributesId, combinations, attr
 
   const _customAttributes = R.over(
     R.lensProp('notes'),
-    notes => R.concat(notes || [], attributesInLayoutCombination)
+    notes => R.pipe(R.concat, R.uniq)(notes || [], attributesInLayoutCombination)
   )(customAttributes);
 
   return R.mapObjIndexed(

package/test/getCells.test.js

@@ -78,4 +78,41 @@ describe('getCells tests', () => {
       }
     });
   });
+  it('duplication between notes and combinations definitions', () => {
+    const _customAttributes = {
+      flags: [],
+      notes: ['A1', 'A2']
+    };
+
+    const combinations = {
+      cells: [],
+      layout: [{ id: 'LAYOUT_COMB', concepts: ['D1', 'A1'] }]
+    };
+
+    const attributesSeries = { 'D1=V0': {} };
+
+    const cellsAttributesIds = ['A2'];
+
+    const observations = {
+      'obs': {
+        value: 'val',
+        formattedValue: 'val',
+        attributes: {
+          A1: { id: 'A1', value: { id: 'A1V' }, serieKey: 'D1=V0' },
+          A2: { id: 'A2', value: { id: 'A2V' } },
+        }
+      }
+    };
+    expect(getCells(_customAttributes, cellsAttributesIds, combinations, attributesSeries, [])(observations)).to.deep.equal({
+      'obs': {
+        value: 'val',
+        intValue: null,
+        sideProps: null,
+        flags: [
+          { id: 'A1', value: { id: 'A1V' } },
+          { id: 'A2', value: { id: 'A2V' } }
+        ]
+      }
+    });
+  });
 });

package/test/parseAttributes.test.js

@@ -7,6 +7,7 @@ const attributes = [
   { id: 'a9', relationship: { dimensions: ['d4'] }, values: [{ id: 'a9v1' }] }, // single 'many values' dimension relationship
   { id: 'a10', relationship: { dimensions: ['d1', 'd2'] }, values: [{ id: 'a10v1' }] }, // many 'single value' dimensions realtionship
   { id: 'a11', relationship: { dimensions: ['d1', 'd2', 'd4'] }, values: [{ id: 'a11v1' }] }, // one 'many values' and many 'single value' dimensions relationship
+  { id: 'a12', relationship: { dimensions: ['d4', 'd5', 'd7'] }, values: [{ id: 'a11v1' }] }, // exclude empty dimension from relationship
 ];
 
 const customAttributes = {};
@@ -18,6 +19,7 @@ const dimensions = [
   { id: 'd4', header: false, values: [{ id: 'v0' }, { id: 'v1' }] },
   { id: 'd5', header: false, values: [{ id: 'v0' }, { id: 'v1' }] },
   { id: 'd6', header: false, values: [{ id: 'v0' }, { id: 'v1' }] },
+  { id: 'd7', header: false, values: [] }
 ];
 
 describe('parseAttributes test', () => {
@@ -28,6 +30,7 @@ describe('parseAttributes test', () => {
       { id: 'a9', index: 2, relationship: ['d4'], series: true, values: [{ id: 'a9v1' }] },
       { id: 'a10', index: 3, relationship: ['d1', 'd2'], header: true, values: [{ id: 'a10v1' }] },
       { id: 'a11', index: 4, relationship: ['d4'], series: true, values: [{ id: 'a11v1' }] },
+      { id: 'a12', index: 5, relationship: ['d4', 'd5'], series: true, values: [{ id: 'a11v1' }] },
     ]);
   });
 });