@sinequa/atomic-angular 1.0.8 → 1.0.10

package/fesm2022/sinequa-atomic-angular.mjs

@@ -2809,19 +2809,45 @@ function withSavedSearchesFeatures() {
     })));
 }
 
+/**
+ * Canonical default shape of the user settings state.
+ *
+ * Shared between `initialize()` (overlaid under the fetched settings) and `reset()`
+ * (used as the replacement state) so the two cannot drift apart. Keep in sync with
+ * the `UserSettingsState` type.
+ */
+const USER_SETTINGS_DEFAULTS = {
+    bookmarks: [],
+    recentSearches: [],
+    savedSearches: [],
+    baskets: [],
+    alerts: [],
+    assistants: {},
+    language: undefined,
+    collapseAssistant: undefined,
+    userTheme: undefined,
+    agents: { isDebugMode: false }
+};
 function withUserSettingsFeatures() {
     return signalStoreFeature(withState({ language: undefined, collapseAssistant: undefined }), withMethods(store => ({
         /**
          * Initializes the user settings store by fetching the user settings from the backend API
          * and patching the store with the retrieved settings.
          *
+         * The fetched settings are overlaid on top of {@link USER_SETTINGS_DEFAULTS} so that any
+         * key absent from the new user's settings resets to its default instead of retaining the
+         * previous user's in-memory value. This is required because `initialize()` runs both on
+         * first login and on every user override (impersonation): a plain merge would leak the
+         * previous user's data (e.g. `recentSearches`) into the new user's session and backend.
+         *
          * @returns {Promise<void>} A promise that resolves when the initialization is complete.
          */
         async initialize() {
-            // Fetch the user settings from the backend API and patch the store with the result
+            // Fetch the user settings from the backend API and overlay them on the defaults,
+            // so missing keys reset rather than keep the previous user's values.
             try {
                 const settings = await fetchUserSettings();
-                patchState(store, settings);
+                patchState(store, { ...USER_SETTINGS_DEFAULTS, ...settings });
             }
             catch (err) {
                 error('Error fetching user settings:', err);
@@ -2839,17 +2865,7 @@ function withUserSettingsFeatures() {
         async reset() {
             // Reset the user settings to the initial state
             await deleteUserSettings();
-            patchState(store, {
-                bookmarks: [],
-                recentSearches: [],
-                savedSearches: [],
-                baskets: [],
-                alerts: [],
-                assistants: {},
-                language: undefined,
-                collapseAssistant: undefined,
-                agents: { isDebugMode: false }
-            });
+            patchState(store, USER_SETTINGS_DEFAULTS);
         }
     })));
 }
@@ -9882,6 +9898,8 @@ class AlertDialog {
         if (!this.alert)
             return;
         const q = this.alert.query;
+        // `q.filters` widened to `Filter[] | LegacyFilter[]` upstream, but the
+        // query-params store deliberately deals in `LegacyFilter[]` only.
         const filters = Array.isArray(q.filters) ? q.filters : undefined;
         this.queryParamsStore.patch({ text: q.text, tab: q.tab, basket: q.basket, sort: q.sort, filters, name: q.name });
         this.dialog()?.close();