@simplysm/sd-cli 14.0.63 → 14.0.65

package/tests/utils/typecheck-env.spec.ts

@@ -1,144 +1,118 @@
-import { describe, it, expect, vi, afterEach } from "vitest";
-
-// Mock fs for getTypesFromPackageJson
-const mockExistsSync = vi.fn<(path: string) => boolean>();
-const mockReadFileSync = vi.fn<(path: string, encoding: string) => string>();
-vi.mock("fs", () => {
-  const fsMock = {
-    existsSync: (path: string) => mockExistsSync(path),
-    readFileSync: (path: string, encoding: string) => mockReadFileSync(path, encoding),
-  };
-  return { ...fsMock, default: fsMock };
-});
-
-vi.mock("typescript", () => ({
-  default: {
-    readConfigFile: vi.fn(),
-    sys: { readFile: vi.fn() },
-    parseJsonConfigFileContent: vi.fn(),
-  },
-}));
+import { describe, it, expect, beforeAll, afterAll } from "vitest";
+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
 
-const {
+import {
   getTypesFromPackageJson,
   getCompilerOptionsForEnv,
   toTypecheckEnvs,
-} = await import("../../src/utils/tsconfig");
+} from "../../src/utils/tsconfig";
+
+let tmpRoot: string;
 
-afterEach(() => {
-  vi.clearAllMocks();
+beforeAll(() => {
+  tmpRoot = mkdtempSync(path.join(tmpdir(), "typecheck-env-"));
 });
 
-//#region Acceptance Tests — Slice 1 Scenarios
+afterAll(() => {
+  rmSync(tmpRoot, { recursive: true, force: true });
+});
+
+function makePkgDir(devDependencies?: Record<string, string>): string {
+  const dir = mkdtempSync(path.join(tmpRoot, "pkg-"));
+  if (devDependencies) {
+    writeFileSync(path.join(dir, "package.json"), JSON.stringify({ devDependencies }));
+  }
+  return dir;
+}
+
+function makePkgDirWithJson(json: object): string {
+  const dir = mkdtempSync(path.join(tmpRoot, "pkg-"));
+  writeFileSync(path.join(dir, "package.json"), JSON.stringify(json));
+  return dir;
+}
 
 describe("getCompilerOptionsForEnv", () => {
   // Scenario: node env에서 DOM 및 WebWorker lib 제거
   it("removes DOM and WebWorker libs in node env", () => {
-    mockExistsSync.mockReturnValue(false);
+    const pkgDir = makePkgDir(); // package.json 없음
     const base = { lib: ["lib.esnext.d.ts", "lib.dom.d.ts", "lib.dom.iterable.d.ts", "lib.webworker.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "node", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "node", pkgDir);
     expect(result.lib).toEqual(["lib.esnext.d.ts"]);
   });
 
   // Scenario: node env에서 사용자 커스텀 lib 보존
   it("preserves custom libs in node env", () => {
-    mockExistsSync.mockReturnValue(false);
+    const pkgDir = makePkgDir();
     const base = { lib: ["lib.esnext.d.ts", "lib.webworker.d.ts", "lib.scripthost.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "node", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "node", pkgDir);
     expect(result.lib).toEqual(["lib.esnext.d.ts", "lib.scripthost.d.ts"]);
   });
 
   // Scenario: browser env에서 lib 변화 없음
   it("does not modify lib in browser env", () => {
-    mockExistsSync.mockReturnValue(false);
+    const pkgDir = makePkgDir();
     const base = { lib: ["lib.esnext.d.ts", "lib.webworker.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "browser", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "browser", pkgDir);
     expect(result.lib).toEqual(["lib.esnext.d.ts", "lib.webworker.d.ts"]);
   });
 
   // Scenario: node env에서 types 변화 없음
   it("does not set types in node env", () => {
-    mockExistsSync.mockReturnValue(false);
+    const pkgDir = makePkgDir();
     const base = { lib: ["lib.esnext.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "node", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "node", pkgDir);
     expect(result.types).toBeUndefined();
   });
 
   // Scenario: browser env에서 @types/node 제거
   it("removes @types/node in browser env via devDeps", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(
-      JSON.stringify({ devDependencies: { "@types/node": "^20", "@types/ws": "^8" } }),
-    );
+    const pkgDir = makePkgDir({ "@types/node": "^20", "@types/ws": "^8" });
     const base = { lib: ["lib.esnext.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "browser", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "browser", pkgDir);
     expect(result.types).toEqual(["ws"]);
   });
 
   // Scenario: browser env에서 @types/node만 있는 경우
   it("returns empty types when only @types/node in browser env", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(
-      JSON.stringify({ devDependencies: { "@types/node": "^20" } }),
-    );
+    const pkgDir = makePkgDir({ "@types/node": "^20" });
     const base = { lib: ["lib.esnext.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "browser", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "browser", pkgDir);
     expect(result.types).toEqual([]);
   });
 
   // Scenario: browser env에서 @types가 없는 경우
   it("returns empty types when no @types in browser env", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(
-      JSON.stringify({ devDependencies: { vitest: "^1" } }),
-    );
+    const pkgDir = makePkgDir({ vitest: "^1" });
     const base = { lib: ["lib.esnext.d.ts"] };
-    const result = getCompilerOptionsForEnv(base, "browser", "/pkg");
+    const result = getCompilerOptionsForEnv(base, "browser", pkgDir);
     expect(result.types).toEqual([]);
   });
 });
 
-//#endregion
-
-//#region Unit Tests — getTypesFromPackageJson
-
 describe("getTypesFromPackageJson", () => {
   it("extracts @types packages from devDependencies", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(
-      JSON.stringify({
-        devDependencies: { "@types/node": "^20", "@types/ws": "^8", "vitest": "^1" },
-      }),
-    );
-    expect(getTypesFromPackageJson("/pkg")).toEqual(["node", "ws"]);
+    const pkgDir = makePkgDir({ "@types/node": "^20", "@types/ws": "^8", "vitest": "^1" });
+    expect(getTypesFromPackageJson(pkgDir)).toEqual(["node", "ws"]);
   });
 
   it("returns empty array when package.json does not exist", () => {
-    mockExistsSync.mockReturnValue(false);
-    expect(getTypesFromPackageJson("/nonexistent")).toEqual([]);
+    const pkgDir = mkdtempSync(path.join(tmpRoot, "pkg-empty-"));
+    expect(getTypesFromPackageJson(pkgDir)).toEqual([]);
   });
 
   it("returns empty array when no devDependencies", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(JSON.stringify({ name: "test" }));
-    expect(getTypesFromPackageJson("/pkg")).toEqual([]);
+    const pkgDir = makePkgDirWithJson({ name: "test" });
+    expect(getTypesFromPackageJson(pkgDir)).toEqual([]);
   });
 
   it("handles scoped @types packages", () => {
-    mockExistsSync.mockReturnValue(true);
-    mockReadFileSync.mockReturnValue(
-      JSON.stringify({
-        devDependencies: { "@types/ssh2-sftp-client": "^9" },
-      }),
-    );
-    expect(getTypesFromPackageJson("/pkg")).toEqual(["ssh2-sftp-client"]);
+    const pkgDir = makePkgDir({ "@types/ssh2-sftp-client": "^9" });
+    expect(getTypesFromPackageJson(pkgDir)).toEqual(["ssh2-sftp-client"]);
   });
 });
 
-//#endregion
-
-//#region Unit Tests — toTypecheckEnvs
-
 describe("toTypecheckEnvs", () => {
   it("returns ['node'] for node target", () => {
     expect(toTypecheckEnvs("node")).toEqual(["node"]);
@@ -164,5 +138,3 @@ describe("toTypecheckEnvs", () => {
     expect(toTypecheckEnvs(undefined)).toEqual(["node", "browser"]);
   });
 });
-
-//#endregion

package/tests/utils/typecheck-non-package.spec.ts

@@ -1,18 +1,9 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
 
-const mocks = vi.hoisted(() => ({
-  parseTsconfig: vi.fn(),
+// typescript default export는 ESM에서 spyOn 불가 (Cannot redefine property) — vi.mock 유지
+const tsMocks = vi.hoisted(() => ({
   createIncrementalCompilerHost: vi.fn(),
   createIncrementalProgram: vi.fn(),
-  serializeDiagnostic: vi.fn((d: any) => d),
-}));
-
-vi.mock("../../src/utils/tsconfig", () => ({
-  parseTsconfig: mocks.parseTsconfig,
-}));
-
-vi.mock("../../src/typecheck/typecheck-serialization", () => ({
-  serializeDiagnostic: mocks.serializeDiagnostic,
 }));
 
 vi.mock("typescript", async (importOriginal) => {
@@ -22,18 +13,34 @@ vi.mock("typescript", async (importOriginal) => {
     ...orig,
     default: {
       ...origDefault,
-      createIncrementalCompilerHost: mocks.createIncrementalCompilerHost,
-      createIncrementalProgram: mocks.createIncrementalProgram,
+      createIncrementalCompilerHost: tsMocks.createIncrementalCompilerHost,
+      createIncrementalProgram: tsMocks.createIncrementalProgram,
       DiagnosticCategory: { Error: 1, Warning: 0 },
     },
   };
 });
 
-const { typecheckNonPackageFiles } = await import("../../src/typecheck/typecheck-non-package");
+import * as tsconfigMod from "../../src/utils/tsconfig";
+import * as typecheckSerializationMod from "../../src/typecheck/typecheck-serialization";
+
+import { typecheckNonPackageFiles } from "../../src/typecheck/typecheck-non-package";
+
+const mocks = {
+  parseTsconfig: undefined as unknown as ReturnType<typeof vi.spyOn>,
+  createIncrementalCompilerHost: tsMocks.createIncrementalCompilerHost,
+  createIncrementalProgram: tsMocks.createIncrementalProgram,
+  serializeDiagnostic: undefined as unknown as ReturnType<typeof vi.spyOn>,
+};
 
 describe("typecheckNonPackageFiles", () => {
   beforeEach(() => {
-    vi.clearAllMocks();
+    vi.restoreAllMocks();
+
+    mocks.parseTsconfig = vi.spyOn(tsconfigMod, "parseTsconfig");
+    mocks.serializeDiagnostic = vi.spyOn(typecheckSerializationMod, "serializeDiagnostic")
+      .mockImplementation((d: any) => d);
+    mocks.createIncrementalCompilerHost.mockReset();
+    mocks.createIncrementalProgram.mockReset();
 
     mocks.parseTsconfig.mockReturnValue({
       fileNames: [
@@ -45,7 +52,7 @@ describe("typecheckNonPackageFiles", () => {
       errors: [],
     });
 
-    mocks.createIncrementalCompilerHost.mockReturnValue({});
+    mocks.createIncrementalCompilerHost.mockReturnValue({} as any);
 
     const mockProgram = {
       emit: vi.fn(() => ({ diagnostics: [] })),

package/tests/workers/build-watch-paths.acc.spec.ts

@@ -1,17 +1,11 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
+import * as collectDepsMod from "../../src/deps/replace-deps/collect-deps";
+import { buildWatchPaths } from "../../src/workers/build-watch-paths";
 
-// collectDeps는 파일 시스템에 의존하므로 모킹
-vi.mock("../../src/deps/replace-deps/collect-deps", () => ({
-  collectDeps: vi.fn(),
-}));
-
-const { collectDeps } = await import("../../src/deps/replace-deps/collect-deps");
-const { buildWatchPaths } = await import("../../src/workers/build-watch-paths");
-
-const mockCollectDeps = vi.mocked(collectDeps);
+const mockCollectDeps = vi.spyOn(collectDepsMod, "collectDeps");
 
 beforeEach(() => {
-  vi.restoreAllMocks();
+  mockCollectDeps.mockReset();
 });
 
 describe("buildWatchPaths", () => {

package/tests/workers/build-watch-paths.spec.ts

@@ -1,16 +1,11 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
+import * as collectDepsMod from "../../src/deps/replace-deps/collect-deps";
+import { buildWatchPaths } from "../../src/workers/build-watch-paths";
 
-vi.mock("../../src/deps/replace-deps/collect-deps", () => ({
-  collectDeps: vi.fn(),
-}));
-
-const { collectDeps } = await import("../../src/deps/replace-deps/collect-deps");
-const { buildWatchPaths } = await import("../../src/workers/build-watch-paths");
-
-const mockCollectDeps = vi.mocked(collectDeps);
+const mockCollectDeps = vi.spyOn(collectDepsMod, "collectDeps");
 
 beforeEach(() => {
-  vi.restoreAllMocks();
+  mockCollectDeps.mockReset();
 });
 
 describe("buildWatchPaths", () => {

package/tests/workers/client-worker.acc.spec.ts

@@ -1,105 +1,78 @@
-import { describe, it, expect, vi, beforeEach } from "vitest";
-
-//#region Mocks
+import { describe, it, expect, vi, beforeAll, afterAll, beforeEach } from "vitest";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
+
+import * as coreNode from "@simplysm/core-node";
+import * as sharedWorkerLifecycle from "../../src/workers/shared-worker-lifecycle";
+import * as esbuildClientConfig from "../../src/esbuild/esbuild-client-config";
+import * as esbuildIndexHtml from "../../src/esbuild/esbuild-index-html";
+import * as esbuildPwa from "../../src/esbuild/esbuild-pwa";
+import * as devHttpServer from "../../src/dev-server/dev-http-server";
+import * as hmrService from "../../src/dev-server/hmr-service";
+import * as hmrClientScript from "../../src/dev-server/hmr-client-script";
+import * as copyPublic from "../../src/utils/copy-public";
+import * as sdConfig from "../../src/utils/sd-config";
 
 let workerFns: Record<string, (...args: any[]) => any>;
 let mockSend: ReturnType<typeof vi.fn>;
 
 const mockRebuild = vi.fn();
 const mockDispose = vi.fn();
-const mockReadFileSync = vi.fn();
-const mockExistsSync = vi.fn();
-
-vi.mock("@simplysm/core-node", () => ({
-  createWorker: vi.fn((fns: Record<string, Function>) => {
-    workerFns = fns as any;
-    mockSend = vi.fn();
-    return { send: mockSend };
-  }),
-}));
-
-vi.mock("../../src/workers/shared-worker-lifecycle", () => ({
-  setupWorkerLifecycle: vi.fn(() => ({
-    logger: { debug: vi.fn(), error: vi.fn(), warn: vi.fn() },
-    guardStartWatch: vi.fn(),
-  })),
-}));
-
-vi.mock("../../src/esbuild/esbuild-client-config", () => ({
-  createClientEsbuildContext: vi.fn(() =>
-    Promise.resolve({
-      context: { rebuild: mockRebuild, dispose: mockDispose, watch: vi.fn() },
-      sourceFileCache: {},
-    }),
-  ),
-}));
-
-vi.mock("../../src/esbuild/esbuild-index-html", () => ({
-  generateIndexHtml: vi.fn(() =>
-    Promise.resolve({ content: "<html></html>", errors: [], warnings: [] }),
-  ),
-}));
-
-vi.mock("../../src/esbuild/esbuild-pwa", () => ({
-  applyPwa: vi.fn(() => Promise.resolve()),
-  createPwaHtmlTransform: vi.fn(),
-}));
-
-vi.mock("../../src/dev-server/dev-http-server", () => ({
-  createDevHttpServer: vi.fn(),
-}));
-
-vi.mock("../../src/dev-server/hmr-service", () => ({
-  createHmrService: vi.fn(),
-}));
-
-vi.mock("../../src/dev-server/hmr-client-script", () => ({
-  createHmrPostTransform: vi.fn(),
-}));
-
-vi.mock("../../src/utils/copy-public", () => ({
-  copyPublicFiles: vi.fn(() => Promise.resolve()),
-  watchPublicFiles: vi.fn(),
-}));
-
-vi.mock("../../src/utils/sd-config", () => ({
-  loadSdConfig: vi.fn(() =>
-    Promise.resolve({
-      packages: { "my-app": { target: "client", server: "my-server" } },
-    }),
-  ),
-}));
-
-vi.mock("node:fs", () => ({
-  default: {
-    readFileSync: (...args: any[]) => mockReadFileSync(...args),
-    writeFileSync: vi.fn(),
-    existsSync: (...args: any[]) => mockExistsSync(...args),
-    mkdirSync: vi.fn(),
-    rmSync: vi.fn(),
-  },
-}));
-
-//#endregion
-
-// Import triggers createWorker, capturing the functions
+
+vi.spyOn(coreNode, "createWorker").mockImplementation((fns: Record<string, Function>) => {
+  workerFns = fns as any;
+  mockSend = vi.fn();
+  return { send: mockSend } as any;
+});
+
+vi.spyOn(sharedWorkerLifecycle, "setupWorkerLifecycle").mockImplementation(() => ({
+  logger: { debug: vi.fn(), error: vi.fn(), warn: vi.fn() },
+  guardStartWatch: vi.fn(),
+}) as any);
+
+vi.spyOn(esbuildClientConfig, "createClientEsbuildContext").mockResolvedValue({
+  context: { rebuild: mockRebuild, dispose: mockDispose, watch: vi.fn() },
+  sourceFileCache: {},
+} as any);
+
+vi.spyOn(esbuildIndexHtml, "generateIndexHtml").mockResolvedValue({
+  content: "<html></html>", errors: [], warnings: [],
+});
+
+vi.spyOn(esbuildPwa, "applyPwa").mockResolvedValue(undefined);
+vi.spyOn(esbuildPwa, "createPwaHtmlTransform").mockReturnValue(undefined as any);
+
+vi.spyOn(devHttpServer, "createDevHttpServer").mockReturnValue(undefined as any);
+vi.spyOn(hmrService, "createHmrService").mockReturnValue(undefined as any);
+vi.spyOn(hmrClientScript, "createHmrPostTransform").mockReturnValue(undefined as any);
+
+vi.spyOn(copyPublic, "copyPublicFiles").mockResolvedValue(undefined);
+vi.spyOn(copyPublic, "watchPublicFiles").mockReturnValue(undefined as any);
+
+vi.spyOn(sdConfig, "loadSdConfig").mockResolvedValue({
+  packages: { "my-app": { target: "client", server: "my-server" } },
+} as any);
+
 await import("../../src/workers/client.worker");
 
-const baseBuildInfo = {
-  name: "my-app",
-  cwd: "/workspace",
-  pkgDir: "/workspace/packages/my-app",
-};
+let tmpRoot: string;
+let baseBuildInfo: { name: string; cwd: string; pkgDir: string };
+
+beforeAll(() => {
+  tmpRoot = mkdtempSync(path.join(tmpdir(), "client-worker-acc-"));
+  const pkgDir = path.join(tmpRoot, "packages", "my-app");
+  mkdirSync(pkgDir, { recursive: true });
+  writeFileSync(path.join(pkgDir, "package.json"), JSON.stringify({ name: "@scope/my-app" }));
+  baseBuildInfo = { name: "my-app", cwd: tmpRoot, pkgDir };
+});
+
+afterAll(() => {
+  rmSync(tmpRoot, { recursive: true, force: true });
+});
 
 beforeEach(() => {
   vi.clearAllMocks();
-  mockReadFileSync.mockImplementation((filePath: any) => {
-    if (String(filePath).endsWith("package.json")) {
-      return JSON.stringify({ name: "@scope/my-app" });
-    }
-    return "";
-  });
-  mockExistsSync.mockReturnValue(false);
   mockRebuild.mockResolvedValue({
     metafile: { outputs: {} },
     errors: [],
@@ -140,49 +113,3 @@ describe("client.worker build() — Acceptance", () => {
     expect(result.errors).toContain("Unexpected crash");
   });
 });
-
-describe("client.worker build() — browserSupport 전달", () => {
-  // Scenario: browserSupport가 ClientBuildInfo를 통해 전달된다
-  it("browserSupport 설정이 createClientEsbuildContext에 legacyModule/browserslist/postcssPlugins로 전달된다", async () => {
-    const { createClientEsbuildContext } = await import(
-      "../../src/esbuild/esbuild-client-config"
-    );
-
-    const result = await workerFns["build"]({
-      ...baseBuildInfo,
-      browserSupport: {
-        legacyModule: true,
-        browserslist: "Chrome 61",
-        postCss: { plugins: [["autoprefixer"]] },
-      },
-    });
-
-    expect(result.success).toBe(true);
-    expect(vi.mocked(createClientEsbuildContext)).toHaveBeenCalledWith(
-      expect.objectContaining({
-        legacyModule: true,
-        browserslist: "Chrome 61",
-        postcssPlugins: [["autoprefixer"]],
-      }),
-    );
-  });
-
-  // Scenario: browserSupport 미설정 시 기본값으로 동작한다
-  it("browserSupport 미설정 시 legacyModule=false, browserslist=undefined로 전달된다", async () => {
-    const { createClientEsbuildContext } = await import(
-      "../../src/esbuild/esbuild-client-config"
-    );
-
-    const result = await workerFns["build"](baseBuildInfo);
-
-    expect(result.success).toBe(true);
-    expect(vi.mocked(createClientEsbuildContext)).toHaveBeenCalledWith(
-      expect.objectContaining({
-        legacyModule: false,
-        browserslist: undefined,
-        postcssPlugins: undefined,
-      }),
-    );
-  });
-});
-