@simplysm/sd-cli 14.0.36 → 14.0.38

package/tests/angular/vite-angular-plugin.spec.ts

@@ -1,114 +1,95 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import path from "path";
-import type { SdConfig } from "../../src/sd-config.types";
 import {
   FIXTURE_DIR,
   PKG_DIR,
-  createTestSdConfig,
   initPlugin,
 } from "./_vite-angular-plugin-test-setup";
 
-const mockLoadSdConfig = vi.fn<(...args: unknown[]) => Promise<SdConfig>>();
-
-vi.mock("../../src/utils/sd-config", () => ({
-  loadSdConfig: (...args: unknown[]) => mockLoadSdConfig(...args),
-}));
-
 const { sdAngularPlugin } = await import("../../src/angular/vite-angular-plugin.js");
 
 beforeEach(() => {
   vi.clearAllMocks();
   vi.spyOn(process, "cwd").mockReturnValue(FIXTURE_DIR);
-  mockLoadSdConfig.mockResolvedValue(createTestSdConfig());
 });
 
 describe("sdAngularPlugin", () => {
-  // config() define 반환은 Vitest 축소로 제거됨 (esbuild-client-config에서 처리)
-
   // Scenario: non-Angular .ts 파일은 기본 처리
   it("returns undefined for non-emitted .ts files", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
     await initPlugin(plugin);
 
-    const result = await (plugin as any).transform?.call(
+    const result = (plugin as any).transform?.call(
       {},
       "export const x = 1;",
       "/some/unknown/file.ts",
     );
 
     expect(result).toBeUndefined();
-    await (plugin as any).buildEnd?.call({});
+    (plugin as any).buildEnd?.call({});
   });
 
   // Scenario: buildStart에서 초기화 및 emit + buildEnd에서 리소스 정리
   it("initializes facade in buildStart and disposes in buildEnd", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
     await initPlugin(plugin);
-    await (plugin as any).buildEnd?.call({});
+    (plugin as any).buildEnd?.call({});
   });
 
-  // handleHotUpdate, configureServer, optimizeDeps는 Vitest 축소로 제거됨
-  // Feature 3.3에서 esbuild 기반 테스트로 교체 예정
-
-  // Scenario: .mjs 파일이 JavaScriptTransformer를 통과한다
-  it("transforms .mjs files through JavaScriptTransformer", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
+  // Scenario: .mjs/.js 파일은 처리하지 않는다
+  it("returns undefined for .mjs files", async () => {
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
     await initPlugin(plugin);
 
-    const result = await (plugin as any).transform?.call(
+    const result = (plugin as any).transform?.call(
       {},
       "export const x = 1;",
       "/some/library/module.mjs",
     );
 
-    expect(result).toBeDefined();
-    expect(result.code).toBeDefined();
-    expect(typeof result.code).toBe("string");
-    await (plugin as any).buildEnd?.call({});
+    expect(result).toBeUndefined();
+    (plugin as any).buildEnd?.call({});
   });
 
-  // Scenario: .js 파일이 JavaScriptTransformer를 통과한다
-  it("transforms .js files through JavaScriptTransformer", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
+  it("returns undefined for .js files", async () => {
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
     await initPlugin(plugin);
 
-    const result = await (plugin as any).transform?.call(
+    const result = (plugin as any).transform?.call(
       {},
       "export const y = 2;",
       "/some/library/module.js",
     );
 
-    expect(result).toBeDefined();
-    expect(result.code).toBeDefined();
-    expect(typeof result.code).toBe("string");
-    await (plugin as any).buildEnd?.call({});
+    expect(result).toBeUndefined();
+    (plugin as any).buildEnd?.call({});
   });
 
   // Scenario: 비대상 파일(.css 등)은 transform하지 않는다
   it("returns undefined for non-JS files like .css", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
     await initPlugin(plugin);
 
-    const result = await (plugin as any).transform?.call(
+    const result = (plugin as any).transform?.call(
       {},
       "body { color: red; }",
       "/some/styles.css",
     );
 
     expect(result).toBeUndefined();
-    await (plugin as any).buildEnd?.call({});
+    (plugin as any).buildEnd?.call({});
   });
 
-  // Scenario: Angular .ts 파일 transform (prod 모드)
+  // Scenario: Angular .ts 파일 transform
   it("transforms emitted .ts files with compiled JS", async () => {
-    const plugin = sdAngularPlugin({ pkg: "basic-app"});
-    await initPlugin(plugin, { mode: "production", command: "build" });
+    const plugin = sdAngularPlugin({ pkg: "basic-app" });
+    await initPlugin(plugin);
 
     const appComponentPath = path
       .join(PKG_DIR, "src/app.component.ts")
       .replace(/\\/g, "/");
 
-    const result = await (plugin as any).transform?.call({}, "", appComponentPath);
+    const result = (plugin as any).transform?.call({}, "", appComponentPath);
 
     if (result != null) {
       expect(result).toHaveProperty("code");
@@ -116,23 +97,6 @@ describe("sdAngularPlugin", () => {
       expect(result.code.length).toBeGreaterThan(0);
     }
 
-    await (plugin as any).buildEnd?.call({});
-  });
-
-  // config() define 반환값은 Vitest 축소로 제거됨 (Feature 3.3에서 별도 테스트)
-
-  // Scenario: browserSupport 미설정 시 기본값 동작
-  it("works when browserSupport is not set in sd.config.ts", async () => {
-    mockLoadSdConfig.mockResolvedValue(createTestSdConfig());
-
-    const plugin = sdAngularPlugin({ pkg: "basic-app" });
-
-    await initPlugin(plugin);
-
-    const appComponentPath = PKG_DIR.replace(/\\/g, "/") + "/src/app.component.ts";
-    const result = await (plugin as any).transform?.call({}, "", appComponentPath);
-    expect(result).toBeDefined();
-
-    await (plugin as any).buildEnd?.call({});
+    (plugin as any).buildEnd?.call({});
   });
 });

package/tests/commands/typecheck.spec.ts

@@ -27,7 +27,7 @@ vi.mock("../../src/typecheck/typecheck-non-package", () => ({
   typecheckNonPackageFiles: mocks.typecheckNonPackageFiles,
 }));
 
-vi.mock("../../src/engines/index", () => ({
+vi.mock("../../src/engines/engine-factory", () => ({
   createTypecheckEngine: mocks.createTypecheckEngine,
 }));
 

package/tests/engines/base-engine.spec.ts

@@ -254,6 +254,31 @@ describe("BaseEngine", () => {
       await engine.stop();
     });
 
+    it("_callStartWatch 실패 시 에러를 ResultCollector에 보고하고 resolveInitialBuild를 호출한다", async () => {
+      const mockResultCollector = { add: vi.fn() };
+
+      mockWorker.startWatch.mockRejectedValue(new Error("Worker RPC failed"));
+
+      const engine = new TscEngine({
+        cwd: "/root",
+        pkg: createMockPkg(),
+        resultCollector: mockResultCollector as any,
+      });
+
+      // startWatch()가 hang하지 않고 resolve되어야 한다
+      await engine.startWatch({ js: true, dts: true });
+
+      // ResultCollector에 에러가 보고되어야 한다
+      const errorReport = mockResultCollector.add.mock.calls.find(
+        (c: any[]) => c[0].type === "build" && c[0].status === "error",
+      );
+      expect(errorReport).toBeDefined();
+      expect(errorReport![0].name).toBe("test-pkg");
+      expect(errorReport![0].message).toContain("Worker RPC failed");
+
+      await engine.stop();
+    });
+
     it("calls resolver on error event to release RebuildManager batch", async () => {
       const mockResolver = vi.fn();
       const mockRebuildManager = { registerBuild: vi.fn(() => mockResolver) };

package/tests/engines/engine-adapter-isolation.spec.ts

@@ -25,7 +25,7 @@ describe("EsbuildClientEngine adapter isolation", () => {
     }
   });
 
-  it("vite-angular-plugin.ts imports only JavaScriptTransformer from @angular/build/private", () => {
+  it("vite-angular-plugin.ts does not import @angular/* directly", () => {
 
     const pluginFile = path.resolve(
       import.meta.dirname,
@@ -33,8 +33,8 @@ describe("EsbuildClientEngine adapter isolation", () => {
     );
     const content = fs.readFileSync(pluginFile, "utf-8");
 
-    expect(content).toContain("@angular/build/private");
-    expect(content).toContain("JavaScriptTransformer");
+    const angularImportPattern = /from\s+["']@angular\/(build|compiler-cli)/;
+    expect(angularImportPattern.test(content)).toBe(false);
     expect(content).not.toContain("createAngularCompilation");
     expect(content).not.toMatch(/\bSourceFileCache\b(?<!AngularSourceFileCache)/);
     expect(content).not.toContain("ComponentStylesheetBundler");

package/tests/engines/esbuild-client-engine.acc.spec.ts

@@ -134,6 +134,35 @@ describe("EsbuildClientEngine Acceptance", () => {
     await engine.stop();
   });
 
+  // Scenario: 초기 빌드 실패 시 ResultCollector에 에러 보고
+  it("초기 빌드 실패 시 ResultCollector에 에러가 보고된다", async () => {
+    // Given: client 패키지가 정의되어 있다
+    const mockResultCollector = { add: vi.fn() };
+
+    mockWorker.startWatch.mockResolvedValue({
+      success: false,
+      errors: ["esbuild compilation failed"],
+    });
+
+    const engine = new EsbuildClientEngine({
+      cwd: "/root",
+      pkg: createMockPkg(),
+      resultCollector: mockResultCollector as any,
+    });
+
+    // When: startWatch()를 호출한다
+    await engine.startWatch({ js: true, dts: false });
+
+    // Then: ResultCollector에 에러가 보고된다
+    const errorReport = mockResultCollector.add.mock.calls.find(
+      (c: any[]) => c[0].type === "build" && c[0].status === "error",
+    );
+    expect(errorReport).toBeDefined();
+    expect(errorReport![0].name).toBe("my-client");
+
+    await engine.stop();
+  });
+
   // Scenario: 엔진 중지
   it("stop()으로 worker를 종료하고 .dev-port를 삭제한다", async () => {
     // Given: dev watch 모드가 실행 중이다

package/tests/engines/esbuild-client-engine.spec.ts

@@ -271,6 +271,32 @@ describe("EsbuildClientEngine", () => {
       await engine.stop();
     });
 
+    it("초기 빌드 실패 시 에러를 logger.error로 출력한다", async () => {
+      mockWorker.startWatch.mockResolvedValue({
+        success: false,
+        errors: ["Module not found: @angular/core", "Syntax error in app.ts"],
+      });
+
+      const engine = new EsbuildClientEngine({ cwd: "/root", pkg: createMockPkg() });
+      await engine.startWatch({ js: true, dts: false });
+
+      // startWatch가 reject하지 않고 정상 완료되는지 확인 (기존 동작 유지)
+      // 에러 로깅은 verify.md에서 검증
+      expect(mockWorker.startWatch).toHaveBeenCalled();
+
+      await engine.stop();
+    });
+
+    it("초기 빌드 성공 시 에러 로깅을 하지 않는다", async () => {
+      mockWorker.startWatch.mockResolvedValue({ success: true });
+
+      const engine = new EsbuildClientEngine({ cwd: "/root", pkg: createMockPkg() });
+      // 예외 없이 완료
+      await expect(engine.startWatch({ js: true, dts: false })).resolves.toBeUndefined();
+
+      await engine.stop();
+    });
+
     it("scopeRebuild 이벤트를 구독하지 않는다", async () => {
       mockWorker.startWatch.mockResolvedValue({ success: true });
 

package/tests/orchestrators/build-orchestrator.spec.ts

@@ -59,7 +59,7 @@ const mockEngines: Array<{
   stop: ReturnType<typeof vi.fn>;
 }> = [];
 
-vi.mock("../../src/engines/index", () => ({
+vi.mock("../../src/engines/engine-factory", () => ({
   createBuildEngine: vi.fn(() => {
     const engine = {
       run: vi.fn().mockResolvedValue({

package/tests/orchestrators/dev-orchestrator.spec.ts

@@ -40,7 +40,7 @@ const mockBuildEngines: Array<{
   port?: number;
 }> = [];
 
-vi.mock("../../src/engines/index", () => ({
+vi.mock("../../src/engines/engine-factory", () => ({
   createBuildEngine: vi.fn((pkg: any, options: any) => {
     const engine = {
       run: vi.fn().mockResolvedValue({

package/tests/orchestrators/typecheck-orchestrator.spec.ts

@@ -28,7 +28,7 @@ vi.mock("../../src/typecheck/typecheck-non-package", () => ({
   typecheckNonPackageFiles: mocks.typecheckNonPackageFiles,
 }));
 
-vi.mock("../../src/engines/index", () => ({
+vi.mock("../../src/engines/engine-factory", () => ({
   createTypecheckEngine: mocks.createTypecheckEngine,
 }));
 

package/tests/orchestrators/watch-orchestrator.spec.ts

@@ -45,7 +45,7 @@ const mockBuildEngines: Array<{
   _pkgName: string;
 }> = [];
 
-vi.mock("../../src/engines/index", () => ({
+vi.mock("../../src/engines/engine-factory", () => ({
   createBuildEngine: vi.fn((pkg: any, options: any) => {
     const engine = {
       run: vi.fn().mockResolvedValue({

package/tests/utils/esbuild-client-config.acc.spec.ts

@@ -108,7 +108,7 @@ describe("createClientEsbuildContext — Acceptance", () => {
     expect(pluginOpts.incremental).toBe(true);
     expect(pluginOpts.sourceFileCache).toBe(mockSourceFileCache);
     expect(pluginOpts.loadResultCache).toBe(mockSourceFileCache.loadResultCache);
-    expect((pluginOpts as any).browserOnlyBuild).toBe(true);
+    expect(pluginOpts.includeTestMetadata).toBe(true);
 
     // BundleStylesheetOptions
     expect(styleOpts.workspaceRoot).toBe("/workspace");
@@ -161,6 +161,9 @@ describe("createClientEsbuildContext — Acceptance", () => {
     expect(pluginOpts.sourcemap).toBe(false);
     expect(pluginOpts.advancedOptimizations).toBe(true);
     expect(pluginOpts.thirdPartySourcemaps).toBe(false);
+    expect(pluginOpts.incremental).toBe(false);
+    expect(pluginOpts.includeTestMetadata).toBe(false);
+    expect((pluginOpts as unknown as Record<string, unknown>)["browserOnlyBuild"]).toBeUndefined();
 
     // BundleStylesheetOptions
     expect(styleOpts.optimization).toBe(true);

package/tests/utils/hmr-service-dispatcher.acc.spec.ts

@@ -155,6 +155,76 @@ describe("HMR 디스패처 통합", () => {
     });
   });
 
+  describe("Scenario: 파일 크기 동일하지만 내용 변경 → 변경 감지", () => {
+    it("CSS 내용이 변경되었지만 크기가 동일한 경우 css-update를 전송한다", async () => {
+      // 임시 dist 디렉토리에 CSS 파일 생성
+      const distDir = path.join(tmpDir, "dist-hash-test");
+      fs.mkdirSync(distDir, { recursive: true });
+      fs.writeFileSync(path.join(distDir, "main.css"), "body { color: red; }");
+      fs.writeFileSync(path.join(distDir, "main.js"), "console.log('hello');");
+
+      // outDir을 전달하는 HMR 서비스 생성
+      hmrService.close();
+      await new Promise<void>((resolve, reject) => {
+        httpServer.close((err) => {
+          if (err != null) reject(err);
+          else resolve();
+        });
+      });
+
+      httpServer = http.createServer((_req, res) => { res.writeHead(404); res.end(); });
+      hmrService = createHmrService({
+        httpServer,
+        basePath: "/app/",
+        templateUpdates,
+        outDir: distDir,
+      });
+      port = await new Promise<number>((resolve, reject) => {
+        httpServer.listen(0, "127.0.0.1", () => {
+          const addr = httpServer.address();
+          if (typeof addr === "object" && addr != null) resolve(addr.port);
+          else reject(new Error("포트 감지 실패"));
+        });
+        httpServer.on("error", reject);
+      });
+
+      const cssContent = "body { color: red; }";
+      const metafile1: esbuild.Metafile = {
+        inputs: {},
+        outputs: {
+          "main.js": { bytes: 22, inputs: {}, imports: [], exports: [] },
+          "main.css": { bytes: cssContent.length, inputs: {}, imports: [], exports: [] },
+        },
+      };
+
+      // 첫 빌드 (baseline)
+      hmrService.onBuildEnd(metafile1);
+      await new Promise((r) => setTimeout(r, 150));
+
+      // CSS 내용 변경 (같은 크기)
+      const newCssContent = "body { color: blu; }"; // 같은 길이
+      fs.writeFileSync(path.join(distDir, "main.css"), newCssContent);
+
+      const ws = await connectWs();
+      const msgPromise = waitForMessage(ws);
+
+      const metafile2: esbuild.Metafile = {
+        inputs: {},
+        outputs: {
+          "main.js": { bytes: 22, inputs: {}, imports: [], exports: [] },
+          "main.css": { bytes: newCssContent.length, inputs: {}, imports: [], exports: [] },
+        },
+      };
+      hmrService.onBuildEnd(metafile2);
+
+      const msg = await msgPromise;
+      expect(msg["type"]).toBe("css-update");
+
+      ws.close();
+      fs.rmSync(distDir, { recursive: true, force: true });
+    });
+  });
+
   describe("Scenario: CSS-only 변경 → css-update 메시지", () => {
     it("JS 출력은 동일하고 CSS만 변경되면 css-update를 전송한다", async () => {
       // 초기 빌드

package/tests/workers/client-worker-initial-build-error.verify.md

@@ -0,0 +1,8 @@
+# 초기 빌드 에러 보고 — LLM 검증
+
+## 검증 항목
+
+- [x] client.worker.ts onEnd에서 초기 빌드 시 errors 필드가 포함되는지: `client.worker.ts:285-291` — `initialBuildResolve`에 `errors: result.errors.map((e) => e.text)` 포함 확인
+- [x] EsbuildClientEngine.startWatch에서 반환값의 success 확인 후 에러 로깅하는지: `EsbuildClientEngine.ts:135-137` — `result != null && !result.success` 조건으로 `logger.error` 호출 확인. 테스트 실행 시 `[my-client] 초기 빌드 실패: Module not found: @angular/core; Syntax error in app.ts` 출력 확인
+- [x] esbuild-client-config.ts에서 dev 모드 logLevel이 "warning"인지: `esbuild-client-config.ts:169` — `logLevel: isDev ? "warning" : "silent"` 확인. `isDev = options.mode === "dev"` (line 52)
+- [x] esbuild-client-config.ts에서 build 모드 logLevel이 "silent"인지: 동일 라인 — 삼항 연산자의 false 분기가 `"silent"` 확인