@simplysm/sd-cli 14.0.19 → 14.0.21

package/tests/orchestrators/typecheck-orchestrator.spec.ts

@@ -0,0 +1,180 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+
+//#region Mocks
+
+const mocks = vi.hoisted(() => ({
+  loadSdConfig: vi.fn(),
+  deserializeDiagnostic: vi.fn((d: any) => d),
+  typecheckNonPackageFiles: vi.fn(),
+  createBuildEngine: vi.fn(),
+  discoverWorkspacePackages: vi.fn(),
+  mergeTestsPackagesIntoConfig: vi.fn(),
+}));
+
+const mockEngines: Array<{
+  run: ReturnType<typeof vi.fn>;
+  stop: ReturnType<typeof vi.fn>;
+}> = [];
+
+vi.mock("../../src/utils/sd-config", () => ({
+  loadSdConfig: mocks.loadSdConfig,
+}));
+
+vi.mock("../../src/utils/typecheck-serialization", () => ({
+  deserializeDiagnostic: mocks.deserializeDiagnostic,
+}));
+
+vi.mock("../../src/utils/typecheck-non-package", () => ({
+  typecheckNonPackageFiles: mocks.typecheckNonPackageFiles,
+}));
+
+vi.mock("../../src/engines/index", () => ({
+  createBuildEngine: mocks.createBuildEngine,
+}));
+
+vi.mock("../../src/utils/package-utils", async (importOriginal) => {
+  const actual = await importOriginal<typeof import("../../src/utils/package-utils")>();
+  return {
+    ...actual,
+    discoverWorkspacePackages: mocks.discoverWorkspacePackages,
+    mergeTestsPackagesIntoConfig: mocks.mergeTestsPackagesIntoConfig,
+  };
+});
+
+vi.mock("typescript", async (importOriginal) => {
+  const orig = await importOriginal<Record<string, unknown>>();
+  const origDefault = (orig["default"] ?? orig) as Record<string, unknown>;
+  return {
+    ...orig,
+    default: {
+      ...origDefault,
+      sortAndDeduplicateDiagnostics: vi.fn((d: unknown[]) => d),
+      formatDiagnosticsWithColorAndContext: vi.fn((diags: Array<{ messageText: string }>) =>
+        diags.map((d) => `formatted: ${d.messageText}`).join("\n"),
+      ),
+    },
+  };
+});
+
+vi.mock("consola", () => {
+  const fns = (): Record<string, unknown> => ({
+    debug: vi.fn(), start: vi.fn(), success: vi.fn(),
+    info: vi.fn(), error: vi.fn(), warn: vi.fn(), log: vi.fn(),
+    withTag: vi.fn(() => fns()),
+    level: 0,
+  });
+  const c = fns();
+  return { consola: c, default: c, LogLevels: {} };
+});
+
+const { TypecheckOrchestrator } = await import(
+  "../../src/orchestrators/TypecheckOrchestrator"
+);
+
+//#endregion
+
+//#region Helpers
+
+function createMockEngine() {
+  const engine = {
+    run: vi.fn().mockResolvedValue({
+      build: { success: true, errors: [], warnings: [], diagnostics: [] },
+    }),
+    startWatch: vi.fn(),
+    stop: vi.fn().mockResolvedValue(undefined),
+  };
+  mockEngines.push(engine);
+  return engine;
+}
+
+function setupDefaults(packages: Record<string, any> = {}) {
+  mocks.loadSdConfig.mockResolvedValue({ packages });
+  mocks.createBuildEngine.mockImplementation(() => createMockEngine() as any);
+  mocks.typecheckNonPackageFiles.mockReturnValue({
+    success: true, errorCount: 0, warningCount: 0, diagnostics: [],
+  });
+
+  mocks.discoverWorkspacePackages.mockReturnValue(new Map<string, string>());
+  const pathMap = new Map<string, string>();
+  for (const name of Object.keys(packages)) {
+    pathMap.set(name, `packages/${name}`);
+  }
+  mocks.mergeTestsPackagesIntoConfig.mockReturnValue({
+    merged: packages,
+    pathMap,
+  });
+}
+
+//#endregion
+
+//#region Tests
+
+beforeEach(() => {
+  vi.clearAllMocks();
+  mockEngines.length = 0;
+});
+
+describe("TypecheckOrchestrator", () => {
+  // Acceptance: Scenario "TypecheckOrchestrator 정상 실행"
+  it("produces correct TypecheckResult through init → start → shutdown lifecycle", async () => {
+    setupDefaults({
+      "core-common": { target: "neutral" },
+      "core-node": { target: "node" },
+    });
+
+    const orchestrator = new TypecheckOrchestrator({ targets: [], options: [] });
+    await orchestrator.initialize();
+    const result = await orchestrator.start();
+    await orchestrator.shutdown();
+
+    expect(result.success).toBe(true);
+    expect(result.errorCount).toBe(0);
+    expect(result.warningCount).toBe(0);
+    // neutral → 2 tasks (node + browser), node → 1 task = 3 engines
+    expect(mocks.createBuildEngine).toHaveBeenCalledTimes(3);
+    for (const engine of mockEngines) {
+      expect(engine.run).toHaveBeenCalledWith(
+        expect.objectContaining({ js: false, dts: false }),
+      );
+    }
+  });
+
+  // Acceptance: Scenario "엔진 성공 시 리소스 정리"
+  it("calls engine.stop() after successful run", async () => {
+    setupDefaults({ "core-node": { target: "node" } });
+
+    const orchestrator = new TypecheckOrchestrator({ targets: [], options: [] });
+    await orchestrator.initialize();
+    await orchestrator.start();
+    await orchestrator.shutdown();
+
+    expect(mockEngines[0].stop).toHaveBeenCalled();
+  });
+
+  // Acceptance: Scenario "엔진 실패 시 리소스 정리"
+  it("calls engine.stop() even when run fails", async () => {
+    setupDefaults({ "core-node": { target: "node" } });
+    mocks.createBuildEngine.mockImplementation(() => {
+      const engine = {
+        run: vi.fn().mockRejectedValue(new Error("build error")),
+        startWatch: vi.fn(),
+        stop: vi.fn().mockResolvedValue(undefined),
+      };
+      mockEngines.push(engine);
+      return engine as any;
+    });
+
+    const orchestrator = new TypecheckOrchestrator({ targets: [], options: [] });
+    await orchestrator.initialize();
+    const result = await orchestrator.start();
+    await orchestrator.shutdown();
+
+    expect(result.success).toBe(false);
+    expect(mockEngines[0].stop).toHaveBeenCalled();
+  });
+});
+
+// executeTypecheck 편의 함수 테스트는 tests/commands/typecheck.spec.ts에서
+// 동일한 코드 경로를 통해 검증되므로 중복 삭제함
+
+//#endregion

package/tests/sd-cli-catch-all.verify.md

@@ -0,0 +1,7 @@
+# replaceDeps catch-all 에러 필터링 -- LLM 검증
+
+## 검증 항목
+
+- [x] catch 블록이 에러 코드를 확인하여 MODULE_NOT_FOUND/ERR_MODULE_NOT_FOUND만 무시: `sd-cli.ts:37-41` 확인 완료. `code` 프로퍼티를 체크하고 해당 코드가 아닌 경우 `console.warn`으로 경고 출력
+- [x] 예상 외 에러(SyntaxError 등)에 경고 로그 출력: `console.warn("[sd-cli] replaceDeps 사전 설정 실패:", ...)` 확인
+- [x] Phase 2로 정상 진행: catch 후 코드 흐름이 Phase 2(line 44~)로 계속됨 확인

package/tests/utils/lint-core-import-paths.verify.md

@@ -0,0 +1,10 @@
+# lint.worker/lint-utils/check.ts import 경로 검증 -- LLM 검증
+
+## 검증 항목
+
+- [x] lint.worker.ts가 `../utils/lint-core`에서 import: `import { executeLint, type LintOptions, type LintResult } from "../utils/lint-core";` (line 2) 확인
+- [x] lint-utils.ts가 `./lint-core`에서 import: `import type { LintOptions, LintResult } from "./lint-core";` (line 2) 확인
+- [x] check.ts가 `../utils/lint-core`에서 import: `import { executeLint, type LintResult } from "../utils/lint-core";` (line 4) 확인
+- [x] commands/lint.ts�� `../commands/lint` import가 없음: `import { executeLint, type LintOptions } from "../utils/lint-core";` (line 1)만 존재
+- [x] lint-core.ts에 runLint가 없음: `executeLint`, `loadIgnorePatterns`, `LintOptions`, `LintResult`만 export
+- [x] commands/lint.ts에 runLint만 존재: 13줄의 thin wrapper

package/tests/utils/lint-core.spec.ts

@@ -0,0 +1,188 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+
+// Hoisted mock references — available inside vi.mock factories
+const mocks = vi.hoisted(() => ({
+  fsxExists: vi.fn<(path: string) => Promise<boolean>>(),
+  fsxGlob: vi.fn<(...args: unknown[]) => Promise<string[]>>(),
+  filterByTargets: vi.fn(
+    (files: string[], _targets: string[], _cwd: string) => files,
+  ),
+  lintFiles: vi.fn<() => Promise<Array<{ errorCount: number; warningCount: number }>>>(),
+  loadFormatter: vi.fn(),
+  outputFixes: vi.fn(),
+  jitiImport: vi.fn(),
+  eslintCtor: vi.fn(),
+}));
+
+vi.mock("@simplysm/core-node", () => ({
+  fsx: { exists: mocks.fsxExists, glob: mocks.fsxGlob },
+  pathx: { filterByTargets: mocks.filterByTargets },
+}));
+
+vi.mock("eslint", () => ({
+  ESLint: class MockESLint {
+    constructor(options: unknown) { mocks.eslintCtor(options); }
+    lintFiles = mocks.lintFiles;
+    loadFormatter = mocks.loadFormatter;
+    static outputFixes = mocks.outputFixes;
+  },
+}));
+
+vi.mock("jiti", () => ({
+  createJiti: vi.fn(() => ({ import: mocks.jitiImport })),
+}));
+
+vi.mock("consola", () => {
+  const fns = (): Record<string, unknown> => ({
+    debug: vi.fn(), start: vi.fn(), success: vi.fn(),
+    info: vi.fn(), error: vi.fn(), warn: vi.fn(), log: vi.fn(),
+    withTag: vi.fn(() => fns()),
+    level: 0,
+  });
+  const c = fns();
+  return { consola: c, default: c, LogLevels: {} };
+});
+
+const { loadIgnorePatterns, executeLint } = await import("../../src/utils/lint-core");
+
+//#region loadIgnorePatterns
+
+describe("loadIgnorePatterns", () => {
+  beforeEach(() => vi.clearAllMocks());
+
+  it("extracts globalIgnores patterns from eslint config", async () => {
+    mocks.fsxExists.mockImplementation((p) =>
+      Promise.resolve(typeof p === "string" && p.endsWith("eslint.config.ts")),
+    );
+    mocks.jitiImport.mockResolvedValue({
+      default: [
+        { ignores: ["dist/**", "node_modules/**"] },
+        { files: ["*.ts"], rules: {} }, // not globalIgnores — has files key
+        { ignores: [".cache/**"] },
+      ],
+    });
+
+    const result = await loadIgnorePatterns("/project");
+    expect(result).toEqual(["dist/**", "node_modules/**", ".cache/**"]);
+  });
+
+  it("ignores config objects that have files key", async () => {
+    mocks.fsxExists.mockImplementation((p) =>
+      Promise.resolve(typeof p === "string" && p.endsWith("eslint.config.ts")),
+    );
+    mocks.jitiImport.mockResolvedValue({
+      default: [{ files: ["*.ts"], ignores: ["dist/**"] }],
+    });
+
+    const result = await loadIgnorePatterns("/project");
+    expect(result).toEqual([]);
+  });
+
+  it("throws when no eslint config file found", async () => {
+    mocks.fsxExists.mockResolvedValue(false);
+
+    await expect(loadIgnorePatterns("/project")).rejects.toThrow(
+      "ESLint 설정 파일",
+    );
+  });
+});
+
+//#endregion
+
+//#region executeLint
+
+describe("executeLint", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    // Default: eslint config exists with no ignores
+    mocks.fsxExists.mockImplementation((p) =>
+      Promise.resolve(typeof p === "string" && p.endsWith("eslint.config.ts")),
+    );
+    mocks.jitiImport.mockResolvedValue({ default: [] });
+    mocks.fsxGlob.mockResolvedValue(["/project/src/a.ts", "/project/src/b.ts"]);
+    mocks.filterByTargets.mockImplementation((files) => files);
+    mocks.lintFiles.mockResolvedValue([{ errorCount: 0, warningCount: 0 }]);
+    mocks.loadFormatter.mockResolvedValue({
+      format: vi.fn().mockResolvedValue(""),
+    });
+  });
+
+  it("lints all collected files and returns success when no errors", async () => {
+    const result = await executeLint({ targets: [], fix: false, timing: false });
+
+    expect(result.success).toBe(true);
+    expect(result.errorCount).toBe(0);
+    expect(result.warningCount).toBe(0);
+    expect(mocks.lintFiles).toHaveBeenCalled();
+  });
+
+  it("filters files by targets via pathx.filterByTargets", async () => {
+    const filteredFiles = ["/project/packages/core-common/src/a.ts"];
+    mocks.filterByTargets.mockReturnValue(filteredFiles);
+
+    await executeLint({ targets: ["packages/core-common"], fix: false, timing: false });
+
+    expect(mocks.filterByTargets).toHaveBeenCalledWith(
+      expect.any(Array),
+      ["packages/core-common"],
+      expect.any(String),
+    );
+  });
+
+  it("applies auto-fix when fix option is true", async () => {
+    await executeLint({ targets: [], fix: true, timing: false });
+
+    expect(mocks.outputFixes).toHaveBeenCalled();
+  });
+
+  it("sets TIMING env variable when timing option is true", async () => {
+    const origTiming = process.env["TIMING"];
+
+    await executeLint({ targets: [], fix: false, timing: true });
+
+    expect(process.env["TIMING"]).toBe("1");
+
+    // Cleanup
+    if (origTiming == null) delete process.env["TIMING"];
+    else process.env["TIMING"] = origTiming;
+  });
+
+  it("creates ESLint with cache enabled and correct cache location", async () => {
+    await executeLint({ targets: [], fix: false, timing: false });
+
+    expect(mocks.eslintCtor).toHaveBeenCalledWith(
+      expect.objectContaining({
+        cache: true,
+        cacheLocation: expect.stringContaining("eslint.cache"),
+      }),
+    );
+  });
+
+  it("returns error count and formatted output when lint errors found", async () => {
+    mocks.lintFiles.mockResolvedValue([
+      { errorCount: 3, warningCount: 1 },
+      { errorCount: 1, warningCount: 2 },
+    ]);
+    mocks.loadFormatter.mockResolvedValue({
+      format: vi.fn().mockResolvedValue("error details"),
+    });
+
+    const result = await executeLint({ targets: [], fix: false, timing: false });
+
+    expect(result.success).toBe(false);
+    expect(result.errorCount).toBe(4);
+    expect(result.warningCount).toBe(3);
+    expect(result.formattedOutput).toBe("error details");
+  });
+
+  it("returns success when no files to lint", async () => {
+    mocks.fsxGlob.mockResolvedValue([]);
+
+    const result = await executeLint({ targets: [], fix: false, timing: false });
+
+    expect(result.success).toBe(true);
+    expect(mocks.lintFiles).not.toHaveBeenCalled();
+  });
+});
+
+//#endregion

package/tests/utils/server-production-files-import-paths.verify.md

@@ -0,0 +1,14 @@
+# server-build.worker 비즈니스 로직 분리 — LLM 검증
+
+## 검증 항목
+
+- [x] 4개 함수가 utils/server-production-files.ts에 export되어 있다: line 14, 27, 68, 87에 각각 export function 확인
+- [x] worker에서 4개 함수 정의가 제거되었다: worker에 함수 정의 없음, import와 호출만 존재
+- [x] worker에서 collectAllExternals, generateProductionFiles를 새 모듈에서 import한다: line 19 `import { collectAllExternals, generateProductionFiles } from "../utils/server-production-files"`
+- [x] collectAllExternals 시그니처: `(pkgDir: string, manualExternals?: string[]) => string[]` — line 14 확인
+- [x] parseLockfileVersions 시그니처: `(cwd: string) => Map<string, string>` — line 27 확인
+- [x] resolveLockedVersions 시그니처: `(cwd: string, pkgNames: string[]) => Record<string, string>` — line 68 확인
+- [x] generateProductionFiles 시그니처: `(info: ServerBuildInfo, externals: string[]) => void` — line 87 확인
+- [x] worker에 build, rebuildAll, startWatch, stopWatch, cleanup, createEsbuildWatchContext가 존재한다: line 116, 148, 259, 336, 359, 488 확인
+- [x] worker에서 cpx import가 제거되었다: grep 결과 매칭 없음
+- [x] worker에서 collectAllDependencyExternals import가 제거되었다: grep 결과 매칭 없음

package/tests/workers/server-build-context-dispose.verify.md

@@ -0,0 +1,8 @@
+# esbuild context dispose 안전성 -- LLM 검증
+
+## 검증 항목
+
+- [x] try-finally 패턴 적용: `server-build.worker.ts:434-442` — oldContext 캡처 후 try 블록에서 새 context 생성, finally에서 oldContext.dispose() 호출
+- [x] 성공 시 dispose: try 블록에서 새 context 생성 성공 → finally에서 oldContext.dispose() 실행
+- [x] 실패 시 dispose: createEsbuildWatchContext() 예외 시 → finally에서 oldContext.dispose() 실행 보장
+- [x] null 안전: `if (oldContext != null)` 가드로 oldContext가 없는 경우(output.js=false 등) 안전