@simplysm/sd-cli 14.0.18 → 14.0.21

package/tests/utils/vite-scope-watch-plugin.spec.ts

@@ -16,6 +16,7 @@ vi.mock("@simplysm/core-node", () => ({
 vi.mock("fs", () => ({
   default: {
     existsSync: vi.fn(() => true),
+    realpathSync: vi.fn((p: string) => p.replace("/symlink/", "/real/")),
   },
 }));
 
@@ -133,6 +134,27 @@ describe("sdScopeWatchPlugin", () => {
     expect(FsWatcher.watch).not.toHaveBeenCalled();
   });
 
+  // Scenario: symlink 경로를 realpath로 해결하여 감시한다
+  it("resolves symlink paths to realpath for watch directories", async () => {
+    const plugin = sdScopeWatchPlugin({
+      pkgDir: "/packages/my-client",
+      replaceDeps: [
+        { packageName: "@scope/core", sourcePath: "/packages/core" },
+      ],
+    });
+
+    const mockServer = {
+      watcher: { emit: vi.fn() },
+      httpServer: { on: vi.fn() },
+    };
+
+    await (plugin as any).configureServer?.(mockServer);
+
+    // fs.realpathSync가 dist 경로에 대해 호출되었는지 확인
+    const fsModule = (await import("fs")).default;
+    expect(fsModule.realpathSync).toHaveBeenCalled();
+  });
+
   // Unit: server close cleans up watcher
   it("registers cleanup on server httpServer close", async () => {
     const plugin = sdScopeWatchPlugin({

package/tests/workers/server-build-context-dispose.verify.md

@@ -0,0 +1,8 @@
+# esbuild context dispose 안전성 -- LLM 검증
+
+## 검증 항목
+
+- [x] try-finally 패턴 적용: `server-build.worker.ts:434-442` — oldContext 캡처 후 try 블록에서 새 context 생성, finally에서 oldContext.dispose() 호출
+- [x] 성공 시 dispose: try 블록에서 새 context 생성 성공 → finally에서 oldContext.dispose() 실행
+- [x] 실패 시 dispose: createEsbuildWatchContext() 예외 시 → finally에서 oldContext.dispose() 실행 보장
+- [x] null 안전: `if (oldContext != null)` 가드로 oldContext가 없는 경우(output.js=false 등) 안전

package/tests/workers/server-runtime-worker.spec.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, vi, beforeEach, afterEach, beforeAll, afterAll } from "vitest";
+import fs from "fs";
 import path from "path";
 import os from "os";
 import fsp from "fs/promises";
@@ -82,8 +83,9 @@ vi.mock("net", () => ({
 // Import triggers createWorker
 await import("../../src/workers/server-runtime.worker");
 
-// Create a temp mock main.js that exports globalThis.__sdCliTestServer
-const mockMainJsPath = path.join(os.tmpdir(), `sd-cli-test-main-${Date.now()}.mjs`);
+// Create a temp directory with mock main.js that exports globalThis.__sdCliTestServer
+const mockMainDir = path.join(os.tmpdir(), `sd-cli-test-server-${Date.now()}`);
+const mockMainJsPath = path.join(mockMainDir, "main.mjs");
 
 const mockRegister = vi.fn().mockResolvedValue(undefined);
 
@@ -96,6 +98,7 @@ const mockServer = {
 
 beforeAll(async () => {
   (globalThis as any).__sdCliTestServer = mockServer;
+  await fsp.mkdir(mockMainDir, { recursive: true });
   await fsp.writeFile(
     mockMainJsPath,
     "export const server = globalThis.__sdCliTestServer;\n",
@@ -103,7 +106,7 @@ beforeAll(async () => {
 });
 
 afterAll(async () => {
-  await fsp.unlink(mockMainJsPath).catch(() => {});
+  await fsp.rm(mockMainDir, { recursive: true, force: true }).catch(() => {});
   delete (globalThis as any).__sdCliTestServer;
 });
 
@@ -152,7 +155,7 @@ describe("server-runtime.worker start", () => {
     portCheckIndex = 0;
   });
 
-  afterEach(() => {
+  afterEach(async () => {
     // Restore modified env vars
     for (const [key, value] of Object.entries(savedEnv)) {
       if (value === undefined) {
@@ -161,6 +164,8 @@ describe("server-runtime.worker start", () => {
         process.env[key] = value;
       }
     }
+    // .dev-port 정리
+    await fsp.unlink(path.join(mockMainDir, ".dev-port")).catch(() => {});
   });
 
   function trackEnv(key: string): void {
@@ -268,6 +273,45 @@ describe("server-runtime.worker start", () => {
     expect(mockRegister).not.toHaveBeenCalled();
   });
 
+  // Acceptance: Scenario "서버 listen 완료 후 .dev-port 기록"
+  it("writes .dev-port file with server port after listen", async () => {
+    portCheckResults = [true];
+    mockServer.options.port = 3000;
+
+    await workerFns["start"]({ mainJsPath: mockMainJsPath });
+
+    const portFile = path.join(mockMainDir, ".dev-port");
+    const content = await fsp.readFile(portFile, "utf-8");
+    expect(content).toBe("3000");
+  });
+
+  // Unit: 포트 충돌로 다른 포트 사용 시 실제 포트 기록
+  it("writes actual port to .dev-port when port auto-incremented", async () => {
+    portCheckResults = [false, false, true]; // 3000, 3001 taken, 3002 available
+    mockServer.options.port = 3000;
+
+    await workerFns["start"]({ mainJsPath: mockMainJsPath });
+
+    const portFile = path.join(mockMainDir, ".dev-port");
+    const content = await fsp.readFile(portFile, "utf-8");
+    expect(content).toBe("3002");
+  });
+
+  // Unit: cleanup 시 .dev-port 삭제
+  it("removes .dev-port file during cleanup", async () => {
+    portCheckResults = [true];
+    await workerFns["start"]({ mainJsPath: mockMainJsPath });
+
+    const portFile = path.join(mockMainDir, ".dev-port");
+    expect(fs.existsSync(portFile)).toBe(true);
+
+    const { registerCleanupHandlers } = await import("../../src/utils/worker-utils");
+    const cleanupFn = vi.mocked(registerCleanupHandlers).mock.calls[0][0];
+    await cleanupFn();
+
+    expect(fs.existsSync(portFile)).toBe(false);
+  });
+
   it("sends error event when main.js does not export server", async () => {
     // Create a temp file without server export
     const noServerPath = path.join(os.tmpdir(), `sd-cli-test-no-server-${Date.now()}.mjs`);