@simplysm/sd-cli 14.0.13 → 14.0.15

package/tests/orchestrators/build-orchestrator.spec.ts

@@ -271,7 +271,7 @@ describe("BuildOrchestrator.start", () => {
 
     // BuildEngine should be created and run() called
     expect(createBuildEngine).toHaveBeenCalledOnce();
-    expect(mockEngines[0].run).toHaveBeenCalledWith({ js: true, dts: true, lint: true });
+    expect(mockEngines[0].run).toHaveBeenCalledWith({ js: true, dts: true, lint: false });
     expect(mockEngines[0].stop).toHaveBeenCalled();
   });
 
@@ -624,7 +624,7 @@ describe("BuildOrchestrator client build", () => {
       expect.any(Object),
     );
     const engineMock = vi.mocked(createBuildEngine).mock.results[0].value;
-    expect(engineMock.run).toHaveBeenCalledWith({ js: true, dts: false, lint: true });
+    expect(engineMock.run).toHaveBeenCalledWith({ js: true, dts: false, lint: false });
     expect(engineMock.stop).toHaveBeenCalled();
   });
 
@@ -852,7 +852,7 @@ describe("BuildOrchestrator native build integration (Slice 1)", () => {
     // ViteEngine should have been called
     expect(createBuildEngine).toHaveBeenCalled();
     const engineMock = vi.mocked(createBuildEngine).mock.results[0].value;
-    expect(engineMock.run).toHaveBeenCalledWith({ js: true, dts: false, lint: true });
+    expect(engineMock.run).toHaveBeenCalledWith({ js: true, dts: false, lint: false });
 
     // Capacitor should have been created, initialized, and built
     expect(Capacitor.create).toHaveBeenCalledWith(
@@ -980,8 +980,8 @@ describe("BuildOrchestrator native build integration (Slice 1)", () => {
 const { runLintInWorker } = await import("../../src/utils/lint-utils");
 
 describe("BuildOrchestrator lint integration", () => {
-  // Scenario: build에서 각 패키지 빌드 시 lint가 함께 실행된다
-  it("passes lint:true to engine.run for all package types", async () => {
+  // build에서 lint를 실행하지 않는다 (lint는 check에서만 실행)
+  it("passes lint:false to engine.run for all package types", async () => {
     setupDefaults({
       packages: {
         "core-common": { target: "neutral", publish: { type: "npm" } },
@@ -994,15 +994,13 @@ describe("BuildOrchestrator lint integration", () => {
     await orchestrator.initialize();
     await orchestrator.start();
 
-    // All 3 engines should receive lint: true
     expect(mockEngines).toHaveLength(3);
     for (const engine of mockEngines) {
       const runArgs = engine.run.mock.calls[0][0];
-      expect(runArgs.lint).toBe(true);
+      expect(runArgs.lint).toBe(false);
     }
   });
 
-  // Scenario: build에서 기존 runLint() 병렬 태스크가 제거된다
   it("does not call runLint (separate lint worker)", async () => {
     setupDefaults({
       packages: {
@@ -1017,32 +1015,7 @@ describe("BuildOrchestrator lint integration", () => {
     expect(runLintInWorker).not.toHaveBeenCalled();
   });
 
-  // Scenario: build lint 에러가 빌드 결과 출력에 포함된다
-  it("sets hasError when lint fails in engine result", async () => {
-    setupDefaults({
-      packages: {
-        "core-common": { target: "neutral", publish: { type: "npm" } },
-      },
-    });
-    vi.mocked(createBuildEngine).mockReturnValue({
-      run: vi.fn().mockResolvedValue({
-        success: true,
-        build: { success: true, errors: [], warnings: [], diagnostics: [] },
-        lint: { success: false, errorCount: 3, warningCount: 0, formattedOutput: "lint errors here" },
-      }),
-      startWatch: vi.fn(),
-      stop: vi.fn().mockResolvedValue(undefined),
-    } as any);
-
-    const orchestrator = new BuildOrchestrator({ targets: [], options: [] });
-    await orchestrator.initialize();
-    const hasError = await orchestrator.start();
-
-    expect(hasError).toBe(true);
-  });
-
-  // Scenario: build에서 scripts 패키지는 제외된다
-  it("excludes scripts packages (no lint for scripts)", async () => {
+  it("excludes scripts packages", async () => {
     setupDefaults({
       packages: {
         "core-common": { target: "neutral", publish: { type: "npm" } },
@@ -1054,7 +1027,6 @@ describe("BuildOrchestrator lint integration", () => {
     await orchestrator.initialize();
     await orchestrator.start();
 
-    // Only core-common should have engine (scripts excluded)
     expect(mockEngines).toHaveLength(1);
     expect(runLintInWorker).not.toHaveBeenCalled();
   });
@@ -1062,114 +1034,4 @@ describe("BuildOrchestrator lint integration", () => {
 
 //#endregion
 
-//#region Feature 2.1 Slice 3: build typeLabel에 lint 분기 추가
-
-describe("Feature 2.1: build에서 lint 에러가 'lint' 라벨로 출력", () => {
-  it("build에서 lint 에러가 'lint' 라벨로 출력된다", async () => {
-    setupDefaults({
-      packages: {
-        "core-common": { target: "neutral", publish: { type: "npm" } },
-      },
-    });
-    vi.mocked(createBuildEngine).mockReturnValue({
-      run: vi.fn().mockResolvedValue({
-        success: true,
-        build: { success: true, errors: [], warnings: [], diagnostics: [] },
-        lint: { success: false, errorCount: 1, warningCount: 0, formattedOutput: "no-unused-vars" },
-      }),
-      startWatch: vi.fn(),
-      stop: vi.fn().mockResolvedValue(undefined),
-    } as any);
-
-    const orchestrator = new BuildOrchestrator({ targets: [], options: [] });
-    await orchestrator.initialize();
-    await orchestrator.start();
-
-    // formatBuildMessages should have been called with "lint" label
-    const { formatBuildMessages } = await import("../../src/utils/output-utils");
-    const fmtCalls = vi.mocked(formatBuildMessages).mock.calls;
-    const lintCall = fmtCalls.find((c) => c[1] === "lint");
-    expect(lintCall).toBeDefined();
-    expect(lintCall![0]).toBe("core-common");
-  });
-
-  it("build에서 JS 빌드 에러는 target 라벨(neutral) 유지", async () => {
-    setupDefaults({
-      packages: {
-        "core-common": { target: "neutral", publish: { type: "npm" } },
-      },
-    });
-    vi.mocked(createBuildEngine).mockReturnValue({
-      run: vi.fn().mockResolvedValue({
-        success: false,
-        build: { success: false, errors: ["Module not found"], warnings: [], diagnostics: [] },
-      }),
-      startWatch: vi.fn(),
-      stop: vi.fn().mockResolvedValue(undefined),
-    } as any);
-
-    const orchestrator = new BuildOrchestrator({ targets: [], options: [] });
-    await orchestrator.initialize();
-    await orchestrator.start();
-
-    const { formatBuildMessages } = await import("../../src/utils/output-utils");
-    const fmtCalls = vi.mocked(formatBuildMessages).mock.calls;
-    const jsCall = fmtCalls.find((c) => c[1] === "neutral");
-    expect(jsCall).toBeDefined();
-  });
-
-  it("build에서 빌드 에러는 target 라벨 유지", async () => {
-    setupDefaults({
-      packages: {
-        "core-common": { target: "neutral", publish: { type: "npm" } },
-      },
-    });
-    vi.mocked(createBuildEngine).mockReturnValue({
-      run: vi.fn().mockResolvedValue({
-        success: false,
-        build: { success: false, errors: ["Type error"], warnings: [], diagnostics: [] },
-      }),
-      startWatch: vi.fn(),
-      stop: vi.fn().mockResolvedValue(undefined),
-    } as any);
-
-    const orchestrator = new BuildOrchestrator({ targets: [], options: [] });
-    await orchestrator.initialize();
-    await orchestrator.start();
-
-    const { formatBuildMessages } = await import("../../src/utils/output-utils");
-    const fmtCalls = vi.mocked(formatBuildMessages).mock.calls;
-    const buildCall = fmtCalls.find((c) => c[1] === "neutral");
-    expect(buildCall).toBeDefined();
-  });
-
-  it("build에서 lint 성공 시 에러 출력 없음", async () => {
-    setupDefaults({
-      packages: {
-        "core-common": { target: "neutral", publish: { type: "npm" } },
-      },
-    });
-    vi.mocked(createBuildEngine).mockReturnValue({
-      run: vi.fn().mockResolvedValue({
-        success: true,
-        build: { success: true, errors: [], warnings: [], diagnostics: [] },
-        lint: { success: true, errorCount: 0, warningCount: 0, formattedOutput: "" },
-      }),
-      startWatch: vi.fn(),
-      stop: vi.fn().mockResolvedValue(undefined),
-    } as any);
-
-    const orchestrator = new BuildOrchestrator({ targets: [], options: [] });
-    await orchestrator.initialize();
-    await orchestrator.start();
-
-    // No error log about lint
-    const errorCalls = mockLogger.error.mock.calls;
-    const lintErrorCall = errorCalls.find(
-      (c: unknown[]) => typeof c[0] === "string" && (c[0]).includes("lint"),
-    );
-    expect(lintErrorCall).toBeUndefined();
-  });
-});
-
 //#endregion

package/tests/utils/vite-config.spec.ts

@@ -11,6 +11,11 @@ vi.mock("../../src/angular/vite-angular-plugin.js", () => ({
   sdAngularPlugin: mockSdAngularPlugin,
 }));
 
+const mockSolidPlugin = vi.fn(() => ({ name: "vite-plugin-solid" }));
+vi.mock("vite-plugin-solid", () => ({
+  default: mockSolidPlugin,
+}));
+
 vi.mock("../../src/utils/vite-scope-watch-plugin.js", () => ({
   sdScopeWatchPlugin: vi.fn(() => ({ name: "sd-scope-watch-plugin" })),
 }));
@@ -577,6 +582,55 @@ describe("createClientViteConfig", () => {
     expect(scopePlugin).toBeUndefined();
   });
 
+  // --- framework selection (Feature 1.1: client-framework-selection) ---
+
+  // Acceptance: Scenario "Solid 프레임워크 선택"
+  it("uses solidPlugin when framework is 'solid'", async () => {
+    const config = await createClientViteConfig({
+      ...createDefaultOptions(),
+      framework: "solid",
+    });
+
+    const plugins = config.plugins as Array<{ name: string }>;
+    expect(plugins.find((p) => p.name === "vite-plugin-solid")).toBeDefined();
+    expect(mockSolidPlugin).toHaveBeenCalled();
+    expect(mockSdAngularPlugin).not.toHaveBeenCalled();
+  });
+
+  // Acceptance: Scenario "framework 미지정 시 기본값"
+  it("uses sdAngularPlugin when framework is not specified", async () => {
+    await createClientViteConfig(createDefaultOptions());
+
+    expect(mockSdAngularPlugin).toHaveBeenCalled();
+    expect(mockSolidPlugin).not.toHaveBeenCalled();
+  });
+
+  // Acceptance: Scenario "Angular 프레임워크 명시 선택"
+  it("uses sdAngularPlugin when framework is 'angular'", async () => {
+    await createClientViteConfig({
+      ...createDefaultOptions(),
+      framework: "angular",
+    });
+
+    expect(mockSdAngularPlugin).toHaveBeenCalled();
+    expect(mockSolidPlugin).not.toHaveBeenCalled();
+  });
+
+  // Acceptance: Scenario "Solid 빌드에서 PostCSS inline 플러그인 미적용"
+  it("does not add sdPostCssInlinePlugin when framework is 'solid' even with postCssPlugins", async () => {
+    const fakePlugin = { postcssPlugin: "autoprefixer" };
+    const config = await createClientViteConfig({
+      ...createDefaultOptions(),
+      framework: "solid",
+      postCssPlugins: [fakePlugin],
+    });
+
+    const plugins = config.plugins as Array<{ name: string }>;
+    expect(plugins.find((p) => p.name === "sd-postcss-inline")).toBeUndefined();
+    // 하지만 css.postcss는 여전히 설정된다 (외부 CSS 파일용)
+    expect(config.css?.postcss).toEqual({ plugins: [fakePlugin] });
+  });
+
   // Acceptance: Scenario "pwa 필드 미설정 시 기본값"
   it("uses default manifest values from pkgName when pwa is undefined", async () => {
     await createClientViteConfig(createDefaultOptions());
@@ -595,4 +649,49 @@ describe("createClientViteConfig", () => {
       }),
     );
   });
+
+  // --- legacyModule dev mode (Feature: fix-legacy-ngdevmode) ---
+
+  // Acceptance: Scenario "legacyModule: true + dev 명령 실행 시 sdAngularPlugin에 dev: true 전달"
+  it("passes dev: true to sdAngularPlugin when mode is dev with legacyModule", async () => {
+    await createClientViteConfig({
+      ...createDefaultOptions(),
+      mode: "dev",
+      legacyModule: true,
+      watch: true,
+    });
+
+    expect(mockSdAngularPlugin).toHaveBeenCalledWith(
+      expect.objectContaining({ dev: true }),
+    );
+  });
+
+  // Acceptance: Scenario "legacyModule dev에서 build output 설정이 적용된다"
+  it("applies build output settings when mode is dev with legacyModule", async () => {
+    const config = await createClientViteConfig({
+      ...createDefaultOptions(),
+      mode: "dev",
+      legacyModule: true,
+      watch: true,
+    });
+
+    expect(config.build?.outDir).toMatch(/my-client[\\/]dist$/);
+    expect(config.build?.watch).toEqual({});
+    expect(config.build?.emptyOutDir).toBe(false);
+    expect(config.build?.minify).toBe(false);
+  });
+
+  // Unit: legacyModule dev에서 PWA가 추가되지 않는다
+  it("does not add VitePWA plugin when mode is dev with legacyModule", async () => {
+    const config = await createClientViteConfig({
+      ...createDefaultOptions(),
+      mode: "dev",
+      legacyModule: true,
+      watch: true,
+    });
+
+    const plugins = config.plugins as Array<{ name: string }>;
+    const pwaPlugin = plugins.find((p) => p.name === "vite-plugin-pwa");
+    expect(pwaPlugin).toBeUndefined();
+  });
 });

package/tests/workers/client-worker.spec.ts

@@ -228,9 +228,10 @@ describe("client.worker", () => {
 
       expect(mockCreateClientViteConfig).toHaveBeenCalledWith(
         expect.objectContaining({
-          mode: "build",
+          mode: "dev",
           watch: true,
           pwa: false,
+          legacyModule: true,
         }),
       );
     });