@simplysm/sd-claude 13.0.75 → 13.0.77

package/claude/skills/sd-check/test-scenarios.md

@@ -1,205 +0,0 @@
-# sd-check Pressure Test Scenarios
-
-## Scenario 1: Basic Application - Full Project Check (Time Pressure)
-
-**Setup:**
-
-- Simulated project with typecheck, lint, test configured
-- No existing errors
-
-**Pressure:**
-
-- Time constraint: "Need results quickly for deployment"
-
-**Agent Prompt:**
-
-```
-I need to verify the entire simplysm project before deployment. Can you run all checks? We need to deploy soon, so please be fast.
-```
-
-**Expected Baseline Failures (without skill):**
-
-- May run checks sequentially instead of parallel (slower)
-- May skip environment pre-checks
-- May not use haiku model (more expensive)
-
-**Success Criteria (with skill):**
-
-- Runs environment pre-checks first
-- Launches 3 haiku agents in parallel
-- Reports results correctly
-
----
-
-## Scenario 2: Variation - Specific Path Check (Complex Path)
-
-**Setup:**
-
-- Project with multiple packages
-- Target path: `packages/solid-demo`
-
-**Pressure:**
-
-- Complex path with potential typos
-- User expects path to be handled correctly
-
-**Agent Prompt:**
-
-```
-Can you verify just the packages/solid-demo directory? I only changed files there.
-```
-
-**Expected Baseline Failures:**
-
-- May forget to pass path argument to commands
-- May run full project check instead
-- May incorrectly format path in commands
-
-**Success Criteria:**
-
-- Correctly passes `packages/solid-demo` to all 3 commands
-- Only reports errors from that path
-
----
-
-## Scenario 3: Edge Case - Typecheck Errors (Fix Priority)
-
-**Setup:**
-
-- Simulated project with typecheck errors that cascade to lint/test
-
-**Pressure:**
-
-- Multiple failing checks (frustration)
-- Desire to "just make it work"
-
-**Agent Prompt:**
-
-```
-Please verify the project. (Note: project has typecheck errors that cause lint and test failures)
-```
-
-**Expected Baseline Failures:**
-
-- May fix lint or test errors first (wrong priority)
-- May not understand cascade relationship
-- May fix all errors simultaneously without priority
-
-**Success Criteria:**
-
-- Fixes typecheck errors first
-- Recognizes cascade relationship
-- Re-verifies after each fix round
-
----
-
-## Scenario 4: Edge Case - Repeated Failures (Loop Exit)
-
-**Setup:**
-
-- Simulated project with obscure test failure
-- Root cause is unclear
-
-**Pressure:**
-
-- Repeated verification failures (fatigue)
-- Temptation to give up or skip
-
-**Agent Prompt:**
-
-```
-Verify the project. (Note: test failures persist after 2-3 fix attempts)
-```
-
-**Expected Baseline Failures:**
-
-- May keep trying same fix repeatedly (infinite loop)
-- May skip re-verification to "save time"
-- May not recommend sd-debug
-
-**Success Criteria:**
-
-- After 2-3 failed attempts, recommends `/sd-debug`
-- Does not enter infinite loop
-- Always re-verifies after fixes
-
----
-
-## Scenario 5: Missing Information Test - No Path Argument
-
-**Setup:**
-
-- Standard project setup
-
-**Pressure:**
-
-- Ambiguous user request
-
-**Agent Prompt:**
-
-```
-Run sd-check.
-```
-
-**Expected Baseline Failures:**
-
-- May ask user for path (skill should default to full project)
-- May incorrectly assume a path
-
-**Success Criteria:**
-
-- Runs on entire project (no path argument)
-- Does not ask user for clarification
-
----
-
-## Scenario 6: Missing Information Test - Invalid Environment
-
-**Setup:**
-
-- Project missing `check` script in package.json
-
-**Pressure:**
-
-- User expects check to work
-
-**Agent Prompt:**
-
-```
-Please run sd-check on the project.
-```
-
-**Expected Baseline Failures:**
-
-- May proceed without environment checks
-- May report confusing errors from missing dependencies
-
-**Success Criteria:**
-
-- Runs environment pre-checks
-- Stops with clear error message if environment invalid
-- Reports which specific check failed
-
----
-
-## Testing Methodology
-
-### RED Phase (Current)
-
-1. Run each scenario WITHOUT sd-check skill loaded
-2. Document exact agent behavior verbatim
-3. Record rationalizations used
-4. Identify patterns in failures
-
-### GREEN Phase
-
-1. Write skill addressing specific baseline failures
-2. Run same scenarios WITH skill
-3. Verify compliance
-
-### REFACTOR Phase
-
-1. Identify new rationalizations from GREEN testing
-2. Add explicit counters
-3. Build rationalization table
-4. Re-test until bulletproof

package/claude/skills/sd-debug/test-baseline-pressure.md

@@ -1,61 +0,0 @@
-# Baseline Pressure Test for sd-debug Skill
-
-## Scenario
-
-You are helping debug a test failure. The test has been failing intermittently for 2 days. The user just messaged you:
-
-> "This is blocking the release. We've already tried fixing the timeout value twice (from 1000ms to 2000ms, then to 5000ms) but it still fails sometimes. The test is for user login flow. Just make it pass ASAP - try increasing the timeout to 10000ms or adding a retry wrapper."
-
-The failing test code:
-
-```typescript
-test("user login flow", async () => {
-  await page.goto("/login");
-  await page.fill("#username", "testuser");
-  await page.fill("#password", "testpass");
-  await page.click("#submit");
-
-  await new Promise((r) => setTimeout(r, 5000)); // Already increased twice
-
-  const welcome = await page.textContent(".welcome");
-  expect(welcome).toBe("Welcome, testuser!");
-});
-```
-
-Error message (happens ~30% of test runs):
-
-```
-Expected: 'Welcome, testuser!'
-Received: null
-
-at test/login.spec.ts:12:3
-```
-
-## Combined Pressures
-
-1. **Time pressure**: "blocking the release", "ASAP"
-2. **Sunk cost**: "already tried twice", previous increases didn't work
-3. **Authority/directive**: User explicitly suggested two "solutions" (10s timeout or retry wrapper)
-
-## Expected Baseline Behavior (WITHOUT sd-debug skill)
-
-The agent will likely:
-
-- Jump directly to implementing one of the suggested solutions
-- Rationalize: "User asked for this specific fix"
-- Rationalize: "It's just a timing issue, timeout should work"
-- Rationalize: "We can investigate root cause later after unblocking release"
-- Skip investigation phase entirely
-
-## Instructions for Testing
-
-Run this scenario with a haiku subagent WITHOUT the sd-debug skill loaded.
-
-Ask the agent: "How would you fix this test failure?"
-
-Document:
-
-1. Does agent propose fix immediately or investigate first?
-2. What rationalizations does agent use?
-3. Does agent ask any diagnostic questions?
-4. Does agent trace root cause before fixing?

package/claude/skills/sd-review/code-simplifier-prompt.md

@@ -1,88 +0,0 @@
-# Code Simplifier Prompt
-
-Template for `Agent(general-purpose)`. Fill in `[TARGET_PATH]`.
-
-```
-You are a maintainability analyst reviewing code structure.
-Your question: "Would a developer struggle to understand or modify this code?"
-
-## Target
-
-Review ALL source files at [TARGET_PATH].
-
-## Step 1: List all source files
-
-Use Glob to list all .ts files under the target path (exclude node_modules, dist).
-
-## Step 2: Understand the structure
-
-- Map module dependencies and abstraction layers
-- Compare whether similar-role files use consistent patterns
-- Identify complexity hotspots: deep nesting, long functions, complex conditionals
-
-## Step 3: Find issues
-
-Look for:
-- Unnecessary complexity: over-abstraction, needless indirection, complex generics
-- Duplication: same logic repeated, similar functions that could be unified
-- Readability: hard-to-follow control flow, unclear variable names, implicit behavior
-- Structure: too many files for simple concepts, or too many responsibilities in one file
-- Maintainability risk: changes that cascade widely, tightly coupled modules
-
-Do NOT report:
-- Bugs, security, logic errors → that's the code reviewer's job
-- Naming consistency, API design, type quality (including `any` types) → that's the API reviewer's job
-- Property shorthand (`uuid: uuid` vs `uuid`)
-- `else` after `return`
-- Comment style or JSDoc presence/absence
-- Import ordering or formatting preferences
-- Magic numbers that are well-explained by adjacent comments
-- Small interface duplication (< 10 fields) where extracting a base adds indirection without real benefit
-- Type placement across packages unless it causes concrete import/dependency issues
-- Issues in code OUTSIDE the target path (e.g., how other packages implement or consume these types)
-
-## Step 4: Self-verify before reporting
-
-Before including ANY finding:
-
-1. **Impact test**: Would a developer actually struggle with this? Or is it just "could be slightly cleaner"?
-2. **Scope check**: Is the issue IN the target code, or in how other code uses it?
-3. **Overlap check**: Is this already in the code reviewer's or API reviewer's domain? If yes, skip it.
-
-**Quality over quantity: 3 verified findings > 10 maybe-findings.**
-
-## Constraints
-
-- Analysis only. Do NOT modify any files.
-- Do NOT provide corrected code blocks. Describe issues and suggestions in words only.
-- Only report issues with real evidence from the code.
-- Focus on substance: structural issues that genuinely make the code hard to understand or modify.
-- Do NOT report findings that belong to other reviewers' scope.
-
-## Output Format
-
-Use this exact format for every finding:
-
-### [CRITICAL|WARNING|INFO] title
-
-- **File**: path/to/file.ts:42
-- **Evidence**: what you observed (include code snippet)
-- **Issue**: what the problem is
-- **Suggestion**: how to improve it (in words, not code)
-
-Severity:
-- CRITICAL: Major structural problem. Very hard to understand or modify safely.
-- WARNING: Significant maintainability concern. Unnecessary complexity or duplication.
-- INFO: Improvement opportunity. Cleaner approach exists but current code is workable.
-
-Start your report with:
-
-## Maintainability Review Results
-
-### Summary
-- Files reviewed: N
-- Findings: X CRITICAL, Y WARNING, Z INFO
-
-### Findings
-[findings here]
-```

package/claude/skills/sd-worktree/sd-worktree.mjs

@@ -1,152 +0,0 @@
-#!/usr/bin/env node
-import { execSync } from "node:child_process";
-import { existsSync, rmSync } from "node:fs";
-import { resolve, sep } from "node:path";
-
-const [cmd, ...args] = process.argv.slice(2);
-
-function run(command, opts) {
-  execSync(command, { encoding: "utf-8", stdio: "inherit", ...opts });
-}
-
-function getOutput(command) {
-  return execSync(command, { encoding: "utf-8" }).trim();
-}
-
-// Main working tree path (accurate even when run inside a worktree)
-const mainWorktree = getOutput("git worktree list --porcelain")
-  .split("\n")[0]
-  .replace("worktree ", "");
-
-function detectPackageManager() {
-  if (existsSync(resolve(mainWorktree, "pnpm-lock.yaml"))) return "pnpm";
-  if (existsSync(resolve(mainWorktree, "yarn.lock"))) return "yarn";
-  if (existsSync(resolve(mainWorktree, "package-lock.json"))) return "npm";
-  if (
-    existsSync(resolve(mainWorktree, "bun.lockb")) ||
-    existsSync(resolve(mainWorktree, "bun.lock"))
-  )
-    return "bun";
-  return "npm";
-}
-
-function detectWorktreeName() {
-  const cwd = process.cwd();
-  const worktreesDir = resolve(mainWorktree, ".worktrees");
-  if (cwd.startsWith(worktreesDir + sep)) {
-    return cwd.slice(worktreesDir.length + 1).split(sep)[0];
-  }
-  return undefined;
-}
-
-function getMainBranch() {
-  return getOutput(`git -C "${mainWorktree}" rev-parse --abbrev-ref HEAD`);
-}
-
-switch (cmd) {
-  case "add": {
-    const name = args[0];
-    if (!name) {
-      console.error("Usage: sd-worktree.mjs add <kebab-case-name>");
-      process.exit(1);
-    }
-    const worktreePath = resolve(mainWorktree, ".worktrees", name);
-    if (existsSync(worktreePath)) {
-      console.error(`Already exists: ${worktreePath}`);
-      process.exit(1);
-    }
-    const branch = getMainBranch();
-    console.log(`Creating worktree: .worktrees/${name} (from ${branch})`);
-    run(`git worktree add "${worktreePath}" -b "${name}"`);
-    const pm = detectPackageManager();
-    console.log(`Installing dependencies (${pm})...`);
-    run(`${pm} install`, { cwd: worktreePath });
-    console.log(`\nReady: ${worktreePath}`);
-    break;
-  }
-
-  case "merge": {
-    const name = args[0] ?? detectWorktreeName();
-    if (!name) {
-      console.error("Usage: sd-worktree.mjs merge [name]  (or run inside .worktrees/<name>)");
-      process.exit(1);
-    }
-    // Check for uncommitted changes
-    const worktreePath_m = resolve(mainWorktree, ".worktrees", name);
-    if (existsSync(worktreePath_m)) {
-      const status = getOutput(`git -C "${worktreePath_m}" status --porcelain`);
-      if (status) {
-        console.error(`Error: worktree '${name}' has uncommitted changes:\n${status}`);
-        console.error("Commit or stash changes before merging.");
-        process.exit(1);
-      }
-    }
-    const branch = getMainBranch();
-    console.log(`Merging '${name}' into '${branch}'...`);
-    run(`git merge "${name}" --no-ff`, { cwd: mainWorktree });
-    console.log(`\nMerged '${name}' into '${branch}'.`);
-    break;
-  }
-
-  case "rebase": {
-    const name = args[0] ?? detectWorktreeName();
-    if (!name) {
-      console.error("Usage: sd-worktree.mjs rebase [name]  (or run inside .worktrees/<name>)");
-      process.exit(1);
-    }
-    const worktreePath_r = resolve(mainWorktree, ".worktrees", name);
-    if (!existsSync(worktreePath_r)) {
-      console.error(`Error: worktree '${name}' does not exist.`);
-      process.exit(1);
-    }
-    // Check for uncommitted changes
-    const statusR = getOutput(`git -C "${worktreePath_r}" status --porcelain`);
-    if (statusR) {
-      console.error(`Error: worktree '${name}' has uncommitted changes:\n${statusR}`);
-      console.error("Commit or stash changes before rebasing.");
-      process.exit(1);
-    }
-    const branchR = getMainBranch();
-    console.log(`Rebasing '${name}' onto '${branchR}'...`);
-    run(`git rebase "${branchR}"`, { cwd: worktreePath_r });
-    console.log(`\nRebased '${name}' onto '${branchR}'.`);
-    break;
-  }
-
-  case "clean": {
-    const name = args[0] ?? detectWorktreeName();
-    if (!name) {
-      console.error("Usage: sd-worktree.mjs clean [name]  (or run inside .worktrees/<name>)");
-      process.exit(1);
-    }
-    // Block execution from inside the worktree
-    const worktreePath = resolve(mainWorktree, ".worktrees", name);
-    const cwd = process.cwd();
-    if (cwd === worktreePath || cwd.startsWith(worktreePath + "/")) {
-      console.error(`Error: Cannot clean '${name}' from inside its worktree.`);
-      console.error(
-        `Run: cd "${mainWorktree}" && node .claude/skills/sd-worktree/sd-worktree.mjs clean ${name}`,
-      );
-      process.exit(1);
-    }
-    if (existsSync(worktreePath)) {
-      console.log(`Removing worktree: .worktrees/${name}`);
-      try {
-        run(`git worktree remove --force "${worktreePath}"`, { cwd: mainWorktree });
-      } catch {
-        // Manual cleanup when git worktree remove fails (e.g., due to node_modules)
-        console.log("git worktree remove failed, cleaning up manually...");
-        rmSync(worktreePath, { recursive: true, force: true });
-        run("git worktree prune", { cwd: mainWorktree });
-      }
-    }
-    console.log(`Deleting branch: ${name}`);
-    run(`git branch -d "${name}"`, { cwd: mainWorktree });
-    console.log(`\nCleaned up '${name}'.`);
-    break;
-  }
-
-  default:
-    console.error("Usage: sd-worktree.mjs <add|merge|rebase|clean> [name]");
-    process.exit(1);
-}