@simplysm/eslint-plugin 12.4.1 → 12.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@simplysm/eslint-plugin",
-  "version": "12.4.1",
+  "version": "12.5.1",
   "description": "심플리즘 패키지 - ESLINT 플러그인",
   "author": "김석래",
   "repository": {
@@ -10,21 +10,16 @@
   },
   "license": "MIT",
   "type": "module",
-  "main": "src/index.cjs",
+  "main": "src/index.js",
   "engines": {
-    "node": "18.18.2"
+    "node": "20.16.0"
   },
   "dependencies": {
-    "@angular-eslint/eslint-plugin": "^18.3.0",
-    "@angular-eslint/eslint-plugin-template": "^18.3.0",
-    "@angular-eslint/template-parser": "^18.3.0",
-    "@typescript-eslint/eslint-plugin": "^8.2.0",
-    "@typescript-eslint/parser": "^8.2.0",
-    "@typescript-eslint/utils": "^8.2.0",
-    "eslint": "^8.57.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-module-utils": "^2.8.2",
-    "eslint-plugin-import": "^2.29.1",
-    "typescript": "~5.5.4"
+    "@typescript-eslint/utils": "^8.4.0",
+    "angular-eslint": "^18.3.0",
+    "eslint": "^9.9.1",
+    "globals": "^15.9.0",
+    "typescript": "~5.5.4",
+    "typescript-eslint": "^8.4.0"
   }
 }

package/src/configs/root.js

@@ -0,0 +1,92 @@
+import globals from "globals";
+import tseslint from "typescript-eslint";
+import ngeslint from "angular-eslint";
+import plugin from "../plugin.js";
+
+export default [
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.es2021,
+      },
+      ecmaVersion: 2021,
+      sourceType: "module",
+    },
+  },
+  {
+    files: ["**/*.js"],
+    rules: {
+      "no-console": ["warn"],
+      "no-warning-comments": ["warn"],
+
+      "require-await": ["error"],
+      "semi": ["error"],
+      "no-shadow": ["error"],
+      "no-duplicate-imports": ["error"],
+      "no-unused-expressions": ["error"],
+      "no-unused-vars": ["error"],
+      "no-undef": ["error"],
+    },
+  },
+  ...tseslint.config(
+    {
+      files: ["**/*.ts"],
+      plugins: {
+        "@typescript-eslint": tseslint.plugin,
+        "@angular-eslint": ngeslint.tsPlugin,
+        "@simplysm": plugin,
+      },
+      languageOptions: {
+        parser: tseslint.parser,
+      },
+      processor: ngeslint.processInlineTemplates,
+      rules: {
+        // 기본
+        "no-console": ["warn"],
+        "no-warning-comments": ["warn"],
+
+        // 타입스크립트
+        "@typescript-eslint/require-await": ["error"],
+        "@typescript-eslint/await-thenable": ["error"],
+        "@typescript-eslint/return-await": ["error", "always"],
+        "@typescript-eslint/no-floating-promises": ["error"],
+        // "@typescript-eslint/semi": ["error"], // Deprecated (https://typescript-eslint.io/rules/semi/)
+        "@typescript-eslint/no-shadow": ["error"],
+        // "@typescript-eslint/no-unnecessary-condition": ["error", {allowConstantLoopConditions: true}],
+        "@typescript-eslint/no-unnecessary-type-assertion": ["error"],
+        "@typescript-eslint/non-nullable-type-assertion-style": ["error"],
+        "@typescript-eslint/prefer-reduce-type-parameter": ["error"],
+        "@typescript-eslint/prefer-return-this-type": ["error"],
+        "@typescript-eslint/typedef": ["error"],
+        "@typescript-eslint/no-unused-expressions": ["error"],
+        "@typescript-eslint/no-unused-vars": ["error", { args: "none" }],
+        "@typescript-eslint/strict-boolean-expressions": [
+          "error",
+          {
+            allowNullableBoolean: true,
+            allowNullableObject: true,
+          },
+        ],
+        "@typescript-eslint/prefer-ts-expect-error": ["error"],
+
+        // 심플리즘
+        "@simplysm/ts-no-throw-not-implement-error": ["warn"],
+      },
+    },
+    {
+      files: ["**/*.html"],
+      languageOptions: {
+        parser: ngeslint.templateParser,
+      },
+      plugins: {
+        "@angular-eslint/template": ngeslint.templatePlugin,
+        "@simplysm": plugin,
+      },
+      rules: {
+        "@simplysm/ng-template-no-todo-comments": "warn",
+        "@angular-eslint/template/use-track-by-function": "error",
+      },
+    },
+  ),
+];

package/src/index.js

@@ -0,0 +1,7 @@
+import root from "./configs/root.js";
+
+export default {
+  configs: {
+    root,
+  },
+};

package/src/plugin.js

@@ -0,0 +1,9 @@
+import tsNoThrowNotImplementError from "./rules/ts-no-throw-not-implement-error.js";
+import ngTemplateNoTodoComments from "./rules/ng-template-no-todo-comments.js";
+
+export default {
+  rules: {
+    "ts-no-throw-not-implement-error": tsNoThrowNotImplementError,
+    "ng-template-no-todo-comments": ngTemplateNoTodoComments,
+  },
+};

package/src/rules/{ng-template-no-todo-comments.cjs → ng-template-no-todo-comments.js}

@@ -1,18 +1,18 @@
-module.exports = {
+export default {
   meta: {
     type: "suggestion",
     docs: {
-      description: "HTML의 'TODO' 주석 경고"
+      description: "HTML의 'TODO' 주석 경고",
     },
 
-    schema: []
+    schema: [],
   },
 
   create: (context) => {
     // const parserServices = context.parserServices;
     return {
       Program(node) {
-        if (node.value) {
+        if ("value" in node && typeof node.value === "string") {
           const comments = node.value.match(/<!--(((?!-->)[\s\S])*)-->/g);
           if (!comments) return;
 
@@ -33,13 +33,13 @@ module.exports = {
             context.report({
               loc: {
                 start: { line, column },
-                end: { line: endLine, column: endColumn }
+                end: { line: endLine, column: endColumn },
               },
-              message: comment.match(/<!--(((?!-->)[\s\S])*)-->/)[1].trim()
+              message: comment.match(/<!--(((?!-->)[\s\S])*)-->/)[1].trim(),
             });
           }
         }
-      }
+      },
     };
-  }
+  },
 };

package/src/rules/{ts-no-throw-not-implement-error.cjs → ts-no-throw-not-implement-error.js}

@@ -1,15 +1,16 @@
-const {AST_NODE_TYPES} = require("@typescript-eslint/utils");
+import { AST_NODE_TYPES } from "@typescript-eslint/utils";
+import { getParserServices } from "@typescript-eslint/utils/eslint-utils";
 
-module.exports = {
+export default {
   meta: {
     type: "suggestion",
     docs: {
-      description: "'NotImplementError' 사용 경고"
+      description: "'NotImplementError' 사용 경고",
     },
-    schema: []
+    schema: [],
   },
   create: (context) => {
-    const parserServices = context.parserServices;
+    const parserServices = getParserServices(context);
     const program = parserServices.program;
     const checker = program.getTypeChecker();
 
@@ -45,18 +46,15 @@ module.exports = {
     }
 
     function checkThrowArgument(node) {
-      if (
-        node.type === AST_NODE_TYPES.AwaitExpression
-        || node.type === AST_NODE_TYPES.YieldExpression
-      ) {
+      if (node.type === AST_NODE_TYPES.AwaitExpression || node.type === AST_NODE_TYPES.YieldExpression) {
         return;
       }
 
       const type = tryGetThrowArgumentType(node);
       if (type && type.getSymbol() && type.getSymbol().getName() === "NotImplementError") {
         context.report({
-          node,
-          message: node.arguments.value || "구현되어있지 않습니다" //"'NotImplementError'를 'throw'하고 있습니다."
+          node: node,
+          message: node["arguments"]["value"] || "구현되어있지 않습니다", //"'NotImplementError'를 'throw'하고 있습니다."
         });
       }
     }
@@ -66,7 +64,7 @@ module.exports = {
         if (node.argument) {
           checkThrowArgument(node.argument);
         }
-      }
+      },
     };
-  }
+  },
 };

package/src/configs/root.cjs

@@ -1,109 +0,0 @@
-module.exports = {
-  ignorePatterns: [
-    "**/node_modules/**",
-    "**/.cache/**",
-    "**/dist/**",
-    "**/.*/**",
-    "**/_*/**"
-  ],
-  env: {
-    node: true,
-    es2021: true
-  },
-  parserOptions: {
-    ecmaVersion: 2021,
-    sourceType: "module"
-  },
-  overrides: [
-    {
-      files: ["*.js", "*.cjs"],
-      plugins: ["import"],
-      rules: {
-        // import
-        "import/no-extraneous-dependencies": ["error"], // 느림
-
-        "no-console": ["warn"],
-        "no-warning-comments": ["warn"],
-
-        "require-await": ["error"],
-        "semi": ["error"],
-        "no-shadow": ["error"],
-        "no-duplicate-imports": ["error"],
-        "no-unused-expressions": ["error"],
-        "no-unused-vars": ["error"],
-        "no-undef": ["error"],
-      },
-    },
-    {
-      files: ["*.ts"],
-      plugins: [
-        "import",
-        "@simplysm",
-        "@typescript-eslint",
-        "@angular-eslint",
-        "@angular-eslint/template"
-      ],
-      parser: '@typescript-eslint/parser',
-      processor: "@angular-eslint/template/extract-inline-html",
-      settings: {
-        'import/extensions': [".js", ".cjs", ".ts"],
-        'import/external-module-folders': ['node_modules', 'node_modules/@types'],
-        'import/parsers': {
-          '@typescript-eslint/parser': [".ts"],
-        },
-        "import/resolver": {
-          "typescript": true,
-          "node": {
-            extensions: [".js", ".cjs", ".ts"]
-          }
-        }
-      },
-      rules: {
-        // 기본
-        "no-console": ["warn"],
-        "no-warning-comments": ["warn"],
-
-        // import
-        "import/no-extraneous-dependencies": ["error"], // 느림
-
-        // 타입스크립트
-        "@typescript-eslint/require-await": ["error"],
-        "@typescript-eslint/await-thenable": ["error"],
-        "@typescript-eslint/return-await": ["error", "always"],
-        "@typescript-eslint/no-floating-promises": ["error"],
-        // "@typescript-eslint/semi": ["error"], // Deprecated (https://typescript-eslint.io/rules/semi/)
-        "@typescript-eslint/no-shadow": ["error"],
-        // "@typescript-eslint/no-unnecessary-condition": ["error", {allowConstantLoopConditions: true}],
-        "@typescript-eslint/no-unnecessary-type-assertion": ["error"],
-        "@typescript-eslint/non-nullable-type-assertion-style": ["error"],
-        "@typescript-eslint/prefer-reduce-type-parameter": ["error"],
-        "@typescript-eslint/prefer-return-this-type": ["error"],
-        "@typescript-eslint/typedef": ["error"],
-        "@typescript-eslint/no-unused-expressions": ["error"],
-        "@typescript-eslint/no-unused-vars": ["error", {args: "none"}],
-        "@typescript-eslint/strict-boolean-expressions": ["error", {
-          allowNullableBoolean: true,
-          allowNullableObject: true
-        }],
-        "@typescript-eslint/prefer-ts-expect-error": ["error"],
-
-        // 심플리즘
-        "@simplysm/ts-no-throw-not-implement-error": ["warn"],
-        "@simplysm/ts-no-self-entry-import": ["error"],
-        "@simplysm/ts-no-external-import": ["error"]
-      }
-    },
-    {
-      files: ["*.html"],
-      plugins: [
-        "@angular-eslint/template",
-        "@simplysm"
-      ],
-      parser: "@angular-eslint/template-parser",
-      rules: {
-        "@simplysm/ng-template-no-todo-comments": "warn",
-        "@angular-eslint/template/use-track-by-function": "error"
-      }
-    }
-  ]
-};

package/src/index.cjs

@@ -1,11 +0,0 @@
-module.exports = {
-  configs: {
-    "root": require("./configs/root.cjs")
-  },
-  rules: {
-    "ts-no-external-import": require("./rules/ts-no-external-import.cjs"),
-    "ts-no-self-entry-import": require("./rules/ts-no-self-entry-import.cjs"),
-    "ts-no-throw-not-implement-error": require("./rules/ts-no-throw-not-implement-error.cjs"),
-    "ng-template-no-todo-comments": require("./rules/ng-template-no-todo-comments.cjs")
-  }
-};

package/src/rules/ts-no-external-import.cjs

@@ -1,72 +0,0 @@
-const resolve = require("eslint-module-utils/resolve").default;
-const path = require("path");
-const fs = require("fs");
-
-module.exports = {
-  meta: {
-    type: "problem",
-    docs: {
-      description: "패키지 외부의 파일 직접 import 금지"
-    },
-    fixable: true,
-    schema: [],
-  },
-  create: (context) => {
-    const filePath = context.getFilename();
-
-    function getPkgPath(currFilePath) {
-      let curr = path.dirname(currFilePath);
-      while (true) {
-        if (fs.existsSync(path.resolve(curr, "package.json"))) {
-          break;
-        }
-
-        curr = path.dirname(curr);
-        if (!curr) break;
-      }
-
-      return curr;
-    }
-
-    function append(node) {
-      const requirePath = node.value;
-      if (filePath !== "<text>" && requirePath.startsWith("..")) {
-        const resolvedPath = (resolve(requirePath, context) || requirePath).toLowerCase();
-        if (resolvedPath) {
-          const pkgPath = getPkgPath(filePath);
-          const relativePath = path.relative(pkgPath, resolvedPath);
-          const isChildPath = Boolean(relativePath) && !relativePath.startsWith("..") && !path.isAbsolute(relativePath);
-          if (!isChildPath) {
-            context.report({
-              node,
-              message: "패키지 외부의 파일을 직접 import 하고 있습니다.",
-              fix(fixer) {
-                const reqPkgNpmConf = JSON.parse(fs.readFileSync(path.resolve(getPkgPath(resolvedPath), "package.json"), "utf-8"));
-                return fixer.replaceText(node, `"${reqPkgNpmConf.name}"`);
-              }
-            });
-          }
-        }
-      }
-    }
-
-    return {
-      "ImportDeclaration": (node) => {
-        append(node.source);
-      },
-      "CallExpression": (node) => {
-        if (
-          node
-          && node.callee
-          && node.callee.type === "Identifier"
-          && node.callee.name === "require"
-          && node.arguments.length === 1
-          && node.arguments[0].type === "Literal"
-          && typeof node.arguments[0].value === "string"
-        ) {
-          append(node.arguments[0]);
-        }
-      }
-    };
-  }
-};

package/src/rules/ts-no-self-entry-import.cjs

@@ -1,63 +0,0 @@
-const resolve = require("eslint-module-utils/resolve").default;
-const path = require("path");
-
-module.exports = {
-  meta: {
-    type: "problem",
-    docs: {
-      description: "동일 패키지 내의 index.ts 파일 import 금지"
-    },
-    schema: []
-  },
-  create: (context) => {
-    const filePath = context.getFilename();
-    const importMap = new Map();
-
-    function append(requirePath, node) {
-      if (filePath !== "<text>" && (requirePath.endsWith(".") || requirePath.endsWith("/"))) {
-        const resolvedPath = (resolve(requirePath, context) || requirePath).toLowerCase();
-        if (resolvedPath) {
-          if (importMap.has(resolvedPath)) {
-            importMap.get(resolvedPath).push(node);
-          }
-          else {
-            importMap.set(resolvedPath, [node]);
-          }
-        }
-      }
-    }
-
-    return {
-      "ImportDeclaration": (node) => {
-        append(node.source.value, node);
-      },
-      "CallExpression": (node) => {
-        if (
-          node
-          && node.callee
-          && node.callee.type === "Identifier"
-          && node.callee.name === "require"
-          && node.arguments.length === 1
-          && node.arguments[0].type === "Literal"
-          && typeof node.arguments[0].value === "string"
-        ) {
-          append(node.arguments[0].value, node);
-        }
-      },
-      "Program:exit": () => {
-        const rootFileNames = context.parserServices.program.getRootFileNames()
-          .map((item) => path.normalize(item).toLowerCase());
-        for (const rootFileName of rootFileNames) {
-          if (importMap.has(rootFileName)) {
-            for (const node of importMap.get(rootFileName)) {
-              context.report({
-                node,
-                message: "동일 패키지상의 index.ts 파일을 import 하고 있습니다."
-              });
-            }
-          }
-        }
-      }
-    };
-  }
-};