@simplysm/eslint-plugin 10.0.65 → 11.0.3

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@simplysm/eslint-plugin",
-  "version": "10.0.65",
+  "version": "11.0.3",
   "description": "심플리즘 패키지 - ESLINT 플러그인",
   "author": "김석래",
   "repository": {
     "type": "git",
-    "url": "https://github.com/kslhunter/simplysm10.git",
+    "url": "https://github.com/kslhunter/simplysm11.git",
     "directory": "packages/eslint-plugin"
   },
   "license": "MIT",
@@ -15,6 +15,9 @@
     "node": "^16"
   },
   "dependencies": {
+    "@angular-eslint/eslint-plugin": "^16.2.0",
+    "@angular-eslint/eslint-plugin-template": "^16.2.0",
+    "@angular-eslint/template-parser": "^16.2.0",
     "@typescript-eslint/eslint-plugin": "^6.7.4",
     "@typescript-eslint/experimental-utils": "^5.62.0",
     "@typescript-eslint/parser": "^6.7.4",
@@ -22,8 +25,6 @@
     "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-module-utils": "^2.8.0",
     "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-react": "^7.33.2",
-    "eslint-plugin-react-refresh": "^0.4.3",
     "typescript": "^4.9.5"
   }
 }

package/src/configs/root.cjs

@@ -33,7 +33,7 @@ module.exports = {
         "no-undef": ["error"],
         // "linebreak-style": ["error", "unix"]
 
-        "arrow-parens": ["error"]
+        // "arrow-parens": ["error"]
       },
     },
     {
@@ -49,9 +49,9 @@ module.exports = {
         "@typescript-eslint",
         "import",
         "@simplysm",
-        "react-refresh",
-        "react"
+        "@angular-eslint"
       ],
+      processor: "@angular-eslint/template/extract-inline-html",
       settings: {
         "import/parsers": {
           "@typescript-eslint/parser": [".ts", ".tsx"]
@@ -60,25 +60,19 @@ module.exports = {
           "typescript": {
             project: "packages/*/tsconfig.json",
           }
-        },
-        "react": {
-          version: "detect"
         }
       },
       rules: {
         // 기본
         "no-console": ["warn"],
         "no-warning-comments": ["warn"],
-        "arrow-parens": ["error"],
+        // "arrow-parens": ["error"],
         // "linebreak-style": ["error", "unix"],
 
         // import
         "import/no-extraneous-dependencies": ["error"], // 느림
         // "import/no-duplicates": ["error"], // 느림
 
-        // REACT
-        "react-refresh/only-export-components": ["warn"],
-
         // 타입스크립트
         "@typescript-eslint/explicit-member-accessibility": ["error"],
         "@typescript-eslint/require-await": ["error"],
@@ -116,33 +110,21 @@ module.exports = {
         }],
         "@typescript-eslint/prefer-ts-expect-error": ["error"],
 
-        // REACT
-        "react/jsx-curly-brace-presence": ["error", {props: "always", propElementValues: "always"}],
-        "react/jsx-key": ["error", {
-          checkFragmentShorthand: true,
-          checkKeyMustBeforeSpread: true,
-          warnOnDuplicates: true
-        }],
-        "react/jsx-no-useless-fragment": "error",
-        "react/jsx-pascal-case": "error",
-        "react/jsx-wrap-multilines": ["error", {
-          "declaration": "parens",
-          "assignment": "parens",
-          "return": "parens",
-          "arrow": "parens",
-          "condition": "parens",
-          "logical": "parens",
-          "prop": "parens"
-        }],
-        "react/no-array-index-key": "error",
-        "react/no-deprecated": "warn",
-
-
         // 심플리즘
         "@simplysm/ts-no-throw-not-implement-error": ["warn"],
         "@simplysm/ts-no-self-entry-import": ["error"],
-        "@simplysm/ts-no-external-import": ["error"],
-        "@simplysm/jsx-no-prop-object": ["error"],
+        "@simplysm/ts-no-external-import": ["error"]
+      }
+    },
+    {
+      files: ["*.html"],
+      parser: "@angular-eslint/template-parser",
+      plugins: [
+        "@angular-eslint/template",
+        "@simplysm"
+      ],
+      rules: {
+        "@simplysm/ng-template-no-todo-comments": "warn"
       }
     }
   ]

package/src/index.cjs

@@ -6,6 +6,6 @@ module.exports = {
     "ts-no-external-import": require("./rules/ts-no-external-import.cjs"),
     "ts-no-self-entry-import": require("./rules/ts-no-self-entry-import.cjs"),
     "ts-no-throw-not-implement-error": require("./rules/ts-no-throw-not-implement-error.cjs"),
-    "jsx-no-prop-object": require("./rules/jsx-no-direct-object.cjs")
+    "ng-template-no-todo-comments": require("./rules/ng-template-no-todo-comments.cjs")
   }
 };

package/src/rules/ng-template-no-todo-comments.cjs

@@ -0,0 +1,45 @@
+module.exports = {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "HTML의 'TODO' 주석 경고"
+    },
+
+    schema: []
+  },
+
+  create: (context) => {
+    // const parserServices = context.parserServices;
+    return {
+      Program(node) {
+        if (node.value) {
+          const comments = node.value.match(/<!--(((?!-->)[\s\S])*)-->/g);
+          if (!comments) return;
+
+          let cursor = 0;
+          for (const comment of comments) {
+            if (!comment.includes("TODO:")) continue;
+
+            const index = node.value.slice(cursor).indexOf(comment) + cursor;
+            const line = node.value.slice(0, index).split("\n").length;
+            const column = index - node.value.slice(0, index).lastIndexOf("\n") - 1;
+
+            const endIndex = index + comment.length;
+            const endLine = node.value.slice(0, endIndex).split("\n").length;
+            const endColumn = endIndex - node.value.slice(0, endIndex).lastIndexOf("\n") - 1;
+
+            cursor += index;
+
+            context.report({
+              loc: {
+                start: { line, column },
+                end: { line: endLine, column: endColumn }
+              },
+              message: comment.match(/<!--(((?!-->)[\s\S])*)-->/)[1].trim()
+            });
+          }
+        }
+      }
+    };
+  }
+};

package/src/rules/jsx-no-direct-object.cjs

@@ -1,58 +0,0 @@
-module.exports = {
-  meta: {
-    type: "problem",
-    docs: {
-      description: "'jsx'에 직접적으로 Object/Array/Function를 입력할 수 없음",
-    },
-    fixable: false,
-    schema: [],
-  },
-  create: (context) => {
-    let scope = context.getScope();
-    let variables = scope.variables;
-
-    while (scope.type !== 'global') {
-      scope = scope.upper;
-      variables = scope.variables.concat(variables);
-    }
-    if (scope.childScopes.length) {
-      variables = scope.childScopes[0].variables.concat(variables);
-      if (scope.childScopes[0].childScopes.length) {
-        variables = scope.childScopes[0].childScopes[0].variables.concat(variables);
-      }
-    }
-    variables = variables.reverse();
-
-    return {
-      JSXExpressionContainer(node) {
-        if (
-          node.type !== 'JSXExpressionContainer'
-          || node.expression.type === "ArrayExpression"
-          || node.expression.type === "ObjectExpression"
-          || node.expression.type === "ArrowFunctionExpression"
-          || node.expression.type === "FunctionExpression"
-        ) {
-          context.report({
-            node,
-            message: "'jsx'에 직접적으로 Object/Array/Function을 넣을 수 없습니다. (필요시, $.obj, $.fn, $.getter 활용)"
-          });
-        }
-        else if (node.expression.type === "Identifier") {
-          const variable = variables.find((item) => item.name === node.expression.name);
-
-          if (
-            variable?.defs[0]?.node.init?.type === "ArrayExpression"
-            || variable?.defs[0]?.node.init?.type === "ObjectExpression"
-            || variable?.defs[0]?.node.init?.type === "ArrowFunctionExpression"
-            || variable?.defs[0]?.node.init?.type === "FunctionExpression"
-          ) {
-            context.report({
-              node,
-              message: "'jsx'에 직접적으로 Object/Array/Function을 넣을 수 없습니다. (필요시, $.obj, $.fn, $.getter 활용)"
-            });
-          }
-        }
-      }
-    };
-  },
-};