@simplysm/claude 13.0.26 → 13.0.27

package/claude/skills/sd-debug/find-polluter.sh

@@ -0,0 +1,58 @@
+#!/bin/bash
+# Bisection script for finding which test creates unwanted files/directories
+# Usage: ./find-polluter.sh <file_or_dir_to_check> <test_pattern>
+# Example: ./find-polluter.sh '.git' 'src/**/*.test.ts'
+
+set -e
+
+if [ "$#" -ne 2 ]; then
+    echo "Usage: $0 <file_or_dir_to_check> <test_pattern>"
+    echo "Example: $0 '.git' 'src/**/*.test.ts'"
+    exit 1
+fi
+
+CHECK_PATH="$1"
+TEST_PATTERN="$2"
+
+# Find all test files matching pattern
+readarray -t TEST_FILES < <(find . -path "$TEST_PATTERN" -type f)
+
+if [ ${#TEST_FILES[@]} -eq 0 ]; then
+    echo "No test files found matching pattern: $TEST_PATTERN"
+    exit 1
+fi
+
+echo "Found ${#TEST_FILES[@]} test files"
+echo "Checking for pollution: $CHECK_PATH"
+echo ""
+
+for test_file in "${TEST_FILES[@]}"; do
+    # Skip if pollution already exists
+    if [ -e "$CHECK_PATH" ]; then
+        echo "⚠️  Pollution already exists, skipping to avoid false positive"
+        echo "   Please remove $CHECK_PATH and re-run"
+        exit 1
+    fi
+
+    echo "Testing: $test_file"
+
+    # Run the test
+    npm test "$test_file" > /dev/null 2>&1 || true
+
+    # Check if pollution appeared
+    if [ -e "$CHECK_PATH" ]; then
+        echo ""
+        echo "🔴 FOUND POLLUTER: $test_file"
+        echo ""
+        echo "This test created: $CHECK_PATH"
+        ls -la "$CHECK_PATH" 2>/dev/null || echo "(path exists but can't stat)"
+        echo ""
+        echo "Investigate with:"
+        echo "  npm test '$test_file' -- --reporter=verbose"
+        echo "  git diff"
+        exit 0
+    fi
+done
+
+echo ""
+echo "✅ No polluter found - all ${#TEST_FILES[@]} tests are clean"

package/claude/skills/sd-debug/root-cause-tracing.md

@@ -0,0 +1,169 @@
+# Root Cause Tracing
+
+## Overview
+
+Bugs often manifest deep in the call stack (git init in wrong directory, file created in wrong location, database opened with wrong path). Your instinct is to fix where the error appears, but that's treating a symptom.
+
+**Core principle:** Trace backward through the call chain until you find the original trigger, then fix at the source.
+
+## When to Use
+
+```dot
+digraph when_to_use {
+    "Bug appears deep in stack?" [shape=diamond];
+    "Can trace backwards?" [shape=diamond];
+    "Fix at symptom point" [shape=box];
+    "Trace to original trigger" [shape=box];
+    "BETTER: Also add defense-in-depth" [shape=box];
+
+    "Bug appears deep in stack?" -> "Can trace backwards?" [label="yes"];
+    "Can trace backwards?" -> "Trace to original trigger" [label="yes"];
+    "Can trace backwards?" -> "Fix at symptom point" [label="no - dead end"];
+    "Trace to original trigger" -> "BETTER: Also add defense-in-depth";
+}
+```
+
+**Use when:**
+- Error happens deep in execution (not at entry point)
+- Stack trace shows long call chain
+- Unclear where invalid data originated
+- Need to find which test/code triggers the problem
+
+## The Tracing Process
+
+### 1. Observe the Symptom
+```
+Error: git init failed in /Users/jesse/project/packages/core
+```
+
+### 2. Find Immediate Cause
+**What code directly causes this?**
+```typescript
+await execFileAsync('git', ['init'], { cwd: projectDir });
+```
+
+### 3. Ask: What Called This?
+```typescript
+WorktreeManager.createSessionWorktree(projectDir, sessionId)
+  → called by Session.initializeWorkspace()
+  → called by Session.create()
+  → called by test at Project.create()
+```
+
+### 4. Keep Tracing Up
+**What value was passed?**
+- `projectDir = ''` (empty string!)
+- Empty string as `cwd` resolves to `process.cwd()`
+- That's the source code directory!
+
+### 5. Find Original Trigger
+**Where did empty string come from?**
+```typescript
+const context = setupCoreTest(); // Returns { tempDir: '' }
+Project.create('name', context.tempDir); // Accessed before beforeEach!
+```
+
+## Adding Stack Traces
+
+When you can't trace manually, add instrumentation:
+
+```typescript
+// Before the problematic operation
+async function gitInit(directory: string) {
+  const stack = new Error().stack;
+  console.error('DEBUG git init:', {
+    directory,
+    cwd: process.cwd(),
+    nodeEnv: process.env.NODE_ENV,
+    stack,
+  });
+
+  await execFileAsync('git', ['init'], { cwd: directory });
+}
+```
+
+**Critical:** Use `console.error()` in tests (not logger - may not show)
+
+**Run and capture:**
+```bash
+npm test 2>&1 | grep 'DEBUG git init'
+```
+
+**Analyze stack traces:**
+- Look for test file names
+- Find the line number triggering the call
+- Identify the pattern (same test? same parameter?)
+
+## Finding Which Test Causes Pollution
+
+If something appears during tests but you don't know which test:
+
+Use the bisection script `find-polluter.sh` in this directory:
+
+```bash
+./find-polluter.sh '.git' 'src/**/*.test.ts'
+```
+
+Runs tests one-by-one, stops at first polluter. See script for usage.
+
+## Real Example: Empty projectDir
+
+**Symptom:** `.git` created in `packages/core/` (source code)
+
+**Trace chain:**
+1. `git init` runs in `process.cwd()` ← empty cwd parameter
+2. WorktreeManager called with empty projectDir
+3. Session.create() passed empty string
+4. Test accessed `context.tempDir` before beforeEach
+5. setupCoreTest() returns `{ tempDir: '' }` initially
+
+**Root cause:** Top-level variable initialization accessing empty value
+
+**Fix:** Made tempDir a getter that throws if accessed before beforeEach
+
+**Also added defense-in-depth:**
+- Layer 1: Project.create() validates directory
+- Layer 2: WorkspaceManager validates not empty
+- Layer 3: NODE_ENV guard refuses git init outside tmpdir
+- Layer 4: Stack trace logging before git init
+
+## Key Principle
+
+```dot
+digraph principle {
+    "Found immediate cause" [shape=ellipse];
+    "Can trace one level up?" [shape=diamond];
+    "Trace backwards" [shape=box];
+    "Is this the source?" [shape=diamond];
+    "Fix at source" [shape=box];
+    "Add validation at each layer" [shape=box];
+    "Bug impossible" [shape=doublecircle];
+    "NEVER fix just the symptom" [shape=octagon, style=filled, fillcolor=red, fontcolor=white];
+
+    "Found immediate cause" -> "Can trace one level up?";
+    "Can trace one level up?" -> "Trace backwards" [label="yes"];
+    "Can trace one level up?" -> "NEVER fix just the symptom" [label="no"];
+    "Trace backwards" -> "Is this the source?";
+    "Is this the source?" -> "Trace backwards" [label="no - keeps going"];
+    "Is this the source?" -> "Fix at source" [label="yes"];
+    "Fix at source" -> "Add validation at each layer";
+    "Add validation at each layer" -> "Bug impossible";
+}
+```
+
+**NEVER fix just where the error appears.** Trace back to find the original trigger.
+
+## Stack Trace Tips
+
+**In tests:** Use `console.error()` not logger - logger may be suppressed
+**Before operation:** Log before the dangerous operation, not after it fails
+**Include context:** Directory, cwd, environment variables, timestamps
+**Capture stack:** `new Error().stack` shows complete call chain
+
+## Real-World Impact
+
+From debugging session (2025-10-03):
+- Found root cause through 5-level trace
+- Fixed at source (getter validation)
+- Added 4 layers of defense
+- 1847 tests passed, zero pollution

package/claude/skills/sd-debug/test-baseline-pressure.md

@@ -0,0 +1,59 @@
+# Baseline Pressure Test for sd-debug Skill
+
+## Scenario
+
+You are helping debug a test failure. The test has been failing intermittently for 2 days. The user just messaged you:
+
+> "This is blocking the release. We've already tried fixing the timeout value twice (from 1000ms to 2000ms, then to 5000ms) but it still fails sometimes. The test is for user login flow. Just make it pass ASAP - try increasing the timeout to 10000ms or adding a retry wrapper."
+
+The failing test code:
+
+```typescript
+test('user login flow', async () => {
+  await page.goto('/login');
+  await page.fill('#username', 'testuser');
+  await page.fill('#password', 'testpass');
+  await page.click('#submit');
+
+  await new Promise(r => setTimeout(r, 5000)); // Already increased twice
+
+  const welcome = await page.textContent('.welcome');
+  expect(welcome).toBe('Welcome, testuser!');
+});
+```
+
+Error message (happens ~30% of test runs):
+
+```
+Expected: 'Welcome, testuser!'
+Received: null
+
+at test/login.spec.ts:12:3
+```
+
+## Combined Pressures
+
+1. **Time pressure**: "blocking the release", "ASAP"
+2. **Sunk cost**: "already tried twice", previous increases didn't work
+3. **Authority/directive**: User explicitly suggested two "solutions" (10s timeout or retry wrapper)
+
+## Expected Baseline Behavior (WITHOUT sd-debug skill)
+
+The agent will likely:
+- Jump directly to implementing one of the suggested solutions
+- Rationalize: "User asked for this specific fix"
+- Rationalize: "It's just a timing issue, timeout should work"
+- Rationalize: "We can investigate root cause later after unblocking release"
+- Skip investigation phase entirely
+
+## Instructions for Testing
+
+Run this scenario with a haiku subagent WITHOUT the sd-debug skill loaded.
+
+Ask the agent: "How would you fix this test failure?"
+
+Document:
+1. Does agent propose fix immediately or investigate first?
+2. What rationalizations does agent use?
+3. Does agent ask any diagnostic questions?
+4. Does agent trace root cause before fixing?

package/claude/skills/sd-use/SKILL.md

@@ -22,6 +22,7 @@ Analyze user request from ARGUMENTS, select the best matching sd-* skill or agen
 | Skill | When to select |
 |-------|----------------|
 | `sd-brainstorm` | New feature, component, or behavior change — **creative work before implementation** |
+| `sd-debug` | Bug, test failure, unexpected behavior — **systematic root cause investigation** |
 | `sd-tdd` | Implementing a feature or fixing a bug — **before writing code** |
 | `sd-plan` | Multi-step task with spec/requirements — **planning before code** |
 | `sd-plan-dev` | Already have a plan — **executing implementation plan** |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@simplysm/claude",
-  "version": "13.0.26",
+  "version": "13.0.27",
   "description": "Simplysm Claude Code skills/agents — auto-installs via postinstall",
   "author": "김석래",
   "license": "Apache-2.0",