@simplysm/claude 13.0.24 → 13.0.25
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/claude/agents/sd-api-reviewer.md +1 -1
- package/claude/agents/sd-code-reviewer.md +1 -1
- package/claude/agents/sd-code-simplifier.md +1 -1
- package/claude/agents/sd-security-reviewer.md +1 -1
- package/claude/skills/sd-brainstorm/SKILL.md +1 -1
- package/claude/skills/sd-check/SKILL.md +66 -24
- package/claude/skills/sd-plan/SKILL.md +1 -1
- package/claude/skills/sd-tdd/SKILL.md +1 -1
- package/package.json +1 -1
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: sd-api-reviewer
|
|
3
3
|
description: Reviews a library's public API for developer experience (DX) quality - naming consistency, industry standard alignment, intuitiveness, error messages, type hints, configuration complexity, and usage pattern coherence
|
|
4
|
-
model:
|
|
4
|
+
model: opus
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
You are an expert API/DX reviewer who evaluates libraries from the **consumer's perspective**. Your goal is to identify friction points that developers encounter when using a package.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: sd-code-reviewer
|
|
3
3
|
description: Reviews code for bugs, logic errors, security vulnerabilities, code quality issues, and adherence to project conventions, using confidence-based filtering to report only high-priority issues that truly matter
|
|
4
|
-
model:
|
|
4
|
+
model: opus
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
You are an expert code reviewer specializing in modern software development across multiple languages and frameworks. Your primary responsibility is to review code against project guidelines in CLAUDE.md with high precision to minimize false positives.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: sd-code-simplifier
|
|
3
3
|
description: Simplifies and refines code for clarity, consistency, and maintainability while preserving all functionality. Focuses on recently modified code unless instructed otherwise.
|
|
4
|
-
model:
|
|
4
|
+
model: opus
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
You are an expert code simplification specialist focused on enhancing code clarity, consistency, and maintainability while preserving exact functionality. Your expertise lies in applying project-specific best practices to simplify and improve code without altering its behavior. You prioritize readable, explicit code over overly compact solutions. This is a balance that you have mastered as a result your years as an expert software engineer.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: sd-security-reviewer
|
|
3
3
|
description: Reviews ORM queries and service endpoints for SQL injection and input validation vulnerabilities in simplysm's string-escaping ORM
|
|
4
|
-
model:
|
|
4
|
+
model: opus
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
You are a security-focused code reviewer for the simplysm framework.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: sd-brainstorm
|
|
3
3
|
description: "You MUST use this before any creative work - creating features, building components, adding functionality, or modifying behavior. Explores user intent, requirements and design before implementation."
|
|
4
|
-
model:
|
|
4
|
+
model: opus
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
# Brainstorming Ideas Into Designs
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: sd-check
|
|
3
3
|
description: Verify code via typecheck, lint, and tests
|
|
4
4
|
argument-hint: "[path]"
|
|
5
|
-
model:
|
|
5
|
+
model: opus
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
## Usage
|
|
@@ -59,43 +59,85 @@ If all pre-checks pass, report "Environment OK" and proceed to code verification
|
|
|
59
59
|
|
|
60
60
|
## Code Verification
|
|
61
61
|
|
|
62
|
-
Run
|
|
63
|
-
|
|
64
|
-
Repeat until no errors remain, then proceed to the next step.
|
|
62
|
+
Run verification checks using haiku agents for command execution, then analyze and fix errors.
|
|
63
|
+
Repeat until all checks pass.
|
|
65
64
|
|
|
66
|
-
### Step 1:
|
|
65
|
+
### Step 1: Launch Verification Agents (Parallel)
|
|
67
66
|
|
|
67
|
+
Launch 3 haiku agents in parallel using the Task tool.
|
|
68
|
+
|
|
69
|
+
**Important**: Replace `[path]` in the commands below with the actual path argument provided by the user. If no argument was provided, omit the path (runs on entire project).
|
|
70
|
+
|
|
71
|
+
**Agent 1 - Typecheck:**
|
|
68
72
|
```
|
|
69
|
-
|
|
73
|
+
Task tool with:
|
|
74
|
+
subagent_type: Bash
|
|
75
|
+
model: haiku
|
|
76
|
+
description: "Run typecheck"
|
|
77
|
+
prompt: "Run `pnpm typecheck [path]` and return the full output. Do NOT analyze or fix errors - just report the raw output."
|
|
70
78
|
```
|
|
71
79
|
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
80
|
+
**Agent 2 - Lint:**
|
|
81
|
+
```
|
|
82
|
+
Task tool with:
|
|
83
|
+
subagent_type: Bash
|
|
84
|
+
model: haiku
|
|
85
|
+
description: "Run lint with auto-fix"
|
|
86
|
+
prompt: "Run `pnpm lint --fix [path]` and return the full output. Do NOT analyze or fix errors - just report the raw output."
|
|
87
|
+
```
|
|
75
88
|
|
|
89
|
+
**Agent 3 - Test:**
|
|
76
90
|
```
|
|
77
|
-
|
|
91
|
+
Task tool with:
|
|
92
|
+
subagent_type: Bash
|
|
93
|
+
model: haiku
|
|
94
|
+
description: "Run tests"
|
|
95
|
+
prompt: "Run `pnpm vitest [path] --run` and return the full output. Do NOT analyze or fix errors - just report the raw output."
|
|
78
96
|
```
|
|
79
97
|
|
|
80
|
-
|
|
98
|
+
### Step 2: Collect Results and Fix Errors
|
|
81
99
|
|
|
82
|
-
|
|
100
|
+
Wait for all 3 agents to complete. Collect their outputs.
|
|
83
101
|
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
102
|
+
If any errors are found:
|
|
103
|
+
|
|
104
|
+
1. **Analyze errors by priority**: typecheck → lint → test
|
|
105
|
+
- Typecheck errors may cause lint/test errors, so fix them first
|
|
106
|
+
2. **Read failing files** to identify root causes
|
|
107
|
+
3. **Fix with Edit**:
|
|
108
|
+
- Typecheck errors: Fix type issues
|
|
109
|
+
- Lint errors: Fix linting issues (most should be auto-fixed by `--fix`)
|
|
110
|
+
- Test failures:
|
|
111
|
+
- Run `git diff` to check for intentional code changes
|
|
112
|
+
- If intentional changes not reflected in tests: Update test code
|
|
113
|
+
- If source code bug: Fix source code
|
|
114
|
+
4. Proceed to Step 3
|
|
115
|
+
|
|
116
|
+
If all checks passed: Proceed to Completion.
|
|
117
|
+
|
|
118
|
+
### Step 3: Re-verify (Loop)
|
|
119
|
+
|
|
120
|
+
Go back to Step 1 and launch the 3 haiku agents again.
|
|
121
|
+
Repeat until all checks pass with no errors.
|
|
122
|
+
|
|
123
|
+
## Common Mistakes
|
|
124
|
+
|
|
125
|
+
### Running checks sequentially instead of parallel
|
|
126
|
+
❌ **Wrong**: Launch agent 1, wait, then agent 2, wait, then agent 3
|
|
127
|
+
✅ **Right**: Launch all 3 agents in a single message with multiple Task tool calls
|
|
87
128
|
|
|
88
|
-
|
|
89
|
-
|
|
129
|
+
### Fixing before collecting all results
|
|
130
|
+
❌ **Wrong**: Agent 1 returns error → fix immediately → launch agents again
|
|
131
|
+
✅ **Right**: Wait for all 3 agents → collect all errors → fix in priority order → re-verify
|
|
90
132
|
|
|
91
|
-
|
|
133
|
+
### Skipping re-verification after fixes
|
|
134
|
+
❌ **Wrong**: Fix typecheck error → assume lint/test still pass
|
|
135
|
+
✅ **Right**: Always re-run all 3 checks after any fix (fixes can introduce new errors)
|
|
92
136
|
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
- **Source code bug**: Fix the source code.
|
|
97
|
-
3. Re-run tests after the fix.
|
|
137
|
+
### Using wrong model for agents
|
|
138
|
+
❌ **Wrong**: `model: opus` or `model: sonnet` for verification agents
|
|
139
|
+
✅ **Right**: `model: haiku` for command execution (cheaper, faster)
|
|
98
140
|
|
|
99
141
|
## Completion Criteria
|
|
100
142
|
|
|
101
|
-
Complete when all 3
|
|
143
|
+
Complete when all 3 checks pass without errors.
|