@simonren/quorum 0.8.0 → 0.8.1

package/dist/adapters/claude.js

@@ -124,27 +124,30 @@ export class ClaudeAdapter {
         const result = await executor.run();
         const elapsed = Math.round((Date.now() - cliStartTime) / 1000);
         console.error(`[claude] ✓ complete (${elapsed}s)`);
-        // Check for errors captured from stream events
+        // Prefer a completed response over a captured error: a non-fatal error event
+        // that precedes a successful agent_message must not discard the result (same
+        // class of bug fixed in the codex adapter). Only treat a decoder error as
+        // fatal when no final response was produced.
+        const finalResponse = decoder.getFinalResponse();
+        if (finalResponse) {
+            return {
+                stdout: finalResponse,
+                stderr: result.stderr,
+                exitCode: result.exitCode,
+                truncated: result.truncated,
+            };
+        }
         const decoderError = decoder.getError();
         if (decoderError) {
             const combined = result.stderr ? `${decoderError}\n\nCLI stderr: ${result.stderr}` : decoderError;
             return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
         }
-        const finalResponse = decoder.getFinalResponse();
-        if (!finalResponse && decoder.hasNoOutput()) {
+        if (decoder.hasNoOutput()) {
             const combined = result.stderr ? `No output from Claude\n\nCLI stderr: ${result.stderr}` : 'No output from Claude';
             return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
         }
-        if (!finalResponse) {
-            const combined = result.stderr ? `No result event from Claude\n\nCLI stderr: ${result.stderr}` : 'No result event from Claude';
-            return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
-        }
-        return {
-            stdout: finalResponse,
-            stderr: result.stderr,
-            exitCode: result.exitCode,
-            truncated: result.truncated,
-        };
+        const combined = result.stderr ? `No result event from Claude\n\nCLI stderr: ${result.stderr}` : 'No result event from Claude';
+        return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
     }
     handleException(error, startTime) {
         const err = error;

package/dist/adapters/codex.js

@@ -125,27 +125,45 @@ export class CodexAdapter {
         const result = await executor.run();
         const elapsed = Math.round((Date.now() - cliStartTime) / 1000);
         console.error(`[codex] ✓ complete (${elapsed}s)`);
-        // Check for errors captured from JSONL events
+        // A genuine fatal error (a top-level `error` event or `turn.failed`) is
+        // TERMINAL and wins even when a — possibly intermediate/stale — agent_message
+        // exists. `--full-auto` runs a multi-turn loop, so a turn can emit a message
+        // and a later turn can fail; without this check, that failure would be
+        // reported as a successful review with stale content.
+        const fatalError = decoder.getFatalError();
+        if (fatalError) {
+            const combined = result.stderr ? `${fatalError}\n\nCLI stderr: ${result.stderr}` : fatalError;
+            return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
+        }
+        // No fatal error: a completed response wins even if a NON-fatal error-item
+        // appeared earlier. Codex emits its "Skill descriptions were shortened to fit
+        // the 2% skills context budget" notice as an item.completed/type:error event —
+        // purely informational ("Codex can still see every skill"); the turn still
+        // completes and produces an agent_message. Use `!== null` (not truthiness) so
+        // an empty-string response is preserved for the caller's empty-response
+        // handling rather than misclassified as "no result event".
+        // (Checking getError() first discarded otherwise-successful reviews.)
+        const finalResponse = decoder.getFinalResponse();
+        if (finalResponse !== null) {
+            return {
+                stdout: finalResponse,
+                stderr: result.stderr,
+                exitCode: result.exitCode,
+                truncated: result.truncated,
+            };
+        }
+        // No response: surface a non-fatal item-level error if one was captured.
         const decoderError = decoder.getError();
         if (decoderError) {
             const combined = result.stderr ? `${decoderError}\n\nCLI stderr: ${result.stderr}` : decoderError;
             return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
         }
-        const finalResponse = decoder.getFinalResponse();
-        if (!finalResponse && decoder.hasNoOutput()) {
+        if (decoder.hasNoOutput()) {
             const combined = result.stderr ? `No output from Codex\n\nCLI stderr: ${result.stderr}` : 'No output from Codex';
             return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
         }
-        if (!finalResponse) {
-            const combined = result.stderr ? `No result event from Codex\n\nCLI stderr: ${result.stderr}` : 'No result event from Codex';
-            return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
-        }
-        return {
-            stdout: finalResponse,
-            stderr: result.stderr,
-            exitCode: result.exitCode,
-            truncated: result.truncated,
-        };
+        const combined = result.stderr ? `No result event from Codex\n\nCLI stderr: ${result.stderr}` : 'No result event from Codex';
+        return { stdout: '', stderr: combined, exitCode: 1, truncated: false };
     }
     handleException(error, startTime) {
         const err = error;

package/dist/decoders/codex.d.ts

@@ -43,6 +43,7 @@ export declare class CodexEventDecoder {
     private _finalResponse;
     private _usage;
     private _error;
+    private _fatalError;
     private _eventCount;
     /**
      * Parse a single JSONL line. Silently skips malformed or empty input.
@@ -59,9 +60,18 @@ export declare class CodexEventDecoder {
      */
     getUsage(): CodexEvent['usage'] | null;
     /**
-     * Returns the error message from `error` or `turn.failed` events, or `null`.
+     * Returns the error message from any source — a top-level `error`, a
+     * `turn.failed`, or a non-fatal item-level error notice — or `null`.
+     * Superset of `getFatalError()`.
      */
     getError(): string | null;
+    /**
+     * Returns the message from a TERMINAL fatal error only — a top-level `error`
+     * event or `turn.failed` — or `null`. The benign item-level error notice
+     * (e.g. the "skills shortened" budget message) is NOT fatal and is excluded,
+     * so a successful turn can win over it without masking a genuine failure.
+     */
+    getFatalError(): string | null;
     /**
      * Returns true if events were received but no agent_message was produced.
      * Combined with a fast exit, this indicates rate limiting or instant rejection.

package/dist/decoders/codex.js

@@ -25,8 +25,14 @@ export class CodexEventDecoder {
     _finalResponse = null;
     // Token usage from the most recently seen turn.completed
     _usage = null;
-    // Error message from error/turn.failed events
+    // Error message from ANY source (top-level error, turn.failed, or a non-fatal
+    // item-level error notice). Superset of _fatalError.
     _error = null;
+    // Error message from a TERMINAL fatal source ONLY: a top-level `error` event
+    // or `turn.failed`. Kept separate from the benign item-level error notice
+    // (e.g. Codex's "skills shortened" budget message) so the adapter can let a
+    // completed response override the benign notice WITHOUT masking a real failure.
+    _fatalError = null;
     // Count of events received (0 = possible rate limit / instant rejection)
     _eventCount = 0;
     // =============================================================================
@@ -68,11 +74,22 @@ export class CodexEventDecoder {
         return this._usage;
     }
     /**
-     * Returns the error message from `error` or `turn.failed` events, or `null`.
+     * Returns the error message from any source — a top-level `error`, a
+     * `turn.failed`, or a non-fatal item-level error notice — or `null`.
+     * Superset of `getFatalError()`.
      */
     getError() {
         return this._error;
     }
+    /**
+     * Returns the message from a TERMINAL fatal error only — a top-level `error`
+     * event or `turn.failed` — or `null`. The benign item-level error notice
+     * (e.g. the "skills shortened" budget message) is NOT fatal and is excluded,
+     * so a successful turn can win over it without masking a genuine failure.
+     */
+    getFatalError() {
+        return this._fatalError;
+    }
     /**
      * Returns true if events were received but no agent_message was produced.
      * Combined with a fast exit, this indicates rate limiting or instant rejection.
@@ -95,14 +112,19 @@ export class CodexEventDecoder {
         if (event.type === 'turn.completed' && event.usage != null) {
             this._usage = event.usage;
         }
-        // Capture errors from error/turn.failed events
+        // Capture errors. A top-level `error` event and `turn.failed` are TERMINAL
+        // failures — record them as fatal (and in the general _error superset).
         if (event.type === 'error') {
             this._error = event.message || 'Unknown error from Codex';
+            this._fatalError = this._error;
         }
         if (event.type === 'turn.failed') {
             this._error = event.error?.message || 'Turn failed';
+            this._fatalError = this._error;
         }
-        // Capture error items (e.g. model errors reported as item.completed with type=error)
+        // An item.completed/type:error is a NON-fatal notice (e.g. the "skills
+        // shortened" budget message, or a per-item model error). Record it only in
+        // the general _error bucket — never as fatal — so it cannot mask a response.
         if (event.type === 'item.completed' && event.item?.type === 'error') {
             this._error = event.item.message || event.item.text || 'Model error';
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@simonren/quorum",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "MCP server for Claude Code — a quorum of AI models (Codex, Gemini, Claude) for adversarial review and consultation, synthesized by Claude Code",
   "type": "module",
   "main": "dist/index.js",