@silverbulletmd/silverbullet 2.4.2 → 2.6.1

package/client/space_lua/stdlib/string_pack.ts

@@ -0,0 +1,490 @@
+import {
+  LuaBuiltinFunction,
+  LuaMultiRes,
+  LuaRuntimeError,
+} from "../runtime.ts";
+
+import { isTaggedFloat } from "../numeric.ts";
+
+function untagN(x: any): number {
+  if (typeof x === "number") return x;
+  if (isTaggedFloat(x)) return x.value;
+  return Number(x);
+}
+
+const NATIVE_LITTLE = new Uint8Array(new Uint16Array([1]).buffer)[0] === 1;
+const NATIVE_MAXALIGN = 8; // JS doubles are 8-byte aligned
+
+type KOption =
+  | "int"
+  | "uint"
+  | "float"
+  | "double"
+  | "number"
+  | "char"
+  | "string"
+  | "zstr"
+  | "padding"
+  | "paddalign"
+  | "nop";
+
+interface ParsedOption {
+  opt: KOption;
+  size: number; // byte width
+  ntoalign: number; // padding bytes before this field
+}
+
+interface Header {
+  islittle: boolean;
+  maxalign: number;
+}
+
+function makeHeader(): Header {
+  return { islittle: NATIVE_LITTLE, maxalign: NATIVE_MAXALIGN };
+}
+
+// Read digits from fmt starting at pos; return [value, newPos]
+function readNum(fmt: string, pos: number, dflt: number): [number, number] {
+  if (pos >= fmt.length || fmt[pos] < "0" || fmt[pos] > "9") return [dflt, pos];
+  let v = 0;
+  while (pos < fmt.length && fmt[pos] >= "0" && fmt[pos] <= "9") {
+    v = v * 10 + (fmt.charCodeAt(pos) - 48);
+    pos++;
+  }
+  return [v, pos];
+}
+
+function numLimit(
+  fmt: string,
+  pos: number,
+  dflt: number,
+  src: string,
+): [number, number] {
+  const [sz, np] = readNum(fmt, pos, dflt);
+  if (sz < 1 || sz > 16) {
+    throw new Error(`integral size (${sz}) out of limits [1,16] in '${src}'`);
+  }
+  return [sz, np];
+}
+
+// Parse one option from fmt[pos], return [parsed, newPos]
+// Modifies header in place for '<', '>', '=', '!'
+function getOption(
+  fmt: string,
+  pos: number,
+  h: Header,
+): [KOption, number, number] {
+  // [opt, size, newPos]
+  const c = fmt[pos++];
+  switch (c) {
+    case "b":
+      return ["int", 1, pos];
+    case "B":
+      return ["uint", 1, pos];
+    case "h":
+      return ["int", 2, pos];
+    case "H":
+      return ["uint", 2, pos];
+    case "l":
+      return ["int", 8, pos];
+    case "L":
+      return ["uint", 8, pos];
+    case "j":
+      return ["int", 8, pos];
+    case "J":
+      return ["uint", 8, pos];
+    case "T":
+      return ["uint", 8, pos];
+    case "f":
+      return ["float", 4, pos];
+    case "n":
+      return ["number", 8, pos];
+    case "d":
+      return ["double", 8, pos];
+    case "i": {
+      const [sz, np] = numLimit(fmt, pos, 4, "i");
+      return ["int", sz, np];
+    }
+    case "I": {
+      const [sz, np] = numLimit(fmt, pos, 4, "I");
+      return ["uint", sz, np];
+    }
+    case "s": {
+      const [sz, np] = numLimit(fmt, pos, 8, "s");
+      return ["string", sz, np];
+    }
+    case "c": {
+      const [sz, np] = readNum(fmt, pos, -1);
+      if (sz === -1) throw new Error("missing size for format option 'c'");
+      return ["char", sz, np];
+    }
+    case "z":
+      return ["zstr", 0, pos];
+    case "x":
+      return ["padding", 1, pos];
+    case "X":
+      return ["paddalign", 0, pos];
+    case " ":
+      return ["nop", 0, pos];
+    case "<":
+      h.islittle = true;
+      return ["nop", 0, pos];
+    case ">":
+      h.islittle = false;
+      return ["nop", 0, pos];
+    case "=":
+      h.islittle = NATIVE_LITTLE;
+      return ["nop", 0, pos];
+    case "!": {
+      const [sz, np] = readNum(fmt, pos, NATIVE_MAXALIGN);
+      h.maxalign = sz;
+      return ["nop", 0, np];
+    }
+    default:
+      throw new Error(`invalid format option '${c}'`);
+  }
+}
+
+// Compute alignment padding
+function getDetails(
+  fmt: string,
+  pos: number,
+  h: Header,
+  totalsize: number,
+): [ParsedOption, number] {
+  let opt: KOption, size: number;
+  [opt, size, pos] = getOption(fmt, pos, h);
+
+  let align = size;
+
+  if (opt === "paddalign") {
+    if (pos >= fmt.length) {
+      throw new Error("invalid next option for option 'X'");
+    }
+    const hCopy = { ...h };
+    let nextOpt: KOption, nextSize: number;
+    [nextOpt, nextSize, pos] = getOption(fmt, pos, hCopy);
+    if (nextOpt === "char" || nextSize === 0) {
+      throw new Error("invalid next option for option 'X'");
+    }
+    align = nextSize;
+  }
+
+  let ntoalign = 0;
+  if (
+    opt !== "char" &&
+    opt !== "nop" &&
+    opt !== "padding" &&
+    opt !== "paddalign"
+  ) {
+    const realign = Math.min(align, h.maxalign);
+    if (realign > 0) {
+      ntoalign = (realign - (totalsize % realign)) % realign;
+    }
+  }
+
+  return [{ opt, size, ntoalign }, pos];
+}
+
+function packInt(v: bigint, size: number, islittle: boolean): Uint8Array {
+  const buf = new Uint8Array(size);
+  let val = v;
+  // Two's complement mask
+  const mask = (1n << BigInt(size * 8)) - 1n;
+  val = ((val % (mask + 1n)) + (mask + 1n)) & mask; // normalise to unsigned
+  for (let i = 0; i < size; i++) {
+    buf[islittle ? i : size - 1 - i] = Number(val & 0xffn);
+    val >>= 8n;
+  }
+  return buf;
+}
+
+function unpackInt(
+  buf: Uint8Array,
+  pos: number,
+  size: number,
+  islittle: boolean,
+  issigned: boolean,
+): bigint {
+  let res = 0n;
+  const limit = Math.min(size, 8);
+  for (let i = limit - 1; i >= 0; i--) {
+    res = (res << 8n) | BigInt(buf[pos + (islittle ? i : size - 1 - i)]);
+  }
+  if (issigned && size <= 8) {
+    const mask = 1n << BigInt(size * 8 - 1);
+    if (res & mask) res -= mask << 1n;
+  }
+  return res;
+}
+
+function packFloat32(v: number, islittle: boolean): Uint8Array {
+  const buf = new ArrayBuffer(4);
+  new DataView(buf).setFloat32(0, v, islittle);
+  return new Uint8Array(buf);
+}
+
+function unpackFloat32(
+  buf: Uint8Array,
+  pos: number,
+  islittle: boolean,
+): number {
+  return new DataView(buf.buffer, buf.byteOffset + pos, 4).getFloat32(
+    0,
+    islittle,
+  );
+}
+
+function packFloat64(v: number, islittle: boolean): Uint8Array {
+  const buf = new ArrayBuffer(8);
+  new DataView(buf).setFloat64(0, v, islittle);
+  return new Uint8Array(buf);
+}
+
+function unpackFloat64(
+  buf: Uint8Array,
+  pos: number,
+  islittle: boolean,
+): number {
+  return new DataView(buf.buffer, buf.byteOffset + pos, 8).getFloat64(
+    0,
+    islittle,
+  );
+}
+
+export const strPackFn = new LuaBuiltinFunction(
+  (sf, fmt: string, ...args: any[]) => {
+    const h = makeHeader();
+    const parts: Uint8Array[] = [];
+    let totalsize = 0;
+    let argIdx = 0;
+
+    let pos = 0;
+    while (pos < fmt.length) {
+      let opt: ParsedOption;
+      [opt, pos] = getDetails(fmt, pos, h, totalsize);
+
+      // alignment padding
+      if (opt.ntoalign > 0) {
+        parts.push(new Uint8Array(opt.ntoalign));
+        totalsize += opt.ntoalign;
+      }
+
+      switch (opt.opt) {
+        case "nop":
+        case "paddalign":
+          break;
+
+        case "padding":
+          parts.push(new Uint8Array(1)); // LUAL_PACKPADBYTE = 0
+          totalsize += 1;
+          break;
+
+        case "int":
+        case "uint": {
+          const v = args[argIdx++];
+          if (v === undefined || v === null) {
+            throw new LuaRuntimeError(
+              `bad argument #${argIdx} to 'pack' (value expected)`,
+              sf,
+            );
+          }
+          let bi: bigint;
+          if (typeof v === "bigint") bi = v;
+          else bi = BigInt(Math.trunc(untagN(v)));
+          parts.push(packInt(bi, opt.size, h.islittle));
+          totalsize += opt.size;
+          break;
+        }
+
+        case "float": {
+          const v = untagN(args[argIdx++]);
+          parts.push(packFloat32(v, h.islittle));
+          totalsize += 4;
+          break;
+        }
+
+        case "double":
+        case "number": {
+          const v = untagN(args[argIdx++]);
+          parts.push(packFloat64(v, h.islittle));
+          totalsize += 8;
+          break;
+        }
+
+        case "char": {
+          const s: string = String(args[argIdx++]);
+          const enc = new TextEncoder().encode(s);
+          const buf = new Uint8Array(opt.size);
+          buf.set(enc.subarray(0, opt.size));
+          parts.push(buf);
+          totalsize += opt.size;
+          break;
+        }
+
+        case "string": {
+          const s: string = String(args[argIdx++]);
+          const enc = new TextEncoder().encode(s);
+          const lenBuf = packInt(BigInt(enc.length), opt.size, h.islittle);
+          parts.push(lenBuf);
+          parts.push(enc);
+          totalsize += opt.size + enc.length;
+          break;
+        }
+
+        case "zstr": {
+          const s: string = String(args[argIdx++]);
+          if (s.includes("\0")) {
+            throw new LuaRuntimeError(
+              "string contains zeros for format 'z'",
+              sf,
+            );
+          }
+          const enc = new TextEncoder().encode(s);
+          parts.push(enc);
+          parts.push(new Uint8Array(1)); // null terminator
+          totalsize += enc.length + 1;
+          break;
+        }
+      }
+    }
+
+    // Concatenate all parts into one binary string (latin-1 encoding)
+    let total = 0;
+    for (const p of parts) total += p.length;
+    const out = new Uint8Array(total);
+    let off = 0;
+    for (const p of parts) {
+      out.set(p, off);
+      off += p.length;
+    }
+
+    // Return as a Lua binary string (each byte is a char code 0-255)
+    let result = "";
+    for (let i = 0; i < out.length; i++) result += String.fromCharCode(out[i]);
+    return result;
+  },
+);
+
+export const strUnpackFn = new LuaBuiltinFunction(
+  (sf, fmt: string, data: string, init?: number) => {
+    const h = makeHeader();
+
+    const buf = new Uint8Array(data.length);
+    for (let i = 0; i < data.length; i++) {
+      buf[i] = data.charCodeAt(i) & 0xff;
+    }
+
+    let pos = (init !== undefined && init !== null ? init : 1) - 1;
+    const results: any[] = [];
+
+    let fmtPos = 0;
+    while (fmtPos < fmt.length) {
+      let opt: ParsedOption;
+      [opt, fmtPos] = getDetails(fmt, fmtPos, h, pos);
+
+      if (opt.ntoalign + opt.size > buf.length - pos) {
+        if (
+          opt.opt !== "nop" &&
+          opt.opt !== "paddalign" &&
+          opt.opt !== "padding"
+        ) {
+          throw new LuaRuntimeError("data string too short", sf);
+        }
+      }
+
+      pos += opt.ntoalign; // skip alignment padding
+
+      switch (opt.opt) {
+        case "nop":
+        case "paddalign":
+          break;
+
+        case "padding":
+          pos += 1;
+          break;
+
+        case "int": {
+          const v = unpackInt(buf, pos, opt.size, h.islittle, true);
+          const n = Number(v);
+          results.push(Number.isSafeInteger(n) ? n : v);
+          pos += opt.size;
+          break;
+        }
+
+        case "uint": {
+          const v = unpackInt(buf, pos, opt.size, h.islittle, false);
+          const n = Number(v);
+          results.push(Number.isSafeInteger(n) ? n : v);
+          pos += opt.size;
+          break;
+        }
+
+        case "float": {
+          results.push(unpackFloat32(buf, pos, h.islittle));
+          pos += 4;
+          break;
+        }
+
+        case "double":
+        case "number": {
+          results.push(unpackFloat64(buf, pos, h.islittle));
+          pos += 8;
+          break;
+        }
+
+        case "char": {
+          const s = String.fromCharCode(...buf.subarray(pos, pos + opt.size));
+          results.push(s);
+          pos += opt.size;
+          break;
+        }
+
+        case "string": {
+          const len = Number(unpackInt(buf, pos, opt.size, h.islittle, false));
+          if (len > buf.length - pos - opt.size) {
+            throw new LuaRuntimeError("data string too short", sf);
+          }
+          pos += opt.size;
+          const s = new TextDecoder().decode(buf.subarray(pos, pos + len));
+          results.push(s);
+          pos += len;
+          break;
+        }
+
+        case "zstr": {
+          let end = pos;
+          while (end < buf.length && buf[end] !== 0) end++;
+          if (end >= buf.length) {
+            throw new LuaRuntimeError("unfinished string for format 'z'", sf);
+          }
+          results.push(new TextDecoder().decode(buf.subarray(pos, end)));
+          pos = end + 1;
+          break;
+        }
+      }
+    }
+
+    results.push(pos + 1);
+    return new LuaMultiRes(results);
+  },
+);
+
+export const strPackSizeFn = new LuaBuiltinFunction((_sf, fmt: string) => {
+  const h = makeHeader();
+  let totalsize = 0;
+  let pos = 0;
+
+  while (pos < fmt.length) {
+    let opt: ParsedOption;
+    [opt, pos] = getDetails(fmt, pos, h, totalsize);
+
+    if (opt.opt === "string" || opt.opt === "zstr") {
+      throw new LuaRuntimeError("variable-length format", _sf);
+    }
+
+    totalsize += opt.ntoalign + opt.size;
+  }
+
+  return totalsize;
+});

package/client/space_lua/stdlib/table.ts

@@ -5,6 +5,7 @@ import {
   luaCall,
   type LuaEnv,
   luaEquals,
+  luaFormatNumber,
   luaGet,
   LuaMultiRes,
   LuaRuntimeError,
@@ -77,15 +78,14 @@ export const tableApi = new LuaTable({
           return v;
         }
         if (typeof v === "number") {
-          return String(v);
+          return luaFormatNumber(v);
         }
         if (isTaggedFloat(v)) {
-          return String(v.value);
+          return luaFormatNumber(v.value, "float");
         }
 
-        const ty = typeof v === "object" && v instanceof LuaTable
-          ? "table"
-          : typeof v;
+        const ty =
+          typeof v === "object" && v instanceof LuaTable ? "table" : typeof v;
         throw new LuaRuntimeError(
           `invalid value (${ty}) at index ${idx} in table for 'concat'`,
           sf,
@@ -204,6 +204,56 @@ export const tableApi = new LuaTable({
     },
   ),
 
+  /**
+   * Moves elements from table a1 into table a2 (defaults to a1).
+   * Equivalent to: `for i = f, e do a2[t+(i-f)] = a1[i] end`
+   * Handles overlapping ranges within the same table correctly.
+   * @param a1 - Source table.
+   * @param f - First source index (inclusive).
+   * @param e - Last source index (inclusive).
+   * @param t - Destination start index.
+   * @param a2 - Destination table (defaults to a1).
+   * @returns a2.
+   */
+  move: new LuaBuiltinFunction(
+    async (
+      sf,
+      a1: LuaTable | any[],
+      f: number,
+      e: number,
+      t: number,
+      a2?: LuaTable | any[],
+    ) => {
+      // a2 defaults to a1
+      if (a2 === undefined || a2 === null) {
+        a2 = a1;
+      }
+
+      // Empty range: nothing to do, return destination
+      if (e < f) {
+        return a2;
+      }
+
+      const count = e - f + 1;
+
+      // When source and destination overlap and destination is ahead of
+      // source then copy backwards to avoid clobbering unread values.
+      if (t > f && a2 === a1) {
+        for (let i = count - 1; i >= 0; i--) {
+          const v = await luaGet(a1, f + i, sf.astCtx ?? null, sf);
+          await luaSet(a2, t + i, v, sf);
+        }
+      } else {
+        for (let i = 0; i < count; i++) {
+          const v = await luaGet(a1, f + i, sf.astCtx ?? null, sf);
+          await luaSet(a2, t + i, v, sf);
+        }
+      }
+
+      return a2;
+    },
+  ),
+
   /**
    * Sorts a table.
    * @param tbl - The table to sort.
@@ -215,7 +265,7 @@ export const tableApi = new LuaTable({
       if (Array.isArray(tbl)) {
         return await asyncQuickSort(tbl, async (a, b) => {
           if (comp) {
-            return (await comp.call(sf, a, b)) ? -1 : 1;
+            return (await comp.call(sf, a, b)) ? -1 : 0;
           }
           return (a as any) < (b as any) ? -1 : 1;
         });
@@ -235,7 +285,7 @@ export const tableApi = new LuaTable({
       const cmp = async (a: any, b: any): Promise<number> => {
         if (comp) {
           const r = await luaCall(comp, [a, b], sf.astCtx ?? {}, sf);
-          return r ? -1 : 1;
+          return r ? -1 : 0;
         }
 
         const av = isTaggedFloat(a) ? a.value : a;
@@ -250,10 +300,7 @@ export const tableApi = new LuaTable({
 
         const ta = typeof av;
         const tb = typeof bv;
-        throw new LuaRuntimeError(
-          `attempt to compare ${ta} with ${tb}`,
-          sf,
-        );
+        throw new LuaRuntimeError(`attempt to compare ${ta} with ${tb}`, sf);
       };
 
       const sorted = await asyncQuickSort(values, cmp);
@@ -338,24 +385,37 @@ export const tableApi = new LuaTable({
     },
   ),
 
-  pack: new LuaBuiltinFunction((_sf, ...args: any[]) => {
+  /**
+   * Returns a new table with all arguments stored in keys 1, 2, ..., n
+   * and t.n = n (the total number of arguments).
+   */
+  pack: new LuaBuiltinFunction(async (sf, ...args: any[]) => {
     const tbl = new LuaTable();
-    for (let i = 0; i < args.length; i++) {
-      tbl.set(i + 1, args[i]);
+    const n = args.length;
+    for (let i = 0; i < n; i++) {
+      await luaSet(tbl, i + 1, args[i], sf);
     }
-    tbl.set("n", args.length);
+    void tbl.rawSet("n", n);
     return tbl;
   }),
 
+  /**
+   * Returns all values t[i], t[i+1], ..., t[j].
+   * i defaults to 1, j defaults to #t (honours __len).
+   * Empty range returns no values (null), not an empty multi-res.
+   */
   unpack: new LuaBuiltinFunction(
     async (sf, tbl: LuaTable | any[], i?: number, j?: number) => {
-      i = i ?? 1;
+      i = i === undefined || i === null ? 1 : i;
       if (j === undefined || j === null) {
         j = Array.isArray(tbl)
           ? tbl.length
           : await luaLenForTableLibAsync(sf, tbl);
       }
 
+      if (i > j) {
+        return new LuaMultiRes([]);
+      }
       const result: LuaValue[] = [];
       for (let k = i; k <= j; k++) {
         const v = Array.isArray(tbl)