@silverbulletmd/silverbullet 2.4.1 → 2.5.3

package/plug-api/constants.ts

@@ -8,35 +8,3 @@ export const wrongSpacePathError: Error = new Error(
 );
 export const pingTimeout: number = 2000;
 export const pingInterval: number = 5000;
-
-/**
- * HTTP status codes that should be treated as "offline" conditions.
- *
- * This is particularly useful for cases where a proxy (such as Cloudflare or other reverse proxies)
- * indicates that the backend server is down, but there is still network connectivity between
- * the user and the proxy. In these scenarios, we want to allow the user to continue working
- * with their cached data rather than showing an error, even though technically there is network
- * connectivity to the proxy.
- *
- * This enables SilverBullet to work in a true "offline-first" manner, falling back to cached
- * content when the backend is unavailable through no fault of the user's network connection.
- *
- * All 5xx server errors are included to prevent the client from caching error HTML pages
- * (e.g., Nginx 500 error pages) which would prevent the client from booting in offline mode.
- */
-export const offlineStatusCodes = {
-  500: "Internal Server Error", // Server encountered an unexpected condition
-  501: "Not Implemented", // Server does not support the functionality required
-  502: "Bad Gateway", // Proxy server received invalid response from upstream server
-  503: "Service Unavailable", // Server is temporarily unable to handle the request
-  504: "Gateway Timeout", // Proxy server did not receive a timely response from upstream server
-  505: "HTTP Version Not Supported", // Server does not support the HTTP version
-  506: "Variant Also Negotiates", // Server has an internal configuration error
-  507: "Insufficient Storage", // Server is unable to store the representation
-  508: "Loop Detected", // Server detected an infinite loop while processing
-  509: "Bandwidth Limit Exceeded", // Server bandwidth limit has been exceeded
-  510: "Not Extended", // Further extensions to the request are required
-  511: "Network Authentication Required", // Client needs to authenticate to gain network access
-
-  530: "Unable to resolve origin hostname", // Served when cloudflared is down on the host
-} as const;

package/plug-api/lib/async.ts

@@ -1,6 +1,6 @@
 export function throttle(func: () => void, limit: number): () => void {
   let timer: any = null;
-  return function () {
+  return () => {
     if (!timer) {
       timer = setTimeout(() => {
         func();
@@ -15,7 +15,7 @@ export function throttleImmediately(
   limit: number,
 ): () => void {
   let timer: any = null;
-  return function () {
+  return () => {
     if (!timer) {
       func();
       timer = setTimeout(() => {

package/plug-api/lib/crypto.ts

@@ -85,7 +85,7 @@ export async function encryptStringDeterministic(
   key: CryptoKey,
   clearText: string,
 ): Promise<string> {
-  const encrypted = await crypto.subtle.encrypt(
+  const encrypted = await globalThis.crypto.subtle.encrypt(
     { name: "AES-CTR", counter: fixedCounter, length: fixedCounter.length * 8 },
     key,
     new TextEncoder().encode(clearText),
@@ -97,7 +97,7 @@ export async function decryptStringDeterministic(
   key: CryptoKey,
   cipherText: string,
 ): Promise<string> {
-  const decrypted = await crypto.subtle.decrypt(
+  const decrypted = await globalThis.crypto.subtle.decrypt(
     { name: "AES-CTR", counter: fixedCounter, length: fixedCounter.length * 8 },
     key,
     base64Decode(cipherText) as BufferSource,
@@ -110,8 +110,8 @@ export async function encryptAesGcm(
   key: CryptoKey,
   data: Uint8Array,
 ): Promise<Uint8Array> {
-  const iv = crypto.getRandomValues(new Uint8Array(12)); // 96-bit IV recommended for GCM
-  const encryptedBuffer = await crypto.subtle.encrypt(
+  const iv = globalThis.crypto.getRandomValues(new Uint8Array(12)); // 96-bit IV recommended for GCM
+  const encryptedBuffer = await globalThis.crypto.subtle.encrypt(
     { name: "AES-GCM", iv },
     key,
     data as BufferSource,
@@ -132,7 +132,7 @@ export async function decryptAesGcm(
 ): Promise<Uint8Array> {
   const iv = encryptedData.slice(0, 12); // extract IV (first 12 bytes)
   const ciphertext = encryptedData.slice(12);
-  const decryptedBuffer = await crypto.subtle.decrypt(
+  const decryptedBuffer = await globalThis.crypto.subtle.decrypt(
     { name: "AES-GCM", iv },
     key,
     ciphertext,
@@ -148,7 +148,7 @@ export async function deriveCTRKeyFromPassword(
   const passwordBytes = new TextEncoder().encode(password);
 
   // Import password as a CryptoKey
-  const baseKey = await crypto.subtle.importKey(
+  const baseKey = await globalThis.crypto.subtle.importKey(
     "raw",
     passwordBytes,
     { name: "PBKDF2" },
@@ -156,7 +156,7 @@ export async function deriveCTRKeyFromPassword(
     ["deriveBits", "deriveKey"],
   );
 
-  return crypto.subtle.deriveKey(
+  return globalThis.crypto.subtle.deriveKey(
     {
       name: "PBKDF2",
       salt: salt as BufferSource,
@@ -174,7 +174,7 @@ export async function deriveCTRKeyFromPassword(
 }
 
 export function importKey(b64EncodedKey: string): Promise<CryptoKey> {
-  return crypto.subtle.importKey(
+  return globalThis.crypto.subtle.importKey(
     "raw",
     base64Decode(b64EncodedKey) as BufferSource,
     { name: "AES-CTR" },
@@ -184,15 +184,15 @@ export function importKey(b64EncodedKey: string): Promise<CryptoKey> {
 }
 
 export async function exportKey(ctrKey: CryptoKey): Promise<string> {
-  const key = await crypto.subtle.exportKey("raw", ctrKey);
+  const key = await globalThis.crypto.subtle.exportKey("raw", ctrKey);
   return base64Encode(new Uint8Array(key));
 }
 
 export async function deriveGCMKeyFromCTR(
   ctrKey: CryptoKey,
 ): Promise<CryptoKey> {
-  const rawKey = await crypto.subtle.exportKey("raw", ctrKey);
-  return crypto.subtle.importKey(
+  const rawKey = await globalThis.crypto.subtle.exportKey("raw", ctrKey);
+  return globalThis.crypto.subtle.importKey(
     "raw",
     rawKey,
     { name: "AES-GCM" },

package/plug-api/lib/json.ts

@@ -125,7 +125,7 @@ export function deepClone<T>(obj: T, ignoreKeys: string[] = []): T {
     for (const key in obj) {
       if (ignoreKeys.includes(key)) {
         objClone[key] = obj[key];
-      } else if (Object.prototype.hasOwnProperty.call(obj, key)) {
+      } else if (Object.hasOwn(obj, key)) {
         objClone[key] = deepClone(obj[key], ignoreKeys);
       }
     }

package/plug-api/lib/limited_map.ts

@@ -1,7 +1,7 @@
 type LimitedMapRecord<V> = {
   value: V;
   la: number;
-  expTimer?: number;
+  expTimer?: ReturnType<typeof setTimeout>;
 };
 
 export class LimitedMap<V> {

package/plug-api/lib/native_fetch.ts

@@ -1,3 +1,5 @@
+export {};
+
 declare global {
   function nativeFetch(
     input: RequestInfo | URL,

package/plug-api/lib/ref.ts

@@ -87,7 +87,7 @@ export function isValidName(name: string): boolean {
 export function isValidPath(path: string): path is Path {
   const ref = parseToRef(path);
 
-  return !!ref && ref.path === path;
+  return !!ref && ref.path === path && path !== "";
 }
 
 /**
@@ -95,7 +95,7 @@ export function isValidPath(path: string): path is Path {
  * TO THE INNER WORKINGS OF SILVERBULLET AND CHANGES COULD INTRODUCE MAJOR BUGS
  */
 const refRegex =
-  /^(?<meta>\^)?(?<path>(?!.*\.[a-zA-Z0-9]+\.md$)(?!\/?(\.|\^))(?!.*(?:\/|^)\.{1,2}(?:\/|$)|.*\/{2})(?!.*(?:\]\]|\[\[))[^@#\|<>]*)(@(?<pos>\d+)|@[Ll](?<line>\d+)(?:[Cc](?<col>\d+))?|#\s*(?<header>.*))?$/;
+  /^(?<meta>\^)?(?<path>(?!.*\.[a-zA-Z0-9]+\.md$)(?!\/?(\.|\^))(?!.*(?:\/|^)\.{1,2}(?:\/|$)|.*\/{2})(?!.*(?:\]\]|\[\[))[^@#|<>]*)(@(?<pos>\d+)|@[Ll](?<line>\d+)(?:[Cc](?<col>\d+))?|#\s*(?<header>.*))?$/;
 
 /**
  * Parses a reference string into a ref object.
@@ -118,13 +118,13 @@ export function parseToRef(stringRef: string): Ref | null {
   if (groups.pos !== undefined) {
     ref.details = {
       type: "position",
-      pos: parseInt(groups.pos),
+      pos: parseInt(groups.pos, 10),
     };
   } else if (groups.line !== undefined) {
     ref.details = {
       type: "linecolumn",
-      line: parseInt(groups.line),
-      column: groups.col !== undefined ? parseInt(groups.col) : 1,
+      line: parseInt(groups.line, 10),
+      column: groups.col !== undefined ? parseInt(groups.col, 10) : 1,
     };
   } else if (groups.header !== undefined) {
     ref.details = {

package/plug-api/lib/transclusion.ts

@@ -45,19 +45,19 @@ export function parseDimensionFromAlias(
     const [width, height] = dimPart.split("x");
     dim = {};
     if (width) {
-      dim.width = parseInt(width);
+      dim.width = parseInt(width, 10);
     }
     if (height) {
-      dim.height = parseInt(height);
+      dim.height = parseInt(height, 10);
     }
   } else if (/^[x\d]/.test(text)) {
     const [width, height] = text.split("x");
     dim = {};
     if (width) {
-      dim.width = parseInt(width);
+      dim.width = parseInt(width, 10);
     }
     if (height) {
-      dim.height = parseInt(height);
+      dim.height = parseInt(height, 10);
     }
     alias = "";
   } else {
@@ -74,7 +74,7 @@ export function parseDimensionFromAlias(
 export function parseTransclusion(
   text: string,
 ): Transclusion | null {
-  let url, alias = undefined;
+  let url, alias ;
   let linktype: LinkType = "markdownlink";
   // TODO: Take in the tree and use tree nodes to get url and alias (Applies to all regex uses)
   mdLinkRegex.lastIndex = 0;

package/plug-api/lib/tree.ts

@@ -91,7 +91,7 @@ export function replaceNodesMatching(
   tree: ParseTree,
   substituteFn: (tree: ParseTree) => ParseTree | null | undefined,
 ) {
-  if (tree && tree.children) {
+  if (tree?.children) {
     const children = tree.children.slice();
     for (const child of children) {
       const subst = substituteFn(child);
@@ -182,7 +182,8 @@ export function nodeAtPos(tree: ParseTree, pos: number): ParseTree | null {
     if (n && n.text !== undefined) {
       // Got a text node, let's return its parent
       return tree;
-    } else if (n) {
+    }
+    if (n) {
       // Got it
       return n;
     }
@@ -190,6 +191,53 @@ export function nodeAtPos(tree: ParseTree, pos: number): ParseTree | null {
   return null;
 }
 
+// Ensure a TableRow/TableHeader has a TableCell between every pair of
+// TableDelimiters, and optionally pad to match columnCount.
+// headerHasLeadingDelim indicates whether the header starts with a delimiter.
+export function normalizeTableRow(
+  row: ParseTree,
+  columnCount?: number,
+  headerHasLeadingDelim?: boolean,
+): void {
+  const children = row.children;
+  if (!children) return;
+  const normalized: ParseTree[] = [];
+  let lookingForCell = false;
+  for (const child of children) {
+    if (child.type === "TableDelimiter" && lookingForCell) {
+      normalized.push({ type: "TableCell", children: [] });
+    }
+    if (child.type === "TableDelimiter") {
+      lookingForCell = true;
+    }
+    if (child.type === "TableCell") {
+      lookingForCell = false;
+    }
+    normalized.push(child);
+  }
+  row.children = normalized;
+
+  // Fix leading-pipe mismatch: row has leading delimiter but header doesn't
+  if (headerHasLeadingDelim === false) {
+    if (row.children.length > 0 && row.children[0].type === "TableDelimiter") {
+      // Insert empty cell after the leading delimiter
+      row.children.splice(1, 0, { type: "TableCell", children: [] });
+    }
+  }
+
+  // Pad trailing empty cells to match header column count
+  if (columnCount !== undefined) {
+    let cellCount = 0;
+    for (const child of row.children) {
+      if (child.type === "TableCell") cellCount++;
+    }
+    while (cellCount < columnCount) {
+      row.children.push({ type: "TableCell", children: [] });
+      cellCount++;
+    }
+  }
+}
+
 // Turn ParseTree back into text
 export function renderToText(tree?: ParseTree): string {
   if (!tree) {

package/plug-api/lib/yaml.ts

@@ -44,7 +44,7 @@ function serializeToYamlValue(
       return "[]"; // Use flow style for empty arrays for simplicity
     }
     // Determine indentation for list items (base + 2 spaces)
-    const itemIndentation = baseIndentation + "  ";
+    const itemIndentation = `${baseIndentation}  `;
     // Format each item recursively, preceded by '- ' marker
     return "\n" +
       value.map((item) =>
@@ -55,7 +55,7 @@ function serializeToYamlValue(
   } else if (typeof value === "object" && value !== null) {
     // Basic object serialization (not requested, but good to consider)
     // This is highly simplified and doesn't handle nesting well without more context
-    const itemIndentation = baseIndentation + "  ";
+    const itemIndentation = `${baseIndentation}  `;
     const entries = Object.entries(value);
     if (entries.length === 0) return "{}"; // Flow style empty objects
     return "\n" +
@@ -89,7 +89,7 @@ export function applyPatches(
       for (let i = 0; i < lines.length; i++) {
         const line = lines[i];
         const trimmedLine = line.trim();
-        if (trimmedLine.startsWith(key + ":")) {
+        if (trimmedLine.startsWith(`${key}:`)) {
           keyLineIndex = i;
           startDeleteIndex = i;
           endDeleteIndex = i;
@@ -203,7 +203,7 @@ export function applyPatches(
     for (let i = 0; i < lines.length; i++) {
       const line = lines[i];
       const trimmedLine = line.trim();
-      if (trimmedLine.startsWith(key + ":")) {
+      if (trimmedLine.startsWith(`${key}:`)) {
         keyLineIndex = i;
         // Extract inline comment if present
         const commentMatch = line.match(/#.*$/);
@@ -214,7 +214,7 @@ export function applyPatches(
         for (let j = i - 1; j >= 0; j--) {
           const prevLine = lines[j].trim();
           if (prevLine.startsWith("#")) {
-            commentBlock = lines[j] + "\n" + commentBlock;
+            commentBlock = `${lines[j]}\n${commentBlock}`;
           } else if (prevLine !== "") {
             break;
           }
@@ -223,7 +223,7 @@ export function applyPatches(
         for (let j = i + 1; j < lines.length; j++) {
           const nextLine = lines[j].trim();
           if (nextLine.startsWith("#")) {
-            trailingComments += lines[j] + "\n";
+            trailingComments += `${lines[j]}\n`;
           } else if (nextLine !== "") {
             break;
           }
@@ -243,7 +243,7 @@ export function applyPatches(
     } else {
       // For scalars, format as key: value
       replacementLine = `${key}: ${serializedNewValue}${
-        inlineComment ? " " + inlineComment : ""
+        inlineComment ? ` ${inlineComment}` : ""
       }`;
     }
 
@@ -267,14 +267,14 @@ export function applyPatches(
       ];
 
       // Join lines and ensure proper newlines
-      currentYaml = newContent.join("\n").replace(/\n*$/, "\n") + "\n";
+      currentYaml = `${newContent.join("\n").replace(/\n*$/, "\n")}\n`;
     } else {
       // Key not found: Add the new key-value pair to the end
       const newLineBlock = replacementLine;
       if (currentYaml.trim() === "") {
-        currentYaml = newLineBlock + "\n";
+        currentYaml = `${newLineBlock}\n`;
       } else {
-        currentYaml = currentYaml.replace(/\n*$/, "\n") + newLineBlock + "\n";
+        currentYaml = `${currentYaml.replace(/\n*$/, "\n") + newLineBlock}\n`;
       }
     }
   }

package/plug-api/syscalls/editor.ts

@@ -249,7 +249,7 @@ export function filterBox(
 export function showPanel(
   id: "lhs" | "rhs" | "bhs" | "modal",
   mode: number,
-  html: string,
+  html: HTMLElement | HTMLElement[] | string,
   script = "",
 ): Promise<void> {
   return syscall("editor.showPanel", id, mode, html, script);

package/plug-api/system_mock.ts

@@ -71,7 +71,6 @@ export function createMockSystem() {
     systemSyscalls(clientMock, false),
   );
 
-  // @ts-ignore: global
   globalThis.syscall = (name: string, ...args: any): Promise<any> => {
     return system.localSyscall(name, args);
   };

package/client/plugos/sandboxes/deno_worker_sandbox.ts

@@ -1,6 +0,0 @@
-import { WorkerSandbox } from "./worker_sandbox.ts";
-import type { SandboxFactory } from "./sandbox.ts";
-
-export function createSandbox<HookT>(workerUrl: URL): SandboxFactory<HookT> {
-  return (plug) => new WorkerSandbox(plug, workerUrl);
-}